Re: [PATCH] staging: erofs: fix an error handling in erofs_readdir()
On Sun, Aug 18, 2019 at 09:25:04PM +0800, Gao Xiang wrote:
> On Sun, Aug 18, 2019 at 09:17:52PM +0800, kbuild test robot wrote:
> > Hi Gao,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on linus/master]
> > [cannot apply to v5.3-rc4 next-20190816]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
>
> ... those patches should be applied to staging tree
> since linux-next has not been updated yet...
thanks for the feedback, we will consider this to our todo list.
>
> Thanks,
> Gao Xiang
>
> >
> > url:
> > https://github.com/0day-ci/linux/commits/Gao-Xiang/staging-erofs-fix-an-error-handling-in-erofs_readdir/20190818-191344
> > config: arm64-allyesconfig (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 7.4.0
> > reproduce:
> > wget
> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> > ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > GCC_VERSION=7.4.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot
> >
> > All errors (new ones prefixed by >>):
> >
> >drivers/staging/erofs/dir.c: In function 'erofs_readdir':
> > >> drivers/staging/erofs/dir.c:110:11: error: 'EFSCORRUPTED' undeclared
> > >> (first use in this function); did you mean 'FS_NRSUPER'?
> >err = -EFSCORRUPTED;
> > ^~~~
> > FS_NRSUPER
> >drivers/staging/erofs/dir.c:110:11: note: each undeclared identifier is
> > reported only once for each function it appears in
> >
> > vim +110 drivers/staging/erofs/dir.c
> >
> > 85
> > 86 static int erofs_readdir(struct file *f, struct dir_context
> > *ctx)
> > 87 {
> > 88 struct inode *dir = file_inode(f);
> > 89 struct address_space *mapping = dir->i_mapping;
> > 90 const size_t dirsize = i_size_read(dir);
> > 91 unsigned int i = ctx->pos / EROFS_BLKSIZ;
> > 92 unsigned int ofs = ctx->pos % EROFS_BLKSIZ;
> > 93 int err = 0;
> > 94 bool initial = true;
> > 95
> > 96 while (ctx->pos < dirsize) {
> > 97 struct page *dentry_page;
> > 98 struct erofs_dirent *de;
> > 99 unsigned int nameoff, maxsize;
> >100
> >101 dentry_page = read_mapping_page(mapping, i,
> > NULL);
> >102 if (dentry_page == ERR_PTR(-ENOMEM)) {
> >103 errln("no memory to readdir of logical
> > block %u of nid %llu",
> >104i, EROFS_V(dir)->nid);
> >105 err = -ENOMEM;
> >106 break;
> >107 } else if (IS_ERR(dentry_page)) {
> >108 errln("fail to readdir of logical block
> > %u of nid %llu",
> >109i, EROFS_V(dir)->nid);
> > > 110 err = -EFSCORRUPTED;
> >111 break;
> >112 }
> >113
> >114 de = (struct erofs_dirent *)kmap(dentry_page);
> >115
> >116 nameoff = le16_to_cpu(de->nameoff);
> >117
> >118 if (unlikely(nameoff < sizeof(struct
> > erofs_dirent) ||
> >119 nameoff >= PAGE_SIZE)) {
> >120 errln("%s, invalid de[0].nameoff %u",
> >121__func__, nameoff);
> >122
> >123 err = -EIO;
> >124 goto skip_this;
> >125 }
> >126
> >127 maxsize = min_t(unsigned int,
> >128 dirsize - ctx->pos + ofs,
> > PAGE_SIZE);
> >129
> >130 /* search dirents at the arbitrary position */
> >131 if (unlikely(initial)) {
> >132 initial = false;
> >133
> >134 ofs = roundup(ofs, sizeof(struct
> > erofs_dirent));
> >135 if (unlikely(ofs >= nameoff))
> >136 goto skip_this;
> >137 }
> >138
> >139 err = erofs_fill_dentries(ctx, de, &ofs,
> > nameoff, maxsize);
> >140 skip_this:
> >141 kunmap(dentry_page);
> >142
> >143 put_page(dentry_page);
> >144
> >145 c
[0-Day CI notification] 0-Day kernel test service will be shut down from Sep 30 3PM to Oct 5
Hi all, this is Philip who maintains the 0-Day kernel test service. Thanks for subscribing to 0-Day kernel testing. We will have lab power down from Oct 1 to Oct 5, so that the service will be shut down from Asia Pacific Time Sep 30 3PM and will recover from Oct 6 as soon as we can. Sorry for any inconvenience caused due to the service shut down. Thanks ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > staging-testing
> > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media:
> > hantro: remove parentheses
> > reproduce:
> > # apt-get install sparse
> > # sparse version:
> > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined
> > >> twice
> >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > --
> > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined
> > >> twice
> >drivers/scsi/sr.c:691:10: sparse: also defined here
> > --
> > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry
> > >> defined twice
> >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > --
> > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai'
> > >> was not declared. Should it be static?
> > --
> > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > >> 'nft_pipapo_get' was not declared. Should it be static?
> >
> > vim +362 drivers/ide/ide-gd.c
> >
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const
> > struct block_device_operations ide_gd_ops = {
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
> > = THIS_MODULE,
> > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
> > = ide_gd_unlocked_open,
> > b2f21e057dfbaa Al Viro 2008-10-16 361.release
> > = ide_gd_release,
> > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
> > = ide_gd_ioctl,
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > CONFIG_COMPAT
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
> > = ide_gd_compat_ioctl,
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
> > = ide_gd_getgeo,
> > 5b03a1b140e13a Tejun Heo 2011-03-09 367.check_events
> > = ide_gd_check_events,
> > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > .revalidate_disk= ide_gd_revalidate_disk
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> >
> > :: The code at line 362 was first introduced by commit
> > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into
> > .locked_ioctl
>
> Why is 0-day starting to spit out sparse warnings for things that have
> nothing to do with the specific patch, or tree?
thanks for the input, Greg, we will check this to avoid
false positive.
>
> False-positive errors are the worst, please fix.
>
> greg k-h
> ___
> kbuild-all mailing list -- kbuild-...@lists.01.org
> To unsubscribe send an email to kbuild-all-le...@lists.01.org
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:17:40AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> > On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > > tree:
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > > staging-testing
> > > > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging:
> > > > media: hantro: remove parentheses
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version:
> > > > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > make ARCH=x86_64 allmodconfig
> > > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > > >
> > > > If you fix the issue, kindly add following tag
> > > > Reported-by: kbuild test robot
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry
> > > > >> defined twice
> > > >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > > > --
> > > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined
> > > > >> twice
> > > >drivers/scsi/sr.c:691:10: sparse: also defined here
> > > > --
> > > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer
> > > > >> entry defined twice
> > > >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > > > --
> > > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > > > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol
> > > > >> 'rt1015_dai' was not declared. Should it be static?
> > > > --
> > > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > > > >> 'nft_pipapo_get' was not declared. Should it be static?
> > > >
> > > > vim +362 drivers/ide/ide-gd.c
> > > >
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > > > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const
> > > > struct block_device_operations ide_gd_ops = {
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
> > > > = THIS_MODULE,
> > > > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
> > > > = ide_gd_unlocked_open,
> > > > b2f21e057dfbaa Al Viro 2008-10-16 361
> > > > .release= ide_gd_release,
> > > > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
> > > > = ide_gd_ioctl,
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > > > CONFIG_COMPAT
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
> > > > = ide_gd_compat_ioctl,
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
> > > > = ide_gd_getgeo,
> > > > 5b03a1b140e13a Tejun Heo 2011-03-09 367
> > > > .check_events = ide_gd_check_events,
> > > > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > > > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > > > .revalidate_disk= ide_gd_revalidate_disk
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> > > >
> > > > :: The code at line 362 was first introduced by commit
> > > > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL
> > > > into .locked_ioctl
> > >
> > > Why is 0-day starting to spit out sparse warnings for things that have
> > > nothing to do with the specific patch, or tree?
> > thanks for the input, Greg, we will check this to avoid
> > false positive.
>
> This was not the only false-positive report I got this morning, so
> something went wrong on your end that started spitting out new ones :(
sorry for the noise, we will go through the reports sent to you in recent
days to check. If it is handy for you to fwd me the "wrong" mail, it
can also help me address the problem.
One issue relates to "ERROR: modpost: "sysrq_mask"
[drivers/tty/serial/serial_core.ko] undefined"
is caused by modpost logging interface change, we had disabled this
build false positive yestesday, and we will look for a solution for this soon.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:53:07AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 18, 2020 at 02:42:31PM +0800, Philip Li wrote:
> > On Wed, Mar 18, 2020 at 07:17:40AM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> > > > On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > > > > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > > > > tree:
> > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > > > > staging-testing
> > > > > > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging:
> > > > > > media: hantro: remove parentheses
> > > > > > reproduce:
> > > > > > # apt-get install sparse
> > > > > > # sparse version:
> > > > > > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > > > make ARCH=x86_64 allmodconfig
> > > > > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > > > > >
> > > > > > If you fix the issue, kindly add following tag
> > > > > > Reported-by: kbuild test robot
> > > > > >
> > > > > > All warnings (new ones prefixed by >>):
> > > > > >
> > > > > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry
> > > > > > >> defined twice
> > > > > >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > > > > > --
> > > > > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry
> > > > > > >> defined twice
> > > > > >drivers/scsi/sr.c:691:10: sparse: also defined here
> > > > > > --
> > > > > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer
> > > > > > >> entry defined twice
> > > > > >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > > > > > --
> > > > > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > > > > > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > > > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol
> > > > > > >> 'rt1015_dai' was not declared. Should it be static?
> > > > > > --
> > > > > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > > > > > >> 'nft_pipapo_get' was not declared. Should it be static?
> > > > > >
> > > > > > vim +362 drivers/ide/ide-gd.c
> > > > > >
> > > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > > > > > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static
> > > > > > const struct block_device_operations ide_gd_ops = {
> > > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
> > > > > > = THIS_MODULE,
> > > > > > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
> > > > > > = ide_gd_unlocked_open,
> > > > > > b2f21e057dfbaa Al Viro 2008-10-16 361
> > > > > > .release= ide_gd_release,
> > > > > > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
> > > > > > = ide_gd_ioctl,
> > > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > > > > > CONFIG_COMPAT
> > > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
> > > > > > = ide_gd_compat_ioctl,
> > > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
> > > > > > = ide_gd_getgeo,
> > > > > > 5b03a1b140e13a Tejun Heo 2011-03-09 367
> > > > > > .check_events = ide_gd_check_events,
> > > > > > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > > > &
Re: [kbuild-all] Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management
On Mon, Jun 29, 2020 at 12:31:16PM -0500, Bjorn Helgaas wrote: > Vaibhav: s/genric/generic/ in the subject > > On Tue, Jun 30, 2020 at 12:09:36AM +0800, kernel test robot wrote: > > Hi Vaibhav, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v5.8-rc3 next-20200629] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: > > https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/drivers-staging-use-generic-power-management/20200629-163141 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > 347fa58ff5558075eec98725029c443c80ffbf4a > > config: x86_64-rhel-7.6 (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 > > reproduce (this is a W=1 build): > > # save the attached .config to linux build tree > > make W=1 ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > If the patch has already been merged and we need an incremental patch > that fixes *only* the build issue, I think it's fine to add a > "Reported-by" tag. > > But if this patch hasn't been merged anywhere, I think adding the > "Reported-by" tag would be pointless and distracting. This report > should result in a v2 posting of the patch with the build issue fixed. > > There will be no evidence of the problem in the v2 patch. The patch > itself contains other changes unrelated to the build issue, so > "Reported-by" makes so sense for them. I would treat this as just > another review comment, and we don't usually credit those in the > commit log (though it's nice if they're mentioned in the v2 cover > letter so reviewers know what changed and why). > > Is there any chance kbuild could be made smart enough to suggest the > tag only when it finds an issue in some list of published trees? Thanks a lot for the suggestion. As of now, this is a recommendation, and user may judge based on own situation to add "as appropriate". Meanwhile, we will continue making the bot better. > > > All errors (new ones prefixed by >>): > > > >drivers/staging/qlge/qlge_main.c: In function 'qlge_resume': > > >> drivers/staging/qlge/qlge_main.c:4793:17: error: 'pdev' undeclared > > >> (first use in this function); did you mean 'qdev'? > > 4793 | pci_set_master(pdev); > > | ^~~~ > > | qdev > > ... > ___ > kbuild-all mailing list -- kbuild-...@lists.01.org > To unsubscribe send an email to kbuild-all-le...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
