Re: [PATCH 1/5] staging:iio:hmc5843: Added regmap support
> >> > This patch changes hmc5843.c to use regmap. This provides > >transparent caching > >> > to the code as well as abstraction necessary to add support for > >SPI-based > >> > hmc5983. > >> > > >> > Signed-off-by: Josef Gajdusek > >> Hi Josef, > >> > >> A few little bits and pieces inline. > >> Peter, could you also take a look at this series? I might manage to test the proposed code on a hmc5883l, probably until the weekend; otherwise patches look good > >strange, I remember this causing issues. Now I am unable to > >reproduce them so it was probably something else. Do you want me to > >resend or can you apply without these lines swapped? > > I am feeling lazy plus might not get to this until Saturday so resend. -- Peter Meerwald +43-664-218 (mobile) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Anybody working on tidspbridge?
Hello, > > Given the total lack of response here, I suggest just deleting the > > driver. No one has ever done the "real work" that is going to be > > required to get this code out of staging. It has had build errors > > causing it to not even be usable for some kernel versions with no one > > noticing, so I doubt anyone cares about it anymore here. > > Cc'ing some more people who might be interested. If no one offers to > work on the driver in the next couple of days, I'll send a patch to > remove it. I'm using the driver (with kernel 3.7) and it works reasonably well for me; removing it seems a bit harsh regards, p. -- Peter Meerwald +43-664-218 (mobile) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: iio: adc: add missing spaces around minus sign
> The checkpatch.pl tool detected coding style problem: > > CHECK: spaces preferred around that '-' (ctx:VxV) oh no, not again please see e.g. https://lore.kernel.org/patchwork/patch/635994/ for some discussion why this patch doesn't make sense > in two files inside the adc directory. This patch will remove this > problem. > > Signed-off-by: Slawomir Stepien > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c > b/drivers/staging/iio/adc/ad7192.c > index acdbc07fd259..7c632cf1932b 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > } > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > - in_voltage-voltage_scale_available, > + in_voltage - voltage_scale_available, >0444, ad7192_show_scale_available, NULL, 0); > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, > diff --git a/drivers/staging/iio/adc/ad7280a.c > b/drivers/staging/iio/adc/ad7280a.c > index 58420dcb406d..a4b4f8678c56 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void > *private) > } > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > - in_voltage-voltage_thresh_low_value, > + in_voltage - voltage_thresh_low_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, > AD7280A_CELL_UNDERVOLTAGE); > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > - in_voltage-voltage_thresh_high_value, > + in_voltage - voltage_thresh_high_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, > -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros
> Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> macros to create the device attributes.
great that you work on cleaning this up!
the patch does a bit more than is claimed, it also renames stuff;
eventually, a proper prefix ('tsl2583_') should be used...
maybe you can unify the two files in this patch series?
./staging/iio/Documentation/sysfs-bus-iio-light-tsl2583
./staging/iio/Documentation/light/sysfs-bus-iio-light-tsl2583
Suggested-by: Peter Meerwald-Stadler
:-)
> Signed-off-by: Brian Masney
> ---
> drivers/staging/iio/light/tsl2583.c | 117
> ++--
> 1 file changed, 57 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2583.c
> b/drivers/staging/iio/light/tsl2583.c
> index 8448a87..bbb8fc3 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -501,8 +501,8 @@ static int taos_chip_off(struct iio_dev *indio_dev)
>
> /* Sysfs Interface Functions */
>
> -static ssize_t taos_power_state_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> +static ssize_t power_state_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct tsl2583_chip *chip = iio_priv(indio_dev);
> @@ -510,9 +510,9 @@ static ssize_t taos_power_state_show(struct device *dev,
> return sprintf(buf, "%d\n", chip->taos_chip_status);
> }
>
> -static ssize_t taos_power_state_store(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf, size_t len)
> +static ssize_t power_state_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> int value;
> @@ -528,8 +528,9 @@ static ssize_t taos_power_state_store(struct device *dev,
> return len;
> }
>
> -static ssize_t taos_gain_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> +static ssize_t illuminance0_calibscale_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct tsl2583_chip *chip = iio_priv(indio_dev);
> @@ -553,9 +554,9 @@ static ssize_t taos_gain_show(struct device *dev,
> return sprintf(buf, "%s\n", gain);
> }
>
> -static ssize_t taos_gain_store(struct device *dev,
> -struct device_attribute *attr,
> -const char *buf, size_t len)
> +static ssize_t illuminance0_calibscale_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct tsl2583_chip *chip = iio_priv(indio_dev);
> @@ -587,15 +588,16 @@ gain_store_done:
> return ret;
> }
>
> -static ssize_t taos_gain_available_show(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> +static ssize_t illuminance0_calibscale_available_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> {
> return sprintf(buf, "%s\n", "1 8 16 111");
> }
>
> -static ssize_t taos_als_time_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> +static ssize_t illuminance0_integration_time_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct tsl2583_chip *chip = iio_priv(indio_dev);
> @@ -603,9 +605,9 @@ static ssize_t taos_als_time_show(struct device *dev,
> return sprintf(buf, "%d\n", chip->taos_settings.als_time);
> }
>
> -static ssize_t taos_als_time_store(struct device *dev,
> -struct device_attribute *attr,
> -const char *buf, size_t len)
> +static ssize_t illuminance0_integration_time_store(struct device *dev,
> +
