[PATCH] staging: rts5208: Fix checkpath warning

2019-08-30 Thread P SAI PRASANTH 
This patch fixes the following checkpath warning in the file 
drivers/staging/rts5208/rtsx_transport.c:546

WARNING: line over 80 characters
+   option = RTSX_SG_VALID | RTSX_SG_END |
RTSX_SG_TRANS_DATA;

Signed-off-by: P SAI PRASANTH 
---
 drivers/staging/rts5208/rtsx_transport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_transport.c 
b/drivers/staging/rts5208/rtsx_transport.c
index 8277d78..495fa60 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -542,7 +542,8 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip 
*chip, u8 card,
(unsigned int)addr, len);
 
if (j == (sg_cnt - 1))
-   option = RTSX_SG_VALID | RTSX_SG_END | 
RTSX_SG_TRANS_DATA;
+   option = RTSX_SG_VALID | RTSX_SG_END | 
+RTSX_SG_TRANS_DATA;
else
option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: rts5208: Fix checkpath warning

2019-08-30 Thread P SAI PRASANTH 
This patch fixes the following checkpath warning 
in the file drivers/staging/rts5208/rtsx_transport.c:546

WARNING: line over 80 characters
+   option = RTSX_SG_VALID | RTSX_SG_END |
RTSX_SG_TRANS_DATA;

Signed-off-by: P SAI PRASANTH 
---
Changes in v2:
 -restructured code for better fixing the checkpath warning
 -wrapped commit description

 drivers/staging/rts5208/rtsx_transport.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx_transport.c 
b/drivers/staging/rts5208/rtsx_transport.c
index 8277d78..48c782f 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip 
*chip, u8 card,
 
dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
(unsigned int)addr, len);
-
+
+   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
if (j == (sg_cnt - 1))
-   option = RTSX_SG_VALID | RTSX_SG_END | 
RTSX_SG_TRANS_DATA;
-   else
-   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
+   option |= RTSX_SG_END
 
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] staging: rts5208: Fix checkpath warning

2019-08-30 Thread P SAI PRASANTH 
This patch fixes the following checkpath warning
in the file drivers/staging/rts5208/rtsx_transport.c:546

WARNING: line over 80 characters
+   option = RTSX_SG_VALID | RTSX_SG_END |
RTSX_SG_TRANS_DATA;

Signed-off-by: P SAI PRASANTH 
---
Changes in v3:
 -Fixes the following error in da59abd45efc
  >> drivers/staging//rts5208/rtsx_transport.c:548:4: error: expected
 ';' before 'rtsx_add_sg_tbl'
   rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
   ^~~

 drivers/staging/rts5208/rtsx_transport.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx_transport.c 
b/drivers/staging/rts5208/rtsx_transport.c
index 8277d78..3c67656 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip 
*chip, u8 card,
 
dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
(unsigned int)addr, len);
-
+
+   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
if (j == (sg_cnt - 1))
-   option = RTSX_SG_VALID | RTSX_SG_END | 
RTSX_SG_TRANS_DATA;
-   else
-   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
+   option |= RTSX_SG_END;
 
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: rts5208: Fix checkpath warning

2019-08-30 Thread P Sai Prasanth 
On 19-08-30 19:58:09, Joe Perches wrote:
> On Sat, 2019-08-31 at 07:55 +0530, P SAI PRASANTH wrote:
> > This patch fixes the following checkpath warning
> > in the file drivers/staging/rts5208/rtsx_transport.c:546
> > 
> > WARNING: line over 80 characters
> > +   option = RTSX_SG_VALID | RTSX_SG_END |
> > RTSX_SG_TRANS_DATA;
> []
> > diff --git a/drivers/staging/rts5208/rtsx_transport.c 
> > b/drivers/staging/rts5208/rtsx_transport.c
> []
> > @@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip 
> > *chip, u8 card,
> >  
> > dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
> > (unsigned int)addr, len);
> > -
> > +
> 
> This same line delete then insert the same blank line
> is very unusual.
> 
> What did you use to create this patch?
> 
> > +   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> > if (j == (sg_cnt - 1))
> > -   option = RTSX_SG_VALID | RTSX_SG_END | 
> > RTSX_SG_TRANS_DATA;
> > -   else
> > -   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> > +   option |= RTSX_SG_END;
> >  
> > rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
> >  
>
I have used vim for creating this patch. Upon checking, there is an extra tab on
the new blankline which has been added. I'm sending an update immediately.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4] staging: rts5208: Fix checkpath warning

2019-08-30 Thread P SAI PRASANTH 
This patch fixes the following checkpath warning
in the file drivers/staging/rts5208/rtsx_transport.c:546

WARNING: line over 80 characters
+   option = RTSX_SG_VALID | RTSX_SG_END |
RTSX_SG_TRANS_DATA;

Signed-off-by: P SAI PRASANTH 
---
Changes in v4:
 -Fix extra tab issue which was causing same blank line to be added and removed
  in git diff.

 drivers/staging/rts5208/rtsx_transport.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx_transport.c 
b/drivers/staging/rts5208/rtsx_transport.c
index 8277d78..c1d99c4 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -541,10 +541,9 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip 
*chip, u8 card,
dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
(unsigned int)addr, len);
 
+   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
if (j == (sg_cnt - 1))
-   option = RTSX_SG_VALID | RTSX_SG_END | 
RTSX_SG_TRANS_DATA;
-   else
-   option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
+   option |= RTSX_SG_END;
 
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rts5208: Fix checkpath warning

2019-08-31 Thread P SAI PRASANTH 
This patch fixes the following checkpath warning
in file drivers/staging/rts5208/xd.c:1754

WARNING: line over 80 characters
+   index, offset, DMA_TO_DEVICE,
chip->xd_timeout);

Signed-off-by: P SAI PRASANTH 
---
 drivers/staging/rts5208/xd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index f3dc96a..e62eee3 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1751,7 +1751,8 @@ static int xd_write_multiple_pages(struct rtsx_chip 
*chip, u32 old_blk,
 
retval = rtsx_transfer_data_partial(chip, XD_CARD, buf, page_cnt * 512,
scsi_sg_count(chip->srb),
-   index, offset, DMA_TO_DEVICE, 
chip->xd_timeout);
+   index, offset,
+   DMA_TO_DEVICE, chip->xd_timeout);
if (retval < 0) {
rtsx_clear_xd_error(chip);
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel