[PATCH 3/3] drivers/fbtft: Fix indentation
Signed-off-by: Luis Gerhorst Acked-by: Jonny Schaefer Acked-by: Alexander Wuerstlein --- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 34b1c81..566f89c 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -1377,8 +1377,8 @@ int fbtft_probe_common(struct fbtft_display *display, par->fbtftops.write_register = fbtft_write_reg16_bus16; else dev_warn(dev, - "no default functions for regwidth=%d and buswidth=%d\n", - display->regwidth, display->buswidth); +"no default functions for regwidth=%d and buswidth=%d\n", +display->regwidth, display->buswidth); /* write_vmem() functions */ if (display->buswidth == 8) -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else
The Linux kernel coding style states that braces should only be used
when necessary.
This fixes the checkpatch warning
WARNING: line over 80 characters
+ } else if (display->regwidth == 8 && display->buswidth == 9 &&
par->spi) {
introduced by patch #1.
Signed-off-by: Luis Gerhorst
Acked-by: Jonny Schaefer
Acked-by: Alexander Wuerstlein
---
drivers/staging/fbtft/fbtft-core.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 66b46b2..34b1c81 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1367,19 +1367,18 @@ int fbtft_probe_common(struct fbtft_display *display,
}
/* write register functions */
- if (display->regwidth == 8 && display->buswidth == 8) {
+ if (display->regwidth == 8 && display->buswidth == 8)
par->fbtftops.write_register = fbtft_write_reg8_bus8;
- } else if (display->regwidth == 8 && display->buswidth == 9 &&
par->spi) {
+ else if (display->regwidth == 8 && display->buswidth == 9 && par->spi)
par->fbtftops.write_register = fbtft_write_reg8_bus9;
- } else if (display->regwidth == 16 && display->buswidth == 8) {
+ else if (display->regwidth == 16 && display->buswidth == 8)
par->fbtftops.write_register = fbtft_write_reg16_bus8;
- } else if (display->regwidth == 16 && display->buswidth == 16) {
+ else if (display->regwidth == 16 && display->buswidth == 16)
par->fbtftops.write_register = fbtft_write_reg16_bus16;
- } else {
+ else
dev_warn(dev,
"no default functions for regwidth=%d and
buswidth=%d\n",
display->regwidth, display->buswidth);
- }
/* write_vmem() functions */
if (display->buswidth == 8)
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/3] drivers/fbtft: Remove newline after else in else-if
This removes the following warning issued by checkpatch
WARNING: suspect code indent for conditional statements (8, 8)
+ } else
+ if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
Signed-off-by: Luis Gerhorst
Acked-by: Jonny Schaefer
Acked-by: Alexander Wuerstlein
---
drivers/staging/fbtft/fbtft-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 6d0363d..66b46b2 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1369,8 +1369,7 @@ int fbtft_probe_common(struct fbtft_display *display,
/* write register functions */
if (display->regwidth == 8 && display->buswidth == 8) {
par->fbtftops.write_register = fbtft_write_reg8_bus8;
- } else
- if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
+ } else if (display->regwidth == 8 && display->buswidth == 9 &&
par->spi) {
par->fbtftops.write_register = fbtft_write_reg8_bus9;
} else if (display->regwidth == 16 && display->buswidth == 8) {
par->fbtftops.write_register = fbtft_write_reg16_bus8;
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [driver-core:driver-core-testing] BUILD SUCCESS ae4d90f7ca49eb71f8a3dca64d06d4c4e2193705
Luis > El 25.12.2023, a las 4:31, kernel test robot escribió: > > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > driver-core-testing > branch HEAD: ae4d90f7ca49eb71f8a3dca64d06d4c4e2193705 driver core: device.h: > fix Excess kernel-doc description warning > > elapsed time: 2281m > > configs tested: 99 > configs skipped: 1 > > The following configs have been built successfully. > More configs may be tested in the coming days. > > tested configs: > alpha allnoconfig gcc > alpha defconfig gcc > arc allnoconfig gcc > arc defconfig gcc > arc nsimosci_hs_smp_defconfig gcc > arc randconfig-001-20231224 gcc > arc randconfig-002-20231224 gcc > arm allnoconfig gcc > arm defconfig clang > armmvebu_v5_defconfig clang > armneponset_defconfig clang > arm randconfig-001-20231224 gcc > arm randconfig-002-20231224 gcc > arm randconfig-003-20231224 gcc > arm randconfig-004-20231224 gcc > arm rpc_defconfig gcc > armshmobile_defconfig gcc > arm64 allnoconfig gcc > arm64 defconfig gcc > arm64 randconfig-001-20231224 gcc > arm64 randconfig-002-20231224 gcc > arm64 randconfig-003-20231224 gcc > arm64 randconfig-004-20231224 gcc > csky allnoconfig gcc > cskydefconfig gcc > csky randconfig-001-20231224 gcc > csky randconfig-002-20231224 gcc > hexagon allnoconfig clang > hexagon defconfig clang > hexagon randconfig-001-20231224 clang > hexagon randconfig-002-20231224 clang > i386 allmodconfig clang > i386 allnoconfig clang > i386 allyesconfig clang > i386 buildonly-randconfig-001-20231224 gcc > i386 buildonly-randconfig-002-20231224 gcc > i386 buildonly-randconfig-003-20231224 gcc > i386 buildonly-randconfig-004-20231224 gcc > i386 buildonly-randconfig-005-20231224 gcc > i386 buildonly-randconfig-006-20231224 gcc > i386defconfig gcc > i386 randconfig-001-20231224 gcc > i386 randconfig-002-20231224 gcc > i386 randconfig-003-20231224 gcc > i386 randconfig-004-20231224 gcc > i386 randconfig-005-20231224 gcc > i386 randconfig-006-20231224 gcc > i386 randconfig-011-20231224 clang > i386 randconfig-012-20231224 clang > i386 randconfig-013-20231224 clang > i386 randconfig-014-20231224 clang > i386 randconfig-015-20231224 clang > i386 randconfig-016-20231224 clang > loongarchallmodconfig gcc > loongarch allnoconfig gcc > loongarch randconfig-001-20231224 gcc > loongarch randconfig-002-20231224 gcc > m68k allmodconfig gcc > m68k allnoconfig gcc > m68k allyesconfig gcc > m68kdefconfig gcc > m68km5407c3_defconfig gcc > microblaze allmodconfig gcc > microblazeallnoconfig gcc > microblaze allyesconfig gcc > mips allyesconfig gcc > mips malta_kvm_defconfig clang > nios2allmodconfig gcc > nios2allyesconfig gcc > nios2 randconfig-001-20231224 gcc > nios2 randconfig-002-20231224 gcc > pariscrandconfig-001-20231224 gcc > pariscrandconfig-002-20231224 gcc > powerpc asp8347_defconfig gcc > powerpc currituck_defconfig gcc > powerpc ep8248e_defconfig gcc > powerpc ppa8548_defconfig gcc > powerpc randconfig-001-20231224 gcc > powerpc randconfig-002-20231224 gcc > powerpc randconfig-003-20231224 gcc > powerpc6
