Re: [PATCH 24/39] docs: driver-model: move it to the driver-api book
On Fri, 2019-06-28 at 09:30 -0300, Mauro Carvalho Chehab wrote:
> The audience for the Kernel driver-model is clearly Kernel hackers.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Jeff Kirsher
For the 'ice' driver changes.
> ---
> Documentation/{ => driver-api}/driver-model/binding.rst | 0
> Documentation/{ => driver-api}/driver-model/bus.rst | 0
> Documentation/{ => driver-api}/driver-model/class.rst | 0
> .../{ => driver-api}/driver-model/design-patterns.rst | 0
> Documentation/{ => driver-api}/driver-model/device.rst| 0
> Documentation/{ => driver-api}/driver-model/devres.rst| 0
> Documentation/{ => driver-api}/driver-model/driver.rst| 0
> Documentation/{ => driver-api}/driver-model/index.rst | 2 --
> Documentation/{ => driver-api}/driver-model/overview.rst | 0
> Documentation/{ => driver-api}/driver-model/platform.rst | 0
> Documentation/{ => driver-api}/driver-model/porting.rst | 2 +-
> Documentation/driver-api/gpio/driver.rst | 2 +-
> Documentation/driver-api/index.rst| 1 +
> Documentation/eisa.txt| 4 ++--
> Documentation/filesystems/sysfs.txt | 2 +-
> Documentation/hwmon/submitting-patches.rst| 2 +-
> Documentation/translations/zh_CN/filesystems/sysfs.txt| 2 +-
> drivers/base/platform.c | 2 +-
> drivers/gpio/gpio-cs5535.c| 2 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
> drivers/staging/unisys/Documentation/overview.txt | 4 ++--
> include/linux/device.h| 2 +-
> include/linux/platform_device.h | 2 +-
> scripts/coccinelle/free/devm_free.cocci | 2 +-
> 24 files changed, 16 insertions(+), 17 deletions(-)
> rename Documentation/{ => driver-api}/driver-model/binding.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/bus.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/class.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/design-patterns.rst
> (100%)
> rename Documentation/{ => driver-api}/driver-model/device.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/devres.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/driver.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/index.rst (96%)
> rename Documentation/{ => driver-api}/driver-model/overview.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/platform.rst (100%)
> rename Documentation/{ => driver-api}/driver-model/porting.rst (99%)
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/2] ethernet: intel: Support Hyper-V hosts
On Thu, Apr 14, 2016 at 4:55 PM, K. Y. Srinivasan wrote: > Make adjustments to the Intel 10G VF driver to support > running on Hyper-V hosts. > > K. Y. Srinivasan (2): > ethernet: intel: Add the device ID's presented while running on > Hyper-V > intel: ixgbevf: Support Windows hosts (Hyper-V) > > drivers/net/ethernet/intel/ixgbevf/defines.h |5 + > drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 11 ++ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 56 ++--- > drivers/net/ethernet/intel/ixgbevf/mbx.c | 12 ++ > drivers/net/ethernet/intel/ixgbevf/vf.c | 138 > + > drivers/net/ethernet/intel/ixgbevf/vf.h |2 + > 6 files changed, 206 insertions(+), 18 deletions(-) Don't know how you butchered the mailing list address, but you did not send this series to intel-wired-...@lists.osuosl.org mailing list. Please address the requested changes that Mark suggested and resubmit to the correct mailing list please. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)
On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. > > Signed-off-by: K. Y. Srinivasan > --- > V2: Addressed most of the comments from > Alexander Duyck > and Rustad, Mark D . > > V3: Addressed additional comments from > Alexander Duyck > > V4: Addressed kbuild errors reported by: > kbuild test robot > > V5: Addressed additional comments from > Alexander Duyck First I commend you on actually making a proper changelog for a patch. The only issue I have is that the changelog provides not actual changes. Saying you reacted to comments does not summarize what the actual changes were. I purposely did not review the earlier versions because by the time I went to do a review, there was another version already submitted. So your changelog requires that users look at all the previous emails to actually see what Alex and Mark requested in changes. I am telling you this for future patches, it will not impact these patches, just really disappointing. I will take the extra time to track down all the previous emails and the changes requested to ensure you made all the changes that were requested of you. :-( This will just delay when I apply the patches for testing. > > drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 12 ++ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 31 +++- > drivers/net/ethernet/intel/ixgbevf/mbx.c | 12 ++ > drivers/net/ethernet/intel/ixgbevf/vf.c | 216 > + > drivers/net/ethernet/intel/ixgbevf/vf.h | 2 + > 5 files changed, 266 insertions(+), 7 deletions(-) signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)
On Sat, 2014-06-07 at 18:40 +0200, Ken Helias wrote: > From: Ken Helias > > All other add functions for lists have the new item as first argument > and the > position where it is added as second argument. This was changed for no > good > reason in this function and makes using it unnecessary confusing. > > The name was changed to let old code generate a compile errors instead > of > using the wrong parameter order. > > Signed-off-by: Ken Helias > Cc: Linux NICS > Cc: "Paul E. McKenney" > Cc: dri-de...@lists.freedesktop.org > Cc: e1000-de...@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: de...@driverdev.osuosl.org > Cc: linux-fsde...@vger.kernel.org > Cc: b.a.t.m@lists.open-mesh.org > Cc: bri...@lists.linux-foundation.org For the Intel driver changes... Acked-by: Jeff Kirsher > --- > Patch based on "Add linux-next specific files for 20140606" > > v3: > renamed from hlist_add_after* to hlist_add_behind > > v2: > Splitted into two patches > reduced number of Cc > > Documentation/RCU/whatisRCU.txt | 2 +- > drivers/gpu/drm/drm_hashtab.c| 2 +- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +- > drivers/staging/lustre/lustre/libcfs/hash.c | 4 ++-- > fs/namespace.c | 2 +- > fs/notify/inode_mark.c | 2 +- > fs/notify/vfsmount_mark.c| 2 +- > include/linux/list.h | 4 ++-- > include/linux/rculist.h | 8 > net/batman-adv/fragmentation.c | 2 +- > net/bridge/br_multicast.c| 2 +- > net/ipv4/fib_trie.c | 2 +- > net/ipv6/addrlabel.c | 2 +- > net/xfrm/xfrm_policy.c | 4 ++-- > 15 files changed, 21 insertions(+), 21 deletions(-) signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] bcm/CmHost.c: Fix noisy compile warnings
The Beceem WIMAX was generating compile warnings on 64bit machines,
which were:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
(struct bcm_connect_mgr_params *) ntohl(
^
drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
(struct bcm_connect_mgr_params *) ntohl(
^
drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
(struct bcm_connect_mgr_params *) ntohl(
This resolves the issue by generating 64bit friendly code.
Signed-off-by: Jeff Kirsher
---
drivers/staging/bcm/CmHost.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index adca0ce..29fa05d 100644
--- a/drivers/staging/bcm/CmHost.c
+++ b/drivers/staging/bcm/CmHost.c
@@ -1499,9 +1499,15 @@ ULONG StoreCmControlResponseMessage(struct
bcm_mini_adapter *Adapter,
}
/* this can't possibly be right */
+#ifdef CONFIG_32BIT
pstAddIndication->psfAuthorizedSet =
(struct bcm_connect_mgr_params *) ntohl(
(ULONG)pstAddIndication->psfAuthorizedSet);
+#else
+ pstAddIndication->psfAuthorizedSet =
+ (struct bcm_connect_mgr_params *)(u64)ntohl(
+ (ULONG)pstAddIndication->psfAuthorizedSet);
+#endif
if (pstAddIndicationAlt->u8Type == DSA_REQ) {
struct bcm_add_request AddRequest;
@@ -1542,9 +1548,15 @@ ULONG StoreCmControlResponseMessage(struct
bcm_mini_adapter *Adapter,
return 0;
}
+#ifdef CONFIG_32BIT
pstAddIndication->psfAdmittedSet =
(struct bcm_connect_mgr_params *) ntohl(
(ULONG) pstAddIndication->psfAdmittedSet);
+#else
+ pstAddIndication->psfAdmittedSet =
+ (struct bcm_connect_mgr_params *)(u64)ntohl(
+ (ULONG) pstAddIndication->psfAdmittedSet);
+#endif
/* ACTIVE SET */
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)
@@ -1560,9 +1572,15 @@ ULONG StoreCmControlResponseMessage(struct
bcm_mini_adapter *Adapter,
return 0;
}
+#ifdef CONFIG_32BIT
pstAddIndication->psfActiveSet =
(struct bcm_connect_mgr_params *) ntohl(
(ULONG)pstAddIndication->psfActiveSet);
+#else
+ pstAddIndication->psfActiveSet =
+ (struct bcm_connect_mgr_params *)(u64)ntohl(
+ (ULONG)pstAddIndication->psfActiveSet);
+#endif
(*puBufferLength) = sizeof(struct bcm_add_indication);
*(struct bcm_add_indication *)pvBuffer = *pstAddIndication;
--
1.9.3
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 15:59 +0300, Dan Carpenter wrote:
> Or we could fix it but add a multi-line comment with lots of capital
> letters and exclamation marks. I guess we would need to make a
> function
> since this cast is in several places.
>
> void *silence_buggy_casting(u32 pointer)
> {
> /*
> * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
> * FIXME!!! We know this cast is totally buggy. The BCM
> driver
> * doesn't work on 64 bits. But no one knows how to make this
> * work. Oh well. Let's silence the GCC warning.
> * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
> *
> */
> return (void *)(long)pointer;
> }
>
> Something really ugly and gnarly like that would be hard to ignore.
I thought I remember Greg saying something about getting rid of this
driver anyway, but I could be wrong. If Greg decides to keep this
driver around, then I think we should something like your suggestion
above.
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 09:11 -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > [] > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver around, then I think we should something like your suggestion > > above. > > Or maybe just make the Kconfig depend on X86_32 I like the idea, but won't this exclude other 32 bit systems like MIPS and I am sure there might be others. I could assume that Beceem WIMAX was intended for x86 arch's that are 32 bit only, which may be a safe bet. The only thing we know for sure is that is broken on 64bit. > --- > drivers/staging/bcm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig > index 8acf4b2..fa5a3a4 100644 > --- a/drivers/staging/bcm/Kconfig > +++ b/drivers/staging/bcm/Kconfig > @@ -1,6 +1,6 @@ > config BCM_WIMAX > tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" > - depends on USB && NET > + depends on USB && NET && X86_32 > help > This is an experimental driver for the Beceem WIMAX chipset used >by Sprint 4G. > > signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote: > On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher > wrote: > > > I like the idea, but won't this exclude other 32 bit systems like MIPS > > and I am sure there might be others. I could assume that Beceem WIMAX > > was intended for x86 arch's that are 32 bit only, which may be a safe > > bet. The only thing we know for sure is that is broken on 64bit. > > What about this? That works for me. I am putting together a v2 patch now, since you came up with the change, I will put you as the author Fabio, ok? > > diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig > index 8acf4b2..fa5a3a4 100644 > --- a/drivers/staging/bcm/Kconfig > +++ b/drivers/staging/bcm/Kconfig > @@ -1,6 +1,6 @@ > config BCM_WIMAX > tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" > - depends on USB && NET > + depends on USB && NET && !64BIT > help > This is an experimental driver for the Beceem WIMAX chipset used > by Sprint 4G. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
From: Fabio Estevam The Beceem WIMAX was generating compile warnings on 64bit machines, which were: drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( This resolves the issue by preventing the driver to compile if CONFIG_64BIT is enabled, since the driver is known to be broken for 64 bit arch's. CC: Dan Carpenter CC: Joe Perches Signed-off-by: Fabio Estevam Signed-off-by: Jeff Kirsher --- v2: change fix from using typecast u64 in the code to altering Kconfig to prevent the driver from compiling on 64 bit arch's based on feedback drivers/staging/bcm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig index 8acf4b2..273b328 100644 --- a/drivers/staging/bcm/Kconfig +++ b/drivers/staging/bcm/Kconfig @@ -1,6 +1,6 @@ config BCM_WIMAX tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" - depends on USB && NET + depends on USB && NET && !64BIT help This is an experimental driver for the Beceem WIMAX chipset used by Sprint 4G. -- 1.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > From: Fabio Estevam > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > which were: > > > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer > > of different size [-Wint-to-pointer-cast] > >(struct bcm_connect_mgr_params *) ntohl( > >^ > > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer > > of different size [-Wint-to-pointer-cast] > >(struct bcm_connect_mgr_params *) ntohl( > >^ > > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer > > of different size [-Wint-to-pointer-cast] > >(struct bcm_connect_mgr_params *) ntohl( > > > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT > > is enabled, since the driver is known to be broken for 64 bit arch's. > > > > Oops. Someone turned a Joe patch into a real patch. Please enable > COMPILE_TEST for this. I agree with Joe, that COMPILE_TEST is not useful for this driver. > > regards, > dan carpenter > signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 23:41 +0200, Matthias Beyer wrote: > On 15-10-2014 06:03:33, Jeff Kirsher wrote: > > > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver around, then I think we should something like your suggestion > > above. > > Let me throw in my comment here: Yes, Greg stated in several places > that this whole driver should be removed. I was about to ask when this > will happen, so let me add a suggestion: > > Lets delete this _now_!!1!1! > > If you care, I can search the statements where Greg stated that this > should be removed, but I guess this some effort... I can barely > remember that one time was on the linuxnewbies ML and one or two times > here. No need to dig up where and when Greg stated that it should be removed, I was pretty sure he mentioned it on several lists. I think the most recent was on the linuxnewbies ML. I will just go ahead and create a patch to remove the driver. Greg can then decide to either accept the patch to fix the Kconfig or accept the patch to remove the driver. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Thu, 2014-10-16 at 00:24 +0200, Matthias Beyer wrote: > On 15-10-2014 15:19:44, Jeff Kirsher wrote: > > I will just go ahead and create a patch to remove the driver. Greg > can > > then decide to either accept the patch to fix the Kconfig or accept > the > > patch to remove the driver. > > Don't forget the maintainers file :-) Yep, got it. Thanks for the reminder. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote: > From: Fabio Estevam > > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] >(struct bcm_connect_mgr_params *) ntohl( >^ > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] >(struct bcm_connect_mgr_params *) ntohl( >^ > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] >(struct bcm_connect_mgr_params *) ntohl( > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT > is enabled, since the driver is known to be broken for 64 bit arch's. > > CC: Dan Carpenter > CC: Joe Perches > Signed-off-by: Fabio Estevam > Signed-off-by: Jeff Kirsher Greg- I have also submitted a patch to remove this driver entirely. So if you choose to apply the patch to remove the driver, then you can disregard this patch. > --- > v2: change fix from using typecast u64 in the code to altering Kconfig to > prevent the driver from compiling on 64 bit arch's based on feedback > > drivers/staging/bcm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig > index 8acf4b2..273b328 100644 > --- a/drivers/staging/bcm/Kconfig > +++ b/drivers/staging/bcm/Kconfig > @@ -1,6 +1,6 @@ > config BCM_WIMAX > tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" > - depends on USB && NET > + depends on USB && NET && !64BIT > help > This is an experimental driver for the Beceem WIMAX chipset used >by Sprint 4G. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
On Thu, 2014-10-16 at 10:48 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > > > > [] > > > > > I thought I remember Greg saying something about getting rid of this > > > > > driver anyway, but I could be wrong. If Greg decides to keep this > > > > > driver around, then I think we should something like your suggestion > > > > > above. > > > > > > > > Or maybe just make the Kconfig depend on X86_32 > > > > > > What I like about your patches is that they are pure theoretical work > > > and I don't have to think about them like regular proper patches with a > > > signed off by etc. All the fun, none of the responsibility. > > > > I've sent a lot of signed-off patches. > > These are simple suggestions. > > > > I think COMPILE_TEST isn't useful here. > > I don't understand... COMPILE_TEST means runing a static checker on > the driver. Why would we not want to do QA? I think we can drop this patch altogether since I have submitted another patch to remove this driver from the kernel completely, since Matthias Beyer (and Greg KH in earlier discussions) suggested we do so. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
On Thu, 2014-10-16 at 10:52 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote: > > On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > > > From: Fabio Estevam > > > > > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > > > which were: > > > > > > > > drivers/staging/bcm/CmHost.c: In function > > > > ‘StoreCmControlResponseMessage’: > > > > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from > > > > integer of different size [-Wint-to-pointer-cast] > > > >(struct bcm_connect_mgr_params *) ntohl( > > > >^ > > > > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from > > > > integer of different size [-Wint-to-pointer-cast] > > > >(struct bcm_connect_mgr_params *) ntohl( > > > >^ > > > > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from > > > > integer of different size [-Wint-to-pointer-cast] > > > >(struct bcm_connect_mgr_params *) ntohl( > > > > > > > > This resolves the issue by preventing the driver to compile if > > > > CONFIG_64BIT > > > > is enabled, since the driver is known to be broken for 64 bit arch's. > > > > > > > > > > Oops. Someone turned a Joe patch into a real patch. Please enable > > > COMPILE_TEST for this. > > > > I agree with Joe, that COMPILE_TEST is not useful for this driver. > > If we remove the driver fine, but if we keep the driver then we should > do enable any QA testing we can. Sorry, after thinking about this more, I think that Joe and I jumped to the conclusion that adding COMPILE_TEST meant to add " || COMPILE_TEST" which would generate the same compile warnings we see now, especially when doing allmodconfig. But, if we added " && COMPILE_TEST", along with the other Kconfig change, then I am fine with that. So yes, I am on the same page with you. If we end up keeping the driver, then I will respin the patch to add && COMPILE_TEST. I will wait to re-spin based on whether Greg accepts the patch to remove the driver or not. signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 03/51] DMA-API: net: intel/e1000e: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:27 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
> if (!err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(64));
> if (!err)
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> dev_err(&pdev->dev,
> "No usable DMA configuration,
> aborting\n");
> goto err_dma;
> }
> }
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 18 ++
> 1 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 05/51] DMA-API: net: intel/igbvf: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:29 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
> if (!err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(64));
> if (!err)
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> dev_err(&pdev->dev, "No usable DMA "
> "configuration, aborting\n");
> goto err_dma;
> }
> }
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 18 ++
> 1 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 04/51] DMA-API: net: intel/igb: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:28 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
> if (!err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(64));
> if (!err)
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> dev_err(&pdev->dev,
> "No usable DMA configuration,
> aborting\n");
> goto err_dma;
> }
> }
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 18 ++
> 1 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 06/51] DMA-API: net: intel/ixgb: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:30 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
> if (!err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(64));
> if (!err)
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> pr_err("No usable DMA configuration,
> aborting\n");
> goto err_dma_mask;
> }
> }
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 16 +---
> 1 files changed, 5 insertions(+), 11 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 07/51] DMA-API: net: intel/ixgbe: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:31 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) &&
> !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> dev_err(&pdev->dev,
> "No usable DMA configuration,
> aborting\n");
> goto err_dma;
> }
> }
> pci_using_dac = 0;
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 +--
> 1 files changed, 5 insertions(+), 10 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 12/51] DMA-API: net: intel/e1000: replace dma_set_mask()+dma_set_coherent_mask() with new helper
On Thu, 2013-09-19 at 22:37 +0100, Russell King wrote: > Replace the following sequence: > > dma_set_mask(dev, mask); > dma_set_coherent_mask(dev, mask); > > with a call to the new helper dma_set_mask_and_coherent(). > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/e1000/e1000_main.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 08/51] DMA-API: net: intel/ixgbevf: fix 32-bit DMA mask handling
On Thu, 2013-09-19 at 22:32 +0100, Russell King wrote:
> The fallback to 32-bit DMA mask is rather odd:
> if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) &&
> !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
> pci_using_dac = 1;
> } else {
> err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (err) {
> err = dma_set_coherent_mask(&pdev->dev,
> DMA_BIT_MASK(32));
> if (err) {
> dev_err(&pdev->dev, "No usable DMA "
> "configuration, aborting\n");
> goto err_dma;
> }
> }
> pci_using_dac = 0;
> }
> This means we only set the coherent DMA mask in the fallback path if
> the DMA mask set failed, which is silly. This fixes it to set the
> coherent DMA mask only if dma_set_mask() succeeded, and to error out
> if either fails.
>
> Signed-off-by: Russell King
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 15
> +--
> 1 files changed, 5 insertions(+), 10 deletions(-)
Acked-by: Jeff Kirsher
signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
