from:"Hans Wennborg"

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Hans Wennborg




On 08/02/2014 05:46 PM, Joe Perches wrote:

On Sat, 2014-08-02 at 15:20 -0700, Hans Wennborg wrote:

Signed-off-by: Hans Wennborg 
---
  arch/cris/arch-v32/drivers/cryptocop.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/arch-v32/drivers/cryptocop.c 
b/arch/cris/arch-v32/drivers/cryptocop.c

[]

@@ -3155,7 +3155,7 @@ static void print_dma_descriptors(struct 
cryptocop_int_operation *iop)
printk("print_dma_descriptors start\n");

printk("iop:\n");
-   printk("\tsid: 0x%lld\n", iop->sid);
+   printk("\tsid: 0x%llx\n", iop->sid);

printk("\tcdesc_out: 0x%p\n", iop->cdesc_out);
printk("\tcdesc_in: 0x%p\n", iop->cdesc_in);


Thanks.

This is a surprisingly common error:

$ /usr/bin/git grep -P 
'0x\%(?!ull\b|ul\b|u\b|lu\b|llu\b|llux\b|lux\b|lx\b|lluX\b|luX\b|lX\b)[ul]*[ud]'

[...]

Yes, I have a patch for a bunch of these, but I figured it would be 
easier to get it merged if I split it up. (Complete kernel newbie here.)


 - Hans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 15/19] staging: nokia_h4p: fix %d confusingly prefixed with 0x in format string

2014-08-03 Thread Hans Wennborg

Signed-off-by: Hans Wennborg 
---
 drivers/staging/nokia_h4p/nokia_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/nokia_h4p/nokia_core.c 
b/drivers/staging/nokia_h4p/nokia_core.c
index 775e1d0..240da0c 100644
--- a/drivers/staging/nokia_h4p/nokia_core.c
+++ b/drivers/staging/nokia_h4p/nokia_core.c
@@ -1113,7 +1113,7 @@ static int hci_h4p_probe(struct platform_device *pdev)
GPIOF_OUT_INIT_LOW, "bt_wakeup");
 
if (err < 0) {
-   dev_err(info->dev, "Cannot get GPIO line 0x%d",
+   dev_err(info->dev, "Cannot get GPIO line 0x%x",
info->bt_wakeup_gpio);
return err;
}
-- 
2.0.0.526.g5318336

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-03 Thread Hans Wennborg

Signed-off-by: Hans Wennborg 
---
 drivers/staging/rtl8192ee/pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192ee/pci.c b/drivers/staging/rtl8192ee/pci.c
index 0215aef..349e636 100644
--- a/drivers/staging/rtl8192ee/pci.c
+++ b/drivers/staging/rtl8192ee/pci.c
@@ -649,7 +649,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int 
prio)
 
if ((ring->entries - skb_queue_len(&ring->queue)) == 2) {
RT_TRACE(COMP_ERR, DBG_LOUD,
-("more desc left, wake skb_queue@%d,ring->idx 
= %d, skb_queue_len = 0x%d\n",
+("more desc left, wake skb_queue@%d,ring->idx 
= %d, skb_queue_len = 0x%x\n",
 prio, ring->idx,
 skb_queue_len(&ring->queue)));
 
@@ -1628,7 +1628,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
 
if ((own == 1) && (hw_queue != BEACON_QUEUE)) {
RT_TRACE(COMP_ERR, DBG_WARNING,
-("No more TX desc@%d, ring->idx = %d, idx = 
%d, skb_queue_len = 0x%d\n",
+("No more TX desc@%d, ring->idx = %d, idx = 
%d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
@@ -1670,7 +1670,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
if ((ring->entries - skb_queue_len(&ring->queue)) < 2 &&
hw_queue != BEACON_QUEUE) {
RT_TRACE(COMP_ERR, DBG_LOUD,
-("less desc left, stop skb_queue@%d, ring->idx = %d, 
idx = %d, skb_queue_len = 0x%d\n",
+("less desc left, stop skb_queue@%d, ring->idx = %d, 
idx = %d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
-- 
2.0.0.526.g5318336

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 17/19] staging: rtl8821ae: fix %d confusingly prefixed with 0x in format strings

2014-08-03 Thread Hans Wennborg

Signed-off-by: Hans Wennborg 
---
 drivers/staging/rtl8821ae/pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c
index 26d7b2f..b818788 100644
--- a/drivers/staging/rtl8821ae/pci.c
+++ b/drivers/staging/rtl8821ae/pci.c
@@ -662,7 +662,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int 
prio)
RT_TRACE(COMP_ERR, DBG_LOUD,
("more desc left, wake"
 "skb_queue@%d,ring->idx = %d,"
-"skb_queue_len = 0x%d\n",
+"skb_queue_len = 0x%x\n",
 prio, ring->idx,
 skb_queue_len(&ring->queue)));
 
@@ -1650,7 +1650,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
if ((own == 1) && (hw_queue != BEACON_QUEUE)) {
RT_TRACE(COMP_ERR, DBG_WARNING,
 ("No more TX desc@%d, ring->idx = %d,"
- "idx = %d, skb_queue_len = 0x%d\n",
+ "idx = %d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
@@ -1695,7 +1695,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
RT_TRACE(COMP_ERR, DBG_LOUD,
 ("less desc left, stop skb_queue@%d, "
  "ring->idx = %d,"
- "idx = %d, skb_queue_len = 0x%d\n",
+ "idx = %d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
-- 
2.0.0.526.g5318336

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-03 Thread Hans Wennborg


On 08/02/2014 11:10 PM, Joe Perches wrote:

On Sat, 2014-08-02 at 18:19 -0700, Hans Wennborg wrote:

Yes, I have a patch for a bunch of these, but I figured it would be
easier to get it merged if I split it up. (Complete kernel newbie here.)


You as a kernel newbie did good, thanks.

A small tip would be to do all of them in a single series
cc'ing each individual patch to the appropriate maintainers
and mailing lists.


Thanks for the advice! I have split up and sent out the big patch as a 
series, with hopefully the right folks CC'd.


 - Hans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg


On 08/09/2014 09:23 PM, Greg KH wrote:

On Sun, Aug 03, 2014 at 05:20:58PM -0700, Hans Wennborg wrote:

Signed-off-by: Hans Wennborg 
---
  drivers/staging/rtl8192ee/pci.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)


This patch fails to apply to my tree :(



Sorry about that. I'll try to rebase and re-post the patch.

 - Hans
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg

Re-sending patch based off of
https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-10 Thread Hans Wennborg

Signed-off-by: Hans Wennborg 
---
 drivers/staging/rtl8192ee/pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192ee/pci.c b/drivers/staging/rtl8192ee/pci.c
index 0215aef..349e636 100644
--- a/drivers/staging/rtl8192ee/pci.c
+++ b/drivers/staging/rtl8192ee/pci.c
@@ -649,7 +649,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int 
prio)
 
if ((ring->entries - skb_queue_len(&ring->queue)) == 2) {
RT_TRACE(COMP_ERR, DBG_LOUD,
-("more desc left, wake skb_queue@%d,ring->idx 
= %d, skb_queue_len = 0x%d\n",
+("more desc left, wake skb_queue@%d,ring->idx 
= %d, skb_queue_len = 0x%x\n",
 prio, ring->idx,
 skb_queue_len(&ring->queue)));
 
@@ -1628,7 +1628,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
 
if ((own == 1) && (hw_queue != BEACON_QUEUE)) {
RT_TRACE(COMP_ERR, DBG_WARNING,
-("No more TX desc@%d, ring->idx = %d, idx = 
%d, skb_queue_len = 0x%d\n",
+("No more TX desc@%d, ring->idx = %d, idx = 
%d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
@@ -1670,7 +1670,7 @@ static int rtl_pci_tx(struct ieee80211_hw *hw,
if ((ring->entries - skb_queue_len(&ring->queue)) < 2 &&
hw_queue != BEACON_QUEUE) {
RT_TRACE(COMP_ERR, DBG_LOUD,
-("less desc left, stop skb_queue@%d, ring->idx = %d, 
idx = %d, skb_queue_len = 0x%d\n",
+("less desc left, stop skb_queue@%d, ring->idx = %d, 
idx = %d, skb_queue_len = 0x%x\n",
  hw_queue, ring->idx, idx,
  skb_queue_len(&ring->queue)));
 
-- 
2.0.0.526.g5318336

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

[PATCH 15/19] staging: nokia_h4p: fix %d confusingly prefixed with 0x in format string

[PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

[PATCH 17/19] staging: rtl8821ae: fix %d confusingly prefixed with 0x in format strings

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

Re: [PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

Re: staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

[PATCH] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

8 matches

Site Navigation

Mail list logo

Footer information