[PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
Fix coding style errors found by checkpatch.pl tool Signed-off-by: Gbenga Adalumo --- drivers/staging/comedi/drivers/daqboard2000.c | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c index f97d18d..2ca8d3e 100644 --- a/drivers/staging/comedi/drivers/daqboard2000.c +++ b/drivers/staging/comedi/drivers/daqboard2000.c @@ -40,10 +40,10 @@ Configuration options: not applicable, uses PCI auto config for the card, and here are the findings so far. 1. A good document that describes the PCI interface chip is 9080db-106.pdf - available from http://www.plxtech.com/products/io/pci9080 + available from http://www.plxtech.com/products/io/pci9080 2. The initialization done so far is: -a. program the FPGA (windows code sans a lot of error messages) + a. program the FPGA (windows code sans a lot of error messages) b. 3. Analog out seems to work OK with DAC's disabled, if DAC's are enabled, @@ -52,52 +52,52 @@ Configuration options: not applicable, uses PCI auto config gives me no clues. I'll keep it simple so far. 4. Analog in. -Each channel in the scanlist seems to be controlled by four + Each channel in the scanlist seems to be controlled by four control words: -Word0: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + Word0: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -Word1: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + Word1: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | | | | | | | - +--+--+ | | | | +-- Digital input (??) + +--+--+ | | | | +-- Digital input (??) | | | | + 10 us settling time | | | +-- Suspend acquisition (last to scan) | | + Simultaneous sample and hold | +-- Signed data format +- Correction offset low -Word2: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | | | | | | | | | | - +-+ +--+--+ +++ +++ +--+--+ - | | | | +- Expansion channel + Word2: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + | | | | | | | | | | + +-+ +--+--+ +++ +++ +--+--+ + | | | | +- Expansion channel | | | +--- Expansion gain - | | +--- Channel (low) + | | +--- Channel (low) | +- Correction offset high +- Correction gain low -Word3: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | | | | | | | | | - +--+--+ | | +-+-+ | | +-- Low bank enable - || | | | + High bank enable - || | | +-- Hi/low select + Word3: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + | | | | | | | | | + +--+--+ | | +-+-+ | | +-- Low bank enable + || | | | + High bank enable + || | | +-- Hi/low select || | +-- Gain (1,?,2,4,8,16,32,64) || +-- differential/single ended |+ Unipolar +- Correction gain high 999. The card seems to have an incredible amount of capabilities, but -trying to reverse engineer them from the Windows source is beyond my + trying to reverse engineer them from the Windows source is beyond my patience. */ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
The patch fixes a trailing whitespace and code indenting coding style errors as reported by checkpatch.pl tool. Details of the lines where the fixed errors were reported are as follows: drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:55: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:58: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:59: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:60: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:61: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:63: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:64: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:65: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:66: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:68: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:75: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:76: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:77: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:78: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:79: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:80: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:81: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:83: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:86: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:87: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:88: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:89: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:90: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:91: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:92: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:93: ERROR: code indent should use tabs where possible drivers/staging/comedi/drivers/daqboard2000.c:100: ERROR: code indent should use tabs where possible --Gbenga Adalumo On Mon, Apr 20, 2015 at 7:43 AM, Greg KH wrote: > On Sun, Apr 19, 2015 at 07:59:31PM -0700, Gbenga Adalumo wrote: >> Fix coding style errors found by checkpatch.pl tool > > What errors? Be specific. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: fix code indent coding style issues in daqboard2000.c
This is a patch to daqboard2000.c file that fixes code indent errors found by the checkpatch.pl tool Signed-off-by: Gbenga Adalumo --- drivers/staging/comedi/drivers/daqboard2000.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c index f97d18d..223a3fa 100644 --- a/drivers/staging/comedi/drivers/daqboard2000.c +++ b/drivers/staging/comedi/drivers/daqboard2000.c @@ -43,7 +43,7 @@ Configuration options: not applicable, uses PCI auto config available from http://www.plxtech.com/products/io/pci9080 2. The initialization done so far is: -a. program the FPGA (windows code sans a lot of error messages) + a. program the FPGA (windows code sans a lot of error messages) b. 3. Analog out seems to work OK with DAC's disabled, if DAC's are enabled, @@ -52,52 +52,52 @@ Configuration options: not applicable, uses PCI auto config gives me no clues. I'll keep it simple so far. 4. Analog in. -Each channel in the scanlist seems to be controlled by four + Each channel in the scanlist seems to be controlled by four control words: -Word0: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + Word0: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -Word1: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + Word1: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | | | | | | | - +--+--+ | | | | +-- Digital input (??) + +--+--+ | | | | +-- Digital input (??) | | | | + 10 us settling time | | | +-- Suspend acquisition (last to scan) | | + Simultaneous sample and hold | +-- Signed data format +- Correction offset low -Word2: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | | | | | | | | | | - +-+ +--+--+ +++ +++ +--+--+ - | | | | +- Expansion channel + Word2: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + | | | | | | | | | | + +-+ +--+--+ +++ +++ +--+--+ + | | | | +- Expansion channel | | | +--- Expansion gain - | | +--- Channel (low) + | | +--- Channel (low) | +- Correction offset high +- Correction gain low -Word3: - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - ! | | | ! | | | ! | | | ! | | | ! - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | | | | | | | | | - +--+--+ | | +-+-+ | | +-- Low bank enable - || | | | + High bank enable - || | | +-- Hi/low select + Word3: + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + ! | | | ! | | | ! | | | ! | | | ! + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + | | | | | | | | | + +--+--+ | | +-+-+ | | +-- Low bank enable + || | | | + High bank enable + || | | +-- Hi/low select || | +-- Gain (1,?,2,4,8,16,32,64) || +-- differential/single ended |+ Unipolar +- Correction gain high 999. The card seems to have an incredible amount of capabilities, but -trying to reverse engineer them from the Windows source is beyond my + trying to reverse engineer them from the Windows source is beyond my patience. */ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
