[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/rtl8192u/r8192U_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..6b647ad 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
u16 N_DBPSOfRate(u16 DataRate);
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
u8 bShortPreamble)
{
u16 FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+ unsigned int tx_queue)
{
if (tx_queue >= 9) {
RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
+ bool bIsRxAggrSubframe)
{
#ifdef USB_RX_AGGREGATION_SUPPORT
if (bIsRxAggrSubframe)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Pls Confirm!
Good day How are you today, did you receive the email I sent you three days ago? For important discussion on ( Investment ) If not please reply me back so that I will resend it again. Please confirm if you did ( posteaz...@gmail.com ). Best Regards, Mr. Fred Grenville ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Pls Confirm!
Good day How are you today, did you receive the email I sent you three days ago? For important discussion on ( Investment ) If not please reply me back so that I will resend it again. Please confirm if you did ( posteaz...@gmail.com ). Best Regards, Mr. Fred Grenville ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c
From: Fred
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/rtl8192u/r8192U_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..6b647ad 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
u16 N_DBPSOfRate(u16 DataRate);
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
u8 bShortPreamble)
{
u16 FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+ unsigned int tx_queue)
{
if (tx_queue >= 9) {
RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
+ bool bIsRxAggrSubframe)
{
#ifdef USB_RX_AGGREGATION_SUPPORT
if (bIsRxAggrSubframe)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c
From: Fred Chou
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/rtl8192u/r8192U_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..6b647ad 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
u16 N_DBPSOfRate(u16 DataRate);
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
u8 bShortPreamble)
{
u16 FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+ unsigned int tx_queue)
{
if (tx_queue >= 9) {
RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
+ bool bIsRxAggrSubframe)
{
#ifdef USB_RX_AGGREGATION_SUPPORT
if (bIsRxAggrSubframe)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: rt8192u: fix sparse warnings in r8192U_core.c
From: Fred Chou
v2: alignment to match open parenthesis
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/rtl8192u/r8192U_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..6b647ad 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
u16 N_DBPSOfRate(u16 DataRate);
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
u8 bShortPreamble)
{
u16 FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+unsigned int tx_queue)
{
if (tx_queue >= 9) {
RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
+bool bIsRxAggrSubframe)
{
#ifdef USB_RX_AGGREGATION_SUPPORT
if (bIsRxAggrSubframe)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] staging: rtl8192u: fix sparse warnings
From: Fred Chou
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared.
Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
change in v3: fixed alignment to match open parenthesis
drivers/staging/rtl8192u/r8192U_core.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..2c61801 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
@@ -1486,8 +1486,8 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
u16 N_DBPSOfRate(u16 DataRate);
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
- u8 bShortPreamble)
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+ u8 bShortPreamble)
{
u16 FrameTime;
u16 N_DBPS;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+unsigned int tx_queue)
{
if (tx_queue >= 9) {
RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
+bool bIsRxAggrSubframe)
{
#ifdef USB_RX_AGGREGATION_SUPPORT
if (bIsRxAggrSubframe)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: rtl8192u: fix sparse warnings
On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
> On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
>> From: Fred Chou
>>
>> Fixed the following warnings in sparse:
>>
>> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
>> symbol 'dump_eprom' was not declared.
>> Should it be static?
>> drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
>> symbol 'ComputeTxTime' was not declared.
>> Should it be static?
>> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
>> symbol 'txqueue2outpipe' was not declared.
>> Should it be static?
>> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
>> symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
>> Should it be static?
>>
>> Signed-off-by: Fred Chou
>>
>> ---
>> change in v3: fixed alignment to match open parenthesis
> have u fixed?
> your v2 was having one problem of alignment, but v3 is again having 3
> problems.
> and your patch doesnot apply to next-20141203
>
The alignment issue is fixed when I apply the patch against my local
kernel source tree. Wondering why there are still alignment problems.
Let me test with next-20141203 and send v4 again. My apologies...
Fred
> sudip
>
>>
>> drivers/staging/rtl8192u/r8192U_core.c | 12 +++-
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/r8192U_core.c
>> b/drivers/staging/rtl8192u/r8192U_core.c
>> index 7640386..2c61801 100644
>> --- a/drivers/staging/rtl8192u/r8192U_core.c
>> +++ b/drivers/staging/rtl8192u/r8192U_core.c
>> @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
>>
>>
>> /* this is only for debug */
>> -void dump_eprom(struct net_device *dev)
>> +static void dump_eprom(struct net_device *dev)
>> {
>> int i;
>> for (i = 0; i < 63; i++)
>> @@ -1486,8 +1486,8 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
>>
>> u16 N_DBPSOfRate(u16 DataRate);
>>
>> -u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
>> - u8 bShortPreamble)
>> +static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
>> + u8 bShortPreamble)
>> {
>> u16 FrameTime;
>> u16 N_DBPS;
>> @@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
>> return N_DBPS;
>> }
>>
>> -unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
>> +static unsigned int txqueue2outpipe(struct r8192_priv *priv,
>> + unsigned int tx_queue)
>> {
>> if (tx_queue >= 9) {
>> RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
>> @@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
>>
>> }
>>
>> -u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
>> bIsRxAggrSubframe)
>> +static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
>> + bool bIsRxAggrSubframe)
>> {
>> #ifdef USB_RX_AGGREGATION_SUPPORT
>> if (bIsRxAggrSubframe)
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: rtl8192u: fix sparse warnings
On 4/12/2014 4:30 PM, Sudip Mukherjee wrote:
> On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote:
>>
>>
>> On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
>>> On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
>>>> From: Fred Chou
>>>>
>>>> Fixed the following warnings in sparse:
>>>>
>>>> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
>>>>symbol 'dump_eprom' was not declared.
>>>>Should it be static?
>>>> drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
>>>>symbol 'ComputeTxTime' was not declared.
>>>>Should it be static?
>>>> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
>>>>symbol 'txqueue2outpipe' was not declared.
>>>>Should it be static?
>>>> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
>>>>symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
>>>>Should it be static?
>>>>
>>>> Signed-off-by: Fred Chou
>>>>
>>>> ---
>>>> change in v3: fixed alignment to match open parenthesis
>>> have u fixed?
>>> your v2 was having one problem of alignment, but v3 is again having 3
>>> problems.
>>> and your patch doesnot apply to next-20141203
>>>
>>
>> The alignment issue is fixed when I apply the patch against my local
>> kernel source tree. Wondering why there are still alignment problems.
>> Let me test with next-20141203 and send v4 again. My apologies...
>
> i think you have created your v3 on top of your v2.
> reset the source before doing this one. and check the patch with checkpatch
> before sending.
>
> thanks
> sudip
v3 is created from scratch. I removed the v2 patch when formatting the
patch. checkpatch.pl does not report any zeros or warnings for both v2
and v3, and the alignment looks all right to me. That makes me very
confused.
>>
>> Fred
>>
>>> sudip
>>>
>>>>
>>>> drivers/staging/rtl8192u/r8192U_core.c | 12 +++-
>>>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/rtl8192u/r8192U_core.c
>>>> b/drivers/staging/rtl8192u/r8192U_core.c
>>>> index 7640386..2c61801 100644
>>>> --- a/drivers/staging/rtl8192u/r8192U_core.c
>>>> +++ b/drivers/staging/rtl8192u/r8192U_core.c
>>>> @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
>>>>
>>>>
>>>> /* this is only for debug */
>>>> -void dump_eprom(struct net_device *dev)
>>>> +static void dump_eprom(struct net_device *dev)
>>>> {
>>>>int i;
>>>>for (i = 0; i < 63; i++)
>>>> @@ -1486,8 +1486,8 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
>>>>
>>>> u16 N_DBPSOfRate(u16 DataRate);
>>>>
>>>> -u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
>>>> -u8 bShortPreamble)
>>>> +static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8
>>>> bManagementFrame,
>>>> +u8 bShortPreamble)
>>>> {
>>>>u16 FrameTime;
>>>>u16 N_DBPS;
>>>> @@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
>>>>return N_DBPS;
>>>> }
>>>>
>>>> -unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int
>>>> tx_queue)
>>>> +static unsigned int txqueue2outpipe(struct r8192_priv *priv,
>>>> + unsigned int tx_queue)
>>>> {
>>>>if (tx_queue >= 9) {
>>>>RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
>>>> @@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
>>>>
>>>> }
>>>>
>>>> -u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
>>>> bIsRxAggrSubframe)
>>>> +static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats
>>>> *Status,
>>>> + bool bIsRxAggrSubframe)
>>>> {
>>>> #ifdef USB_RX_AGGREGATION_SUPPORT
>>>>if (bIsRxAggrSubframe)
>>>> --
>>>> 1.9.1
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to majord...@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>> Please read the FAQ at http://www.tux.org/lkml/
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:lustre:lustre:ptlrpc: fix sparse warnings in lproc_ptlrpc.c
From: Fred Chou
Fixed the below warning in sparse:
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:184:6:
warning: symbol 'ptlrpc_lprocfs_register' was not declared.
Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
index 4011e00..4c0d48e 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
@@ -181,9 +181,10 @@ const char *ll_eopcode2str(__u32 opcode)
return ll_eopcode_table[opcode].opname;
}
#if defined (CONFIG_PROC_FS)
-void ptlrpc_lprocfs_register(struct proc_dir_entry *root, char *dir,
-char *name, struct proc_dir_entry **procroot_ret,
-struct lprocfs_stats **stats_ret)
+static void ptlrpc_lprocfs_register(struct proc_dir_entry *root, char *dir,
+ char *name,
+ struct proc_dir_entry **procroot_ret,
+ struct lprocfs_stats **stats_ret)
{
struct proc_dir_entry *svc_procroot;
struct lprocfs_stats *svc_stats;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6655: remove unused function in mac.c
From: Fred Chou
Removed the unused function MACvGetShortRetryLimit, which also
fixed the following sparse warning:
drivers/staging/vt6655/mac.c:162:6: warning:
symbol 'MACvGetShortRetryLimit' was not declared. Should it be static?
Signed-off-by: Fred Chou
---
drivers/staging/vt6655/mac.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 8f0d652..09a91d1 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -30,7 +30,6 @@
* MACbIsRegBitsOff - Test if All test Bits Off
* MACbIsIntDisable - Test if MAC interrupt disable
* MACvSetShortRetryLimit - Set 802.11 Short Retry limit
- * MACvGetShortRetryLimit - Get 802.11 Short Retry limit
* MACvSetLongRetryLimit - Set 802.11 Long Retry limit
* MACvSetLoopbackMode - Set MAC Loopback Mode
* MACvSaveContext - Save Context of MAC Registers
@@ -146,24 +145,6 @@ void MACvSetShortRetryLimit(void __iomem *dwIoBase,
unsigned char byRetryLimit)
VNSvOutPortB(dwIoBase + MAC_REG_SRT, byRetryLimit);
}
-/*
- * Description:
- * Get 802.11 Short Retry Limit
- *
- * Parameters:
- * In:
- * dwIoBase- Base Address for MAC
- * Out:
- * pbyRetryLimit - Retry Limit Get
- *
- * Return Value: none
- *
- */
-void MACvGetShortRetryLimit(void __iomem *dwIoBase, unsigned char
*pbyRetryLimit)
-{
- // get SRT
- VNSvInPortB(dwIoBase + MAC_REG_SRT, pbyRetryLimit);
-}
/*
* Description:
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: range: tidy up comedi_check_chanlist()
Refactor this function to remove an extra indent level
Signed-off-by: Fred Akers
---
drivers/staging/comedi/range.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 46b3da6..c4bb13b 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -143,29 +143,28 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int
n,
unsigned int chanspec;
int chan, range_len, i;
- if (s->range_table || s->range_table_list) {
- for (i = 0; i < n; i++) {
- chanspec = chanlist[i];
- chan = CR_CHAN(chanspec);
- if (s->range_table)
- range_len = s->range_table->length;
- else if (s->range_table_list && chan < s->n_chan)
- range_len = s->range_table_list[chan]->length;
- else
- range_len = 0;
- if (chan >= s->n_chan ||
- CR_RANGE(chanspec) >= range_len ||
- aref_invalid(s, chanspec)) {
- dev_warn(dev->class_dev,
-"bad chanlist[%d]=0x%08x chan=%d range
length=%d\n",
-i, chanspec, chan, range_len);
- return -EINVAL;
- }
- }
- } else {
+ if (!s->range_table && !s->range_table_list) {
dev_err(dev->class_dev, "(bug) no range type list!\n");
return -EINVAL;
}
+ for (i = 0; i < n; i++) {
+ chanspec = chanlist[i];
+ chan = CR_CHAN(chanspec);
+ if (s->range_table)
+ range_len = s->range_table->length;
+ else if (s->range_table_list && chan < s->n_chan)
+ range_len = s->range_table_list[chan]->length;
+ else
+ range_len = 0;
+ if (chan >= s->n_chan ||
+ CR_RANGE(chanspec) >= range_len ||
+ aref_invalid(s, chanspec)) {
+ dev_warn(dev->class_dev,
+"bad chanlist[%d]=0x%08x chan=%d range
length=%d\n",
+i, chanspec, chan, range_len);
+ return -EINVAL;
+ }
+ }
return 0;
}
EXPORT_SYMBOL_GPL(comedi_check_chanlist);
--
1.8.5.3
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: range: remove unnecessary sanity check
This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list
Signed-off-by: Fred Akers
---
Apply this after first patch
drivers/staging/comedi/range.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index c4bb13b..b684954 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -143,10 +143,6 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int
n,
unsigned int chanspec;
int chan, range_len, i;
- if (!s->range_table && !s->range_table_list) {
- dev_err(dev->class_dev, "(bug) no range type list!\n");
- return -EINVAL;
- }
for (i = 0; i < n; i++) {
chanspec = chanlist[i];
chan = CR_CHAN(chanspec);
--
1.8.5.3
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/2] Staging: comedi: range: tidy up comedi_check_chanlist()
Refactor this function to remove an extra indent level
Signed-off-by: Fred Akers
---
drivers/staging/comedi/range.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 46b3da6..c4bb13b 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -143,29 +143,28 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int
n,
unsigned int chanspec;
int chan, range_len, i;
- if (s->range_table || s->range_table_list) {
- for (i = 0; i < n; i++) {
- chanspec = chanlist[i];
- chan = CR_CHAN(chanspec);
- if (s->range_table)
- range_len = s->range_table->length;
- else if (s->range_table_list && chan < s->n_chan)
- range_len = s->range_table_list[chan]->length;
- else
- range_len = 0;
- if (chan >= s->n_chan ||
- CR_RANGE(chanspec) >= range_len ||
- aref_invalid(s, chanspec)) {
- dev_warn(dev->class_dev,
-"bad chanlist[%d]=0x%08x chan=%d range
length=%d\n",
-i, chanspec, chan, range_len);
- return -EINVAL;
- }
- }
- } else {
+ if (!s->range_table && !s->range_table_list) {
dev_err(dev->class_dev, "(bug) no range type list!\n");
return -EINVAL;
}
+ for (i = 0; i < n; i++) {
+ chanspec = chanlist[i];
+ chan = CR_CHAN(chanspec);
+ if (s->range_table)
+ range_len = s->range_table->length;
+ else if (s->range_table_list && chan < s->n_chan)
+ range_len = s->range_table_list[chan]->length;
+ else
+ range_len = 0;
+ if (chan >= s->n_chan ||
+ CR_RANGE(chanspec) >= range_len ||
+ aref_invalid(s, chanspec)) {
+ dev_warn(dev->class_dev,
+"bad chanlist[%d]=0x%08x chan=%d range
length=%d\n",
+i, chanspec, chan, range_len);
+ return -EINVAL;
+ }
+ }
return 0;
}
EXPORT_SYMBOL_GPL(comedi_check_chanlist);
--
1.8.5.3
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/2] Staging: comedi: range: remove unnecessary sanity check
This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list
Signed-off-by: Fred Akers
---
drivers/staging/comedi/range.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index c4bb13b..b684954 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -143,10 +143,6 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int
n,
unsigned int chanspec;
int chan, range_len, i;
- if (!s->range_table && !s->range_table_list) {
- dev_err(dev->class_dev, "(bug) no range type list!\n");
- return -EINVAL;
- }
for (i = 0; i < n; i++) {
chanspec = chanlist[i];
chan = CR_CHAN(chanspec);
--
1.8.5.3
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names
This patch fixes a few function names that are very long and are
not in the correct naming style
Signed-off-by: Fred Akers
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 ++
drivers/staging/comedi/drivers/addi_apci_1564.c| 16 +++---
2 files changed, 36 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
index a31e115..cb426e7 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
@@ -116,7 +116,7 @@ static unsigned int ui_InterruptData, ui_Type;
/*
++
-| Function Name : int i_APCI1564_ConfigDigitalInput |
+| Function Name : int i_apci1564_di_config |
|(struct comedi_device *dev,struct comedi_subdevice
*s, |
| struct comedi_insn *insn,unsigned int *data)
|
++
@@ -141,10 +141,9 @@ static unsigned int ui_InterruptData, ui_Type;
|
|
++
*/
-static int i_APCI1564_ConfigDigitalInput(struct comedi_device *dev,
-struct comedi_subdevice *s,
-struct comedi_insn *insn,
-unsigned int *data)
+static int i_apci1564_di_config(struct comedi_device *dev,
+ struct comedi_subdevice *s,
+ struct comedi_insn *insn, unsigned int *data)
{
struct addi_private *devpriv = dev->private;
@@ -184,7 +183,7 @@ static int apci1564_di_insn_bits(struct comedi_device *dev,
/*
++
-| Function Name : int i_APCI1564_ConfigDigitalOutput |
+| Function Name : int i_apci1564_do_config |
|(struct comedi_device *dev,struct comedi_subdevice
*s, |
| struct comedi_insn *insn,unsigned int *data)
|
++
@@ -207,10 +206,9 @@ static int apci1564_di_insn_bits(struct comedi_device *dev,
|
|
++
*/
-static int i_APCI1564_ConfigDigitalOutput(struct comedi_device *dev,
- struct comedi_subdevice *s,
- struct comedi_insn *insn,
- unsigned int *data)
+static int i_apci1564_do_config(struct comedi_device *dev,
+ struct comedi_subdevice *s,
+ struct comedi_insn *insn, unsigned int *data)
{
struct addi_private *devpriv = dev->private;
unsigned int ul_Command = 0;
@@ -261,7 +259,7 @@ static int apci1564_do_insn_bits(struct comedi_device *dev,
/*
++
-| Function Name : int i_APCI1564_ConfigTimerCounterWatchdog |
+| Function Name : int i_apci1564_timer_config |
|(struct comedi_device *dev,struct comedi_subdevice
*s, |
| struct comedi_insn *insn,unsigned int *data)
|
++
@@ -289,10 +287,9 @@ static int apci1564_do_insn_bits(struct comedi_device *dev,
|
|
++
*/
-static int i_APCI1564_ConfigTimerCounterWatchdog(struct comedi_device *dev,
-struct comedi_subdevice *s,
-struct comedi_insn *insn,
-unsigned int *data)
+static int i_apci1564_timer_config(struct comedi_device *dev,
+ struct comedi_subdevice *s,
+ struct comedi_insn *insn, unsigned int *data)
{
struct addi_private *devpriv = dev->private;
unsigned int ul_Command1 = 0;
@@ -384,7 +381,7 @@ static int i_APCI1564_ConfigTimerCounterWatchdog(struct
comedi_device *dev,
/*
++
-| Function Nam
Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names
On Tuesday, March 11, 2014 02:31:07 PM Ian Abbott wrote: > On 2014-03-09 07:26, Fred Akers wrote: > > This patch fixes a few function names that are very long and are > > not in the correct naming style > > > > Signed-off-by: Fred Akers > > --- > > > > .../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 > > ++ drivers/staging/comedi/drivers/addi_apci_1564.c > > | 16 +++--- > > 2 files changed, 36 insertions(+), 42 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c index > > a31e115..cb426e7 100644 > > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > @@ -116,7 +116,7 @@ static unsigned int ui_InterruptData, ui_Type; > > > > /* > > +--- > > -+> > > -| Function Name : int i_APCI1564_ConfigDigitalInput > >| +| Function Name : int i_apci1564_di_config > > | > It would be nice to get rid of the silly i_, v_ prefixes as well! I'll submit a V2 removing those prefixes. I'm working on doing similar renames on functions for the other files under the addi-data directory as well. I'll include those in the V2 patch. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names
On Wednesday, March 12, 2014 01:06:27 AM Hartley Sweeten wrote: > On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote: > > This patch fixes a few function names that are very long and are > > not in the correct naming style > > > > Signed-off-by: Fred Akers > > Fred, > > I pulled Greg's staging tree to see if your patches apply. > > Patch 1/2 is ok but patch 2/2 does not apply: > > Applying: Staging: Comedi: addi-data: Clean up function comments > error: patch failed: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c:1 error: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c: patch does not > apply error: patch failed: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c:1 error: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c: patch does not > apply error: patch failed: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:1 error: > drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: patch does not > apply Patch failed at 0001 Staging: Comedi: addi-data: Clean up function > comments > > Maybe Greg will have better luck. > > Regards, > Hartley I think maybe the character encoding may have upset something? I'll wait and see if Greg has any luck. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] vme: remove redundant else condition
The else condition is redundant after a return. Remove these redundant else
conditions.
Signed-off-by: Fred Chou
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c
b/drivers/staging/vme/devices/vme_pio2_gpio.c
index f00af07..d8a118d 100644
--- a/drivers/staging/vme/devices/vme_pio2_gpio.c
+++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
@@ -58,14 +58,14 @@ static int pio2_gpio_get(struct gpio_chip *chip, unsigned
int offset)
if (reg & PIO2_CHANNEL_BIT[offset]) {
if (card->bank[PIO2_CHANNEL_BANK[offset]].config != BOTH)
return 0;
- else
- return 1;
- } else {
- if (card->bank[PIO2_CHANNEL_BANK[offset]].config != BOTH)
- return 1;
- else
- return 0;
+
+ return 1;
}
+
+ if (card->bank[PIO2_CHANNEL_BANK[offset]].config != BOTH)
+ return 1;
+
+ return 0;
}
static void pio2_gpio_set(struct gpio_chip *chip, unsigned int offset,
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
