Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number
From: Stephen Hemminger Date: Fri, 14 Sep 2018 12:54:55 -0700 > The Hyper-V implementation of PCI controller has concept of 32 bit serial > number > (not to be confused with PCI-E serial number). This value is sent in the > protocol > from the host to indicate SR-IOV VF device is attached to a synthetic NIC. > > Using the serial number (instead of MAC address) to associate the two devices > avoids lots of potential problems when there are duplicate MAC addresses from > tunnels or layered devices. > > The patch set is broken into two parts, one is for the PCI controller > and the other is for the netvsc device. Normally, these go through different > trees but sending them together here for better review. The PCI changes > were submitted previously, but the main review comment was "why do you > need this?". This is why. > > v2 - slot name can be shorter. > remove locking when creating pci_slots; see comment for explaination Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
From: YueHaibing Date: Thu, 20 Sep 2018 20:32:44 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. I would advise you not to send so many of these changes as a group. If one of the patches needs feedback addressed, which is already the case, you will have to resubmit the entire series all over again with the fixes. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch
From: Haiyang Zhang Date: Fri, 21 Sep 2018 18:20:34 + > From: Haiyang Zhang > > The patch adds support for LRO/RSC in the vSwitch feature. It reduces > the per packet processing overhead by coalescing multiple TCP segments > when possible. The feature is enabled by default on VMs running on > Windows Server 2019 and later. > > The patch set also adds ethtool command handler and documents. Series applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet_info internal field initialization
From: Haiyang Zhang
Date: Fri, 28 Sep 2018 14:41:23 +
> From: Haiyang Zhang
>
> The RSC feature -- a bit field "internal" was added here with total
> size unchanged:
> struct rndis_per_packet_info {
> u32 size;
> u32 type:31;
> u32 internal:1;
> u32 ppi_offset;
> };
>
> On TX path, we put rndis msg into skb head room, which is not zeroed
> before passing to us. We do not use the "internal" field in TX path,
> but it may impact older hosts which use the entire 32 bits as "type".
>
> To fix the bug, this patch sets the field "internal" to zero.
>
> Fixes: c8e4eff4675f ("hv_netvsc: Add support for LRO/RSC in the vSwitch")
> Signed-off-by: Haiyang Zhang
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 2/6] MAINTAINERS: update files maintained under DPAA2 PTP/ETHERNET
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:26 +0800 > The files maintained under DPAA2 PTP/ETHERNET needs to > be updated since dpaa2 ptp driver had been moved into > drivers/net/ethernet/freescale/dpaa2/. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 1/6] net: dpaa2: move DPAA2 PTP driver out of staging/
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:25 +0800 > This patch is to move DPAA2 PTP driver out of staging/ > since the dpaa2-eth had been moved out. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 4/6] net: dpaa2: rename rtc as ptp in dpaa2-ptp driver
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:28 +0800 > In dpaa2-ptp driver, it's odd to use rtc in names of > some functions and structures except these dprtc APIs. > This patch is to use ptp instead of rtc in names. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 3/6] net: dpaa2: fix dependency of config FSL_DPAA2_ETH
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:27 +0800 > The NETDEVICES dependency and ETHERNET dependency hadn't > been required since dpaa2-eth was moved out of staging. > Also allowed COMPILE_TEST for dpaa2-eth. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 5/6] net: dpaa2: remove unused code for dprtc
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:29 +0800 > This patch is to removed unused code for dprtc. > This code will be re-added along with more features > of dpaa2-ptp added. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3, 6/6] net: dpaa2: fix and improve dpaa2-ptp driver
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:30 +0800 > This patch is to fix and improve dpaa2-ptp driver > in some places. > > - Fixed the return for some functions. > - Replaced kzalloc with devm_kzalloc. > - Removed dev_set_drvdata(dev, NULL). > - Made ptp_dpaa2_caps const. > > Signed-off-by: Yangbo Lu Applied. You can make things much easier for me and everyone else if you provide a proper "[PATCH 0/N] ..." header posting with your patch series. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,v3] hv_netvsc: fix vf serial matching with pci slot info
From: Haiyang Zhang
Date: Mon, 15 Oct 2018 19:06:15 +
> From: Haiyang Zhang
>
> The VF device's serial number is saved as a string in PCI slot's
> kobj name, not the slot->number. This patch corrects the netvsc
> driver, so the VF device can be successfully paired with synthetic
> NIC.
>
> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")
> Reported-by: Vitaly Kuznetsov
> Signed-off-by: Haiyang Zhang
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/4] VLAN tag handling cleanup
From: Michał Mirosław Date: Tue, 20 Nov 2018 13:20:30 +0100 > This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit > handling is made similar to how other tag fields are used. Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 00/12] switchdev: Convert switchdev_port_obj_{add,del}() to notifiers
From: Petr Machata Date: Thu, 22 Nov 2018 23:27:52 + > An offloading driver may need to have access to switchdev events on > ports that aren't directly under its control. An example is a VXLAN port > attached to a bridge offloaded by a driver. The driver needs to know > about VLANs configured on the VXLAN device. However the VXLAN device > isn't stashed between the bridge and a front-panel-port device (such as > is the case e.g. for LAG devices), so the usual switchdev ops don't > reach the driver. > > VXLAN is likely not the only device type like this: in theory any L2 > tunnel device that needs offloading will prompt requirement of this > sort. > > A way to fix this is to give up the notion of port object addition / > deletion as a switchdev operation, which assumes somewhat tight coupling > between the message producer and consumer. And instead send the message > over a notifier chain. ... Series applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/8] Pass extack to NETDEV_PRE_UP
Your CC list is so huge that vger.kernel.org dropped all of your postings. That CC list is not reasonable at all, trim it down to the most minimum set. Probably 2 or 3 mailing lists, primarily netdev, and maybe a small handful of specific developers. Nothing more. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
From: Sergio Paracuellos Date: Wed, 19 Dec 2018 20:46:26 +0100 > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos I am assuming the devicetree folks will take this into their tree or similar. If I need to take this into my tree, please let me know. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled
From: Florian Westphal
Date: Fri, 21 Dec 2018 21:57:26 +0100
> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds. Use helper instead to reset the secpath.
>
> Not even compile tested.
>
> Cc: Greg Kroah-Hartman
> Reported-by: Guenter Roeck
> Fixes: 4165079ba328d ("net: switch secpath to use skb extension
> infrastructure")
> Signed-off-by: Florian Westphal
> ---
> Greg, David:
>
> The patch will not break build for a tree that lacks the 'Fixes'
> commit, so this can also go in via staging tree.
> OTOH, net-next build is broken for mips/octeon, so I think in
> this case net-next might make more sense?
Yeah I agree, that net-next is probably the best place for this.
Because I know that Linus is sensitive to situations where he is
sent a pull request, and then what he pulls doesn't match the pull
request shortlog etc. I have asked him how he would let me handle
this.
That's the only reason I haven't integrated this yet.
Just FYI!
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings
From: Sergio Paracuellos Date: Sat, 22 Dec 2018 08:39:09 +0100 > Switch bindings for spi managed mode are using spaces instead of tabs. > Fix them to get a file with a proper kernel indentation style. > > Signed-off-by: Sergio Paracuellos This doesn't apply to any of my trees so I'm going to assume this was targetting the devicetree GIT tree or something like that. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()
From: Florian Fainelli Date: Wed, 6 Feb 2019 09:45:34 -0800 > Based on discussion with Ido and feedback from Jakub there are clearly > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > > - PF/VF drivers which typically only implement return the port's parent > ID, yet have to implement switchdev_port_attr_get() just for that > > - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more > attributes which we want to be able to eventually veto in the context > of the caller, thus making them candidates for using a blocking notifier > chain > > Changes in v4: .. Series applied, thanks Florian. I'll push this out to net-next after my build tests complete. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()
From: David Miller Date: Wed, 06 Feb 2019 13:50:50 -0800 (PST) > From: Florian Fainelli > Date: Wed, 6 Feb 2019 09:45:34 -0800 > >> Based on discussion with Ido and feedback from Jakub there are clearly >> two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: >> >> - PF/VF drivers which typically only implement return the port's parent >> ID, yet have to implement switchdev_port_attr_get() just for that >> >> - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more >> attributes which we want to be able to eventually veto in the context >> of the caller, thus making them candidates for using a blocking notifier >> chain >> >> Changes in v4: > .. > > Series applied, thanks Florian. > > I'll push this out to net-next after my build tests complete. I had to remove the unused variable 'rocker' to kill a warning introduced by patch #8. Just FYI... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 00/16] net: Remove switchdev_ops
From: Florian Fainelli
Date: Sun, 10 Feb 2019 12:44:47 -0800
> I am going to submit a v3 which moves the port_attr_{get,set} to a
> switchdev notifier, but does not yet get rid of
> switchdev_port_attr_get() entirely since there is not a clear path yet
> to split the setting between non-sleeping and sleeping context.
Ok.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v3 0/9] net: Remove switchdev_ops
From: Florian Fainelli Date: Mon, 11 Feb 2019 09:31:42 -0800 > David, I will be reposting a v4 with Jiri's Acked-by as well as adding > fallthrough switch/case annotations so we don't regress on that front. > Thank you. Ok, thanks for letting me know. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v4 0/9] net: Remove switchdev_ops
From: Florian Fainelli Date: Mon, 11 Feb 2019 11:09:52 -0800 > David, I would like to get Ido's feedback on this to make sure I did not > miss something, thank you! Ok, Ido please look at this when you can. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
From: Florian Fainelli Date: Mon, 11 Feb 2019 13:17:46 -0800 > AFAICT there is no code that attempts to get the value of the attribute > SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with > switchdev_port_attr_set(). > > This is effectively no doing anything and it can slow down future work > that tries to make modifications in these areas so remove that. Series applied. > David, there should be no dependency with previous patch series, but > again, feedback from Ido and Jiri would be welcome in case this was > added for a reason. Ok, is there going to be another respin of that switchdev_ops removal series? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get()
From: Florian Fainelli Date: Fri, 15 Feb 2019 16:37:38 -0800 > David, please ignore this version, I will repost one that actually > builds, need to keep mangling with my kernel configuration and keep > those drivers enabled... Ok. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops
From: Florian Fainelli Date: Wed, 27 Feb 2019 11:44:24 -0800 > This patch series completes the removal of the switchdev_ops by > converting switchdev_port_attr_set() to use either the blocking > (process) or non-blocking (atomic) notifier since we typically need to > deal with both depending on where in the bridge code we get called from. > > This was tested with the forwarding selftests and DSA hardware. > > Ido, hopefully this captures your comments done on v1, if not, can you > illustrate with some pseudo-code what you had in mind if that's okay? > > Changes in v3: > > - added Reviewed-by tags from Ido where relevant > - added missing notifier_to_errno() in net/bridge/br_switchdev.c when > calling the atomic notifier for PRE_BRIDGE_FLAGS > - kept mlxsw_sp_switchdev_init() in mlxsw/ > > Changes in v2: > > - do not check for SWITCHDEV_F_DEFER when calling the blocking notifier > and instead directly call the atomic notifier from the single location > where this is required Series applied, thanks Florian. I'll push this out after my build tests complete. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] switchdev: Remove unused transaction item queue
From: Florian Fainelli
Date: Wed, 27 Feb 2019 16:29:16 -0800
> There are no more in tree users of the
> switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure
> in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API
> and implementation to be switchdev independant").
>
> Remove this unused code and update the documentation accordingly since.
>
> Signed-off-by: Florian Fainelli
Applied, thanks Florian.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging/octeon: Fix build error without CONFIG_NETDEVICES
From: Greg KH
Date: Wed, 31 Jul 2019 18:02:19 +0200
> From: YueHaibing
>
> While do COMPILE_TEST build without CONFIG_NETDEVICES,
> we get Kconfig warning:
>
> WARNING: unmet direct dependencies detected for PHYLIB
> Depends on [n]: NETDEVICES [=n]
> Selected by [y]:
> - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES
> [=n] || COMPILE_TEST [=y])
>
> Reported-by: Hulk Robot
> Reported-by: Mark Brown
> Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
> Signed-off-by: YueHaibing
> Signed-off-by: Greg Kroah-Hartman
Applied to net-next.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)
From: Nathan Chancellor Date: Wed, 31 Jul 2019 09:35:09 -0700 > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? > [-Werror=implicit-function-declaration] > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) One of the hi-lo, lo-hi writeq/readq headers has to be included. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning
From: Nathan Chancellor Date: Wed, 31 Jul 2019 11:50:24 -0700 > arm allyesconfig warns: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > Selected by [y]: > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > NETDEVICES [=y] || COMPILE_TEST [=y]) > > and errors: > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? The proper way to fix this is to include either linux/io-64-nonatomic-hi-lo.h or linux/io-64-nonatomic-lo-hi.h whichever is appropriate. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors
From: Nathan Chancellor
Date: Fri, 2 Aug 2019 23:01:56 -0700
> After commit 171a9bae68c7 ("staging/octeon: Allow test build on
> !MIPS"), the following combination of configs cause a few Kconfig
> warnings and build errors (distilled from arm allyesconfig and Randy's
> randconfig builds):
>
> CONFIG_NETDEVICES=y
> CONFIG_STAGING=y
> CONFIG_COMPILE_TEST=y
>
> and CONFIG_OCTEON_ETHERNET as either a module or built-in.
>
> WARNING: unmet direct dependencies detected for MDIO_OCTEON
> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n]
> Selected by [y]:
> - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC ||
> COMPILE_TEST [=y]) && NETDEVICES [=y]
>
> In file included from ../drivers/net/phy/mdio-octeon.c:14:
> ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> function ‘writeq’; did you mean ‘writel’?
> [-Werror=implicit-function-declaration]
> 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr)
> |^~
>
> CONFIG_64BIT is not strictly necessary if the proper readq/writeq
> definitions are included from io-64-nonatomic-lo-hi.h.
>
> CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because
> of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h.").
>
> Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
> Reported-by: kbuild test robot
> Reported-by: Mark Brown
> Reported-by: Randy Dunlap
> Signed-off-by: Nathan Chancellor
Applied to net-next.
Please make it clear what tree your changes are targetting in the future,
thank you.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hp100: Move 100BaseVG AnyLAN driver to staging
From: Joe Perches Date: Thu, 31 Oct 2019 11:23:37 -0700 > 100BaseVG AnyLAN hasn't been useful since 1996 or so and even then > didn't sell many devices. It's unlikely any are still in use. > > Move the driver to staging with the intent of removing it altogether > one day. > > Signed-off-by: Joe Perches Applied to net-next. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
From: Greg KH Date: Mon, 4 Nov 2019 13:20:09 +0100 > Why is this being submitted to staging? What is wrong with the "real" > part of the kernel for this? Agreed, this makes no sense at all. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host
From: Haiyang Zhang Date: Tue, 11 Nov 2014 15:27:52 -0800 > - if (mtu < 68 || mtu > limit) > + if (mtu < ETH_DATA_LEN || mtu > limit) > return -EINVAL; This is not correct. The test is against the minimally supported MTU, which should be 68 not ETH_DATA_LEN which is 1500. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host
From: Haiyang Zhang Date: Wed, 12 Nov 2014 20:02:11 + > The Hyper-V host doesn't support MTU below 1500. If we try setting MTU to a > value < 1500, the host will use 1500 automatically and return 1500 in the > RNDIS_OID_GEN_MAXIMUM_FRAME_SIZE query and guest will also use it. That's > why I set the lower limit to ETH_DATA_LEN. > > Are you suggesting that we keep the 68 as the lower limit, and let the host > auto-reset it to 1500 when we trying to set an MTU < 1500? Then you need to add a comment, because without any information or context that change looks wrong. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,v2] hyperv: Add processing of MTU reduced by the host
From: Haiyang Zhang Date: Wed, 12 Nov 2014 14:07:44 -0800 > If the host uses packet encapsulation feature, the MTU may be reduced by the > host due to headroom reservation for encapsulation. This patch handles this > new MTU value. > > Signed-off-by: Haiyang Zhang Applied, thanks for adding the comment. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
From: SF Markus Elfring Date: Thu, 20 Nov 2014 15:25:27 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 15:15:21 +0100 > > The vfree() function performs also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring This does not apply to the net-next tree, please respin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
From: SF Markus Elfring Date: Fri, 21 Nov 2014 23:15:42 +0100 >> This does not apply to the net-next tree, please respin. > > Thanks for your reply. > > How do you think about to try out the scripts which I published > in March to get more constructive feedback? This has nothing to do with me asking you to frame your patches against the correct tree. If I had time to investigate automation of changes using such tools, I would participate in such discussions, but I don't. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
From: SF Markus Elfring Date: Sun, 23 Nov 2014 01:51:24 +0100 >> This has nothing to do with me asking you to frame your patches >> against the correct tree. > > I imagine than someone other can also pick up this update suggestion > (a simple change of two lines) quicker before I might try another > software build again from a different commit as a base. Whereas if you learn how to base your changes cleanly on the correct base now, all of your future submissions will go quickly and smoothly into my tree. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
From: SF Markus Elfring Date: Sun, 23 Nov 2014 08:18:31 +0100 >> Whereas if you learn how to base your changes cleanly on the correct >> base now, all of your future submissions will go quickly and smoothly >> into my tree. > > My reluctance to work with more Linux repositories will evolve > over time. The faster affected software versions can be rebuilt > the more it will become interesting to try even more source > code improvements out, won't it? > > I find it nice that you could accept update suggestions for > a few other Linux components already. You are seriously starting to waste our time. Either resubmit your changes against a clean base, or more on. Seriously, all I am purely interested in is seeing properly submitted patches, reviewing them, and then integrating them. Anything else is pure noise to me. Thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
From: SF Markus Elfring Date: Tue, 25 Nov 2014 22:55:34 +0100 > From: Markus Elfring > Date: Tue, 25 Nov 2014 22:33:45 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Signed-off-by: Haiyang Zhang Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hyperv: Add support for vNIC hot removal
From: Haiyang Zhang Date: Mon, 1 Dec 2014 13:28:39 -0800 > This patch adds proper handling of the vNIC hot removal event, which includes > a rescind-channel-offer message from the host side that triggers vNIC close > and > removal. In this case, the notices to the host during close and removal is not > necessary because the channel is rescinded. This patch blocks these > unnecessary > messages, and lets vNIC removal process complete normally. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hyperv: Fix some variable name typos in send-buffer init/revoke
From: Haiyang Zhang Date: Fri, 19 Dec 2014 18:25:18 -0800 > The changed names are union fields with the same size, so the existing code > still works. But, we now update these variables to the correct names. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes
From: Petr Štetiar Date: Mon, 6 May 2019 23:24:43 +0200 > this patch series is an attempt to fix the mess, I've somehow managed to > introduce. > > First patch in this series is defacto v5 of the previous 05/10 patch in the > series, but since the v4 of this 05/10 patch wasn't picked up by the > patchwork for some unknown reason, this patch wasn't applied with the other > 9 patches in the series, so I'm resending it as a separate patch of this > fixup series again. > > Second patch is a result of this rebase against net-next tree, where I was > checking again all current users of of_get_mac_address and found out, that > there's new one in DSA, so I've converted this user to the new ERR_PTR > encoded error value as well. > > Third patch which was sent as v5 wasn't considered for merge, but I still > think, that we need to check for possible NULL value, thus current IS_ERR > check isn't sufficient and we need to use IS_ERR_OR_NULL instead. > > Fourth patch fixes warning reported by kbuild test robot. Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [GIT PULL net-next, resend] isdn: deprecate non-mISDN drivers
From: Arnd Bergmann Date: Fri, 31 May 2019 14:32:52 +0200 > [resending, rebased on top of today's net-next] > > The following changes since commit 7b3ed2a137b077bc0967352088b0adb6049eed20: > > Merge branch '100GbE' of > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue > (2019-05-30 15:17:05 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git > tags/isdn-removal > > for you to fetch changes up to 6d97985072dc270032dc7a08631080bfd6253e82: > > isdn: move capi drivers to staging (2019-05-31 11:17:41 +0200) Pulled, thanks Arnd. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/12] treewide: Fix GENMASK misuses
From: Joe Perches Date: Tue, 9 Jul 2019 22:04:13 -0700 > These GENMASK uses are inverted argument order and the > actual masks produced are incorrect. Fix them. > > Add checkpatch tests to help avoid more misuses too. Patches #7 and #8 applied to 'net', with appropriate Fixes tags added to #8. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
From: David Miller
Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)
> From: YueHaibing
> Date: Wed, 24 Jul 2019 21:01:26 +0800
>
>> Now if CONFIG_ETHERNET is not set, QLGE driver
>> building fails:
>>
>> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
>> drivers/staging/qlge/qlge_main.c:4831: undefined reference to
>> `unregister_netdev'
>>
>> Reported-by: Hulk Robot
>> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to
>> drivers/staging/qlge/")
>> Signed-off-by: YueHaibing
>
> I'll let Greg take this.
Actually, I take that back.
Since the move to staging happened in my tree I will take this ;-)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
From: YueHaibing
Date: Wed, 24 Jul 2019 21:01:26 +0800
> Now if CONFIG_ETHERNET is not set, QLGE driver
> building fails:
>
> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> drivers/staging/qlge/qlge_main.c:4831: undefined reference to
> `unregister_netdev'
>
> Reported-by: Hulk Robot
> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to
> drivers/staging/qlge/")
> Signed-off-by: YueHaibing
I'll let Greg take this.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v5 12/29] compat_ioctl: move drivers to compat_ptr_ioctl
From: Arnd Bergmann Date: Tue, 30 Jul 2019 21:50:28 +0200 > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Hartman > Acked-by: Michael S. Tsirkin > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jason Gunthorpe > Reviewed-by: Jiri Kosina > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Arnd Bergmann I assume this has to go via your series, thus: Acked-by: David S. Miller ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)
From: Greg Kroah-Hartman Date: Wed, 31 Jul 2019 13:35:22 +0200 > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: >> >> Today's -next fails to build an ARM allmodconfig due to: >> >> > allmodconfig (arm, gcc-8) ― FAIL, 1 error, 40 warnings, 0 section >> > mismatches >> > >> > Errors: >> > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of >> > function 'writeq'; did you mean 'writel'? >> > [-Werror=implicit-function-declaration] >> >> as a result of the changes that introduced: >> >> WARNING: unmet direct dependencies detected for MDIO_OCTEON >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && >> 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] >> Selected by [m]: >> - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES >> [=y] || COMPILE_TEST [=y]) >> >> which is triggered by the staging OCTEON_ETHERNET driver which misses a >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 >> (staging/octeon: Allow test build on !MIPS). > > A patch was posted for this, but it needs to go through the netdev tree > as that's where the offending patches are coming from. I didn't catch that, was netdev CC:'d? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 net-next 2/2] hv_netvsc: avoid unnecessary wakeups on subchannel creation
From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:06 -0700 > Only need to wakeup the initiator after all sub-channels > are opened. > > Signed-off-by: Stephen Hemminger Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 net-next 1/2] hv_netvsc: fix deadlock on hotplug
From: Stephen Hemminger
Date: Wed, 6 Sep 2017 13:53:05 -0700
> When a virtual device is added dynamically (via host console), then
> the vmbus sends an offer message for the primary channel. The processing
> of this message for networking causes the network device to then
> initialize the sub channels.
>
> The problem is that setting up the sub channels needs to wait until
> the subsequent subchannel offers have been processed. These offers
> come in on the same ring buffer and work queue as where the primary
> offer is being processed; leading to a deadlock.
>
> This did not happen in older kernels, because the sub channel waiting
> logic was broken (it wasn't really waiting).
>
> The solution is to do the sub channel setup in its own work queue
> context that is scheduled by the primary channel setup; and then
> happens later.
>
> Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation")
> Reported-by: Dexuan Cui
> Signed-off-by: Stephen Hemminger
> ---
> v2 - fix module removal race with new work queue
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net] netvsc: increase default receive buffer size
From: Stephen Hemminger
Date: Thu, 14 Sep 2017 09:31:07 -0700
> The default receive buffer size was reduced by recent change
> to a value which was appropriate for 10G and Windows Server 2016.
> But the value is too small for full performance with 40G on Azure.
> Increase the default back to maximum supported by host.
>
> Fixes: 8b5327975ae1 ("netvsc: allow controlling send/recv buffer size")
> Signed-off-by: Stephen Hemminger
What other side effects are there to making this buffer so large?
Just curious...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net] netvsc: increase default receive buffer size
From: Stephen Hemminger
Date: Thu, 14 Sep 2017 09:31:07 -0700
> The default receive buffer size was reduced by recent change
> to a value which was appropriate for 10G and Windows Server 2016.
> But the value is too small for full performance with 40G on Azure.
> Increase the default back to maximum supported by host.
>
> Fixes: 8b5327975ae1 ("netvsc: allow controlling send/recv buffer size")
> Signed-off-by: Stephen Hemminger
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size
From: Colin King Date: Fri, 22 Sep 2017 16:50:23 +0100 > From: Colin Ian King > > Don't populate const array ver_list on the stack, instead make it > static. Makes the object code smaller by over 400 bytes: > > Before: >text data bss dec hex filename > 18444 3168 320 2193255ac drivers/net/hyperv/netvsc.o > > After: >text data bss dec hex filename > 17950 3224 320 2149453f6 drivers/net/hyperv/netvsc.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Applied to net-next, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] timer: Remove meaningless .data/.function assignments
From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc: Krzysztof Halasa > Cc: Aditya Shankar > Cc: Ganesh Krishna > Cc: Greg Kroah-Hartman > Cc: Jens Axboe > Cc: net...@vger.kernel.org > Cc: linux-wirel...@vger.kernel.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Kees Cook > Acked-by: Greg Kroah-Hartman # for staging > Acked-by: Krzysztof Halasa # for wan/hdlc* > Acked-by: Jens Axboe # for amiflop > --- > This should go via the timer/core tree, please. It's been acked by each > of the maintainers. Thanks! For networking bits: Acked-by: David S. Miller ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net] hv_sock: add locking in the open/close/release code paths
From: Dexuan Cui Date: Thu, 19 Oct 2017 03:33:14 + > > Without the patch, when hvs_open_connection() hasn't completely established > a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't > inserted the sock into the connected queue), vsock_stream_connect() may see > the sk_state change and return the connection to the userspace, and next > when the userspace closes the connection quickly, hvs_release() may not see > the connection in the connected queue; finally hvs_open_connection() > inserts the connection into the queue, but we won't be able to purge the > connection for ever. > > Signed-off-by: Dexuan Cui Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 3/4] hv_netvsc: reset net_device_ctx->nvdev with rcu_assign_pointer()
From: Vitaly Kuznetsov Date: Tue, 31 Oct 2017 15:40:06 +0100 > Eric Dumazet writes: > >> On Tue, 2017-10-31 at 14:42 +0100, Vitaly Kuznetsov wrote: >>> RCU_INIT_POINTER() is not suitable here as it doesn't give us ordering >>> guarantees (see the comment in rcupdate.h). This is also not a hotpath. >>> >>> Signed-off-by: Vitaly Kuznetsov >>> --- >>> drivers/net/hyperv/netvsc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c >>> index bfc79698b8f4..12efb3e34775 100644 >>> --- a/drivers/net/hyperv/netvsc.c >>> +++ b/drivers/net/hyperv/netvsc.c >>> @@ -560,7 +560,7 @@ void netvsc_device_remove(struct hv_device *device) >>> >>> netvsc_revoke_buf(device, net_device); >>> >>> - RCU_INIT_POINTER(net_device_ctx->nvdev, NULL); >>> + rcu_assign_pointer(net_device_ctx->nvdev, NULL); >> >> I see no point for this patch. >> >> Setting a NULL pointer needs no barrier at all. > > Oh, sorry, I got confused by the comment near RCU_INIT_POINTER() in > rcupdate.h. Now looking at their definitions I see. > > This patch can of course be dropped from the series. Any time there is a change to the series, you must resubmit the entire series. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes
From: Vitaly Kuznetsov Date: Thu, 2 Nov 2017 11:35:29 +0100 > It was found that netvsc driver doesn't survive e.g. > > # while true; do ethtool -L eth0 combined 4; ethtool -L eth0 combined 8; done" > > test. I was able to identify a hang in guest/host communication, it is > fixed by PATCH1 of this series. PATCH2 is a cosmetic change masking > unneeded messages. > > Changes since v1: > - Throw away patches 2 and 3 of the original series as one is unneeded and > the other is not justified [Eric Dumazet, Stephen Hemminger] so I'm only > fixing the hang now, the crash doesn't reproduce. Will keep an eye on it. Series applied to net-next, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/2] retire IPX and NCPFS
From: Stephen Hemminger Date: Tue, 14 Nov 2017 08:37:13 -0800 > These are both old decrepit protocols that need to be sent > to pasture. These need to go to gregkh and his staging/ tree, not net-next. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/2] retire IPX and NCPFS
From: Greg KH Date: Wed, 15 Nov 2017 10:13:18 +0100 > On Wed, Nov 15, 2017 at 09:58:33AM +0900, David Miller wrote: >> From: Stephen Hemminger >> Date: Tue, 14 Nov 2017 08:37:13 -0800 >> >> > These are both old decrepit protocols that need to be sent >> > to pasture. >> >> These need to go to gregkh and his staging/ tree, not net-next. > > I'll gladly take them, as long as you have no objection and I can get an > ack for them. No objection: Acked-by: David S. Miller ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net v2] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes
From: Vitaly Kuznetsov
Date: Wed, 15 Nov 2017 15:12:55 +0100
> rndis_filter_device_add() is called both from netvsc_probe() when we
> initially create the device and from set channels/mtu/ringparam
> routines where we basically remove the device and add it back.
>
> hw_features is reset in rndis_filter_device_add() and filled with
> host data. However, we lose all additional flags which are set outside
> of the driver, e.g. register_netdevice() adds NETIF_F_SOFT_FEATURES and
> many others.
>
> Unfortunately, calls to rndis_{query_hwcaps(), _set_offload_params()}
> calls cannot be avoided on every RNDIS reset: host expects us to set
> required features explicitly. Moreover, in theory hardware capabilities
> can change and we need to reflect the change in hw_features.
>
> Reset net->hw_features bits according to host data in
> rndis_netdev_set_hwcaps(), clear corresponding feature bits
> from net->features in case some features went missing (will never happen
> in real life I guess but let's be consistent).
>
> Signed-off-by: Vitaly Kuznetsov
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 0/8] Cavium OCTEON-III network driver.
The net-next tree is closed, please resubmit this when the net-next tree opens again. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/6] hv_netvsc: minor optimizations
From: Stephen Hemminger Date: Fri, 1 Dec 2017 11:01:43 -0800 > These are a set of local optimizations the Hyper-V networking driver. > Also include a vmbus patch in this set, because it depends on the > netvsc that last used that function. Series applied. For the ring percentage stuff, I would suggest sticking to power of 2 arithmetic (and thus approximations) even when the ring size is not a power of 2. That way you won't even need multiplies. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size
From: Dan Carpenter Date: Fri, 8 Dec 2017 13:33:25 +0300 > On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote: >> From: Haiyang Zhang >> >> It should be 31 MB on recent host versions. >> >> Signed-off-by: Haiyang Zhang >> Signed-off-by: Stephen Hemminger > > This is very vague. What does "recent" mean in this context? There are > also some unrelated white space changes here which make the patch harder > to read. > > This patch kind of makes the bug fixed by patch 2 even worse because > before the receive buffer was capped at around 16MB and now we can set > the receive buffer to 31MB. It might make sense to fold the two > patches together. > > Is patch 2 a memory corruption bug? The changelog doesn't really say > what the user visible effects of the bug are. Basically if you make the > buffer too small then it's a performance issue but if you make it too > large what happens? It's not clear to me. Agreed with Dan, we definitely need more verbose and detailed commit log messages for this series. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/2] hv_netvsc: Fix default and limit of recv buffe
From: Stephen Hemminger Date: Mon, 11 Dec 2017 08:56:56 -0800 > The default for receive buffer descriptors is not correct, it should > match the default receive buffer size and the upper limit of receive > buffer size is too low. Also, for older versions of Window servers > hosts, different lower limit check is necessary, otherwise the buffer > request will be rejected by the host, resulting vNIC not come up. > > This patch set corrects these problems. Series applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/6] hv_netvsc: minor changes
From: Stephen Hemminger Date: Tue, 12 Dec 2017 16:48:34 -0800 > This includes minor cleanup of code in send and receive path and > also a new statistic to check for allocation failures. This also > eliminates some of the extra RCU when not needed. > > There is a theoritical bug where buffered data could be blocked > for longer than necessary if the ring buffer got full. This > has not been seen in the wild, found by inspection. > > The reference count between net device and internal RNDIS > is not needed. Series applied, thanks Stephen. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync
From: Haiyang Zhang
Date: Fri, 29 Jun 2018 14:07:16 -0700
> From: Stephen Hemminger
>
> When doing device hotplug the sub channel must be async to avoid
> deadlock issues because device is discovered in softirq context.
>
> When doing changes to MTU and number of channels, the setup
> must be synchronous to avoid races such as when MTU and device
> settings are done in a single ip command.
>
> Reported-by: Thomas Walker
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation")
> Signed-off-by: Stephen Hemminger
> Signed-off-by: Haiyang Zhang
Applied and queued up for -stable.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net,v2] hv_netvsc: Fix napi reschedule while receive completion is busy
From: Haiyang Zhang
Date: Tue, 17 Jul 2018 17:11:13 +
> From: Haiyang Zhang
>
> If out ring is full temporarily and receive completion cannot go out,
> we may still need to reschedule napi if certain conditions are met.
> Otherwise the napi poll might be stopped forever, and cause network
> disconnect.
>
> Fixes: 7426b1a51803 ("netvsc: optimize receive completions")
> Signed-off-by: Stephen Hemminger
> Signed-off-by: Haiyang Zhang
Applied and queued up for -stable.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes
From: Guenter Roeck
Date: Mon, 23 Jul 2018 14:39:33 -0700
> Including asm/cacheflush.h first results in the following build error when
> trying to build sparc32:allmodconfig.
...
> Include generic includes files first to fix the problem.
>
> Fixes: fc96d58c10162 ("[media] v4l: omap4iss: Add support for OMAP4 camera
> interface - Video devices")
> Suggested-by: Linus Torvalds
> Cc: David Miller
> Cc: Randy Dunlap
> Signed-off-by: Guenter Roeck
Acked-by: David S. Miller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc
From: Yidong Ren Date: Mon, 30 Jul 2018 17:09:45 + > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters already exist in current code. Exposing > these counters will help troubleshooting performance issues. > > for_each_present_cpu() was used instead of for_each_possible_cpu(). > for_each_possible_cpu() would create very long and useless output. > It is still being used for internal buffer, but not for ethtool > output. > > There could be an overflow if cpu was added between ethtool > call netvsc_get_sset_count() and netvsc_get_ethtool_stats() and > netvsc_get_strings(). (still safe if cpu was removed) > ethtool makes these three function calls separately. > As long as we use ethtool, I can't see any clean solution. > > Currently and in foreseeable short term, Hyper-V doesn't support > cpu hot-plug. Plus, ethtool is for admin use. Unlikely the admin > would perform such combo operations. > > Signed-off-by: Yidong Ren Applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback
From: Takashi Iwai
Date: Tue, 14 Aug 2018 19:10:50 +0200
> The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback
> to single queue mode") tried to fix the fallback behavior to a single
> queue mode, but it changed the function to return zero incorrectly,
> while the function should return an object pointer. Eventually this
> leads to a NULL dereference at the callers that expect non-NULL
> value.
>
> Fix it by returning the proper net_device object.
>
> Fixes: 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue
> mode")
> Signed-off-by: Takashi Iwai
Applied and queued up for -stable.
Please do not put explicit "CC: stable" notations in networking patches, I queue
up and submit networking patches to -stable explicitly.
Thank you.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()
From: Dexuan Cui Date: Wed, 22 Aug 2018 21:20:03 + > --- > drivers/net/hyperv/netvsc_drv.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > > FYI: these are the related 3 paths which show the deadlock: This incredibly useful information belongs in the commit log message, and therefore before the --- and signoffs. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()
From: Dexuan Cui Date: Thu, 30 Aug 2018 00:58:48 + >> From: David Miller >> Sent: Wednesday, August 29, 2018 17:49 >> >> From: Dexuan Cui >> Date: Wed, 22 Aug 2018 21:20:03 + >> >> > --- >> > drivers/net/hyperv/netvsc_drv.c | 11 ++- >> > 1 file changed, 10 insertions(+), 1 deletion(-) >> > >> > >> > FYI: these are the related 3 paths which show the deadlock: >> >> This incredibly useful information belongs in the commit log >> message, and therefore before the --- and signoffs. > > Hi David, > I was afraid the call-traces are too detailed. :-) > > Can you please move the info to before the --- line? > > Or, should I resend the patch with the commit log updated? Please resend. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()
From: Dexuan Cui
Date: Thu, 30 Aug 2018 05:42:13 +
>
> This patch fixes the race between netvsc_probe() and
> rndis_set_subchannel(), which can cause a deadlock.
>
> These are the related 3 paths which show the deadlock:
...
> Before path #1 finishes, path #2 can start to run, because just before
> the "bus_probe_device(dev);" in device_add() in path #1, there is a line
> "object_uevent(&dev->kobj, KOBJ_ADD);", so systemd-udevd can
> immediately try to load hv_netvsc and hence path #2 can start to run.
>
> Next, path #2 offloads the subchannal's initialization to a workqueue,
> i.e. path #3, so we can end up in a deadlock situation like this:
>
> Path #2 gets the device lock, and is trying to get the rtnl lock;
> Path #3 gets the rtnl lock and is waiting for all the subchannel messages
> to be processed;
> Path #1 is trying to get the device lock, but since #2 is not releasing
> the device lock, path #1 has to sleep; since the VMBus messages are
> processed one by one, this means the sub-channel messages can't be
> procedded, so #3 has to sleep with the rtnl lock held, and finally #2
> has to sleep... Now all the 3 paths are sleeping and we hit the deadlock.
>
> With the patch, we can make sure #2 gets both the device lock and the
> rtnl lock together, gets its job done, and releases the locks, so #1
> and #3 will not be blocked for ever.
>
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Signed-off-by: Dexuan Cui
Applied and queued up for -stable.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver
From: Ioana Radulescu Date: Wed, 29 Aug 2018 04:42:38 -0500 > The Freescale/NXP DPAA2 Ethernet driver was first included in > drivers/staging, due to its dependencies on two components located > there at the time of its initial submission: > * the fsl-mc bus driver, which was moved to drivers/bus in kernel 4.17 > * the dpio driver, which was moved to drivers/soc/fsl in kernel 4.18 > > More information on the DPAA2 architecture and the interactions > between the fsl-mc bus and the objects present on it can be found in: > Documentation/networking/dpaa2/overview.rst > > For easier review, the patch is generated without the -M option, > although the driver files are moved without any code changes. > > changes since v1[1]: > * remove RFC label, since dependencies have been merged on net-next > * add patch fixing a possible race at probe (reported by Andrew Lunn) > > [1] https://lore.kernel.org/patchwork/patch/971333/ Series applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 1/2] PCI: hv: support reporting serial number as slot information
From: Stephen Hemminger
Date: Wed, 29 Aug 2018 09:24:51 -0700
> + spin_lock_irqsave(&hbus->device_list_lock, flags);
> + list_for_each_entry(hpdev, &hbus->children, list_entry) {
> + if (hpdev->pci_slot)
> + continue;
> +
> + slot_nr = PCI_SLOT(wslot_to_devfn(hpdev->desc.win_slot.slot));
> + snprintf(name, SLOT_NAME_SIZE, "%u", hpdev->desc.ser);
> + hpdev->pci_slot = pci_create_slot(hbus->pci_bus, slot_nr,
> + name, NULL);
pci_create_slot() takes a mutex, therefore you can't hold a spinlock or
disable interrupts here.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] netvsc: fix use-after-free in netvsc_change_mtu()
From: Dexuan Cui Date: Thu, 2 Mar 2017 13:00:53 + > 'nvdev' is freed in rndis_filter_device_remove -> netvsc_device_remove -> > free_netvsc_device, so we mustn't access it, before it's re-created in > rndis_filter_device_add -> netvsc_device_add. > > Signed-off-by: Dexuan Cui Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings
From: Philippe Reynes
Date: Wed, 8 Mar 2017 23:41:04 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 0/2] netvsc: Fix miscellaneous issues
From: k...@exchange.microsoft.com Date: Fri, 24 Mar 2017 20:54:08 -0700 > Fix miscellaneous issues. Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] netvsc: fix dereference before null check errors
From: Haiyang Zhang
Date: Mon, 27 Mar 2017 00:50:27 +
>
>
>> -Original Message-
>> From: Colin King [mailto:colin.k...@canonical.com]
>> Sent: Saturday, March 25, 2017 10:27 AM
>> To: KY Srinivasan ; Haiyang Zhang
>> ; Stephen Hemminger ;
>> de...@linuxdriverproject.org; net...@vger.kernel.org
>> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org
>> Subject: [PATCH] netvsc: fix dereference before null check errors
>>
>> From: Colin Ian King
>>
>> ndev is being checked to see if it is a null pointer however before
>> the null check ndev is being dereferenced; hence there is a potential
>> null pointer dereference bug that needs fixing. Fix this by only
>> dereferencing ndev after the null check.
>>
>> Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference
>> before null check")
>>
>> Signed-off-by: Colin Ian King
>
> Reviewed-by: Haiyang Zhang
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation
From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang The net-next tree is closed, please resubmit this when the net-next tree reopens. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts
From: Mohammed Gamal
Date: Thu, 5 Apr 2018 21:09:17 +0200
> Guests running on WS2012 hosts would not shutdown when changing network
> interface setting (e.g. Number of channels, MTU ... etc).
>
> This patch series addresses these shutdown issues we enecountered with WS2012
> hosts. It's essentialy a rework of the series sent in
> https://lkml.org/lkml/2018/1/23/111 on top of latest upstream
>
> Fixes: 0ef58b0a05c1 ("hv_netvsc: change GPAD teardown order on older
> versions")
Series applied, thank you.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload
From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 > Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Also, all of your networking submissions have been dropped because the net-next tree is closed. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation
From: Haiyang Zhang Date: Tue, 17 Apr 2018 15:31:47 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 and 6.1 message structures, and includes > these versions into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang Zhang Applied to net-next, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
From: Mohammed Gamal
Date: Wed, 9 May 2018 10:17:34 +0200
> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
>
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
>
> Signed-off-by: Mohammed Gamal
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Add handlers for ethtool get/set msg level
From: Haiyang Zhang Date: Tue, 22 May 2018 11:29:34 -0700 > From: Haiyang Zhang > > The handlers for ethtool get/set msg level are missing from netvsc. > This patch adds them. > > Signed-off-by: Haiyang Zhang Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs
From: Petr Machata
Date: Wed, 30 May 2018 02:55:34 +0200
> In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap
> mirror"), mlxsw got support for offloading mirror-to-gretap such that
> the underlay packet path involves a bridge. In that case, the offload is
> also influenced by PVID setting of said bridge. However, changes to VLAN
> configuration of the bridge itself do not generate switchdev
> notifications, so there's no mechanism to prod mlxsw to update the
> offload when these settings change.
>
> In this patchset, the problem is resolved by distributing the switchdev
> notification SWITCHDEV_OBJ_ID_PORT_VLAN also for configuration changes
> on bridge VLANs. Since stacked devices distribute the notification to
> lower devices, such event eventually reaches the driver, which can
> determine whether it's a bridge or port VLAN by inspecting orig_dev.
>
> To keep things consistent, the newly-distributed notifications observe
> the same protocol as the existing ones: dual prepare/commit, with
> -EOPNOTSUPP indicating lack of support, even though there's currently
> nothing to prepare for and nothing to support. Correspondingly, all
> switchdev drivers have been updated to return -EOPNOTSUPP for bridge
> VLAN notifications.
>
> In patches #1 and #2, the code base is changed to support the following
> additions: functions br_switchdev_port_vlan_add() and
> br_switchdev_port_vlan_del() are introduced to simplify sending
> notifications; and br_vlan_add_existing() is introduced to later make it
> simpler to add error-handling code for the case of configuring a
> preexisting VLAN on bridge CPU port.
>
> In patches #3-#6, respectively for mlxsw, rocker, DSA and DPAA2 ethsw,
> the new notifications (which are not enabled yet) are ignored to
> maintain the current behavior.
>
> In patch #7, the notification is actually enabled.
>
> In patch #8, mlxsw is changed to update offloads of mirror-to-gre also
> for bridge-related notifications.
...
Series applied, thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()
From: Wei Yongjun
Date: Thu, 31 May 2018 02:04:43 +
> Fix to return a negative error code from the failover register fail
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use
> the failover framework")
> Signed-off-by: Wei Yongjun
Applied, thank you.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup
From: Dexuan Cui
Date: Wed, 6 Jun 2018 21:32:51 +
>
> Recently people reported the NIC stops working after
> "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not
> enabled, after the refactoring of the common detach logic: when the NIC
> has sub-channels, usually we enable all the TX queues after all
> sub-channels are set up: see rndis_set_subchannel() ->
> netif_device_attach(), but in the case of "ifdown eth0; ifup eth0" where
> the number of channels doesn't change, we also must make sure the TX queues
> are enabled. The patch fixes the regression.
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> Signed-off-by: Dexuan Cui
Applied and queued up for -stable.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hv_netvsc: Add per-cpu ethtool stats for netvsc
From: Yidong Ren Date: Wed, 6 Jun 2018 15:27:00 -0700 > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters exist in current code. Exposing these > counters will help troubleshooting performance issues. > > Signed-off-by: Yidong Ren net-next is closed, please resubmit this new feature when it opens again, also: > + // fetch percpu stats of vf Please do not use c++ comments. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net 0/3] hv_netvsc: notification and namespace fixes
From: Stephen Hemminger Date: Mon, 11 Jun 2018 12:44:53 -0700 > This set of patches addresses two set of fixes. First it backs out > the common callback model which was merged in net-next without > completing all the review feedback or getting maintainer approval. > > Then it fixes the transparent VF management code to handle network > namespaces. Series applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload
Bug fixes should be targetted at net, not net-next. Furthermore, net-next is closed. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload
From: Haiyang Zhang Date: Thu, 14 Jun 2018 18:29:09 -0700 > From: Haiyang Zhang > > These fields in struct ndis_ipsecv2_offload and struct ndis_rsc_offload > are one byte according to the specs. This patch defines them with the > right size. These structs are not in use right now, but will be used soon. > > Signed-off-by: Haiyang Zhang Applied, thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,1/3] hv_netvsc: Clean up two unused variables
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:52 -0700 > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,2/3] hv_netvsc: Define a macro RNDIS_AND_PPI_SIZE
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:53 -0700 > The sum of RNDIS msg and PPI struct sizes is used in multiple places, so we > define > a macro for them. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,3/3] hv_netvsc: Fix the packet free when it is in skb headroom
From: Haiyang Zhang Date: Mon, 6 Apr 2015 15:22:54 -0700 > In the two places changed, we now use netvsc_xmit_completion() which properly > frees hv_netvsc_packet in or not in skb headroom. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/2] hv_netvsc: linearize SKBs bigger than MAX_PAGE_BUFFER_COUNT-2 pages
From: Vitaly Kuznetsov
Date: Wed, 8 Apr 2015 17:54:04 +0200
> This patch series fixes the same issue which was fixed in Xen with commit
> 97a6d1bb2b658ac85ed88205ccd1ab809899884d ("xen-netfront: Fix handling packets
> on
> compound pages with skb_linearize").
This patch series only applies on net-next, so that's where I put it.
Please be completely explicit about this in the future, rather than
forcing me to try and figure it out.
Thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] hv_netvsc: Implement partial copy into send buffer
From: Haiyang Zhang Date: Mon, 13 Apr 2015 16:34:35 -0700 > If remaining space in a send buffer slot is too small for the whole message, > we only copy the RNDIS header and PPI data into send buffer, so we can batch > one more packet each time. It reduces the vmbus per-message overhead. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode
From: six...@microsoft.com Date: Tue, 21 Apr 2015 15:58:05 -0700 > From: Simon Xiao > > Signed-off-by: Simon Xiao > Reviewed-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang I just gave you feedback on this patch in response to your original submission, do not ignore it. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode
From: Simon Xiao Date: Tue, 21 Apr 2015 22:14:14 + > In current netvsc driver, for each packet received, it will call > dump_rndis_message() to try to dump the rndis packet information by > netdev_dbg(). In non-debug mode, dump_rndis_message() will not dump > anything but it still initialize some local variables and process > the switch logic in the function of dump_rndis_message(), which is > unnecessary, especially in high network throughput situation. See NETIF_MSG_* and use it properly in your driver, read other drivers and learn how to properly use it for things like this. I'm not going to explain this a third time. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
