Re: [PATCH 02/11] staging: greybus: Remove redundant license text

[David Lin]

On Tue, Nov 7, 2017 at 5:58 AM, Greg Kroah-Hartman
 wrote:
> Now that the SPDX tag is in all greybus files, that identifies the
> license in a specific and legally-defined manner.  So the extra GPL text
> wording can be removed as it is no longer needed at all.
>
> This is done on a quest to remove the 700+ different ways that files in
> the kernel describe the GPL license text.  And there's unneeded stuff
> like the address (sometimes incorrect) for the FSF which is never
> needed.
>
> No copyright headers or other non-license-description text was removed.
>
> Cc: Vaibhav Hiremath 
> Cc: Johan Hovold 
> Cc: Alex Elder 
> Cc: Greg Kroah-Hartman 
> Cc: Vaibhav Agarwal 
> Cc: Mark Greer 
> Cc: Viresh Kumar 
> Cc: Rui Miguel Silva 
> Cc: David Lin 
> Cc: "Bryan O'Donoghue" 
> Signed-off-by: Greg Kroah-Hartman 

Acked-by: David Lin 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

[David Lin]

On Tue, Nov 7, 2017 at 5:58 AM, Greg Kroah-Hartman
 wrote:
> It's good to have SPDX identifiers in all files to make it easier to
> audit the kernel tree for correct licenses.
>
> Update the drivers/staging/greybus files files with the correct SPDX
> license identifier based on the license text in the file itself.  The
> SPDX identifier is a legally binding shorthand, which can be used
> instead of the full boiler plate text.
>
> This work is based on a script and data from Thomas Gleixner, Philippe
> Ombredanne, and Kate Stewart.
>
> Cc: Johan Hovold 
> Cc: Alex Elder 
> Cc: Greg Kroah-Hartman 
> Cc: Vaibhav Hiremath 
> Cc: Vaibhav Agarwal 
> Cc: Mark Greer 
> Cc: Viresh Kumar 
> Cc: Rui Miguel Silva 
> Cc: David Lin 
> Cc: "Bryan O'Donoghue" 
> Cc: Thomas Gleixner 
> Cc: Kate Stewart 
> Cc: Philippe Ombredanne 
> Signed-off-by: Greg Kroah-Hartman 

Acked-by: David Lin 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: greybus: uart: constify tty_port_operations structure

[David Lin]

On Sat, Oct 15, 2016 at 2:23 AM, Johan Hovold  wrote:
>
> [ +CC: staging list (for real this time) ]
>
> On Sat, Oct 15, 2016 at 12:28:01PM +0530, Bhumika Goyal wrote:
> > Declare tty_port_operations structure as const as it is only stored in
> > the ops field of a tty_port structure which is a field of a gb_tty
> > structure. The ops field is of type const struct tty_port_operations *,
> > so tty_port_operations structures having this property can be
> > declared as const.
> > Done using Coccinelle:
> >
> > @r1 disable optional_qualifier @
> > identifier i;
> > position p;
> > @@
> > static struct tty_port_operations i@p = {...};
> >
> > @ok1@
> > identifier r1.i;
> > position p;
> > struct gb_tty q;
> > @@
> > q.port.ops=&i@p
> >
> > @bad@
> > position p!={r1.p,ok1.p};
> > identifier r1.i;
> > @@
> > i@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r1.i;
> > @@
> > static
> > +const
> > struct tty_port_operations i={...};
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r1.i;
> > @@
> > +const
> > struct tty_port_operations i;
> >
> > File size before:
> >text  data bss dec hex filename
> >7646   512  56    82142016 drivers/staging/greybus/uart.o
> >
> > File size after:
> >text  data bss dec hex filename
> >7710   448  5682142016 drivers/staging/greybus/uart.o
> >
> > Signed-off-by: Bhumika Goyal 

Reviewed-by: David Lin 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel