[PATCH] Staging: Speakup: speakup_decpc: fixed a block comment misalignment

[Daniel Perez]

Fixed a coding style issue (block comments misasligned and code indents
not done with tabs)

Signed-off-by: Daniel Perez 
---
 drivers/staging/speakup/speakup_decpc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/speakup_decpc.c 
b/drivers/staging/speakup/speakup_decpc.c
index 6bf38e4..ca3fc4d 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -85,8 +85,8 @@
 #defineCTRL_io_priority0x0c00  /*   change i/o priority */
 #defineCTRL_free_mem   0x0d00  /*   get free paragraphs on 
module */
 #defineCTRL_get_lang   0x0e00  /* return bit mask of loaded
-* languages
-*/
+* languages
+*/
 #defineCMD_test0x2000  /* self-test 
request */
 #defineTEST_mask   0x0F00  /* isolate test field */
 #defineTEST_null   0x  /* no test requested */
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: Speakup: speakup_decpc: fixed a block comment misalignment

[Daniel Perez]

Hi Greg,
I agree with you, that patch looks ugly. I came about this (non) coding style
mistake by running scripts/checkpatch --file --terse on speakup_decp.c . I
re-ran it just now on the unpatched version to check, and I get the following:

drivers/staging/speakup/speakup_decpc.c:88: WARNING: Block comments should align
the * on each line

(And a bunch of other warnings regarding other lines)

I remade the changes and when I run git diff I get the exact same ugly looking
diff text.

So I'm not sure if its a problem with my version of checkpatch or something
else on my distro (Ubuntu 16.04).


Any idea where to look at?

Best regards,

Daniel 

On Thu, Feb 16, 2017 at 10:17:54AM -0800, Greg KH wrote:
> On Wed, Feb 15, 2017 at 12:02:43PM +0100, Daniel Perez wrote:
> > Fixed a coding style issue (block comments misasligned and code indents
> > not done with tabs)
> > 
> > Signed-off-by: Daniel Perez 
> > ---
> >  drivers/staging/speakup/speakup_decpc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/speakup/speakup_decpc.c 
> > b/drivers/staging/speakup/speakup_decpc.c
> > index 6bf38e4..ca3fc4d 100644
> > --- a/drivers/staging/speakup/speakup_decpc.c
> > +++ b/drivers/staging/speakup/speakup_decpc.c
> > @@ -85,8 +85,8 @@
> >  #defineCTRL_io_priority0x0c00  /*   change i/o priority */
> >  #defineCTRL_free_mem   0x0d00  /*   get free paragraphs on 
> > module */
> >  #defineCTRL_get_lang   0x0e00  /* return bit mask of loaded
> > -* languages
> > -*/
> > +* languages
> > +*/
> 
> Ick, does that look correct to you?  It does not to me :(
> 
> sorry,
> 
> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: BCM2835-Audio: bcm2835-pcm: single line block statement braces fix

[Daniel Perez de Andres]

A single line statement under an if clause doesn't require braces {}

Signed-off-by: Daniel Perez de Andres 
---
 drivers/staging/bcm2835-audio/bcm2835-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c 
b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 014bf7a..a2a8694 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
@@ -317,9 +317,9 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream 
*substream)
err = bcm2835_audio_set_params(alsa_stream, channels,
alsa_stream->params_rate,
alsa_stream->pcm_format_width);
-   if (err < 0) {
+   if (err < 0)
audio_error(" error setting hw params\n");
-   }
+
 
bcm2835_audio_setup(alsa_stream);
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel