Re: [PATCH] staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"
On Thu, 2019-06-06 at 20:10 -0700, Shobhit Kukreti wrote: > coccicheck reported Unneeded variable ret at > rtl8723bs/core/rtw_ap.c:1400. > Function "rtw_acl_remove_sta" always returns 0. Modified return type > of the > function to void. > > Signed-off-by: Shobhit Kukreti Looks good, thanks. Reviewed-by: Bastien Nocera ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: staging: rtl8723bs: bug or pointless if else ?
On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote:
> Hi,
>
> On 28-06-18 09:43, Michael Straube wrote:
> > Hi,
> >
> > I stumbled upon the following if else construct in
> > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618
> >
> > if (pwrpriv->bInternalAutoSuspend)
> > {
> > ret = rtw_resume_process(padapter);
> > }
> > else
> > {
> > if (pwrpriv->wowlan_mode || pwrpriv-
> > >wowlan_ap_mode)
> > {
> > ret = rtw_resume_process(padapter);
> > }
> > else
> > {
> > ret = rtw_resume_process(padapter);
> > }
> > }
> >
> > It does not matter if the conditions are true or not,
> > ret is always set to:
> >
> > ret = rtw_resume_process(padapter)
> >
> > Is this a bug or is the if else construct just pointless?
>
> It probably is just pointless, my guess would be that once
> upon a time there was a difference in the paths and at some
> point that difference went away.
Quite:
https://github.com/hadess/rtl8723bs/blob/7d36e26f78bbc709844c12ad0c62e3e8503fdbc5/os_dep/linux/sdio_intf.c#L1757
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH][staging-next] staging: rtl8723bs: spelling mistake: "dismatch" -> "mismatch"
On Mon, 2018-04-30 at 15:19 +0100, Colin King wrote: > + P2P_STATE_RECV_INVITE_REQ_DISMATCH = > 17,/* receiving the P2P Inviation request and mismatch > with the profile. */ Might as well fix the "inviation" as well, no? :) Thanks ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
On Tue, 2020-03-24 at 12:38 +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > Make it possible to disable the LED, as it can be pretty annoying
> > depending on where it's located.
> >
> > See also https://github.com/lwfinger/rtl8188eu/pull/304 for the
> > out-of-tree version.
> >
> > Signed-off-by: Bastien Nocera
> > ---
> > drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++
> > drivers/staging/rtl8188eu/include/drv_types.h | 2 ++
> > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
> > 3 files changed, 13 insertions(+)
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c
> > b/drivers/staging/rtl8188eu/core/rtw_led.c
> > index d1406cc99768..75a859accb7e 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> > @@ -467,10 +467,16 @@ void blink_handler(struct LED_871x *pLed)
> >
> > void led_control_8188eu(struct adapter *padapter, enum
> > LED_CTL_MODE LedAction)
> > {
> > + struct registry_priv *registry_par;
> > +
> > if (padapter->bSurpriseRemoved || padapter->bDriverStopped ||
> > !padapter->hw_init_completed)
> > return;
> >
> > + registry_par = &padapter->registrypriv;
> > + if (!registry_par->led_enable)
> > + return;
> > +
> > if ((padapter->pwrctrlpriv.rf_pwrstate != rf_on &&
> > padapter->pwrctrlpriv.rfoff_reason > RF_CHANGE_BY_PS) &&
> > (LedAction == LED_CTL_TX || LedAction == LED_CTL_RX ||
> > diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
> > b/drivers/staging/rtl8188eu/include/drv_types.h
> > index 35c0946bc65d..4ca828141d3f 100644
> > --- a/drivers/staging/rtl8188eu/include/drv_types.h
> > +++ b/drivers/staging/rtl8188eu/include/drv_types.h
> > @@ -67,6 +67,8 @@ struct registry_priv {
> > u8 wmm_enable;
> > u8 uapsd_enable;
> >
> > + u8 led_enable;
> > +
> > struct wlan_bssid_exdev_network;
> >
> > u8 ht_enable;
> > diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > index 8907bf6bb7ff..ba55ae741215 100644
> > --- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > +++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > @@ -47,6 +47,8 @@ static int rtw_acm_method;/* 0:By SW 1:By HW. */
> > static int rtw_wmm_enable = 1;/* default is set to enable the
> > wmm. */
> > static int rtw_uapsd_enable;
> >
> > +static int rtw_led_enable = 1;
> > +
> > static int rtw_ht_enable = 1;
> > /* 0 :disable, bit(0): enable 2.4g, bit(1): enable 5g */
> > static int rtw_cbw40_enable = 3;
> > @@ -98,6 +100,7 @@ module_param(rtw_channel, int, 0644);
> > module_param(rtw_wmm_enable, int, 0644);
> > module_param(rtw_vrtl_carrier_sense, int, 0644);
> > module_param(rtw_vcs_type, int, 0644);
> > +module_param(rtw_led_enable, int, 0644);
>
> Ick, really? No, no nee module parameters, this is not the 1990's.
>
> This should be done on a per-device basis, using the correct apis.
What API?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
On Tue, 2020-03-24 at 13:32 +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2020 at 12:47:01PM +0100, Bastien Nocera wrote:
> > On Tue, 2020-03-24 at 12:38 +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote:
> > > > Make it possible to disable the LED, as it can be pretty
> > > > annoying
> > > > depending on where it's located.
> > > >
> > > > See also https://github.com/lwfinger/rtl8188eu/pull/304 for the
> > > > out-of-tree version.
> > > >
> > > > Signed-off-by: Bastien Nocera
> > > > ---
> > > > drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++
> > > > drivers/staging/rtl8188eu/include/drv_types.h | 2 ++
> > > > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
> > > > 3 files changed, 13 insertions(+)
> > > >
> > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c
> > > > b/drivers/staging/rtl8188eu/core/rtw_led.c
> > > > index d1406cc99768..75a859accb7e 100644
> > > > --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> > > > +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> > > > @@ -467,10 +467,16 @@ void blink_handler(struct LED_871x *pLed)
> > > >
> > > > void led_control_8188eu(struct adapter *padapter, enum
> > > > LED_CTL_MODE LedAction)
> > > > {
> > > > + struct registry_priv *registry_par;
> > > > +
> > > > if (padapter->bSurpriseRemoved || padapter-
> > > > >bDriverStopped ||
> > > > !padapter->hw_init_completed)
> > > > return;
> > > >
> > > > + registry_par = &padapter->registrypriv;
> > > > + if (!registry_par->led_enable)
> > > > + return;
> > > > +
> > > > if ((padapter->pwrctrlpriv.rf_pwrstate != rf_on &&
> > > > padapter->pwrctrlpriv.rfoff_reason >
> > > > RF_CHANGE_BY_PS) &&
> > > > (LedAction == LED_CTL_TX || LedAction == LED_CTL_RX
> > > > ||
> > > > diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
> > > > b/drivers/staging/rtl8188eu/include/drv_types.h
> > > > index 35c0946bc65d..4ca828141d3f 100644
> > > > --- a/drivers/staging/rtl8188eu/include/drv_types.h
> > > > +++ b/drivers/staging/rtl8188eu/include/drv_types.h
> > > > @@ -67,6 +67,8 @@ struct registry_priv {
> > > > u8 wmm_enable;
> > > > u8 uapsd_enable;
> > > >
> > > > + u8 led_enable;
> > > > +
> > > > struct wlan_bssid_exdev_network;
> > > >
> > > > u8 ht_enable;
> > > > diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > > > b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > > > index 8907bf6bb7ff..ba55ae741215 100644
> > > > --- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > > > +++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
> > > > @@ -47,6 +47,8 @@ static int rtw_acm_method;/* 0:By SW 1:By
> > > > HW. */
> > > > static int rtw_wmm_enable = 1;/* default is set to enable the
> > > > wmm. */
> > > > static int rtw_uapsd_enable;
> > > >
> > > > +static int rtw_led_enable = 1;
> > > > +
> > > > static int rtw_ht_enable = 1;
> > > > /* 0 :disable, bit(0): enable 2.4g, bit(1): enable 5g */
> > > > static int rtw_cbw40_enable = 3;
> > > > @@ -98,6 +100,7 @@ module_param(rtw_channel, int, 0644);
> > > > module_param(rtw_wmm_enable, int, 0644);
> > > > module_param(rtw_vrtl_carrier_sense, int, 0644);
> > > > module_param(rtw_vcs_type, int, 0644);
> > > > +module_param(rtw_led_enable, int, 0644);
> > >
> > > Ick, really? No, no nee module parameters, this is not the
> > > 1990's.
> > >
> > > This should be done on a per-device basis, using the correct
> > > apis.
> >
> > What API?
>
> Documentation/leds/index.rst should give you a good start :)
Given how much work it'd be, I'll give it a miss and carry on using the
out-of-tree driver.
Thanks for the hint.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
On Tue, 2020-03-24 at 13:48 +0100, Greg Kroah-Hartman wrote: > > Huh? Why not fix this properly, as that's the only way this driver > is > ever going to be fixed up correctly and get out of staging at all. Because, unfortunately, I have limited free time. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
Make it possible to disable the LED, as it can be pretty annoying
depending on where it's located.
See also https://github.com/lwfinger/rtl8188eu/pull/304 for the
out-of-tree version.
Signed-off-by: Bastien Nocera
---
drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++
drivers/staging/rtl8188eu/include/drv_types.h | 2 ++
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
3 files changed, 13 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c
b/drivers/staging/rtl8188eu/core/rtw_led.c
index d1406cc99768..75a859accb7e 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -467,10 +467,16 @@ void blink_handler(struct LED_871x *pLed)
void led_control_8188eu(struct adapter *padapter, enum LED_CTL_MODE LedAction)
{
+ struct registry_priv *registry_par;
+
if (padapter->bSurpriseRemoved || padapter->bDriverStopped ||
!padapter->hw_init_completed)
return;
+ registry_par = &padapter->registrypriv;
+ if (!registry_par->led_enable)
+ return;
+
if ((padapter->pwrctrlpriv.rf_pwrstate != rf_on &&
padapter->pwrctrlpriv.rfoff_reason > RF_CHANGE_BY_PS) &&
(LedAction == LED_CTL_TX || LedAction == LED_CTL_RX ||
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 35c0946bc65d..4ca828141d3f 100644
--- a/drivers/staging/rtl8188eu/include/drv_types.h
+++ b/drivers/staging/rtl8188eu/include/drv_types.h
@@ -67,6 +67,8 @@ struct registry_priv {
u8 wmm_enable;
u8 uapsd_enable;
+ u8 led_enable;
+
struct wlan_bssid_exdev_network;
u8 ht_enable;
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 8907bf6bb7ff..ba55ae741215 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -47,6 +47,8 @@ static int rtw_acm_method;/* 0:By SW 1:By HW. */
static int rtw_wmm_enable = 1;/* default is set to enable the wmm. */
static int rtw_uapsd_enable;
+static int rtw_led_enable = 1;
+
static int rtw_ht_enable = 1;
/* 0 :disable, bit(0): enable 2.4g, bit(1): enable 5g */
static int rtw_cbw40_enable = 3;
@@ -98,6 +100,7 @@ module_param(rtw_channel, int, 0644);
module_param(rtw_wmm_enable, int, 0644);
module_param(rtw_vrtl_carrier_sense, int, 0644);
module_param(rtw_vcs_type, int, 0644);
+module_param(rtw_led_enable, int, 0644);
module_param(rtw_ht_enable, int, 0644);
module_param(rtw_cbw40_enable, int, 0644);
module_param(rtw_ampdu_enable, int, 0644);
@@ -162,6 +165,8 @@ static void loadparam(struct adapter *padapter, struct
net_device *pnetdev)
registry_par->wmm_enable = (u8)rtw_wmm_enable;
registry_par->uapsd_enable = (u8)rtw_uapsd_enable;
+ registry_par->led_enable = (u8)rtw_led_enable;
+
registry_par->ht_enable = (u8)rtw_ht_enable;
registry_par->cbw40_enable = (u8)rtw_cbw40_enable;
registry_par->ampdu_enable = (u8)rtw_ampdu_enable;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
On Tue, 2020-03-24 at 16:20 +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote: > > Make it possible to disable the LED, as it can be pretty annoying > > depending on where it's located. > > > > See also https://github.com/lwfinger/rtl8188eu/pull/304 for the > > out-of-tree version. > > > > Signed-off-by: Bastien Nocera > > --- > > drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++ > > drivers/staging/rtl8188eu/include/drv_types.h | 2 ++ > > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 + > > 3 files changed, 13 insertions(+) > > Why was this resent? Didn't I just reject this? It wasn't resent, it's the same mail you already answered. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend 3] staging: rtl8188eu: Add rtw_led_enable module parameter
On Tue, 2020-03-24 at 20:35 +0300, Dan Carpenter wrote: > On Tue, Mar 24, 2020 at 04:21:47PM +0100, Bastien Nocera wrote: > > On Tue, 2020-03-24 at 16:20 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Mar 24, 2020 at 11:36:00AM +0100, Bastien Nocera wrote: > > > > Make it possible to disable the LED, as it can be pretty > > > > annoying > > > > depending on where it's located. > > > > > > > > See also https://github.com/lwfinger/rtl8188eu/pull/304 for the > > > > out-of-tree version. > > > > > > > > Signed-off-by: Bastien Nocera > > > > --- > > > > drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++ > > > > drivers/staging/rtl8188eu/include/drv_types.h | 2 ++ > > > > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 + > > > > 3 files changed, 13 insertions(+) > > > > > > Why was this resent? Didn't I just reject this? > > > > It wasn't resent, it's the same mail you already answered. > > It says "resend" in the subject. This isn't what we were talking about though ;) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 20/22] staging rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
> } else {
> - for (pstat->aid = 1; pstat->aid <= NUM_STA; pstat->aid++)
> + for (pstat->aid = 1; pstat->aid < NUM_STA; pstat->aid++)
> if (pstapriv->sta_aid[pstat->aid - 1] == NULL)
> break;
why not start at 0 and increment pstat->aid afterwards? Meh.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/22] staging: rtl87232bs: Fix errors and warnings detected by Smatch
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > A number of routines have indenting, off by one, and possible usage > while null warnings or errors listed by Smatch. This set of patches > fix all but one of these, and it is in code that will be removed in a > subsequent patch. > > Signed-off-by: Larry Finger Feel free to add: Reviewed-by: Bastien Nocera for all the patches I didn't directly comment on. Cheers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > + if (cam_id >= 0 && cam_id < 32) Isn't there a constant we could use instead of hard-coding this? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > Smatch lists the following: > > CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 > rtw_cfg80211_ibss_indicate_connect() error: we previously assumed > 'scanned' could be null (see line 466) > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:942 > rtw_cfg80211_set_encryption() warn: inconsistent indenting > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:955 > rtw_cfg80211_set_encryption() error: buffer overflow 'psecuritypriv- > >dot11DefKey' 4 <= 4 > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1017 > rtw_cfg80211_set_encryption() error: buffer overflow 'padapter- > >securitypriv.dot118021XGrpKey' 5 <= 5 > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1216 > cfg80211_rtw_set_default_key() warn: inconsistent indenting > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2498 > rtw_cfg80211_monitor_if_xmit_entry() error: we previously assumed > 'skb' could be null (see line 2495) > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2850 > cfg80211_rtw_start_ap() warn: if statement not indented > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2860 > cfg80211_rtw_start_ap() warn: if statement not indented > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3417 > rtw_cfg80211_preinit_wiphy() warn: inconsistent indenting > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3547 > rtw_wdev_alloc() info: ignoring unreachable code. > > The indenting warnings were fixed by simple white space changes. > > The section where 'scanned' could be null required an immediate exit > from > the routine at that point. A similar fix was required where 'skb' > could be null. > > The two buffer overflow errors were caused by off-by-one errors. > While > locating these problems, another one was found in > os_dep/ioctl_linux.c. Could you please split those up into patches that fix one kind of problem? Makes it easier to review. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 13/22] staging: rtl8723bs: Fix indenting mistake in core/rtw_ap.c
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > Fixing this requires changing the indentatikon of a long for loop. Typo here. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/7] staging: rtl8732: Various checkpatch fixes
On Thu, 2017-04-27 at 18:09 -0600, Justin Vreeland wrote: > Justin Vreeland (7): > > staging: rtl8723bs: Fix pointer style > staging: rtl8723bs: Fix spacing around '<' > staging: rtl8723bs: Do not use assignment in if condition You can add: Reviewed-By: Bastien Nocera To those last 3 patches. Cheers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Ensure checkpatch compliance
>
> > Signed-off-by: Justin Vreeland
> ---
> v2:
> - Added commit message
> - Fixed overly long lines
>
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 --
> drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++--
> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 9 -
> 3 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 28d1a229c3a6..21ec890fd60c 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -385,8 +385,7 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter)
> > /* Config MAC */
> > /* */
> > rtStatus = phy_ConfigMACWithParaFile(Adapter, pszMACRegFile);
> > - if (rtStatus == _FAIL)
> > - {
> > + if (rtStatus == _FAIL) {
> > ODM_ConfigMACWithHeaderFile(&pHalData->odmpriv);
> > rtStatus = _SUCCESS;
> > }
> @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter
> *Adapter)
> > Adapter->registrypriv.RegEnableTxPowerLimit == 1 ||
> > (Adapter->registrypriv.RegEnableTxPowerLimit == 2 &&
> > pHalData->EEPROMRegulatory == 1)
> > ) {
> > - if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter,
> > pszRFTxPwrLmtFile) == _FAIL)
> > - {
> > + if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter,
> > pszRFTxPwrLmtFile) == _FAIL) {
> > if (HAL_STATUS_SUCCESS !=
> > ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT,
> > (ODM_RF_RADIO_PATH_E)0))
> > rtStatus = _FAIL;
> > }
> @@ -474,8 +472,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter
> *Adapter)
> > /* */
> > /* 1. Read PHY_REG.TXT BB INIT!! */
> > /* */
> > - if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG)
> > == _FAIL)
> > - {
> > + if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG)
> > ==
> + _FAIL) {
This and...
> if (HAL_STATUS_SUCCESS !=
> ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG))
> > rtStatus = _FAIL;
> > }
> @@ -491,8 +489,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter
> *Adapter)
> > Adapter->registrypriv.RegEnableTxPowerByRate == 1 ||
> > (Adapter->registrypriv.RegEnableTxPowerByRate == 2 &&
> > pHalData->EEPROMRegulatory != 2)
> > ) {
> > - if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) ==
> > _FAIL)
> > - {
> > + if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) ==
> > + _FAIL) {
> > if (HAL_STATUS_SUCCESS !=
> > ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG))
> > rtStatus = _FAIL;
> > }
> @@ -514,8 +512,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter
> *Adapter)
> > /* */
> > /* 2. Read BB AGC table Initialization */
> > /* */
> > - if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile,
> > CONFIG_BB_AGC_TAB) == _FAIL)
> > - {
> > + if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile,
> + CONFIG_BB_AGC_TAB) == _FAIL) {
...this and the other such changes below are just way ugly, whatever
the coding style says.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: > v2: > Added commit messages > Fixed overly long lines > Added Bastien Nocera's Reviewed-by tag > - Also fixed commit messages marked reviewed, hope that's OK. The > patch > contents are identical. > > Justin Vreeland (7): > staging: rtl8723bs: Fix initialization of static variables > staging: rtl8723bs: Wrap multi-line macros in do-while loop You can add: Reviewed-by: Bastien Nocera for those 2. Cheers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Enclosing macros with complex values ensures expression is evaluated
> as
> expected.
>
> Signed-off-by: Justin Vreeland
> ---
> v2:
> - Added spaces around plus signs
> - Fixed line over 80 columns
> - Added commit message
>
> drivers/staging/rtl8723bs/hal/odm.h | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h
> b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..87a76bafecb3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21
> /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14 + 24 + 21)
> /* Channels_2_4G_NUM
> + * +
> Channels_5G_20M_NUM
> + * + Channels_5G
> + */
This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional
On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote: > > Sorry about blank email. > > I'm not 100% happy with it either. Larry Finger suggested to fix the > overly long lines so I tried to find a decent way to shorten them. I > think the best way would be to change the function names or pull the > function > calls out of the if statements. > > If these line breaks aren't a good solution and keeping them over 80 > isn't either I'd > rather drop this patch from the set if that's okay. Dropping the sections of this patch that require linefeeds in the middle of if statements would be fine by me. I don't think that a brace on the next line is worse than splitting a condition on 2 lines. Cheers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: unisys: Fix typo in comment
Signed-off-by: Bastien Nocera
---
drivers/staging/unisys/virthba/virthba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b/drivers/staging/unisys/virthba/virthba.c
index d7a629b..03672d8 100644
--- a/drivers/staging/unisys/virthba/virthba.c
+++ b/drivers/staging/unisys/virthba/virthba.c
@@ -476,7 +476,7 @@ virthba_probe(struct virtpci_dev *virtpcidev, const struct
pci_device_id *id)
* instance - this virthba that has just been created is an
* instance of a scsi host adapter. This scsi_host_alloc
* function allocates a new Scsi_Host struct & performs basic
-* initializatoin. The host is not published to the scsi
+* initialization. The host is not published to the scsi
* midlayer until scsi_add_host is called.
*/
DBGINF("calling scsi_host_alloc.\n");
--
2.1.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Resolve RF Type mismatch
On Wed, 2018-02-07 at 00:57 +0900, Kangmin Park wrote: > From: pr0gr4m This needs a commit message. I don't understand what the code is trying to do. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
