from:"Alaa Emad"

[PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Alaa Emad

This change fixes a checkpatch error for "space prohibited before that close 
parenthesis ')'"

Signed-off-by: Alaa Emad 
---
 certs/x509_revocation_list| 0
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)
 create mode 100644 certs/x509_revocation_list

diff --git a/certs/x509_revocation_list b/certs/x509_revocation_list
new file mode 100644
index ..e69de29bb2d1
diff --git a/drivers/staging/fbtft/fbtft-bus.c 
b/drivers/staging/fbtft/fbtft-bus.c
index 63c65dd67b17..847cbfbbd766 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out:  
  \
 } \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] staging: hikey9xx: hi6421-spmi-pmic.c: removing

2021-02-14 Thread Alaa Emad

drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:53: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:69: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:180: CHECK: Alignment should match 
open parenthesis
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:238: CHECK: Alignment should match 
open parenthesis
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:281: WARNING: DT compatible string 
"hisilicon,hi6421-spmi" appears un-documented -- check 
./Documentation/devicetree/bindings/
total: 0 errors, 5 warnings, 2 checks, 297 lines checked

Signed-off-by: Alaa Emad 

---
 drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c 
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
 /*
  * The IRQs are mapped as:
  *
- * ==  =   =
- * IRQ MASK REGISTER   IRQ REGISTERBIT
- * ==  =   =
+ * ==  =   =
+ * IRQ MASK REGISTER   IRQ REGISTERBIT
+ * ==  =   =
  * OTMP0x0202  0x212   bit 0
  * VBUS_CONNECT0x0202  0x212   bit 1
  * VBUS_DISCONNECT 0x0202  0x212   bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
  * SIM0_HPD_F  0x0203  0x213   bit 3
  * SIM1_HPD_R  0x0203  0x213   bit 4
  * SIM1_HPD_F  0x0203  0x213   bit 5
- * ==  =   =
+ * ==  =   =
  */
 #define SOC_PMIC_IRQ_MASK_0_ADDR   0x0202
 #define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct 
hi6421_spmi_pmic *ddata)
 
for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
-   HISI_MASK);
+HISI_MASK);
 
for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;
 
ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
-&hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Alaa Emad

This patch fix the following issues in hi6421-spmi-pmic.c file:

drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:53: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:69: WARNING: please, no space 
before tabs
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:180: CHECK: Alignment should match 
open parenthesis
drivers/staging/hikey9xx/hi6421-spmi-pmic.c:238: CHECK: Alignment should match 
open parenthesis


Signed-off-by: Alaa Emad 

---
 drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c 
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
 /*
  * The IRQs are mapped as:
  *
- * ==  =   =
- * IRQ MASK REGISTER   IRQ REGISTERBIT
- * ==  =   =
+ * ==  =   =
+ * IRQ MASK REGISTER   IRQ REGISTERBIT
+ * ==  =   =
  * OTMP0x0202  0x212   bit 0
  * VBUS_CONNECT0x0202  0x212   bit 1
  * VBUS_DISCONNECT 0x0202  0x212   bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
  * SIM0_HPD_F  0x0203  0x213   bit 3
  * SIM1_HPD_R  0x0203  0x213   bit 4
  * SIM1_HPD_F  0x0203  0x213   bit 5
- * ==  =   =
+ * ==  =   =
  */
 #define SOC_PMIC_IRQ_MASK_0_ADDR   0x0202
 #define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct 
hi6421_spmi_pmic *ddata)
 
for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
-   HISI_MASK);
+HISI_MASK);
 
for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;
 
ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
-&hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: hikey9xx: fix styling issues

2021-02-16 Thread Alaa Emad

In hi6421-spmi-pmic.c, there are some warnings and Check:

"WARNING: please, no space before tabs" in lines 51,52,53 and 69.
"CHECK: Alignment should match open parenthesis" in lines 180 and 238.

Signed-off-by: Alaa Emad 
---
Changes in v2:
  - Make the commit message more clearer.
---
 drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c 
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
 /*
  * The IRQs are mapped as:
  *
- * ==  =   =
- * IRQ MASK REGISTER   IRQ REGISTERBIT
- * ==  =   =
+ * ==  =   =
+ * IRQ MASK REGISTER   IRQ REGISTERBIT
+ * ==  =   =
  * OTMP0x0202  0x212   bit 0
  * VBUS_CONNECT0x0202  0x212   bit 1
  * VBUS_DISCONNECT 0x0202  0x212   bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
  * SIM0_HPD_F  0x0203  0x213   bit 3
  * SIM1_HPD_R  0x0203  0x213   bit 4
  * SIM1_HPD_F  0x0203  0x213   bit 5
- * ==  =   =
+ * ==  =   =
  */
 #define SOC_PMIC_IRQ_MASK_0_ADDR   0x0202
 #define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct 
hi6421_spmi_pmic *ddata)
 
for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
-   HISI_MASK);
+HISI_MASK);
 
for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;
 
ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
-&hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: hikey9xx: fix warning styling issues

2021-02-19 Thread Alaa Emad

Fix "WARNING: please, no space before tabs" styling issue in
hi6421-spmi-pmic.c for lines 51,52,53 and 69.

Signed-off-by: Alaa Emad 
---
 drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c 
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 4ebcfea9f3bf..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
 /*
  * The IRQs are mapped as:
  *
- * ==  =   =
- * IRQ MASK REGISTER   IRQ REGISTERBIT
- * ==  =   =
+ * ==  =   =
+ * IRQ MASK REGISTER   IRQ REGISTERBIT
+ * ==  =   =
  * OTMP0x0202  0x212   bit 0
  * VBUS_CONNECT0x0202  0x212   bit 1
  * VBUS_DISCONNECT 0x0202  0x212   bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
  * SIM0_HPD_F  0x0203  0x213   bit 3
  * SIM1_HPD_R  0x0203  0x213   bit 4
  * SIM1_HPD_F  0x0203  0x213   bit 5
- * ==  =   =
+ * ==  =   =
  */
 #define SOC_PMIC_IRQ_MASK_0_ADDR   0x0202
 #define SOC_PMIC_IRQ0_ADDR 0x0212
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Fix space prohibited issue in fbtft-bus.c

[PATCH 1/1] staging: hikey9xx: hi6421-spmi-pmic.c: removing

[PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

[PATCH v2] staging: hikey9xx: fix styling issues

[PATCH] staging: hikey9xx: fix warning styling issues

5 matches

Site Navigation

Mail list logo

Footer information