[PATCH v2] staging: vt6655: fix camelcase in wCurrentRate
Replace camelcase word variable "wCurrentRate" into linux kernel coding
style equivalent "current_rate".
References:
https://www.kernel.org/doc/html/latest/process/coding-style.html
https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
Signed-off-by: Alberto Merciai
---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 12 +--
drivers/staging/vt6655/rxtx.c| 134 +--
3 files changed, 74 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 29f354ced563..f5dee7ad99cd 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -208,7 +208,7 @@ struct vnt_private {
unsigned char byPreambleType;
unsigned char byShortPreamble;
- unsigned short wCurrentRate;
+ unsigned short current_rate;
unsigned char byShortRetryLimit;
unsigned char byLongRetryLimit;
enum nl80211_iftype op_mode;
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 41cbec4134b0..2c5398b128df 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -213,7 +213,7 @@ static void device_init_registers(struct vnt_private *priv)
priv->bNonERPPresent = false;
priv->bBarkerPreambleMd = false;
- priv->wCurrentRate = RATE_1M;
+ priv->current_rate = RATE_1M;
priv->byTopOFDMBasicRate = RATE_24M;
priv->byTopCCKBasicRate = RATE_1M;
@@ -369,7 +369,7 @@ static void device_init_registers(struct vnt_private *priv)
/* Set BB and packet type at the same time. */
/* Set Short Slot Time, xIFS, and RSPINF. */
- priv->wCurrentRate = RATE_54M;
+ priv->current_rate = RATE_54M;
priv->bRadioOff = false;
@@ -1382,11 +1382,11 @@ static int vnt_config(struct ieee80211_hw *hw, u32
changed)
if (changed & IEEE80211_CONF_CHANGE_POWER) {
if (priv->byBBType == BB_TYPE_11B)
- priv->wCurrentRate = RATE_1M;
+ priv->current_rate = RATE_1M;
else
- priv->wCurrentRate = RATE_54M;
+ priv->current_rate = RATE_54M;
- RFbSetPower(priv, priv->wCurrentRate,
+ RFbSetPower(priv, priv->current_rate,
conf->chandef.chan->hw_value);
}
@@ -1448,7 +1448,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
}
if (changed & BSS_CHANGED_TXPOWER)
- RFbSetPower(priv, priv->wCurrentRate,
+ RFbSetPower(priv, priv->current_rate,
conf->chandef.chan->hw_value);
if (changed & BSS_CHANGED_BEACON_ENABLED) {
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index cfab64d2b312..17795ebcdfbc 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -97,7 +97,7 @@ s_vFillRTSHead(
bool bNeedAck,
bool bDisCRC,
struct ieee80211_hdr *hdr,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
unsigned char byFBOption
);
@@ -114,7 +114,7 @@ s_vGenerateTxParameter(
bool bNeedACK,
unsigned intuDMAIdx,
void *psEthHeader,
- unsigned short wCurrentRate
+ unsigned short current_rate
);
static unsigned int
@@ -136,7 +136,7 @@ s_uFillDataHead(
unsigned int cbLastFragmentSize,
unsigned int uMACfragNum,
unsigned char byFBOption,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
bool is_pspoll
);
@@ -197,7 +197,7 @@ s_uGetRTSCTSRsvTime(
unsigned char byRTSRsvType,
unsigned char byPktType,
unsigned int cbFrameLength,
- unsigned short wCurrentRate
+ unsigned short current_rate
)
{
unsigned int uRrvTime = 0;
@@ -206,7 +206,7 @@ s_uGetRTSCTSRsvTime(
unsigned int uAckTime = 0;
unsigned int uDataTime = 0;
- uDataTime = bb_get_frame_time(pDevice->byPreambleType, byPktType,
cbFrameLength, wCurrentRate);
+ uDataTime = bb_get_frame_time(pDevice->byPreambleType, byPktType,
cbFrameLength, current_rate);
if (byRTSRsvType == 0) { /* RTSTxRrvTime_bb */
uRTSTime = bb_get_frame_time(pDevice->byPreambleType,
byPktType, 20, pDevice->byTopCCKBasicRate);
uAckTime = bb_get_frame_time(pDevice->byPreambleType,
byPktType, 14, pDevice->byTopCCKBasicRate);
@@ -440,7 +440,7 @@ s_uFillDataHead(
unsigned int cbLastFragmentSize,
unsigned int uMACfragNum,
unsigned char byFBOption,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
bool is_pspoll
)
{
@@ -451,7 +451,7 @@ s_uFillDataHead(
if (byFBOption == AUTO_FB_NONE) {
struct vnt_tx_datahead_g *buf = pTxDataHead;
Re: [PATCH v2] staging: vt6655: fix camelcase in wCurrentRate
On Sun, Nov 14, 2021 at 09:20:29AM +0100, Alberto Merciai wrote: > Replace camelcase word variable "wCurrentRate" into linux kernel coding > style equivalent "current_rate". > > References: > https://www.kernel.org/doc/html/latest/process/coding-style.html > https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm > > Signed-off-by: Alberto Merciai > --- > drivers/staging/vt6655/device.h | 2 +- > drivers/staging/vt6655/device_main.c | 12 +-- > drivers/staging/vt6655/rxtx.c| 134 +-- > 3 files changed, 74 insertions(+), 74 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] staging: vt6655: fix camelcase in wCurrentRate
Replace camelcase word variable "wCurrentRate" into linux kernel coding
style equivalent "current_rate".
References:
https://www.kernel.org/doc/html/latest/process/coding-style.html
https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
Signed-off-by: Alberto Merciai
---
v2: Add version changelog as suggested by Greg KH
v1: Add mail message body as suggested by Greg KH
---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 12 +--
drivers/staging/vt6655/rxtx.c| 134 +--
3 files changed, 74 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 29f354ced563..f5dee7ad99cd 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -208,7 +208,7 @@ struct vnt_private {
unsigned char byPreambleType;
unsigned char byShortPreamble;
- unsigned short wCurrentRate;
+ unsigned short current_rate;
unsigned char byShortRetryLimit;
unsigned char byLongRetryLimit;
enum nl80211_iftype op_mode;
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 41cbec4134b0..2c5398b128df 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -213,7 +213,7 @@ static void device_init_registers(struct vnt_private *priv)
priv->bNonERPPresent = false;
priv->bBarkerPreambleMd = false;
- priv->wCurrentRate = RATE_1M;
+ priv->current_rate = RATE_1M;
priv->byTopOFDMBasicRate = RATE_24M;
priv->byTopCCKBasicRate = RATE_1M;
@@ -369,7 +369,7 @@ static void device_init_registers(struct vnt_private *priv)
/* Set BB and packet type at the same time. */
/* Set Short Slot Time, xIFS, and RSPINF. */
- priv->wCurrentRate = RATE_54M;
+ priv->current_rate = RATE_54M;
priv->bRadioOff = false;
@@ -1382,11 +1382,11 @@ static int vnt_config(struct ieee80211_hw *hw, u32
changed)
if (changed & IEEE80211_CONF_CHANGE_POWER) {
if (priv->byBBType == BB_TYPE_11B)
- priv->wCurrentRate = RATE_1M;
+ priv->current_rate = RATE_1M;
else
- priv->wCurrentRate = RATE_54M;
+ priv->current_rate = RATE_54M;
- RFbSetPower(priv, priv->wCurrentRate,
+ RFbSetPower(priv, priv->current_rate,
conf->chandef.chan->hw_value);
}
@@ -1448,7 +1448,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
}
if (changed & BSS_CHANGED_TXPOWER)
- RFbSetPower(priv, priv->wCurrentRate,
+ RFbSetPower(priv, priv->current_rate,
conf->chandef.chan->hw_value);
if (changed & BSS_CHANGED_BEACON_ENABLED) {
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index cfab64d2b312..17795ebcdfbc 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -97,7 +97,7 @@ s_vFillRTSHead(
bool bNeedAck,
bool bDisCRC,
struct ieee80211_hdr *hdr,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
unsigned char byFBOption
);
@@ -114,7 +114,7 @@ s_vGenerateTxParameter(
bool bNeedACK,
unsigned intuDMAIdx,
void *psEthHeader,
- unsigned short wCurrentRate
+ unsigned short current_rate
);
static unsigned int
@@ -136,7 +136,7 @@ s_uFillDataHead(
unsigned int cbLastFragmentSize,
unsigned int uMACfragNum,
unsigned char byFBOption,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
bool is_pspoll
);
@@ -197,7 +197,7 @@ s_uGetRTSCTSRsvTime(
unsigned char byRTSRsvType,
unsigned char byPktType,
unsigned int cbFrameLength,
- unsigned short wCurrentRate
+ unsigned short current_rate
)
{
unsigned int uRrvTime = 0;
@@ -206,7 +206,7 @@ s_uGetRTSCTSRsvTime(
unsigned int uAckTime = 0;
unsigned int uDataTime = 0;
- uDataTime = bb_get_frame_time(pDevice->byPreambleType, byPktType,
cbFrameLength, wCurrentRate);
+ uDataTime = bb_get_frame_time(pDevice->byPreambleType, byPktType,
cbFrameLength, current_rate);
if (byRTSRsvType == 0) { /* RTSTxRrvTime_bb */
uRTSTime = bb_get_frame_time(pDevice->byPreambleType,
byPktType, 20, pDevice->byTopCCKBasicRate);
uAckTime = bb_get_frame_time(pDevice->byPreambleType,
byPktType, 14, pDevice->byTopCCKBasicRate);
@@ -440,7 +440,7 @@ s_uFillDataHead(
unsigned int cbLastFragmentSize,
unsigned int uMACfragNum,
unsigned char byFBOption,
- unsigned short wCurrentRate,
+ unsigned short current_rate,
bool is_pspoll
)
{
@@ -451,7 +451,7 @@ s_uFillDataHead(
if (byFBOpt
[PATCH] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
Indicator) into linux kernel coding style equivalent
variable "current_rssi".
References:
https://www.kernel.org/doc/html/latest/process/coding-style.html
https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 4 ++--
drivers/staging/vt6655/dpc.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 29f354ced563..80c9ace0d116 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -167,7 +167,7 @@ struct vnt_private {
unsigned char abyCurrentNetAddr[ETH_ALEN]; __aligned(2)
bool bLinkPass; /* link status: OK or fail */
- unsigned intuCurrRSSI;
+ unsigned intcurrent_rssi;
unsigned char byCurrSQ;
unsigned long dwTxAntennaSel;
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 41cbec4134b0..17cdb2dc0aa9 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -979,10 +979,10 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
if (priv->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
return;
- if (!(priv->vif->bss_conf.assoc && priv->uCurrRSSI))
+ if (!(priv->vif->bss_conf.assoc && priv->current_rssi))
return;
- RFvRSSITodBm(priv, (u8)priv->uCurrRSSI, &dbm);
+ RFvRSSITodBm(priv, (u8)priv->current_rssi, &dbm);
for (i = 0; i < BB_VGA_LEVEL; i++) {
if (dbm < priv->ldBmThreshold[i]) {
diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
index 52214a30e9b6..9fea1ee0d612 100644
--- a/drivers/staging/vt6655/dpc.c
+++ b/drivers/staging/vt6655/dpc.c
@@ -82,7 +82,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct
sk_buff *skb,
RFvRSSITodBm(priv, *rssi, &rx_dbm);
priv->byBBPreEDRSSI = (u8)rx_dbm + 1;
- priv->uCurrRSSI = *rssi;
+ priv->current_rssi = *rssi;
skb_pull(skb, 4);
skb_trim(skb, frame_size);
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:debugfs_cleanup] BUILD SUCCESS 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup branch HEAD: 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d fs: make d_path-like functions all have unsigned size possible Warning in current branch (please contact us if interested): fs/d_path.c:20:20: warning: Unsigned variable '.' can't be negative so it is unnecessary to test it. [unsignedPositive] Warning ids grouped by kconfigs: gcc_recent_errors `-- ia64-randconfig-p001-2024 `-- fs-d_path.c:warning:Unsigned-variable-.-can-t-be-negative-so-it-is-unnecessary-to-test-it.-unsignedPositive elapsed time: 720m configs tested: 196 configs skipped: 4 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allmodconfig arm allyesconfig m68k amiga_defconfig mips jazz_defconfig powerpc lite5200b_defconfig m68k bvme6000_defconfig mipsgpr_defconfig arc axs101_defconfig powerpc mpc866_ads_defconfig powerpc mpc834x_itx_defconfig powerpc64 defconfig csky alldefconfig arm rpc_defconfig armmini2440_defconfig arm palmz72_defconfig sh se7721_defconfig powerpcsam440ep_defconfig powerpcklondike_defconfig riscv nommu_k210_sdcard_defconfig m68kmvme147_defconfig powerpc g5_defconfig arm ixp4xx_defconfig mips lemote2f_defconfig h8300allyesconfig riscvnommu_k210_defconfig arm lpc18xx_defconfig powerpc ppc44x_defconfig arm imote2_defconfig powerpc mpc837x_rdb_defconfig arcvdk_hs38_defconfig arm pcm027_defconfig sparc64 defconfig arm assabet_defconfig sparc sparc32_defconfig powerpc rainier_defconfig m68k sun3x_defconfig powerpc tqm8555_defconfig um alldefconfig shmigor_defconfig shedosk7760_defconfig powerpc ppc6xx_defconfig openriscdefconfig armvexpress_defconfig sh shx3_defconfig m68kstmark2_defconfig arm jornada720_defconfig arm h3600_defconfig shtitan_defconfig powerpcmpc7448_hpc2_defconfig sh sh2007_defconfig ia64 alldefconfig sh se7724_defconfig mipsomega2p_defconfig arm u8500_defconfig arm spitz_defconfig sh magicpanelr2_defconfig sh defconfig sh se7722_defconfig arm at91_dt_defconfig powerpc mpc8272_ads_defconfig mips pic32mzda_defconfig mipsbcm63xx_defconfig arm pxa255-idp_defconfig armhisi_defconfig arc alldefconfig arm pxa3xx_defconfig sh se7206_defconfig powerpc pq2fads_defconfig mips loongson1b_defconfig arm sama7_defconfig arm collie_defconfig arc axs103_smp_defconfig sh se7751_defconfig sh sh03_defconfig xtensa defconfig powerpc64alldefconfig powerpc mpc8315_rdb_defconfig arm aspeed_g4_defconfig mips malta_defconfig arm mainstone_defconfig powerpc mpc8540_ads_defconfig powerpc powernv_defconfig mips decstation_defconfig openrisc simple_smp_defconfig arm socfpga_defconfig armpleb_defconfig arm moxart_defconfig armmagicia
[staging:staging-testing] BUILD REGRESSION 501d3e5056387568baf1f60e1d0929d912f5893f
te2f_defconfig h8300allyesconfig riscvnommu_k210_defconfig arm lpc18xx_defconfig powerpc ppc44x_defconfig arm imote2_defconfig powerpc mpc837x_rdb_defconfig shedosk7760_defconfig powerpc ppc6xx_defconfig arm h3600_defconfig shtitan_defconfig powerpcmpc7448_hpc2_defconfig sh sh2007_defconfig ia64 alldefconfig sh se7721_defconfig mipsomega2p_defconfig arm spitz_defconfig sh se7724_defconfig arm u8500_defconfig sh magicpanelr2_defconfig sh defconfig sh se7722_defconfig arm at91_dt_defconfig powerpc mpc8272_ads_defconfig mips pic32mzda_defconfig mipsbcm63xx_defconfig powerpc pq2fads_defconfig mips loongson1b_defconfig arm sama7_defconfig arm collie_defconfig arc axs103_smp_defconfig sh se7751_defconfig sh sh03_defconfig xtensa defconfig powerpc64alldefconfig powerpc mpc8315_rdb_defconfig arm socfpga_defconfig armpleb_defconfig arm pxa255-idp_defconfig armmini2440_defconfig arm moxart_defconfig armmagician_defconfig arm multi_v4t_defconfig arm randconfig-c002-2024 ia64 allmodconfig ia64defconfig ia64 allyesconfig m68kdefconfig m68k allmodconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig cskydefconfig alpha defconfig alphaallyesconfig nios2allyesconfig arc defconfig sh allmodconfig xtensa allyesconfig parisc defconfig s390defconfig s390 allmodconfig s390 allyesconfig parisc allyesconfig sparcallyesconfig sparc defconfig i386defconfig i386 debian-10.3 i386 allyesconfig mips allmodconfig mips allyesconfig powerpc allnoconfig powerpc allmodconfig powerpc allyesconfig x86_64 randconfig-a015-2024 x86_64 randconfig-a013-2024 x86_64 randconfig-a012-2024 x86_64 randconfig-a011-2024 x86_64 randconfig-a014-2024 x86_64 randconfig-a016-2024 i386 randconfig-a014-2024 i386 randconfig-a016-2024 i386 randconfig-a012-2024 i386 randconfig-a013-2024 i386 randconfig-a011-2024 i386 randconfig-a015-2024 arc randconfig-r043-2024 s390 randconfig-r044-2024 riscvrandconfig-r042-2024 riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallyesconfig riscvallmodconfig um x86_64_defconfig um i386_defconfig x86_64rhel-8.3-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3-func x86_64 kexec x86_64 allyesconfig clang tested configs: x86_64 randconfig-c007-2024 i386 randconfig-c001-2024 arm randconfig-c002-2024 riscvrandconfig-c
Hope all is well with you and your family!
Hope all is well with you and your family! Greetings my dear, Please permit me to introduce myself, I came across your e-mail prior to a private search while in need of your assistance. My name is Mr. Abderazack Zebdani, from Burkina Faso, I work in Bank Of Africa (BOA) as Telex Manager, please see this as a confidential message and do not reveal it to another person and let me know whether you can be of assistance regarding my proposal below because it is top secret. Nevertheless, I want you to understand that there are still genuine and legitimate business class persons in the internet world today so I am assuring you that this transaction is 100% genuine. I am about to retire from active Banking service to start a new life but I am skeptical to reveal this particular secret to a stranger. You must assure me that everything will be handled confidentially because we are not going to suffer again in life. It has been 10 years now that most of the greedy African Politicians used our bank to launder money overseas through the help of their Political advisers. Most of the funds which they transferred out of the shores of Africa were gold and oil money that was supposed to have been used to develop the continent. Their Political advisers always inflated the amounts before transferring to foreign accounts, so I also used the opportunity to divert part of the funds hence I am aware that there is no official trace of how much was transferred as all the accounts used for such transfers were being closed after transfer. I acted as the Bank Officer to most of the politicians and when I discovered that they were using me to succeed in their greedy act; I also cleaned some of their banking records from the Bank files and no one cared to ask me because the money was too much for them to control, They laundered over $5billion Dollars during the process. Before I send this message to you, I have already diverted ($10.5million Dollars) to an escrow account belonging to no one in the bank. The bank is anxious now to know who the beneficiary to the funds is, because they have made a lot of profits with the funds. It is more than Eight years now, I don’t want to retire from the bank without transferring the funds to a foreign account, I only want you to assist me by providing a reliable bank account where the funds can be transferred. The money will be shared 60% for me and 40% for you. There is no one coming to ask you about the funds because I secured everything. You are not to face any difficulties or legal implications as I am going to handle the transfer personally. If you are capable of receiving the funds, do let me know immediately to enable me to give you detailed information on what to do. For me, I am looking forward to hearing from you soon. Thanks with all my best regards. Mr. Abderazack Zebdani. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
