date:20210923

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH

On Wed, Sep 22, 2021 at 08:17:15PM +0800, Cheng Chao wrote:
> I notice that v4.9.283 has released, but this patch is not merged.
> It's exactly a bug.

Can you please resend this and include all of the information in this
thread in the changelog comment explaining why this is only needed for
this one branch?  Trying to piece it all together on my own doesn't work
well :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Cheng Chao

Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached 
buffer alloc")
the commit e7f63771b60e introduced the bug which didn't test page which maybe 
NULL.
and previous logic was right.

the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this bug,
and other longterm/stable version have not.

kernel panic is here when page is NULL:

Unable to handle kernel paging request at virtual address b038
pgd = d9d94000
[b038] *pgd=
Internal error: Oops: 2805 [#1] PREEMPT SMP ARM
...
task: daa2dd00 task.stack: da194000
PC is at v7_dma_clean_range+0x1c/0x34
LR is at arm_dma_sync_single_for_device+0x44/0x58
pc : []lr : []psr: 200f0013
sp : da195da0  ip : dc1f9000  fp : c1043dc4
r10:   r9 : c16f1f58  r8 : 0001
r7 : c1621f94  r6 : c0116418  r5 :   r4 : c011aa58
r3 : 003f  r2 : 0040  r1 : b048  r0 : b038
Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
Control: 10c5383d  Table: 19d9406a  DAC: 0051
...
[] (v7_dma_clean_range) from [] 
(arm_dma_sync_single_for_device+0x44/0x58)
[] (arm_dma_sync_single_for_device) from [] 
(arm_dma_sync_sg_for_device+0x50/0x7c)
[] (arm_dma_sync_sg_for_device) from [] 
(ion_pages_sync_for_device+0xb0/0xec)
[] (ion_pages_sync_for_device) from [] 
(ion_system_heap_allocate+0x2a0/0x2e0)
[] (ion_system_heap_allocate) from [] 
(ion_alloc+0x12c/0x494)
[] (ion_alloc) from [] (ion_ioctl+0x510/0x63c)
[] (ion_ioctl) from [] (do_vfs_ioctl+0xa8/0x9b4)
[] (do_vfs_ioctl) from [] (SyS_ioctl+0x6c/0x7c)
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x48)
Code: e3a02004 e1a02312 e2423001 e1c3 (ee070f3a)
---[ end trace 89278304932c0e87 ]---
Kernel panic - not syncing: Fatal exception

Signed-off-by: Cheng Chao 
---
 drivers/staging/android/ion/ion_system_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_system_heap.c 
b/drivers/staging/android/ion/ion_system_heap.c
index 22c481f2ae4f..2a35b99cf628 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -75,7 +75,7 @@ static struct page *alloc_buffer_page(struct ion_system_heap 
*heap,
 
page = ion_page_pool_alloc(pool);
 
-   if (cached)
+   if (page && cached)
ion_pages_sync_for_device(NULL, page, PAGE_SIZE << order,
  DMA_BIDIRECTIONAL);
return page;
-- 
2.26.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Cheng Chao

Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached 
buffer alloc")
the commit e7f63771b60e introduced the bug which didn't test page which maybe 
NULL.
and previous logic was right.

the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this bug,
and other longterm/stable version have not.

kernel panic is here when page is NULL:

Unable to handle kernel paging request at virtual address b038
pgd = d9d94000
[b038] *pgd=
Internal error: Oops: 2805 [#1] PREEMPT SMP ARM
...
task: daa2dd00 task.stack: da194000
PC is at v7_dma_clean_range+0x1c/0x34
LR is at arm_dma_sync_single_for_device+0x44/0x58
pc : []lr : []psr: 200f0013
sp : da195da0  ip : dc1f9000  fp : c1043dc4
r10:   r9 : c16f1f58  r8 : 0001
r7 : c1621f94  r6 : c0116418  r5 :   r4 : c011aa58
r3 : 003f  r2 : 0040  r1 : b048  r0 : b038
Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
Control: 10c5383d  Table: 19d9406a  DAC: 0051
...
[] (v7_dma_clean_range) from [] 
(arm_dma_sync_single_for_device+0x44/0x58)
[] (arm_dma_sync_single_for_device) from [] 
(arm_dma_sync_sg_for_device+0x50/0x7c)
[] (arm_dma_sync_sg_for_device) from [] 
(ion_pages_sync_for_device+0xb0/0xec)
[] (ion_pages_sync_for_device) from [] 
(ion_system_heap_allocate+0x2a0/0x2e0)
[] (ion_system_heap_allocate) from [] 
(ion_alloc+0x12c/0x494)
[] (ion_alloc) from [] (ion_ioctl+0x510/0x63c)
[] (ion_ioctl) from [] (do_vfs_ioctl+0xa8/0x9b4)
[] (do_vfs_ioctl) from [] (SyS_ioctl+0x6c/0x7c)
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x48)
Code: e3a02004 e1a02312 e2423001 e1c3 (ee070f3a)
---[ end trace 89278304932c0e87 ]---
Kernel panic - not syncing: Fatal exception

Signed-off-by: Cheng Chao 
---
 drivers/staging/android/ion/ion_system_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_system_heap.c 
b/drivers/staging/android/ion/ion_system_heap.c
index 22c481f2ae4f..2a35b99cf628 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -75,7 +75,7 @@ static struct page *alloc_buffer_page(struct ion_system_heap 
*heap,
 
page = ion_page_pool_alloc(pool);
 
-   if (cached)
+   if (page && cached)
ion_pages_sync_for_device(NULL, page, PAGE_SIZE << order,
  DMA_BIDIRECTIONAL);
return page;
-- 
2.26.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Patch "staging: android: ion: fix page is NULL" has been added to the 4.9-stable tree

2021-09-23 Thread gregkh



This is a note to let you know that I've just added the patch titled

staging: android: ion: fix page is NULL

to the 4.9-stable tree which can be found at:

http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
 staging-android-ion-fix-page-is-null.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let  know about it.


>From cs.os.ker...@gmail.com  Thu Sep 23 16:22:16 2021
From: Cheng Chao 
Date: Thu, 23 Sep 2021 22:18:14 +0800
Subject: staging: android: ion: fix page is NULL
To: labb...@redhat.com, sumit.sem...@linaro.org, gre...@linuxfoundation.org, 
a...@android.com, riandr...@android.com, de...@driverdev.osuosl.org
Cc: sta...@vger.kernel.org, Cheng Chao 
Message-ID: <20210923141814.1109472-1-cs.os.ker...@gmail.com>

From: Cheng Chao 

Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached 
buffer alloc")
the commit e7f63771b60e introduced the bug which didn't test page which maybe 
NULL.
and previous logic was right.

the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this bug,
and other longterm/stable version have not.

kernel panic is here when page is NULL:

Unable to handle kernel paging request at virtual address b038
pgd = d9d94000
[b038] *pgd=
Internal error: Oops: 2805 [#1] PREEMPT SMP ARM
...
task: daa2dd00 task.stack: da194000
PC is at v7_dma_clean_range+0x1c/0x34
LR is at arm_dma_sync_single_for_device+0x44/0x58
pc : []lr : []psr: 200f0013
sp : da195da0  ip : dc1f9000  fp : c1043dc4
r10:   r9 : c16f1f58  r8 : 0001
r7 : c1621f94  r6 : c0116418  r5 :   r4 : c011aa58
r3 : 003f  r2 : 0040  r1 : b048  r0 : b038
Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
Control: 10c5383d  Table: 19d9406a  DAC: 0051
...
[] (v7_dma_clean_range) from [] 
(arm_dma_sync_single_for_device+0x44/0x58)
[] (arm_dma_sync_single_for_device) from [] 
(arm_dma_sync_sg_for_device+0x50/0x7c)
[] (arm_dma_sync_sg_for_device) from [] 
(ion_pages_sync_for_device+0xb0/0xec)
[] (ion_pages_sync_for_device) from [] 
(ion_system_heap_allocate+0x2a0/0x2e0)
[] (ion_system_heap_allocate) from [] 
(ion_alloc+0x12c/0x494)
[] (ion_alloc) from [] (ion_ioctl+0x510/0x63c)
[] (ion_ioctl) from [] (do_vfs_ioctl+0xa8/0x9b4)
[] (do_vfs_ioctl) from [] (SyS_ioctl+0x6c/0x7c)
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x48)
Code: e3a02004 e1a02312 e2423001 e1c3 (ee070f3a)
---[ end trace 89278304932c0e87 ]---
Kernel panic - not syncing: Fatal exception

Signed-off-by: Cheng Chao 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/android/ion/ion_system_heap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -75,7 +75,7 @@ static struct page *alloc_buffer_page(st
 
page = ion_page_pool_alloc(pool);
 
-   if (cached)
+   if (page && cached)
ion_pages_sync_for_device(NULL, page, PAGE_SIZE << order,
  DMA_BIDIRECTIONAL);
return page;


Patches currently in stable-queue which might be from cs.os.ker...@gmail.com are

queue-4.9/staging-android-ion-fix-page-is-null.patch
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH

On Thu, Sep 23, 2021 at 10:18:14PM +0800, Cheng Chao wrote:
> Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up 
> cached buffer alloc")
> the commit e7f63771b60e introduced the bug which didn't test page which maybe 
> NULL.
> and previous logic was right.
> 
> the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this 
> bug,
> and other longterm/stable version have not.



thanks for this, now queued up.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v7 02/24] dt-bindings: introduce silabs,wfx.yaml

2021-09-23 Thread Rob Herring

On Mon, 20 Sep 2021 18:11:14 +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller 
> 
> Prepare the inclusion of the wfx driver in the kernel.
> 
> Signed-off-by: Jérôme Pouiller 
> ---
>  .../bindings/net/wireless/silabs,wfx.yaml | 133 ++
>  1 file changed, 133 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
> 

Reviewed-by: Rob Herring 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

[PATCH 4.9] staging: android: ion: fix page is NULL

[PATCH 4.9] staging: android: ion: fix page is NULL

Patch "staging: android: ion: fix page is NULL" has been added to the 4.9-stable tree

Re: [PATCH 4.9] staging: android: ion: fix page is NULL

Re: [PATCH v7 02/24] dt-bindings: introduce silabs,wfx.yaml

6 matches

Site Navigation

Mail list logo

Footer information