Re: [PATCH] staging: wimax: Mundane typo fixes
On Mon, Mar 22, 2021 at 09:14:43PM -0700, Randy Dunlap wrote: > On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote: > > > > s/procesing/processing/ > > s/comunication/communication/ > > > > Signed-off-by: Bhaskar Chowdhury > > drivers/staging/wimax/ is in the process of being deleted. It's already gone from my tree, and should be gone from linux-next as well. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v11 0/6] MIPS: ralink: add CPU clock detection and clock driver for MT7621
Hi Stephen, On Tue, Mar 9, 2021 at 6:22 AM Sergio Paracuellos wrote: > > This patchset ports CPU clock detection for MT7621 from OpenWrt > and adds a complete clock plan for the mt7621 SOC. > > The documentation for this SOC only talks about two registers > regarding to the clocks: > * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped > refclock. PLL and dividers used for CPU and some sort of BUS (AHB?). > * SYSC_REG_CPLL_CLKCFG1 - a banch of gates to enable/disable clocks for > all or some ip cores. > > Registers needed for this driver to work are in two already mapped areas > in its platform's device tree. These are 'sysc' and 'memc' nodes. Most > of other drivers just make use of platform operations defined in > 'asm/mach-ralink/ralink_regs.h' but this can be avoided declaring this > two nodes to be accesible through syscon. Main registers for the clocks > are in the sysc control node so this node is merged with clock properties > and will also be the clock provider for the SoC. > > No documentation about a probably existent set of dividers for each ip > core is included in the datasheets. So we cannot make anything better, > AFAICT. > > Looking into driver code, and some openWRT patched there are > another frequences which are used in some drivers (uart, sd...). > According to all of this information the clock plan for this > SoC is set as follows: > - Main top clock "xtal" from where all the rest of the world is >derived. > - CPU clock "cpu" derived from "xtal" frequencies and a bunch of >register reads and predividers. > - BUS clock "bus" derived from "cpu" and with (cpu / 4) MHz. > - Fixed clocks from "xtal": > * "50m": 50 MHz. > * "125m": 125 MHz. > * "150m": 150 MHz. > * "250m": 250 MHz. > * "270m": 270 MHz. > > We also have a buch of gate clocks with their parents: > - "hsdma": "150m" > - "fe": "250m" > - "sp_divtx": "270m" > - "timer": "50m" > - "pcm": "270m" > - "pio": "50m" > - "gdma": "bus" > - "nand": "125m" > - "i2c": "50m" > - "i2s": "270m" > - "spi": "bus" > - "uart1": "50m" > - "uart2": "50m" > - "uart3": "50m" > - "eth": "50m" > - "pcie0": "125m" > - "pcie1": "125m" > - "pcie2": "125m" > - "crypto": "250m" > - "shxc": "50m" > > There was a previous attempt of doing this here[0] but the author > (Chuanhong Guo) did not wanted to make assumptions of a clock plan > for the platform that time. It seems that now he has a better idea of > how the clocks are dispossed for this SoC so he share code[1] where > some frequencies and clock parents for the gates are coded from a > real mediatek private clock plan. > > I do really want this to be upstreamed so according to the comments > in previous attempt[0] from Oleksij Rempel and the frequencies in > code[1] I have tried to do this by myself. > > All of this patches have been tested in a GNUBee PC1 resulting in a > working platform. > > Changes in v11: > - Collect Rob's Reviewed-by in bindings documentation patch. > - Fix MAINTAINERS patch using file 'mediatek,mt7621-sysc.yaml' >for documentation bindings. Something still missing or something that is needed to be fixed to get this series applied through your tree? Thanks in advance for your time. Best regards, Sergio Paracuellos > > Changes in v10: > - Merge clock properties into 'sysc' system control node making >this node a clock provider. > - Update driver to use 'mediatek,mt7621-sysc' as compatible string. > - Update documentation bindings and its related filename to >'mediatek,mt7621-sysc.yaml'. > - Make use of 'linux/bitfields.h' header to avoid some preprocesor >shift definitions and just use bit masks decreasing a bit LOC. > > Changes in v9: > - Set two missing ret values to its related PTR_ERR in function >'mt7621_clk_probe' (also related with [3]). > - Select MFC_SYSCON in Kconfig. > > Changes in v8: > - Fix kernel test robot complain about the use of 'ret' variable >initialized: see [3] > > Changes in v7: > - Make use of CLK_OF_DECLARE_DRIVER instead of CLK_OF_DECLARE and >register there only the top clocks that are needed in 'of_clk_init'. >The rest of the clocks (fixed and gates) are now registered using >a platform driver. Because we have avoid architecture dependent stuff >now this has sense because we can enable this driver for COMPILE_TEST. > - Convert fixed clocks and gates related function to receive a 'struct >device' pointer instead of 'struct device_node' one. > - Make use of dev_ APIS in stuff related with platform driver instead >of use device_node related stuff. > - Add new static global 'mt7621_clk_early' to store pointers to clk_hw >registered at 'of_clk_init' stage. Make use of this in platform device >probe function to properly copy this into the new required 'clk_data' >to provide a properly hierarchy clock structure. > - Rename 'mt7621_register_top_clocks' function into a more accurate >name now which is 'mt76
Re: [PATCH v3] drivers: most: add ALSA sound driver
On Tue, Feb 09, 2021 at 11:13:47AM +0100, Christian Gromm wrote: > This patch moves the ALSA sound driver out of the staging area and adds it > to the stable part of the MOST driver. Modifications to the Makefiles and > Kconfigs are done accordingly to not break the build. > > Signed-off-by: Christian Gromm > --- > v2: > Reported-by: Greg Kroah-Hartman > > submitted patch that fixes issue found during code audit > to staging version first to be able to resend single patch that > adds the driver. The patch series included: > > - use swabXX functions of kernel > > v3: > Reported-by: Dan Carpenter > > - use non-safe list iteration > - add sanity check for function argument Given a lack of complaints about this, I've now queued this up in my staging tree for the next -rc1 merge window, thanks! greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: Trivial typo fix
On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: > > s/netowrk/network/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c > b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 2c9425e2a1e9..3888d3984ec0 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -599,7 +599,7 @@ void rtw_update_scanned_network(struct adapter *adapter, > struct wlan_bssid_ex *t > } > > if (rtw_roam_flags(adapter)) { > - /* TODO: don't select netowrk in the same ess as > oldest if it's new enough*/ > + /* TODO: don't select network in the same ess as > oldest if it's new enough*/ Any reason you did not remove the two spaces at the same time? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: Trivial typo fix
On 10:05 Tue 23 Mar 2021, Greg KH wrote: On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: s/netowrk/network/ Signed-off-by: Bhaskar Chowdhury --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 2c9425e2a1e9..3888d3984ec0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -599,7 +599,7 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t } if (rtw_roam_flags(adapter)) { - /* TODO: don't select netowrk in the same ess as oldest if it's new enough*/ + /* TODO: don't select network in the same ess as oldest if it's new enough*/ Any reason you did not remove the two spaces at the same time? It skips my attention.Apologies. thanks, greg k-h signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH V2]staging: rtl8723bs: Trivial typo fix
s/netowrk/network/ ..and an extra space has removed from the sentence. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: I have missed to remove an extra space in the sentence, corrected,Greg pointed out,thanks. drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 2c9425e2a1e9..562bc929be4c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -599,7 +599,7 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t } if (rtw_roam_flags(adapter)) { - /* TODO: don't select netowrk in the same ess as oldest if it's new enough*/ + /* TODO: don't select network in the same ess as oldest if it's new enough*/ } if (oldest == NULL || time_after(oldest->last_scanned, pnetwork->last_scanned)) -- 2.31.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c
On 22/03/21 13:11, Greg KH wrote: XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux distributions. Making them depend on, rather than select XILLYBUS_CLASS is likely to disable the driver in those distributions. That's not an issue here, depends-on will allow those distros to also enable this option. But wait, why is this a separate option at all? Shouldn't the class code just be part of the "core" XILLYBUS code anyway? I'll try to explain the whole picture: XILLYBUS_CLASS /\ | | XILLYBUS XILLYUSB / \ | | XILLYBUS_PCIE XILLYBUS_OF XILLYBUS_CLASS is new and common to all drivers in this group. XILLYBUS is for drivers based upon memory registers + DMA-based interfaces, and it's combined with XILLYBUS_PCIE and/or XILLYBUS_OF. XILLYUSB is for the USB variant only. Or a more detailed, bottom-up outline: * CONFIG_XILLYBUS_PCIE -> xillybus_pcie.c: Functions related to PCIe. * CONFIG_XILLYBUS_OF -> xillybus_of.c: Functions related to Xillybus as a peripheral on an FPGA / Processor combo chip. * CONFIG_XILLYBUS -> xillybus_core.c: Functions that are common to the two above, mainly access to the peripheral with memory-mapped registers and DMA. * CONFIG_XILLYUSB -> xillyusb.c: The driver for the USB variant, accesses the peripheral through the USB framework. * CONFIG_XILLYBUS_CLASS -> xillybus_class.c: The new module, which contains the class and API parts that would otherwise appear both in xillybus_core.c and xillyusb.c. Contains utility functions for the two latter. Because XILLYBUS_CLASS is new and "N" by default, making a "depends on" relationship means that "make olddefconfig" silently turns off CONFIG_XILLYBUS and CONFIG_XILLYBUS_PCIE. That's a bug: Adding a new driver shouldn't change anything in the existing configuration. That's why I had the "select XILLYBUS_CLASS" to begin with: It ensures a smooth transition on a kernel upgrade, by adding XILLYBUS_CLASS to kernels that had CONFIG_XILLYBUS enabled. Is there another way to prevent the said bug, without "select"? Thanks and regards, Eli ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/9] fix extern declarations checkpatch issues
Fix extern declaration issues warned by checkpatch. Changes in v2: - removal of prototypes when function can be static - move of static function defs inside file to let the code compile - split last patch in two patches (one patch for blank line removal) Fabio Aiuto (9): staging: rtl8723bs: removed function prototypes in core/rtw_efuse.c staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c staging: rtl8723bs: removed function prototypes and made statics in core/rtw_recv.c staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c staging: rtl8723bs: remove function prototypes in hal/odm.c staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c staging: rtl8723bs: remove blank line os_dep/os_intfs.c drivers/staging/rtl8723bs/core/rtw_efuse.c| 14 +- .../staging/rtl8723bs/core/rtw_ioctl_set.c|1 - drivers/staging/rtl8723bs/core/rtw_mlme.c |2 - drivers/staging/rtl8723bs/core/rtw_recv.c | 441 ++--- .../staging/rtl8723bs/core/rtw_wlan_util.c|3 - drivers/staging/rtl8723bs/hal/odm.c | 1717 - .../staging/rtl8723bs/include/osdep_intf.h|2 + .../staging/rtl8723bs/include/rtw_ioctl_set.h |2 + .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |2 - drivers/staging/rtl8723bs/os_dep/os_intfs.c |5 +- drivers/staging/rtl8723bs/os_dep/sdio_intf.c |3 - 11 files changed, 1038 insertions(+), 1154 deletions(-) -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/9] staging: rtl8723bs: removed function prototypes in core/rtw_efuse.c
fix the following checkpatch issues: WARNING: externs should be avoided in .c files 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: +bool removed two function prototypes in core/rtw_efuse.c and made definition static Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c index 32ca10f01413..3701336e7ff6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -32,12 +32,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; #define REG_EFUSE_CTRL 0x0030 #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ -bool -Efuse_Read1ByteFromFakeContent( - struct adapter *padapter, - u16 Offset, - u8 *Value); -bool +static bool Efuse_Read1ByteFromFakeContent( struct adapter *padapter, u16 Offset, @@ -53,12 +48,7 @@ Efuse_Read1ByteFromFakeContent( return true; } -bool -Efuse_Write1ByteToFakeContent( - struct adapter *padapter, - u16 Offset, - u8 Value); -bool +static bool Efuse_Write1ByteToFakeContent( struct adapter *padapter, u16 Offset, -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/9] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c
fix the following checkpatch issues: WARNING: externs should be avoided in .c files 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40: +u8 rtw_do_join(struct adapter *padapter); WARNING: externs should be avoided in .c files 15: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:15: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 ++ 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index cb14855742f7..7d858cae2395 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -37,7 +37,6 @@ u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid) return ret; } -u8 rtw_do_join(struct adapter *padapter); u8 rtw_do_join(struct adapter *padapter) { struct list_head*plist, *phead; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 95cfef118a94..1ee86ec2dee7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -12,8 +12,6 @@ #include #include -extern u8 rtw_do_join(struct adapter *padapter); - intrtw_init_mlme_priv(struct adapter *padapter) { int i; diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h index d6d3c39a69c6..31424bf2d926 100644 --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h @@ -22,6 +22,8 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 *bssid, struct ndis_802_1 u8 rtw_validate_bssid(u8 *bssid); u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid); +u8 rtw_do_join(struct adapter *padapter); + u16 rtw_get_cur_max_rate(struct adapter *adapter); #endif -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/9] staging: rtl8723bs: removed function prototypes and made statics in core/rtw_recv.c
fix the following checkpatch issue: WARNING: externs should be avoided in .c files 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190: +signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame); removed function prototypes and made statics moved two static function definitions before their usage to make code compile Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 441 ++ 1 file changed, 207 insertions(+), 234 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 1fa381663b4c..608a59286505 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -305,8 +305,7 @@ struct recv_buf *rtw_dequeue_recvbuf(struct __queue *queue) } -signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *precvframe); -signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *precvframe) +static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *precvframe) { signed int i, res = _SUCCESS; @@ -436,8 +435,7 @@ signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *precvfra } /* decrypt and set the ivlen, icvlen of the recv_frame */ -union recv_frame *decryptor(struct adapter *padapter, union recv_frame *precv_frame); -union recv_frame *decryptor(struct adapter *padapter, union recv_frame *precv_frame) +static union recv_frame *decryptor(struct adapter *padapter, union recv_frame *precv_frame) { struct rx_pkt_attrib *prxattrib = &precv_frame->u.hdr.attrib; @@ -528,8 +526,7 @@ union recv_frame *decryptor(struct adapter *padapter, union recv_frame *precv_fr } /* set the security information in the recv_frame */ -union recv_frame *portctrl(struct adapter *adapter, union recv_frame *precv_frame); -union recv_frame *portctrl(struct adapter *adapter, union recv_frame *precv_frame) +static union recv_frame *portctrl(struct adapter *adapter, union recv_frame *precv_frame) { u8 *psta_addr = NULL; u8 *ptr; @@ -606,8 +603,7 @@ union recv_frame *portctrl(struct adapter *adapter, union recv_frame *precv_fram return prtnframe; } -signed int recv_decache(union recv_frame *precv_frame, u8 bretry, struct stainfo_rxcache *prxcache); -signed int recv_decache(union recv_frame *precv_frame, u8 bretry, struct stainfo_rxcache *prxcache) +static signed int recv_decache(union recv_frame *precv_frame, u8 bretry, struct stainfo_rxcache *prxcache) { signed int tid = precv_frame->u.hdr.attrib.priority; @@ -634,8 +630,7 @@ signed int recv_decache(union recv_frame *precv_frame, u8 bretry, struct stainfo } -void process_pwrbit_data(struct adapter *padapter, union recv_frame *precv_frame); -void process_pwrbit_data(struct adapter *padapter, union recv_frame *precv_frame) +static void process_pwrbit_data(struct adapter *padapter, union recv_frame *precv_frame) { unsigned char pwrbit; u8 *ptr = precv_frame->u.hdr.rx_data; @@ -671,8 +666,7 @@ void process_pwrbit_data(struct adapter *padapter, union recv_frame *precv_frame } } -void process_wmmps_data(struct adapter *padapter, union recv_frame *precv_frame); -void process_wmmps_data(struct adapter *padapter, union recv_frame *precv_frame) +static void process_wmmps_data(struct adapter *padapter, union recv_frame *precv_frame) { struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib; struct sta_priv *pstapriv = &padapter->stapriv; @@ -723,8 +717,7 @@ void process_wmmps_data(struct adapter *padapter, union recv_frame *precv_frame) } } -void count_rx_stats(struct adapter *padapter, union recv_frame *prframe, struct sta_info *sta); -void count_rx_stats(struct adapter *padapter, union recv_frame *prframe, struct sta_info *sta) +static void count_rx_stats(struct adapter *padapter, union recv_frame *prframe, struct sta_info *sta) { int sz; struct sta_info *psta = NULL; @@ -755,9 +748,7 @@ void count_rx_stats(struct adapter *padapter, union recv_frame *prframe, struct traffic_check_for_leave_lps(padapter, false, 0); } -signed int sta2sta_data_frame(struct adapter *adapter, union recv_frame *precv_frame, - struct sta_info **psta); -signed int sta2sta_data_frame(struct adapter *adapter, union recv_frame *precv_frame, +static signed int sta2sta_data_frame(struct adapter *adapter, union recv_frame *precv_frame, struct sta_info **psta) { u8 *ptr = precv_frame->u.hdr.rx_data; @@ -850,9 +841,7 @@ signed int sta2sta_data_frame(struct adapter *adapter, union recv_frame *precv_f return ret; } -signed int ap2sta_data_frame(struct adapter *adapter, union recv_frame *precv_frame, - struct sta_info **psta); -signed int ap2sta_data_frame(struct adapter *adapter, union recv_frame *pre
[PATCH v2 4/9] staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c
fix the following checkpatch issues: WARNING: externs should be avoided in .c files 28: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:28: +extern unsigned char RTW_WPA_OUI[]; -- WARNING: externs should be avoided in .c files 29: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:29: +extern unsigned char WPA_TKIP_CIPHER[4]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index bfd55a0356f5..760b0ea4e9bd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -25,9 +25,6 @@ static unsigned char AIRGOCAP_OUI[] = {0x00, 0x0a, 0xf5}; static unsigned char RSN_TKIP_CIPHER[4] = {0x00, 0x0f, 0xac, 0x02}; static unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02}; -extern unsigned char RTW_WPA_OUI[]; -extern unsigned char WPA_TKIP_CIPHER[4]; - #define R2T_PHY_DELAY (0) /* define WAIT_FOR_BCN_TO_MIN (3000) */ -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 6/9] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c
fix the following checkpatch issues: WARNING: externs should be avoided in .c files 196: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:196: +int _netdev_open(struct net_device *pnetdev); -- WARNING: externs should be avoided in .c files 197: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:197: +int netdev_open(struct net_device *pnetdev); moved function prototype in include/osdep_intf.h removed function prototype and made a static removed unnecessary extern declaration in os_dep/ioctl_cfg80211.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h| 2 ++ drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 -- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_intf.h b/drivers/staging/rtl8723bs/include/osdep_intf.h index 5ad85416c598..48c90f00cc2e 100644 --- a/drivers/staging/rtl8723bs/include/osdep_intf.h +++ b/drivers/staging/rtl8723bs/include/osdep_intf.h @@ -69,4 +69,6 @@ void rtw_ndev_destructor(struct net_device *ndev); int rtw_suspend_common(struct adapter *padapter); int rtw_resume_common(struct adapter *padapter); +int netdev_open(struct net_device *pnetdev); + #endif /* _OSDEP_INTF_H_ */ diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index a577ddcce8cd..03a784558d79 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1259,8 +1259,6 @@ static int cfg80211_rtw_get_station(struct wiphy *wiphy, return ret; } -extern int netdev_open(struct net_device *pnetdev); - static int cfg80211_rtw_change_iface(struct wiphy *wiphy, struct net_device *ndev, enum nl80211_iftype type, diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 9ae7d46fb501..c6c5cc0a9e08 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -193,8 +193,6 @@ MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable, "0:Disable, 1:Enable, 2: Depend on efuse module_param(rtw_tx_pwr_by_rate, int, 0644); MODULE_PARM_DESC(rtw_tx_pwr_by_rate, "0:Disable, 1:Enable, 2: Depend on efuse"); -int _netdev_open(struct net_device *pnetdev); -int netdev_open(struct net_device *pnetdev); static int netdev_close(struct net_device *pnetdev); static void loadparam(struct adapter *padapter, struct net_device *pnetdev) @@ -875,7 +873,7 @@ int rtw_drv_register_netdev(struct adapter *if1) return _rtw_drv_register_netdev(padapter, name); } -int _netdev_open(struct net_device *pnetdev) +static int _netdev_open(struct net_device *pnetdev) { uint status; struct adapter *padapter = rtw_netdev_priv(pnetdev); -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/9] staging: rtl8723bs: remove function prototypes in hal/odm.c
fix the following checkpatch issues: WARNING: externs should be avoided in .c files 285: FILE: drivers/staging/rtl8723bs/hal/odm.c:285: +void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 287: FILE: drivers/staging/rtl8723bs/hal/odm.c:287: +void odm_CommonInfoSelfUpdate(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 289: FILE: drivers/staging/rtl8723bs/hal/odm.c:289: +void odm_CmnInfoInit_Debug(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 291: FILE: drivers/staging/rtl8723bs/hal/odm.c:291: +void odm_BasicDbgMessage(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 305: FILE: drivers/staging/rtl8723bs/hal/odm.c:305: +void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 309: FILE: drivers/staging/rtl8723bs/hal/odm.c:309: +void odm_RSSIMonitorInit(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 311: FILE: drivers/staging/rtl8723bs/hal/odm.c:311: +void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 313: FILE: drivers/staging/rtl8723bs/hal/odm.c:313: +void odm_RSSIMonitorCheck(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 315: FILE: drivers/staging/rtl8723bs/hal/odm.c:315: +void odm_SwAntDetectInit(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 317: FILE: drivers/staging/rtl8723bs/hal/odm.c:317: +void odm_SwAntDivChkAntSwitchCallback(void *FunctionContext); -- WARNING: externs should be avoided in .c files 321: FILE: drivers/staging/rtl8723bs/hal/odm.c:321: +void odm_GlobalAdapterCheck(void); -- WARNING: externs should be avoided in .c files 323: FILE: drivers/staging/rtl8723bs/hal/odm.c:323: +void odm_RefreshRateAdaptiveMask(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 325: FILE: drivers/staging/rtl8723bs/hal/odm.c:325: +void ODM_TXPowerTrackingCheck(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 327: FILE: drivers/staging/rtl8723bs/hal/odm.c:327: +void odm_RateAdaptiveMaskInit(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 330: FILE: drivers/staging/rtl8723bs/hal/odm.c:330: +void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 338: FILE: drivers/staging/rtl8723bs/hal/odm.c:338: +void odm_InitHybridAntDiv(struct dm_odm_t *pDM_Odm); -- WARNING: externs should be avoided in .c files 340: FILE: drivers/staging/rtl8723bs/hal/odm.c:340: +bool odm_StaDefAntSel( -- WARNING: externs should be avoided in .c files 349: FILE: drivers/staging/rtl8723bs/hal/odm.c:349: +void odm_SetRxIdleAnt(struct dm_odm_t *pDM_Odm, u8 Ant, bool bDualPath); -- WARNING: externs should be avoided in .c files 353: FILE: drivers/staging/rtl8723bs/hal/odm.c:353: +void odm_HwAntDiv(struct dm_odm_t *pDM_Odm); removed function prototypes and made staics where needed in hal/odm.c moved function definition in file to let the compiler work Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 1717 +-- 1 file changed, 824 insertions(+), 893 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c index 49d552105a65..3d92eee3a840 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -279,1126 +279,1057 @@ u32 TxScalingTable_Jaguar[TXSCALE_TABLE_SIZE] = { 0x3FE /* 36, +6.0dB */ }; -/* Local Function predefine. */ - -/* STARTCOMMON INFO RELATED--- */ -void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm); - -void odm_CommonInfoSelfUpdate(struct dm_odm_t *pDM_Odm); +/* Remove Edca by Yu Chen */ -void odm_CmnInfoInit_Debug(struct dm_odm_t *pDM_Odm); -void odm_BasicDbgMessage(struct dm_odm_t *pDM_Odm); +#define RxDefaultAnt1 0x65a9 +#define RxDefaultAnt2 0x569a -/* ENDCOMMON INFO RELATED--- */ +static void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm) +{ + pDM_Odm->bCckHighPower = (bool) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG(CCK_RPT_FORMAT, pDM_Odm), ODM_BIT(CCK_RPT_FORMAT, pDM_Odm)); + pDM_Odm->RFPathRxEnable = (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG(BB_RX_PATH, pDM_Odm), ODM_BIT(BB_RX_PATH, pDM_Odm)); -/* START---DIG--- */ + ODM_InitDebugSetting(pDM_Odm); -/* Remove by Yuchen */ + pDM_Odm->TxRate = 0xFF; +} -/* END---DIG--- */ +static void odm_CommonInfoSelfUpdate(struct dm_odm_t *pDM_Odm) +{ + u8 EntryCnt = 0; + u8 i; + PSTA_INFO_T pEntry; -/* START---BB POWER SAVE--- */ -/* Remove BB power Saving by YuChen */ -/* END-BB POWER SAVE--- */ + if (*(pDM_Odm->pBandWidth)
[PATCH v2 7/9] staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c
fix the following checkpatch issue: WARNING: externs should be avoided in .c files 486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486: +extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 8f8549eee23e..185919b6963f 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -483,7 +483,6 @@ static void rtw_dev_remove(struct sdio_func *func) } extern int pm_netdev_open(struct net_device *pnetdev, u8 bnormal); -extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); static int rtw_sdio_suspend(struct device *dev) { -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 8/9] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c
remove unnecessary extern. The function is defined static in os_dep/os_intfs.c and used only once in the same file Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 185919b6963f..156ad91d33ee 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -482,8 +482,6 @@ static void rtw_dev_remove(struct sdio_func *func) RT_TRACE(_module_hci_intfs_c_, _drv_notice_, ("-rtw_dev_remove\n")); } -extern int pm_netdev_open(struct net_device *pnetdev, u8 bnormal); - static int rtw_sdio_suspend(struct device *dev) { struct sdio_func *func = dev_to_sdio_func(dev); -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 9/9] staging: rtl8723bs: remove blank line os_dep/os_intfs.c
remove blank line Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index c6c5cc0a9e08..405aa95af579 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1027,7 +1027,6 @@ void rtw_ips_dev_unload(struct adapter *padapter) rtw_hal_deinit(padapter); } - static int pm_netdev_open(struct net_device *pnetdev, u8 bnormal) { int status = -1; -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/9] fix extern declarations checkpatch issues
On Tue, Mar 23, 2021 at 01:56:27PM +0100, Fabio Aiuto wrote: > Fix extern declaration issues warned by checkpatch. Nit, we have a new mailing list, you might want to use that now instead of driverdev in the future, thanks! greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 06/12] media: atomisp: Remove defines
Em Mon, 14 Dec 2020 12:01:50 +0100 Philipp Gerlesberger escreveu: > Remov defines, they don't make sense. > The programmer should know what things need to be static and what not. > Also leave "inline" out and let the compiler decide > > Co-developed-by: Andrey Khlopkov > Signed-off-by: Andrey Khlopkov > Signed-off-by: Philipp Gerlesberger > --- > .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git > a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > index 9cd3d92b34c9..45b72e98bc9f 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > @@ -21,10 +21,7 @@ > #ifndef __INLINE_RMGR__ > #define STORAGE_CLASS_RMGR_H extern > #define STORAGE_CLASS_RMGR_C > -#else/* __INLINE_RMGR__ */ > -#define STORAGE_CLASS_RMGR_H static inline > -#define STORAGE_CLASS_RMGR_C static inline > -#endif /* __INLINE_RMGR__ */ > +#endif No, that's not the right way to address it. Instead, you should replace the occurrences of those macros at the code and get rid of them. Thanks, Mauro ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS
Em Mon, 14 Dec 2020 12:01:56 +0100 Philipp Gerlesberger escreveu: > Logical continuations should be on the previous line > > Co-developed-by: Andrey Khlopkov > Signed-off-by: Andrey Khlopkov > Signed-off-by: Philipp Gerlesberger > --- > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > index 2f1c2df59f71..7d44070c7114 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > @@ -24,8 +24,8 @@ > > */ > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t > *desc) > { > - if (NULL == qhandle || NULL == desc > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > + if (NULL == qhandle || NULL == desc || > + NULL == desc->cb_elems || NULL == desc->cb_desc) { Nah, there are coding style issues here... we usually do: if (foo == CONSTANT) instead of: if (CONSTANT == foo) Also, we usually simplify checks for null. So, the above should be, instead, just: if (!qhandle || !desc || !desc->cb_elements || !desc->cb_desc) > /* Invalid parameters, return error*/ > return -EINVAL; > } Thanks, Mauro ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote: > Fixed alignment of multi-line comment. > Added a * for each line of the comment. > > Signed-off-by: Abhishek C > --- > drivers/android/binder.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index c119736ca56a..700719c58147 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned > int cmd, unsigned long arg) > unsigned int size = _IOC_SIZE(cmd); > void __user *ubuf = (void __user *)arg; > > - /*pr_info("binder_ioctl: %d:%d %x %lx\n", > - proc->pid, current->pid, cmd, arg);*/ > + /* pr_info("binder_ioctl: %d:%d %x %lx\n", > + * proc->pid, current->pid, cmd, arg); > + */ This looks like left-over debugging code, and as-is, is formatted properly. Why not just delete it entirely? If someone needs debugging code, they can add it back in. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c
On Mon, Mar 22, 2021 at 10:29:27PM +0300, Dan Carpenter wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > > +bool > > > > moved two function prototypes in include/rtw_efuse.h > > Can't you just make these functions static instead? > > regards, > dan carpenter > Hi Dan, sorry for my recent spamming, I forgot to cc you in my patchset v2 submit. Thank you, fabio ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v5 08/24] wfx: add bus_sdio.c
On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller wrote: > > Hello Ulf, > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > wrote: > > > > > > From: Jérôme Pouiller > > > > > > Signed-off-by: Jérôme Pouiller > > > --- > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 + > > > 1 file changed, 259 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > [...] > > > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) > > > }, > > > + { }, > > > +}; > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > + > > > +struct sdio_driver wfx_sdio_driver = { > > > + .name = "wfx-sdio", > > > + .id_table = wfx_sdio_ids, > > > + .probe = wfx_sdio_probe, > > > + .remove = wfx_sdio_remove, > > > + .drv = { > > > + .owner = THIS_MODULE, > > > + .of_match_table = wfx_sdio_of_match, > > > > It's not mandatory to support power management, like system > > suspend/resume. However, as this looks like this is a driver for an > > embedded SDIO device, you probably want this. > > > > If that is the case, please assign the dev_pm_ops here and implement > > the ->suspend|resume() callbacks. > > I have no platform to test suspend/resume, so I have only a > theoretical understanding of this subject. I see. > > I understanding is that with the current implementation, the > device will be powered off on suspend and then totally reset > (including reloading of the firmware) on resume. I am wrong? You are correct, for a *removable* SDIO card. In this case, the mmc/sdio core will remove the corresponding SDIO card/device and its corresponding SDIO func devices at system suspend. It will then be redetected at system resume (and the SDIO func driver re-probed). Although, as this is an embedded SDIO device, per definition it's not a removable card (MMC_CAP_NONREMOVABLE should be set for the corresponding mmc host), the SDIO card will stick around and instead the ->suspend|resume() callback needs to be implemented for the SDIO func driver. > > This behavior sounds correct to me. You would expect something > more? Yes, see above. Kind regards Uffe ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2]staging: rtl8723bs: Trivial typo fix
On 3/23/21 2:23 AM, Bhaskar Chowdhury wrote: > s/netowrk/network/ > > ..and an extra space has removed from the sentence. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > I have missed to remove an extra space in the sentence, > corrected,Greg pointed out,thanks. > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c > b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 2c9425e2a1e9..562bc929be4c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -599,7 +599,7 @@ void rtw_update_scanned_network(struct adapter *adapter, > struct wlan_bssid_ex *t > } > > if (rtw_roam_flags(adapter)) { > - /* TODO: don't select netowrk in the same ess as > oldest if it's new enough*/ > + /* TODO: don't select network in the same ess as oldest > if it's new enough*/ > } > > if (oldest == NULL || time_after(oldest->last_scanned, > pnetwork->last_scanned)) > -- -- ~Randy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v5 08/24] wfx: add bus_sdio.c
On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote: > On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller > wrote: > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > > wrote: > > > > > > > > From: Jérôme Pouiller > > > > > > > > Signed-off-by: Jérôme Pouiller > > > > --- > > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 + > > > > 1 file changed, 259 insertions(+) > > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > > > [...] > > > > > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, > > > > SDIO_DEVICE_ID_SILABS_WF200) }, > > > > + { }, > > > > +}; > > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > > + > > > > +struct sdio_driver wfx_sdio_driver = { > > > > + .name = "wfx-sdio", > > > > + .id_table = wfx_sdio_ids, > > > > + .probe = wfx_sdio_probe, > > > > + .remove = wfx_sdio_remove, > > > > + .drv = { > > > > + .owner = THIS_MODULE, > > > > + .of_match_table = wfx_sdio_of_match, > > > > > > It's not mandatory to support power management, like system > > > suspend/resume. However, as this looks like this is a driver for an > > > embedded SDIO device, you probably want this. > > > > > > If that is the case, please assign the dev_pm_ops here and implement > > > the ->suspend|resume() callbacks. > > > > I have no platform to test suspend/resume, so I have only a > > theoretical understanding of this subject. > > I see. > > > > > I understanding is that with the current implementation, the > > device will be powered off on suspend and then totally reset > > (including reloading of the firmware) on resume. I am wrong? > > You are correct, for a *removable* SDIO card. In this case, the > mmc/sdio core will remove the corresponding SDIO card/device and its > corresponding SDIO func devices at system suspend. It will then be > redetected at system resume (and the SDIO func driver re-probed). > > Although, as this is an embedded SDIO device, per definition it's not > a removable card (MMC_CAP_NONREMOVABLE should be set for the > corresponding mmc host), the SDIO card will stick around and instead > the ->suspend|resume() callback needs to be implemented for the SDIO > func driver. If I follow what has been done in other drivers I would write something like: static int wfx_sdio_suspend(struct device *dev) { struct sdio_func *func = dev_to_sdio_func(dev); struct wfx_sdio_priv *bus = sdio_get_drvdata(func); config_reg_write_bits(bus->core, CFG_IRQ_ENABLE_DATA, 0); // Necessary to keep device firmware in RAM return sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER); } However, why not the implementation below? static int wfx_sdio_suspend(struct device *dev) { struct sdio_func *func = dev_to_sdio_func(dev); wfx_sdio_remove(func); return 0; } In both cases, I worry to provide these functions without being able to test them. -- Jérôme Pouiller ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v5 08/24] wfx: add bus_sdio.c
On Tue, 23 Mar 2021 at 18:53, Jérôme Pouiller wrote: > > On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote: > > On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller > > wrote: > > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > > > wrote: > > > > > > > > > > From: Jérôme Pouiller > > > > > > > > > > Signed-off-by: Jérôme Pouiller > > > > > --- > > > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 > > > > > + > > > > > 1 file changed, 259 insertions(+) > > > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > > > > > [...] > > > > > > > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, > > > > > SDIO_DEVICE_ID_SILABS_WF200) }, > > > > > + { }, > > > > > +}; > > > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > > > + > > > > > +struct sdio_driver wfx_sdio_driver = { > > > > > + .name = "wfx-sdio", > > > > > + .id_table = wfx_sdio_ids, > > > > > + .probe = wfx_sdio_probe, > > > > > + .remove = wfx_sdio_remove, > > > > > + .drv = { > > > > > + .owner = THIS_MODULE, > > > > > + .of_match_table = wfx_sdio_of_match, > > > > > > > > It's not mandatory to support power management, like system > > > > suspend/resume. However, as this looks like this is a driver for an > > > > embedded SDIO device, you probably want this. > > > > > > > > If that is the case, please assign the dev_pm_ops here and implement > > > > the ->suspend|resume() callbacks. > > > > > > I have no platform to test suspend/resume, so I have only a > > > theoretical understanding of this subject. > > > > I see. > > > > > > > > I understanding is that with the current implementation, the > > > device will be powered off on suspend and then totally reset > > > (including reloading of the firmware) on resume. I am wrong? > > > > You are correct, for a *removable* SDIO card. In this case, the > > mmc/sdio core will remove the corresponding SDIO card/device and its > > corresponding SDIO func devices at system suspend. It will then be > > redetected at system resume (and the SDIO func driver re-probed). > > > > Although, as this is an embedded SDIO device, per definition it's not > > a removable card (MMC_CAP_NONREMOVABLE should be set for the > > corresponding mmc host), the SDIO card will stick around and instead > > the ->suspend|resume() callback needs to be implemented for the SDIO > > func driver. > > If I follow what has been done in other drivers I would write something > like: > > static int wfx_sdio_suspend(struct device *dev) > { > struct sdio_func *func = dev_to_sdio_func(dev); > struct wfx_sdio_priv *bus = sdio_get_drvdata(func); > > config_reg_write_bits(bus->core, CFG_IRQ_ENABLE_DATA, 0); > // Necessary to keep device firmware in RAM > return sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER); This will tell the mmc/sdio core to keep the SDIO card powered on during system suspend. Thus, it doesn't need to re-initialize it at system resume - and the firmware should not need to be re-programmed. On the other hand, if you don't plan to support system wakeups, it would probably be better to power off the card, to avoid wasting energy while the system is suspended. I assume that means you need to re-program the firmware as well. Normally, it's these kinds of things that need to be managed from a ->resume() callback. > } > > However, why not the implementation below? > > static int wfx_sdio_suspend(struct device *dev) > { > struct sdio_func *func = dev_to_sdio_func(dev); > > wfx_sdio_remove(func); I don't know what wfx_sdio_remove() does, but for sure you would need a ->resume() callback to make it possible to restore power/firmware. > return 0; > } > > In both cases, I worry to provide these functions without being able to > test them. Alright, let's simply leave this driver without having the PM callbacks assigned. I guess we can revisit this at some later point. The mmc core will log a message about the missing callbacks, in case someone tries to execute system suspend/resume when the driver has been probed. Kind regards Uffe ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 01/13] dt-bindings: mfd: Add 'nxp, imx8mq-vpu-ctrl' to syscon list
On Thu, 18 Mar 2021 09:20:34 +0100, Benjamin Gaignard wrote: > Add 'nxp,imx8mq-vpu-ctrl' in the list of possible syscon. > It will used to access to the VPU control registers. > > Signed-off-by: Benjamin Gaignard > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 02/13] dt-bindings: media: nxp, imx8mq-vpu: Update the bindings for G2 support
On Thu, 18 Mar 2021 09:20:35 +0100, Benjamin Gaignard wrote: > Introducing G2 hevc video decoder lead to modify the bindings to allow > to get one node per VPUs. > VPUs share one hardware control block which is provided as a phandle on > an syscon. > Each node got now one reg and one interrupt. > Add a compatible for G2 hardware block: nxp,imx8mq-vpu-g2. > > To be compatible with older DT the driver is still capable to use 'ctrl' > reg-name even if it is deprecated now. > > Signed-off-by: Benjamin Gaignard > --- > version 5: > - This version doesn't break the backward compatibilty between kernel > and DT. > > .../bindings/media/nxp,imx8mq-vpu.yaml| 53 --- > 1 file changed, 34 insertions(+), 19 deletions(-) > Reviewed-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v5 02/24] dt-bindings: introduce silabs,wfx.yaml
On Mon, 15 Mar 2021 14:24:39 +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Prepare the inclusion of the wfx driver in the kernel. > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 133 ++ > 1 file changed, 133 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml > Reviewed-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-linus] BUILD SUCCESS e78836ae76d20f38eed8c8c67f21db97529949da
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-linus branch HEAD: e78836ae76d20f38eed8c8c67f21db97529949da staging: rtl8192e: Change state information from u16 to u8 elapsed time: 723m configs tested: 114 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig x86_64 allyesconfig i386 allyesconfig powerpcsam440ep_defconfig powerpc mpc834x_itxgp_defconfig powerpc ppa8548_defconfig powerpc mpc836x_rdk_defconfig armlart_defconfig m68k m5208evb_defconfig mips cu1000-neo_defconfig powerpc ksi8560_defconfig armmps2_defconfig mipsmalta_kvm_guest_defconfig arc haps_hs_smp_defconfig sparc defconfig powerpc lite5200b_defconfig powerpc sequoia_defconfig mips rbtx49xx_defconfig powerpcsocrates_defconfig nds32 allnoconfig arm imx_v6_v7_defconfig armneponset_defconfig shhp6xx_defconfig arm orion5x_defconfig mipsmalta_qemu_32r6_defconfig mips capcella_defconfig arm lubbock_defconfig powerpc tqm8541_defconfig powerpc mpc834x_itx_defconfig sh rsk7203_defconfig mips loongson1b_defconfig arm davinci_all_defconfig powerpc mpc866_ads_defconfig sh ap325rxa_defconfig arm socfpga_defconfig powerpc wii_defconfig arm pxa_defconfig powerpc tqm8555_defconfig powerpc eiger_defconfig arm pxa168_defconfig mips cu1830-neo_defconfig powerpc obs600_defconfig powerpc64 defconfig mips ath25_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig nios2 defconfig arc allyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig sparcallyesconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a002-20210323 x86_64 randconfig-a003-20210323 x86_64 randconfig-a006-20210323 x86_64 randconfig-a001-20210323 x86_64 randconfig-a004-20210323 x86_64 randconfig-a005-20210323 i386 randconfig-a003-20210323 i386 randconfig-a004-20210323 i386 randconfig-a001-20210323 i386 randconfig-a002-20210323 i386 randconfig-a006-20210323 i386 randconfig-a005-20210323 i386 randconfig-a014-20210323 i386 randconfig-a011-20210323 i386 randconfig-a015-20210323 i386 randconfig-a016-20210323 i386 randconfig-a012-20210323 i386 randconfig-a013-20210323 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv
[staging:staging-testing] BUILD SUCCESS d010995736cb581de55e99268d66937085b45ea0
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: d010995736cb581de55e99268d66937085b45ea0 staging: rtl8723bs: remove blank line os_dep/os_intfs.c elapsed time: 725m configs tested: 94 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig x86_64 allyesconfig i386 allyesconfig riscvallyesconfig m68k m5208evb_defconfig mips cu1000-neo_defconfig powerpc ksi8560_defconfig armmps2_defconfig powerpcsocrates_defconfig arm imx_v6_v7_defconfig armneponset_defconfig shhp6xx_defconfig arm orion5x_defconfig mipsworkpad_defconfig mips cu1830-neo_defconfig armshmobile_defconfig powerpc ep8248e_defconfig powerpc makalu_defconfig armspear3xx_defconfig arm pxa_defconfig powerpc tqm8555_defconfig powerpc eiger_defconfig arm pxa168_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig nios2 defconfig arc allyesconfig nds32 allnoconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a002-20210323 x86_64 randconfig-a003-20210323 x86_64 randconfig-a006-20210323 x86_64 randconfig-a001-20210323 x86_64 randconfig-a004-20210323 x86_64 randconfig-a005-20210323 i386 randconfig-a003-20210323 i386 randconfig-a004-20210323 i386 randconfig-a001-20210323 i386 randconfig-a002-20210323 i386 randconfig-a006-20210323 i386 randconfig-a005-20210323 i386 randconfig-a014-20210323 i386 randconfig-a011-20210323 i386 randconfig-a015-20210323 i386 randconfig-a016-20210323 i386 randconfig-a012-20210323 i386 randconfig-a013-20210323 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3-kbuiltin x86_64 kexec clang tested configs: x86_64 randconfig-a012-20210323 x86_64 randconfig-a015-20210323 x86_64 randconfig-a013-20210323 x86_64 randconfig-a014-20210323 x86_64 randconfig-a011-20210323 x86_64 randconfig-a016-20210323 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman
[driver-core:driver-core-linus] BUILD SUCCESS f0acf637d60ffcef3ccb6e279f743e587b3c7359
nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a002-20210323 x86_64 randconfig-a003-20210323 x86_64 randconfig-a006-20210323 x86_64 randconfig-a001-20210323 x86_64 randconfig-a004-20210323 x86_64 randconfig-a005-20210323 i386 randconfig-a003-20210323 i386 randconfig-a004-20210323 i386 randconfig-a001-20210323 i386 randconfig-a002-20210323 i386 randconfig-a006-20210323 i386 randconfig-a005-20210323 i386 randconfig-a004-20210324 i386 randconfig-a003-20210324 i386 randconfig-a001-20210324 i386 randconfig-a002-20210324 i386 randconfig-a006-20210324 i386 randconfig-a005-20210324 i386 randconfig-a014-20210323 i386 randconfig-a011-20210323 i386 randconfig-a015-20210323 i386 randconfig-a016-20210323 i386 randconfig-a012-20210323 i386 randconfig-a013-20210323 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3-kbuiltin x86_64 kexec clang tested configs: x86_64 randconfig-a012-20210323 x86_64 randconfig-a015-20210323 x86_64 randconfig-a013-20210323 x86_64 randconfig-a014-20210323 x86_64 randconfig-a011-20210323 x86_64 randconfig-a016-20210323 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:driver-core-testing] BUILD SUCCESS a7d30f3f41cf40aad1c4557fa180fe320d5b7c74
s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a003-20210323 i386 randconfig-a004-20210323 i386 randconfig-a001-20210323 i386 randconfig-a002-20210323 i386 randconfig-a006-20210323 i386 randconfig-a005-20210323 i386 randconfig-a004-20210324 i386 randconfig-a003-20210324 i386 randconfig-a001-20210324 i386 randconfig-a002-20210324 i386 randconfig-a006-20210324 i386 randconfig-a005-20210324 i386 randconfig-a014-20210323 i386 randconfig-a011-20210323 i386 randconfig-a015-20210323 i386 randconfig-a016-20210323 i386 randconfig-a012-20210323 i386 randconfig-a013-20210323 x86_64 randconfig-a002-20210323 x86_64 randconfig-a003-20210323 x86_64 randconfig-a006-20210323 x86_64 randconfig-a001-20210323 x86_64 randconfig-a004-20210323 x86_64 randconfig-a005-20210323 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3-kbuiltin x86_64 kexec clang tested configs: x86_64 randconfig-a012-20210323 x86_64 randconfig-a015-20210323 x86_64 randconfig-a013-20210323 x86_64 randconfig-a014-20210323 x86_64 randconfig-a011-20210323 x86_64 randconfig-a016-20210323 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel