[PATCH] staging: rtl8192u: minor coding style fix
Fixes this checkpatch warning
WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: Lee Gibson
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index d853586705fc..175bb8b15389 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -726,7 +726,7 @@ static int r8192_wx_set_enc_ext(struct net_device *dev,
idx--;
group = ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY;
- if ((!group) || (IW_MODE_ADHOC == ieee->iw_mode) || (alg ==
KEY_TYPE_WEP40)) {
+ if ((!group) || (ieee->iw_mode == IW_MODE_ADHOC) || (alg ==
KEY_TYPE_WEP40)) {
if ((ext->key_len == 13) && (alg == KEY_TYPE_WEP40))
alg = KEY_TYPE_WEP104;
ieee->pairwise_key_type = alg;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] media: hantro: Auto generate the AXI ID to avoid conflicts
The AXI ID is an AXI bus configuration for improve bus performance. If
read and write operations use different ID the operations can be
paralleled, whereas when they have the same ID the operations will be
serialized. Right now, the write ID is fixed to 0 but we can set it to
0xff to get auto generated ID to avoid possible conflicts.
This change has no functional changes, but seems reasonable to let the
hardware to autogenerate the ID instead of hardcoding in software.
Signed-off-by: Enric Balletbo i Serra
---
drivers/staging/media/hantro/hantro_g1_h264_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/hantro/hantro_g1_h264_dec.c
b/drivers/staging/media/hantro/hantro_g1_h264_dec.c
index 845bef73d218..090088cd98ea 100644
--- a/drivers/staging/media/hantro/hantro_g1_h264_dec.c
+++ b/drivers/staging/media/hantro/hantro_g1_h264_dec.c
@@ -30,7 +30,7 @@ static void set_params(struct hantro_ctx *ctx)
u32 reg;
/* Decoder control register 0. */
- reg = G1_REG_DEC_CTRL0_DEC_AXI_WR_ID(0x0);
+ reg = G1_REG_DEC_CTRL0_DEC_AXI_WR_ID(0xff);
if (sps->flags & V4L2_H264_SPS_FLAG_MB_ADAPTIVE_FRAME_FIELD)
reg |= G1_REG_DEC_CTRL0_SEQ_MBAFF_E;
if (sps->profile_idc > 66) {
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:debugfs_remove_return_value] BUILD SUCCESS 69a38ab85705e888ec86d0731cb46fd39c41dcfe
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_remove_return_value branch HEAD: 69a38ab85705e888ec86d0731cb46fd39c41dcfe debugfs: remove return value of debugfs_create_bool() elapsed time: 725m configs tested: 107 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc tqm8541_defconfig arm gemini_defconfig powerpc xes_mpc85xx_defconfig m68kq40_defconfig armmmp2_defconfig m68k m5275evb_defconfig powerpc pcm030_defconfig arm iop32x_defconfig mipsbcm47xx_defconfig powerpc mpc837x_mds_defconfig microblaze mmu_defconfig powerpc stx_gp3_defconfig powerpc mpc836x_rdk_defconfig powerpcge_imp3a_defconfig mips ip27_defconfig mipsomega2p_defconfig arcnsim_700_defconfig s390 allmodconfig riscvallyesconfig arcvdk_hs38_smp_defconfig powerpc canyonlands_defconfig sh sh7710voipgw_defconfig powerpc mpc836x_mds_defconfig arm lpc18xx_defconfig mips tb0219_defconfig powerpc ep8248e_defconfig arm milbeaut_m10v_defconfig riscv allnoconfig sh rts7751r2d1_defconfig mips gcw0_defconfig arm vf610m4_defconfig arm ezx_defconfig armoxnas_v6_defconfig mips maltaaprp_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210225 i386 randconfig-a006-20210225 i386 randconfig-a004-20210225 i386 randconfig-a001-20210225 i386 randconfig-a003-20210225 i386 randconfig-a002-20210225 x86_64 randconfig-a015-20210225 x86_64 randconfig-a011-20210225 x86_64 randconfig-a012-20210225 x86_64 randconfig-a016-20210225 x86_64 randconfig-a013-20210225 x86_64 randconfig-a014-20210225 i386 randconfig-a013-20210225 i386 randconfig-a012-20210225 i386 randconfig-a011-20210225 i386 randconfig-a014-20210225 i386 randconfig-a016-20210225 i386 randconfig-a015-20210225 riscvnommu_k210_defconfig riscvnommu_virt_defconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3
[staging:staging-testing] BUILD SUCCESS 09f800c562683848511c8a7750d73d50cfd506ef
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: 09f800c562683848511c8a7750d73d50cfd506ef staging: clocking-wizard: Remove the hardcoding of the clock outputs elapsed time: 725m configs tested: 117 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc tqm8541_defconfig arm gemini_defconfig powerpc xes_mpc85xx_defconfig m68kq40_defconfig armmmp2_defconfig m68k m5275evb_defconfig nios2 defconfig riscvnommu_k210_defconfig m68k amiga_defconfig arm ep93xx_defconfig sh se7619_defconfig powerpc mpc836x_mds_defconfig powerpc pcm030_defconfig arm iop32x_defconfig mipsbcm47xx_defconfig powerpc mpc837x_mds_defconfig microblaze mmu_defconfig powerpc stx_gp3_defconfig powerpc mpc836x_rdk_defconfig powerpcge_imp3a_defconfig mips ip27_defconfig mipsomega2p_defconfig arcnsim_700_defconfig s390 allmodconfig riscvallyesconfig arcvdk_hs38_smp_defconfig powerpc canyonlands_defconfig sh sh7710voipgw_defconfig arm lpc18xx_defconfig mips tb0219_defconfig powerpc ep8248e_defconfig arm milbeaut_m10v_defconfig riscv allnoconfig armzeus_defconfig powerpc ep88xc_defconfig mips rm200_defconfig sh rts7751r2d1_defconfig mips gcw0_defconfig arm vf610m4_defconfig arm ezx_defconfig armoxnas_v6_defconfig mips maltaaprp_defconfig powerpc mpc832x_mds_defconfig arm cns3420vb_defconfig sh secureedge5410_defconfig riscvnommu_virt_defconfig arm simpad_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210225 i386 randconfig-a006-20210225 i386 randconfig-a004-20210225 i386 randconfig-a001-20210225 i386 randconfig-a003-20210225 i386 randconfig-a002-20210225 x86_64 randconfig-a015-20210225 x86_64 randconfig-a011-20210225 x86_64 randconfig-a012-20210225 x86_64 randconfig-a016-20210225 x86_64 randconfig-a013-20210225 x86_64 randconfig-a014-20210225 i386 randconfig-a013-20210225 i386 randconfig-a012-20210225 i386 randconfig-a011-20210225 i386 randconfig-a014
Re: [PATCH] media: hantro: Auto generate the AXI ID to avoid conflicts
Hi Enric, Thanks a lot for the patch. On Thu, 25 Feb 2021 at 09:08, Enric Balletbo i Serra wrote: > > The AXI ID is an AXI bus configuration for improve bus performance. If > read and write operations use different ID the operations can be > paralleled, whereas when they have the same ID the operations will be > serialized. Right now, the write ID is fixed to 0 but we can set it to > 0xff to get auto generated ID to avoid possible conflicts. > > This change has no functional changes, but seems reasonable to let the > hardware to autogenerate the ID instead of hardcoding in software. > > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/staging/media/hantro/hantro_g1_h264_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro_g1_h264_dec.c > b/drivers/staging/media/hantro/hantro_g1_h264_dec.c > index 845bef73d218..090088cd98ea 100644 > --- a/drivers/staging/media/hantro/hantro_g1_h264_dec.c > +++ b/drivers/staging/media/hantro/hantro_g1_h264_dec.c > @@ -30,7 +30,7 @@ static void set_params(struct hantro_ctx *ctx) > u32 reg; > > /* Decoder control register 0. */ > - reg = G1_REG_DEC_CTRL0_DEC_AXI_WR_ID(0x0); > + reg = G1_REG_DEC_CTRL0_DEC_AXI_WR_ID(0xff); Can we define a macro to avoid this magic number, and add some comments explaining what's 0xff for? Given this is AXI configuration, I'd expect it's CODEC-agnostic. Maybe we could move CODEC-agnostic path to avoid duplicating the code? Does this change apply to the rkvdec driver? Thanks, Ezequiel ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8192u: minor coding style fix
On Thu, Feb 25, 2021 at 10:03:51AM +, Lee Gibson wrote:
> Fixes this checkpatch warning
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Lee Gibson
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
> b/drivers/staging/rtl8192u/r8192U_wx.c
> index d853586705fc..175bb8b15389 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -726,7 +726,7 @@ static int r8192_wx_set_enc_ext(struct net_device *dev,
> idx--;
> group = ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY;
>
> - if ((!group) || (IW_MODE_ADHOC == ieee->iw_mode) || (alg ==
> KEY_TYPE_WEP40)) {
> + if ((!group) || (ieee->iw_mode == IW_MODE_ADHOC) || (alg ==
> KEY_TYPE_WEP40)) {
> if ((ext->key_len == 13) && (alg == KEY_TYPE_WEP40))
> alg = KEY_TYPE_WEP104;
> ieee->pairwise_key_type = alg;
> --
> 2.25.1
Someone already sent this same fix in before you did, sorry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
