Re: [PATCH 1/8] phy: phy-hi3670-usb3: move driver from staging into phy
On 16-11-20, 13:59, Mauro Carvalho Chehab wrote:
> +#define CTRL7_USB2_REFCLKSEL_MASK(3 << 3)
> +#define CTRL7_USB2_REFCLKSEL_ABB (3 << 3)
> +#define CTRL7_USB2_REFCLKSEL_PAD (2 << 3)
This should use GENMASK()
> +
> +#define CFG50_USB3_PHY_TEST_POWERDOWNBIT(23)
> +
> +#define CFG54_USB31PHY_CR_ADDR_MASK (0x)
> +#define CFG54_USB31PHY_CR_ADDR_SHIFT (16)
We can skip this by using FIELD_GET/FIELD_SET macros and only define
register fields.
> +static int hi3670_phy_cr_start(struct regmap *usb31misc, int direction)
> +{
> + int ret;
> +
> + if (direction)
> + ret = regmap_update_bits(usb31misc, USB_MISC_CFG54,
> + CFG54_USB31PHY_CR_WR_EN,
> + CFG54_USB31PHY_CR_WR_EN);
> + else
> + ret = regmap_update_bits(usb31misc, USB_MISC_CFG54,
> + CFG54_USB31PHY_CR_RD_EN,
> + CFG54_USB31PHY_CR_RD_EN);
how about:
if direction
reg = CFG54_USB31PHY_CR_WR_EN;
else
reg = CFG54_USB31PHY_CR_RD_EN;
regmap_update_bits(usb31misc, USB_MISC_CFG54, reg, reg);
> +
> + if (ret)
> + return ret;
> +
> + ret = hi3670_phy_cr_clk(usb31misc);
> + if (ret)
> + return ret;
> +
> + ret = regmap_update_bits(usb31misc, USB_MISC_CFG54,
> + CFG54_USB31PHY_CR_RD_EN |
> CFG54_USB31PHY_CR_WR_EN, 0);
> +
> + return ret;
return regmap_update_bits()
> +static int hi3670_phy_cr_wait_ack(struct regmap *usb31misc)
> +{
> + u32 reg;
> + int retry = 10;
> + int ret;
> +
> + while (retry-- > 0) {
> + ret = regmap_read(usb31misc, USB_MISC_CFG54, ®);
> + if (ret)
> + return ret;
> + if ((reg & CFG54_USB31PHY_CR_ACK) == CFG54_USB31PHY_CR_ACK)
> + return 0;
> +
> + ret = hi3670_phy_cr_clk(usb31misc);
> + if (ret)
> + return ret;
No delay in between reads..? maybe add a small delay and reduce the
retries?
> +static int hi3670_phy_cr_set_addr(struct regmap *usb31misc, u32 addr)
> +{
> + u32 reg;
> + int ret;
> +
> + ret = regmap_read(usb31misc, USB_MISC_CFG54, ®);
> + if (ret)
> + return ret;
> +
> + reg &= ~(CFG54_USB31PHY_CR_ADDR_MASK << CFG54_USB31PHY_CR_ADDR_SHIFT);
> + reg |= ((addr & CFG54_USB31PHY_CR_ADDR_MASK) <<
> CFG54_USB31PHY_CR_ADDR_SHIFT);
> + ret = regmap_write(usb31misc, USB_MISC_CFG54, reg);
regmap_update_bits() ?
> +static int hi3670_is_abbclk_seleted(struct hi3670_priv *priv)
> +{
> + u32 reg;
> +
> + if (!priv->sctrl) {
> + dev_err(priv->dev, "priv->sctrl is null!\n");
> + return 1;
> + }
> +
> + if (regmap_read(priv->sctrl, SCTRL_SCDEEPSLEEPED, ®)) {
> + dev_err(priv->dev, "SCTRL_SCDEEPSLEEPED read failed!\n");
> + return 1;
Not a -ve error code?
--
~Vinod
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 0/4] MT7621 PCIe PHY
On 21-11-20, 16:50, Sergio Paracuellos wrote:
> This series adds support for the PCIe PHY found in the Mediatek
> MT7621 SoC.
>
> There is also a 'mt7621-pci' driver which is the controller part
> which is still in staging and is a client of this phy.
>
> Both drivers have been tested together in a gnubee1 board.
>
> This series are rebased on the top of linux-phy:
> commit 768a711e2d4b ("phy: samsung: phy-exynos-pcie: fix typo 'tunning'")
Applied, thanks
--
~Vinod
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY
On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote:
> > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32
> > > reg)
> > > +{
> > > + regmap_write(phy->regmap, reg, val);
> >
> > Why not use regmap_ calls directly and avoid the dummy wrappers..?
>
> This is because name was the dummy names are a bit shorter :) but if
> it is also necessary I will use directly regmap_ functions.
At least don't swap the last two arguments around.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang
On Wed, Nov 25, 2020 at 01:42:57PM +0900, Benjamin Poirier wrote: > On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva > > --- > > drivers/staging/qlge/qlge_main.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/qlge/qlge_main.c > > b/drivers/staging/qlge/qlge_main.c > > index 27da386f9d87..c41b1373dcf8 100644 > > --- a/drivers/staging/qlge/qlge_main.c > > +++ b/drivers/staging/qlge/qlge_main.c > > @@ -1385,6 +1385,7 @@ static void ql_categorize_rx_err(struct ql_adapter > > *qdev, u8 rx_err, > > break; > > case IB_MAC_IOCB_RSP_ERR_CRC: > > stats->rx_crc_err++; > > + break; > > default: > > break; > > } > > In this instance, it think it would be more appropriate to remove the > "default" case. There are checkers which complain about that. (As a static checker developer myself, I think complaining about missing default cases is a waste of everyone's time). regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 0/4] MT7621 PCIe PHY
Hi Vinod,
On Mon, Nov 30, 2020 at 11:48 AM Vinod Koul wrote:
>
> On 21-11-20, 16:50, Sergio Paracuellos wrote:
> > This series adds support for the PCIe PHY found in the Mediatek
> > MT7621 SoC.
> >
> > There is also a 'mt7621-pci' driver which is the controller part
> > which is still in staging and is a client of this phy.
> >
> > Both drivers have been tested together in a gnubee1 board.
> >
> > This series are rebased on the top of linux-phy:
> > commit 768a711e2d4b ("phy: samsung: phy-exynos-pcie: fix typo 'tunning'")
>
> Applied, thanks
Thanks for letting me know.
Best regards,
Sergio Paracuellos
>
> --
> ~Vinod
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY
Hi Dan,
On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter wrote:
>
> On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote:
> > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32
> > > > reg)
> > > > +{
> > > > + regmap_write(phy->regmap, reg, val);
> > >
> > > Why not use regmap_ calls directly and avoid the dummy wrappers..?
> >
> > This is because name was the dummy names are a bit shorter :) but if
> > it is also necessary I will use directly regmap_ functions.
>
> At least don't swap the last two arguments around.
You are right. I don't really know why I changed the order there but
those have been deleted in applied series.
>
> regards,
> dan carpenter
Best regards,
Sergio Paracuellos
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: (subset) [PATCH v6 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399
On Tue, 20 Oct 2020 16:38:41 -0300, Helen Koike wrote: > Move the bindings out of drivers/staging and place them in > Documentation/devicetree/bindings instead. > > Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check > and make ARCH=arm64 dt_binding_check. > > Tested by verifying images streamed from Scarlet Chromebook > > [...] Applied, thanks! [8/9] arm64: dts: rockchip: add isp0 node for rk3399 commit: 97a0115cd96a173369ef30eee2290184921b3f24 [9/9] arm64: dts: rockchip: add isp and sensors for Scarlet commit: ef098edc9c245dd1c150001e22c78e6a3ffd7ff8 Best regards, -- Heiko Stuebner ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:media:zoran: Fixed grammar issue
Removed repeated word 'in' Signed-off-by: Travis Carter --- drivers/staging/media/zoran/zoran_card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c index dfc60e2e9dd7..c77aa458b6d2 100644 --- a/drivers/staging/media/zoran/zoran_card.c +++ b/drivers/staging/media/zoran/zoran_card.c @@ -39,7 +39,7 @@ MODULE_PARM_DESC(card, "Card type"); /* * The video mem address of the video card. The driver has a little database for some videocards * to determine it from there. If your video card is not in there you have either to give it to - * the driver as a parameter or set in in a VIDIOCSFBUF ioctl + * the driver as a parameter or set in a VIDIOCSFBUF ioctl */ static unsigned long vidmem; /* default = 0 - Video memory base address */ -- 2.17.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 000/141] Fix fall-through warnings for Clang
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:media:zoran: Fixed grammar issue
On Mon, Nov 30, 2020 at 05:06:59PM -0600, Travis Carter wrote: > Removed repeated word 'in' > > Signed-off-by: Travis Carter > --- > drivers/staging/media/zoran/zoran_card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zoran_card.c > b/drivers/staging/media/zoran/zoran_card.c > index dfc60e2e9dd7..c77aa458b6d2 100644 > --- a/drivers/staging/media/zoran/zoran_card.c > +++ b/drivers/staging/media/zoran/zoran_card.c > @@ -39,7 +39,7 @@ MODULE_PARM_DESC(card, "Card type"); > /* > * The video mem address of the video card. The driver has a little database > for some videocards > * to determine it from there. If your video card is not in there you have > either to give it to > - * the driver as a parameter or set in in a VIDIOCSFBUF ioctl > + * the driver as a parameter or set in a VIDIOCSFBUF ioctl > */ > > static unsigned long vidmem; /* default = 0 - Video memory base address */ > -- > 2.17.1 > Hello Acked-by: Corentin Labbe Thanks ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
