Re: [PATCH v2] staging: rtl8192u: ieee80211: replace kmalloc/memset with kzalloc
On Fri, Oct 23, 2020 at 11:47:05AM -0700, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 63a561ab4a76..fb8483c499b3 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -227,13 +227,10 @@ static struct ieee80211_txb *ieee80211_alloc_txb(int
> nr_frags, int txb_size,
> {
> struct ieee80211_txb *txb;
> int i;
> - txb = kmalloc(
> - sizeof(struct ieee80211_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
Can you please use array_size() for this type of math to ensure that the
multiplication is safe?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: rtl8192e: replace kmalloc/memset with kzalloc
On Fri, Oct 23, 2020 at 12:01:47PM -0700, Elena Afanasova wrote: > Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too. > Found with Coccinelle. > > Signed-off-by: Elena Afanasova > --- > Changes in v2: > - correct the subject line > - correct the commit message > > drivers/staging/rtl8192e/rtllib_tx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c > b/drivers/staging/rtl8192e/rtllib_tx.c > index e0d79daca24a..c9959bb4ab63 100644 > --- a/drivers/staging/rtl8192e/rtllib_tx.c > +++ b/drivers/staging/rtl8192e/rtllib_tx.c > @@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int > nr_frags, int txb_size, > struct rtllib_txb *txb; > int i; > > - txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags), > - gfp_mask); > + txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask); Same here, please always use array_size() ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error
On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin
>
> Currently in case of alignment or FCS error if the packet cannot be
> corrected it's still not dropped. Report the error properly and drop the
> packet while making the code around a little bit more readable.
>
> Signed-off-by: Alexander Sverdlin
> Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.")
>
> Change-Id: Ie1fadcc57cb5e221cf3e83c169b53a5533b8edff
Please stop using gerrit for patches destined for upstream development
:(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Congratulation: You're a winner!
CONGRATULATION!!! With reference to the 1,350th EuroMillions draw which took place on Friday 28th August 2020 at 21:00 CEST (20:00 BST) and the winning numbers drawn were: Lucky numbers 7-12-16-17-31 Star Number 7-9 Millionaire Maker: MNHF52876 serial number MZNS47038 Prize credited to file EURO/86169/2020 An official letter was sent to your address. Your email address has been awarded the sum of Ј2,804,611.10 GB pounds. Kindly, confirm receipt of this notification by contacting your claims officer Mr. Kennith William on will...@zoho.com for more details. visit the link https://www.euro-millions.com/results/28-08-2020 to view your winning details as published on the Euro-Millions site. Euro-Millions prizes must be claimed within 180 days of the draw date. This is a confidential mail sent to ONLY winners of this draws. If you have any questions, please contact our customer support. Kind regards, Peter Jones Customer Support EURO-MILLIONS Customer Service UK Regional Office Acorns Oakwood Park Business Center Fountains Road Bishop Thornton, Harrogate HG3 3BF, UK. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] staging: rtl8192u: ieee80211: replace kmalloc/memset with kzalloc
Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
Found with Coccinelle.
Signed-off-by: Elena Afanasova
---
Changes in v3:
- use array_size()
Changes in v2:
- correct the subject line
- correct the commit message
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
index 63a561ab4a76..53ce97aae206 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
@@ -227,13 +227,10 @@ static struct ieee80211_txb *ieee80211_alloc_txb(int
nr_frags, int txb_size,
{
struct ieee80211_txb *txb;
int i;
- txb = kmalloc(
- sizeof(struct ieee80211_txb) + (sizeof(u8 *) * nr_frags),
- gfp_mask);
+ txb = kzalloc(sizeof(*txb) + array_size(sizeof(u8 *), nr_frags),
gfp_mask);
if (!txb)
return NULL;
- memset(txb, 0, sizeof(struct ieee80211_txb));
txb->nr_frags = nr_frags;
txb->frag_size = __cpu_to_le16(txb_size);
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH v3] staging: rtl8192u: ieee80211: replace kmalloc/memset with kzalloc
On Sun, 25 Oct 2020, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v3:
> - use array_size()
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 63a561ab4a76..53ce97aae206 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -227,13 +227,10 @@ static struct ieee80211_txb *ieee80211_alloc_txb(int
> nr_frags, int txb_size,
> {
> struct ieee80211_txb *txb;
> int i;
> - txb = kmalloc(
> - sizeof(struct ieee80211_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + array_size(sizeof(u8 *), nr_frags),
> gfp_mask);
There is no need to exceed 80 characters here.
julia
> if (!txb)
> return NULL;
>
> - memset(txb, 0, sizeof(struct ieee80211_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = __cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/43e637becf35f98a952c38ee1a5b690798c62c75.camel%40gmail.com.
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:debugfs_cleanup] BUILD SUCCESS 2a1ed3b223489bd154c7c2760c953f3299e8ff5e
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup branch HEAD: 2a1ed3b223489bd154c7c2760c953f3299e8ff5e debugfs: remove return value of debugfs_create_devm_seqfile() elapsed time: 720m configs tested: 90 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig arm lpc18xx_defconfig powerpc tqm5200_defconfig mips xway_defconfig mips bmips_be_defconfig sh sh2007_defconfig mips tb0219_defconfig powerpc walnut_defconfig mips db1xxx_defconfig mips ip28_defconfig m68kmvme16x_defconfig powerpcklondike_defconfig powerpc stx_gp3_defconfig sh se7206_defconfig sh se7722_defconfig csky alldefconfig sparc sparc32_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a001-20201025 x86_64 randconfig-a003-20201025 x86_64 randconfig-a002-20201025 x86_64 randconfig-a006-20201025 x86_64 randconfig-a005-20201025 x86_64 randconfig-a004-20201025 i386 randconfig-a002-20201025 i386 randconfig-a003-20201025 i386 randconfig-a005-20201025 i386 randconfig-a001-20201025 i386 randconfig-a006-20201025 i386 randconfig-a004-20201025 i386 randconfig-a016-20201025 i386 randconfig-a015-20201025 i386 randconfig-a014-20201025 i386 randconfig-a013-20201025 i386 randconfig-a012-20201025 i386 randconfig-a011-20201025 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a011-20201025 x86_64 randconfig-a013-20201025 x86_64 randconfig-a016-20201025 x86_64 randconfig-a015-20201025 x86_64 randconfig-a012-20201025 x86_64 randconfig-a014-20201025 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing] BUILD SUCCESS 119cf262a5235d9060c3f596c277c828533d18e6
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: 119cf262a5235d9060c3f596c277c828533d18e6 staging: r8188eu: inline rtw_init_netdev_name() elapsed time: 722m configs tested: 95 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc mpc834x_itx_defconfig arc haps_hs_defconfig shtitan_defconfig sparc64 defconfig arm spear13xx_defconfig sh sdk7780_defconfig mipsmaltaup_defconfig mipsjmr3927_defconfig s390 alldefconfig armmulti_v7_defconfig arm shannon_defconfig parisc alldefconfig arc axs103_smp_defconfig c6x defconfig mips ath25_defconfig powerpc pasemi_defconfig m68kq40_defconfig arm tct_hammer_defconfig c6x dsk6455_defconfig arm vf610m4_defconfig sh sh2007_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a001-20201025 x86_64 randconfig-a003-20201025 x86_64 randconfig-a002-20201025 x86_64 randconfig-a006-20201025 x86_64 randconfig-a005-20201025 x86_64 randconfig-a004-20201025 i386 randconfig-a002-20201025 i386 randconfig-a003-20201025 i386 randconfig-a005-20201025 i386 randconfig-a001-20201025 i386 randconfig-a006-20201025 i386 randconfig-a004-20201025 i386 randconfig-a016-20201025 i386 randconfig-a015-20201025 i386 randconfig-a014-20201025 i386 randconfig-a013-20201025 i386 randconfig-a012-20201025 i386 randconfig-a011-20201025 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a011-20201025 x86_64 randconfig-a013-20201025 x86_64 randconfig-a016-20201025 x86_64 randconfig-a015-20201025 x86_64 randconfig-a012-20201025 x86_64 randconfig-a014-20201025 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http
Re: [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns
On Wed, Oct 21, 2020 at 01:01:07PM +0530, Deepak R Varma wrote:
Hello,
Requesting a review / ack of this patch.
Thank you,
Deepak.
> Reformat lines that exceed 100 column in length. Issue reported by
> checkpatch script.
>
> Signed-off-by: Deepak R Varma
> ---
> Changes since v1:
>- No change in this patch.
>- Patch 2/2 has a change.
>
> drivers/staging/kpc2000/kpc_dma/dma.c | 27 +---
> drivers/staging/kpc2000/kpc_dma/fileops.c | 44 +++
> .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 9 ++--
> 3 files changed, 63 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/dma.c
> b/drivers/staging/kpc2000/kpc_dma/dma.c
> index 452a3f7c835d..b8d8294aa4c3 100644
> --- a/drivers/staging/kpc2000/kpc_dma/dma.c
> +++ b/drivers/staging/kpc2000/kpc_dma/dma.c
> @@ -16,7 +16,8 @@ irqreturn_t ndd_irq_handler(int irq, void *dev_id)
> {
> struct kpc_dma_device *ldev = (struct kpc_dma_device *)dev_id;
>
> - if ((GetEngineControl(ldev) & ENG_CTL_IRQ_ACTIVE) ||
> (ldev->desc_completed->MyDMAAddr != GetEngineCompletePtr(ldev)))
> + if ((GetEngineControl(ldev) & ENG_CTL_IRQ_ACTIVE) ||
> + (ldev->desc_completed->MyDMAAddr != GetEngineCompletePtr(ldev)))
> schedule_work(&ldev->irq_work);
>
> return IRQ_HANDLED;
> @@ -39,7 +40,9 @@ void ndd_irq_worker(struct work_struct *ws)
> cur = eng->desc_completed;
> do {
> cur = cur->Next;
> - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> (acd = %p)\n", cur, cur->acd);
> + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> (acd = %p)\n",
> + cur,
> + cur->acd);
> BUG_ON(cur == eng->desc_next); // Ordering failure.
>
> if (cur->DescControlFlags & DMA_DESC_CTL_SOP) {
> @@ -56,7 +59,9 @@ void ndd_irq_worker(struct work_struct *ws)
>
> if (cur->DescControlFlags & DMA_DESC_CTL_EOP) {
> if (cur->acd)
> - transfer_complete_cb(cur->acd,
> eng->accumulated_bytes, eng->accumulated_flags | ACD_FLAG_DONE);
> + transfer_complete_cb(cur->acd,
> + eng->accumulated_bytes,
> + eng->accumulated_flags |
> ACD_FLAG_DONE);
> }
>
> eng->desc_completed = cur;
> @@ -103,7 +108,10 @@ int setup_dma_engine(struct kpc_dma_device *eng, u32
> desc_cnt)
> eng->dir = DMA_TO_DEVICE;
>
> eng->desc_pool_cnt = desc_cnt;
> - eng->desc_pool = dma_pool_create("KPC DMA Descriptors",
> &eng->pldev->dev, sizeof(struct kpc_dma_descriptor), DMA_DESC_ALIGNMENT,
> 4096);
> + eng->desc_pool = dma_pool_create("KPC DMA Descriptors",
> + &eng->pldev->dev,
> + sizeof(struct kpc_dma_descriptor),
> + DMA_DESC_ALIGNMENT, 4096);
>
> eng->desc_pool_first = dma_pool_alloc(eng->desc_pool, GFP_KERNEL |
> GFP_DMA, &head_handle);
> if (!eng->desc_pool_first) {
> @@ -141,7 +149,11 @@ int setup_dma_engine(struct kpc_dma_device *eng, u32
> desc_cnt)
> INIT_WORK(&eng->irq_work, ndd_irq_worker);
>
> // Grab IRQ line
> - rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED,
> KP_DRIVER_NAME_DMA_CONTROLLER, eng);
> + rv = request_irq(eng->irq,
> + ndd_irq_handler,
> + IRQF_SHARED,
> + KP_DRIVER_NAME_DMA_CONTROLLER,
> + eng);
> if (rv) {
> dev_err(&eng->pldev->dev, "%s: failed to request_irq: %d\n",
> __func__, rv);
> return rv;
> @@ -195,7 +207,10 @@ void stop_dma_engine(struct kpc_dma_device *eng)
> }
>
> // Clear any persistent bits just to make sure there is no residue from
> the reset
> - SetClearEngineControl(eng, (ENG_CTL_IRQ_ACTIVE | ENG_CTL_DESC_COMPLETE
> | ENG_CTL_DESC_ALIGN_ERR | ENG_CTL_DESC_FETCH_ERR | ENG_CTL_SW_ABORT_ERR |
> ENG_CTL_DESC_CHAIN_END | ENG_CTL_DMA_WAITING_PERSIST), 0);
> + SetClearEngineControl(eng, (ENG_CTL_IRQ_ACTIVE | ENG_CTL_DESC_COMPLETE |
> + ENG_CTL_DESC_ALIGN_ERR |
> ENG_CTL_DESC_FETCH_ERR |
> + ENG_CTL_SW_ABORT_ERR |
> ENG_CTL_DESC_CHAIN_END |
> + ENG_CTL_DMA_WAITING_PERSIST), 0);
>
> // Reset performance counters
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c
> b/drivers/staging/kpc2000/kpc_dma/fileops.c
> index e1c7c04f16fe..b929987844ff 100644
> --- a/drivers/staging/kpc2000/kpc_dma/fileops.c
> +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
> @@ -76,7 +76,11 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
>
> // Lock the user buffer pages in memory, and
Re: [PATCH v2 2/2] staging: kpc2000: kpc_dma: rename show function per convention
On Wed, Oct 21, 2020 at 01:05:25PM +0530, Deepak R Varma wrote:
Hello,
Requesting a review / ack for this patch.
Thank you,
Deepak.
> Rename show_engine_regs show function to engine_regs_show as per the
> convention followed. The show function macro DEVICE_ATTR is replaced
> by DEVICE_ATTR_RO. Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma
> ---
> Changes since v1:
>- Replace DEVICE_ATTR by DEVICE_ATTR_RO as suggested by Greg.
>
> drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> index 7698e5ef2a7c..aa9f96793e59 100644
> --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> @@ -50,7 +50,7 @@ static void kpc_dma_del_device(struct kpc_dma_device *ldev)
> }
>
> /** SysFS Attributes **/
> -static ssize_t show_engine_regs(struct device *dev, struct device_attribute
> *attr, char *buf)
> +static ssize_t engine_regs_show(struct device *dev, struct device_attribute
> *attr, char *buf)
> {
> struct kpc_dma_device *ldev;
> struct platform_device *pldev = to_platform_device(dev);
> @@ -80,7 +80,7 @@ static ssize_t show_engine_regs(struct device *dev, struct
> device_attribute *at
> ldev->desc_completed
> );
> }
> -static DEVICE_ATTR(engine_regs, 0444, show_engine_regs, NULL);
> +static DEVICE_ATTR_RO(engine_regs);
>
> static const struct attribute *ndd_attr_list[] = {
> &dev_attr_engine_regs.attr,
> --
> 2.25.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] Re: [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns
On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote: > > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p > > (acd = %p)\n", cur, cur->acd); > > + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p > > (acd = %p)\n", > > + cur, > > + cur->acd); Why do you put 'cur' and 'cur->acd' on different lines? > > - rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, > > KP_DRIVER_NAME_DMA_CONTROLLER, eng); > > + rv = request_irq(eng->irq, > > +ndd_irq_handler, > > +IRQF_SHARED, > > +KP_DRIVER_NAME_DMA_CONTROLLER, > > +eng); Likewise. I'd do: rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, KP_DRIVER_NAME_DMA_CONTROLLER, eng); ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns
On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote: > On Wed, Oct 21, 2020 at 01:01:07PM +0530, Deepak R Varma wrote: > > Hello, > Requesting a review / ack of this patch. As I said in my previous email, to the outreachy list, if I have not applied something, it needs to be resent, if you still think it is needed. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
