[staging:staging-next] BUILD SUCCESS WITH WARNING 14442181d20490945f341644bb8257e334b01447
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: 14442181d20490945f341644bb8257e334b01447 staging: wfx: always enable FastPs in combo with new firmwares Warning in current branch: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:1722:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] Warning ids grouped by kconfigs: recent_errors `-- x86_64-allyesconfig `-- drivers-staging-vc04_services-vchiq-mmal-mmal-vchiq.c:warning:Variable-ret-is-reassigned-a-value-before-the-old-one-has-been-used.-redundantAssignment elapsed time: 3085m configs tested: 245 configs skipped: 34 arm defconfig arm allmodconfig arm allnoconfig arm allyesconfig arm64allyesconfig arm64 defconfig arm64allmodconfig arm64 allnoconfig arm aspeed_g4_defconfig m68k m5249evb_defconfig armmmp2_defconfig shshmin_defconfig powerpc pmac32_defconfig parisc allmodconfig sh defconfig arm moxart_defconfig armqcom_defconfig arm iop32x_defconfig mips ip28_defconfig powerpc pq2fads_defconfig arm at91_dt_defconfig sh cayman_defconfig m68k amcore_defconfig arc nps_defconfig armtrizeps4_defconfig microblazenommu_defconfig m68km5407c3_defconfig sh allmodconfig arm s5pv210_defconfig arm ezx_defconfig arm colibri_pxa270_defconfig h8300 h8s-sim_defconfig arcnsim_700_defconfig c6xevmc6472_defconfig m68km5272c3_defconfig arcnsimosci_defconfig mips malta_kvm_defconfig arm ep93xx_defconfig openrisc simple_smp_defconfig mips ip27_defconfig sh apsh4a3a_defconfig arc nsimosci_hs_smp_defconfig shtitan_defconfig powerpc skiroot_defconfig arm cm_x300_defconfig sh kfr2r09-romimage_defconfig mips tb0219_defconfig sh j2_defconfig arm lpd270_defconfig h8300 edosk2674_defconfig nios2 10m50_defconfig arm pxa3xx_defconfig arm imx_v6_v7_defconfig powerpc ppc6xx_defconfig mips ath25_defconfig ia64 allmodconfig arm assabet_defconfig xtensa defconfig arm jornada720_defconfig powerpc maple_defconfig mips pistachio_defconfig h8300 defconfig arm simpad_defconfig xtensa virt_defconfig sh landisk_defconfig m68kstmark2_defconfig sh se7780_defconfig arm efm32_defconfig sh alldefconfig powerpcmvme5100_defconfig mips rb532_defconfig xtensa iss_defconfig m68k m5475evb_defconfig armvexpress_defconfig arm lpc32xx_defconfig mips sb1250_swarm_defconfig powerpc mpc885_ads_defconfig arm milbeaut_m10v_defconfig shdreamcast_defconfig openriscor1ksim_defconfig m68k alldefconfig arc axs103_smp_defconfig ia64 tiger_defconfig arm vf610m4_defconfig mipsjmr3927_defconfig arm nhk8815_defconfig arm pxa_defconfig powerpc mgcoge_defconfig arm bcm2835_defconfig mipsmaltaup_defconfig m68kmac_defconfig sh magicpanelr2_defconfig arc tb10x_defconfig ia64
[PATCH v2 2/5] staging: rtl8712: Simplify expressions with boolean logic
Simplify some expressions by using boolean operations.
Signed-off-by: Mauro Dreissig
---
drivers/staging/rtl8712/hal_init.c | 4 ++--
drivers/staging/rtl8712/osdep_intf.h | 2 +-
drivers/staging/rtl8712/rtl8712_recv.c | 5 ++---
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 1f5ba9cbe951..d3fc6fa9a715 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -99,12 +99,12 @@ static void fill_fwpriv(struct _adapter *adapter, struct
fw_priv *fwpriv)
default:
fwpriv->rf_config = RTL8712_RFC_1T2R;
}
- fwpriv->mp_mode = (regpriv->mp_mode == 1) ? 1 : 0;
+ fwpriv->mp_mode = (regpriv->mp_mode == 1);
/* 0:off 1:on 2:auto */
fwpriv->vcs_type = regpriv->vrtl_carrier_sense;
fwpriv->vcs_mode = regpriv->vcs_type; /* 1:RTS/CTS 2:CTS to self */
/* default enable turbo_mode */
- fwpriv->turbo_mode = ((regpriv->wifi_test == 1) ? 0 : 1);
+ fwpriv->turbo_mode = (regpriv->wifi_test != 1);
fwpriv->low_power_mode = regpriv->low_power;
}
diff --git a/drivers/staging/rtl8712/osdep_intf.h
b/drivers/staging/rtl8712/osdep_intf.h
index 2cc25db1a91d..9e75116c987e 100644
--- a/drivers/staging/rtl8712/osdep_intf.h
+++ b/drivers/staging/rtl8712/osdep_intf.h
@@ -17,7 +17,7 @@
#include "osdep_service.h"
#include "drv_types.h"
-#define RND4(x)(((x >> 2) + (((x & 3) == 0) ? 0 : 1)) << 2)
+#define RND4(x)(((x >> 2) + ((x & 3) != 0)) << 2)
struct intf_priv {
u8 *intf_dev;
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/drivers/staging/rtl8712/rtl8712_recv.c
index c513cda2a49e..d83f421acfc1 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -143,9 +143,8 @@ static void update_recvframe_attrib_from_recvstat(struct
rx_pkt_attrib *pattrib,
/*TODO:
* Offset 0
*/
- pattrib->bdecrypted = ((le32_to_cpu(prxstat->rxdw0) & BIT(27)) >> 27)
-? 0 : 1;
- pattrib->crc_err = (le32_to_cpu(prxstat->rxdw0) & BIT(14)) >> 14;
+ pattrib->bdecrypted = (le32_to_cpu(prxstat->rxdw0) & BIT(27)) == 0;
+ pattrib->crc_err = (le32_to_cpu(prxstat->rxdw0) & BIT(14)) != 0;
/*Offset 4*/
/*Offset 8*/
/*Offset 12*/
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 4/5] staging: rtl8712: Remove variable 'raw' from rtl871x_open_fw()
Remove useless variable 'raw' from function rtl871x_open_fw()
making the code a bit easier to understand.
Signed-off-by: Mauro Dreissig
---
drivers/staging/rtl8712/hal_init.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index d53efdfc9bf0..d7b30152d409 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -67,15 +67,13 @@ MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
static u32 rtl871x_open_fw(struct _adapter *adapter, const u8 **mappedfw)
{
- const struct firmware **raw = &adapter->fw;
-
if (adapter->fw->size > 20) {
dev_err(&adapter->pnetdev->dev, "r8172u: Badfw->size of %d\n",
(int)adapter->fw->size);
return 0;
}
- *mappedfw = (*raw)->data;
- return (*raw)->size;
+ *mappedfw = adapter->fw->data;
+ return adapter->fw->size;
}
static void fill_fwpriv(struct _adapter *adapter, struct fw_priv *fwpriv)
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/5] staging: rtl8712: Use proper format in call to dev_err()
In the call to dev_err(), remove the cast of size_t to int
and change the format string accordingly.
As reported by the kernel test robot, the correct
format string for a size_t argument should be %zu.
Reported-by: kernel test robot
Signed-off-by: Mauro Dreissig
---
drivers/staging/rtl8712/hal_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index d7b30152d409..ed51023b85a0 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -68,8 +68,8 @@ MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
static u32 rtl871x_open_fw(struct _adapter *adapter, const u8 **mappedfw)
{
if (adapter->fw->size > 20) {
- dev_err(&adapter->pnetdev->dev, "r8172u: Badfw->size of %d\n",
- (int)adapter->fw->size);
+ dev_err(&adapter->pnetdev->dev, "r8712u: Bad fw->size of %zu\n",
+ adapter->fw->size);
return 0;
}
*mappedfw = adapter->fw->data;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/5] staging: rtl8712: Replace constant 49152 with expression 48 * 1024
This way we don't need the comment stating that 49152 equals 48k.
Signed-off-by: Mauro Dreissig
---
drivers/staging/rtl8712/hal_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 7293cdc3a43b..1f5ba9cbe951 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -27,7 +27,7 @@
#include "usb_osintf.h"
#define FWBUFF_ALIGN_SZ 512
-#define MAX_DUMP_FWSZ 49152 /*default = 49152 (48k)*/
+#define MAX_DUMP_FWSZ (48 * 1024)
static void rtl871x_load_fw_cb(const struct firmware *firmware, void *context)
{
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/5] Code simplifications
This series applies some code enhancements to rtl8712 staging driver. Fixed the last commit as reported by kernel test robot . Mauro Dreissig (5): staging: rtl8712: Replace constant 49152 with expression 48 * 1024 staging: rtl8712: Simplify expressions with boolean logic staging: rtl8712: Use ETH_ALEN instead of hardcoded value staging: rtl8712: Remove variable 'raw' from rtl871x_open_fw() staging: rtl8712: Use proper format in call to dev_err() drivers/staging/rtl8712/hal_init.c | 18 -- drivers/staging/rtl8712/osdep_intf.h | 2 +- drivers/staging/rtl8712/rtl8712_recv.c | 5 ++--- 3 files changed, 11 insertions(+), 14 deletions(-) -- 2.25.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/5] staging: rtl8712: Use ETH_ALEN instead of hardcoded value
Use macro ETH_ALEN which defines the number of octets in an ethernet address. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index d3fc6fa9a715..d53efdfc9bf0 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -343,7 +343,7 @@ uint rtl8712_hal_init(struct _adapter *padapter) /* Fix the RX FIFO issue(USB error) */ r8712_write8(padapter, 0x1025fe5C, r8712_read8(padapter, 0x1025fe5C) | BIT(7)); - for (i = 0; i < 6; i++) + for (i = 0; i < ETH_ALEN; i++) padapter->eeprompriv.mac_addr[i] = r8712_read8(padapter, MACID + i); return _SUCCESS; -- 2.25.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Annotate r8712_sitesurvey_cmd()
Add __must_hold() sparse annotation to r8712_sitesurvey_cmd(),
replacing the comments on top of the function.
Signed-off-by: Mauro Dreissig
---
drivers/staging/rtl8712/rtl871x_cmd.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c
b/drivers/staging/rtl8712/rtl871x_cmd.c
index 26b618008fcf..c7523072a660 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -168,14 +168,9 @@ void r8712_free_cmd_obj(struct cmd_obj *pcmd)
kfree(pcmd);
}
-/*
- * r8712_sitesurvey_cmd(~)
- * ### NOTE: ()
- * MUST TAKE CARE THAT BEFORE CALLING THIS FUNC,
- * YOU SHOULD HAVE LOCKED pmlmepriv->lock
- */
u8 r8712_sitesurvey_cmd(struct _adapter *padapter,
struct ndis_802_11_ssid *pssid)
+ __must_hold(&padapter->mlmepriv.lock)
{
struct cmd_obj *ph2c;
struct sitesurvey_parm *psurveyPara;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:driver-core-testing] BUILD SUCCESS 0a2fae2aea4a21b59d4a920b9765aaa696270b16
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: 0a2fae2aea4a21b59d4a920b9765aaa696270b16 lib: update DEBUG_SHIRQ docs to match reality elapsed time: 3722m configs tested: 222 configs skipped: 25 The following configs have been built successfully. More configs may be tested in the coming days. arm defconfig arm allyesconfig arm allmodconfig arm allnoconfig arm64allyesconfig arm64 defconfig arm64allmodconfig arm64 allnoconfig arm aspeed_g4_defconfig m68k m5249evb_defconfig armmmp2_defconfig shshmin_defconfig powerpc pmac32_defconfig parisc allmodconfig sh defconfig arm moxart_defconfig armqcom_defconfig arm iop32x_defconfig arm at91_dt_defconfig m68k amcore_defconfig arc nps_defconfig armtrizeps4_defconfig microblazenommu_defconfig m68km5407c3_defconfig sh allmodconfig arm s5pv210_defconfig arm ezx_defconfig arm colibri_pxa270_defconfig h8300 h8s-sim_defconfig arcnsim_700_defconfig c6xevmc6472_defconfig m68km5272c3_defconfig arcnsimosci_defconfig powerpc pq2fads_defconfig mips malta_kvm_defconfig arm ep93xx_defconfig openrisc simple_smp_defconfig arm assabet_defconfig powerpc ppc40x_defconfig arm cm_x300_defconfig sh kfr2r09-romimage_defconfig mips tb0219_defconfig sh j2_defconfig arm lpd270_defconfig arm pxa3xx_defconfig arm imx_v6_v7_defconfig powerpc ppc6xx_defconfig mips ath25_defconfig powerpc maple_defconfig mips pistachio_defconfig h8300 defconfig arm simpad_defconfig xtensa virt_defconfig sh landisk_defconfig m68kstmark2_defconfig sh se7780_defconfig arm efm32_defconfig sh alldefconfig powerpcmvme5100_defconfig mips rb532_defconfig xtensa iss_defconfig powerpc mpc885_ads_defconfig arm milbeaut_m10v_defconfig shdreamcast_defconfig openriscor1ksim_defconfig m68k alldefconfig arc axs103_smp_defconfig ia64 tiger_defconfig arm vf610m4_defconfig arm pxa_defconfig powerpc mgcoge_defconfig arm bcm2835_defconfig mipsmaltaup_defconfig m68kmac_defconfig sh magicpanelr2_defconfig sh apsh4a3a_defconfig arc tb10x_defconfig ia64 bigsur_defconfig powerpc mpc5200_defconfig s390 debug_defconfig ia64defconfig s390 alldefconfig sh se7705_defconfig arcvdk_hs38_defconfig parisc alldefconfig arm imote2_defconfig nios2 defconfig armclps711x_defconfig xtensaxip_kc705_defconfig sparcalldefconfig arm viper_defconfig arm orion5x_defconfig m68k multi_defconfig arm imx_v4_v5_defconfig arm rpc_defconfig arm mv78xx0_defconfig s390defconfig sh cayman_defconfig arm socfpga_defconfig mipse55_defconfig powerpc
