Re: [PATCH 50/50] staging: vchiq: Move vchiq.h into include directory
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/Makefile > b/drivers/staging/vc04_services/vchiq-mmal/Makefile > index f8164c33aec3..b2a830f48acc 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/Makefile > +++ b/drivers/staging/vc04_services/vchiq-mmal/Makefile > @@ -5,4 +5,5 @@ obj-$(CONFIG_BCM2835_VCHIQ_MMAL) += bcm2835-mmal-vchiq.o > > ccflags-y += \ > -I$(srctree)/$(src)/.. \ > + -I$(srctree)/$(src)/../include \ > -D__VCCOREVER__=0x0400 > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > index 72afa4319bd3..b99b7555a8fb 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > @@ -23,14 +23,14 @@ > #include > #include > #include > +#include > #include > +#include Just realised that there an include too many here... Regards, Nicolas signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] staging: vc04_services: vchiq_arm: replace bitshift with BIT macro
On Wed, Jun 24, 2020 at 08:20:34PM +0200, Garrit Franke wrote: > This should prevent possible overflowing bits by using the BIT macro in > vchiq_core > There are no "overflowing bits". Fold both patches together. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] trivial: staging: vc04_services: replace bitshift with BIT macro
Cleans up some bitshifts by using the BIT macro.
Signed-off-by: Garrit Franke
---
.../interface/vchiq_arm/vchiq_core.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index ae9183db44ee..e0027148963e 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -39,9 +39,9 @@ struct vchiq_openack_payload {
};
enum {
- QMFLAGS_IS_BLOCKING = (1 << 0),
- QMFLAGS_NO_MUTEX_LOCK = (1 << 1),
- QMFLAGS_NO_MUTEX_UNLOCK = (1 << 2)
+ QMFLAGS_IS_BLOCKING = BIT(0),
+ QMFLAGS_NO_MUTEX_LOCK = BIT(1),
+ QMFLAGS_NO_MUTEX_UNLOCK = BIT(2)
};
/* we require this for consistency between endpoints */
@@ -526,14 +526,14 @@ request_poll(struct vchiq_state *state, struct
vchiq_service *service,
do {
value = atomic_read(&service->poll_flags);
} while (atomic_cmpxchg(&service->poll_flags, value,
- value | (1 << poll_type)) != value);
+ value | BIT(poll_type)) != value);
do {
value = atomic_read(&state->poll_services[
service->localport>>5]);
} while (atomic_cmpxchg(
&state->poll_services[service->localport>>5],
- value, value | (1 << (service->localport & 0x1f)))
+ value, value | BIT(service->localport & 0x1f))
!= value);
}
@@ -1287,19 +1287,19 @@ poll_services(struct vchiq_state *state)
flags = atomic_xchg(&state->poll_services[group], 0);
for (i = 0; flags; i++) {
- if (flags & (1 << i)) {
+ if (flags & BIT(i)) {
struct vchiq_service *service =
find_service_by_port(state,
(group<<5) + i);
u32 service_flags;
- flags &= ~(1 << i);
+ flags &= ~BIT(i);
if (!service)
continue;
service_flags =
atomic_xchg(&service->poll_flags, 0);
if (service_flags &
- (1 << VCHIQ_POLL_REMOVE)) {
+ BIT(VCHIQ_POLL_REMOVE)) {
vchiq_log_info(vchiq_core_log_level,
"%d: ps - remove %d<->%d",
state->id, service->localport,
@@ -1317,7 +1317,7 @@ poll_services(struct vchiq_state *state)
request_poll(state, service,
VCHIQ_POLL_REMOVE);
} else if (service_flags &
- (1 << VCHIQ_POLL_TERMINATE)) {
+ BIT(VCHIQ_POLL_TERMINATE)) {
vchiq_log_info(vchiq_core_log_level,
"%d: ps - terminate %d<->%d",
state->id, service->localport,
@@ -1328,11 +1328,11 @@ poll_services(struct vchiq_state *state)
request_poll(state, service,
VCHIQ_POLL_TERMINATE);
}
- if (service_flags & (1 << VCHIQ_POLL_TXNOTIFY))
+ if (service_flags & BIT(VCHIQ_POLL_TXNOTIFY))
notify_bulks(service,
&service->bulk_tx,
1/*retry_poll*/);
- if (service_flags & (1 << VCHIQ_POLL_RXNOTIFY))
+ if (service_flags & BIT(VCHIQ_POLL_RXNOTIFY))
notify_bulks(service,
&service->bulk_rx,
1/*retry_poll*/);
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] trivial: staging: vc04_services: replace bitshift with BIT macro
On Thu, Jun 25, 2020 at 11:32:37AM +0200, Garrit Franke wrote: > Cleans up some bitshifts by using the BIT macro. > > Signed-off-by: Garrit Franke Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: gasket: Convert symbolic permission to octal
Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
Consider using octal permissions '0444'.
Signed-off-by: Brooke Basile
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h
b/drivers/staging/gasket/gasket_sysfs.h
index ab5aa351d555..eb0fd3b0490f 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
\
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: gasket: Convert symbolic permission to octal
On Thu, Jun 25, 2020 at 09:25:13AM -0400, Brooke Basile wrote:
> Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
>
> Signed-off-by: Brooke Basile
> ---
> drivers/staging/gasket/gasket_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h
> b/drivers/staging/gasket/gasket_sysfs.h
> index ab5aa351d555..eb0fd3b0490f 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
> .data.attr_type = _attr_type \
> }
Someone else sent this a few days before you did:
https://lore.kernel.org/r/20200622073612.12282-1-rodolfovillo...@gmail.com
sorry,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: nvec: changed coding style, line should not end with a (
Signed-off-by: B K Karthik
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..16afbe1dfdeb 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -382,8 +382,8 @@ static void nvec_request_master(struct work_struct *work)
msg = list_first_entry(&nvec->tx_data, struct nvec_msg, node);
spin_unlock_irqrestore(&nvec->tx_lock, flags);
nvec_gpio_set_value(nvec, 0);
- err = wait_for_completion_interruptible_timeout(
- &nvec->ec_transfer, msecs_to_jiffies(5000));
+ err =
wait_for_completion_interruptible_timeout(&nvec->ec_transfer,
+ msecs_to_jiffies(5000));
if (err == 0) {
dev_warn(nvec->dev, "timeout waiting for ec
transfer\n");
--
2.20.1
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: nvec: changed coding style, line should not end with a (
On Thu, Jun 25, 2020 at 09:50:51AM -0400, B K Karthik wrote:
> Signed-off-by: B K Karthik
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..16afbe1dfdeb 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -382,8 +382,8 @@ static void nvec_request_master(struct work_struct *work)
> msg = list_first_entry(&nvec->tx_data, struct nvec_msg, node);
> spin_unlock_irqrestore(&nvec->tx_lock, flags);
> nvec_gpio_set_value(nvec, 0);
> - err = wait_for_completion_interruptible_timeout(
> - &nvec->ec_transfer, msecs_to_jiffies(5000));
> + err =
> wait_for_completion_interruptible_timeout(&nvec->ec_transfer,
> + msecs_to_jiffies(5000));
>
> if (err == 0) {
> dev_warn(nvec->dev, "timeout waiting for ec
> transfer\n");
> --
> 2.20.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 2/2] staging: vc04_services: vchiq_arm: Remove unnecessary parens
On Wed, Jun 24, 2020 at 08:20:35PM +0200, Garrit Franke wrote: > Signed-off-by: Garrit Franke > > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 5a6d2bd59ec0..e0027148963e 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -533,7 +533,7 @@ request_poll(struct vchiq_state *state, struct > vchiq_service *service, > service->localport>>5]); > } while (atomic_cmpxchg( > &state->poll_services[service->localport>>5], > - value, value | BIT((service->localport & 0x1f))) > + value, value | BIT(service->localport & 0x1f)) > != value); > } > > -- > 2.25.1 > > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/50] staging: vchiq: Getting rid of the vchi/vchiq split
On Tue, Jun 23, 2020 at 06:41:46PM +0200, Nicolas Saenz Julienne wrote: > vchi acts as a mid layer between vchiq and its kernel services, while > arguably providing little to no benefit: half of the functions exposed > are a 1:1 copy of vchiq's, and the rest provide some functionality which > can be easly integrated into vchiq without all the churn. Moreover it > has been found in the past as a blockage to further fixes in vchiq as > every change needed its vchi counterpart, if even possible. > > Hence this series, which merges all vchi functionality into vchiq and > provies a simpler and more concise API to services. > > I'm aware that kernel's vchi API tries to mimic its userspace > counterpart (or vice versa). Obviously this breaks the parity, but I > don't think it's a sane goal to have. There is little sense or gain from > it, and adds impossible constraints to upstreaming the driver. > > Overall this fall short of removing 1100 lines of code, which is pretty > neat on itself. > > So far it has been tested trough bcm2835-camera, audio and vchiq-test. I > can't do much about vc-sm-cma for now as it's only available downstream, > but I made sure not to break anything and will provide some patches for > the RPi devs to pick-up, so as to make their life easier. > > Note that in order to keep the divergence between the downstream and > upstream versions of this as small as possible I picked up some > mmal-vchiq patches that might not be absolutely necessary to the goal of > the series. I took the first 2 patches and will wait for the rest to be resent :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/2] Coding style fix for the qlge driver
These two patches fix two coding style problems for all files under drivers/staging/qlge as reported by checkpatch.pl, - trailing */ in block comment - unnecessary else after return or break Coiby Xu (2): fix trailing */ in block comment fix else after return or break drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 11 ++- drivers/staging/qlge/qlge_mpi.c | 14 -- 3 files changed, 24 insertions(+), 24 deletions(-) -- 2.27.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] fix else after return or break
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 058889687907..87433510a224 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of mac index register\n",
__func__);
return;
- } else {
- if (value[0])
- pr_err("%s: CAM index %d CAM Lookup Lower =
0x%.08x:%.08x, Output = 0x%.08x\n",
- qdev->ndev->name, i, value[1], value[0],
- value[2]);
}
+ if (value[0])
+ pr_err("%s: CAM index %d CAM Lookup Lower =
0x%.08x:%.08x, Output = 0x%.08x\n",
+ qdev->ndev->name, i, value[1], value[0],
+ value[2]);
}
for (i = 0; i < 32; i++) {
if (ql_get_mac_addr_reg
@@ -1404,11 +1403,10 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of mac index register\n",
__func__);
return;
- } else {
- if (value[0])
- pr_err("%s: MCAST index %d CAM Lookup Lower =
0x%.08x:%.08x\n",
- qdev->ndev->name, i, value[1], value[0]);
}
+ if (value[0])
+ pr_err("%s: MCAST index %d CAM Lookup Lower =
0x%.08x:%.08x\n",
+ qdev->ndev->name, i, value[1], value[0]);
}
ql_sem_unlock(qdev, SEM_MAC_ADDR_MASK);
}
@@ -1427,11 +1425,10 @@ void ql_dump_routing_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of routing index register\n",
__func__);
return;
- } else {
- if (value)
- pr_err("%s: Routing Mask %d = 0x%.08x\n",
- qdev->ndev->name, i, value);
}
+ if (value)
+ pr_err("%s: Routing Mask %d = 0x%.08x\n",
+ qdev->ndev->name, i, value);
}
ql_sem_unlock(qdev, SEM_RT_IDX_MASK);
}
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index aaecf2b0f9a1..0054c454506b 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3778,10 +3778,10 @@ static int ql_wol(struct ql_adapter *qdev)
"Failed to set magic packet on %s.\n",
qdev->ndev->name);
return status;
- } else
- netif_info(qdev, drv, qdev->ndev,
- "Enabled magic packet successfully on %s.\n",
- qdev->ndev->name);
+ }
+ netif_info(qdev, drv, qdev->ndev,
+ "Enabled magic packet successfully on %s.\n",
+ qdev->ndev->name);
wol |= MB_WOL_MAGIC_PKT;
}
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 3bb08d290525..fa178fc642a6 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -276,8 +276,8 @@ static void ql_link_up(struct ql_adapter *qdev, struct
mbox_params *mbcp)
netif_err(qdev, ifup, qdev->ndev,
"Failed to init CAM/Routing tables.\n");
return;
- } else
- clear_bit(QL_CAM_RT_SET, &qdev->flags);
+ }
+ clear_bit(QL_CAM_RT_SET, &qdev->flags);
}
/* Queue up a worker to check the frame
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] fix trailing */ in block comment
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1650de13842f..aaecf2b0f9a1 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3244,7 +3244,8 @@ static void ql_set_irq_mask(struct ql_adapter *qdev,
struct intr_context *ctx)
*/
ctx->irq_mask = (1 << qdev->rx_ring[vect].cq_id);
/* Add the TX ring(s) serviced by this vector
-* to the mask. */
+* to the mask.
+*/
for (j = 0; j < tx_rings_per_vector; j++) {
ctx->irq_mask |=
(1 << qdev->rx_ring[qdev->rss_ring_count +
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9cc034..3bb08d290525 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -389,7 +389,8 @@ static void ql_init_fw_done(struct ql_adapter *qdev, struct
mbox_params *mbcp)
* This can get called iteratively from the mpi_work thread
* when events arrive via an interrupt.
* It also gets called when a mailbox command is polling for
- * it's completion. */
+ * it's completion.
+ */
static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
{
int status;
@@ -520,7 +521,7 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct
mbox_params *mbcp)
* changed when a mailbox command is waiting
* for a response and an AEN arrives and
* is handled.
-* */
+*/
mbcp->out_count = orig_count;
return status;
}
@@ -555,7 +556,8 @@ static int ql_mailbox_command(struct ql_adapter *qdev,
struct mbox_params *mbcp)
* here because some AEN might arrive while
* we're waiting for the mailbox command to
* complete. If more than 5 seconds expire we can
-* assume something is wrong. */
+* assume something is wrong.
+*/
count = jiffies + HZ * MAILBOX_TIMEOUT;
do {
/* Wait for the interrupt to come in. */
@@ -1178,7 +1180,7 @@ void ql_mpi_idc_work(struct work_struct *work)
/* Signal the resulting link up AEN
* that the frame routing and mac addr
* needs to be set.
-* */
+*/
set_bit(QL_CAM_RT_SET, &qdev->flags);
/* Do ACK if required */
if (timeout) {
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Macros with complex values should be enclosed in parentheses" in line 241 by
adding parentheses.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Alignment should match open parenthesis" by adding tab spaces in line 410.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"return of an errno should typically be negative" by adding a "-" in front of
EPOLLER in line 812.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Alignment should match open parenthesis" by adding tab spaces in line 1270.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.c
b/drivers/staging/media/soc_camera/soc_camera.c
index 39f513f69b89..66a14ebd8093 100644
--- a/drivers/staging/media/soc_camera/soc_camera.c
+++ b/drivers/staging/media/soc_camera/soc_camera.c
@@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct
soc_camera_subdev_desc *ssdd,
}
EXPORT_SYMBOL(soc_camera_apply_board_flags);
-#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
- ((x) >> 24) & 0xff
+#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
+ ((x) >> 24) & 0xff)
static int soc_camera_try_fmt(struct soc_camera_device *icd,
struct v4l2_format *f)
@@ -407,7 +407,7 @@ static int soc_camera_dqbuf(struct file *file, void *priv,
}
static int soc_camera_create_bufs(struct file *file, void *priv,
- struct v4l2_create_buffers *create)
+ struct v4l2_create_buffers *create)
{
struct soc_camera_device *icd = file->private_data;
int ret;
@@ -806,10 +806,10 @@ static __poll_t soc_camera_poll(struct file *file,
poll_table *pt)
{
struct soc_camera_device *icd = file->private_data;
struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
- __poll_t res = EPOLLERR;
+ __poll_t res = -EPOLLERR;
if (icd->streamer != file)
- return EPOLLERR;
+ return -EPOLLERR;
mutex_lock(&ici->host_lock);
res = ici->ops->poll(file, pt);
@@ -1267,7 +1267,7 @@ static int soc_camera_i2c_init(struct soc_camera_device
*icd,
}
subdev = v4l2_i2c_new_subdev_board(&ici->v4l2_dev, adap,
- shd->board_info, NULL);
+ shd->board_info, NULL);
if (!subdev) {
ret = -ENODEV;
goto ei2cnd;
--
2.20.1
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] wilc1000: move wilc driver out of staging
From: Ajay Singh
WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The
WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other
processors with minimal resource requirements with a simple
SPI/SDIO-to-Wi-Fi interface.
WILC1000 driver has been part of staging for few years. With
contributions from the community, it has improved significantly. Full
driver review has helped in achieving the current state.
The details for those reviews are captured in 1 & 2.
[1].
https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kat...@microchip.com/
[2].
https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kat...@microchip.com/
Signed-off-by: Ajay Singh
---
As suggested, keeping all the changes in single commit with file rename
so it's easy to move out of staging [3].
Please choose whichever option you prefer between the git mv or patch series
sent last Tuesday. The resulting driver is the same as no patch has been
queued in between.
[3].
https://lore.kernel.org/linux-wireless/2020062311.31559-1-ajay.kat...@microchip.com/
.../net/wireless}/microchip,wilc1000.yaml | 0
MAINTAINERS | 14 +++---
drivers/net/wireless/Kconfig | 1 +
drivers/net/wireless/Makefile | 1 +
drivers/net/wireless/microchip/Kconfig| 15 +++
drivers/net/wireless/microchip/Makefile | 2 ++
.../wireless/microchip}/wilc1000/Kconfig | 0
.../wireless/microchip}/wilc1000/Makefile | 0
.../wireless/microchip}/wilc1000/cfg80211.c | 0
.../wireless/microchip}/wilc1000/cfg80211.h | 0
.../wireless/microchip}/wilc1000/fw.h | 0
.../wireless/microchip}/wilc1000/hif.c| 0
.../wireless/microchip}/wilc1000/hif.h| 0
.../wireless/microchip}/wilc1000/mon.c| 0
.../wireless/microchip}/wilc1000/netdev.c | 0
.../wireless/microchip}/wilc1000/netdev.h | 0
.../wireless/microchip}/wilc1000/sdio.c | 0
.../wireless/microchip}/wilc1000/spi.c| 0
.../wireless/microchip}/wilc1000/wlan.c | 0
.../wireless/microchip}/wilc1000/wlan.h | 0
.../wireless/microchip}/wilc1000/wlan_cfg.c | 0
.../wireless/microchip}/wilc1000/wlan_cfg.h | 0
.../wireless/microchip}/wilc1000/wlan_if.h| 0
drivers/staging/Kconfig | 2 --
drivers/staging/Makefile | 1 -
25 files changed, 26 insertions(+), 10 deletions(-)
rename {drivers/staging/wilc1000 =>
Documentation/devicetree/bindings/net/wireless}/microchip,wilc1000.yaml (100%)
create mode 100644 drivers/net/wireless/microchip/Kconfig
create mode 100644 drivers/net/wireless/microchip/Makefile
rename drivers/{staging => net/wireless/microchip}/wilc1000/Kconfig (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/Makefile (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/cfg80211.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/cfg80211.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/fw.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/hif.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/hif.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/mon.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/netdev.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/netdev.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/sdio.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/spi.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/wlan.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/wlan.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/wlan_cfg.c (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/wlan_cfg.h (100%)
rename drivers/{staging => net/wireless/microchip}/wilc1000/wlan_if.h (100%)
diff --git a/drivers/staging/wilc1000/microchip,wilc1000.yaml
b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
similarity index 100%
rename from drivers/staging/wilc1000/microchip,wilc1000.yaml
rename to Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
diff --git a/MAINTAINERS b/MAINTAINERS
index 68f21d46614c..7dae51e32254 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11362,6 +11362,13 @@ L: linux-arm-ker...@lists.infradead.org (moderated
for non-subscribers)
S: Supported
F: drivers/usb/gadget/udc/atmel_usba_udc.*
+MICROCHIP WILC1000 WIFI DRIVER
+M: Adham Abozaeid
+M: Ajay Singh
+L: linux-wirel...@vger.kernel.org
+S: Supported
+F: drivers/net/wireless/microchip/wilc1000/
+
MICROCHIP XDMA DRIVER
M: Ludovic Desroches
L: linux-arm-ker...@lists.infradead.or
Re: [PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR
On Thu, Jun 25, 2020 at 11:35:17AM -0400, B K Karthik wrote: > staging: media: soc_camera: soc_camera.c: Clearing coding-style problem > "Macros with complex values should be enclosed in parentheses" in line 241 by > adding parentheses. > staging: media: soc_camera: soc_camera.c: Clearing coding-style problem > "Alignment should match open parenthesis" by adding tab spaces in line 410. > staging: media: soc_camera: soc_camera.c: Clearing coding-style problem > "return of an errno should typically be negative" by adding a "-" in front of > EPOLLER in line 812. > staging: media: soc_camera: soc_camera.c: Clearing coding-style problem > "Alignment should match open parenthesis" by adding tab spaces in line 1270. > > Signed-off-by: B K Karthik > --- > drivers/staging/media/soc_camera/soc_camera.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] fix else after return or break
On Thu, Jun 25, 2020 at 11:36:14PM +0800, Coiby Xu wrote: > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/qlge_dbg.c | 23 ++- > drivers/staging/qlge/qlge_main.c | 8 > drivers/staging/qlge/qlge_mpi.c | 4 ++-- > 3 files changed, 16 insertions(+), 19 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] fix trailing */ in block comment
On Thu, Jun 25, 2020 at 11:36:13PM +0800, Coiby Xu wrote: > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/qlge_main.c | 3 ++- > drivers/staging/qlge/qlge_mpi.c | 10 ++ > 2 files changed, 8 insertions(+), 5 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] fix trailing */ in block comment
The subject isn't right (no subsystem prefix) and we need a commit message. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/2] staging: qlge: coding style fix for the qlge driver
These two patches fix two coding style problems for all files under drivers/staging/qlge as reported by checkpatch.pl, - trailing */ in block comment - unnecessary else after return or break Coiby Xu (2): fix trailing */ in block comment fix else after return or break drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 11 ++- drivers/staging/qlge/qlge_mpi.c | 14 -- 3 files changed, 24 insertions(+), 24 deletions(-) -- 2.27.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] staging: qlge: fix else after return or break
Remove unnecessary elses after return or break.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 058889687907..87433510a224 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of mac index register\n",
__func__);
return;
- } else {
- if (value[0])
- pr_err("%s: CAM index %d CAM Lookup Lower =
0x%.08x:%.08x, Output = 0x%.08x\n",
- qdev->ndev->name, i, value[1], value[0],
- value[2]);
}
+ if (value[0])
+ pr_err("%s: CAM index %d CAM Lookup Lower =
0x%.08x:%.08x, Output = 0x%.08x\n",
+ qdev->ndev->name, i, value[1], value[0],
+ value[2]);
}
for (i = 0; i < 32; i++) {
if (ql_get_mac_addr_reg
@@ -1404,11 +1403,10 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of mac index register\n",
__func__);
return;
- } else {
- if (value[0])
- pr_err("%s: MCAST index %d CAM Lookup Lower =
0x%.08x:%.08x\n",
- qdev->ndev->name, i, value[1], value[0]);
}
+ if (value[0])
+ pr_err("%s: MCAST index %d CAM Lookup Lower =
0x%.08x:%.08x\n",
+ qdev->ndev->name, i, value[1], value[0]);
}
ql_sem_unlock(qdev, SEM_MAC_ADDR_MASK);
}
@@ -1427,11 +1425,10 @@ void ql_dump_routing_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of routing index register\n",
__func__);
return;
- } else {
- if (value)
- pr_err("%s: Routing Mask %d = 0x%.08x\n",
- qdev->ndev->name, i, value);
}
+ if (value)
+ pr_err("%s: Routing Mask %d = 0x%.08x\n",
+ qdev->ndev->name, i, value);
}
ql_sem_unlock(qdev, SEM_RT_IDX_MASK);
}
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index aaecf2b0f9a1..0054c454506b 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3778,10 +3778,10 @@ static int ql_wol(struct ql_adapter *qdev)
"Failed to set magic packet on %s.\n",
qdev->ndev->name);
return status;
- } else
- netif_info(qdev, drv, qdev->ndev,
- "Enabled magic packet successfully on %s.\n",
- qdev->ndev->name);
+ }
+ netif_info(qdev, drv, qdev->ndev,
+ "Enabled magic packet successfully on %s.\n",
+ qdev->ndev->name);
wol |= MB_WOL_MAGIC_PKT;
}
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 3bb08d290525..fa178fc642a6 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -276,8 +276,8 @@ static void ql_link_up(struct ql_adapter *qdev, struct
mbox_params *mbcp)
netif_err(qdev, ifup, qdev->ndev,
"Failed to init CAM/Routing tables.\n");
return;
- } else
- clear_bit(QL_CAM_RT_SET, &qdev->flags);
+ }
+ clear_bit(QL_CAM_RT_SET, &qdev->flags);
}
/* Queue up a worker to check the frame
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] staging: qlge: fix trailing */ in block comment
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1650de13842f..aaecf2b0f9a1 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3244,7 +3244,8 @@ static void ql_set_irq_mask(struct ql_adapter *qdev,
struct intr_context *ctx)
*/
ctx->irq_mask = (1 << qdev->rx_ring[vect].cq_id);
/* Add the TX ring(s) serviced by this vector
-* to the mask. */
+* to the mask.
+*/
for (j = 0; j < tx_rings_per_vector; j++) {
ctx->irq_mask |=
(1 << qdev->rx_ring[qdev->rss_ring_count +
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9cc034..3bb08d290525 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -389,7 +389,8 @@ static void ql_init_fw_done(struct ql_adapter *qdev, struct
mbox_params *mbcp)
* This can get called iteratively from the mpi_work thread
* when events arrive via an interrupt.
* It also gets called when a mailbox command is polling for
- * it's completion. */
+ * it's completion.
+ */
static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
{
int status;
@@ -520,7 +521,7 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct
mbox_params *mbcp)
* changed when a mailbox command is waiting
* for a response and an AEN arrives and
* is handled.
-* */
+*/
mbcp->out_count = orig_count;
return status;
}
@@ -555,7 +556,8 @@ static int ql_mailbox_command(struct ql_adapter *qdev,
struct mbox_params *mbcp)
* here because some AEN might arrive while
* we're waiting for the mailbox command to
* complete. If more than 5 seconds expire we can
-* assume something is wrong. */
+* assume something is wrong.
+*/
count = jiffies + HZ * MAILBOX_TIMEOUT;
do {
/* Wait for the interrupt to come in. */
@@ -1178,7 +1180,7 @@ void ql_mpi_idc_work(struct work_struct *work)
/* Signal the resulting link up AEN
* that the frame routing and mac addr
* needs to be set.
-* */
+*/
set_bit(QL_CAM_RT_SET, &qdev->flags);
/* Do ACK if required */
if (timeout) {
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] fix trailing */ in block comment
On Thu, Jun 25, 2020 at 08:25:10PM +0300, Dan Carpenter wrote: The subject isn't right (no subsystem prefix) and we need a commit message. regards, dan carpenter Thank you for pointing out the exact problems! -- Best regards, Coiby ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: qlge: fix else after return or break
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
> Remove unnecessary elses after return or break.
unrelated trivia:
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
[]
> @@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter
> *qdev)
> pr_err("%s: Failed read of mac index register\n",
> __func__);
> return;
> - } else {
> - if (value[0])
> - pr_err("%s: CAM index %d CAM Lookup Lower =
> 0x%.08x:%.08x, Output = 0x%.08x\n",
> -qdev->ndev->name, i, value[1], value[0],
> -value[2]);
looks like all of these could use netdev_err
netdev_err(qdev, "etc...",
i, value[1], value[0], value[2]);
etc...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/4] Tegra Video Decoder driver power management corrections
24.06.2020 18:23, Dmitry Osipenko пишет: > 24.06.2020 18:16, Hans Verkuil пишет: >> On 24/06/2020 17:08, Dmitry Osipenko wrote: >>> Hello, >>> >>> This small series addresses a Runtime PM issue that was discovered during >>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume >>> failure. Secondly it fixes reboot on some Tegra devices due to bootloader >>> expecting VDE power partition to be ON at the boot time, which wasn't >>> happening in case of a warm re-booting (i.e. by PMC resetting). >> >> Can you rebase this on top of the media_tree master branch? I think a variant >> of patch 1 has already been applied. I found a mail today where you mentioned >> that you preferred your version (it looks like I missed that) so you'll need >> to >> rework patch 1. > > Hello Hans, > > I'll take a look at what patches has been applied, my bad for sending > the v2 too late. Thank you for the heads up! > I tested the already-applied variant of the patch 1 and it has the same behaviour as my variant, so it's okay. Would you want me to send a v3 without the conflicting patch 1 or you could apply the patches 2-4 from this series? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] fixing ERROR: Macros with complex values must be enclosed within parentheses.
soc_camera.c: fixing ERROR: Macros with complex values must be enclused within parentheses. Signed-off-by: B K Karthik --- drivers/staging/media/soc_camera/soc_camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/staging/media/soc_camera/soc_camera.c index 39f513f69b89..f609ecf6691c 100644 --- a/drivers/staging/media/soc_camera/soc_camera.c +++ b/drivers/staging/media/soc_camera/soc_camera.c @@ -238,8 +238,7 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_subdev_desc *ssdd, } EXPORT_SYMBOL(soc_camera_apply_board_flags); -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \ - ((x) >> 24) & 0xff +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, ((x) >> 24) & 0xff) static int soc_camera_try_fmt(struct soc_camera_device *icd, struct v4l2_format *f) -- 2.20.1 signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] fixing ERROR: Macros with complex values must be enclosed within parentheses.
Hi Karthik, Thank you for the patch. On Thu, Jun 25, 2020 at 10:17:23PM -0400, B K Karthik wrote: > soc_camera.c: > > fixing ERROR: Macros with complex values must be enclused within parentheses. > > Signed-off-by: B K Karthik > --- > drivers/staging/media/soc_camera/soc_camera.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/media/soc_camera/soc_camera.c > b/drivers/staging/media/soc_camera/soc_camera.c > index 39f513f69b89..f609ecf6691c 100644 > --- a/drivers/staging/media/soc_camera/soc_camera.c > +++ b/drivers/staging/media/soc_camera/soc_camera.c > @@ -238,8 +238,7 @@ unsigned long soc_camera_apply_board_flags(struct > soc_camera_subdev_desc *ssdd, > } > EXPORT_SYMBOL(soc_camera_apply_board_flags); > > -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \ > - ((x) >> 24) & 0xff > +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, > ((x) >> 24) & 0xff) This won't work. Try to compile this driver with CONFIG_DYNAMIC_DEBUG and the compiler will tell you why. Regardless, drivers/staging/media/soc_camera/soc_camera.c is in staging because it will be removed from the kernel, cleanups for this file won't be accepted. > static int soc_camera_try_fmt(struct soc_camera_device *icd, > struct v4l2_format *f) -- Regards, Laurent Pinchart ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing] BUILD SUCCESS 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027 staging: ion: fix common struct sg_table related issues elapsed time: 725m configs tested: 120 configs skipped: 5 The following configs have been built successfully. More configs may be tested in the coming days. arm defconfig arm allyesconfig arm allmodconfig arm allnoconfig arm64allyesconfig arm64 defconfig arm64allmodconfig arm64 allnoconfig arc haps_hs_smp_defconfig s390 allyesconfig powerpc g5_defconfig mipsjmr3927_defconfig sh se7751_defconfig arm imx_v6_v7_defconfig armxcep_defconfig arm pxa255-idp_defconfig arm tango4_defconfig arm mainstone_defconfig arm moxart_defconfig m68kq40_defconfig sh sdk7786_defconfig armmps2_defconfig s390 allnoconfig arm pxa_defconfig arm lpc18xx_defconfig mips ip27_defconfig arm eseries_pxa_defconfig mips loongson3_defconfig i386 alldefconfig nds32 allnoconfig sh se7724_defconfig mips loongson1b_defconfig pariscallnoconfig armlart_defconfig i386 allnoconfig i386 allyesconfig i386defconfig i386 debian-10.3 ia64 allmodconfig ia64defconfig ia64 allnoconfig ia64 allyesconfig m68k allmodconfig m68k allnoconfig m68k sun3_defconfig m68kdefconfig m68k allyesconfig nios2 defconfig nios2allyesconfig openriscdefconfig c6x allyesconfig c6x allnoconfig openrisc allyesconfig nds32 defconfig csky allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig h8300allmodconfig xtensa defconfig arc defconfig arc allyesconfig sh allmodconfig shallnoconfig microblazeallnoconfig mips allyesconfig mips allnoconfig mips allmodconfig parisc defconfig parisc allyesconfig parisc allmodconfig powerpc defconfig powerpc allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20200624 x86_64 randconfig-a002-20200624 x86_64 randconfig-a003-20200624 x86_64 randconfig-a005-20200624 x86_64 randconfig-a001-20200624 x86_64 randconfig-a006-20200624 i386 randconfig-a002-20200624 i386 randconfig-a006-20200624 i386 randconfig-a003-20200624 i386 randconfig-a001-20200624 i386 randconfig-a005-20200624 i386 randconfig-a004-20200624 i386 randconfig-a013-20200624 i386 randconfig-a016-20200624 i386 randconfig-a012-20200624 i386 randconfig-a014-20200624 i386 randconfig-a011-20200624 i386 randconfig-a015-20200624 riscvallyesconfig riscv allnoconfig riscv defconfig riscvallmodconfig s390
Re: [PATCH] fixing ERROR: Macros with complex values must be enclosed within parentheses.
On Thu, Jun 25, 2020 at 10:17:23PM -0400, B K Karthik wrote: > soc_camera.c: > > fixing ERROR: Macros with complex values must be enclused within parentheses. > > Signed-off-by: B K Karthik > --- > drivers/staging/media/soc_camera/soc_camera.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v7 00/17] wilc1000: move out of staging
Greg KH writes: > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote: >> Greg KH writes: >> >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: >> >> writes: >> >> >> >> > From: Ajay Singh >> >> > >> >> > This patch series is to review and move wilc1000 driver out of staging. >> >> > Most of the review comments received in [1] & [2] are addressed in the >> >> > latest code. >> >> > Please review and provide your inputs. >> >> > >> >> > [1]. >> >> > https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kat...@microchip.com/ >> >> > [2]. >> >> > https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kat...@microchip.com/ >> >> > >> >> > Changes since v6: >> >> > - added Reviewed-by tag received for DT binding document patch earlier. >> >> >* https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus >> >> > - merged latest driver and included --base commit as suggested. >> >> >> >> Greg, in preparation for moving the driver to drivers/net/wireless can I >> >> ask you to not to take wilc1000 patches for the time being? I think that >> >> way it would be easier to move the driver between trees if there are no >> >> changes after v5.8-rc1. Or is there a better way handle the move? >> > >> > The best way is for there to be a series of patches that just adds the >> > driver to the "real" part of the tree, and when that is merged, let me >> > know and I will just delete the driver version in the staging tree. >> > >> > Does that work for you? >> >> It would be fine for me but won't that approach break the build (eg. >> allyesconfig) due to two duplicate versions of the same driver in >> wireless-drivers-next? > > For maybe one day, yes, but that's all. > >> What I was thinking that Ajay would create a patch moving the driver >> from drivers/staging/wilc1000 to >> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git >> format-patch --find-renames' the patch should be really small, mostly >> just renames and small changes to Kconfig, Makefile and MAINTAINERS >> files. But this of course would require that there are no wilc1000 >> patches in your tree until you get the driver move commit during the >> next merge window, otherwise we would see conflicts between staging-next >> and wireless-drivers-next. >> >> But I don't have any strong opinions, whatever is easiest for everyone :) > > It's kind of hard to review patches that do moves, but if you all want > to do that, that's fine with me. Actually we have been reviewing the driver with full diffs, one file per patch style[1], so I think everyone are happy. At least I have not heard any complaints. And Ajay already submitted that the simple rename patch proposed, thanks Ajay! https://patchwork.kernel.org/patch/11625025/ And indeed the patch is simple as it can get. So Greg, if it's ok for you I would like to apply that simple patch to wireless-drivers-next. > Note, I can't guarantee that I'll not take any wilc1000 patches, I'll > probably forget, but git mv will handle all of that just fine. Good point. To be on the safe side one option is that if I create a topic branch for this simple patch and use v5.8-rc1 as the baseline. Then I would pull the topic branch to wireless-drivers-next and you could pull it to staging-next. That way you would not have wilc1000 in your tree anymore and no accidental submission or commits either :) What do you think? [1 ] https://patchwork.kernel.org/project/linux-wireless/list/?series=307223&state=*&order=date -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] wilc1000: move wilc driver out of staging
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on wireless-drivers-next/master
wireless-drivers/master v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Ajay-Kathat-microchip-com/wilc1000-move-wilc-driver-out-of-staging/20200625-203957
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
9bea6eb3f59cb2fad8b46d91c666a17d0aa53456
config: ia64-randconfig-r013-20200624 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/net/wireless/microchip/wilc1000/mon.c: In function
'wilc_wfi_init_mon_interface':
>> drivers/net/wireless/microchip/wilc1000/mon.c:232:2: warning: 'strncpy'
>> specified bound 16 equals destination size [-Wstringop-truncation]
232 | strncpy(wl->monitor_dev->name, name, IFNAMSIZ);
| ^~
vim +/strncpy +232 drivers/net/wireless/microchip/wilc1000/mon.c
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 216
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 217
struct net_device *wilc_wfi_init_mon_interface(struct wilc *wl,
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 218
const char *name,
1b7c69e84bcea7 drivers/staging/wilc1000/linux_mon.c Anchal Jain 2016-03-14 219
struct net_device *real_dev)
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 220
{
73d359a08b76da drivers/staging/wilc1000/linux_mon.c Ajay Singh 2018-05-02 221
struct wilc_wfi_mon_priv *priv;
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 222
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 223
/* If monitor interface is already initialized, return it */
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 224
if (wl->monitor_dev)
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 225
return wl->monitor_dev;
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 226
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 227
wl->monitor_dev = alloc_etherdev(sizeof(struct wilc_wfi_mon_priv));
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 228
if (!wl->monitor_dev)
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 229
return NULL;
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 230
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 231
wl->monitor_dev->type = ARPHRD_IEEE80211_RADIOTAP;
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 @232
strncpy(wl->monitor_dev->name, name, IFNAMSIZ);
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 233
wl->monitor_dev->name[IFNAMSIZ - 1] = 0;
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 234
wl->monitor_dev->netdev_ops = &wilc_wfi_netdev_ops;
9bc061e8805487 drivers/staging/wilc1000/wilc_mon.c Ajay Singh 2019-06-26 235
wl->monitor_dev->needs_free_netdev = true;
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 236
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 237
if (register_netdevice(wl->monitor_dev)) {
d892c97c889a77 drivers/staging/wilc1000/linux_mon.c Leo Kim 2016-02-22 238
netdev_err(real_dev, "register_netdevice failed\n");
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 239
return NULL;
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Johnny Kim 2015-05-11 240
}
588713006ea49d drivers/staging/wilc1000/linux_mon.c Ajay Singh 2019-02-02 241
priv = netdev_priv(wl->monitor_dev);
60959e53f83988 drivers/staging/wilc1000/linux_mon.c Leo Kim 2016-02-22 242
if (!priv)
c5c77ba18ea66a drivers/staging/wilc1000/linux_mon.c Joh
Re: [PATCH] wilc1000: move wilc driver out of staging
writes: > From: Ajay Singh > > WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The > WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other > processors with minimal resource requirements with a simple > SPI/SDIO-to-Wi-Fi interface. > > WILC1000 driver has been part of staging for few years. With > contributions from the community, it has improved significantly. Full > driver review has helped in achieving the current state. > The details for those reviews are captured in 1 & 2. > > [1]. > https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kat...@microchip.com/ > [2]. > https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kat...@microchip.com/ > > Signed-off-by: Ajay Singh [...] > --- a/drivers/net/wireless/Kconfig > +++ b/drivers/net/wireless/Kconfig > @@ -47,6 +47,7 @@ source "drivers/net/wireless/st/Kconfig" > source "drivers/net/wireless/ti/Kconfig" > source "drivers/net/wireless/zydas/Kconfig" > source "drivers/net/wireless/quantenna/Kconfig" > +source "drivers/net/wireless/microchip/Kconfig" This should be in alphabetical order. > --- a/drivers/net/wireless/Makefile > +++ b/drivers/net/wireless/Makefile > @@ -19,6 +19,7 @@ obj-$(CONFIG_WLAN_VENDOR_ST) += st/ > obj-$(CONFIG_WLAN_VENDOR_TI) += ti/ > obj-$(CONFIG_WLAN_VENDOR_ZYDAS) += zydas/ > obj-$(CONFIG_WLAN_VENDOR_QUANTENNA) += quantenna/ > +obj-$(CONFIG_WLAN_VENDOR_MICROCHIP) += microchip/ And this as well. I fixed these in the topic branch, please double check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?h=wilc1000-move-out-of-staging&id=5625f965d7644b4dc6a71d74021cfe093ad34eea I have not pulled that branch yet into master so we can make changes still. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/4] Tegra Video Decoder driver power management corrections
On 26/06/2020 02:17, Dmitry Osipenko wrote: > 24.06.2020 18:23, Dmitry Osipenko пишет: >> 24.06.2020 18:16, Hans Verkuil пишет: >>> On 24/06/2020 17:08, Dmitry Osipenko wrote: Hello, This small series addresses a Runtime PM issue that was discovered during of Tegra VI driver reviewing by balancing RPM usage count on RPM resume failure. Secondly it fixes reboot on some Tegra devices due to bootloader expecting VDE power partition to be ON at the boot time, which wasn't happening in case of a warm re-booting (i.e. by PMC resetting). >>> >>> Can you rebase this on top of the media_tree master branch? I think a >>> variant >>> of patch 1 has already been applied. I found a mail today where you >>> mentioned >>> that you preferred your version (it looks like I missed that) so you'll >>> need to >>> rework patch 1. >> >> Hello Hans, >> >> I'll take a look at what patches has been applied, my bad for sending >> the v2 too late. Thank you for the heads up! >> > > I tested the already-applied variant of the patch 1 and it has the same > behaviour as my variant, so it's okay. > > Would you want me to send a v3 without the conflicting patch 1 or you > could apply the patches 2-4 from this series? > I'll mark 1/4 as superseded and will apply patches 2-4. No need for you to do anything. Regards, Hans ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
