Re: [PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment
Thanks for the feedback Greg. Will resubmit the patch as you suggest. Thanks john On Sun, 10 May 2020 at 07:55, Greg KH wrote: > > On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote: > > Coding style issue > > > > Signed-off-by: John Oldman > > --- > > v1: Initial attempt. > > V2: Resubmitted with shorter comment line, as suggested by Greg KH. > > > > This patch clears the checkpatch.pl "Block comments should align the * on > > each line" warning. > > Why is this text not in the changelog area? Don't you think that it is > better than the 3 words you currently put there? > > Please fix up and resend. > > thanks, > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6656: Remove logically dead code
In the start of the "vnt_rf_set_txpower" function the "power" variable
is set at most to VNT_RF_MAX_POWER (hex = 0x3f, dec = 63). Then, in the
switch statement there are four comparisons with the "power" variable
against AL7230_PWR_IDX_LEN (dec = 64), VT3226_PWR_IDX_LEN (dec = 64),
VT3342_PWR_IDX_LEN (dec = 64). Due to all the commented comparisons are
to check if the "power" variable is "greater than or equal" to 64, this
never happens. So, remove the logically dead code.
Also, remove all the defines that are no longer required.
Addresses-Coverity-ID: 1230228 ("Logically dead code")
Fixes: f53d9f12c51a ("staging: vt6656: rf.c additional power.")
Signed-off-by: Oscar Carter
---
drivers/staging/vt6656/rf.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index fb708467b99b..5b8da06e3916 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -28,15 +28,9 @@
#include "usbpipe.h"
#define CB_AL2230_INIT_SEQ15
-
#define CB_AL7230_INIT_SEQ16
-#define AL7230_PWR_IDX_LEN64
-
#define CB_VT3226_INIT_SEQ11
-#define VT3226_PWR_IDX_LEN64
-
#define CB_VT3342_INIT_SEQ13
-#define VT3342_PWR_IDX_LEN64
static u8 al2230_init_table[CB_AL2230_INIT_SEQ][3] = {
{0x03, 0xf7, 0x90},
@@ -658,9 +652,6 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8
power,
if (ret)
return ret;
- if (power >= AL7230_PWR_IDX_LEN)
- return -EINVAL;
-
/*
* 0x080F1B00 for 3 wire control TxGain(D10)
* and 0x31 as TX Gain value
@@ -671,16 +662,11 @@ static int vnt_rf_set_txpower(struct vnt_private *priv,
u8 power,
break;
case RF_VT3226:
- if (power >= VT3226_PWR_IDX_LEN)
- return -EINVAL;
power_setting = ((0x3f - power) << 20) | (0x17 << 8);
ret = vnt_rf_write_embedded(priv, power_setting);
break;
case RF_VT3226D0:
- if (power >= VT3226_PWR_IDX_LEN)
- return -EINVAL;
-
if (ch->flags & IEEE80211_CHAN_NO_OFDM) {
u16 hw_value = ch->hw_value;
@@ -731,9 +717,6 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8
power,
break;
case RF_VT3342A0:
- if (power >= VT3342_PWR_IDX_LEN)
- return -EINVAL;
-
power_setting = ((0x3f - power) << 20) | (0x27 << 8);
ret = vnt_rf_write_embedded(priv, power_setting);
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
This patch is removing CFLAGS that are defining flags that are not used. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/Makefile | 3 --- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 3 --- 3 files changed, 7 deletions(-) diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile index a151f30fc46f..e70357ec0af8 100644 --- a/drivers/staging/vt6655/Makefile +++ b/drivers/staging/vt6655/Makefile @@ -1,7 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -# TODO: all of these should be removed -ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__ -ccflags-y += -DHOSTAP vt6655_stage-y += device_main.o \ card.o \ diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 5889023d19c4..41cbec4134b0 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -32,7 +32,6 @@ * * Revision History: */ -#undef __NO_VERSION__ #include #include "device.h" diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile index a0f3862dea75..f696a9d7a143 100644 --- a/drivers/staging/vt6656/Makefile +++ b/drivers/staging/vt6656/Makefile @@ -1,7 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -# TODO: all of these should be removed -ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__ -ccflags-y += -DHOSTAP vt6656_stage-y += main_usb.o \ card.o \ -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment
Coding style issue
This patch clears the checkpatch.pl "Block comments should align the * on each
line" warning.
Signed-off-by: John Oldman
---
v1: Initial attempt.
v2: Resubmitted with shorter comment line, as suggested by Greg KH.
v3: Resubmitted with descriptiuon text moved into the comment area.
.../interface/vchiq_arm/vchiq_connected.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index 1640906e3929..993535bbc479 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -15,10 +15,10 @@ static intg_once_init;
static struct mutex g_connected_mutex;
/
-*
-* Function to initialize our lock.
-*
-***/
+ *
+ * Function to initialize our lock.
+ *
+ ***/
static void connected_init(void)
{
@@ -29,13 +29,13 @@ static void connected_init(void)
}
/
-*
-* This function is used to defer initialization until the vchiq stack is
-* initialized. If the stack is already initialized, then the callback will
-* be made immediately, otherwise it will be deferred until
-* vchiq_call_connected_callbacks is called.
-*
-***/
+ *
+ * This function is used to defer initialization until the vchiq stack is
+ * initialized. If the stack is already initialized, then the callback will
+ * be made immediately, otherwise it will be deferred until
+ * vchiq_call_connected_callbacks is called.
+ *
+ ***/
void vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
{
@@ -64,11 +64,11 @@ void
vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
}
/
-*
-* This function is called by the vchiq stack once it has been connected to
-* the videocore and clients can start to use the stack.
-*
-***/
+ *
+ * This function is called by the vchiq stack once it has been connected to
+ * the videocore and clients can start to use the stack.
+ *
+ ***/
void vchiq_call_connected_callbacks(void)
{
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
This patch will add indentation to multiline variable and put obj-$(CONFIG_X) at the begining of the file. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/Makefile | 24 drivers/staging/vt6656/Makefile | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile index e70357ec0af8..eda08a1516ab 100644 --- a/drivers/staging/vt6655/Makefile +++ b/drivers/staging/vt6655/Makefile @@ -1,15 +1,15 @@ # SPDX-License-Identifier: GPL-2.0 -vt6655_stage-y += device_main.o \ - card.o \ - channel.o \ - mac.o \ - baseband.o \ - rxtx.o \ - dpc.o \ - power.o \ - srom.o \ - key.o \ - rf.o - obj-$(CONFIG_VT6655) +=vt6655_stage.o + +vt6655_stage-y += device_main.o \ + card.o \ + channel.o \ + mac.o \ + baseband.o \ + rxtx.o \ + dpc.o \ + power.o \ + srom.o \ + key.o \ + rf.o diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile index f696a9d7a143..aac323d6a684 100644 --- a/drivers/staging/vt6656/Makefile +++ b/drivers/staging/vt6656/Makefile @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_VT6656) +=vt6656_stage.o + vt6656_stage-y += main_usb.o \ card.o \ mac.o \ @@ -11,5 +13,3 @@ vt6656_stage-y += main_usb.o \ rf.o \ usbpipe.o \ channel.o - -obj-$(CONFIG_VT6656) +=vt6656_stage.o -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile
This patchset will remove unused definitions of C Macros, reorder variable definition and increase indentation to match visual block. --- v2: spliting original patch to 2 separate patches Matej Dujava (2): staging: vt6656: vt6655: clean Makefiles staging: vt6655: vt6656: change order of makefile variable definitions drivers/staging/vt6655/Makefile | 27 --- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 7 ++- 3 files changed, 14 insertions(+), 21 deletions(-) -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: greybus: Fix uninitialized scalar variable
In the "gb_tty_set_termios" function the "newline" variable is declared
but not initialized. So the "flow_control" member is not initialized and
the OR / AND operations with itself results in an undefined value in
this member.
The purpose of the code is to set the flow control type, so remove the
OR / AND self operator and set the value directly.
Addresses-Coverity-ID: 1374016 ("Uninitialized scalar variable")
Fixes: e55c25206d5c9 ("greybus: uart: Handle CRTSCTS flag in termios")
Signed-off-by: Oscar Carter
---
drivers/staging/greybus/uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 55c51143bb09..4ffb334cd5cd 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -537,9 +537,9 @@ static void gb_tty_set_termios(struct tty_struct *tty,
}
if (C_CRTSCTS(tty) && C_BAUD(tty) != B0)
- newline.flow_control |= GB_SERIAL_AUTO_RTSCTS_EN;
+ newline.flow_control = GB_SERIAL_AUTO_RTSCTS_EN;
else
- newline.flow_control &= ~GB_SERIAL_AUTO_RTSCTS_EN;
+ newline.flow_control = 0;
if (memcmp(&gb_tty->line_coding, &newline, sizeof(newline))) {
memcpy(&gb_tty->line_coding, &newline, sizeof(newline));
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
CURSOS BONIFICABLES DESDE CASA (Empleados activos y en ERTE)
Buenos días Se encuentra abierto el plazo de inscripción de Cursos Bonificables para empleados en activo y en situación de ERTE. Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación 2020 que dispone las empresa. Se realizan desde casa en modalidad individual E-learning a través de la plataforma web y con total flexibilidad horaria. Deseáis que os mandemos la información? Saludos cordiales. Alex Pons Director departamento formación. FOESCO Formación Estatal Continua. Entidad Organizadora: B171823AP www.foesco.com e-mail: cur...@foesco.net Tel: 910 323 794 (Horario de 9h a 15h y de 17h a 20h de Lunes a Viernes) FOESCO ofrece formación a empresas y trabajadores en activo a través de cursos bonificados por la Fundación Estatal para la Formación en el Empleo (antiguo FORCEM) que gestiona las acciones formativas de FORMACIÓN CONTINUA para trabajadores y se rige por la ley 30/2015 de 9 de Septiembre. Si no desea recibir mas información de FOESCO responda a este correo con la palabra BAJA en el asunto. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
