Re: [PATCH] media: staging: rkisp1 Kconfig: depends on OF
Em Tue, 21 Apr 2020 00:17:08 -0300 Ezequiel Garcia escreveu: > Hi Mauro, Randy, > > On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab > wrote: > > > > building it with a random config causes a warning: > > > > WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0 > > Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] > > && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n] > > Selected by [y]: > > - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && > > MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST > > [=y]) > > > > Cc: Stephen Rothwell > > Reported-by: Randy Dunlap > > Signed-off-by: Mauro Carvalho Chehab > > Thanks for the patch. Please note this warning (plus another one), > is already fixed by a couple patches in this series: > > https://patchwork.linuxtv.org/project/linux-media/list/?series=2094 I actually merged the patches yesterday, in order to have a cleaner linux-next today. There were too much Kconfig noise those days. So, could you please rebase your patches on the top of media upstream? Thanks, Mauro ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: ion: Skip sync if not mapped
On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner > wrote: > > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > > > But I do think we can mark it as deprecated and let folks know that > > > > around the end of the year it will be deleted. > > > > > > No one ever notices "depreciated" things, they only notice if the code > > > is no longer there :) > > > > > > So I'm all for just deleting it and seeing who even notices... > > > > Agreed. > > I mean, I get there's not much love for ION in staging, and I too am > eager to see it go, but I also feel like in the discussions around > submitting the dmabuf heaps at talks, etc, that there was clear value > in removing ION after a short time so that folks could transition > being able to test both implementations against the same kernel so > performance regressions, etc could be worked out. > > I am actively getting many requests for help for vendors who are > looking at dmabuf heaps and are starting the transition process, and > I'm trying my best to motivate them to directly work within the > community so their needed heap functionality can go upstream. But it's > going to be a process, and their first attempts aren't going to > magically land upstream. I think being able to really compare their > implementations as they iterate and push things upstream will help in > order to be able to have upstream solutions that are also properly > functional for production usage. But we are not accepting any new ion allocators or changes at the moment, so I don't see how the ion code in the kernel is helping/hurting anything here. There has been a bunch of changes to the ion code recently, in the Android kernel trees, in order to get a lot of the different manufacturer "forks" of ion back together into one place. But again, those patches are not going to be sent upstream for merging so how is ion affecting the dmabuf code at all here? > The dmabuf heaps have been in an official kernel now for all of three > weeks. So yea, we can "delete [ION] and see who even notices", but I > worry that may seem a bit like contempt for the folks doing the work > on transitioning over, which doesn't help getting them to participate > within the community. But they aren't participating in the community today as no one is touching the ion code. So I fail to see how keeping a dead-end-version of ion in the kernel tree really affects anyone these days. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8723bs: rtw_wlan_util: Add size check of SSID IE
Add size check of SSID information element in incoming 802.11
frames, to prevent memcpy() of IE in array bssid->Ssid.Ssid, with
size more than 32 bytes.
Signed-off-by: Denis Straghkov
---
.../staging/rtl8723bs/core/rtw_wlan_util.c| 24 +++
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 110338dbe372..08eb09e29015 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -1271,13 +1271,13 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8
*pframe, u32 packet_len)
unsigned char *pbuf;
u32 wpa_ielen = 0;
u8 *pbssid = GetAddr3Ptr(pframe);
- u32 hidden_ssid = 0;
struct HT_info_element *pht_info = NULL;
struct rtw_ieee80211_ht_cap *pht_cap = NULL;
u32 bcn_channel;
unsigned short ht_cap_info;
unsigned char ht_info_infos_0;
struct mlme_priv *pmlmepriv = &Adapter->mlmepriv;
+ int ssid_len;
if (is_client_associated_to_ap(Adapter) == false)
return true;
@@ -1370,21 +1370,15 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8
*pframe, u32 packet_len)
}
/* checking SSID */
+ ssid_len = 0;
p = rtw_get_ie(bssid->IEs + _FIXED_IE_LENGTH_, _SSID_IE_, &len,
bssid->IELength - _FIXED_IE_LENGTH_);
- if (!p) {
- DBG_871X("%s marc: cannot find SSID for survey event\n",
__func__);
- hidden_ssid = true;
- } else {
- hidden_ssid = false;
- }
-
- if ((NULL != p) && (false == hidden_ssid && (*(p + 1 {
- memcpy(bssid->Ssid.Ssid, (p + 2), *(p + 1));
- bssid->Ssid.SsidLength = *(p + 1);
- } else {
- bssid->Ssid.SsidLength = 0;
- bssid->Ssid.Ssid[0] = '\0';
- }
+if (p) {
+ssid_len = *(p + 1);
+if (ssid_len > NDIS_802_11_LENGTH_SSID)
+ssid_len = 0;
+}
+memcpy(bssid->Ssid.Ssid, (p + 2), ssid_len);
+bssid->Ssid.SsidLength = ssid_len;
RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("%s bssid.Ssid.Ssid:%s
bssid.Ssid.SsidLength:%d "
"cur_network->network.Ssid.Ssid:%s len:%d\n",
__func__, bssid->Ssid.Ssid,
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: rtl8723bs: rtw_wlan_util: Add size check of SSID IE
On Tue, Apr 21, 2020 at 08:08:06PM +0300, Denis Straghkov wrote:
> /* checking SSID */
> + ssid_len = 0;
> p = rtw_get_ie(bssid->IEs + _FIXED_IE_LENGTH_, _SSID_IE_, &len,
> bssid->IELength - _FIXED_IE_LENGTH_);
> - if (!p) {
> - DBG_871X("%s marc: cannot find SSID for survey event\n",
> __func__);
> - hidden_ssid = true;
> - } else {
> - hidden_ssid = false;
> - }
> -
> - if ((NULL != p) && (false == hidden_ssid && (*(p + 1 {
> - memcpy(bssid->Ssid.Ssid, (p + 2), *(p + 1));
> - bssid->Ssid.SsidLength = *(p + 1);
> - } else {
> - bssid->Ssid.SsidLength = 0;
> - bssid->Ssid.Ssid[0] = '\0';
> - }
> +if (p) {
> +ssid_len = *(p + 1);
> +if (ssid_len > NDIS_802_11_LENGTH_SSID)
> +ssid_len = 0;
> +}
> +memcpy(bssid->Ssid.Ssid, (p + 2), ssid_len);
> +bssid->Ssid.SsidLength = ssid_len;
This is using spaces instead of tabs. Please run ./scripts/checkpatch.pl
on your patch.
regargs,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: Power save stop wake_up_count wrap around.
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.").
The bot has tested the following trees: v5.6.5, v5.5.18, v5.4.33, v4.19.116,
v4.14.176, v4.9.219, v4.4.219.
v5.6.5: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
v5.5.18: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
v5.4.33: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
v4.19.116: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return
code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to
SPDX-License-Identifier")
v4.14.176: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver
files")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return
code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to
SPDX-License-Identifier")
v4.9.219: Failed to apply! Possible dependencies:
0ef48913354e ("staging:vt6656:mac.c Aligned code to match open parenthesis")
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver
files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return
code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
812930665872 ("staging: vt6656: Alignment should match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to
SPDX-License-Identifier")
a4dc9bd6a35d ("staging: vt6656: convert spaces to tabs for rf.c")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument
without identifier name issue")
v4.4.219: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to
usbpipe")
1322739849a8 ("staging:vt6656:baseband.h: Fix alignment issue")
555d7a3ada13 ("staging:vt6656:dpc.h:fix parantheses alignment")
5678824069d5 ("staging: vt6656: Add space to align functions")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver
files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return
code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to
SPDX-License-Identifier")
a9f47a456ae5 ("staging:vt6656:card.c:fix alignment checks")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument
without identifier name issue")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: Fix pairwise key entry save.
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: f9ef05ce13e4 ("staging: vt6656: Fix pairwise key for non station
modes").
The bot has tested the following trees: v5.6.5, v5.5.18, v5.4.33, v4.19.116,
v4.14.176, v4.9.219, v4.4.219.
v5.6.5: Build OK!
v5.5.18: Build OK!
v5.4.33: Build OK!
v4.19.116: Build OK!
v4.14.176: Build OK!
v4.9.219: Failed to apply! Possible dependencies:
5e38e15e689b ("staging:vt6656:key.c Aligned code with open parenthesis")
v4.4.219: Failed to apply! Possible dependencies:
5e38e15e689b ("staging:vt6656:key.c Aligned code with open parenthesis")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: rtl8723bs: rtw_wlan_util: Add size check of SSID IE
Add size check of SSID information element in incoming 802.11
frames, to prevent memcpy() of IE in array bssid->Ssid.Ssid, with
size more than 32 bytes.
Signed-off-by: Denis Straghkov
---
Changes in v2:
- Replace spaces on tabs.
.../staging/rtl8723bs/core/rtw_wlan_util.c| 22 +++
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 110338dbe372..69bcd172b298 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -1271,13 +1271,13 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8
*pframe, u32 packet_len)
unsigned char *pbuf;
u32 wpa_ielen = 0;
u8 *pbssid = GetAddr3Ptr(pframe);
- u32 hidden_ssid = 0;
struct HT_info_element *pht_info = NULL;
struct rtw_ieee80211_ht_cap *pht_cap = NULL;
u32 bcn_channel;
unsigned short ht_cap_info;
unsigned char ht_info_infos_0;
struct mlme_priv *pmlmepriv = &Adapter->mlmepriv;
+ int ssid_len;
if (is_client_associated_to_ap(Adapter) == false)
return true;
@@ -1370,21 +1370,15 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8
*pframe, u32 packet_len)
}
/* checking SSID */
+ ssid_len = 0;
p = rtw_get_ie(bssid->IEs + _FIXED_IE_LENGTH_, _SSID_IE_, &len,
bssid->IELength - _FIXED_IE_LENGTH_);
- if (!p) {
- DBG_871X("%s marc: cannot find SSID for survey event\n",
__func__);
- hidden_ssid = true;
- } else {
- hidden_ssid = false;
- }
-
- if ((NULL != p) && (false == hidden_ssid && (*(p + 1 {
- memcpy(bssid->Ssid.Ssid, (p + 2), *(p + 1));
- bssid->Ssid.SsidLength = *(p + 1);
- } else {
- bssid->Ssid.SsidLength = 0;
- bssid->Ssid.Ssid[0] = '\0';
+ if (p) {
+ ssid_len = *(p + 1);
+ if (ssid_len > NDIS_802_11_LENGTH_SSID)
+ ssid_len = 0;
}
+ memcpy(bssid->Ssid.Ssid, (p + 2), ssid_len);
+ bssid->Ssid.SsidLength = ssid_len;
RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("%s bssid.Ssid.Ssid:%s
bssid.Ssid.SsidLength:%d "
"cur_network->network.Ssid.Ssid:%s len:%d\n",
__func__, bssid->Ssid.Ssid,
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging)
On Thursday 13 February 2020 16:18:47 Sasha Levin wrote: > On Thu, Feb 13, 2020 at 01:06:56AM +0100, Pali Rohár wrote: > > In released exFAT specification is not written how are Unicode code > > points above U+ represented in exFAT upcase table. Normally in > > UTF-16 are Unicode code points above U+ represented by surrogate > > pairs but compression format of exFAT upcase table is not clear how to > > do it there. > > > > Are you able to send question about this problem to relevant MS people? > > > > New Linux implementation of exfat which is waiting on mailing list just > > do not support Unicode code points above U+ in exFAT upcase table. > > Sure, I'll forward this question on. I'll see if I can get someone from > their team who could be available to answer questions such as these in > the future - Microsoft is interested in maintaining compatiblity between > Linux and Windows exFAT implementations. Hello Sasha! Have you got any answer from exfat MS team about upcase table for Unicode code points above U+? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [staging] aad378845d: WARNING:held_lock_freed
On 4/16/20 3:13 AM, Stefan Wahren wrote:
Hi,
Am 06.04.20 um 04:04 schrieb kernel test robot:
FYI, we noticed the following commit (built with gcc-7):
commit: aad378845d9334d223d0d56db8332ce071d90202 ("[PATCH 9/9] staging:
bcm2835-camera: reduce indentation in ctrl_set_image_effect")
url:
https://github.com/0day-ci/linux/commits/Stefan-Wahren/staging-bcm2835-camera-Clean-up-driver/20200329-225704
in testcase: boot
on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 8G
caused below changes (please refer to attached dmesg/kmsg for entire
log/backtrace):
+--+++
|
| 301f97157d | aad378845d |
+--+++
| boot_successes
| 8 | 0 |
| boot_failures
| 9 | 16 |
| WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_fwd_prog
| 4 | 3 |
| EIP:rcu_torture_fwd_prog
| 4 | 3 |
| Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode=
| 6 ||
| Assertion_failed
| 2 ||
| WARNING:held_lock_freed
| 0 | 15 |
| is_freeing_memory#-#,with_a_lock_still_held_there
| 0 | 15 |
| WARNING:at_drivers/base/devres.c:#devres_release_all
| 0 | 15 |
| EIP:devres_release_all
| 0 | 15 |
| BUG:kernel_NULL_pointer_dereference,address
| 0 | 15 |
| Oops:#[##]
| 0 | 15 |
| EIP:add_dr
| 0 | 15 |
| Kernel_panic-not_syncing:Fatal_exception
| 0 | 15 |
|
BUG:kernel_hang_in_early-boot_stage,last_printk:Probing_EDD(edd=off_to_disable)...ok
| 0 | 1 |
+--+++
If you fix the issue, kindly add following tag
Reported-by: kernel test robot
[ 296.433348] ### dt-test ### EXPECT \ : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest0/status
[ 296.434682] OF: overlay: WARNING: memory leak will occur if overlay removed,
property: /testcase-data/overlay-node/test-bus/test-unittest0/status
[ 296.438645] ### dt-test ### EXPECT / : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest0/status
[ 296.438647] ### dt-test ### EXPECT \ : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest1/status
[ 296.439964] OF: overlay: WARNING: memory leak will occur if overlay removed,
property: /testcase-data/overlay-node/test-bus/test-unittest1/status
[ 296.442125] ### dt-test ### EXPECT / : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest1/status
[ 296.442125] ### dt-test ### EXPECT \ : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest2/status
[ 296.443264] OF: overlay: WARNING: memory leak will occur if overlay removed,
property: /testcase-data/overlay-node/test-bus/test-unittest2/status
[ 296.464571] ### dt-test ### EXPECT / : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest2/status
[ 296.464572] ### dt-test ### EXPECT \ : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest3/status
[ 296.466503] OF: overlay: WARNING: memory leak will occur if overlay removed,
property: /testcase-data/overlay-node/test-bus/test-unittest3/status
[ 296.469963] ### dt-test ### EXPECT / : OF: overlay: WARNING: memory leak
will occur if overlay removed, property:
/testcase-data/overlay-node/test-bus/test-unittest3/status
[ 296.470955] ### dt-test ### EXPECT \ : OF: overlay: WARNING: memory leak
will occur if ov
