[PATCH] staging: rtl8192u: Replaces symbolic permissions with octal permissions
Solves following checkpatch.pl issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.
Signed-off-by: Camylla Goncalves Cantanheide
---
drivers/staging/rtl8192u/r8192U_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 89dd1fb0b..9e222172b 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -613,13 +613,13 @@ static void rtl8192_proc_init_one(struct net_device *dev)
if (!dir)
return;
- proc_create_single("stats-rx", S_IFREG | S_IRUGO, dir,
+ proc_create_single("stats-rx", S_IFREG | 0444, dir,
proc_get_stats_rx);
- proc_create_single("stats-tx", S_IFREG | S_IRUGO, dir,
+ proc_create_single("stats-tx", S_IFREG | 0444, dir,
proc_get_stats_tx);
- proc_create_single("stats-ap", S_IFREG | S_IRUGO, dir,
+ proc_create_single("stats-ap", S_IFREG | 0444, dir,
proc_get_stats_ap);
- proc_create_single("registers", S_IFREG | S_IRUGO, dir,
+ proc_create_single("registers", S_IFREG | 0444, dir,
proc_get_registers);
}
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables
The variables of function setKey triggered a 'Avoid CamelCase'
warning from checkpatch.pl. This patch renames these
variables to correct this warning.
Signed-off-by: Camylla Goncalves Cantanheide
---
drivers/staging/rtl8192u/r8192U_core.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 93a15d57e..fcfb9024a 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -4877,50 +4877,50 @@ void EnableHWSecurityConfig8192(struct net_device *dev)
write_nic_byte(dev, SECR, SECR_value);
}
-void setKey(struct net_device *dev, u8 EntryNo, u8 KeyIndex, u16 KeyType,
- u8 *MacAddr, u8 DefaultKey, u32 *KeyContent)
+void setKey(struct net_device *dev, u8 entryno, u8 keyindex, u16 keytype,
+ u8 *macaddr, u8 defaultkey, u32 *keycontent)
{
- u32 TargetCommand = 0;
- u32 TargetContent = 0;
- u16 usConfig = 0;
+ u32 target_command = 0;
+ u32 target_content = 0;
+ u16 us_config = 0;
u8 i;
- if (EntryNo >= TOTAL_CAM_ENTRY)
+ if (entryno >= TOTAL_CAM_ENTRY)
RT_TRACE(COMP_ERR, "cam entry exceeds in %s\n", __func__);
RT_TRACE(COMP_SEC,
">to %s, dev:%p, EntryNo:%d, KeyIndex:%d, KeyType:%d,
MacAddr%pM\n",
-__func__, dev, EntryNo, KeyIndex, KeyType, MacAddr);
+__func__, dev, entryno, keyindex, keytype, macaddr);
- if (DefaultKey)
- usConfig |= BIT(15) | (KeyType << 2);
+ if (defaultkey)
+ us_config |= BIT(15) | (keytype << 2);
else
- usConfig |= BIT(15) | (KeyType << 2) | KeyIndex;
+ us_config |= BIT(15) | (keytype << 2) | keyindex;
for (i = 0; i < CAM_CONTENT_COUNT; i++) {
- TargetCommand = i + CAM_CONTENT_COUNT * EntryNo;
- TargetCommand |= BIT(31) | BIT(16);
+ target_command = i + CAM_CONTENT_COUNT * entryno;
+ target_command |= BIT(31) | BIT(16);
if (i == 0) { /* MAC|Config */
- TargetContent = (u32)(*(MacAddr + 0)) << 16 |
- (u32)(*(MacAddr + 1)) << 24 |
- (u32)usConfig;
+ target_content = (u32)(*(macaddr + 0)) << 16 |
+ (u32)(*(macaddr + 1)) << 24 |
+ (u32)us_config;
- write_nic_dword(dev, WCAMI, TargetContent);
- write_nic_dword(dev, RWCAM, TargetCommand);
+ write_nic_dword(dev, WCAMI, target_content);
+ write_nic_dword(dev, RWCAM, target_command);
} else if (i == 1) { /* MAC */
- TargetContent = (u32)(*(MacAddr + 2))|
- (u32)(*(MacAddr + 3)) << 8 |
- (u32)(*(MacAddr + 4)) << 16 |
- (u32)(*(MacAddr + 5)) << 24;
- write_nic_dword(dev, WCAMI, TargetContent);
- write_nic_dword(dev, RWCAM, TargetCommand);
+ target_content = (u32)(*(macaddr + 2)) |
+ (u32)(*(macaddr + 3)) << 8 |
+ (u32)(*(macaddr + 4)) << 16 |
+ (u32)(*(macaddr + 5)) << 24;
+ write_nic_dword(dev, WCAMI, target_content);
+ write_nic_dword(dev, RWCAM, target_command);
} else {
/* Key Material */
- if (KeyContent) {
+ if (keycontent) {
write_nic_dword(dev, WCAMI,
- *(KeyContent + i - 2));
- write_nic_dword(dev, RWCAM, TargetCommand);
+ *(keycontent + i - 2));
+ write_nic_dword(dev, RWCAM, target_command);
}
}
}
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] staging: rtl8192u: Using function name as string
Solves the following checkpatch.pl for a triggered function: WARNING: Prefer using '"%s...", __func__' to using 'setKey', this function's name, in a string Signed-off-by: Camylla Goncalves Cantanheide --- drivers/staging/rtl8192u/r8192U_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 9e222172b..93a15d57e 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -4886,11 +4886,11 @@ void setKey(struct net_device *dev, u8 EntryNo, u8 KeyIndex, u16 KeyType, u8 i; if (EntryNo >= TOTAL_CAM_ENTRY) - RT_TRACE(COMP_ERR, "cam entry exceeds in setKey()\n"); + RT_TRACE(COMP_ERR, "cam entry exceeds in %s\n", __func__); RT_TRACE(COMP_SEC, -">to setKey(), dev:%p, EntryNo:%d, KeyIndex:%d, KeyType:%d, MacAddr%pM\n", -dev, EntryNo, KeyIndex, KeyType, MacAddr); +">to %s, dev:%p, EntryNo:%d, KeyIndex:%d, KeyType:%d, MacAddr%pM\n", +__func__, dev, EntryNo, KeyIndex, KeyType, MacAddr); if (DefaultKey) usConfig |= BIT(15) | (KeyType << 2); -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: Use ARRAY_SIZE instead of hardcoded size
On Sat, Mar 14, 2020 at 05:47:54PM +0100, Oscar Carter wrote: > Use ARRAY_SIZE to replace the hardcoded size so we will never have a > mismatch. > > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/main_usb.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6656/main_usb.c > b/drivers/staging/vt6656/main_usb.c > index 5e48b3ddb94c..4370941ffc04 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -23,6 +23,7 @@ > > #include > #include > +#include > #include "device.h" > #include "card.h" > #include "baseband.h" > @@ -116,6 +117,7 @@ static int vnt_init_registers(struct vnt_private *priv) > int ii; > u8 tmp; > u8 calib_tx_iq = 0, calib_tx_dc = 0, calib_rx_iq = 0; > + const int n_cck_pwr_tbl = ARRAY_SIZE(priv->cck_pwr_tbl); Please use ARRAY_SIZE(priv->cck_pwr_tbl) everywhere instead of introducing this new variable. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
REF
Greetings, I was searching through a local business directory when I found your profile. I am Soliciting On-Behalf of my private client who is interested in having a serious business investment in your country. If you have a valid business, investment or project he can invest back to me for more details. Your swift response is highly needed. Sincerely Stephen Li Please response back to me with is my private email below for more details stephli947...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
REF
Greetings, I was searching through a local business directory when I found your profile. I am Soliciting On-Behalf of my private client who is interested in having a serious business investment in your country. If you have a valid business, investment or project he can invest back to me for more details. Your swift response is highly needed. Sincerely Stephen Li Please response back to me with is my private email below for more details stephli947...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables
On Tue, Mar 17, 2020 at 08:51:30AM +, Camylla Goncalves Cantanheide wrote:
> The variables of function setKey triggered a 'Avoid CamelCase'
> warning from checkpatch.pl. This patch renames these
> variables to correct this warning.
>
> Signed-off-by: Camylla Goncalves Cantanheide
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 52 +-
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c
> b/drivers/staging/rtl8192u/r8192U_core.c
> index 93a15d57e..fcfb9024a 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -4877,50 +4877,50 @@ void EnableHWSecurityConfig8192(struct net_device
> *dev)
> write_nic_byte(dev, SECR, SECR_value);
> }
>
> -void setKey(struct net_device *dev, u8 EntryNo, u8 KeyIndex, u16 KeyType,
> - u8 *MacAddr, u8 DefaultKey, u32 *KeyContent)
> +void setKey(struct net_device *dev, u8 entryno, u8 keyindex, u16 keytype,
> + u8 *macaddr, u8 defaultkey, u32 *keycontent)
> {
> - u32 TargetCommand = 0;
> - u32 TargetContent = 0;
> - u16 usConfig = 0;
> + u32 target_command = 0;
> + u32 target_content = 0;
> + u16 us_config = 0;
Use these renames to think deeply about naming.
I don't like "entryno". I would prefer "entry_no". Use the same
underscore for spaces rule for key_index, mac_addr and all the rest. Is
"key_idx" better or "key_index"?
What added value or meaning does the "target_" part of "target_command"
add? Use "cmd" instead of "command". "target_command" and
"target_content" are the same length and mostly the same letters. Avoid
that sort of thing because it makes it hard to read at a glance. The
two get swapped in your head.
What does the "us_" mean in us_config? Is it microsecond as in usec?
Is it United states? Actually it turns out it probably means "unsigned
short". Never make the variable names show the type. If you have a
good editor you can just hover the mouse over a variable to see the
type. Or if you're using vim like me, then you have to use '*' to
highlight the variable and scroll to the top of the function. Either
way, never use "us_" to mean unsigned short.
What does the "config" part of "us_config" mean? What does the "content"
part of "target_content" mean? Always think about that. Variable names
are hard and maybe "config" and "content" are clear enough. But at
think about it, and consider all the options.
Anyway, the reason that this patch needs to be re-written is because
we want underscores in place of spaces for "key_type" and because
"us_config" is against the rules. The rest is just something to
consider and if you find better names, then go with that but if you
don't just fix those two things and resend.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:debugfs_cleanup] BUILD SUCCESS b1f4a8dbf4d3cfb02f765fd9645ff2ccdbb98006
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup branch HEAD: b1f4a8dbf4d3cfb02f765fd9645ff2ccdbb98006 debugfs: remove return value of debugfs_create_file_size() elapsed time: 11432m configs tested: 117 configs skipped: 0 The following configs have been built successfully. More configs may be tested in the coming days. arm64allyesconfig arm allyesconfig arm64allmodconfig arm allmodconfig arm64 allnoconfig arm allnoconfig arm efm32_defconfig arm at91_dt_defconfig armshmobile_defconfig arm64 defconfig arm exynos_defconfig armmulti_v5_defconfig arm sunxi_defconfig armmulti_v7_defconfig shallnoconfig um defconfig microblaze mmu_defconfig pariscallnoconfig i386 allnoconfig i386 alldefconfig i386 allyesconfig i386defconfig ia64 alldefconfig ia64 allmodconfig ia64 allnoconfig ia64 allyesconfig ia64defconfig nios2 3c120_defconfig nios2 10m50_defconfig c6xevmc6678_defconfig xtensa iss_defconfig c6x allyesconfig xtensa common_defconfig openrisc simple_smp_defconfig openriscor1ksim_defconfig alpha defconfig cskydefconfig nds32 allnoconfig nds32 defconfig h8300 h8s-sim_defconfig h8300 edosk2674_defconfig m68k m5475evb_defconfig m68k allmodconfig h8300h8300h-sim_defconfig m68k sun3_defconfig m68k multi_defconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allnoconfig mips allyesconfig mips fuloong2e_defconfig mips malta_kvm_defconfig pariscgeneric-64bit_defconfig pariscgeneric-32bit_defconfig parisc allyesconfig alpharandconfig-a001-20200316 m68k randconfig-a001-20200316 mips randconfig-a001-20200316 nds32randconfig-a001-20200316 parisc randconfig-a001-20200316 riscvrandconfig-a001-20200316 c6x randconfig-a001-20200316 h8300randconfig-a001-20200316 microblaze randconfig-a001-20200316 nios2randconfig-a001-20200316 sparc64 randconfig-a001-20200316 csky randconfig-a001-20200316 openrisc randconfig-a001-20200316 s390 randconfig-a001-20200316 sh randconfig-a001-20200316 xtensa randconfig-a001-20200316 x86_64 randconfig-b001-20200316 x86_64 randconfig-b002-20200316 x86_64 randconfig-b003-20200316 i386 randconfig-b001-20200316 i386 randconfig-b002-20200316 i386 randconfig-b003-20200316 x86_64 randconfig-e001-20200316 x86_64 randconfig-e002-20200316 x86_64 randconfig-e003-20200316 i386 randconfig-e001-20200316 i386 randconfig-e002-20200316 i386 randconfig-e003-20200316 x86_64 randconfig-h001-20200316 x86_64 randconfig-h002-20200316 x86_64 randconfig-h003-20200316 i386 randconfig-h001-20200316 i386 randconfig-h002-20200316 i386 randconfig-h003-20200316 riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig s390 alldefconfig s390 allmodconfig s390 allnoconfig s390 allyesconfig s390
[RFC PATCH 5/7] pwm: replace polarity enum with macros
To avoid duplication of pwm polarity definitions,
remove "enum pwm_polarity" and use macros instead.
Prepare to use both polarity flags in DTs.
Signed-off-by: Oleksandr Suvorov
---
drivers/pwm/core.c | 2 +-
drivers/pwm/pwm-atmel-tcb.c | 8
drivers/pwm/pwm-bcm-kona.c | 2 +-
drivers/pwm/pwm-bcm2835.c | 2 +-
drivers/pwm/pwm-berlin.c| 2 +-
drivers/pwm/pwm-ep93xx.c| 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-lpc18xx-sct.c | 2 +-
drivers/pwm/pwm-omap-dmtimer.c | 2 +-
drivers/pwm/pwm-renesas-tpu.c | 4 ++--
drivers/pwm/pwm-samsung.c | 2 +-
drivers/pwm/pwm-stm32.c | 2 +-
drivers/pwm/pwm-tiecap.c| 2 +-
drivers/pwm/pwm-tiehrpwm.c | 4 ++--
drivers/pwm/pwm-vt8500.c| 2 +-
drivers/pwm/sysfs.c | 2 +-
drivers/staging/greybus/pwm.c | 2 +-
drivers/video/backlight/lp8788_bl.c | 2 +-
include/linux/mfd/lp8788.h | 2 +-
include/linux/pwm.h | 29 -
include/trace/events/pwm.h | 2 +-
21 files changed, 33 insertions(+), 46 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 08afbb5b98aa..2cb9db8d545b 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -257,7 +257,7 @@ static bool pwm_ops_check(const struct pwm_ops *ops)
* Returns: 0 on success or a negative error code on failure.
*/
int pwmchip_add_with_polarity(struct pwm_chip *chip,
- enum pwm_polarity polarity)
+ unsigned int polarity)
{
struct pwm_device *pwm;
unsigned int i;
diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index 98526a286347..9e8a0b4b1751 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -31,7 +31,7 @@
ATMEL_TC_BEEVT | ATMEL_TC_BSWTRG)
struct atmel_tcb_pwm_device {
- enum pwm_polarity polarity; /* PWM polarity */
+ unsigned int polarity; /* PWM polarity */
unsigned div; /* PWM clock divider */
unsigned duty; /* PWM duty expressed in clk cycles */
unsigned period;/* PWM period expressed in clk cycles */
@@ -60,7 +60,7 @@ static inline struct atmel_tcb_pwm_chip *to_tcb_chip(struct
pwm_chip *chip)
static int atmel_tcb_pwm_set_polarity(struct pwm_chip *chip,
struct pwm_device *pwm,
- enum pwm_polarity polarity)
+ unsigned int polarity)
{
struct atmel_tcb_pwm_device *tcbpwm = pwm_get_chip_data(pwm);
@@ -147,7 +147,7 @@ static void atmel_tcb_pwm_disable(struct pwm_chip *chip,
struct pwm_device *pwm)
unsigned group = pwm->hwpwm / 2;
unsigned index = pwm->hwpwm % 2;
unsigned cmr;
- enum pwm_polarity polarity = tcbpwm->polarity;
+ unsigned int polarity = tcbpwm->polarity;
/*
* If duty is 0 the timer will be stopped and we have to
@@ -206,7 +206,7 @@ static int atmel_tcb_pwm_enable(struct pwm_chip *chip,
struct pwm_device *pwm)
unsigned group = pwm->hwpwm / 2;
unsigned index = pwm->hwpwm % 2;
u32 cmr;
- enum pwm_polarity polarity = tcbpwm->polarity;
+ unsigned int polarity = tcbpwm->polarity;
/*
* If duty is 0 the timer will be stopped and we have to
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 02da511814f1..83eab0cc51ce 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -174,7 +174,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct
pwm_device *pwm,
}
static int kona_pwmc_set_polarity(struct pwm_chip *chip, struct pwm_device
*pwm,
- enum pwm_polarity polarity)
+ unsigned int polarity)
{
struct kona_pwmc *kp = to_kona_pwmc(chip);
unsigned int chan = pwm->hwpwm;
diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
index 91e24f01b54e..2110aef85f19 100644
--- a/drivers/pwm/pwm-bcm2835.c
+++ b/drivers/pwm/pwm-bcm2835.c
@@ -107,7 +107,7 @@ static void bcm2835_pwm_disable(struct pwm_chip *chip,
struct pwm_device *pwm)
}
static int bcm2835_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
- enum pwm_polarity polarity)
+ unsigned int polarity)
{
struct bcm2835_pwm *pc = to_bcm2835_pwm(chip);
u32 value;
diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c
index b91c477cc84b..1a080bf33047 100644
--- a/drivers/pwm/pwm-berlin.c
+++ b/drivers/pwm/pwm-berlin.c
@@ -127,7 +127,7 @@ static int berlin_pwm_config(struct pwm_chip *chip, struct
pwm_device *pwm_dev,
static int berlin_pwm_set_polarity(struct pwm_
Re: [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables
On Tue, 2020-03-17 at 16:43 +0300, Dan Carpenter wrote:
> On Tue, Mar 17, 2020 at 08:51:30AM +, Camylla Goncalves Cantanheide wrote:
> > The variables of function setKey triggered a 'Avoid CamelCase'
> > warning from checkpatch.pl. This patch renames these
> > variables to correct this warning.
> >
> > Signed-off-by: Camylla Goncalves Cantanheide
> > ---
> > drivers/staging/rtl8192u/r8192U_core.c | 52 +-
> > 1 file changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c
> > b/drivers/staging/rtl8192u/r8192U_core.c
> > index 93a15d57e..fcfb9024a 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -4877,50 +4877,50 @@ void EnableHWSecurityConfig8192(struct net_device
> > *dev)
> > write_nic_byte(dev, SECR, SECR_value);
> > }
> >
> > -void setKey(struct net_device *dev, u8 EntryNo, u8 KeyIndex, u16 KeyType,
> > - u8 *MacAddr, u8 DefaultKey, u32 *KeyContent)
> > +void setKey(struct net_device *dev, u8 entryno, u8 keyindex, u16 keytype,
> > + u8 *macaddr, u8 defaultkey, u32 *keycontent)
> > {
> > - u32 TargetCommand = 0;
> > - u32 TargetContent = 0;
> > - u16 usConfig = 0;
> > + u32 target_command = 0;
> > + u32 target_content = 0;
> > + u16 us_config = 0;
>
> Use these renames to think deeply about naming.
>
> I don't like "entryno". I would prefer "entry_no". Use the same
> underscore for spaces rule for key_index, mac_addr and all the rest. Is
> "key_idx" better or "key_index"?
>
> What added value or meaning does the "target_" part of "target_command"
> add? Use "cmd" instead of "command". "target_command" and
> "target_content" are the same length and mostly the same letters. Avoid
> that sort of thing because it makes it hard to read at a glance. The
> two get swapped in your head.
>
> What does the "us_" mean in us_config? Is it microsecond as in usec?
> Is it United states? Actually it turns out it probably means "unsigned
> short". Never make the variable names show the type. If you have a
> good editor you can just hover the mouse over a variable to see the
> type. Or if you're using vim like me, then you have to use '*' to
> highlight the variable and scroll to the top of the function. Either
> way, never use "us_" to mean unsigned short.
>
> What does the "config" part of "us_config" mean? What does the "content"
> part of "target_content" mean? Always think about that. Variable names
> are hard and maybe "config" and "content" are clear enough. But at
> think about it, and consider all the options.
>
> Anyway, the reason that this patch needs to be re-written is because
> we want underscores in place of spaces for "key_type" and because
> "us_config" is against the rules. The rest is just something to
> consider and if you find better names, then go with that but if you
> don't just fix those two things and resend.
What Dan said and:
Make sure to successfully compile the source files the patch
modifies before sending the patch.
Renaming function arguments and not renaming the uses of the
arguments in the function is not good.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-linus] BUILD SUCCESS bb5786b9286c253557a0115bc8d21879e61b7b94
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-linus branch HEAD: bb5786b9286c253557a0115bc8d21879e61b7b94 staging: rtl8188eu: Add device id for MERCUSYS MW150US v2 elapsed time: 481m configs tested: 169 configs skipped: 0 The following configs have been built successfully. More configs may be tested in the coming days. arm allmodconfig arm allnoconfig arm allyesconfig arm64allmodconfig arm64 allnoconfig arm64allyesconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 defconfig sparcallyesconfig sh rsk7269_defconfig mips fuloong2e_defconfig s390defconfig sparc64 allnoconfig um i386_defconfig s390 zfcpdump_defconfig microblaze mmu_defconfig riscvallmodconfig i386 allnoconfig i386 alldefconfig i386 allyesconfig i386defconfig ia64 alldefconfig ia64 allmodconfig ia64 allnoconfig ia64 allyesconfig ia64defconfig c6x allyesconfig c6xevmc6678_defconfig nios2 10m50_defconfig nios2 3c120_defconfig openriscor1ksim_defconfig openrisc simple_smp_defconfig xtensa common_defconfig xtensa iss_defconfig nds32 defconfig nds32 allnoconfig cskydefconfig alpha defconfig h8300 edosk2674_defconfig h8300h8300h-sim_defconfig h8300 h8s-sim_defconfig m68k allmodconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig arc allyesconfig arc defconfig microblazenommu_defconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig powerpc rhel-kconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allnoconfig mips allyesconfig mips malta_kvm_defconfig pariscallnoconfig parisc allyesconfig pariscgeneric-32bit_defconfig pariscgeneric-64bit_defconfig x86_64 randconfig-a001-20200317 x86_64 randconfig-a002-20200317 x86_64 randconfig-a003-20200317 i386 randconfig-a001-20200317 i386 randconfig-a002-20200317 i386 randconfig-a003-20200317 alpharandconfig-a001-20200317 m68k randconfig-a001-20200317 mips randconfig-a001-20200317 nds32randconfig-a001-20200317 parisc randconfig-a001-20200317 riscvrandconfig-a001-20200317 h8300randconfig-a001-20200317 sparc64 randconfig-a001-20200317 c6x randconfig-a001-20200317 nios2randconfig-a001-20200317 microblaze randconfig-a001-20200317 csky randconfig-a001-20200317 openrisc randconfig-a001-20200317 s390 randconfig-a001-20200317 sh randconfig-a001-20200317 xtensa randconfig-a001-20200317 csky randconfig-a001-20200318 openrisc randconfig-a001-20200318 s390 randconfig-a001-20200318 sh randconfig-a001-20200318 xtensa randconfig-a001-20200318 x86_64 randconfig-b001-20200317 x86_64 randconfig-b002-20200317 x86_64 randconfig-b003-20200317 i386 randconfig-b001-20200317 i386 randconfig-b002-20200317 i386
[staging:staging-testing] BUILD SUCCESS ba839b32d6f76a68919ed838e9375c47ca05a91a
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: ba839b32d6f76a68919ed838e9375c47ca05a91a staging: media: hantro: remove parentheses elapsed time: 575m configs tested: 192 configs skipped: 0 The following configs have been built successfully. More configs may be tested in the coming days. arm allmodconfig arm allnoconfig arm allyesconfig arm64allmodconfig arm64 allnoconfig arm64allyesconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 defconfig sparcallyesconfig sh rsk7269_defconfig mips fuloong2e_defconfig s390defconfig m68k multi_defconfig mips malta_kvm_defconfig s390 allnoconfig sparc64 allnoconfig s390 allyesconfig s390 zfcpdump_defconfig microblaze mmu_defconfig riscvallmodconfig i386 allnoconfig i386 alldefconfig i386 allyesconfig i386defconfig ia64 alldefconfig ia64 allmodconfig ia64 allnoconfig ia64 allyesconfig ia64defconfig nios2 3c120_defconfig nios2 10m50_defconfig c6xevmc6678_defconfig xtensa iss_defconfig c6x allyesconfig xtensa common_defconfig openrisc simple_smp_defconfig openriscor1ksim_defconfig alpha defconfig cskydefconfig nds32 allnoconfig nds32 defconfig h8300 h8s-sim_defconfig h8300 edosk2674_defconfig m68k m5475evb_defconfig m68k allmodconfig h8300h8300h-sim_defconfig m68k sun3_defconfig arc allyesconfig arc defconfig microblazenommu_defconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig powerpc rhel-kconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allnoconfig mips allyesconfig pariscallnoconfig parisc allyesconfig pariscgeneric-32bit_defconfig pariscgeneric-64bit_defconfig x86_64 randconfig-a001-20200317 x86_64 randconfig-a002-20200317 x86_64 randconfig-a003-20200317 i386 randconfig-a001-20200317 i386 randconfig-a002-20200317 i386 randconfig-a003-20200317 alpharandconfig-a001-20200317 m68k randconfig-a001-20200317 mips randconfig-a001-20200317 nds32randconfig-a001-20200317 parisc randconfig-a001-20200317 riscvrandconfig-a001-20200317 h8300randconfig-a001-20200317 sparc64 randconfig-a001-20200317 c6x randconfig-a001-20200317 nios2randconfig-a001-20200317 microblaze randconfig-a001-20200317 c6x randconfig-a001-20200318 h8300randconfig-a001-20200318 microblaze randconfig-a001-20200318 nios2randconfig-a001-20200318 sparc64 randconfig-a001-20200318 xtensa randconfig-a001-20200317 openrisc randconfig-a001-20200317 csky randconfig-a001-20200317 sh randconfig-a001-20200317 s390 randconfig-a001-20200317 csky randconfig-a001-20200318 openrisc randconfig-a001-20200318 s390 randconfig-a001-20200318 sh randconfig-a001-20200318 xtensa randconfig-a001
[staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: ba839b32d6f76a68919ed838e9375c47ca05a91a
commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media:
hantro: remove parentheses
reproduce:
# apt-get install sparse
# sparse version:
git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
>> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
drivers/ide/ide-gd.c:364:10: sparse: also defined here
--
>> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined twice
drivers/scsi/sr.c:691:10: sparse: also defined here
--
>> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry
>> defined twice
drivers/block/paride/pcd.c:279:10: sparse: also defined here
--
>> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
>> 'rt1015_aif_dai_ops' was not declared. Should it be static?
>> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai' was
>> not declared. Should it be static?
--
>> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
>> 'nft_pipapo_get' was not declared. Should it be static?
vim +362 drivers/ide/ide-gd.c
c103d6ee69f93e Arnd Bergmann 2019-03-15 357
83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const struct
block_device_operations ide_gd_ops = {
5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
= THIS_MODULE,
6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
= ide_gd_unlocked_open,
b2f21e057dfbaa Al Viro 2008-10-16 361.release
= ide_gd_release,
8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
= ide_gd_ioctl,
c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef CONFIG_COMPAT
c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
= ide_gd_compat_ioctl,
c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
= ide_gd_getgeo,
5b03a1b140e13a Tejun Heo 2011-03-09 367.check_events
= ide_gd_check_events,
c3e33e043f5e9c Tejun Heo 2010-05-15 368
.unlock_native_capacity = ide_gd_unlock_native_capacity,
5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
.revalidate_disk= ide_gd_revalidate_disk
5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
:: The code at line 362 was first introduced by commit
:: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into
.locked_ioctl
:: TO: Arnd Bergmann
:: CC: Jens Axboe
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing 222/222] drivers/mtd/nand/raw/nand_legacy.c:42:17: sparse: warning: cast from restricted __le16
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: ba839b32d6f76a68919ed838e9375c47ca05a91a
commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media:
hantro: remove parentheses
reproduce:
# apt-get install sparse
# sparse version:
git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
>> drivers/mtd/nand/raw/nand_legacy.c:42:17: sparse: warning: cast from
>> restricted __le16
vim +42 drivers/mtd/nand/raw/nand_legacy.c
3d4af7c195850c Boris Brezillon 2018-09-07 32
3d4af7c195850c Boris Brezillon 2018-09-07 33 /**
3d4af7c195850c Boris Brezillon 2018-09-07 34 * nand_read_byte16 - [DEFAULT]
read one byte endianness aware from the chip
3d4af7c195850c Boris Brezillon 2018-09-07 35 * @chip: NAND chip object
3d4af7c195850c Boris Brezillon 2018-09-07 36 *
3d4af7c195850c Boris Brezillon 2018-09-07 37 * Default read function for
16bit buswidth with endianness conversion.
3d4af7c195850c Boris Brezillon 2018-09-07 38 *
3d4af7c195850c Boris Brezillon 2018-09-07 39 */
3d4af7c195850c Boris Brezillon 2018-09-07 40 static uint8_t
nand_read_byte16(struct nand_chip *chip)
3d4af7c195850c Boris Brezillon 2018-09-07 41 {
3d4af7c195850c Boris Brezillon 2018-09-07 @42 return (uint8_t)
cpu_to_le16(readw(chip->legacy.IO_ADDR_R));
3d4af7c195850c Boris Brezillon 2018-09-07 43 }
3d4af7c195850c Boris Brezillon 2018-09-07 44
:: The code at line 42 was first introduced by commit
:: 3d4af7c195850cfccaddc2cf03b010b95236b695 mtd: rawnand: Move legacy code
to nand_legacy.c
:: TO: Boris Brezillon
:: CC: Miquel Raynal
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media:
> hantro: remove parentheses
> reproduce:
> # apt-get install sparse
> # sparse version:
> git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined
> >> twice
>drivers/ide/ide-gd.c:364:10: sparse: also defined here
> --
> >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined twice
>drivers/scsi/sr.c:691:10: sparse: also defined here
> --
> >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry
> >> defined twice
>drivers/block/paride/pcd.c:279:10: sparse: also defined here
> --
> >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai' was
> >> not declared. Should it be static?
> --
> >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> >> 'nft_pipapo_get' was not declared. Should it be static?
>
> vim +362 drivers/ide/ide-gd.c
>
> c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const struct
> block_device_operations ide_gd_ops = {
> 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359 .owner
> = THIS_MODULE,
> 6e9624b8caec29 Arnd Bergmann 2010-08-07 360 .open
> = ide_gd_unlocked_open,
> b2f21e057dfbaa Al Viro 2008-10-16 361 .release
> = ide_gd_release,
> 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362 .ioctl
> = ide_gd_ioctl,
> c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef CONFIG_COMPAT
> c103d6ee69f93e Arnd Bergmann 2019-03-15 364 .ioctl
> = ide_gd_compat_ioctl,
> c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366 .getgeo
> = ide_gd_getgeo,
> 5b03a1b140e13a Tejun Heo 2011-03-09 367 .check_events
> = ide_gd_check_events,
> c3e33e043f5e9c Tejun Heo 2010-05-15 368
> .unlock_native_capacity = ide_gd_unlock_native_capacity,
> 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> .revalidate_disk= ide_gd_revalidate_disk
> 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
>
> :: The code at line 362 was first introduced by commit
> :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into
> .locked_ioctl
Why is 0-day starting to spit out sparse warnings for things that have
nothing to do with the specific patch, or tree?
False-positive errors are the worst, please fix.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > staging-testing
> > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media:
> > hantro: remove parentheses
> > reproduce:
> > # apt-get install sparse
> > # sparse version:
> > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined
> > >> twice
> >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > --
> > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined
> > >> twice
> >drivers/scsi/sr.c:691:10: sparse: also defined here
> > --
> > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry
> > >> defined twice
> >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > --
> > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai'
> > >> was not declared. Should it be static?
> > --
> > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > >> 'nft_pipapo_get' was not declared. Should it be static?
> >
> > vim +362 drivers/ide/ide-gd.c
> >
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const
> > struct block_device_operations ide_gd_ops = {
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
> > = THIS_MODULE,
> > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
> > = ide_gd_unlocked_open,
> > b2f21e057dfbaa Al Viro 2008-10-16 361.release
> > = ide_gd_release,
> > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
> > = ide_gd_ioctl,
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > CONFIG_COMPAT
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
> > = ide_gd_compat_ioctl,
> > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
> > = ide_gd_getgeo,
> > 5b03a1b140e13a Tejun Heo 2011-03-09 367.check_events
> > = ide_gd_check_events,
> > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > .revalidate_disk= ide_gd_revalidate_disk
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> >
> > :: The code at line 362 was first introduced by commit
> > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into
> > .locked_ioctl
>
> Why is 0-day starting to spit out sparse warnings for things that have
> nothing to do with the specific patch, or tree?
thanks for the input, Greg, we will check this to avoid
false positive.
>
> False-positive errors are the worst, please fix.
>
> greg k-h
> ___
> kbuild-all mailing list -- kbuild-...@lists.01.org
> To unsubscribe send an email to kbuild-all-le...@lists.01.org
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > staging-testing
> > > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging:
> > > media: hantro: remove parentheses
> > > reproduce:
> > > # apt-get install sparse
> > > # sparse version:
> > > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > make ARCH=x86_64 allmodconfig
> > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > >
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry
> > > >> defined twice
> > >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > > --
> > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined
> > > >> twice
> > >drivers/scsi/sr.c:691:10: sparse: also defined here
> > > --
> > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry
> > > >> defined twice
> > >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > > --
> > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai'
> > > >> was not declared. Should it be static?
> > > --
> > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > > >> 'nft_pipapo_get' was not declared. Should it be static?
> > >
> > > vim +362 drivers/ide/ide-gd.c
> > >
> > > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const
> > > struct block_device_operations ide_gd_ops = {
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359 .owner
> > > = THIS_MODULE,
> > > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360 .open
> > > = ide_gd_unlocked_open,
> > > b2f21e057dfbaa Al Viro 2008-10-16 361
> > > .release= ide_gd_release,
> > > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362 .ioctl
> > > = ide_gd_ioctl,
> > > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > > CONFIG_COMPAT
> > > c103d6ee69f93e Arnd Bergmann 2019-03-15 364 .ioctl
> > > = ide_gd_compat_ioctl,
> > > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366 .getgeo
> > > = ide_gd_getgeo,
> > > 5b03a1b140e13a Tejun Heo 2011-03-09 367
> > > .check_events = ide_gd_check_events,
> > > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > > .revalidate_disk= ide_gd_revalidate_disk
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> > >
> > > :: The code at line 362 was first introduced by commit
> > > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into
> > > .locked_ioctl
> >
> > Why is 0-day starting to spit out sparse warnings for things that have
> > nothing to do with the specific patch, or tree?
> thanks for the input, Greg, we will check this to avoid
> false positive.
This was not the only false-positive report I got this morning, so
something went wrong on your end that started spitting out new ones :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 07:17:40AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> > On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > > tree:
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > > staging-testing
> > > > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging:
> > > > media: hantro: remove parentheses
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version:
> > > > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > make ARCH=x86_64 allmodconfig
> > > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > > >
> > > > If you fix the issue, kindly add following tag
> > > > Reported-by: kbuild test robot
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry
> > > > >> defined twice
> > > >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > > > --
> > > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined
> > > > >> twice
> > > >drivers/scsi/sr.c:691:10: sparse: also defined here
> > > > --
> > > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer
> > > > >> entry defined twice
> > > >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > > > --
> > > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > > > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol
> > > > >> 'rt1015_dai' was not declared. Should it be static?
> > > > --
> > > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > > > >> 'nft_pipapo_get' was not declared. Should it be static?
> > > >
> > > > vim +362 drivers/ide/ide-gd.c
> > > >
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > > > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static const
> > > > struct block_device_operations ide_gd_ops = {
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359.owner
> > > > = THIS_MODULE,
> > > > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360.open
> > > > = ide_gd_unlocked_open,
> > > > b2f21e057dfbaa Al Viro 2008-10-16 361
> > > > .release= ide_gd_release,
> > > > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362.ioctl
> > > > = ide_gd_ioctl,
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > > > CONFIG_COMPAT
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 364.ioctl
> > > > = ide_gd_compat_ioctl,
> > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366.getgeo
> > > > = ide_gd_getgeo,
> > > > 5b03a1b140e13a Tejun Heo 2011-03-09 367
> > > > .check_events = ide_gd_check_events,
> > > > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > > > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > > > .revalidate_disk= ide_gd_revalidate_disk
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> > > >
> > > > :: The code at line 362 was first introduced by commit
> > > > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL
> > > > into .locked_ioctl
> > >
> > > Why is 0-day starting to spit out sparse warnings for things that have
> > > nothing to do with the specific patch, or tree?
> > thanks for the input, Greg, we will check this to avoid
> > false positive.
>
> This was not the only false-positive report I got this morning, so
> something went wrong on your end that started spitting out new ones :(
sorry for the noise, we will go through the reports sent to you in recent
days to check. If it is handy for you to fwd me the "wrong" mail, it
can also help me address the problem.
One issue relates to "ERROR: modpost: "sysrq_mask"
[drivers/tty/serial/serial_core.ko] undefined"
is caused by modpost logging interface change, we had disabled this
build false positive yestesday, and we will look for a solution for this soon.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [kbuild-all] Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
On Wed, Mar 18, 2020 at 02:42:31PM +0800, Philip Li wrote:
> On Wed, Mar 18, 2020 at 07:17:40AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> > > On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > > > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > > > tree:
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > > > staging-testing
> > > > > head: ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging:
> > > > > media: hantro: remove parentheses
> > > > > reproduce:
> > > > > # apt-get install sparse
> > > > > # sparse version:
> > > > > git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > > > make ARCH=x86_64 allmodconfig
> > > > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > > > >
> > > > > If you fix the issue, kindly add following tag
> > > > > Reported-by: kbuild test robot
> > > > >
> > > > > All warnings (new ones prefixed by >>):
> > > > >
> > > > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry
> > > > > >> defined twice
> > > > >drivers/ide/ide-gd.c:364:10: sparse: also defined here
> > > > > --
> > > > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry
> > > > > >> defined twice
> > > > >drivers/scsi/sr.c:691:10: sparse: also defined here
> > > > > --
> > > > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer
> > > > > >> entry defined twice
> > > > >drivers/block/paride/pcd.c:279:10: sparse: also defined here
> > > > > --
> > > > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol
> > > > > >> 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol
> > > > > >> 'rt1015_dai' was not declared. Should it be static?
> > > > > --
> > > > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol
> > > > > >> 'nft_pipapo_get' was not declared. Should it be static?
> > > > >
> > > > > vim +362 drivers/ide/ide-gd.c
> > > > >
> > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 357
> > > > > 83d5cde47dedf0 Alexey Dobriyan 2009-09-21 358 static
> > > > > const struct block_device_operations ide_gd_ops = {
> > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 359 .owner
> > > > > = THIS_MODULE,
> > > > > 6e9624b8caec29 Arnd Bergmann 2010-08-07 360 .open
> > > > > = ide_gd_unlocked_open,
> > > > > b2f21e057dfbaa Al Viro 2008-10-16 361
> > > > > .release= ide_gd_release,
> > > > > 8a6cfeb6deca3a Arnd Bergmann 2010-07-08 @362 .ioctl
> > > > > = ide_gd_ioctl,
> > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 363 #ifdef
> > > > > CONFIG_COMPAT
> > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 364 .ioctl
> > > > > = ide_gd_compat_ioctl,
> > > > > c103d6ee69f93e Arnd Bergmann 2019-03-15 365 #endif
> > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 366 .getgeo
> > > > > = ide_gd_getgeo,
> > > > > 5b03a1b140e13a Tejun Heo 2011-03-09 367
> > > > > .check_events = ide_gd_check_events,
> > > > > c3e33e043f5e9c Tejun Heo 2010-05-15 368
> > > > > .unlock_native_capacity = ide_gd_unlock_native_capacity,
> > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 369
> > > > > .revalidate_disk= ide_gd_revalidate_disk
> > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 370 };
> > > > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17 371
> > > > >
> > > > > :: The code at line 362 was first introduced by commit
> > > > > :: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL
> > > > > into .locked_ioctl
> > > >
> > > > Why is 0-day starting to spit out sparse warnings for things that have
> > > > nothing to do with the specific patch, or tree?
> > > thanks for the input, Greg, we will check this to avoid
> > > false positive.
> >
> > This was not the only false-positive report I got this morning, so
> > something went wrong on your end that started spitting out new ones :(
> sorry for the noise, we will go through the reports sent to you in recent
> days to check. If it is handy for you to fwd me the "wrong" mail, it
> can also help me address the problem.
Subject: [staging:staging-testing 222/222]
drivers/mtd/nand/raw/nand_legacy.c:42:17: sparse: warning: cast from restricted
__le16
Message-ID: <202003180728.te9zfdlb%...@intel.com>
is also incorrect
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
