[PATCH] staging: greybus: bootrom: fix uninitialized variables
fix uninitialized variables issue found using static code analysis tool (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off-by: Saurav Girepunje --- drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index a8efb86..9eabeb3 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -245,7 +245,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) struct gb_bootrom_get_firmware_request *firmware_request; struct gb_bootrom_get_firmware_response *firmware_response; struct device *dev = &op->connection->bundle->dev; - unsigned int offset, size; + unsigned int offset = 0, size = 0; enum next_request_type next_request; int ret = 0; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables
On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: > fix uninitialized variables issue found using static code analysis tool Which tool is that? > (error) Uninitialized variable: offset > (error) Uninitialized variable: size > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/greybus/bootrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/bootrom.c > b/drivers/staging/greybus/bootrom.c > index a8efb86..9eabeb3 100644 > --- a/drivers/staging/greybus/bootrom.c > +++ b/drivers/staging/greybus/bootrom.c > @@ -245,7 +245,7 @@ static int gb_bootrom_get_firmware(struct gb_operation > *op) > struct gb_bootrom_get_firmware_request *firmware_request; > struct gb_bootrom_get_firmware_response *firmware_response; > struct device *dev = &op->connection->bundle->dev; > - unsigned int offset, size; > + unsigned int offset = 0, size = 0; > enum next_request_type next_request; > int ret = 0; I think this has come up in the past, and while the code in question is overly complicated and confuses static checkers as well as humans, it looks correct to me. Please make sure to verify the output of any tools before posting patches based on them. Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:driver-core-next] BUILD INCOMPLETE 72a9cc952f123948ca1d1011a12e5e1312140b68
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next branch HEAD: 72a9cc952f123948ca1d1011a12e5e1312140b68 devtmpfs: factor out common tail of devtmpfs_{create,delete}_node TIMEOUT after 3863m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doing bisects for _other_ trees. The branch will get more complete coverage and possible error reports when our build infrastructure is restored or catches up. There will be no more build success notification for this branch head, but you can expect reasonably good test coverage after waiting for 1 day. configs timed out: 70 alpha defconfig arm allmodconfig arm allnoconfig arm allyesconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64allmodconfig cskydefconfig h8300 edosk2674_defconfig h8300h8300h-sim_defconfig h8300 h8s-sim_defconfig i386 alldefconfig i386 allnoconfig i386 allyesconfig i386defconfig ia64 alldefconfig ia64 allmodconfig ia64 allnoconfig ia64 allyesconfig ia64defconfig m68k allmodconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allnoconfig mips allyesconfig mips fuloong2e_defconfig mips malta_kvm_defconfig nds32 allnoconfig nds32 defconfig pariscallnoconfig pariscallyesonfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig powerpc defconfig powerpc ppc64_defconfig riscvallmodconfig riscv allnoconfig riscvallyesconfig riscv defconfig riscvnommu_virt_defconfig riscv rv32_defconfig s390 alldefconfig s390 allmodconfig s390 allnoconfig s390 allyesconfig s390 debug_defconfig s390defconfig s390 zfcpdump_defconfig sh allmodconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig sparc64 allmodconfig sparc64 allnoconfig sparc64 allyesconfig sparc64 defconfig um defconfig um i386_defconfig um x86_64_defconfig configs tested: 23 configs skipped: 0 x86_64 rhel-7.2-clear arc allyesconfig microblazenommu_defconfig powerpc rhel-kconfig microblaze mmu_defconfig arc defconfig powerpc allnoconfig x86_64lkp x86_64 rhel x86_64 rhel-7.6 x86_64 fedora-25 x86_64 kexec arm64 defconfig arm64allyesconfig arm64 allnoconfig xtensa common_defconfig openriscor1ksim_defconfig nios2 3c120_defconfig xtensa iss_defconfig c6xevmc6678_defconfig c6x allyesconfig nios2 10m50_de
Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables
On 25/01/20 11:00 +0100, Johan Hovold wrote: On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: fix uninitialized variables issue found using static code analysis tool Which tool is that? (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off-by: Saurav Girepunje --- drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index a8efb86..9eabeb3 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -245,7 +245,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) struct gb_bootrom_get_firmware_request *firmware_request; struct gb_bootrom_get_firmware_response *firmware_response; struct device *dev = &op->connection->bundle->dev; - unsigned int offset, size; + unsigned int offset = 0, size = 0; enum next_request_type next_request; int ret = 0; I think this has come up in the past, and while the code in question is overly complicated and confuses static checkers as well as humans, it looks correct to me. Please make sure to verify the output of any tools before posting patches based on them. Johan I used cppcheck tool . ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[RESEND PATCH] staging: exfat: Fix alignment warnings
Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat_blkdev.c | 4 ++-- drivers/staging/exfat/exfat_core.c | 29 ++-- drivers/staging/exfat/exfat_super.c | 2 +- 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/exfat/exfat_blkdev.c b/drivers/staging/exfat/exfat_blkdev.c index 7bcd98b13109..3068bfda39e4 100644 --- a/drivers/staging/exfat/exfat_blkdev.c +++ b/drivers/staging/exfat/exfat_blkdev.c @@ -31,7 +31,7 @@ void exfat_bdev_close(struct super_block *sb) } int exfat_bdev_read(struct super_block *sb, sector_t secno, struct buffer_head **bh, - u32 num_secs, bool read) + u32 num_secs, bool read) { struct bd_info_t *p_bd = &(EXFAT_SB(sb)->bd_info); struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info); @@ -66,7 +66,7 @@ int exfat_bdev_read(struct super_block *sb, sector_t secno, struct buffer_head * } int exfat_bdev_write(struct super_block *sb, sector_t secno, struct buffer_head *bh, - u32 num_secs, bool sync) +u32 num_secs, bool sync) { s32 count; struct buffer_head *bh2; diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c index 794000e7bc6f..754407c738b7 100644 --- a/drivers/staging/exfat/exfat_core.c +++ b/drivers/staging/exfat/exfat_core.c @@ -250,7 +250,7 @@ static u32 test_alloc_bitmap(struct super_block *sb, u32 clu) } static s32 exfat_alloc_cluster(struct super_block *sb, s32 num_alloc, - struct chain_t *p_chain) + struct chain_t *p_chain) { s32 num_clusters = 0; u32 hint_clu, new_clu, last_clu = CLUSTER_32(~0); @@ -329,7 +329,7 @@ static s32 exfat_alloc_cluster(struct super_block *sb, s32 num_alloc, } static void exfat_free_cluster(struct super_block *sb, struct chain_t *p_chain, - s32 do_relse) + s32 do_relse) { s32 num_clusters = 0; u32 clu; @@ -920,7 +920,7 @@ static void exfat_set_entry_size(struct dentry_t *p_entry, u64 size) } static void exfat_get_entry_time(struct dentry_t *p_entry, struct timestamp_t *tp, - u8 mode) +u8 mode) { u16 t = 0x00, d = 0x21; struct file_dentry_t *ep = (struct file_dentry_t *)p_entry; @@ -949,7 +949,7 @@ static void exfat_get_entry_time(struct dentry_t *p_entry, struct timestamp_t *t } static void exfat_set_entry_time(struct dentry_t *p_entry, struct timestamp_t *tp, - u8 mode) +u8 mode) { u16 t, d; struct file_dentry_t *ep = (struct file_dentry_t *)p_entry; @@ -1013,7 +1013,7 @@ static void init_name_entry(struct name_dentry_t *ep, u16 *uniname) } static s32 exfat_init_dir_entry(struct super_block *sb, struct chain_t *p_dir, -s32 entry, u32 type, u32 start_clu, u64 size) + s32 entry, u32 type, u32 start_clu, u64 size) { sector_t sector; u8 flags; @@ -1089,7 +1089,7 @@ static s32 exfat_init_ext_entry(struct super_block *sb, struct chain_t *p_dir, } static void exfat_delete_dir_entry(struct super_block *sb, struct chain_t *p_dir, - s32 entry, s32 order, s32 num_entries) + s32 entry, s32 order, s32 num_entries) { int i; sector_t sector; @@ -1256,7 +1256,7 @@ static s32 _walk_fat_chain(struct super_block *sb, struct chain_t *p_dir, } static s32 find_location(struct super_block *sb, struct chain_t *p_dir, s32 entry, - sector_t *sector, s32 *offset) +sector_t *sector, s32 *offset) { s32 off, ret; u32 clu = 0; @@ -1492,7 +1492,8 @@ void release_entry_set(struct entry_set_cache_t *es) /* search EMPTY CONTINUOUS "num_entries" entries */ static s32 search_deleted_or_unused_entry(struct super_block *sb, - struct chain_t *p_dir, s32 num_entries) + struct chain_t *p_dir, + s32 num_entries) { int i, dentry, num_empty = 0; s32 dentries_per_clu; @@ -1668,7 +1669,7 @@ static s32 find_empty_entry(struct inode *inode, struct chain_t *p_dir, s32 num_ } static s32 extract_uni_name_from_name_entry(struct name_dentry_t *ep, u16 *uniname, -s32 order) + s32 order) { int i, len = 0; @@ -1690,8 +1691,8 @@ static s32 extract_uni_name_from_name_entry(struct name_dentry_t *ep, u16 *unina * -2 : entry with the name does not exist */ static s32 exfat_find_dir_entry(struct super_block *sb, struct chain_t *p_dir, -struct uni_name_t *p_uniname, s32 num_entries, -
[PATCH] staging: comedi: drivers: fix condition with no effect
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/comedi/drivers/das1800.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c index f16aa7e9..7ab72e8 100644 --- a/drivers/staging/comedi/drivers/das1800.c +++ b/drivers/staging/comedi/drivers/das1800.c @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, outb(DAC(i), dev->iobase + DAS1800_SELECT); outw(0, dev->iobase + DAS1800_DAC); } - } else if (board->id == DAS1800_ID_AO) { - /* -* 'ao' boards have waveform analog outputs that are not -* currently supported. -*/ - s->type = COMEDI_SUBD_UNUSED; } else { s->type = COMEDI_SUBD_UNUSED; } -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8723bs: core: fix condition with no effect
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 71fcb46..5f110c3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2771,18 +2771,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe DBG_871X("+rtw_update_ht_cap()\n"); /* maybe needs check if ap supports rx ampdu. */ - if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) { - if (pregistrypriv->wifi_spec == 1) { - /* remove this part because testbed AP should disable RX AMPDU */ - /* phtpriv->ampdu_enable = false; */ - phtpriv->ampdu_enable = true; - } else { - phtpriv->ampdu_enable = true; - } - } else if (pregistrypriv->ampdu_enable == 2) { - /* remove this part because testbed AP should disable RX AMPDU */ - /* phtpriv->ampdu_enable = true; */ - } + if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) + phtpriv->ampdu_enable = true; /* check Max Rx A-MPDU Size */ len = 0; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8723bs: hal: fix condition with no effect
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c index 02da0a8..8dfa9b9 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -1610,8 +1610,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust( HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(13); else if (maxInterval == 2) HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(14); - else if (maxInterval == 3) - HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15); else HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15); } else { @@ -1619,8 +1617,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust( HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(9); else if (maxInterval == 2) HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(10); - else if (maxInterval == 3) - HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11); else HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11); } @@ -1630,8 +1626,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust( HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(5); else if (maxInterval == 2) HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(6); - else if (maxInterval == 3) - HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7); else HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7); } else { @@ -1639,8 +1633,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust( HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(1); else if (maxInterval == 2) HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(2); - else if (maxInterval == 3) - HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3); else HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3); } -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6656: fix Unneeded variable: "ret"
Remove unneeded variable "ret". Issues reported by coccicheck. Signed-off-by: Saurav Girepunje --- drivers/staging/vt6656/card.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 7958fc1..654cebc 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -719,7 +719,6 @@ int vnt_radio_power_off(struct vnt_private *priv) */ int vnt_radio_power_on(struct vnt_private *priv) { - int ret = 0; vnt_exit_deep_sleep(priv); @@ -739,7 +738,7 @@ int vnt_radio_power_on(struct vnt_private *priv) vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); - return ret; + return 0; } void vnt_set_bss_mode(struct vnt_private *priv) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing] BUILD SUCCESS fc157998b8257fb9cfe753e7f4af1411da995c9b
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: fc157998b8257fb9cfe753e7f4af1411da995c9b staging: most: usb: check for NULL device elapsed time: 2177m configs tested: 275 configs skipped: 0 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig cskydefconfig nds32 allnoconfig nds32 defconfig um defconfig um i386_defconfig um x86_64_defconfig riscvallmodconfig riscv allnoconfig riscvallyesconfig riscv defconfig riscvnommu_virt_defconfig riscv rv32_defconfig h8300 edosk2674_defconfig h8300h8300h-sim_defconfig h8300 h8s-sim_defconfig m68k allmodconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig x86_64 fedora-25 x86_64 kexec x86_64lkp x86_64 rhel x86_64 rhel-7.2-clear x86_64 rhel-7.6 sh allmodconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig x86_64 randconfig-h001-20200125 x86_64 randconfig-h002-20200125 x86_64 randconfig-h003-20200125 i386 randconfig-h001-20200125 i386 randconfig-h002-20200125 i386 randconfig-h003-20200125 x86_64 randconfig-f001-20200125 x86_64 randconfig-f002-20200125 x86_64 randconfig-f003-20200125 i386 randconfig-f001-20200125 i386 randconfig-f002-20200125 i386 randconfig-f003-20200125 arc randconfig-a001-20200125 arm randconfig-a001-20200125 arm64randconfig-a001-20200125 ia64 randconfig-a001-20200125 powerpc randconfig-a001-20200125 sparcrandconfig-a001-20200125 sparcallyesconfig sparc defconfig sparc64 allmodconfig sparc64 allnoconfig sparc64 allyesconfig sparc64 defconfig i386 alldefconfig i386 allnoconfig i386 allyesconfig i386defconfig s390 alldefconfig s390 allmodconfig s390 allnoconfig s390 allyesconfig s390 debug_defconfig s390defconfig s390 zfcpdump_defconfig x86_64 randconfig-g001-20200126 x86_64 randconfig-g002-20200126 x86_64 randconfig-g003-20200126 i386 randconfig-g001-20200126 i386 randconfig-g002-20200126 i386 randconfig-g003-20200126 x86_64 randconfig-h001-20200126 x86_64 randconfig-h002-20200126 x86_64 randconfig-h003-20200126 i386 randconfig-h001-20200126 i386 randconfig-h002-20200126 i386 randconfig-h003-20200126 alpharandconfig-a001-20200125 m68k randconfig-a001-20200125 mips randconfig-a001-20200125 nds32randconfig-a001-20200125 parisc randconfig-a001-20200125 riscvrandconfig-a001-20200125 mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allnoconfig mips allyesconfig mips fuloong2e_defconfig mips malta_kvm_defconfig x86_64 randconfig-b001-20200125 x86_64 randconfig-b002-20200125 x86_64 randconfig-b003-20200125 i386 randconfig-b001-20200125 i386 randconfig-b002-20200125 i386 randconfig-b003-20200125 arm allmodconfig arm64allmodconfig c6x allyesconfig c6x
Re: [RESEND PATCH] staging: exfat: Fix alignment warnings
On Sat, Jan 25, 2020 at 05:49:48PM +0530, Pragat Pandya wrote: > Fix checkpatch warning "Alignment should match open parenthesis". > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat_blkdev.c | 4 ++-- > drivers/staging/exfat/exfat_core.c | 29 ++-- > drivers/staging/exfat/exfat_super.c | 2 +- > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/drivers/staging/exfat/exfat_blkdev.c > b/drivers/staging/exfat/exfat_blkdev.c > index 7bcd98b13109..3068bfda39e4 100644 > --- a/drivers/staging/exfat/exfat_blkdev.c > +++ b/drivers/staging/exfat/exfat_blkdev.c > @@ -31,7 +31,7 @@ void exfat_bdev_close(struct super_block *sb) > } > > int exfat_bdev_read(struct super_block *sb, sector_t secno, struct > buffer_head **bh, > - u32 num_secs, bool read) > + u32 num_secs, bool read) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel