[PATCH 1/3] sm750fb: Fix Avoid CamelCase
Change names of variables and functions into proper names,
according to coding style.
Patch upholds compileability by considering dependencies.
Co-developed-by: Daniel Bauer
Signed-off-by: Daniel Bauer
Signed-off-by: Sven Leykauf
---
drivers/staging/sm750fb/ddk750_dvi.c| 50 +++
drivers/staging/sm750fb/ddk750_dvi.h| 64 -
drivers/staging/sm750fb/ddk750_sii164.c | 171
drivers/staging/sm750fb/ddk750_sii164.h | 40 +++---
4 files changed, 162 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c
b/drivers/staging/sm750fb/ddk750_dvi.c
index cd564ea40779..930f56d91474 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -11,41 +11,41 @@
* function API. Please set the function pointer to NULL whenever the function
* is not supported.
*/
-static struct dvi_ctrl_device g_dcftSupportedDviController[] = {
+static struct dvi_ctrl_device g_dcft_supported_dvi_controller[] = {
#ifdef DVI_CTRL_SII164
{
- .pfnInit = sii164InitChip,
- .pfnGetVendorId = sii164GetVendorID,
- .pfnGetDeviceId = sii164GetDeviceID,
+ .pfn_init = sii164_init_chip,
+ .pfn_get_vendor_id = sii164_get_vendor_id,
+ .pfn_get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
- .pfnResetChip = sii164ResetChip,
- .pfnGetChipString = sii164GetChipString,
- .pfnSetPower = sii164SetPower,
- .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection,
- .pfnIsConnected = sii164IsConnected,
- .pfnCheckInterrupt = sii164CheckInterrupt,
- .pfnClearInterrupt = sii164ClearInterrupt,
+ .pfn_reset_chip = sii164_reset_chip,
+ .pfn_get_chip_string = sii164_get_chip_string,
+ .pfn_set_power = sii164_set_power,
+ .pfn_enable_hot_plug_detection =
sii164_enable_hot_plug_detection,
+ .pfn_is_connected = sii164_is_connected,
+ .pfn_check_interrupt = sii164_check_interrupt,
+ .pfn_clear_interrupt = sii164_clear_interrupt,
#endif
},
#endif
};
-int dviInit(unsigned char edge_select,
- unsigned char bus_select,
- unsigned char dual_edge_clk_select,
- unsigned char hsync_enable,
- unsigned char vsync_enable,
- unsigned char deskew_enable,
- unsigned char deskew_setting,
- unsigned char continuous_sync_enable,
- unsigned char pll_filter_enable,
- unsigned char pll_filter_value)
+int dvi_init(unsigned char edge_select,
+unsigned char bus_select,
+unsigned char dual_edge_clk_select,
+unsigned char hsync_enable,
+unsigned char vsync_enable,
+unsigned char deskew_enable,
+unsigned char deskew_setting,
+unsigned char continuous_sync_enable,
+unsigned char pll_filter_enable,
+unsigned char pll_filter_value)
{
- struct dvi_ctrl_device *pCurrentDviCtrl;
+ struct dvi_ctrl_device *p_current_dvi_ctrl;
- pCurrentDviCtrl = g_dcftSupportedDviController;
- if (pCurrentDviCtrl->pfnInit) {
- return pCurrentDviCtrl->pfnInit(edge_select,
+ p_current_dvi_ctrl = g_dcft_supported_dvi_controller;
+ if (p_current_dvi_ctrl->pfn_init) {
+ return p_current_dvi_ctrl->pfn_init(edge_select,
bus_select,
dual_edge_clk_select,
hsync_enable,
diff --git a/drivers/staging/sm750fb/ddk750_dvi.h
b/drivers/staging/sm750fb/ddk750_dvi.h
index 1c7a565b617a..d3ea365d1509 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.h
+++ b/drivers/staging/sm750fb/ddk750_dvi.h
@@ -4,54 +4,54 @@
/* dvi chip stuffs structros */
-typedef long (*PFN_DVICTRL_INIT)(unsigned char edgeSelect,
-unsigned char busSelect,
-unsigned char dualEdgeClkSelect,
-unsigned char hsyncEnable,
-unsigned char vsyncEnable,
-unsigned char deskewEnable,
-unsigned char deskewSetting,
-unsigned char continuousSyncEnable,
-unsigned char pllFilterEnable,
-unsigned char pllFilterValue);
+typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
+unsigned char bus_select,
+unsigned char dual_edge_clk_select,
+unsigned char hsync_enable,
+unsigned char vsync_enable,
+unsigned char d
[PATCH 3/3] sm750fb: Fix Overlong Line Issues
Fix issues of newly introduced overlong lines, due to name enlargement
within the former two patches.
Co-developed-by: Daniel Bauer
Signed-off-by: Daniel Bauer
Signed-off-by: Sven Leykauf
---
drivers/staging/sm750fb/ddk750_dvi.c| 24
drivers/staging/sm750fb/ddk750_sii164.c | 3 ++-
drivers/staging/sm750fb/sm750_accel.c | 8 +---
3 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c
b/drivers/staging/sm750fb/ddk750_dvi.c
index 930f56d91474..1536e252e37c 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -13,20 +13,20 @@
*/
static struct dvi_ctrl_device g_dcft_supported_dvi_controller[] = {
#ifdef DVI_CTRL_SII164
- {
- .pfn_init = sii164_init_chip,
- .pfn_get_vendor_id = sii164_get_vendor_id,
- .pfn_get_device_id = sii164_get_device_id,
+{
+ .pfn_init = sii164_init_chip,
+ .pfn_get_vendor_id = sii164_get_vendor_id,
+ .pfn_get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
- .pfn_reset_chip = sii164_reset_chip,
- .pfn_get_chip_string = sii164_get_chip_string,
- .pfn_set_power = sii164_set_power,
- .pfn_enable_hot_plug_detection =
sii164_enable_hot_plug_detection,
- .pfn_is_connected = sii164_is_connected,
- .pfn_check_interrupt = sii164_check_interrupt,
- .pfn_clear_interrupt = sii164_clear_interrupt,
+ .pfn_reset_chip = sii164_reset_chip,
+ .pfn_get_chip_string = sii164_get_chip_string,
+ .pfn_set_power = sii164_set_power,
+ .pfn_enable_hot_plug_detection = sii164_enable_hot_plug_detection,
+ .pfn_is_connected = sii164_is_connected,
+ .pfn_check_interrupt = sii164_check_interrupt,
+ .pfn_clear_interrupt = sii164_clear_interrupt,
#endif
- },
+},
#endif
};
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c
b/drivers/staging/sm750fb/ddk750_sii164.c
index 781eceb2f402..47895df1173e 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -301,7 +301,8 @@ void sii164_set_power(unsigned char power_up)
* sii164_select_hot_plug_detection_mode
* This function selects the mode of the hot plug detection.
*/
-static void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode
hot_plug_mode)
+static void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode
+ hot_plug_mode)
{
unsigned char detect_reg;
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb/sm750_accel.c
index d1f940120721..86605df163f0 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -18,7 +18,8 @@
#include "sm750.h"
#include "sm750_accel.h"
-static inline void write_dpr(struct lynx_accel *accel, int offset, u32
reg_value)
+static inline void write_dpr(struct lynx_accel *accel,
+int offset, u32 reg_value)
{
writel(reg_value, accel->dpr_base + offset);
}
@@ -354,7 +355,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char
*p_srcbuf,
write_dpr(accel, DE_PITCH,
((d_pitch / byte_per_pixel << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
- (d_pitch / byte_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10
*/
+ (d_pitch / byte_per_pixel & DE_PITCH_SOURCE_MASK));/* dpr10 */
/*
* Screen Window width in Pixels.
@@ -396,7 +397,8 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char
*p_srcbuf,
for (i = 0; i < height; i++) {
/* For each line, send the data in chunks of 4 bytes */
for (j = 0; j < (ul_4bytes_per_scan / 4); j++)
- write_dp_port(accel, *(unsigned int *)(p_srcbuf + (j *
4)));
+ write_dp_port(accel,
+ *(unsigned int *)(p_srcbuf + (j * 4)));
if (ul_bytes_remain) {
memcpy(aj_remain, p_srcbuf + ul_4bytes_per_scan,
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/3] sm750fb: Fix Avoid CamelCase
Change names of variables and functions into proper names,
according to coding style.
Patch upholds compileability by considiering dependencies.
Co-developed-by: Daniel Bauer
Signed-off-by: Daniel Bauer
Signed-off-by: Sven Leykauf
---
drivers/staging/sm750fb/ddk750_mode.c | 86 +++
drivers/staging/sm750fb/ddk750_mode.h | 2 +-
drivers/staging/sm750fb/ddk750_power.h | 10 +-
drivers/staging/sm750fb/sm750.c| 144 -
drivers/staging/sm750fb/sm750.h| 68 ++--
drivers/staging/sm750fb/sm750_accel.c | 142
drivers/staging/sm750fb/sm750_accel.h | 16 +--
drivers/staging/sm750fb/sm750_cursor.c | 18 ++--
drivers/staging/sm750fb/sm750_cursor.h | 12 +--
drivers/staging/sm750fb/sm750_hw.c | 72 ++---
10 files changed, 285 insertions(+), 285 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c
b/drivers/staging/sm750fb/ddk750_mode.c
index e00a6cb31947..b609fd9b4142 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -14,13 +14,13 @@
* in bit 29:27 of Display Control register.
*/
static unsigned long
-displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
-unsigned long dispControl)
+display_control_adjust_sm750le(struct mode_parameter *p_mode_param,
+ unsigned long disp_control)
{
unsigned long x, y;
- x = pModeParam->horizontal_display_end;
- y = pModeParam->vertical_display_end;
+ x = p_mode_param->horizontal_display_end;
+ y = p_mode_param->vertical_display_end;
/*
* SM750LE has to set up the top-left and bottom-right
@@ -42,41 +42,41 @@ displayControlAdjust_SM750LE(struct mode_parameter
*pModeParam,
*/
/* Clear bit 29:27 of display control register */
- dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK;
+ disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK;
/* Set bit 29:27 of display control register for the right clock */
/* Note that SM750LE only need to supported 7 resolutions. */
if (x == 800 && y == 600)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL41;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL41;
else if (x == 1024 && y == 768)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL65;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL65;
else if (x == 1152 && y == 864)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80;
else if (x == 1280 && y == 768)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80;
else if (x == 1280 && y == 720)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL74;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL74;
else if (x == 1280 && y == 960)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108;
else if (x == 1280 && y == 1024)
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108;
else /* default to VGA clock */
- dispControl |= CRT_DISPLAY_CTRL_CLK_PLL25;
+ disp_control |= CRT_DISPLAY_CTRL_CLK_PLL25;
/* Set bit 25:24 of display controller */
- dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT);
+ disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT);
/* Set bit 14 of display controller */
- dispControl |= DISPLAY_CTRL_CLOCK_PHASE;
+ disp_control |= DISPLAY_CTRL_CLOCK_PHASE;
- poke32(CRT_DISPLAY_CTRL, dispControl);
+ poke32(CRT_DISPLAY_CTRL, disp_control);
- return dispControl;
+ return disp_control;
}
/* only timing related registers will be programed */
-static int programModeRegisters(struct mode_parameter *pModeParam,
- struct pll_value *pll)
+static int program_mode_registers(struct mode_parameter *p_mode_param,
+ struct pll_value *pll)
{
int ret = 0;
int cnt = 0;
@@ -86,46 +86,46 @@ static int programModeRegisters(struct mode_parameter
*pModeParam,
/* programe secondary pixel clock */
poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll));
- tmp = ((pModeParam->horizontal_total - 1) <<
+ tmp = ((p_mode_param->horizontal_total - 1) <<
CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) &
CRT_HORIZONTAL_TOTAL_TOTAL_MASK;
- tmp |= (pModeParam->horizontal_display_end - 1) &
+ tmp |= (p_mode_param->horizontal_display_end - 1) &
CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK;
poke32(CRT_HORIZONTAL_TOTAL, tmp);
- tmp
Hello, 09/12/2019
Good day, My name is Reem E. Hashimy, the Emirates Minister of State and Managing Director of the United Arab Emirates (Dubai) World Expo 2020 Committee. I am writing you to manage my funds I received as financial gratification from various foreign companies I assisted to receive participation slot in the incoming Dubai World Expo 2020. The amount is $44,762,906.00 United States dollars.The cumulative deposit were given as an expression of appreciation from the various foreign companies whose applications received approval to participate in the in-coming Dubai Expo 2020. But I could not receive the various gratifications to my personal account in my country because my social status as a married Muslim lady with limitations to certain investment opportunities. For this reason, an agreement was reached with a consulting firm to keep the funds in open beneficiary account with a financial institution where it will be possible to instruct transfer of the funds to a third party account for investment purpose which is the reason I am contacting you to receive and manage the funds as my investment partner. The detail will be discuss on your indication of interest with your information and capacity to manage the fund. However, if you are not ready to take up responsibility in this partnership, do not reply to this message. Wishing you the best in the month. Reem Hashimy. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
