[PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style

2019-07-08 Thread Fatih ALTINPINAR 
Fixed a coding stlye issue. Removed braces from a single statement if
block.

Signed-off-by: Fatih ALTINPINAR 
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c 
b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index e23b39ab16c5..71a4bcbeada9 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ 
- alignment));
}
 
-   if (!precvbuf->pskb) {
+   if (!precvbuf->pskb)
DBG_871X("%s: alloc_skb fail!\n", __func__);
-   }
}
 
list_add_tail(&precvbuf->list, 
&precvpriv->free_recv_buf_queue.queue);
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: use exact allocation for dma coherent memory

2019-07-08 Thread Christoph Hellwig 
On Tue, Jul 02, 2019 at 11:48:44AM +0200, Arend Van Spriel wrote:
> You made me look ;-) Actually not touching my drivers so I'm off the hook. 
> However, I was wondering if drivers could know so I decided to look into 
> the DMA-API.txt documentation which currently states:
>
> """
> The flag parameter (dma_alloc_coherent() only) allows the caller to
> specify the ``GFP_`` flags (see kmalloc()) for the allocation (the
> implementation may choose to ignore flags that affect the location of
> the returned memory, like GFP_DMA).
> """
>
> I do expect you are going to change that description as well now that you 
> are going to issue a warning on __GFP_COMP. Maybe include that in patch 
> 15/16 where you introduce that warning.

Yes, that description needs an updated, even without this series.
I'll make sure it is more clear.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [OSSNA] Intro to kernel hacking tutorial

2019-07-08 Thread Tobin C. Harding 
On Fri, Jul 05, 2019 at 10:40:43AM +0530, Amit Kumar wrote:
> On Fri, Jul 5, 2019 at 9:02 AM Amit Kumar  wrote:
> >
> > On Fri, Jul 5, 2019 at 8:21 AM Tobin C. Harding  wrote:
> > >
> > > Hi,
> > >
> > > I am doing a tutorial at OSSNA in San Diego on getting into kernel
> > > hacking.  I'm only a couple of years deep into kernel hacking so I
> > > wanted to reach out to those more experienced than myself (and those
> > > less experienced).
> > >
> > > Is there any thing that you would really like to see covered in this
> > > tutorial?
> > >
> > > If you are a grey beard is there anything that you have been lamenting
> > > us newbies not knowing/doing?
> > >
> > > If you are a newbie is there anything that you are struggling with that
> > > you really want to learn?
> > Thank you.
> > Where can I find your tutorial?

It's not written yet :)

> I forget to tell, merely creating and sending patches is not important.
> Also I would like to know how to manage patches, using git, mutt, quilt
> and so on.
> Sending patch through git-email is good. But different versions of patch.
> Applying patch from mutt. Replying to patch recipients.

Nice suggestions thanks, will work this in.

thanks,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Procedure questions - new filesystem driver..

2019-07-08 Thread Valdis Klētnieks 
On Tue, 09 Jul 2019 01:52:20 +0100, Al Viro said:
> On Mon, Jul 08, 2019 at 08:37:42PM -0400, Valdis Klētnieks wrote:
> > I have an out-of-tree driver for the exfat file system that I beaten into 
> > shape
> > for upstreaming. The driver works, and passes sparse and checkpatch (except
> > for a number of line-too-long complaints).
> >
> > Do you want this taken straight to the fs/ tree, or through drivers/staging?
>
> First of all, post it...

OK... Ill post it as if it's going in fs/ and if people disagree, I'll repost 
it for
drivers/staging (once any other complaints have been corrected)...



pgpI3RWaVOIAl.pgp
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Procedure questions - new filesystem driver..

2019-07-08 Thread Valdis Klētnieks 
I have an out-of-tree driver for the exfat file system that I beaten into shape
for upstreaming. The driver works, and passes sparse and checkpatch (except
for a number of line-too-long complaints).

Do you want this taken straight to the fs/ tree, or through drivers/staging?


pgpPbWnt1mYai.pgp
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Procedure questions - new filesystem driver..

2019-07-08 Thread Al Viro 
On Mon, Jul 08, 2019 at 08:37:42PM -0400, Valdis Klētnieks wrote:
> I have an out-of-tree driver for the exfat file system that I beaten into 
> shape
> for upstreaming. The driver works, and passes sparse and checkpatch (except
> for a number of line-too-long complaints).
> 
> Do you want this taken straight to the fs/ tree, or through drivers/staging?

First of all, post it...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 3/3] media: dt-bindings: imx7-csi: add i.MX6UL/L support

2019-07-08 Thread Rob Herring 
On Thu,  6 Jun 2019 17:38:25 +0200, =?UTF-8?q?S=C3=A9bastien=20Szymanski?=  
wrote:
> Document "fsl,imx6ul-csi" entry.
> 
> Signed-off-by: Sébastien Szymanski 
> ---
> 
> Changes for v2:
>  - New patch to document new "fsl,imx6ul-csi" entry.
> 
>  Documentation/devicetree/bindings/media/imx7-csi.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Procedure questions - new filesystem driver..

2019-07-08 Thread Theodore Ts'o 
On Mon, Jul 08, 2019 at 08:37:42PM -0400, Valdis Klētnieks wrote:
> I have an out-of-tree driver for the exfat file system that I beaten into 
> shape
> for upstreaming. The driver works, and passes sparse and checkpatch (except
> for a number of line-too-long complaints).
> 
> Do you want this taken straight to the fs/ tree, or through drivers/staging?

How have you dealt with the patent claims which Microsoft has
asserted[1] on the exFAT file system design?

[1] 
https://www.microsoft.com/en-us/legal/intellectualproperty/mtl/exfat-licensing.aspx

I am not making any claims about the validity of Microsoft's patent
assertions on exFAT, one way or another.  But it might be a good idea
for some laywers from the Linux Foundation to render some legal advice
to their employees (namely Greg K-H and Linus Torvalds) regarding the
advisability of taking exFAT into the official Linux tree.

Personally, if Microsoft is going to be unfriendly about not wanting
others to use their file system technology by making patent claims,
why should we reward them by making their file system better by
improvings its interoperability?  (My personal opinion only.)

Cheers,

- Ted

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel