RE: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl
>
> On Tue, Apr 16, 2019 at 10:19:47PM +0200, Arnd Bergmann wrote:
> > Each of these drivers has a copy of the same trivial helper function
> > to convert the pointer argument and then call the native ioctl handler.
> >
> > We now have a generic implementation of that, so use it.
> >
> > Acked-by: Greg Kroah-Hartman
> > Reviewed-by: Jarkko Sakkinen
> > Reviewed-by: Jason Gunthorpe
> > Signed-off-by: Arnd Bergmann
>
> Acked-by: Michael S. Tsirkin
Acked-by: Tomas Winkler
>
> > ---
> > drivers/char/ppdev.c | 12 +-
> > drivers/char/tpm/tpm_vtpm_proxy.c | 12 +-
> > drivers/firewire/core-cdev.c | 12 +-
> > drivers/hid/usbhid/hiddev.c | 11 +
> > drivers/hwtracing/stm/core.c | 12 +-
> > drivers/misc/mei/main.c | 22 +
> > drivers/mtd/ubi/cdev.c| 36 +++-
> > drivers/net/tap.c | 12 +-
> > drivers/staging/pi433/pi433_if.c | 12 +-
> > drivers/usb/core/devio.c | 16 +
> > drivers/vfio/vfio.c | 39 +++
> > drivers/vhost/net.c | 12 +-
> > drivers/vhost/scsi.c | 12 +-
> > drivers/vhost/test.c | 12 +-
> > drivers/vhost/vsock.c | 12 +-
> > fs/fat/file.c | 13 +--
> > 16 files changed, 20 insertions(+), 237 deletions(-)
> >
> > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index
> > 1ae77b41050a..e96c8d9623e0 100644
> > --- a/drivers/char/ppdev.c
> > +++ b/drivers/char/ppdev.c
> > @@ -674,14 +674,6 @@ static long pp_ioctl(struct file *file, unsigned int
> cmd, unsigned long arg)
> > return ret;
> > }
> >
> > -#ifdef CONFIG_COMPAT
> > -static long pp_compat_ioctl(struct file *file, unsigned int cmd,
> > - unsigned long arg)
> > -{
> > - return pp_ioctl(file, cmd, (unsigned long)compat_ptr(arg));
> > -}
> > -#endif
> > -
> > static int pp_open(struct inode *inode, struct file *file) {
> > unsigned int minor = iminor(inode);
> > @@ -790,9 +782,7 @@ static const struct file_operations pp_fops = {
> > .write = pp_write,
> > .poll = pp_poll,
> > .unlocked_ioctl = pp_ioctl,
> > -#ifdef CONFIG_COMPAT
> > - .compat_ioctl = pp_compat_ioctl,
> > -#endif
> > + .compat_ioctl = compat_ptr_ioctl,
> > .open = pp_open,
> > .release= pp_release,
> > };
> > diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c
> > b/drivers/char/tpm/tpm_vtpm_proxy.c
> > index d74f3de74ae6..fb845f0a430b 100644
> > --- a/drivers/char/tpm/tpm_vtpm_proxy.c
> > +++ b/drivers/char/tpm/tpm_vtpm_proxy.c
> > @@ -675,20 +675,10 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned
> int ioctl,
> > }
> > }
> >
> > -#ifdef CONFIG_COMPAT
> > -static long vtpmx_fops_compat_ioctl(struct file *f, unsigned int ioctl,
> > - unsigned long arg)
> > -{
> > - return vtpmx_fops_ioctl(f, ioctl, (unsigned long)compat_ptr(arg));
> > -}
> > -#endif
> > -
> > static const struct file_operations vtpmx_fops = {
> > .owner = THIS_MODULE,
> > .unlocked_ioctl = vtpmx_fops_ioctl,
> > -#ifdef CONFIG_COMPAT
> > - .compat_ioctl = vtpmx_fops_compat_ioctl,
> > -#endif
> > + .compat_ioctl = compat_ptr_ioctl,
> > .llseek = noop_llseek,
> > };
> >
> > diff --git a/drivers/firewire/core-cdev.c
> > b/drivers/firewire/core-cdev.c index 16a7045736a9..fb934680fdd3 100644
> > --- a/drivers/firewire/core-cdev.c
> > +++ b/drivers/firewire/core-cdev.c
> > @@ -1659,14 +1659,6 @@ static long fw_device_op_ioctl(struct file *file,
> > return dispatch_ioctl(file->private_data, cmd, (void __user *)arg);
> > }
> >
> > -#ifdef CONFIG_COMPAT
> > -static long fw_device_op_compat_ioctl(struct file *file,
> > - unsigned int cmd, unsigned long arg)
> > -{
> > - return dispatch_ioctl(file->private_data, cmd, compat_ptr(arg));
> > -}
> > -#endif
> > -
> > static int fw_device_op_mmap(struct file *file, struct vm_area_struct
> > *vma) {
> > struct client *client = file->private_data; @@ -1808,7 +1800,5 @@
> > const struct file_operations fw_device_ops = {
> > .mmap = fw_device_op_mmap,
> > .release= fw_device_op_release,
> > .poll = fw_device_op_poll,
> > -#ifdef CONFIG_COMPAT
> > - .compat_ioctl = fw_device_op_compat_ioctl,
> > -#endif
> > + .compat_ioctl = compat_ptr_ioctl,
> > };
> > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> > index a746017fac17..ef4a1cd389d6 100644
> > --- a/drivers/hid/usbhid/hiddev.c
> > +++ b/drivers/hid/usbhid/hiddev.c
> > @@ -855,13 +855,6 @@ static long hiddev_ioctl(struct file *file, unsigned
> > int
> cmd, unsigned long arg)
> > return r;
> > }
> >
> > -#ifdef CONFIG_COMPAT
> > -static long hiddev_compat_ioctl(struct file *file, unsigned int cmd,
> >
Re: [PATCH] staging: kpc2000: add initial set of Daktronics drivers
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20190418]
[cannot apply to v5.1-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-kpc2000-add-initial-set-of-Daktronics-drivers/20190420-142353
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
drivers/staging/kpc2000/kpc2000/fileops.c: In function 'kp2000_cdev_read':
>> drivers/staging/kpc2000/kpc2000/fileops.c:74:1: warning: the frame size of
>> 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
--
In file included from include/linux/pci.h:31:0,
from drivers/staging/kpc2000/kpc2000/core.c:4:
drivers/staging/kpc2000/kpc2000/core.c: In function 'read_system_regs':
>> drivers/staging/kpc2000/kpc2000/core.c:148:36: warning: format '%lx' expects
>> argument of type 'long unsigned int', but argument 4 has type 'long long
>> int' [-Wformat=]
dev_err(&pcard->pdev->dev, "Invalid magic! Got: 0x%016llx Want:
0x%016lx\n", read_val, KP2000_MAGIC_VALUE);
^
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
drivers/staging/kpc2000/kpc2000/core.c:148:9: note: in expansion of macro
'dev_err'
dev_err(&pcard->pdev->dev, "Invalid magic! Got: 0x%016llx Want:
0x%016lx\n", read_val, KP2000_MAGIC_VALUE);
^~~
vim +74 drivers/staging/kpc2000/kpc2000/fileops.c
36
37
38 ssize_t kp2000_cdev_read(struct file *filp, char __user *buf, size_t
count, loff_t *f_pos)
39 {
40 struct kp2000_device *pcard = filp->private_data;
41 int cnt = 0;
42 int ret;
43 #define BUFF_CNT 1024
44 char buff[BUFF_CNT] = {0}; //NOTE: Increase this so it is at
least as large as all the scnprintfs. And don't use unbounded strings. "%s"
45 //NOTE: also, this is a really shitty way to implement the
read() call, but it will work for any size 'count'.
46
47 if (WARN(NULL == buf, "kp2000_cdev_read: buf is a NULL
pointer!\n"))
48 return -EINVAL;
49
50 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Card ID
: 0x%08x\n", pcard->card_id);
51 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Version
: 0x%08x\n", pcard->build_version);
52 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Date
: 0x%08x\n", pcard->build_datestamp);
53 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Time
: 0x%08x\n", pcard->build_timestamp);
54 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Offset
: 0x%08x\n", pcard->core_table_offset);
55 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Length
: 0x%08x\n", pcard->core_table_length);
56 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Hardware Revision
: 0x%08x\n", pcard->hardware_revision);
57 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "SSID
: 0x%016llx\n", pcard->ssid);
58 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "DDNA
: 0x%016llx\n", pcard->ddna);
59 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Mask
: 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK));
60 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Active
: 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_ACTIVE));
61 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "CPLD
: 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_CPLD_CONFIG));
62
63 if (*f_pos >= cnt)
64 return 0;
65
66 if (count > cnt)
67 count = cnt;
68
69 ret = copy_to_user(buf, buff + *f_pos, count);
70 if (ret)
71 return -EFAULT;
72
[PATCH] staging: greybus: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher --- drivers/staging/greybus/Kconfig | 44 - 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig index b571e4e8060b..2f5061b565a6 100644 --- a/drivers/staging/greybus/Kconfig +++ b/drivers/staging/greybus/Kconfig @@ -1,7 +1,7 @@ menuconfig GREYBUS tristate "Greybus support" depends on SYSFS - ---help--- + help This option enables the Greybus driver core. Greybus is an hardware protocol that was designed to provide Unipro with a sane application layer. It was originally designed for the @@ -19,7 +19,7 @@ if GREYBUS config GREYBUS_ES2 tristate "Greybus ES3 USB host controller" depends on USB - ---help--- + help Select this option if you have a Toshiba ES3 USB device that acts as a Greybus "host controller". This device is a bridge from a USB device to a Unipro network. @@ -30,7 +30,7 @@ config GREYBUS_ES2 config GREYBUS_AUDIO tristate "Greybus Audio Class driver" depends on SOUND - ---help--- + help Select this option if you have a device that follows the Greybus Audio Class specification. @@ -39,7 +39,7 @@ config GREYBUS_AUDIO config GREYBUS_BOOTROM tristate "Greybus Bootrom Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Bootrom Class specification. @@ -49,7 +49,7 @@ config GREYBUS_BOOTROM config GREYBUS_CAMERA tristate "Greybus Camera Class driver" depends on MEDIA_SUPPORT && LEDS_CLASS_FLASH && BROKEN - ---help--- + help Select this option if you have a device that follows the Greybus Camera Class specification. @@ -59,7 +59,7 @@ config GREYBUS_CAMERA config GREYBUS_FIRMWARE tristate "Greybus Firmware Download Class driver" depends on SPI - ---help--- + help Select this option if you have a device that follows the Greybus Firmware Download Class specification. @@ -69,7 +69,7 @@ config GREYBUS_FIRMWARE config GREYBUS_HID tristate "Greybus HID Class driver" depends on HID && INPUT - ---help--- + help Select this option if you have a device that follows the Greybus HID Class specification. @@ -79,7 +79,7 @@ config GREYBUS_HID config GREYBUS_LIGHT tristate "Greybus LED Class driver" depends on LEDS_CLASS - ---help--- + help Select this option if you have a device that follows the Greybus LED Class specification. @@ -88,7 +88,7 @@ config GREYBUS_LIGHT config GREYBUS_LOG tristate "Greybus Debug Log Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -97,7 +97,7 @@ config GREYBUS_LOG config GREYBUS_LOOPBACK tristate "Greybus Loopback Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Debug Log Class specification. @@ -107,7 +107,7 @@ config GREYBUS_LOOPBACK config GREYBUS_POWER tristate "Greybus Powersupply Class driver" depends on POWER_SUPPLY - ---help--- + help Select this option if you have a device that follows the Greybus Powersupply Class specification. @@ -116,7 +116,7 @@ config GREYBUS_POWER config GREYBUS_RAW tristate "Greybus Raw Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Raw Class specification. @@ -125,7 +125,7 @@ config GREYBUS_RAW config GREYBUS_VIBRATOR tristate "Greybus Vibrator Motor Class driver" - ---help--- + help Select this option if you have a device that follows the Greybus Vibrator Motor Class specification. @@ -134,7 +134,7 @@ config GREYBUS_VIBRATOR menuconfig GREYBUS_BRIDGED_PHY tristate "Greybus Bridged PHY Class drivers" - ---help--- + help Select this option to pick from a variety of Greybus Bridged PHY class drivers. These drivers emulate a number of different "traditional" busses by tunneling them over Greybus. @@ -149,7 +149,7 @@ config GREYBUS_GPIO tristate "Greybus GPIO Bridged PHY driver" depends on GPIOLIB select GPIOLIB_IRQCHIP - ---help--- + help Select this option if you have a device that follows the Greybus GPIO Bridged PHY Class specification. @@ -159,7 +159,7 @@ config GREYBUS_GPIO con
[PATCH] staging: media: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher --- drivers/staging/media/Kconfig | 2 +- drivers/staging/media/bcm2048/Kconfig | 2 +- drivers/staging/media/imx/Kconfig | 4 ++-- drivers/staging/media/ipu3/Kconfig | 2 +- drivers/staging/media/omap4iss/Kconfig | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig index 1da5c20d65c0..277df2b39384 100644 --- a/drivers/staging/media/Kconfig +++ b/drivers/staging/media/Kconfig @@ -1,7 +1,7 @@ menuconfig STAGING_MEDIA bool "Media staging drivers" default n - ---help--- + help This option allows you to select a number of media drivers that don't have the "normal" Linux kernel quality level. Most of them don't follow properly the V4L, DVB and/or RC API's, diff --git a/drivers/staging/media/bcm2048/Kconfig b/drivers/staging/media/bcm2048/Kconfig index a9fc6e186494..a1526175eccb 100644 --- a/drivers/staging/media/bcm2048/Kconfig +++ b/drivers/staging/media/bcm2048/Kconfig @@ -5,7 +5,7 @@ config I2C_BCM2048 tristate "Broadcom BCM2048 FM Radio Receiver support" depends on I2C && VIDEO_V4L2 && RADIO_ADAPTERS - ---help--- + help Say Y here if you want support to BCM2048 FM Radio Receiver. This device driver supports only i2c bus. diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig index 36b276ea2ecc..f6d220b649fb 100644 --- a/drivers/staging/media/imx/Kconfig +++ b/drivers/staging/media/imx/Kconfig @@ -6,7 +6,7 @@ config VIDEO_IMX_MEDIA depends on HAS_DMA select VIDEOBUF2_DMA_CONTIG select V4L2_FWNODE - ---help--- + help Say yes here to enable support for video4linux media controller driver for the i.MX5/6 SOC. @@ -17,7 +17,7 @@ config VIDEO_IMX_CSI tristate "i.MX5/6 Camera Sensor Interface driver" depends on VIDEO_IMX_MEDIA && VIDEO_DEV && I2C default y - ---help--- + help A video4linux camera sensor interface driver for i.MX5/6. config VIDEO_IMX7_CSI diff --git a/drivers/staging/media/ipu3/Kconfig b/drivers/staging/media/ipu3/Kconfig index 75cd889f18f7..d5e50f88684a 100644 --- a/drivers/staging/media/ipu3/Kconfig +++ b/drivers/staging/media/ipu3/Kconfig @@ -5,7 +5,7 @@ config VIDEO_IPU3_IMGU depends on X86 select IOMMU_IOVA select VIDEOBUF2_DMA_SG - ---help--- + help This is the Video4Linux2 driver for Intel IPU3 image processing unit, found in Intel Skylake and Kaby Lake SoCs and used for processing images and video. diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig index 841cc0b3ce13..4dcbc5065821 100644 --- a/drivers/staging/media/omap4iss/Kconfig +++ b/drivers/staging/media/omap4iss/Kconfig @@ -6,5 +6,5 @@ config VIDEO_OMAP4 depends on ARCH_OMAP4 || COMPILE_TEST select MFD_SYSCON select VIDEOBUF2_DMA_CONTIG - ---help--- + help Driver for an OMAP 4 ISS controller. -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: most: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/cdev/Kconfig | 2 +- drivers/staging/most/dim2/Kconfig | 2 +- drivers/staging/most/i2c/Kconfig | 2 +- drivers/staging/most/net/Kconfig | 2 +- drivers/staging/most/sound/Kconfig | 2 +- drivers/staging/most/usb/Kconfig | 2 +- drivers/staging/most/video/Kconfig | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig index 20047abbe560..09d2e1ee3388 100644 --- a/drivers/staging/most/Kconfig +++ b/drivers/staging/most/Kconfig @@ -2,7 +2,7 @@ menuconfig MOST tristate "MOST support" depends on HAS_DMA default n ----help--- +help Say Y here if you want to enable MOST support. This driver needs at least one additional component to enable the desired access from userspace (e.g. character devices) and one that diff --git a/drivers/staging/most/cdev/Kconfig b/drivers/staging/most/cdev/Kconfig index 2b04e26bcbea..2e27e1fce58d 100644 --- a/drivers/staging/most/cdev/Kconfig +++ b/drivers/staging/most/cdev/Kconfig @@ -5,7 +5,7 @@ config MOST_CDEV tristate "Cdev" - ---help--- + help Say Y here if you want to commumicate via character devices. To compile this driver as a module, choose M here: the diff --git a/drivers/staging/most/dim2/Kconfig b/drivers/staging/most/dim2/Kconfig index 5aeef22c3cba..ce9da9180056 100644 --- a/drivers/staging/most/dim2/Kconfig +++ b/drivers/staging/most/dim2/Kconfig @@ -6,7 +6,7 @@ config MOST_DIM2 tristate "DIM2" depends on HAS_IOMEM && OF - ---help--- + help Say Y here if you want to connect via MediaLB to network transceiver. This device driver is platform dependent and needs an additional platform driver to be installed. For more information contact diff --git a/drivers/staging/most/i2c/Kconfig b/drivers/staging/most/i2c/Kconfig index 79d0ff27f56d..f723f99711bd 100644 --- a/drivers/staging/most/i2c/Kconfig +++ b/drivers/staging/most/i2c/Kconfig @@ -5,7 +5,7 @@ config MOST_I2C tristate "I2C" depends on I2C - ---help--- + help Say Y here if you want to connect via I2C to network tranceiver. To compile this driver as a module, choose M here: the diff --git a/drivers/staging/most/net/Kconfig b/drivers/staging/most/net/Kconfig index 795330ba94ef..28040931f7e7 100644 --- a/drivers/staging/most/net/Kconfig +++ b/drivers/staging/most/net/Kconfig @@ -6,7 +6,7 @@ config MOST_NET tristate "Net" depends on NET - ---help--- + help Say Y here if you want to commumicate via a networking device. To compile this driver as a module, choose M here: the diff --git a/drivers/staging/most/sound/Kconfig b/drivers/staging/most/sound/Kconfig index 115262a58a42..5614a999b54e 100644 --- a/drivers/staging/most/sound/Kconfig +++ b/drivers/staging/most/sound/Kconfig @@ -6,7 +6,7 @@ config MOST_SOUND tristate "Sound" depends on SND select SND_PCM - ---help--- + help Say Y here if you want to commumicate via ALSA/sound devices. To compile this driver as a module, choose M here: the diff --git a/drivers/staging/most/usb/Kconfig b/drivers/staging/most/usb/Kconfig index ebbdb573a9a6..539b38fb3d88 100644 --- a/drivers/staging/most/usb/Kconfig +++ b/drivers/staging/most/usb/Kconfig @@ -5,7 +5,7 @@ config MOST_USB tristate "USB" depends on USB && NET - ---help--- + help Say Y here if you want to connect via USB to network tranceiver. This device driver depends on the networking AIM. diff --git a/drivers/staging/most/video/Kconfig b/drivers/staging/most/video/Kconfig index ce6af4f951a6..a458d0c74a0f 100644 --- a/drivers/staging/most/video/Kconfig +++ b/drivers/staging/most/video/Kconfig @@ -5,7 +5,7 @@ config MOST_VIDEO tristate "Video" depends on VIDEO_V4L2 - ---help--- + help Say Y here if you want to commumicate via Video 4 Linux. To compile this driver as a module, choose M here: the -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8*: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher --- drivers/staging/rtl8188eu/Kconfig | 4 ++-- drivers/staging/rtl8192e/Kconfig | 8 drivers/staging/rtl8712/Kconfig | 4 ++-- drivers/staging/rtl8723bs/Kconfig | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig index ff7832798a77..3f8c655856bf 100644 --- a/drivers/staging/rtl8188eu/Kconfig +++ b/drivers/staging/rtl8188eu/Kconfig @@ -7,7 +7,7 @@ config R8188EU select LIB80211 select LIB80211_CRYPT_WEP select LIB80211_CRYPT_CCMP - ---help--- + help This option adds the Realtek RTL8188EU USB device such as TP-Link TL-WN725N. If built as a module, it will be called r8188eu. @@ -16,7 +16,7 @@ if R8188EU config 88EU_AP_MODE bool "Realtek RTL8188EU AP mode" default y - ---help--- + help This option enables Access Point mode. Unless you know that your system will never be used as an AP, or the target system has limited memory, "Y" should be selected. diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig index 4602a47cdb4a..aa571c12678f 100644 --- a/drivers/staging/rtl8192e/Kconfig +++ b/drivers/staging/rtl8192e/Kconfig @@ -3,7 +3,7 @@ config RTLLIB depends on WLAN && m default n select LIB80211 - ---help--- + help If you have a wireless card that uses rtllib, say Y. Currently the only card is the rtl8192e. @@ -16,7 +16,7 @@ config RTLLIB_CRYPTO_CCMP depends on RTLLIB select CRYPTO_AES default y - ---help--- + help CCMP crypto driver for rtllib. If you enabled RTLLIB, you want this. @@ -27,7 +27,7 @@ config RTLLIB_CRYPTO_TKIP select CRYPTO_ARC4 select CRYPTO_MICHAEL_MIC default y - ---help--- + help TKIP crypto driver for rtllib. If you enabled RTLLIB, you want this. @@ -37,7 +37,7 @@ config RTLLIB_CRYPTO_WEP select CRYPTO_ARC4 depends on RTLLIB default y - ---help--- + help TKIP crypto driver for rtllib. If you enabled RTLLIB, you want this. diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig index f160eee52f09..b377d90742db 100644 --- a/drivers/staging/rtl8712/Kconfig +++ b/drivers/staging/rtl8712/Kconfig @@ -4,14 +4,14 @@ config R8712U select WIRELESS_EXT select WEXT_PRIV select FW_LOADER - ---help--- + help This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130. If built as a module, it will be called r8712u. config R8712_TX_AGGR bool "Realtek RTL8712U Transmit Aggregation code" depends on R8712U && BROKEN - ---help--- + help This option provides transmit aggregation for the Realtek RTL8712 USB device. diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig index deae0427ba6c..41ad6ed24860 100644 --- a/drivers/staging/rtl8723bs/Kconfig +++ b/drivers/staging/rtl8723bs/Kconfig @@ -4,7 +4,7 @@ config RTL8723BS depends on m select WIRELESS_EXT select WEXT_PRIV - ---help--- + help This option enables support for RTL8723BS SDIO drivers, such as the wifi found on the 1st gen Intel Compute Stick, the CHIP and many other Intel Atom and ARM based devices. -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: unisys: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher --- drivers/staging/unisys/Kconfig| 2 +- drivers/staging/unisys/visorhba/Kconfig | 2 +- drivers/staging/unisys/visorinput/Kconfig | 2 +- drivers/staging/unisys/visornic/Kconfig | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig index c27dab3b610f..b9c814df5d36 100644 --- a/drivers/staging/unisys/Kconfig +++ b/drivers/staging/unisys/Kconfig @@ -3,7 +3,7 @@ # menuconfig UNISYSSPAR bool "Unisys SPAR driver support" - ---help--- + help Support for the Unisys SPAR drivers if UNISYSSPAR diff --git a/drivers/staging/unisys/visorhba/Kconfig b/drivers/staging/unisys/visorhba/Kconfig index 241d8038261c..4b67634b236d 100644 --- a/drivers/staging/unisys/visorhba/Kconfig +++ b/drivers/staging/unisys/visorhba/Kconfig @@ -5,7 +5,7 @@ config UNISYS_VISORHBA tristate "Unisys visorhba driver" depends on UNISYSSPAR && UNISYS_VISORBUS && SCSI - ---help--- + help The Unisys visorhba driver provides support for s-Par HBA devices exposed on the s-Par visorbus. When a message is sent to visorbus to create a HBA device, the probe function of diff --git a/drivers/staging/unisys/visorinput/Kconfig b/drivers/staging/unisys/visorinput/Kconfig index a3817e0f7e5c..c0681f932d76 100644 --- a/drivers/staging/unisys/visorinput/Kconfig +++ b/drivers/staging/unisys/visorinput/Kconfig @@ -5,7 +5,7 @@ config UNISYS_VISORINPUT tristate "Unisys visorinput driver" depends on UNISYSSPAR && UNISYS_VISORBUS && INPUT - ---help--- + help The Unisys s-Par visorinput driver provides a virtualized system console (keyboard and mouse) that is accessible through the s-Par firmware's user interface. s-Par provides video using the EFI diff --git a/drivers/staging/unisys/visornic/Kconfig b/drivers/staging/unisys/visornic/Kconfig index 1676dc7072d5..33a9b63bccb5 100644 --- a/drivers/staging/unisys/visornic/Kconfig +++ b/drivers/staging/unisys/visornic/Kconfig @@ -5,7 +5,7 @@ config UNISYS_VISORNIC tristate "Unisys visornic driver" depends on UNISYSSPAR && UNISYS_VISORBUS && NET - ---help--- + help The Unisys Visornic driver provides support for s-Par network devices exposed on the s-Par visorbus. When a message is sent to visorbus to create a network device, the probe function of -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: kpc2000: add initial set of Daktronics drivers
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20190418]
[cannot apply to v5.1-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-kpc2000-add-initial-set-of-Daktronics-drivers/20190420-142353
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
drivers/staging/kpc2000/kpc2000/fileops.c: In function 'kp2000_cdev_read':
drivers/staging/kpc2000/kpc2000/fileops.c:59:84: error: implicit declaration
of function 'readq'; did you mean 'readb'?
[-Werror=implicit-function-declaration]
cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Mask:
0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK));
^
readb
>> drivers/staging/kpc2000/kpc2000/fileops.c:59:78: warning: format '%llx'
>> expects argument of type 'long long unsigned int', but argument 4 has type
>> 'int' [-Wformat=]
cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Mask:
0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK));
~~^
%016x
drivers/staging/kpc2000/kpc2000/fileops.c:60:78: warning: format '%llx'
expects argument of type 'long long unsigned int', but argument 4 has type
'int' [-Wformat=]
cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Active :
0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_ACTIVE));
~~^ ~~
%016x
drivers/staging/kpc2000/kpc2000/fileops.c:61:78: warning: format '%llx'
expects argument of type 'long long unsigned int', but argument 4 has type
'int' [-Wformat=]
cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "CPLD:
0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_CPLD_CONFIG));
~~^ ~
%016x
cc1: some warnings being treated as errors
vim +59 drivers/staging/kpc2000/kpc2000/fileops.c
36
37
38 ssize_t kp2000_cdev_read(struct file *filp, char __user *buf, size_t
count, loff_t *f_pos)
39 {
40 struct kp2000_device *pcard = filp->private_data;
41 int cnt = 0;
42 int ret;
43 #define BUFF_CNT 1024
44 char buff[BUFF_CNT] = {0}; //NOTE: Increase this so it is at
least as large as all the scnprintfs. And don't use unbounded strings. "%s"
45 //NOTE: also, this is a really shitty way to implement the
read() call, but it will work for any size 'count'.
46
47 if (WARN(NULL == buf, "kp2000_cdev_read: buf is a NULL
pointer!\n"))
48 return -EINVAL;
49
50 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Card ID
: 0x%08x\n", pcard->card_id);
51 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Version
: 0x%08x\n", pcard->build_version);
52 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Date
: 0x%08x\n", pcard->build_datestamp);
53 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Time
: 0x%08x\n", pcard->build_timestamp);
54 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Offset
: 0x%08x\n", pcard->core_table_offset);
55 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Length
: 0x%08x\n", pcard->core_table_length);
56 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Hardwa
[PATCH] staging: vt665*: use help instead of ---help--- in Kconfig
From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" - Use 8space tab instead of 3space in vt6655/Kconfig Signed-off-by: Moses Christopher --- drivers/staging/vt6655/Kconfig | 9 - drivers/staging/vt6656/Kconfig | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6655/Kconfig b/drivers/staging/vt6655/Kconfig index 77cfc708c516..ed0cfc765677 100644 --- a/drivers/staging/vt6655/Kconfig +++ b/drivers/staging/vt6655/Kconfig @@ -1,6 +1,5 @@ config VT6655 - tristate "VIA Technologies VT6655 support" - depends on PCI && MAC80211 && m - ---help--- - This is a vendor-written driver for VIA VT6655. - + tristate "VIA Technologies VT6655 support" + depends on PCI && MAC80211 && m + help + This is a vendor-written driver for VIA VT6655. diff --git a/drivers/staging/vt6656/Kconfig b/drivers/staging/vt6656/Kconfig index b602ef175d55..16b124ed23bc 100644 --- a/drivers/staging/vt6656/Kconfig +++ b/drivers/staging/vt6656/Kconfig @@ -2,6 +2,6 @@ config VT6656 tristate "VIA Technologies VT6656 support" depends on MAC80211 && USB && WLAN && m select FW_LOADER - ---help--- - This is a vendor-written driver for VIA VT6656. + help + This is a vendor-written driver for VIA VT6656. -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Loan Facility Available:
Sir, Loan Facility Available: We work with a reliable and efficient company in England that specialized on bank loan at a very reasonable rate of 4% per-annul which are far much better than securing financial instrument such as Bank Guarantee (BG) or Standby Letter of Credit (SBLC). The whole process from signing of contract and the application process and approval of loan can be completed as early as ten (10) banking days or less. Contact me for further directives / information if you are interested. Sincerely. Ms. Fita Butti ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate()
Remove unnecessary variable and replace return type.
In addition to that align the function parameters with parentheses to
maintain Linux coding style.
Issue suggested by Coccinelle.
Signed-off-by: Madhumitha Prabakaran
---
Changes in v2
1) Fix my own error of removing function call from the variable.
2) Align the function parameters with parentheses.
---
---
.../staging/vc04_services/bcm2835-camera/controls.c| 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c
b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index e39ab5fae724..71eb349c3138 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -607,18 +607,16 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev,
struct v4l2_ctrl *ctrl,
const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
{
- int ret;
struct vchiq_mmal_port *encoder_out;
dev->capture.encode_bitrate = ctrl->val;
encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0];
- ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
- mmal_ctrl->mmal_id,
- &ctrl->val, sizeof(ctrl->val));
- ret = 0;
- return ret;
+ vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
+ mmal_ctrl->mmal_id, &ctrl->val,
+ sizeof(ctrl->val));
+ return 0;
}
static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8*: use help instead of ---help--- in Kconfig
On 4/20/19 6:37 AM, MosesChristopher wrote: From: Moses Christopher - Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: Moses Christopher I have never seen this warning, but your Kconfig may be newer than mine. In any case, the changes are harmless. Acked-by: Larry Finger --- drivers/staging/rtl8188eu/Kconfig | 4 ++-- drivers/staging/rtl8192e/Kconfig | 8 drivers/staging/rtl8712/Kconfig | 4 ++-- drivers/staging/rtl8723bs/Kconfig | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig index ff7832798a77..3f8c655856bf 100644 --- a/drivers/staging/rtl8188eu/Kconfig +++ b/drivers/staging/rtl8188eu/Kconfig @@ -7,7 +7,7 @@ config R8188EU select LIB80211 select LIB80211_CRYPT_WEP select LIB80211_CRYPT_CCMP - ---help--- + help This option adds the Realtek RTL8188EU USB device such as TP-Link TL-WN725N. If built as a module, it will be called r8188eu. @@ -16,7 +16,7 @@ if R8188EU config 88EU_AP_MODE bool "Realtek RTL8188EU AP mode" default y - ---help--- + help This option enables Access Point mode. Unless you know that your system will never be used as an AP, or the target system has limited memory, "Y" should be selected. diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig index 4602a47cdb4a..aa571c12678f 100644 --- a/drivers/staging/rtl8192e/Kconfig +++ b/drivers/staging/rtl8192e/Kconfig @@ -3,7 +3,7 @@ config RTLLIB depends on WLAN && m default n select LIB80211 - ---help--- + help If you have a wireless card that uses rtllib, say Y. Currently the only card is the rtl8192e. @@ -16,7 +16,7 @@ config RTLLIB_CRYPTO_CCMP depends on RTLLIB select CRYPTO_AES default y - ---help--- + help CCMP crypto driver for rtllib. If you enabled RTLLIB, you want this. @@ -27,7 +27,7 @@ config RTLLIB_CRYPTO_TKIP select CRYPTO_ARC4 select CRYPTO_MICHAEL_MIC default y - ---help--- + help TKIP crypto driver for rtllib. If you enabled RTLLIB, you want this. @@ -37,7 +37,7 @@ config RTLLIB_CRYPTO_WEP select CRYPTO_ARC4 depends on RTLLIB default y - ---help--- + help TKIP crypto driver for rtllib. If you enabled RTLLIB, you want this. diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig index f160eee52f09..b377d90742db 100644 --- a/drivers/staging/rtl8712/Kconfig +++ b/drivers/staging/rtl8712/Kconfig @@ -4,14 +4,14 @@ config R8712U select WIRELESS_EXT select WEXT_PRIV select FW_LOADER - ---help--- + help This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130. If built as a module, it will be called r8712u. config R8712_TX_AGGR bool "Realtek RTL8712U Transmit Aggregation code" depends on R8712U && BROKEN - ---help--- + help This option provides transmit aggregation for the Realtek RTL8712 USB device. diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig index deae0427ba6c..41ad6ed24860 100644 --- a/drivers/staging/rtl8723bs/Kconfig +++ b/drivers/staging/rtl8723bs/Kconfig @@ -4,7 +4,7 @@ config RTL8723BS depends on m select WIRELESS_EXT select WEXT_PRIV - ---help--- + help This option enables support for RTL8723BS SDIO drivers, such as the wifi found on the 1st gen Intel Compute Stick, the CHIP and many other Intel Atom and ARM based devices. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Please indicate your interest.
I have a client who have indicated interest to invest in oversea. He also intends to partner with anyone with a good knowledge of business in the country of the investment who shall act as the Managing partner as he may not be able to relocate out of his country at the moment to manage the business because he holds a political appointment with the government. Please, if you're interested reply for further discussions. Regards Mr.patrick marius. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate()
On Sat, Apr 20, 2019 at 11:56:44AM -0500, Madhumitha Prabakaran wrote:
> Remove unnecessary variable and replace return type.
> In addition to that align the function parameters with parentheses to
> maintain Linux coding style.
>
> Issue suggested by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran
>
> ---
> Changes in v2
>
> 1) Fix my own error of removing function call from the variable.
> 2) Align the function parameters with parentheses.
>
> ---
> ---
> .../staging/vc04_services/bcm2835-camera/controls.c| 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> index e39ab5fae724..71eb349c3138 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> @@ -607,18 +607,16 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev,
> struct v4l2_ctrl *ctrl,
> const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
> {
> - int ret;
> struct vchiq_mmal_port *encoder_out;
>
> dev->capture.encode_bitrate = ctrl->val;
>
> encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0];
>
> - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
> - mmal_ctrl->mmal_id,
> - &ctrl->val, sizeof(ctrl->val));
> - ret = 0;
> - return ret;
> + vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
> + mmal_ctrl->mmal_id, &ctrl->val,
> + sizeof(ctrl->val));
> + return 0;
> }
Why does this function even return anything at all if it can not fail?
Why not return the value that vchiq_mmal_port_parameter_set() returned?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()
On Fri, Apr 19, 2019 at 04:11:30PM -0500, Madhumitha Prabakaran wrote: > Remove unwanted variable and replace the respective return type. > > Issue suggested by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/mt7621-mmc/sd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) This file is long deleted. Always make sure you work off of the latest development tree for the subsystem you are wanting to contribute to. Or on linux-next at the least. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: use help instead of ---help--- in Kconfig
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote: > From: Moses Christopher > > - Resolve the following warning from the Kconfig, > "WARNING: prefer 'help' over '---help---' for new help texts" > > Signed-off-by: Moses Christopher > --- > drivers/staging/unisys/Kconfig| 2 +- > drivers/staging/unisys/visorhba/Kconfig | 2 +- > drivers/staging/unisys/visorinput/Kconfig | 2 +- > drivers/staging/unisys/visornic/Kconfig | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) This, and all of your other ---help--- conversion patches, do not apply at all as some of these have already been done by others in my tree. Please rebase all of your help cleanup staging patches against my staging-next branch and resend any remaining ones that are needed, as I'm going to drop all of these from my queue right now. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
netvigator.com
za___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
