Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error
On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote: > On 3/31/19 1:04 AM, Joe Perches wrote: > > Blind adherence to 80 column limits leads to poor looking > > code. Especially with longish identifier lengths. > I agree. If it were me, I'd use a local variable. For example: > > struct greybus_descriptor_cport *cport_desc = gbphy_dev->cport_desc; > ... > connection = gb_connection_create(gbphy_dev->bundle, > le16_to_cpu(cport_desc->id), NULL); > > Or maybe better: > > u16 cport_id = le16_to_cpu(gbphy_dev->cport_desc->id); > ... > connection = gb_connection_create(gbphy_dev->bundle, cport_id, NULL); True. A possible negative though: Temporaries that are only used once are sometimes less readable as the declaration is supposed to be done at an open brace and that could be relatively far away from the set and use. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] mips: ralink: allow to choose function which belongs with multiple groups
This allows the signals which can be assigned from multiple GPIO pins
to be really assigned as expected.
That one case is "refclk" signal in MT76x8.
It was forcibily assigned to the pin matched by signal name at first.
Eventually it always appears as GPIO #37. We cannot use refclk with the other
pin.
Signed-off-by: NOGUCHI Hiroshi
---
arch/mips/include/asm/mach-ralink/pinmux.h| 3 +-
.../staging/mt7621-pinctrl/pinctrl-rt2880.c | 164 ++
2 files changed, 136 insertions(+), 31 deletions(-)
diff --git a/arch/mips/include/asm/mach-ralink/pinmux.h
b/arch/mips/include/asm/mach-ralink/pinmux.h
index ba8ac331af0c..e2974a04ff61 100644
--- a/arch/mips/include/asm/mach-ralink/pinmux.h
+++ b/arch/mips/include/asm/mach-ralink/pinmux.h
@@ -32,8 +32,7 @@ struct rt2880_pmx_func {
int pin_count;
int *pins;
- int *groups;
- int group_count;
+ int group_idx;
int enabled;
};
diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
index 9b52d44abef1..bdfd93dba02c 100644
--- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
+++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
@@ -26,6 +26,12 @@
#define SYSC_REG_GPIO_MODE 0x60
#define SYSC_REG_GPIO_MODE20x64
+struct rt2880_func_group_map {
+ const char *func_name;
+ const char **group_names;
+ int num_groups;
+};
+
struct rt2880_priv {
struct device *dev;
@@ -39,6 +45,10 @@ struct rt2880_priv {
const char **group_names;
int group_count;
+ struct rt2880_func_group_map *func_to_group_map;
+ s16 *group_to_func_map;
+ int func_to_group_count;
+
u8 *gpio;
int max_pins;
};
@@ -86,7 +96,7 @@ static int rt2880_pmx_func_count(struct pinctrl_dev *pctrldev)
{
struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
- return p->func_count;
+ return p->func_to_group_count;
}
static const char *rt2880_pmx_func_name(struct pinctrl_dev *pctrldev,
@@ -94,7 +104,7 @@ static const char *rt2880_pmx_func_name(struct pinctrl_dev
*pctrldev,
{
struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
- return p->func[func]->name;
+ return p->func_to_group_map[func].func_name;
}
static int rt2880_pmx_group_get_groups(struct pinctrl_dev *pctrldev,
@@ -104,12 +114,8 @@ static int rt2880_pmx_group_get_groups(struct pinctrl_dev
*pctrldev,
{
struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
- if (p->func[func]->group_count == 1)
- *groups = &p->group_names[p->func[func]->groups[0]];
- else
- *groups = p->group_names;
-
- *num_groups = p->func[func]->group_count;
+ *groups = p->func_to_group_map[func].group_names;
+ *num_groups = p->func_to_group_map[func].num_groups;
return 0;
}
@@ -122,6 +128,7 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev
*pctrldev,
u32 reg = SYSC_REG_GPIO_MODE;
int i;
int shift;
+ int func_in_grp;
/* dont allow double use */
if (p->groups[group].enabled) {
@@ -130,8 +137,13 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev
*pctrldev,
return -EBUSY;
}
+ func_in_grp =
+ p->group_to_func_map[(group * p->func_to_group_count) + func];
+ if (func_in_grp < 0)
+ return -EINVAL;
+
p->groups[group].enabled = 1;
- p->func[func]->enabled = 1;
+ p->func[func_in_grp]->enabled = 1;
shift = p->groups[group].shift;
if (shift >= 32) {
@@ -149,9 +161,9 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev
*pctrldev,
if (func == 0) {
mode |= p->groups[group].gpio << shift;
} else {
- for (i = 0; i < p->func[func]->pin_count; i++)
- p->gpio[p->func[func]->pins[i]] = 0;
- mode |= p->func[func]->value << shift;
+ for (i = 0; i < p->func[func_in_grp]->pin_count; i++)
+ p->gpio[p->func[func_in_grp]->pins[i]] = 0;
+ mode |= p->func[func_in_grp]->value << shift;
}
rt_sysc_w32(mode, reg);
@@ -191,6 +203,111 @@ static struct rt2880_pmx_func gpio_func = {
.name = "gpio",
};
+static int rt2880_build_internal_map(struct rt2880_priv *p)
+{
+ int i, j;
+ struct rt2880_func_group_map *f_g;
+ struct rt2880_func_group_map *f_g_tmp;
+ int16_t *g_f;
+ int c = 0;
+ int ret = 0;
+
+ /* func_to_group_map[0] is used for gpio */
+ f_g = devm_kzalloc(p->dev, sizeof(f_g[0]) * 1, GFP_KERNEL);
+ if (!f_g) {
+ ret = -ENOMEM;
+ goto l_exit;
+ }
+ f_g[0].func_name = p->func[0]->name;
+ f_g[0].group_names = p->group_names;
+ f_g[0].num_groups = p->group_count;
+ c = 1;
+
+ /* parse function list which has entries with same
[PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Signed-off-by: Ojaswin Mujoo --- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/dpc.h | 2 +- drivers/staging/vt6656/firmware.h | 2 +- drivers/staging/vt6656/int.h | 2 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/power.h| 2 +- drivers/staging/vt6656/rf.h | 2 +- drivers/staging/vt6656/rxtx.h | 2 +- drivers/staging/vt6656/usbpipe.h | 2 +- drivers/staging/vt6656/wcmd.h | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index a907e30..c3b8bbd 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/card.h b/drivers/staging/vt6656/card.h index 0a91d9b..75cd340 100644 --- a/drivers/staging/vt6656/card.h +++ b/drivers/staging/vt6656/card.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h index 6d0d282..cca330f 100644 --- a/drivers/staging/vt6656/channel.h +++ b/drivers/staging/vt6656/channel.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/desc.h b/drivers/staging/vt6656/desc.h index ac45ebb..3a83a9e 100644 --- a/drivers/staging/vt6656/desc.h +++ b/drivers/staging/vt6656/desc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h index a2feeb9..6074ced 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/dpc.h b/drivers/staging/vt6656/dpc.h index ddd0cb7..e080add 100644 --- a/drivers/staging/vt6656/dpc.h +++ b/drivers/staging/vt6656/dpc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/firmware.h b/drivers/staging/vt6656/firmware.h index f30ae90..161126f 100644 --- a/drivers/staging/vt6656/firmware.h +++ b/drivers/staging/vt6656/firmware.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h index 1e6ff92..987c454e9 100644 --- a/drivers/staging/vt6656/int.h +++ b/drivers/staging/vt6656/int.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/key.h b/drivers/staging/vt6656/key.h index 1306ff4..918c07c 100644 --- a/drivers/staging/vt6656/key.h +++ b/drivers/staging/vt6656/key.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/power.h b/drivers/staging/vt6656/power.h index d5a3198..58755ae 100644 --- a/drivers/staging/vt6656/power.h +++ b/drivers/staging/vt6656/power.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h index f77866a..6103117 100644 --- a/drivers/staging/vt6656/rf.h +++ b/drivers/staging/vt6656/rf.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/rxtx.h b/drivers/staging/vt6656/rxtx.h index 44698f4..d528607 100644 --- a/drivers/staging/vt6656/rxtx.h +++ b/drivers/staging/vt
Re: [PATCH v3 1/5] staging: iio: adc: ad7280a: Tab alignment
On Sun, 24 Mar 2019 18:23:09 +0100
Cristian Sicilia wrote:
> Aligned some parameters.
>
> Signed-off-by: Cristian Sicilia
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index d9df126..571535d 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -830,30 +830,30 @@ static irqreturn_t ad7280_event_handler(int irq, void
> *private)
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> - in_voltage-voltage_thresh_low_value,
> - 0644,
> - ad7280_read_channel_config,
> - ad7280_write_channel_config,
> - AD7280A_CELL_UNDERVOLTAGE);
> + in_voltage-voltage_thresh_low_value,
> + 0644,
> + ad7280_read_channel_config,
> + ad7280_write_channel_config,
> + AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> - in_voltage-voltage_thresh_high_value,
> - 0644,
> - ad7280_read_channel_config,
> - ad7280_write_channel_config,
> - AD7280A_CELL_OVERVOLTAGE);
> + in_voltage-voltage_thresh_high_value,
> + 0644,
> + ad7280_read_channel_config,
> + ad7280_write_channel_config,
> + AD7280A_CELL_OVERVOLTAGE);
>
> static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
> - 0644,
> - ad7280_read_channel_config,
> - ad7280_write_channel_config,
> - AD7280A_AUX_ADC_UNDERVOLTAGE);
> +0644,
> +ad7280_read_channel_config,
> +ad7280_write_channel_config,
> +AD7280A_AUX_ADC_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
> - 0644,
> - ad7280_read_channel_config,
> - ad7280_write_channel_config,
> - AD7280A_AUX_ADC_OVERVOLTAGE);
> +0644,
> +ad7280_read_channel_config,
> +ad7280_write_channel_config,
> +AD7280A_AUX_ADC_OVERVOLTAGE);
>
> static struct attribute *ad7280_event_attributes[] = {
> &iio_dev_attr_in_thresh_low_value.dev_attr.attr,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 2/5] staging: iio: adc: ad7192: Converted bool to bitfield format
On Sun, 24 Mar 2019 18:23:11 +0100
Cristian Sicilia wrote:
> Changed bool format to bitfield format to save space.
>
> Signed-off-by: Cristian Sicilia
This driver is undergoing active rework to move out of staging
and in the meantime these fields have been dropped.
So not applied as no longer relevant.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.h | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.h
> b/drivers/staging/iio/adc/ad7192.h
> index 7433a43..9c1d223 100644
> --- a/drivers/staging/iio/adc/ad7192.h
> +++ b/drivers/staging/iio/adc/ad7192.h
> @@ -35,13 +35,13 @@ struct ad7192_platform_data {
> u16 vref_mv;
> u8 clock_source_sel;
> u32 ext_clk_hz;
> - boolrefin2_en;
> - boolrej60_en;
> - boolsinc3_en;
> - boolchop_en;
> - boolbuf_en;
> - boolunipolar_en;
> - boolburnout_curr_en;
> + u8 refin2_en:1;
> + u8 rej60_en:1;
> + u8 sinc3_en:1;
> + u8 chop_en:1;
> + u8 buf_en:1;
> + u8 unipolar_en:1;
> + u8 burnout_curr_en:1;
> };
>
> #endif /* IIO_ADC_AD7192_H_ */
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/5] staging: iio: adc: ad7280a: Avoid precedence issues in macro
On Sun, 24 Mar 2019 18:23:12 +0100 Cristian Sicilia wrote: > Enclosing parameter with parenthesis due to avoid > possible precedence issue. > > Signed-off-by: Cristian Sicilia I've already applied this one. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c > b/drivers/staging/iio/adc/ad7280a.c > index 571535d..c2391f6 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -97,9 +97,10 @@ > #define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \ > AD7280A_CELL_VOLTAGE_1 + 1) > > -#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c) > -#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)((d * AD7280A_CELLS_PER_DEV) + \ > - c - AD7280A_CELLS_PER_DEV) > +#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + > \ > + (c)) > +#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)(((d) * AD7280A_CELLS_PER_DEV) + > \ > + (c) - AD7280A_CELLS_PER_DEV) > > #define AD7280A_DEVADDR_MASTER 0 > #define AD7280A_DEVADDR_ALL 0x1F ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability
On Sun, 24 Mar 2019 18:23:14 +0100
Cristian Sicilia wrote:
> Creating a temporary variable to improve readability
>
> Signed-off-by: Cristian Sicilia
I have already applied this one.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 55
> ++-
> 1 file changed, 25 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index c2391f6..4ff28f1 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void
> *private)
> for (i = 0; i < st->scan_cnt; i++) {
> if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
> if (((channels[i] >> 11) & 0xFFF) >=
> - st->cell_threshhigh)
> - iio_push_event(indio_dev,
> -IIO_EVENT_CODE(IIO_VOLTAGE,
> - 1,
> - 0,
> - IIO_EV_DIR_RISING,
> - IIO_EV_TYPE_THRESH,
> - 0, 0, 0),
> + st->cell_threshhigh) {
> + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
> + IIO_EV_DIR_RISING,
> + IIO_EV_TYPE_THRESH,
> + 0, 0, 0);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> - else if (((channels[i] >> 11) & 0xFFF) <=
> - st->cell_threshlow)
> - iio_push_event(indio_dev,
> -IIO_EVENT_CODE(IIO_VOLTAGE,
> - 1,
> - 0,
> - IIO_EV_DIR_FALLING,
> - IIO_EV_TYPE_THRESH,
> - 0, 0, 0),
> + } else if (((channels[i] >> 11) & 0xFFF) <=
> +st->cell_threshlow) {
> + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
> + IIO_EV_DIR_FALLING,
> + IIO_EV_TYPE_THRESH,
> + 0, 0, 0);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> + }
> } else {
> - if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh)
> - iio_push_event(indio_dev,
> -IIO_UNMOD_EVENT_CODE(
> - IIO_TEMP,
> - 0,
> + if (((channels[i] >> 11) & 0xFFF) >=
> + st->aux_threshhigh) {
> + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_RISING),
> + IIO_EV_DIR_RISING);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> - else if (((channels[i] >> 11) & 0xFFF) <=
> - st->aux_threshlow)
> - iio_push_event(indio_dev,
> -IIO_UNMOD_EVENT_CODE(
> - IIO_TEMP,
> - 0,
> + } else if (((channels[i] >> 11) & 0xFFF) <=
> + st->aux_threshlow) {
> + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_FALLING),
> + IIO_EV_DIR_FALLING);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> + }
> }
> }
>
___
devel mailing list
de...@linuxdr
Re: [PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability
On Sun, 24 Mar 2019 18:23:14 +0100
Cristian Sicilia wrote:
> Creating a temporary variable to improve readability
>
> Signed-off-by: Cristian Sicilia
Already applied this one as well.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 55
> ++-
> 1 file changed, 25 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index c2391f6..4ff28f1 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void
> *private)
> for (i = 0; i < st->scan_cnt; i++) {
> if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
> if (((channels[i] >> 11) & 0xFFF) >=
> - st->cell_threshhigh)
> - iio_push_event(indio_dev,
> -IIO_EVENT_CODE(IIO_VOLTAGE,
> - 1,
> - 0,
> - IIO_EV_DIR_RISING,
> - IIO_EV_TYPE_THRESH,
> - 0, 0, 0),
> + st->cell_threshhigh) {
> + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
> + IIO_EV_DIR_RISING,
> + IIO_EV_TYPE_THRESH,
> + 0, 0, 0);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> - else if (((channels[i] >> 11) & 0xFFF) <=
> - st->cell_threshlow)
> - iio_push_event(indio_dev,
> -IIO_EVENT_CODE(IIO_VOLTAGE,
> - 1,
> - 0,
> - IIO_EV_DIR_FALLING,
> - IIO_EV_TYPE_THRESH,
> - 0, 0, 0),
> + } else if (((channels[i] >> 11) & 0xFFF) <=
> +st->cell_threshlow) {
> + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
> + IIO_EV_DIR_FALLING,
> + IIO_EV_TYPE_THRESH,
> + 0, 0, 0);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> + }
> } else {
> - if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh)
> - iio_push_event(indio_dev,
> -IIO_UNMOD_EVENT_CODE(
> - IIO_TEMP,
> - 0,
> + if (((channels[i] >> 11) & 0xFFF) >=
> + st->aux_threshhigh) {
> + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_RISING),
> + IIO_EV_DIR_RISING);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> - else if (((channels[i] >> 11) & 0xFFF) <=
> - st->aux_threshlow)
> - iio_push_event(indio_dev,
> -IIO_UNMOD_EVENT_CODE(
> - IIO_TEMP,
> - 0,
> + } else if (((channels[i] >> 11) & 0xFFF) <=
> + st->aux_threshlow) {
> + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_FALLING),
> + IIO_EV_DIR_FALLING);
> + iio_push_event(indio_dev, tmp,
> iio_get_time_ns(indio_dev));
> + }
> }
> }
>
___
devel mailing list
de...@linuxd
Re: [PATCH v3 5/5] staging: iio: adc: ad7280a: Remove CamelCase notation
On Sun, 24 Mar 2019 18:23:16 +0100
Cristian Sicilia wrote:
> Fix CamelCase naming.
>
> Signed-off-by: Cristian Sicilia
Already applied this one as well.
So whole set has been applied.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index 4ff28f1..229dcad 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -917,8 +917,8 @@ static int ad7280_probe(struct spi_device *spi)
> const struct ad7280_platform_data *pdata = dev_get_platdata(&spi->dev);
> struct ad7280_state *st;
> int ret;
> - const unsigned short tACQ_ns[4] = {465, 1010, 1460, 1890};
> - const unsigned short nAVG[4] = {1, 2, 4, 8};
> + const unsigned short t_acq_ns[4] = {465, 1010, 1460, 1890};
> + const unsigned short n_avg[4] = {1, 2, 4, 8};
> struct iio_dev *indio_dev;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> @@ -966,10 +966,9 @@ static int ad7280_probe(struct spi_device *spi)
>*/
>
> st->readback_delay_us =
> - ((tACQ_ns[pdata->acquisition_time & 0x3] + 695) *
> - (AD7280A_NUM_CH * nAVG[pdata->conversion_averaging & 0x3]))
> - - tACQ_ns[pdata->acquisition_time & 0x3] +
> - st->slave_num * 250;
> + ((t_acq_ns[pdata->acquisition_time & 0x3] + 695) *
> + (AD7280A_NUM_CH * n_avg[pdata->conversion_averaging & 0x3])) -
> + t_acq_ns[pdata->acquisition_time & 0x3] + st->slave_num * 250;
>
> /* Convert to usecs */
> st->readback_delay_us = DIV_ROUND_UP(st->readback_delay_us, 1000);
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Beautiful
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my approach is a little inappropriate to begin with. Hope to hear back from you. Jack. Nota de confidencialidad: Este mensaje y todo documento adjunto puede contener informacion confidencial y protegida legalmente bajo secreto profesional. La transmision de esta informacion es privada y esta dirigida unicamente a la persona o entidad indicada, y su acceso por cualquier otra persona no esta autorizado. Si usted ha recibido este mensaje por error, por favor informeselo al remitente y borrelo. El contenido de este mensaje corresponde a la opinion de su autor pero no refleja necesariamente la de Polakof y Cia. S.A., quien tampoco asume responsabilidad por alteraciones que afecten a este mensaje luego de su envio. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Above line should be after ---. Signed-off-by: Ojaswin Mujoo Although, it looks ok to me. but this is spread through out the tree and a result of a copy paste. Reviewed-by: Mukesh Ojha But, i would want other to comment on this, whether we really want this kind of effort coming forward. or can it be not done by some scripting? Cheers, -Mukesh --- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/dpc.h | 2 +- drivers/staging/vt6656/firmware.h | 2 +- drivers/staging/vt6656/int.h | 2 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/power.h| 2 +- drivers/staging/vt6656/rf.h | 2 +- drivers/staging/vt6656/rxtx.h | 2 +- drivers/staging/vt6656/usbpipe.h | 2 +- drivers/staging/vt6656/wcmd.h | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index a907e30..c3b8bbd 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/card.h b/drivers/staging/vt6656/card.h index 0a91d9b..75cd340 100644 --- a/drivers/staging/vt6656/card.h +++ b/drivers/staging/vt6656/card.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h index 6d0d282..cca330f 100644 --- a/drivers/staging/vt6656/channel.h +++ b/drivers/staging/vt6656/channel.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/desc.h b/drivers/staging/vt6656/desc.h index ac45ebb..3a83a9e 100644 --- a/drivers/staging/vt6656/desc.h +++ b/drivers/staging/vt6656/desc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h index a2feeb9..6074ced 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/dpc.h b/drivers/staging/vt6656/dpc.h index ddd0cb7..e080add 100644 --- a/drivers/staging/vt6656/dpc.h +++ b/drivers/staging/vt6656/dpc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/firmware.h b/drivers/staging/vt6656/firmware.h index f30ae90..161126f 100644 --- a/drivers/staging/vt6656/firmware.h +++ b/drivers/staging/vt6656/firmware.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h index 1e6ff92..987c454e9 100644 --- a/drivers/staging/vt6656/int.h +++ b/drivers/staging/vt6656/int.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/key.h b/drivers/staging/vt6656/key.h index 1306ff4..918c07c 100644 --- a/drivers/staging/vt6656/key.h +++ b/drivers/staging/vt6656/key.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/power.h b/drivers/staging/vt6656/power.h index d5a3198..58755ae 100644 --- a/drivers/staging/vt6656/power.h +++ b/drivers/staging/vt6656/power.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h index f77866a..6103117 10
Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
On 3/31/2019 5:49 PM, Mukesh Ojha wrote: On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Above line should be after ---. Signed-off-by: Ojaswin Mujoo Although, it looks ok to me. but this is spread through out the tree and a result of a copy paste. Reviewed-by: Mukesh Ojha But, i would want other to comment on this, whether we really want this kind of effort coming forward. or can it be not done by some scripting? Found the discussion and the script at https://lkml.org/lkml/2019/2/7/46. Let's do that. Cheers, -Mukesh --- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/dpc.h | 2 +- drivers/staging/vt6656/firmware.h | 2 +- drivers/staging/vt6656/int.h | 2 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/power.h | 2 +- drivers/staging/vt6656/rf.h | 2 +- drivers/staging/vt6656/rxtx.h | 2 +- drivers/staging/vt6656/usbpipe.h | 2 +- drivers/staging/vt6656/wcmd.h | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index a907e30..c3b8bbd 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/card.h b/drivers/staging/vt6656/card.h index 0a91d9b..75cd340 100644 --- a/drivers/staging/vt6656/card.h +++ b/drivers/staging/vt6656/card.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h index 6d0d282..cca330f 100644 --- a/drivers/staging/vt6656/channel.h +++ b/drivers/staging/vt6656/channel.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/desc.h b/drivers/staging/vt6656/desc.h index ac45ebb..3a83a9e 100644 --- a/drivers/staging/vt6656/desc.h +++ b/drivers/staging/vt6656/desc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h index a2feeb9..6074ced 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/dpc.h b/drivers/staging/vt6656/dpc.h index ddd0cb7..e080add 100644 --- a/drivers/staging/vt6656/dpc.h +++ b/drivers/staging/vt6656/dpc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/firmware.h b/drivers/staging/vt6656/firmware.h index f30ae90..161126f 100644 --- a/drivers/staging/vt6656/firmware.h +++ b/drivers/staging/vt6656/firmware.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h index 1e6ff92..987c454e9 100644 --- a/drivers/staging/vt6656/int.h +++ b/drivers/staging/vt6656/int.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/key.h b/drivers/staging/vt6656/key.h index 1306ff4..918c07c 100644 --- a/drivers/staging/vt6656/key.h +++ b/drivers/staging/vt6656/key.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. diff --git a/drivers/staging/vt6656/power.h b/drivers/staging/vt6656/power.h index d5a3198..58755ae 100644 --- a/drivers/staging/vt6656/power.h +++ b/drivers/staging/vt6656/power.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Ne
Re: [PATCH] Staging: greybus: usb: Fixed a coding style error
On Sun, 2019-03-31 at 01:30 -0400, Will Cunningham wrote: > Line was >80 characters. [] > diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c [] > @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, > return -ENOMEM; > > connection = gb_connection_create(gbphy_dev->bundle, > - > le16_to_cpu(gbphy_dev->cport_desc->id), > - NULL); > + le16_to_cpu(gbphy_dev->cport_desc->id), > + NULL); Blind adherence to 80 column limits leads to poor looking code. Especially with longish identifier lengths. Another way to do this, which is not necessarily actually better is to position the left side of the assignment on a separate line like: connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu(gbphy_dev->cport_desc->id), Is that better?I prefer the original. It was better before as it was aligned to open parenthesis. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Dear
Hello dear, i hope this letter meets you well? my name is Jack, I know this may seem inappropriate so i ask for your forgiveness, i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am currently looking for a relationship in which I will feel loved. I promise to answer any question that you may want to ask me...all i need is just your attention and the chance to know you more. Please tell me more about yourself, if you do not mind. Hope to hear back from you soon and i hope this letter will be the beginning of a lasting communication between us. Jack. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.
Removed unnecessary parentheses.`
Signed-off-by: Will Cunningham
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers/staging/comedi/drivers/pcl818.c
index 0af5315d4357..da5d53a288f7 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
pcl818_alloc_dma(dev, it->options[2]);
/* use 1MHz or 10MHz oscilator */
- if ((it->options[3] == 0) || (it->options[3] == 10))
+ if (it->options[3] == 0 || it->options[3] == 10)
osc_base = I8254_OSC_BASE_10MHZ;
else
osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
devpriv->ns_min = board->ns_min;
if (!board->is_818) {
/* extended PCL718 to 100kHz DAC */
- if ((it->options[6] == 1) || (it->options[6] == 100))
+ if (it->options[6] == 1 || it->options[6] == 100)
devpriv->ns_min = 1;
}
@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
s->maxdata = 0x0fff;
s->range_table = &range_unipolar5;
if (board->is_818) {
- if ((it->options[4] == 1) || (it->options[4] == 10))
+ if (it->options[4] == 1 || it->options[4] == 10)
s->range_table = &range_unipolar10;
if (it->options[4] == 2)
s->range_table = &range_unknown;
} else {
- if ((it->options[5] == 1) || (it->options[5] == 10))
+ if (it->options[5] == 1 || it->options[5] == 10)
s->range_table = &range_unipolar10;
if (it->options[5] == 2)
s->range_table = &range_unknown;
--
2.19.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.
On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote: > Removed unnecessary parentheses.` Odd trailing character :( > > Signed-off-by: Will Cunningham > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/pcl818.c > b/drivers/staging/comedi/drivers/pcl818.c > index 0af5315d4357..da5d53a288f7 100644 > --- a/drivers/staging/comedi/drivers/pcl818.c > +++ b/drivers/staging/comedi/drivers/pcl818.c > @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, > struct comedi_devconfig *it) > pcl818_alloc_dma(dev, it->options[2]); > > /* use 1MHz or 10MHz oscilator */ > - if ((it->options[3] == 0) || (it->options[3] == 10)) > + if (it->options[3] == 0 || it->options[3] == 10) No, please leave as-is. () are there for humans to read, and having to always remember the order of operations is not something you ever want to do. I _REALLY_ hate this option of checkpatch :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
