Hi
Hello, My name is Miss Eden,i saw your profile and i love it,i think we can make it together,please i will like you to email me back through my email thus;so that i will send you my picture.so that we will discuss more about my interest,I will be waiting to receive your lovely reply soon Miss Eden ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: ralink-gdma: Convert unsigned to unsigned int
Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".
Signed-off-by: Bharath Vedartham
---
drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ralink-gdma/ralink-gdma.c
index 0b831f8..523c39e 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -162,7 +162,7 @@ static inline u32 gdma_dma_read(struct gdma_dma_dev
*dma_dev, unsigned int reg)
return readl(dma_dev->base + reg);
}
-static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned reg,
u32 val)
+static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned int
reg, u32 val)
{
writel(val, dma_dev->base + reg);
}
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] staging: iio: adc: Remove CamelCase notation
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index 5d848aa..c02454c 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -917,8 +917,8 @@ static int ad7280_probe(struct spi_device *spi)
const struct ad7280_platform_data *pdata = dev_get_platdata(&spi->dev);
struct ad7280_state *st;
int ret;
- const unsigned short tACQ_ns[4] = {465, 1010, 1460, 1890};
- const unsigned short nAVG[4] = {1, 2, 4, 8};
+ const unsigned short t_acq_ns[4] = {465, 1010, 1460, 1890};
+ const unsigned short n_avg[4] = {1, 2, 4, 8};
struct iio_dev *indio_dev;
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
@@ -966,10 +966,9 @@ static int ad7280_probe(struct spi_device *spi)
*/
st->readback_delay_us =
- ((tACQ_ns[pdata->acquisition_time & 0x3] + 695) *
- (AD7280A_NUM_CH * nAVG[pdata->conversion_averaging & 0x3]))
- - tACQ_ns[pdata->acquisition_time & 0x3] +
- st->slave_num * 250;
+ ((t_acq_ns[pdata->acquisition_time & 0x3] + 695) *
+(AD7280A_NUM_CH * n_avg[pdata->conversion_averaging & 0x3])) -
+ t_acq_ns[pdata->acquisition_time & 0x3] + st->slave_num * 250;
/* Convert to usecs */
st->readback_delay_us = DIV_ROUND_UP(st->readback_delay_us, 1000);
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] staging: iio: adc: Converted bool to bitfield format
Changed bool format to bitfield format to save space.
Signed-off-by: Cristian Sicilia
---
The strange thing is that this struct seems not populated
using a DTS binding function.
---
drivers/staging/iio/adc/ad7192.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h
index 7433a43..87891ba 100644
--- a/drivers/staging/iio/adc/ad7192.h
+++ b/drivers/staging/iio/adc/ad7192.h
@@ -35,13 +35,13 @@ struct ad7192_platform_data {
u16 vref_mv;
u8 clock_source_sel;
u32 ext_clk_hz;
- boolrefin2_en;
- boolrej60_en;
- boolsinc3_en;
- boolchop_en;
- boolbuf_en;
- boolunipolar_en;
- boolburnout_curr_en;
-};
+ u8 refin2_en:1;
+ u8 rej60_en:1;
+ u8 sinc3_en:1;
+ u8 chop_en:1;
+ u8 buf_en:1;
+ u8 unipolar_en:1;
+ u8 burnout_curr_en:1;
+} __attribute__((__packed__));
#endif /* IIO_ADC_AD7192_H_ */
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] staging: iio: adc: Adding temp var to improve readability
Creating a temporary variable to improve readability
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 55 ++-
1 file changed, 25 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d81a5bd..5d848aa 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void
*private)
for (i = 0; i < st->scan_cnt; i++) {
if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
if (((channels[i] >> 11) & 0xFFF) >=
- st->cell_threshhigh)
- iio_push_event(indio_dev,
- IIO_EVENT_CODE(IIO_VOLTAGE,
- 1,
- 0,
- IIO_EV_DIR_RISING,
- IIO_EV_TYPE_THRESH,
- 0, 0, 0),
+ st->cell_threshhigh) {
+ u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
+IIO_EV_DIR_RISING,
+IIO_EV_TYPE_THRESH,
+0, 0, 0);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
- else if (((channels[i] >> 11) & 0xFFF) <=
- st->cell_threshlow)
- iio_push_event(indio_dev,
- IIO_EVENT_CODE(IIO_VOLTAGE,
- 1,
- 0,
- IIO_EV_DIR_FALLING,
- IIO_EV_TYPE_THRESH,
- 0, 0, 0),
+ } else if (((channels[i] >> 11) & 0xFFF) <=
+ st->cell_threshlow) {
+ u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
+IIO_EV_DIR_FALLING,
+IIO_EV_TYPE_THRESH,
+0, 0, 0);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
+ }
} else {
- if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh)
- iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(
- IIO_TEMP,
- 0,
+ if (((channels[i] >> 11) & 0xFFF) >=
+ st->aux_threshhigh) {
+ u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_RISING),
+ IIO_EV_DIR_RISING);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
- else if (((channels[i] >> 11) & 0xFFF) <=
- st->aux_threshlow)
- iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(
- IIO_TEMP,
- 0,
+ } else if (((channels[i] >> 11) & 0xFFF) <=
+ st->aux_threshlow) {
+ u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_FALLING),
+ IIO_EV_DIR_FALLING);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
+ }
}
}
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/5] staging: iio: adc: Avoid precedence issues in macro
Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 55b5879..d81a5bd 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -97,9 +97,10 @@ #define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \ AD7280A_CELL_VOLTAGE_1 + 1) -#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c) -#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)((d * AD7280A_CELLS_PER_DEV) + \ -c - AD7280A_CELLS_PER_DEV) +#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \ +(c)) +#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)(((d) * AD7280A_CELLS_PER_DEV) + \ +(c) - AD7280A_CELLS_PER_DEV) #define AD7280A_DEVADDR_MASTER 0 #define AD7280A_DEVADDR_ALL0x1F -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/5] *** SUBJECT HERE ***
Some source refactoring, parameters aligment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: Tab alignment staging: iio: adc: Converted bool to bitfield format staging: iio: adc: Avoid precedence issues in macro staging: iio: adc: Adding temp var to improve readability staging: iio: adc: Remove CamelCase notation drivers/staging/iio/adc/ad7192.h | 16 +++--- drivers/staging/iio/adc/ad7280a.c | 109 ++ 2 files changed, 60 insertions(+), 65 deletions(-) -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/5] staging: iio: adc: Tab alignment
Aligned some parameters.
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d9df126..55b5879 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -830,30 +830,30 @@ static irqreturn_t ad7280_event_handler(int irq, void
*private)
}
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_CELL_UNDERVOLTAGE);
+in_voltage - voltage_thresh_low_value,
+0644,
+ad7280_read_channel_config,
+ad7280_write_channel_config,
+AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_CELL_OVERVOLTAGE);
+in_voltage - voltage_thresh_high_value,
+0644,
+ad7280_read_channel_config,
+ad7280_write_channel_config,
+AD7280A_CELL_OVERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_AUX_ADC_UNDERVOLTAGE);
+ 0644,
+ ad7280_read_channel_config,
+ ad7280_write_channel_config,
+ AD7280A_AUX_ADC_UNDERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_AUX_ADC_OVERVOLTAGE);
+ 0644,
+ ad7280_read_channel_config,
+ ad7280_write_channel_config,
+ AD7280A_AUX_ADC_OVERVOLTAGE);
static struct attribute *ad7280_event_attributes[] = {
&iio_dev_attr_in_thresh_low_value.dev_attr.attr,
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4] staging: ralink-gdma: Use u32 over uint32_t
Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t"
Signed-off-by: Bharath Vedartham
---
Changes since v3
- Fixed allignment issues.
- Submitted a seperate patch to change unsigned
to unsigned int.
- One of the allignments crosses 80 characters in a line
but I feel that we may loose readability if we try to reduce
the characters in the line.
---
drivers/staging/ralink-gdma/ralink-gdma.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ralink-gdma/ralink-gdma.c
index d78042e..0b831f8 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -157,14 +157,12 @@ static struct gdma_dma_desc *to_gdma_dma_desc(struct
virt_dma_desc *vdesc)
return container_of(vdesc, struct gdma_dma_desc, vdesc);
}
-static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev,
-unsigned int reg)
+static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev, unsigned int reg)
{
return readl(dma_dev->base + reg);
}
-static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev,
- unsigned reg, uint32_t val)
+static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned reg,
u32 val)
{
writel(val, dma_dev->base + reg);
}
@@ -283,7 +281,7 @@ static int rt305x_gdma_start_transfer(struct
gdma_dmaengine_chan *chan)
struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
dma_addr_t src_addr, dst_addr;
struct gdma_dma_sg *sg;
- uint32_t ctrl0, ctrl1;
+ u32 ctrl0, ctrl1;
/* verify chan is already stopped */
ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
@@ -361,7 +359,7 @@ static int rt3883_gdma_start_transfer(struct
gdma_dmaengine_chan *chan)
struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
dma_addr_t src_addr, dst_addr;
struct gdma_dma_sg *sg;
- uint32_t ctrl0, ctrl1;
+ u32 ctrl0, ctrl1;
/* verify chan is already stopped */
ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
@@ -753,7 +751,7 @@ static void gdma_dma_tasklet(unsigned long arg)
static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
{
- uint32_t gct;
+ u32 gct;
/* all chans round robin */
gdma_dma_write(dma_dev, GDMA_RT305X_GCT, GDMA_REG_GCT_ARBIT_RR);
@@ -767,7 +765,7 @@ static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
static void rt3883_gdma_init(struct gdma_dma_dev *dma_dev)
{
- uint32_t gct;
+ u32 gct;
/* all chans round robin */
gdma_dma_write(dma_dev, GDMA_REG_GCT, GDMA_REG_GCT_ARBIT_RR);
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[no subject]
>From bb04b0ca982b7042902fffe1377e0e38e83b402b Mon Sep 17 00:00:00 2001 From: Will Cunningham Date: Sat, 23 Mar 2019 12:54:34 -0400 Subject: [PATCH] Staging: emxx_udc: emxx_udc: Fixed a coding style error Removed unnecessary parentheses. Signed-off-by: Will Cunningham --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index a913d40f0801..80a906742cdc 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -136,7 +136,7 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req) struct usb_ctrlrequest *p_ctrl; struct nbu2ss_udc *udc; - if ((!_ep) || (!_req)) + if (!_ep || !_req) return; udc = (struct nbu2ss_udc *)_req->context; -- 2.19.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format
Changed bool format to bitfield format to save space.
Signed-off-by: Cristian Sicilia
---
The strange thing is that this struct seems not populated
using a DTS binding function.
---
drivers/staging/iio/adc/ad7192.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h
index 7433a43..87891ba 100644
--- a/drivers/staging/iio/adc/ad7192.h
+++ b/drivers/staging/iio/adc/ad7192.h
@@ -35,13 +35,13 @@ struct ad7192_platform_data {
u16 vref_mv;
u8 clock_source_sel;
u32 ext_clk_hz;
- boolrefin2_en;
- boolrej60_en;
- boolsinc3_en;
- boolchop_en;
- boolbuf_en;
- boolunipolar_en;
- boolburnout_curr_en;
-};
+ u8 refin2_en:1;
+ u8 rej60_en:1;
+ u8 sinc3_en:1;
+ u8 chop_en:1;
+ u8 buf_en:1;
+ u8 unipolar_en:1;
+ u8 burnout_curr_en:1;
+} __attribute__((__packed__));
#endif /* IIO_ADC_AD7192_H_ */
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 4/5] staging: iio: adc: Adding temp var to improve readability
Creating a temporary variable to improve readability
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 55 ++-
1 file changed, 25 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d81a5bd..5d848aa 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void
*private)
for (i = 0; i < st->scan_cnt; i++) {
if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
if (((channels[i] >> 11) & 0xFFF) >=
- st->cell_threshhigh)
- iio_push_event(indio_dev,
- IIO_EVENT_CODE(IIO_VOLTAGE,
- 1,
- 0,
- IIO_EV_DIR_RISING,
- IIO_EV_TYPE_THRESH,
- 0, 0, 0),
+ st->cell_threshhigh) {
+ u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
+IIO_EV_DIR_RISING,
+IIO_EV_TYPE_THRESH,
+0, 0, 0);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
- else if (((channels[i] >> 11) & 0xFFF) <=
- st->cell_threshlow)
- iio_push_event(indio_dev,
- IIO_EVENT_CODE(IIO_VOLTAGE,
- 1,
- 0,
- IIO_EV_DIR_FALLING,
- IIO_EV_TYPE_THRESH,
- 0, 0, 0),
+ } else if (((channels[i] >> 11) & 0xFFF) <=
+ st->cell_threshlow) {
+ u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
+IIO_EV_DIR_FALLING,
+IIO_EV_TYPE_THRESH,
+0, 0, 0);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
+ }
} else {
- if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh)
- iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(
- IIO_TEMP,
- 0,
+ if (((channels[i] >> 11) & 0xFFF) >=
+ st->aux_threshhigh) {
+ u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_RISING),
+ IIO_EV_DIR_RISING);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
- else if (((channels[i] >> 11) & 0xFFF) <=
- st->aux_threshlow)
- iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(
- IIO_TEMP,
- 0,
+ } else if (((channels[i] >> 11) & 0xFFF) <=
+ st->aux_threshlow) {
+ u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_FALLING),
+ IIO_EV_DIR_FALLING);
+ iio_push_event(indio_dev, tmp,
iio_get_time_ns(indio_dev));
+ }
}
}
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/5] staging: iio: adc: Avoid precedence issues in macro
Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 55b5879..d81a5bd 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -97,9 +97,10 @@ #define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \ AD7280A_CELL_VOLTAGE_1 + 1) -#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c) -#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)((d * AD7280A_CELLS_PER_DEV) + \ -c - AD7280A_CELLS_PER_DEV) +#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \ +(c)) +#define AD7280A_CALC_TEMP_CHAN_NUM(d, c)(((d) * AD7280A_CELLS_PER_DEV) + \ +(c) - AD7280A_CELLS_PER_DEV) #define AD7280A_DEVADDR_MASTER 0 #define AD7280A_DEVADDR_ALL0x1F -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/5] staging: iio: adc: Remove CamelCase notation
Fix CamelCase naming.
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index 5d848aa..c02454c 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -917,8 +917,8 @@ static int ad7280_probe(struct spi_device *spi)
const struct ad7280_platform_data *pdata = dev_get_platdata(&spi->dev);
struct ad7280_state *st;
int ret;
- const unsigned short tACQ_ns[4] = {465, 1010, 1460, 1890};
- const unsigned short nAVG[4] = {1, 2, 4, 8};
+ const unsigned short t_acq_ns[4] = {465, 1010, 1460, 1890};
+ const unsigned short n_avg[4] = {1, 2, 4, 8};
struct iio_dev *indio_dev;
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
@@ -966,10 +966,9 @@ static int ad7280_probe(struct spi_device *spi)
*/
st->readback_delay_us =
- ((tACQ_ns[pdata->acquisition_time & 0x3] + 695) *
- (AD7280A_NUM_CH * nAVG[pdata->conversion_averaging & 0x3]))
- - tACQ_ns[pdata->acquisition_time & 0x3] +
- st->slave_num * 250;
+ ((t_acq_ns[pdata->acquisition_time & 0x3] + 695) *
+(AD7280A_NUM_CH * n_avg[pdata->conversion_averaging & 0x3])) -
+ t_acq_ns[pdata->acquisition_time & 0x3] + st->slave_num * 250;
/* Convert to usecs */
st->readback_delay_us = DIV_ROUND_UP(st->readback_delay_us, 1000);
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change
Some source refactoring, parameters alignment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: Tab alignment staging: iio: adc: Converted bool to bitfield format staging: iio: adc: Avoid precedence issues in macro staging: iio: adc: Adding temp var to improve readability staging: iio: adc: Remove CamelCase notation drivers/staging/iio/adc/ad7192.h | 16 +++--- drivers/staging/iio/adc/ad7280a.c | 109 ++ 2 files changed, 60 insertions(+), 65 deletions(-) -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/5] staging: iio: adc: Tab alignment
Aligned some parameters.
Signed-off-by: Cristian Sicilia
---
drivers/staging/iio/adc/ad7280a.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d9df126..55b5879 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -830,30 +830,30 @@ static irqreturn_t ad7280_event_handler(int irq, void
*private)
}
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_CELL_UNDERVOLTAGE);
+in_voltage - voltage_thresh_low_value,
+0644,
+ad7280_read_channel_config,
+ad7280_write_channel_config,
+AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_CELL_OVERVOLTAGE);
+in_voltage - voltage_thresh_high_value,
+0644,
+ad7280_read_channel_config,
+ad7280_write_channel_config,
+AD7280A_CELL_OVERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_AUX_ADC_UNDERVOLTAGE);
+ 0644,
+ ad7280_read_channel_config,
+ ad7280_write_channel_config,
+ AD7280A_AUX_ADC_UNDERVOLTAGE);
static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
- 0644,
- ad7280_read_channel_config,
- ad7280_write_channel_config,
- AD7280A_AUX_ADC_OVERVOLTAGE);
+ 0644,
+ ad7280_read_channel_config,
+ ad7280_write_channel_config,
+ AD7280A_AUX_ADC_OVERVOLTAGE);
static struct attribute *ad7280_event_attributes[] = {
&iio_dev_attr_in_thresh_low_value.dev_attr.attr,
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/5] *** SUBJECT HERE ***
You may want to change "*** SUBJECT HERE ***" in the future :) - Matt On Sat, Mar 23, 2019 at 5:53 AM Cristian Sicilia wrote: > > Some source refactoring, parameters aligment and camel case clearing. > > Replacement of bool to bitfield in a struct, but not found > the population to check if it is done correctly. > > Cristian Sicilia (5): > staging: iio: adc: Tab alignment > staging: iio: adc: Converted bool to bitfield format > staging: iio: adc: Avoid precedence issues in macro > staging: iio: adc: Adding temp var to improve readability > staging: iio: adc: Remove CamelCase notation > > drivers/staging/iio/adc/ad7192.h | 16 +++--- > drivers/staging/iio/adc/ad7280a.c | 109 > ++ > 2 files changed, 60 insertions(+), 65 deletions(-) > > -- > 2.7.4 > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 05/14] staging: most: enable configfs support
Hi Christian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.1-rc1 next-20190322]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Christian-Gromm/staging-most-switch-to-configfs/20190322-075523
config: x86_64-randconfig-i1-03180048 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/staging/most/configfs.o: In function `most_snd_grp_make_item':
>> drivers/staging/most/configfs.c:484: undefined reference to
>> `config_item_init_type_name'
drivers/staging/most/configfs.o: In function `most_common_make_item':
drivers/staging/most/configfs.c:404: undefined reference to
`config_item_init_type_name'
drivers/staging/most/configfs.o: In function `most_sound_make_group':
>> drivers/staging/most/configfs.c:576: undefined reference to
>> `config_group_init_type_name'
drivers/staging/most/configfs.o: In function `most_register_configfs_subsys':
>> drivers/staging/most/configfs.c:606: undefined reference to
>> `configfs_register_subsystem'
drivers/staging/most/configfs.c:608: undefined reference to
`configfs_register_subsystem'
drivers/staging/most/configfs.c:610: undefined reference to
`configfs_register_subsystem'
drivers/staging/most/configfs.c:612: undefined reference to
`configfs_register_subsystem'
drivers/staging/most/configfs.o: In function
`most_deregister_configfs_subsys':
>> drivers/staging/most/configfs.c:628: undefined reference to
>> `configfs_unregister_subsystem'
drivers/staging/most/configfs.c:630: undefined reference to
`configfs_unregister_subsystem'
drivers/staging/most/configfs.c:632: undefined reference to
`configfs_unregister_subsystem'
drivers/staging/most/configfs.c:634: undefined reference to
`configfs_unregister_subsystem'
drivers/staging/most/configfs.o: In function `configfs_init':
>> drivers/staging/most/configfs.c:640: undefined reference to
>> `config_group_init'
drivers/staging/most/configfs.c:643: undefined reference to
`config_group_init'
drivers/staging/most/configfs.c:646: undefined reference to
`config_group_init'
drivers/staging/most/configfs.c:649: undefined reference to
`config_group_init'
vim +484 drivers/staging/most/configfs.c
590f3182 Christian Gromm 2019-03-21 394
590f3182 Christian Gromm 2019-03-21 395 static struct config_item
*most_common_make_item(struct config_group *group,
590f3182 Christian Gromm 2019-03-21 396
const char *name)
590f3182 Christian Gromm 2019-03-21 397 {
590f3182 Christian Gromm 2019-03-21 398struct mdev_link *mdev_link;
590f3182 Christian Gromm 2019-03-21 399
590f3182 Christian Gromm 2019-03-21 400mdev_link =
kzalloc(sizeof(*mdev_link), GFP_KERNEL);
590f3182 Christian Gromm 2019-03-21 401if (!mdev_link)
590f3182 Christian Gromm 2019-03-21 402return ERR_PTR(-ENOMEM);
590f3182 Christian Gromm 2019-03-21 403
590f3182 Christian Gromm 2019-03-21 @404
config_item_init_type_name(&mdev_link->item, name,
590f3182 Christian Gromm 2019-03-21 405
&mdev_link_type);
590f3182 Christian Gromm 2019-03-21 406
590f3182 Christian Gromm 2019-03-21 407if
(!strcmp(group->cg_item.ci_namebuf, "most_cdev"))
590f3182 Christian Gromm 2019-03-21 408strcpy(mdev_link->comp,
"cdev");
590f3182 Christian Gromm 2019-03-21 409else if
(!strcmp(group->cg_item.ci_namebuf, "most_net"))
590f3182 Christian Gromm 2019-03-21 410strcpy(mdev_link->comp,
"net");
590f3182 Christian Gromm 2019-03-21 411else if
(!strcmp(group->cg_item.ci_namebuf, "most_video"))
590f3182 Christian Gromm 2019-03-21 412strcpy(mdev_link->comp,
"video");
590f3182 Christian Gromm 2019-03-21 413strcpy(mdev_link->name, name);
590f3182 Christian Gromm 2019-03-21 414return &mdev_link->item;
590f3182 Christian Gromm 2019-03-21 415 }
590f3182 Christian Gromm 2019-03-21 416
590f3182 Christian Gromm 2019-03-21 417 static void
most_common_release(struct config_item *item)
590f3182 Christian Gromm 2019-03-21 418 {
590f3182 Christian Gromm 2019-03-21 419kfree(to_most_common(item));
590f3182 Christian Gromm 2019-03-21 420 }
590f3182 Christian Gromm 2019-03-21 421
590f3182 Christian Gromm 2019-03-21 422 static struct
configfs_item_operations most_common_item_ops = {
590f3182 Christian Gromm 2019-03-21 423.release=
most_common_release,
590f3182 Christian Gromm 2019-03-21 424 };
590f3182 Christian Gromm 2019-03-21 425
590f3182 Christian Gromm 2019-03-21 426 static struct
configfs_group_operations most_common_group_ops = {
590f3182 Chr
