[PATCH] Fixing coding style issues in wilc1000/wilc_debugfs.c
Most of them were easily fixed. The only invasive fix was the split
of the info string line 63 because:
- it was too long
- checkpath doesn't like 'quoted string split across lines'
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 7d32de9..011438e 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -20,7 +20,7 @@
static struct dentry *wilc_dir;
/*
- *
+ *
*/
#define DEBUG BIT(0)
#define INFOBIT(1)
@@ -32,10 +32,11 @@
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
- *
+ *
*/
-static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
+size_t count, loff_t *ppos)
{
char buf[128];
int res = 0;
@@ -44,13 +45,15 @@ static ssize_t wilc_debug_level_read(struct file *file,
char __user *userbuf, si
if (*ppos > 0)
return 0;
- res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
atomic_read(&WILC_DEBUG_LEVEL));
+ res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
+ atomic_read(&WILC_DEBUG_LEVEL));
return simple_read_from_buffer(userbuf, count, ppos, buf, res);
}
-static ssize_t wilc_debug_level_write(struct file *filp, const char __user
*buf,
- size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_write(struct file *filp,
+ const char __user *buf, size_t count,
+ loff_t *ppos)
{
int flag = 0;
int ret;
@@ -60,7 +63,9 @@ static ssize_t wilc_debug_level_write(struct file *filp,
const char __user *buf,
return ret;
if (flag > DBG_LEVEL_ALL) {
- pr_info("%s, value (0x%08x) is out of range, stay previous flag
(0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
+ pr_info("%s, value (0x%08x) is out of range,", __func__, flag);
+ pr_info("stay previous flag (0x%08x)\n",
+ atomic_read(&WILC_DEBUG_LEVEL));
return -EINVAL;
}
@@ -75,7 +80,7 @@ static ssize_t wilc_debug_level_write(struct file *filp,
const char __user *buf,
}
/*
- *
+ *
*/
#define FOPS(_open, _read, _write, _poll) { \
@@ -94,7 +99,12 @@ struct wilc_debugfs_info_t {
};
static struct wilc_debugfs_info_t debugfs_info[] = {
- { "wilc_debug_level", 0666, (DEBUG | ERR), FOPS(NULL,
wilc_debug_level_read, wilc_debug_level_write, NULL), },
+ {
+ "wilc_debug_level",
+ 0666,
+ (DEBUG | ERR),
+ FOPS(NULL, wilc_debug_level_read, wilc_debug_level_write, NULL),
+ },
};
static int __init wilc_debugfs_init(void)
--
1.9.1
signature.asc
Description: Digital signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Fixing coding style issues in wilc1000/wilc_debugfs.c
On Tue, May 02, 2017 at 09:49:29AM +0200, Vincent Siles wrote:
> Most of them were easily fixed. The only invasive fix was the split
> of the info string line 63 because:
> - it was too long
> - checkpath doesn't like 'quoted string split across lines'
Please fix up your subject line to look more like others for this
driver. Use git to see them.
>
> Signed-off-by: Vincent Siles
> ---
> drivers/staging/wilc1000/wilc_debugfs.c | 28 +++-
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
> b/drivers/staging/wilc1000/wilc_debugfs.c
> index 7d32de9..011438e 100644
> --- a/drivers/staging/wilc1000/wilc_debugfs.c
> +++ b/drivers/staging/wilc1000/wilc_debugfs.c
> @@ -20,7 +20,7 @@
> static struct dentry *wilc_dir;
>
> /*
> - *
>
> + *
>
> */
> #define DEBUG BIT(0)
> #define INFOBIT(1)
> @@ -32,10 +32,11 @@
> EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
>
> /*
> - *
>
> + *
>
> */
>
> -static ssize_t wilc_debug_level_read(struct file *file, char __user
> *userbuf, size_t count, loff_t *ppos)
> +static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
> + size_t count, loff_t *ppos)
> {
> char buf[128];
> int res = 0;
> @@ -44,13 +45,15 @@ static ssize_t wilc_debug_level_read(struct file *file,
> char __user *userbuf, si
> if (*ppos > 0)
> return 0;
>
> - res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
> atomic_read(&WILC_DEBUG_LEVEL));
> + res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
> + atomic_read(&WILC_DEBUG_LEVEL));
>
> return simple_read_from_buffer(userbuf, count, ppos, buf, res);
> }
>
> -static ssize_t wilc_debug_level_write(struct file *filp, const char __user
> *buf,
> - size_t count, loff_t *ppos)
> +static ssize_t wilc_debug_level_write(struct file *filp,
> + const char __user *buf, size_t count,
> + loff_t *ppos)
> {
> int flag = 0;
> int ret;
> @@ -60,7 +63,9 @@ static ssize_t wilc_debug_level_write(struct file *filp,
> const char __user *buf,
> return ret;
>
> if (flag > DBG_LEVEL_ALL) {
> - pr_info("%s, value (0x%08x) is out of range, stay previous flag
> (0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
> + pr_info("%s, value (0x%08x) is out of range,", __func__, flag);
> + pr_info("stay previous flag (0x%08x)\n",
> + atomic_read(&WILC_DEBUG_LEVEL));
No, you just changed this to two different messages, it's not the
correct fix here. Just wrap the line after the string, checkpatch will
not complain when you do that.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: wilc1000: Fixing coding style issues
Here is the full patch after your review:
Fixing coding style issues in drivers/staging/wilc1000/wilc_debugfs.c
Thank you about the information for split strings, I didn't find the
right way to do it.
Best,
V.
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 7d32de9..d651b20 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -20,7 +20,7 @@
static struct dentry *wilc_dir;
/*
- *
+ *
*/
#define DEBUG BIT(0)
#define INFOBIT(1)
@@ -32,10 +32,11 @@
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
- *
+ *
*/
-static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
+size_t count, loff_t *ppos)
{
char buf[128];
int res = 0;
@@ -44,13 +45,15 @@ static ssize_t wilc_debug_level_read(struct file *file,
char __user *userbuf, si
if (*ppos > 0)
return 0;
- res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
atomic_read(&WILC_DEBUG_LEVEL));
+ res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
+ atomic_read(&WILC_DEBUG_LEVEL));
return simple_read_from_buffer(userbuf, count, ppos, buf, res);
}
-static ssize_t wilc_debug_level_write(struct file *filp, const char __user
*buf,
- size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_write(struct file *filp,
+ const char __user *buf, size_t count,
+ loff_t *ppos)
{
int flag = 0;
int ret;
@@ -60,7 +63,8 @@ static ssize_t wilc_debug_level_write(struct file *filp,
const char __user *buf,
return ret;
if (flag > DBG_LEVEL_ALL) {
- pr_info("%s, value (0x%08x) is out of range, stay previous flag
(0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
+ pr_info("%s, value (0x%08x) is out of range, stay previous flag
(0x%08x)\n",
+ __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
return -EINVAL;
}
@@ -75,7 +79,7 @@ static ssize_t wilc_debug_level_write(struct file *filp,
const char __user *buf,
}
/*
- *
+ *
*/
#define FOPS(_open, _read, _write, _poll) { \
@@ -94,7 +98,12 @@ struct wilc_debugfs_info_t {
};
static struct wilc_debugfs_info_t debugfs_info[] = {
- { "wilc_debug_level", 0666, (DEBUG | ERR), FOPS(NULL,
wilc_debug_level_read, wilc_debug_level_write, NULL), },
+ {
+ "wilc_debug_level",
+ 0666,
+ (DEBUG | ERR),
+ FOPS(NULL, wilc_debug_level_read, wilc_debug_level_write, NULL),
+ },
};
static int __init wilc_debugfs_init(void)
--
1.9.1
signature.asc
Description: Digital signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: wilc1000: Fixing coding style issues
On Tue, May 02, 2017 at 03:34:05PM +0200, Vincent Siles wrote: > Here is the full patch after your review: > Fixing coding style issues in drivers/staging/wilc1000/wilc_debugfs.c > > Thank you about the information for split strings, I didn't find the > right way to do it. > > Best, > V. That is a very strange changelog patch here, don't you think? :) Please fix up. Also, please version your patches, SubmittingPatches describes how to do this the correct way. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/5] staging: wilc1000: Function signature too long
Splitting functions signature across several lines to fin in the
80 characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 4c28ee2..a225244 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -35,7 +35,8 @@
*
*/
-static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
+size_t count, loff_t *ppos)
{
char buf[128];
int res = 0;
@@ -49,8 +50,9 @@ static ssize_t wilc_debug_level_read(struct file *file, char
__user *userbuf, si
return simple_read_from_buffer(userbuf, count, ppos, buf, res);
}
-static ssize_t wilc_debug_level_write(struct file *filp, const char __user
*buf,
- size_t count, loff_t *ppos)
+static ssize_t wilc_debug_level_write(struct file *filp,
+ const char __user *buf, size_t count,
+ loff_t *ppos)
{
int flag = 0;
int ret;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/5] staging: wilc1000: Fixing coding style: wilc_debugfs.c
v1: Fixing coding style of the file drivers/staging/wilc1000/wilc_debugfs.c v2: Correctly split pr_info string across multiple lines Splitting the patch: one patch per modification Better commit message Vincent Siles (5): staging: wilc1000: Last line is empty staging: wilc1000: Stripping '-' comments staging: wilc1000: Function signature too long staging: wilc1000: Function calls too long staging: wilc1000: Fixing struct definition layout drivers/staging/wilc1000/wilc_debugfs.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/5] staging: wilc1000: Last line is empty
Removing empty line at the end of the file Signed-off-by: Vincent Siles --- drivers/staging/wilc1000/wilc_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c index 7d32de9..5c93c7c 100644 --- a/drivers/staging/wilc1000/wilc_debugfs.c +++ b/drivers/staging/wilc1000/wilc_debugfs.c @@ -122,4 +122,3 @@ static void __exit wilc_debugfs_remove(void) module_exit(wilc_debugfs_remove); #endif - -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/5] staging: wilc1000: Stripping '-' comments
Removing some '-' comments to fit in the 80 characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 5c93c7c..4c28ee2 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -20,7 +20,7 @@
static struct dentry *wilc_dir;
/*
- *
+ *
*/
#define DEBUG BIT(0)
#define INFOBIT(1)
@@ -32,7 +32,7 @@
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
- *
+ *
*/
static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
size_t count, loff_t *ppos)
@@ -75,7 +75,7 @@ static ssize_t wilc_debug_level_write(struct file *filp,
const char __user *buf,
}
/*
- *
+ *
*/
#define FOPS(_open, _read, _write, _poll) { \
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/5] staging: wilc1000: Fixing struct definition layout
Split struct definition across multiple line to fit in the 80 characters
limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 12d356a..ce54864 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -98,7 +98,12 @@ struct wilc_debugfs_info_t {
};
static struct wilc_debugfs_info_t debugfs_info[] = {
- { "wilc_debug_level", 0666, (DEBUG | ERR), FOPS(NULL,
wilc_debug_level_read, wilc_debug_level_write, NULL), },
+ {
+ "wilc_debug_level",
+ 0666,
+ (DEBUG | ERR),
+ FOPS(NULL, wilc_debug_level_read, wilc_debug_level_write, NULL),
+ },
};
static int __init wilc_debugfs_init(void)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 4/5] staging: wilc1000: Function calls too long
Splitting function calls across multiple lines to fit in the 80
characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index a225244..12d356a 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -45,7 +45,8 @@ static ssize_t wilc_debug_level_read(struct file *file, char
__user *userbuf,
if (*ppos > 0)
return 0;
- res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
atomic_read(&WILC_DEBUG_LEVEL));
+ res = scnprintf(buf, sizeof(buf), "Debug Level: %x\n",
+ atomic_read(&WILC_DEBUG_LEVEL));
return simple_read_from_buffer(userbuf, count, ppos, buf, res);
}
@@ -62,7 +63,8 @@ static ssize_t wilc_debug_level_write(struct file *filp,
return ret;
if (flag > DBG_LEVEL_ALL) {
- pr_info("%s, value (0x%08x) is out of range, stay previous flag
(0x%08x)\n", __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
+ pr_info("%s, value (0x%08x) is out of range, stay previous flag
(0x%08x)\n",
+ __func__, flag, atomic_read(&WILC_DEBUG_LEVEL));
return -EINVAL;
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] vmbus: remove unused vmbus_sendpacket_multipagebuffer
This function is not used anywhere in current code.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 56 --
include/linux/hyperv.h | 6 --
2 files changed, 62 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 736ac76d2a6a..357f3244d0e2 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -808,62 +808,6 @@ int vmbus_sendpacket_mpb_desc(struct vmbus_channel
*channel,
}
EXPORT_SYMBOL_GPL(vmbus_sendpacket_mpb_desc);
-/*
- * vmbus_sendpacket_multipagebuffer - Send a multi-page buffer packet
- * using a GPADL Direct packet type.
- */
-int vmbus_sendpacket_multipagebuffer(struct vmbus_channel *channel,
- struct hv_multipage_buffer *multi_pagebuffer,
- void *buffer, u32 bufferlen, u64 requestid)
-{
- struct vmbus_channel_packet_multipage_buffer desc;
- u32 descsize;
- u32 packetlen;
- u32 packetlen_aligned;
- struct kvec bufferlist[3];
- u64 aligned_data = 0;
- u32 pfncount = NUM_PAGES_SPANNED(multi_pagebuffer->offset,
-multi_pagebuffer->len);
-
- if (pfncount > MAX_MULTIPAGE_BUFFER_COUNT)
- return -EINVAL;
-
- /*
-* Adjust the size down since vmbus_channel_packet_multipage_buffer is
-* the largest size we support
-*/
- descsize = sizeof(struct vmbus_channel_packet_multipage_buffer) -
- ((MAX_MULTIPAGE_BUFFER_COUNT - pfncount) *
- sizeof(u64));
- packetlen = descsize + bufferlen;
- packetlen_aligned = ALIGN(packetlen, sizeof(u64));
-
-
- /* Setup the descriptor */
- desc.type = VM_PKT_DATA_USING_GPA_DIRECT;
- desc.flags = VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED;
- desc.dataoffset8 = descsize >> 3; /* in 8-bytes granularity */
- desc.length8 = (u16)(packetlen_aligned >> 3);
- desc.transactionid = requestid;
- desc.rangecount = 1;
-
- desc.range.len = multi_pagebuffer->len;
- desc.range.offset = multi_pagebuffer->offset;
-
- memcpy(desc.range.pfn_array, multi_pagebuffer->pfn_array,
- pfncount * sizeof(u64));
-
- bufferlist[0].iov_base = &desc;
- bufferlist[0].iov_len = descsize;
- bufferlist[1].iov_base = buffer;
- bufferlist[1].iov_len = bufferlen;
- bufferlist[2].iov_base = &aligned_data;
- bufferlist[2].iov_len = (packetlen_aligned - packetlen);
-
- return hv_ringbuffer_write(channel, bufferlist, 3);
-}
-EXPORT_SYMBOL_GPL(vmbus_sendpacket_multipagebuffer);
-
/**
* vmbus_recvpacket() - Retrieve the user packet on the specified channel
* @channel: Pointer to vmbus_channel structure.
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index f681f7bc9b43..36449d015ff8 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1053,12 +1053,6 @@ extern int vmbus_sendpacket_pagebuffer_ctl(struct
vmbus_channel *channel,
u64 requestid,
u32 flags);
-extern int vmbus_sendpacket_multipagebuffer(struct vmbus_channel *channel,
- struct hv_multipage_buffer *mpb,
- void *buffer,
- u32 bufferlen,
- u64 requestid);
-
extern int vmbus_sendpacket_mpb_desc(struct vmbus_channel *channel,
struct vmbus_packet_mpb_array *mpb,
u32 desc_size,
--
2.11.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/5] staging: wilc1000: Last line is empty
On Tue, May 02, 2017 at 04:18:39PM +0200, Vincent Siles wrote: > Removing empty line at the end of the file Hi Vincent, Small comment on your patch series. You may have more success if your summary phrase is in imperative mood i.e sounds like you are commanding changes to be made to the code base Recent examples from LKML fpga manager: Add Altera CvP driver sched/fair: fix load balancer behavior when cgroup is in use Aslo the changelog should describe the reason for the patch and then describe the changes made in the patch to rectify the previously described problem. See Documentation/process/submitting-patches.rst for complete description of how to write a changelog. Good luck, Tobin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed coding style issue
Fixed checkpatch.pl issue
ERROR: that open brace { should be on the previous line
Signed-off-by: Fabrizio Perria
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
index b4c13ff..d4d53fb 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
@@ -338,8 +338,7 @@ bool GetTs(
else
{
// In WMM case: we use 4 TID only
- if (!IsACValid(TID))
- {
+ if (!IsACValid(TID)) {
IEEE80211_DEBUG(IEEE80211_DL_ERR, " in %s(), TID(%d) is
not valid\n", __func__, TID);
return false;
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Fix coding style issues
Patch v2 addresses review comments from Greg KH. Following is a single patch with only one type of coding style issues fixed. Adheer Chandravanshi (1): staging: rtl8723bs: Fix coding style issues drivers/staging/rtl8723bs/include/rtl8192c_rf.h | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: rtl8723bs: Fix coding style issues
checkpatch.pl reported errors for use of extra whitespaces in the function prototypes. Removed extra spaces to meet the coding standards. Signed-off-by: Adheer Chandravanshi --- drivers/staging/rtl8723bs/include/rtl8192c_rf.h | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h index 0dbee56..97900a3 100644 --- a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h +++ b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h @@ -19,19 +19,16 @@ /* */ /* RF RL6052 Series API */ /* */ -void rtl8192c_RF_ChangeTxPath(struct adapter *Adapter, - u16 DataRate); -void rtl8192c_PHY_RF6052SetBandwidth( - struct adapter *Adapter, - enum CHANNEL_WIDTH Bandwidth); -void rtl8192c_PHY_RF6052SetCckTxPower( - struct adapter *Adapter, - u8* pPowerlevel); -void rtl8192c_PHY_RF6052SetOFDMTxPower( - struct adapter *Adapter, - u8* pPowerLevel, - u8 Channel); -intPHY_RF6052_Config8192C(struct adapter * Adapter ); +void rtl8192c_RF_ChangeTxPath(struct adapter *Adapter, + u16 DataRate); +void rtl8192c_PHY_RF6052SetBandwidth(struct adapter *Adapter, +enum CHANNEL_WIDTH Bandwidth); +void rtl8192c_PHY_RF6052SetCckTxPower(struct adapter *Adapter, + u8 *pPowerlevel); +void rtl8192c_PHY_RF6052SetOFDMTxPower(struct adapter *Adapter, + u8 *pPowerLevel, + u8 Channel); +int PHY_RF6052_Config8192C(struct adapter *Adapter); /*--Exported Function prototype-*/ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: unisys: Solve sparse warning
The following commit fixes the following sparse report: drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to restricted __le64 by casting readq (which is unsigned long on x86) to u64, as expected by the seq_printf call. Signed-off-by: Marcos Paulo de Souza --- Just compiled tested on x86_64. drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c index 6997b16..46d33e6 100644 --- a/drivers/staging/unisys/visorhba/visorhba_main.c +++ b/drivers/staging/unisys/visorhba/visorhba_main.c @@ -657,7 +657,7 @@ static int info_debugfs_show(struct seq_file *seq, void *v) seq_printf(seq, "phys_flags_addr = 0x%016llx\n", phys_flags_addr); seq_printf(seq, "FeatureFlags = %llu\n", - (__le64)readq(devdata->flags_addr)); + (u64)readq(devdata->flags_addr)); } seq_printf(seq, "acquire_failed_cnt = %llu\n", devdata->acquire_failed_cnt); -- 2.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging : rtl8188eu : remove void function return
kernel coding style doesn't allow the return statement in void function. Signed-off-by: Surender Polsani --- Changes for v2: corrected subject line as suggested Changes for v3: modified from line as suggested by Greg KH placed a semicolon in label for fixing build error --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index d04b7fb..428996e 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) skip_dm: /* Check GPIO to determine current RF on/off and Pbc status. */ /* Check Hardware Radio ON/OFF or not */ - return; + ; } void rtw_hal_dm_init(struct adapter *Adapter) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
