Re: [Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

2017-02-25 Thread Greg KH 
On Fri, Feb 24, 2017 at 09:49:17PM +, Long Li wrote:
> A PCI_EJECT message can arrive at the same time we are calling 
> pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS 
> message or in create_root_hv_pci_bus(), in this case we could potentailly 
> modify the bus from multiple places. Properly lock the bus access.

Properly wrap your changelog comments at 72 columns like your editor is
telling you to do...

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bcm2835-audio: Removed redundant check

2017-02-25 Thread Alexandru Jercaianu 
This was reported by checkpatch.pl

Signed-off-by: Alexandru Jercaianu 
---
 drivers/staging/bcm2835-audio/bcm2835-pcm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c 
b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 9e79236..76d85c5 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
@@ -56,8 +56,7 @@ static struct snd_pcm_hardware snd_bcm2835_playback_spdif_hw 
= {
 static void snd_bcm2835_playback_free(struct snd_pcm_runtime *runtime)
 {
audio_info("Freeing up alsa stream here ..\n");
-   if (runtime->private_data)
-   kfree(runtime->private_data);
+   kfree(runtime->private_data);
runtime->private_data = NULL;
 }
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] staging: vchiq_arm: Remove unnecessary includes

2017-02-25 Thread Stefan Wahren 
Including those headers is unnecessary, so we better remove them.

Signed-off-by: Stefan Wahren 
---
 .../interface/vchiq_arm/vchiq_2835_arm.c   |2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index 04c605d..6581923 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -37,12 +37,10 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #define TOTAL_SLOTS (VCHIQ_SLOT_ZERO_SLOTS + 2 * 32)
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] staging: vchiq_arm: Don't define PAGE_SIZE

2017-02-25 Thread Stefan Wahren 
There is no need to define PAGE_SIZE in the vchiq driver
so remove the define from vchiq_pagelist.h .

Signed-off-by: Stefan Wahren 
---
 .../interface/vchiq_arm/vchiq_pagelist.h   |3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
index 12c304c..926c247 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h
@@ -34,9 +34,6 @@
 #ifndef VCHIQ_PAGELIST_H
 #define VCHIQ_PAGELIST_H
 
-#ifndef PAGE_SIZE
-#define PAGE_SIZE 4096
-#endif
 #define CACHE_LINE_SIZE 32
 #define PAGELIST_WRITE 0
 #define PAGELIST_READ 1
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/3] staging: vchiq_arm: Include linux/mm.h

2017-02-25 Thread Stefan Wahren 
vchiq_2835_arm.c uses functions and macros like put_page() or
PAGE_ALIGN(). So we better include the necessary header.

Signed-off-by: Stefan Wahren 
---
 .../interface/vchiq_arm/vchiq_2835_arm.c   |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index 6581923..f5df5c4 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -40,6 +40,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-25 Thread Stefan Wahren 
[add Eric]

> Michael Zoran  hat am 18. Februar 2017 um 12:59 
> geschrieben:
> 
> 
> On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote:
> > The original github source allowed for the cache-line-size property
> > to be missing.  Since recent firmwares also require this property,
> > it makes sense to always require it in the driver as well.
> > 
> > If the cache-line-size property is missing, then the driver probe
> > should fail as no dev since the kernel and dt may be out of sync.
> > The fix is to add a check for the return value of
> > of_property_read_u32.
> > 
> > Changes V2:
> > 1. Add error message if cache-line-size is missing.
> > 2. Simple check for non-zero return value from 
> >of_property_read_u32.
> > 
> > Signed-off-by: Michael Zoran 
> > ---
> >  .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c|
> > 8 +++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > index e6241fb5cfa6..3aeffcb9c87e 100644
> > ---
> > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > +++
> > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > @@ -121,8 +121,14 @@ int vchiq_platform_init(struct platform_device
> > *pdev, VCHIQ_STATE_T *state)
> > if (err < 0)
> > return err;
> >  
> > -   (void)of_property_read_u32(dev->of_node, "cache-line-size",
> > +   err = of_property_read_u32(dev->of_node, "cache-line-size",
> >&g_cache_line_size);
> > +
> > +   if (err) {
> > +   dev_err(dev, "Missing cache-line-size property\n");
> > +   return -ENODEV;
> > +   }
> > +
> > g_fragments_size = 2 * g_cache_line_size;
> >  
> > /* Allocate space for the channels in coherent memory */
> 
> If anybody is willing to add an Reviewed-by, Acked, or even tested-by
> to this it would be great.  I know gregk is a busy guy so it might make
> sense to make a note that someone else looked at this and that I'm not
> out in left field.
> 
> It would be really great if this made it into 4.11.  I'm a bit
> concerned about someone accidently trying to mix this driver with an
> ancient DT. Things would probably sort of work if that was done, but it
> would result in difficult to debug errors.

I think Greg is waiting for Eric's Ack, but it seems you didn't send him a copy.

@Eric: Are you okay with this patch?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-25 Thread Michael Zoran 
On Sat, 2017-02-25 at 14:38 +0100, Stefan Wahren wrote:
> [add Eric]
> 
> > Michael Zoran  hat am 18. Februar 2017 um
> > 12:59 geschrieben:
> > 
> > 
> > On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote:
> > > The original github source allowed for the cache-line-size
> > > property
> > > to be missing.  Since recent firmwares also require this
> > > property,
> > > it makes sense to always require it in the driver as well.
> > > 
> > > If the cache-line-size property is missing, then the driver probe
> > > should fail as no dev since the kernel and dt may be out of sync.
> > > The fix is to add a check for the return value of
> > > of_property_read_u32.
> > > 
> > > Changes V2:
> > >   1. Add error message if cache-line-size is missing.
> > >   2. Simple check for non-zero return value from 
> > >      of_property_read_u32.
> > > 
> > > Signed-off-by: Michael Zoran 
> > > ---
> > >  .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c  
> > >   |
> > > 8 +++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)
> > > 
> > > diff --git
> > > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_ar
> > > m.c
> > > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_ar
> > > m.c
> > > index e6241fb5cfa6..3aeffcb9c87e 100644
> > > ---
> > > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_ar
> > > m.c
> > > +++
> > > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_ar
> > > m.c
> > > @@ -121,8 +121,14 @@ int vchiq_platform_init(struct
> > > platform_device
> > > *pdev, VCHIQ_STATE_T *state)
> > >   if (err < 0)
> > >   return err;
> > >  
> > > - (void)of_property_read_u32(dev->of_node, "cache-line-
> > > size",
> > > + err = of_property_read_u32(dev->of_node, "cache-line-
> > > size",
> > >      &g_cache_line_size);
> > > +
> > > + if (err) {
> > > + dev_err(dev, "Missing cache-line-size
> > > property\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > >   g_fragments_size = 2 * g_cache_line_size;
> > >  
> > >   /* Allocate space for the channels in coherent memory */
> > 
> > If anybody is willing to add an Reviewed-by, Acked, or even tested-
> > by
> > to this it would be great.  I know gregk is a busy guy so it might
> > make
> > sense to make a note that someone else looked at this and that I'm
> > not
> > out in left field.
> > 
> > It would be really great if this made it into 4.11.  I'm a bit
> > concerned about someone accidently trying to mix this driver with
> > an
> > ancient DT. Things would probably sort of work if that was done,
> > but it
> > would result in difficult to debug errors.
> 
> I think Greg is waiting for Eric's Ack, but it seems you didn't send
> him a copy.
> 
> @Eric: Are you okay with this patch?

What's the rule as to who exactly I should be including on patches? 
get_maintainer.pl displays a very long list for stagging, so it isn't
clear to me who should be getting this.

Also, I wonder if I should complain to someone about the linux-rpi-
kernel email list.  It appears to be really unreliable.  I don't think
it's my e-mail server since I seem to get everything else and it's
running on a very major provider in my area.  I occasionally see others
complain about e-mail not getting through too.

Thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-25 Thread Stefan Wahren 
> 
> What's the rule as to who exactly I should be including on patches? 
> get_maintainer.pl displays a very long list for stagging, so it isn't
> clear to me who should be getting this.

At least the active maintainers (bcm2835 + staging) and the relevant mailing 
lists. Usually i try to avoid sending ARM stuff to linux-kernel. All the other 
output from get_maintainers (commiter and authors) could be helpful in the lack 
of a maintainer or in case of a fix for a specific commit. At the end it's only 
a tool like checkpatch.

> 
> Also, I wonder if I should complain to someone about the linux-rpi-
> kernel email list.  It appears to be really unreliable.  I don't think
> it's my e-mail server since I seem to get everything else and it's
> running on a very major provider in my area.  I occasionally see others
> complain about e-mail not getting through too.

Yes, all subscriber to linux-rpi-kernel should be affected by this anti-spam 
stuff. I wrote an email to the owner in the hope to increase the limitation and 
avoid the manual unlock by the moderator. Last weekend i received a bunch of 
emails and some of them were from December 2016. This is unacceptable. I hope 
we will find a solution.

> 
> Thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-25 Thread Michael Zoran 
On Sat, 2017-02-25 at 19:15 +0100, Stefan Wahren wrote:
> > 
> > What's the rule as to who exactly I should be including on
> > patches? 
> > get_maintainer.pl displays a very long list for stagging, so it
> > isn't
> > clear to me who should be getting this.
> 
> At least the active maintainers (bcm2835 + staging) and the relevant
> mailing lists. Usually i try to avoid sending ARM stuff to linux-
> kernel. All the other output from get_maintainers (commiter and
> authors) could be helpful in the lack of a maintainer or in case of a
> fix for a specific commit. At the end it's only a tool like
> checkpatch.
> 
> 

OK.  Thanks for the explanation.

I think this patch may have simply dropped off people's inbox since I
sent it awhile ago and I had to make a few revisions.

If Eric doesn't respond in a few days I'll go ahead and resend it. I
know Eric's a busy guy as well.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bcm2835-audio - style fix, block comments

2017-02-25 Thread Derek Robson 
Fixed block comments as found by checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/bcm2835-audio/bcm2835-ctl.c | 3 ++-
 drivers/staging/bcm2835-audio/bcm2835-pcm.c | 3 ++-
 drivers/staging/bcm2835-audio/bcm2835.h | 5 -
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c 
b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1bf53e5..1dd68c116f57 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -248,7 +248,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol 
*kcontrol,
 {
/* bcm2835 supports only consumer mode and sets all other format flags
 * automatically. So the only thing left is signalling non-audio
-* content */
+* content
+*/
ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
return 0;
 }
diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c 
b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 16127e062661..d965e61b8a6a 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
@@ -308,7 +308,8 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream 
*substream)
 
/* notify the vchiq that it should enter spdif passthrough mode by
 * setting channels=0 (see
-* https://github.com/raspberrypi/linux/issues/528) */
+* https://github.com/raspberrypi/linux/issues/528)
+*/
if (chip->spdif_status & IEC958_AES0_NONAUDIO)
channels = 0;
else
diff --git a/drivers/staging/bcm2835-audio/bcm2835.h 
b/drivers/staging/bcm2835-audio/bcm2835.h
index 36e3ef80e60c..292cf1dc4d7a 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/bcm2835-audio/bcm2835.h
@@ -26,11 +26,6 @@
 #include 
 #include 
 
-/*
-#define AUDIO_DEBUG_ENABLE
-#define AUDIO_VERBOSE_DEBUG_ENABLE
- */
-
 /* Debug macros */
 
 #ifdef AUDIO_DEBUG_ENABLE
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/9] drivers: staging: rtl8712 - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments across whole of the rtl8712 driver
Found using check patch


Derek Robson (9):
  Staging: rtl8712: rtl871x_cmd.h - block comments
  Staging: rtl8712: rtl871x_event.h - style fix
  Staging: rtl8712: rtl871x_io.h - style fix
  Staging: rtl8712: rtl871x_mlme.h - style fix
  Staging: rtl8712: rtl871x_mp_ioctl.h - style fix
  Staging: rtl8712: rtl871x_pwrctrl.h - style fix
  Staging: rtl8712: rtl871x_recv.h - style fix
  Staging: rtl8712: wifi.h - style fix
  Staging: rtl8712: wlan_bssdef.h - style fix

 drivers/staging/rtl8712/rtl871x_cmd.h  |  2 +-
 drivers/staging/rtl8712/rtl871x_event.h|  8 
 drivers/staging/rtl8712/rtl871x_io.h   | 14 ++---
 drivers/staging/rtl8712/rtl871x_mlme.h | 16 +++
 drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32 +++---
 drivers/staging/rtl8712/rtl871x_pwrctrl.h  | 10 +-
 drivers/staging/rtl8712/rtl871x_recv.h | 12 +--
 drivers/staging/rtl8712/wifi.h | 12 +--
 drivers/staging/rtl8712/wlan_bssdef.h  |  6 +++---
 9 files changed, 56 insertions(+), 56 deletions(-)

-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/9] Staging: rtl8712: rtl871x_event.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_event.h | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_event.h 
b/drivers/staging/rtl8712/rtl871x_event.h
index 5db8620980e5..517137906e6c 100644
--- a/drivers/staging/rtl8712/rtl871x_event.h
+++ b/drivers/staging/rtl8712/rtl871x_event.h
@@ -34,7 +34,7 @@
 
 /*
  * Used to report a bss has been scanned
-*/
+ */
 struct survey_event{
struct wlan_bssid_ex bss;
 };
@@ -42,7 +42,7 @@ struct survey_event   {
 /*
  * Used to report that the requested site survey has been done.
  * bss_cnt indicates the number of bss that has been reported.
-*/
+ */
 struct surveydone_event {
unsigned intbss_cnt;
 
@@ -54,7 +54,7 @@ struct surveydone_event {
  *  -1: authentication fail
  *  -2: association fail
  *  > 0: TID
-*/
+ */
 struct joinbss_event {
struct  wlan_networknetwork;
 };
@@ -62,7 +62,7 @@ struct joinbss_event {
 /*
  * Used to report a given STA has joinned the created BSS.
  * It is used in AP/Ad-HoC(M) mode.
-*/
+ */
 struct stassoc_event {
unsigned char macaddr[6];
unsigned char rsvd[2];
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/9] Staging: rtl8712: rtl871x_cmd.h - block comments

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_cmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h 
b/drivers/staging/rtl8712/rtl871x_cmd.h
index 4734ca856aa2..24da2ccea04f 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -144,7 +144,7 @@ struct disconnect_parm {
  * #define IW_MODE_REPEAT  4   // Wireless Repeater (forwarder)
  * #define IW_MODE_SECOND  5   // Secondary master/repeater (backup)
  * #define IW_MODE_MONITOR 6   // Passive monitor (listen only)
-*/
+ */
 struct setopmode_parm {
u8  mode;
u8  rsvd[3];
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4/9] Staging: rtl8712: rtl871x_mlme.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_mlme.h | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_mlme.h 
b/drivers/staging/rtl8712/rtl871x_mlme.h
index 53a23234c598..b21f28140f53 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.h
+++ b/drivers/staging/rtl8712/rtl871x_mlme.h
@@ -68,14 +68,14 @@
 #define _FW_UNDER_SURVEY   WIFI_SITE_MONITOR
 
 /*
-there are several "locks" in mlme_priv,
-since mlme_priv is a shared resource between many threads,
-like ISR/Call-Back functions, the OID handlers, and even timer functions.
-Each _queue has its own locks, already.
-Other items are protected by mlme_priv.lock.
-To avoid possible dead lock, any thread trying to modify mlme_priv
-SHALL not lock up more than one lock at a time!
-*/
+ * there are several "locks" in mlme_priv,
+ * since mlme_priv is a shared resource between many threads,
+ * like ISR/Call-Back functions, the OID handlers, and even timer functions.
+ * Each _queue has its own locks, already.
+ * Other items are protected by mlme_priv.lock.
+ * To avoid possible dead lock, any thread trying to modify mlme_priv
+ * SHALL not lock up more than one lock at a time!
+ */
 
 #define traffic_threshold  10
 #definetraffic_scan_period 500
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32 +++---
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h 
b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
index 1102451a733d..c99a6dbae476 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
@@ -162,26 +162,26 @@ static const struct oid_obj_priv oid_rtl_seg_81_80_00[] = 
{
 */
{1, oid_rt_pro_set_channel_direct_call_hdl},/*0x08*/
{1, oid_null_function}, /*0x09
-   * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL
-   */
+* OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL
+*/
{1, oid_null_function}, /*0x0A
-   * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL
-   */
+* OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL
+*/
{1, oid_rt_pro_set_continuous_tx_hdl},  /*0x0B
-   * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL
-   */
+* 
OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL
+*/
{1, oid_rt_pro_set_single_carrier_tx_hdl}, /*0x0C
-   * OID_RT_PRO_SET_SINGLE_CARRIER_TX_CONTINUOUS
-   */
+   * 
OID_RT_PRO_SET_SINGLE_CARRIER_TX_CONTINUOUS
+   */
{1, oid_null_function}, /*0x0D
-   * OID_RT_PRO_SET_TX_ANTENNA_BB
-   */
+* OID_RT_PRO_SET_TX_ANTENNA_BB
+*/
{1, oid_rt_pro_set_antenna_bb_hdl}, /*0x0E*/
{1, oid_null_function}, /*0x0F  OID_RT_PRO_SET_CR_SCRAMBLER*/
{1, oid_null_function}, /*0x10  OID_RT_PRO_SET_CR_NEW_FILTER*/
{1, oid_rt_pro_set_tx_power_control_hdl}, /*0x11
-   * OID_RT_PRO_SET_TX_POWER_CONTROL
-   */
+  * 
OID_RT_PRO_SET_TX_POWER_CONTROL
+  */
{1, oid_null_function}, /*0x12  OID_RT_PRO_SET_CR_TX_CONFIG*/
{1, oid_null_function}, /*0x13
 * OID_RT_PRO_GET_TX_POWER_CONTROL
@@ -218,11 +218,11 @@ static const struct oid_obj_priv oid_rtl_seg_81_80_20[] = 
{
 *OID_RT_PRO_QUERY_PERMANENT_ADDRESS
 */
{1, oid_null_function}, /*0x2A
-*OID_RT_PRO_SET_PHILIPS_RF_PARAMETERS
-*/
+*OID_RT_PRO_SET_PHILIPS_RF_PARAMETERS
+*/
{1, oid_rt_pro_set_carrier_suppression_tx_hdl},/*0x2B
-*OID_RT_PRO_SET_CARRIER_SUPPRESSION_TX
-*/
+   
*OID_RT_PRO_SET_CARRIER_SUPPRESSION_TX
+   */
{1, oid_null_function}, /*0x2C  OID_RT_PRO_RECEIVE_PACKET*/
{1, oid_null_function}, /*0x2D  OID_RT_PRO_WRITE_EEPROM_BYTE*/
{1, oid_null_function}, /*0x2E  OID_RT_PRO_READ_EEPROM_BYTE*/
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/9] Staging: rtl8712: rtl871x_io.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments.
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_io.h | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_io.h 
b/drivers/staging/rtl8712/rtl871x_io.h
index 26dd24cddd38..dd054d7367b3 100644
--- a/drivers/staging/rtl8712/rtl871x_io.h
+++ b/drivers/staging/rtl8712/rtl871x_io.h
@@ -49,9 +49,9 @@
 #define _IO_CMDMASK_   (0x1F80)
 
 /*
-   For prompt mode accessing, caller shall free io_req
-   Otherwise, io_handler will free io_req
-*/
+ * For prompt mode accessing, caller shall free io_req
+ * Otherwise, io_handler will free io_req
+ */
 /* IO STATUS TYPE */
 #define _IO_ERR_   BIT(2)
 #define _IO_SUCCESS_   BIT(1)
@@ -69,8 +69,8 @@
 #define IO_WR16_ASYNC  (_IO_WRITE_ | _IO_HW_)
 #define IO_WR8_ASYNC   (_IO_WRITE_ | _IO_BYTE_)
 /*
-   Only Sync. burst accessing is provided.
-*/
+ * Only Sync. burst accessing is provided.
+ */
 #define IO_WR_BURST(x) (IO_WRITE_ | _IO_SYNC_ | _IO_BURST_ | \
((x) & _IOSZ_MASK_))
 #define IO_RD_BURST(x) (_IO_SYNC_ | _IO_BURST_ | ((x) & _IOSZ_MASK_))
@@ -218,8 +218,8 @@ struct reg_protocol_wt {
 };
 
 /*
-Below is the data structure used by _io_handler
-*/
+ * Below is the data structure used by _io_handler
+ */
 
 struct io_queue {
spinlock_t lock;
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 6/9] Staging: rtl8712: rtl871x_pwrctrl.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style fo block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.h 
b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
index c82fdf85d474..4a873d053eea 100644
--- a/drivers/staging/rtl8712/rtl871x_pwrctrl.h
+++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
@@ -48,11 +48,11 @@ enum Power_Mgnt {
 };
 
 /*
-   BIT[2:0] = HW state
-   BIT[3] = Protocol PS state, 0: register active state,
-   1: register sleep state
-   BIT[4] = sub-state
-*/
+ * BIT[2:0] = HW state
+ * BIT[3] = Protocol PS state, 0: register active state,
+ * 1: register sleep state
+ * BIT[4] = sub-state
+ */
 
 #definePS_DPS  BIT(0)
 #definePS_LCLK (PS_DPS)
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 7/9] Staging: rtl8712: rtl871x_recv.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/rtl871x_recv.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_recv.h 
b/drivers/staging/rtl8712/rtl871x_recv.h
index f419943ad75d..6c535647daed 100644
--- a/drivers/staging/rtl8712/rtl871x_recv.h
+++ b/drivers/staging/rtl8712/rtl871x_recv.h
@@ -74,12 +74,12 @@ struct rx_pkt_attrib {
 };
 
 /*
-accesser of recv_priv: recv_entry(dispatch / passive level);
-recv_thread(passive) ; returnpkt(dispatch)
-; halt(passive) ;
-
-using enter_critical section to protect
-*/
+ * accesser of recv_priv: recv_entry(dispatch / passive level);
+ * recv_thread(passive) ; returnpkt(dispatch)
+ * ; halt(passive) ;
+ *
+ * using enter_critical section to protect
+ */
 struct recv_priv {
spinlock_t lock;
struct  __queue free_recv_queue;
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 8/9] Staging: rtl8712: wifi.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/wifi.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
index 74dfc9b0e494..556367bfbe8a 100644
--- a/drivers/staging/rtl8712/wifi.h
+++ b/drivers/staging/rtl8712/wifi.h
@@ -370,7 +370,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char 
*pframe)
 
 
 /*-
-   Below is for the security related definition
+ * Below is for the security related definition
  *-
  */
 #define _RESERVED_FRAME_TYPE_  0
@@ -415,7 +415,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char 
*pframe)
 
 
 /* ---
-   Below is the fixed elements...
+ * Below is the fixed elements...
  * ---
  */
 #define _AUTH_ALGM_NUM_2
@@ -444,14 +444,14 @@ static inline unsigned char *get_hdr_bssid(unsigned char 
*pframe)
 #define cap_ShortPremble BIT(5)
 
 /*-
-   Below is the definition for 802.11i / 802.1x
+ * Below is the definition for 802.11i / 802.1x
  
*--
  */
 #define _IEEE8021X_MGT_1   /*WPA */
 #define _IEEE8021X_PSK_2   /* WPA with pre-shared 
key */
 
 /*-
-   Below is the definition for WMM
+ * Below is the definition for WMM
  
*--
  */
 #define _WMM_IE_Length_7  /* for WMM STA */
@@ -459,7 +459,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char 
*pframe)
 
 
 /*-
-   Below is the definition for 802.11n
+ * Below is the definition for 802.11n
  
*--
  */
 
@@ -498,7 +498,7 @@ struct ieee80211_bar {
 #define IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA  0x0004
 
 
- /**
+/*
  * struct ieee80211_ht_cap - HT capabilities
  *
  * This structure refers to "HT capabilities element" as
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 9/9] Staging: rtl8712: wlan_bssdef.h - style fix

2017-02-25 Thread Derek Robson 
Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/rtl8712/wlan_bssdef.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/wlan_bssdef.h 
b/drivers/staging/rtl8712/wlan_bssdef.h
index c0654ae4d70d..9dc9ce5a2ccc 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -53,9 +53,9 @@ struct NDIS_802_11_CONFIGURATION_FH {
 };
 
 /*
-   FW will only save the channel number in DSConfig.
-   ODI Handler will convert the channel number to freq. number.
-*/
+ * FW will only save the channel number in DSConfig.
+ * ODI Handler will convert the channel number to freq. number.
+ */
 struct NDIS_802_11_CONFIGURATION {
u32 Length; /* Length of structure */
u32 BeaconPeriod;   /* units are Kusec */
-- 
2.11.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] speakup: synth: Fix checkpatch warning

2017-02-25 Thread Man Choy 
Fix following checkpatch warning:

WARNING: line over 80 characters
+&synth->attributes) < 
0)

total: 0 errors, 1 warnings, 485 lines checked
Signed-off-by: Man Choy 
---
 drivers/staging/speakup/synth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..d984312 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -406,8 +406,8 @@ static int do_synth_init(struct spk_synth *in_synth)
speakup_register_var(var);
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
-   if (synth->attributes.name && sysfs_create_group(speakup_kobj,
-&synth->attributes) < 
0)
+   if (synth->attributes.name &&
+   sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: vt6656: Fix spaces and char limit

2017-02-25 Thread Jitendra Kumar Khasdev 
This is a patch to usbpipe.c to fix space and char limit warning found by
checkpatch tool.

Signed-off-by: Jitendra Khasdev 
---
 drivers/staging/vt6656/usbpipe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 1ae6a64..9ad8503 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -82,8 +82,8 @@ int vnt_control_in(struct vnt_private *priv, u8 request, u16 
value,
mutex_lock(&priv->usb_lock);
 
status = usb_control_msg(priv->usb,
-   usb_rcvctrlpipe(priv->usb, 0), request, 0xc0, 
value,
-   index, buffer, length, USB_CTL_WAIT);
+   usb_rcvctrlpipe(priv->usb, 0), request, 0xc0,
+   value, index, buffer, length, USB_CTL_WAIT);
 
mutex_unlock(&priv->usb_lock);
 
-- 
2.9.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

2017-02-25 Thread chetan 
Hi Greg,

> Always run checkpatch on your patches so you don't get a grumpy
> maintainer telling you to run your patches through checkpatch!

Since one change per patch has been included, initial patches in series 
will not be completely error/warning free, after running checkpatch.
However it has been ensured that no new issues are introduced
in the process of fixing the original ones.

I will fix up all other comments and resend complete series of patches.

thanks,
chetan

On 2017年02月25日 02:07, Greg KH wrote:
> On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote:
>> This is 02nd patch to file ks_wlan.h file fixing error of enclosing
>> complex macro value in parentheses
> 
> No need to have the "This is the XXX patch..." in the changelog text,
> you don't see that in any other commit logs, right?
> 
>>
>> ---
>> v2:
>>  - split multiple changes across different patches
>> v3:
>>  - mentioned patch revision in subject
>>  - incorporated review comment of correct indentation for do statement
>>
>>  drivers/staging/ks7010/ks_wlan.h | 6 --
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/ks7010/ks_wlan.h 
>> b/drivers/staging/ks7010/ks_wlan.h
>> index 668202d..33d6b28 100644
>> --- a/drivers/staging/ks7010/ks_wlan.h
>> +++ b/drivers/staging/ks7010/ks_wlan.h
>> @@ -36,8 +36,10 @@
>>  
>>  #ifdef KS_WLAN_DEBUG
>>  #define DPRINTK(n, fmt, args...) \
>> - if (KS_WLAN_DEBUG > (n)) \
>> -printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
>> +do { \
> 
> Always run checkpatch on your patches so you don't get a grumpy
> maintainer telling you to run your patches through checkpatch!
> 
> Please fix up all 3 of these and resend.
> 
> thanks,
> 
> greg k-h
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters

2017-02-25 Thread Chetan Sethi 
This patch fixes warning of line over 80 characters, as issued by
checkpatch.pl

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
v4:
 - modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 9ab80e1..668202d 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -18,10 +18,10 @@
 #include 
 #include 
 
-#include /* spinlock_t   
*/
-#include/* wait_queue_head_t
*/
-#include/* pid_t
*/
-#include/* struct net_device_stats,  struct sk_buff 
*/
+#include /* spinlock_t */
+#include/* wait_queue_head_t */
+#include/* pid_t */
+#include/* struct net_device_stats,  struct sk_buff */
 #include 
 #include 
 #include   /* struct atomic_t */
@@ -36,7 +36,8 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
- if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, 
__FUNCTION__, ## args)
+ if (KS_WLAN_DEBUG > (n)) \
+   printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

2017-02-25 Thread Chetan Sethi 
This patch fixes error of enclosing complex macro value in parentheses,
error as issued by checkpatch

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
 - incorporated review comment of correct indentation for do statement
v4:
 - modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 668202d..33d6b28 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -36,8 +36,10 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
- if (KS_WLAN_DEBUG > (n)) \
-   printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+do { \
+   if (KS_WLAN_DEBUG > (n)) \
+   printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+   } while (0)
 #else
 #define DPRINTK(n, fmt, args...)
 #endif
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces

2017-02-25 Thread Chetan Sethi 
This patch fixes coding style issue of using tabs instead of spaces at
start of line, error as issued by checkpatch.pl

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
v4:
 - modified description to exclude mention of patch number from changelog

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 33d6b28..94b648b 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -36,7 +36,7 @@
 
 #ifdef KS_WLAN_DEBUG
 #define DPRINTK(n, fmt, args...) \
-do { \
+   do { \
if (KS_WLAN_DEBUG > (n)) \
printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
} while (0)
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk

2017-02-25 Thread Chetan Sethi 
This patch fixes coding style issue of using pr_notice instead of printk,
warning as issued by checkpatch.pl

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
v4:
 - modified description to exclude mention of patch number from changelog
 - updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 94b648b..78beca7 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
-   printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+   pr_notice("%s: "fmt, __FUNCTION__, ## args); \
} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__

2017-02-25 Thread Chetan Sethi 
This patch fixes coding style issue of using __func__ instead of gcc
specific __FUNCTION__, warning as issued by checkpatch

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
v4:
 - modified description to exclude mention of patch number from changelog
 - updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 78beca7..79737bf 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
 #define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
-   pr_notice("%s: "fmt, __FUNCTION__, ## args); \
+   pr_notice("%s: "fmt, __func__, ## args); \
} while (0)
 #else
 #define DPRINTK(n, fmt, args...)
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly

2017-02-25 Thread Chetan Sethi 
This patch fixes coding style issue of having block comments using a
trailing */ on a separate line, warning as issued by checkpatch

Signed-off-by: Chetan Sethi 
---
v2:
 - split multiple changes across different patches
v3:
 - mentioned patch revision in subject
v4:
 - modified description to exclude mention of patch number from changelog
 - updated subject to include driver name

 drivers/staging/ks7010/ks_wlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 79737bf..1a63704 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -359,7 +359,8 @@ struct wpa_key_t {
u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE];  /* LSB first */
struct sockaddr addr;   /* ff:ff:ff:ff:ff:ff for broadcast/multicast
 * (group) keys or unicast address for
-* individual keys */
+* individual keys
+*/
u16 alg;
u16 key_len;/* WEP: 5 or 13, TKIP: 32, CCMP: 16 */
u8 key_val[IW_ENCODING_TOKEN_MAX];
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel