Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *
On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: > Change the type and uses of rx_rate. > > Signed-off-by: Martin Alonso > --- > drivers/staging/vt6656/dpc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c > index 655f000..782b7d7 100644 > --- a/drivers/staging/vt6656/dpc.c > +++ b/drivers/staging/vt6656/dpc.c > @@ -46,7 +46,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb > *ptr_rcb, > __le64 *tsf_time; > u32 frame_size; > int ii, r; > - u8 *rx_rate, *sq, *sq_3; > + u8 rx_rate; > + u8 *sq, *sq_3; > u32 wbk_status; > u8 *skb_data; > u16 *pay_load_len; > @@ -75,7 +76,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb > *ptr_rcb, > > skb_data = (u8 *)skb->data; > > - rx_rate = skb_data + 5; > + rx_rate = *(skb_data + 5); It occurs to me that we don't check that skb->len is large enough here. We just assume it has at least 5 bytes. TODO: vt6656: verify skb->len before using it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace
On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The rtl871 driver declared an enum for representing LED states. The enum > contains constant LED_OFF which conflicted with declaration found in > linux/leds.h. LED_OFF changed to LED_STATE_OFF > In order to avoid a possible future collision LED_ON was changed to > LED_STATE_ON as well. > > Signed-off-by: Zach Brown > --- > drivers/staging/rtl8712/rtl8712_led.c | 388 > +- > 1 file changed, 194 insertions(+), 194 deletions(-) Ick, messy. I'll be glad to take this patch now to make your life easier in the future. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: fix permissions style
On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. > > Signed-off-by: Ramiro Oliveira > --- > drivers/staging/android/lowmemorykiller.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Doesn't apply to my tree at all, are you sure you are working against linux-next? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *
On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: > Change the type and uses of rx_rate. That's totally vague and doesn't say why this patch is needed at all. For all I can tell, it looks like you are changing the type for no good reason... Please fix this up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: fbtft: Fix checkpatch warning
--- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e9f25dd..0883715 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -841,7 +841,6 @@ static struct fbtft_device_display displays[] = { } } }, { - .name = "piscreen", .spi = &(struct spi_board_info) { .modalias = "fb_ili9486", @@ -1418,14 +1417,14 @@ static int __init fbtft_device_init(void) /* parse module parameter: gpios */ while ((p_gpio = strsep(&gpios, ","))) { - if (strchr(p_gpio, ':') == NULL) { + if (!strchr(p_gpio, ':')) { pr_err("error: missing ':' in gpios parameter: %s\n", p_gpio); return -EINVAL; } p_num = p_gpio; p_name = strsep(&p_num, ":"); - if (p_name == NULL || p_num == NULL) { + if (!p_name || !p_num) { pr_err("something bad happened parsing gpios parameter: %s\n", p_gpio); return -EINVAL; @@ -1586,7 +1585,6 @@ static void __exit fbtft_device_exit(void) if (p_device) platform_device_unregister(p_device); - } arch_initcall(fbtft_device_init); -- 2.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: fbtft: Fix checkpatch warning
Improve code readability. Signed-off-by: Carlos Palminha --- Changes v1->v2: - Added signed-off-by and comment. drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e9f25dd..0883715 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -841,7 +841,6 @@ static struct fbtft_device_display displays[] = { } } }, { - .name = "piscreen", .spi = &(struct spi_board_info) { .modalias = "fb_ili9486", @@ -1418,14 +1417,14 @@ static int __init fbtft_device_init(void) /* parse module parameter: gpios */ while ((p_gpio = strsep(&gpios, ","))) { - if (strchr(p_gpio, ':') == NULL) { + if (!strchr(p_gpio, ':')) { pr_err("error: missing ':' in gpios parameter: %s\n", p_gpio); return -EINVAL; } p_num = p_gpio; p_name = strsep(&p_num, ":"); - if (p_name == NULL || p_num == NULL) { + if (!p_name || !p_num) { pr_err("something bad happened parsing gpios parameter: %s\n", p_gpio); return -EINVAL; @@ -1586,7 +1585,6 @@ static void __exit fbtft_device_exit(void) if (p_device) platform_device_unregister(p_device); - } arch_initcall(fbtft_device_init); -- 2.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fbtft: Fix checkpatch warning
On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote: > Improve code readability. You are doing multiple things in the same patch, and you don't really tell us what you are doing, or why you are doing it... Please take a step back, relax, and wait a day before resending a patch series for these issues. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style
Remove the explicit NULL comparison and rewrite in a compact form and fixed switch case indentation issue. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..0b7bb30 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; @@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent, int ret = 0; switch (heap->type) { - case ION_HEAP_TYPE_CARVEOUT: - case ION_HEAP_TYPE_CHUNK: - if (heap->base && heap->size) - return 0; - - ret = of_reserved_mem_device_init(heap->priv); - break; - default: - break; + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: + if (heap->base && heap->size) + return 0; + + ret = of_reserved_mem_device_init(heap->priv); + break; + default: + break; } return ret; -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style
On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form and > fixed switch case indentation issue. If you need "and" in a subject: line for a patch, that's a huge hint that this needs to be at least 2 patches. Please only ever do "one type of thing" in a single patch. And no, that one thing can not be "fix all coding style issues" :) Please break this up into multiple patches and resend it. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: android: fix permissions style
Change permissions from symbolic to octal. V2: Fix all the permissions, previous patch was missing some. Signed-off-by: Ramiro Oliveira --- drivers/staging/android/lowmemorykiller.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 80d7adf..553a3ee 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -204,10 +204,10 @@ device_initcall(lowmem_init); * not really modular, but the easiest way to keep compat with existing * bootargs behaviour is to continue using module_param here. */ -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, -S_IRUGO | S_IWUSR); +0644); module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, -S_IRUGO | S_IWUSR); -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); +0644); +module_param_named(debug_level, lowmem_debug_level, uint, 0644); -- 2.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: android: fix permissions style
On Wed, Sep 28, 2016 at 02:23:00PM +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. > > V2: Fix all the permissions, previous patch was missing some. > Signed-off-by: Ramiro Oliveira > --- > drivers/staging/android/lowmemorykiller.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/lowmemorykiller.c > b/drivers/staging/android/lowmemorykiller.c > index 80d7adf..553a3ee 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > - S_IRUGO | S_IWUSR); > + 0644); > module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, > - S_IRUGO | S_IWUSR); > -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); > + 0644); > +module_param_named(debug_level, lowmem_debug_level, uint, 0644); > Still doesn't apply, make sure you always work against linux-next... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: fix permissions style
On 9/28/2016 10:28 AM, Greg KH wrote: > On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote: >> Change permissions from symbolic to octal. >> >> Signed-off-by: Ramiro Oliveira >> --- >> drivers/staging/android/lowmemorykiller.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > Doesn't apply to my tree at all, are you sure you are working against > linux-next? > > thanks, > > greg k-h Hi Greg, I've checked and I'm working with linux-next from September 28. I've even cloned a fresh repository and applied my patch against it, and it didn't return any error. I'm following this man page: https://www.kernel.org/doc/man-pages/linux-next.html And these are the latest commits I can see in my local repository. ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10 486aa34 Staging: android: fix permissions style d1dfecd Add linux-next specific files for 20160928 193fc13 Merge branch 'akpm/master' 0a02a3c treewide: remove redundant #include 8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix 25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0 ceed084 kthread: add kerneldoc for kthread_create() 998139d scripts/tags.sh: enable code completion in VIM b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping 73ac410 kdump, vmcoreinfo: report memory sections virtual addresses Can you give some pointers on what I might be doing wrong? BRs, Ramiro ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH -next] staging: media: stih-cec: remove unused including
From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/staging/media/st-cec/stih-cec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c index 2143448..b0aee1d 100644 --- a/drivers/staging/media/st-cec/stih-cec.c +++ b/drivers/staging/media/st-cec/stih-cec.c @@ -16,7 +16,6 @@ #include #include #include -#include #include ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/1] Staging: android: ion: Fixed coding style issues
Fixed checkpatch coding style issues Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..01f3067 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent, int ret = 0; switch (heap->type) { - case ION_HEAP_TYPE_CARVEOUT: - case ION_HEAP_TYPE_CHUNK: - if (heap->base && heap->size) - return 0; - - ret = of_reserved_mem_device_init(heap->priv); - break; - default: - break; + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: + if (heap->base && heap->size) + return 0; + + ret = of_reserved_mem_device_init(heap->priv); + break; + default: + break; } return ret; @@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) static void rmem_ion_device_release(struct reserved_mem *rmem, struct device *dev) { - return; + } static const struct reserved_mem_ops rmem_dma_ops = { -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 01f3067..485fb0f 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: fix permissions style
On Wed, Sep 28, 2016 at 02:48:39PM +0100, Ramiro Oliveira wrote: > On 9/28/2016 10:28 AM, Greg KH wrote: > > On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote: > >> Change permissions from symbolic to octal. > >> > >> Signed-off-by: Ramiro Oliveira > >> --- > >> drivers/staging/android/lowmemorykiller.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Doesn't apply to my tree at all, are you sure you are working against > > linux-next? > > > > thanks, > > > > greg k-h > > Hi Greg, > > I've checked and I'm working with linux-next from September 28. > > I've even cloned a fresh repository and applied my patch against it, and it > didn't return any error. > > I'm following this man page: > https://www.kernel.org/doc/man-pages/linux-next.html > > And these are the latest commits I can see in my local repository. > > ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10 > 486aa34 Staging: android: fix permissions style > d1dfecd Add linux-next specific files for 20160928 > 193fc13 Merge branch 'akpm/master' > 0a02a3c treewide: remove redundant #include > 8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix > 25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0 > ceed084 kthread: add kerneldoc for kthread_create() > 998139d scripts/tags.sh: enable code completion in VIM > b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a > lowmem mapping > 73ac410 kdump, vmcoreinfo: report memory sections virtual addresses > > Can you give some pointers on what I might be doing wrong? Hm, I think this is my fault, sorry. The patch that this conflicts with was applied by me yesterday, and didn't make it into linux-next for the release that you are using. Sorry about that. You can wait for the next linux-next release tomorrow, or you can work off my staging-next branch of the staging.git tree on git.kernel.org (that branch ends up in linux-next.) So you were doing the right thing, we just got out of sync. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues
On Wed, Sep 28, 2016 at 08:51:43PM +0530, shyam saini wrote: > Fixed checkpatch coding style issues What specific issues? Always be descriptive, look at previous patches in the staging tree for examples. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: fix permissions style
On 9/28/2016 4:37 PM, Greg KH wrote: > On Wed, Sep 28, 2016 at 02:48:39PM +0100, Ramiro Oliveira wrote: >> On 9/28/2016 10:28 AM, Greg KH wrote: >>> On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote: >>>> Change permissions from symbolic to octal. >>>> >>>> Signed-off-by: Ramiro Oliveira >>>> --- >>>> drivers/staging/android/lowmemorykiller.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> Doesn't apply to my tree at all, are you sure you are working against >>> linux-next? >>> >>> thanks, >>> >>> greg k-h >> Hi Greg, >> >> I've checked and I'm working with linux-next from September 28. >> >> I've even cloned a fresh repository and applied my patch against it, and it >> didn't return any error. >> >> I'm following this man page: >> https://www.kernel.org/doc/man-pages/linux-next.html >> >> And these are the latest commits I can see in my local repository. >> >> ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10 >> 486aa34 Staging: android: fix permissions style >> d1dfecd Add linux-next specific files for 20160928 >> 193fc13 Merge branch 'akpm/master' >> 0a02a3c treewide: remove redundant #include >> 8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix >> 25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0 >> ceed084 kthread: add kerneldoc for kthread_create() >> 998139d scripts/tags.sh: enable code completion in VIM >> b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a >> lowmem mapping >> 73ac410 kdump, vmcoreinfo: report memory sections virtual addresses >> >> Can you give some pointers on what I might be doing wrong? > Hm, I think this is my fault, sorry. The patch that this conflicts with > was applied by me yesterday, and didn't make it into linux-next for the > release that you are using. > > Sorry about that. You can wait for the next linux-next release > tomorrow, or you can work off my staging-next branch of the staging.git > tree on git.kernel.org (that branch ends up in linux-next.) > > So you were doing the right thing, we just got out of sync. > > greg k-h Thanks for the feedback. I'll work against your staging-next branch and submit the corrected patch. BRs, Ramiro ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 01/87] staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_bytestr32_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 10 +- drivers/staging/wlan-ng/prism2sta.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 4cf4796..5df4e1f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -356,10 +356,10 @@ struct hfa384x_bytestr { u8 data[0]; } __packed; -typedef struct hfa384x_bytestr32 { +struct hfa384x_bytestr32 { u16 len; u8 data[32]; -} __packed hfa384x_bytestr32_t; +} __packed; /* Configuration Record Structures: @@ -398,7 +398,7 @@ struct hfa384x_bytestr { typedef struct hfa384x_HostScanRequest_data { u16 channelList; u16 txRate; - hfa384x_bytestr32_t ssid; + struct hfa384x_bytestr32 ssid; } __packed hfa384x_HostScanRequest_data_t; /*-- Configuration Record: JoinRequest (data portion only) --*/ @@ -643,7 +643,7 @@ struct hfa384x_bytestr { u8 bssid[WLAN_BSSID_LEN]; u16 bcnint; u16 capinfo; - hfa384x_bytestr32_t ssid; + struct hfa384x_bytestr32 ssid; u8 supprates[10]; /* 802.11 info element */ u16 proberesp_rate; } __packed hfa384x_ScanResultSub_t; @@ -678,7 +678,7 @@ struct hfa384x_bytestr { u8 bssid[WLAN_BSSID_LEN]; u16 bcnint; u16 capinfo; - hfa384x_bytestr32_t ssid; + struct hfa384x_bytestr32 ssid; u8 supprates[10]; /* 802.11 info element */ u16 proberesp_rate; u16 atim; diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index a39b294..ec51db2 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1171,7 +1171,7 @@ void prism2sta_processing_defer(struct work_struct *data) { hfa384x_t *hw = container_of(data, struct hfa384x, link_bh); struct wlandevice *wlandev = hw->wlandev; - hfa384x_bytestr32_t ssid; + struct hfa384x_bytestr32 ssid; int result; /* First let's process the auth frames */ @@ -1914,7 +1914,7 @@ void prism2sta_commsqual_defer(struct work_struct *data) { hfa384x_t *hw = container_of(data, struct hfa384x, commsqual_bh); struct wlandevice *wlandev = hw->wlandev; - hfa384x_bytestr32_t ssid; + struct hfa384x_bytestr32 ssid; struct p80211msg_dot11req_mibget msg; struct p80211item_uint32 *mibitem = (struct p80211item_uint32 *) &msg.mibattribute.data; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 02/87] staging: wlang-ng: avoid new typedef: hfa384x_compident_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_compident_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 12 ++-- drivers/staging/wlan-ng/prism2fw.c | 6 +++--- drivers/staging/wlan-ng/prism2sta.c | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 5df4e1f..d462c78 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -367,12 +367,12 @@ struct hfa384x_bytestr32 { */ /*-- Hardware/Firmware Component Information --*/ -typedef struct hfa384x_compident { +struct hfa384x_compident { u16 id; u16 variant; u16 major; u16 minor; -} __packed hfa384x_compident_t; +} __packed; typedef struct hfa384x_caplevel { u16 role; @@ -1304,10 +1304,10 @@ struct prism2sta_accesslist { unsigned int dot11_grpcnt; /* Component Identities */ - hfa384x_compident_t ident_nic; - hfa384x_compident_t ident_pri_fw; - hfa384x_compident_t ident_sta_fw; - hfa384x_compident_t ident_ap_fw; + struct hfa384x_compident ident_nic; + struct hfa384x_compident ident_pri_fw; + struct hfa384x_compident ident_sta_fw; + struct hfa384x_compident ident_ap_fw; u16 mm_mods; /* Supplier compatibility ranges */ diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index 7c5d3e7..35b0ff99 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -96,10 +96,10 @@ struct s3inforec { u16 len; u16 type; union { - hfa384x_compident_t version; + struct hfa384x_compident version; hfa384x_caplevel_t compat; u16 buildseq; - hfa384x_compident_t platform; + struct hfa384x_compident platform; } info; }; @@ -152,7 +152,7 @@ struct imgchunk { /* PDA, built from [card|newfile]+[addfile1+addfile2...] */ static struct pda pda; -static hfa384x_compident_t nicid; +static struct hfa384x_compident nicid; static hfa384x_caplevel_t rfid; static hfa384x_caplevel_t macid; static hfa384x_caplevel_t priid; diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index ec51db2..6169481 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -592,7 +592,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev) /* NIC identity */ result = hfa384x_drvr_getconfig(hw, HFA384x_RID_NICIDENTITY, &hw->ident_nic, - sizeof(hfa384x_compident_t)); + sizeof(struct hfa384x_compident)); if (result) { netdev_err(wlandev->netdev, "Failed to retrieve NICIDENTITY\n"); goto failed; @@ -611,7 +611,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev) /* Primary f/w identity */ result = hfa384x_drvr_getconfig(hw, HFA384x_RID_PRIIDENTITY, &hw->ident_pri_fw, - sizeof(hfa384x_compident_t)); + sizeof(struct hfa384x_compident)); if (result) { netdev_err(wlandev->netdev, "Failed to retrieve PRIIDENTITY\n"); goto failed; @@ -630,7 +630,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev) /* Station (Secondary?) f/w identity */ result = hfa384x_drvr_getconfig(hw, HFA384x_RID_STAIDENTITY, &hw->ident_sta_fw, - sizeof(hfa384x_compident_t)); + sizeof(struct hfa384x_compident)); if (result) { netdev_err(wlandev->netdev, "Failed to retrieve STAIDENTITY\n"); goto failed; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 04/87] staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_caplevel_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 24 drivers/staging/wlan-ng/prism2fw.c | 8 drivers/staging/wlan-ng/prism2sta.c | 14 +++--- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 5ca2a94..e02f894 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -386,13 +386,13 @@ struct hfa384x_compident { u16 minor; } __packed; -typedef struct hfa384x_caplevel { +struct hfa384x_caplevel { u16 role; u16 id; u16 variant; u16 bottom; u16 top; -} __packed hfa384x_caplevel_t; +} __packed; /*-- Configuration Record: cnfAuthentication --*/ #define HFA384x_CNFAUTHENTICATION_OPENSYSTEM 0x0001 @@ -1337,31 +1337,31 @@ struct prism2sta_accesslist { u16 mm_mods; /* Supplier compatibility ranges */ - hfa384x_caplevel_t cap_sup_mfi; - hfa384x_caplevel_t cap_sup_cfi; - hfa384x_caplevel_t cap_sup_pri; - hfa384x_caplevel_t cap_sup_sta; - hfa384x_caplevel_t cap_sup_ap; + struct hfa384x_caplevel cap_sup_mfi; + struct hfa384x_caplevel cap_sup_cfi; + struct hfa384x_caplevel cap_sup_pri; + struct hfa384x_caplevel cap_sup_sta; + struct hfa384x_caplevel cap_sup_ap; /* Actor compatibility ranges */ - hfa384x_caplevel_t cap_act_pri_cfi; /* + struct hfa384x_caplevel cap_act_pri_cfi;/* * pri f/w to controller * interface */ - hfa384x_caplevel_t cap_act_sta_cfi; /* + struct hfa384x_caplevel cap_act_sta_cfi;/* * sta f/w to controller * interface */ - hfa384x_caplevel_t cap_act_sta_mfi; /* sta f/w to modem interface */ + struct hfa384x_caplevel cap_act_sta_mfi;/* sta f/w to modem interface */ - hfa384x_caplevel_t cap_act_ap_cfi; /* + struct hfa384x_caplevel cap_act_ap_cfi; /* * ap f/w to controller * interface */ - hfa384x_caplevel_t cap_act_ap_mfi; /* ap f/w to modem interface */ + struct hfa384x_caplevel cap_act_ap_mfi; /* ap f/w to modem interface */ u32 psusercount;/* Power save user count. */ hfa384x_CommTallies32_t tallies;/* Communication tallies. */ diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index 35b0ff99..ca322fa 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -97,7 +97,7 @@ struct s3inforec { u16 type; union { struct hfa384x_compident version; - hfa384x_caplevel_t compat; + struct hfa384x_caplevel compat; u16 buildseq; struct hfa384x_compident platform; } info; @@ -153,9 +153,9 @@ struct imgchunk { static struct pda pda; static struct hfa384x_compident nicid; -static hfa384x_caplevel_t rfid; -static hfa384x_caplevel_t macid; -static hfa384x_caplevel_t priid; +static struct hfa384x_caplevel rfid; +static struct hfa384x_caplevel macid; +static struct hfa384x_caplevel priid; /**/ /* Local Function Declarations */ diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 6169481..5b51550 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -670,7 +670,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev) /* Compatibility range, Modem supplier */ result = hfa384x_drvr_getconfig(hw, HFA384x_RID_MFISUPRANGE, &hw->cap_sup_mfi, - sizeof(hfa384x_caplevel_t)); + sizeof(struct hfa384x_caplevel)); if (result) { netdev_err(wlandev->netdev, "Failed to retrieve MFISUPRANGE\n"); goto failed; @@ -694,7 +694,7 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev) /* Compatibility range, Controller supplier */ result = hfa384x_drvr_getconfig(hw, HFA384x_RID_CFISUPRANGE, &hw->cap_sup_cfi, - sizeof(hfa384x_caplevel_t)); +
[PATCH 05/87] staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_HostScanRequest_data_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 4 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index e02f894..2ac10a0 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -408,11 +408,11 @@ struct hfa384x_caplevel { #define HFA384x_CREATEIBSS_JOINCREATEIBSS 0 /*-- Configuration Record: HostScanRequest (data portion only) --*/ -typedef struct hfa384x_HostScanRequest_data { +struct hfa384x_HostScanRequest_data { u16 channelList; u16 txRate; struct hfa384x_bytestr32 ssid; -} __packed hfa384x_HostScanRequest_data_t; +} __packed; /*-- Configuration Record: JoinRequest (data portion only) --*/ typedef struct hfa384x_JoinRequest_data { diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 5e5d0ab..1a98d69 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -122,7 +122,7 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) int i, timeout; int istmpenable = 0; - hfa384x_HostScanRequest_data_t scanreq; + struct hfa384x_HostScanRequest_data scanreq; /* gatekeeper check */ if (HFA384x_FIRMWARE_VERSION(hw->ident_sta_fw.major, @@ -292,7 +292,7 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) result = hfa384x_drvr_setconfig(hw, HFA384x_RID_HOSTSCAN, &scanreq, - sizeof(hfa384x_HostScanRequest_data_t)); + sizeof(struct hfa384x_HostScanRequest_data)); if (result) { netdev_err(wlandev->netdev, "setconfig(SCANREQUEST) failed. result=%d\n", -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 00/87] Fix some style warnings in hfa384x.h
This patch series fix some warnings reported by checkpatch.pl script in hfa384x.h: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line WARNING: do not add new typedefs Sergio Paracuellos (87): staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t staging: wlang-ng: avoid new typedef: hfa384x_compident_t staging: wlang-ng: Fix block comments style warnings in hfa384x.h staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t staging: wlang-ng: avoid new typedef: hfa384x_infodata_t staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t staging: wlang-ng: avoid new typedef: hfa384x_usbout_t staging: wlang-ng: avoid new typedef: hfa384x_usbin_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t staging: wlang-ng: avoid
[PATCH 03/87] staging: wlang-ng: Fix block comments style warnings in hfa384x.h
This patch fixes the following checkpatch.pl warnings in hfa384x.h: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 166 ++ 1 file changed, 96 insertions(+), 70 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index d462c78..5ca2a94 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -174,11 +174,12 @@ #defineHFA384x_CMD_ERR ((u16)(0x7F)) /*--- Programming Modes -- - MODE 0: Disable programming - MODE 1: Enable volatile memory programming - MODE 2: Enable non-volatile memory programming - MODE 3: Program non-volatile memory section ---*/ + * MODE 0: Disable programming + * MODE 1: Enable volatile memory programming + * MODE 2: Enable non-volatile memory programming + * MODE 3: Program non-volatile memory section + *- + */ #defineHFA384x_PROGMODE_DISABLE((u16)0x00) #defineHFA384x_PROGMODE_RAM((u16)0x01) #defineHFA384x_PROGMODE_NV ((u16)0x02) @@ -186,8 +187,9 @@ /*--- Record ID Constants --*/ /* -Configuration RIDs: Network Parameters, Static Configuration Entities -*/ + * Configuration RIDs: Network Parameters, Static Configuration Entities + * + */ #defineHFA384x_RID_CNFPORTTYPE ((u16)0xFC00) #defineHFA384x_RID_CNFOWNMACADDR ((u16)0xFC01) #defineHFA384x_RID_CNFDESIREDSSID ((u16)0xFC02) @@ -196,17 +198,19 @@ #defineHFA384x_RID_CNFMAXDATALEN ((u16)0xFC07) /* -Configuration RID lengths: Network Params, Static Config Entities - This is the length of JUST the DATA part of the RID (does not - include the len or code fields) -*/ + * Configuration RID lengths: Network Params, Static Config Entities + * This is the length of JUST the DATA part of the RID (does not + * include the len or code fields) + * + */ #defineHFA384x_RID_CNFOWNMACADDR_LEN ((u16)6) #defineHFA384x_RID_CNFDESIREDSSID_LEN ((u16)34) #defineHFA384x_RID_CNFOWNSSID_LEN ((u16)34) /* -Configuration RIDs: Network Parameters, Dynamic Configuration Entities -*/ + * Configuration RIDs: Network Parameters, Dynamic Configuration Entities + * + */ #defineHFA384x_RID_CREATEIBSS ((u16)0xFC81) #defineHFA384x_RID_FRAGTHRESH ((u16)0xFC82) #defineHFA384x_RID_RTSTHRESH ((u16)0xFC83) @@ -214,8 +218,9 @@ #defineHFA384x_RID_PROMISCMODE ((u16)0xFC85) /*-- -Information RIDs: NIC Information -*/ + * Information RIDs: NIC Information + *-- + */ #defineHFA384x_RID_MAXLOADTIME ((u16)0xFD00) #defineHFA384x_RID_DOWNLOADBUFFER ((u16)0xFD01) #defineHFA384x_RID_PRIIDENTITY ((u16)0xFD02) @@ -231,15 +236,17 @@ #defineHFA384x_RID_STA_CFIACTRANGES((u16)0xFD23) /*-- -Information RID Lengths: NIC Information - This is the length of JUST the DATA part of the RID (does not - include the len or code fields) -*/ + * Information RID Lengths: NIC Information + * This is the length of JUST the DATA part of the RID (does not + * include the len or code fields) + *- + */ #defineHFA384x_RID_NICSERIALNUMBER_LEN ((u16)12) /* -Information RIDs: MAC Information -*/ + * Information RI
[PATCH 06/87] staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_JoinRequest_data_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 8 drivers/staging/wlan-ng/prism2sta.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 2ac10a0..46487da 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -266,7 +266,7 @@ #defineHFA384x_RID_DBMCOMMSQUALITY_LEN \ ((u16)sizeof(hfa384x_dbmcommsquality_t)) #defineHFA384x_RID_JOINREQUEST_LEN \ - ((u16)sizeof(hfa384x_JoinRequest_data_t)) + ((u16)sizeof(struct hfa384x_JoinRequest_data)) /* * Information RIDs: Modem Information @@ -415,10 +415,10 @@ struct hfa384x_HostScanRequest_data { } __packed; /*-- Configuration Record: JoinRequest (data portion only) --*/ -typedef struct hfa384x_JoinRequest_data { +struct hfa384x_JoinRequest_data { u8 bssid[WLAN_BSSID_LEN]; u16 channel; -} __packed hfa384x_JoinRequest_data_t; +} __packed; /*-- Configuration Record: authenticateStation (data portion only) --*/ typedef struct hfa384x_authenticateStation_data { @@ -1298,7 +1298,7 @@ struct prism2sta_accesslist { int scanflag; /* to signal scan complete */ int join_ap;/* are we joined to a specific ap */ int join_retries; /* number of join retries till we fail */ - hfa384x_JoinRequest_data_t joinreq; /* join request saved data */ + struct hfa384x_JoinRequest_data joinreq;/* join request saved data */ struct wlandevice *wlandev; /* Timer to allow for the deferred processing of linkstatus messages */ diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 5b51550..a4619e7 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1035,7 +1035,7 @@ static void prism2sta_inf_scanresults(struct wlandevice *wlandev, int nbss; hfa384x_ScanResult_t *sr = &(inf->info.scanresult); int i; - hfa384x_JoinRequest_data_t joinreq; + struct hfa384x_JoinRequest_data joinreq; int result; /* Get the number of results, first in bytes, then in results */ @@ -1389,7 +1389,7 @@ void prism2sta_processing_defer(struct work_struct *data) * Disable Transmits, Ignore receives of data frames */ if (hw->join_ap && --hw->join_retries > 0) { - hfa384x_JoinRequest_data_t joinreq; + struct hfa384x_JoinRequest_data joinreq; joinreq = hw->joinreq; /* Send the join request */ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 07/87] staging: wlang-ng: avoid new typedef: hfa384x_authenticateStation_data_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_authenticateStation_data_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/prism2sta.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 46487da..385a332 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -421,11 +421,11 @@ struct hfa384x_JoinRequest_data { } __packed; /*-- Configuration Record: authenticateStation (data portion only) --*/ -typedef struct hfa384x_authenticateStation_data { +struct hfa384x_authenticateStation_data { u8 address[ETH_ALEN]; u16 status; u16 algorithm; -} __packed hfa384x_authenticateStation_data_t; +} __packed; /*-- Configuration Record: WPAData (data portion only) --*/ typedef struct hfa384x_WPAData { diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index a4619e7..d918844 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1545,7 +1545,7 @@ static void prism2sta_inf_authreq_defer(struct wlandevice *wlandev, hfa384x_InfFrame_t *inf) { hfa384x_t *hw = wlandev->priv; - hfa384x_authenticateStation_data_t rec; + struct hfa384x_authenticateStation_data rec; int i, added, result, cnt; u8 *addr; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 23/87] staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_AssocStatus_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/prism2sta.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 8f8c64d..c8f5493 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -733,14 +733,14 @@ struct hfa384x_LinkStatus { #define HFA384x_ASSOCSTATUS_REASSOC((u16)2) #define HFA384x_ASSOCSTATUS_AUTHFAIL ((u16)5) -typedef struct hfa384x_AssocStatus { +struct hfa384x_AssocStatus { u16 assocstatus; u8 sta_addr[ETH_ALEN]; /* old_ap_addr is only valid if assocstatus == 2 */ u8 old_ap_addr[ETH_ALEN]; u16 reason; u16 reserved; -} __packed hfa384x_AssocStatus_t; +} __packed; /*-- Unsolicited Frame, MAC Mgmt: AuthRequest (AP Only) --*/ @@ -768,7 +768,7 @@ struct hfa384x_LinkStatus { struct hfa384x_ChInfoResult chinforesult; struct hfa384x_HScanResult hscanresult; struct hfa384x_LinkStatus linkstatus; - hfa384x_AssocStatus_t assocstatus; + struct hfa384x_AssocStatus assocstatus; hfa384x_AuthReq_t authreq; hfa384x_PSUserCount_t psusercnt; hfa384x_KeyIDChanged_t keyidchanged; diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 5773159..fb47b82 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1469,7 +1469,7 @@ static void prism2sta_inf_assocstatus(struct wlandevice *wlandev, hfa384x_InfFrame_t *inf) { hfa384x_t *hw = wlandev->priv; - hfa384x_AssocStatus_t rec; + struct hfa384x_AssocStatus rec; int i; memcpy(&rec, &inf->info.assocstatus, sizeof(rec)); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 09/87] staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_downloadbuffer_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index f7dadfb..761d2c2 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -440,11 +440,11 @@ struct hfa384x_WPAData { /*-- Information Record: DownLoadBuffer --*/ /* NOTE: The page and offset are in AUX format */ -typedef struct hfa384x_downloadbuffer { +struct hfa384x_downloadbuffer { u16 page; u16 offset; u16 len; -} __packed hfa384x_downloadbuffer_t; +} __packed; /* * Information Record Structures: NIC Information @@ -1292,7 +1292,7 @@ struct prism2sta_accesslist { /* Download support */ unsigned int dlstate; - hfa384x_downloadbuffer_t bufinfo; + struct hfa384x_downloadbuffer bufinfo; u16 dltimeout; int scanflag; /* to signal scan complete */ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 22/87] staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_LinkStatus_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 123987f..8f8c64d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -723,9 +723,9 @@ struct hfa384x_HScanResult { #define HFA384x_LINK_AP_INRANGE((u16)5) #define HFA384x_LINK_ASSOCFAIL ((u16)6) -typedef struct hfa384x_LinkStatus { +struct hfa384x_LinkStatus { u16 linkstatus; -} __packed hfa384x_LinkStatus_t; +} __packed; /*-- Unsolicited Frame, MAC Mgmt: AssociationStatus (--*/ @@ -767,7 +767,7 @@ struct hfa384x_HScanResult { struct hfa384x_ScanResult scanresult; struct hfa384x_ChInfoResult chinforesult; struct hfa384x_HScanResult hscanresult; - hfa384x_LinkStatus_t linkstatus; + struct hfa384x_LinkStatus linkstatus; hfa384x_AssocStatus_t assocstatus; hfa384x_AuthReq_t authreq; hfa384x_PSUserCount_t psusercnt; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 25/87] staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_PSUserCount_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 10d13d4..4d078e2 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -751,9 +751,9 @@ struct hfa384x_AuthRequest { /*-- Unsolicited Frame, MAC Mgmt: PSUserCount (AP Only) --*/ -typedef struct hfa384x_PSUserCount { +struct hfa384x_PSUserCount { u16 usercnt; -} __packed hfa384x_PSUserCount_t; +} __packed; typedef struct hfa384x_KeyIDChanged { u8 sta_addr[ETH_ALEN]; @@ -770,7 +770,7 @@ struct hfa384x_AuthRequest { struct hfa384x_LinkStatus linkstatus; struct hfa384x_AssocStatus assocstatus; struct hfa384x_AuthRequest authreq; - hfa384x_PSUserCount_t psusercnt; + struct hfa384x_PSUserCount psusercnt; hfa384x_KeyIDChanged_t keyidchanged; } __packed hfa384x_infodata_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 08/87] staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_WPAData_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 385a332..f7dadfb 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -428,10 +428,10 @@ struct hfa384x_authenticateStation_data { } __packed; /*-- Configuration Record: WPAData (data portion only) --*/ -typedef struct hfa384x_WPAData { +struct hfa384x_WPAData { u16 datalen; u8 data[0]; /* max 80 */ -} __packed hfa384x_WPAData_t; +} __packed; /* * Information Record Structures: NIC Information diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c index 3442de3..95bab45 100644 --- a/drivers/staging/wlan-ng/prism2mib.c +++ b/drivers/staging/wlan-ng/prism2mib.c @@ -709,7 +709,7 @@ static int prism2mib_priv(struct mibrec *mib, switch (mib->did) { case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{ - hfa384x_WPAData_t wpa; + struct hfa384x_WPAData wpa; if (isget) { hfa384x_drvr_getconfig(hw, -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 10/87] staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_commsquality_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 761d2c2..41d8a87 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -454,11 +454,11 @@ struct hfa384x_downloadbuffer { #define HFA384x_PSTATUS_CONN_IBSS ((u16)3) /*-- Information Record: commsquality --*/ -typedef struct hfa384x_commsquality { +struct hfa384x_commsquality { u16 CQ_currBSS; u16 ASL_currBSS; u16 ANL_currFC; -} __packed hfa384x_commsquality_t; +} __packed; /*-- Information Record: dmbcommsquality --*/ typedef struct hfa384x_dbmcommsquality { @@ -1305,7 +1305,7 @@ struct prism2sta_accesslist { struct work_struct link_bh; struct work_struct commsqual_bh; - hfa384x_commsquality_t qual; + struct hfa384x_commsquality qual; struct timer_list commsqual_timer; u16 link_status; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 13/87] staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_rx_frame_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index cb416ce..d663faf 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -539,7 +539,7 @@ struct hfa384x_tx_frame { * */ /*-- Communication Frame: Receive Frame Structure --*/ -typedef struct hfa384x_rx_frame { +struct hfa384x_rx_frame { /*-- MAC rx descriptor (hfa384x byte order) --*/ u16 status; u32 time; @@ -564,7 +564,7 @@ struct hfa384x_tx_frame { u8 dest_addr[6]; u8 src_addr[6]; u16 data_length;/* IEEE? (big endian) format */ -} __packed hfa384x_rx_frame_t; +} __packed; /* * Communication Frames: Field Masks for Receive Frames * @@ -856,7 +856,7 @@ struct hfa384x_tx_frame { /* Response (bulk IN) packet contents */ typedef struct hfa384x_usb_rxfrm { - hfa384x_rx_frame_t desc; + struct hfa384x_rx_frame desc; u8 data[WLAN_DATA_MAXLEN]; } __packed hfa384x_usb_rxfrm_t; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 044ca4d..f1809af 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -3346,7 +3346,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) hdrlen = p80211_headerlen(fc); /* Pull off the descriptor */ - skb_pull(skb, sizeof(hfa384x_rx_frame_t)); + skb_pull(skb, sizeof(struct hfa384x_rx_frame)); /* Now shunt the header block up against the data block * with an "overlapping" copy @@ -3419,7 +3419,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, hfa384x_usb_rxfrm_t *rxfrm) { - hfa384x_rx_frame_t *rxdesc = &(rxfrm->desc); + struct hfa384x_rx_frame *rxdesc = &(rxfrm->desc); unsigned int hdrlen = 0; unsigned int datalen = 0; unsigned int skblen = 0; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 14/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_CommTallies16_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index d663faf..1ff46fe 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -610,7 +610,7 @@ struct hfa384x_rx_frame { */ /*-- Inquiry Frame, Diagnose: Communication Tallies --*/ -typedef struct hfa384x_CommTallies16 { +struct hfa384x_CommTallies16 { u16 txunicastframes; u16 txmulticastframes; u16 txfragments; @@ -632,7 +632,7 @@ struct hfa384x_rx_frame { u16 rxdiscardswepundecr; u16 rxmsginmsgfrag; u16 rxmsginbadmsgfrag; -} __packed hfa384x_CommTallies16_t; +} __packed; typedef struct hfa384x_CommTallies32 { u32 txunicastframes; @@ -762,7 +762,7 @@ struct hfa384x_rx_frame { /*-- Collection of all Inf frames ---*/ typedef union hfa384x_infodata { - hfa384x_CommTallies16_t commtallies16; + struct hfa384x_CommTallies16 commtallies16; hfa384x_CommTallies32_t commtallies32; hfa384x_ScanResult_t scanresult; hfa384x_ChInfoResult_t chinforesult; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 24/87] staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_AuthReq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index c8f5493..10d13d4 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -744,10 +744,10 @@ struct hfa384x_AssocStatus { /*-- Unsolicited Frame, MAC Mgmt: AuthRequest (AP Only) --*/ -typedef struct hfa384x_AuthRequest { +struct hfa384x_AuthRequest { u8 sta_addr[ETH_ALEN]; u16 algorithm; -} __packed hfa384x_AuthReq_t; +} __packed; /*-- Unsolicited Frame, MAC Mgmt: PSUserCount (AP Only) --*/ @@ -769,7 +769,7 @@ struct hfa384x_AssocStatus { struct hfa384x_HScanResult hscanresult; struct hfa384x_LinkStatus linkstatus; struct hfa384x_AssocStatus assocstatus; - hfa384x_AuthReq_t authreq; + struct hfa384x_AuthRequest authreq; hfa384x_PSUserCount_t psusercnt; hfa384x_KeyIDChanged_t keyidchanged; } __packed hfa384x_infodata_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 17/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_ScanResult_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/prism2sta.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 97a796e..1da5a67 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -671,11 +671,11 @@ struct hfa384x_ScanResultSub { u16 proberesp_rate; } __packed; -typedef struct hfa384x_ScanResult { +struct hfa384x_ScanResult { u16 rsvd; u16 scanreason; struct hfa384x_ScanResultSub result[HFA384x_SCANRESULT_MAX]; -} __packed hfa384x_ScanResult_t; +} __packed; /*-- Inquiry Frame, Diagnose: ChInfo Results & Subfields--*/ typedef struct hfa384x_ChInfoResultSub { @@ -764,7 +764,7 @@ struct hfa384x_ScanResultSub { typedef union hfa384x_infodata { struct hfa384x_CommTallies16 commtallies16; struct hfa384x_CommTallies32 commtallies32; - hfa384x_ScanResult_t scanresult; + struct hfa384x_ScanResult scanresult; hfa384x_ChInfoResult_t chinforesult; hfa384x_HScanResult_t hscanresult; hfa384x_LinkStatus_t linkstatus; diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index d4f5957..5dfa3fc 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1033,7 +1033,7 @@ static void prism2sta_inf_scanresults(struct wlandevice *wlandev, { hfa384x_t *hw = wlandev->priv; int nbss; - hfa384x_ScanResult_t *sr = &(inf->info.scanresult); + struct hfa384x_ScanResult *sr = &(inf->info.scanresult); int i; struct hfa384x_JoinRequest_data joinreq; int result; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 28/87] staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_InfFrame_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 8 +++--- drivers/staging/wlan-ng/prism2mgmt.h | 2 +- drivers/staging/wlan-ng/prism2sta.c | 48 ++-- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 7accea2..29d9bc5 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -774,11 +774,11 @@ struct hfa384x_KeyIDChanged { struct hfa384x_KeyIDChanged keyidchanged; } __packed; -typedef struct hfa384x_InfFrame { +struct hfa384x_InfFrame { u16 framelen; u16 infotype; union hfa384x_infodata info; -} __packed hfa384x_InfFrame_t; +} __packed; /* * USB Packet structures and constants. @@ -862,7 +862,7 @@ struct hfa384x_KeyIDChanged { typedef struct hfa384x_usb_infofrm { u16 type; - hfa384x_InfFrame_t info; + struct hfa384x_InfFrame info; } __packed hfa384x_usb_infofrm_t; typedef struct hfa384x_usb_statusresp { @@ -1374,7 +1374,7 @@ struct prism2sta_accesslist { struct hfa384x_ChInfoResult results; } channel_info; - hfa384x_InfFrame_t *scanresults; + struct hfa384x_InfFrame *scanresults; struct prism2sta_authlist authlist; /* Authenticated station list. */ unsigned int accessmode;/* Access mode. */ diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h index 5a4bc75..a275e97 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.h +++ b/drivers/staging/wlan-ng/prism2mgmt.h @@ -65,7 +65,7 @@ u32 prism2sta_ifstate(struct wlandevice *wlandev, u32 ifstate); -void prism2sta_ev_info(struct wlandevice *wlandev, hfa384x_InfFrame_t *inf); +void prism2sta_ev_info(struct wlandevice *wlandev, struct hfa384x_InfFrame *inf); void prism2sta_ev_txexc(struct wlandevice *wlandev, u16 status); void prism2sta_ev_tx(struct wlandevice *wlandev, u16 status); void prism2sta_ev_alloc(struct wlandevice *wlandev); diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index fb47b82..d483fd1 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -110,25 +110,25 @@ static int prism2sta_txframe(struct wlandevice *wlandev, struct sk_buff *skb, static int prism2sta_setmulticast(struct wlandevice *wlandev, netdevice_t *dev); static void prism2sta_inf_handover(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_tallies(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_scanresults(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_chinforesults(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_linkstatus(struct wlandevice *wlandev, -hfa384x_InfFrame_t *inf); +struct hfa384x_InfFrame *inf); static void prism2sta_inf_assocstatus(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_authreq(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_authreq_defer(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); static void prism2sta_inf_psusercnt(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf); + struct hfa384x_InfFrame *inf); /* * prism2sta_open @@ -960,7 +960,7 @@ static int prism2sta_setmulticast(struct wlandevice *wlandev, netdevice_t *dev) * interrupt */ static void prism2sta_inf_handover(struct wlandevice *wlandev, - hfa384x_InfFrame_t *inf) + struct hfa384x_InfFrame *inf)
[PATCH 27/87] staging: wlang-ng: avoid new typedef: hfa384x_infodata_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_infodata_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 532b1a7..7accea2 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -761,7 +761,7 @@ struct hfa384x_KeyIDChanged { } __packed; /*-- Collection of all Inf frames ---*/ -typedef union hfa384x_infodata { +union hfa384x_infodata { struct hfa384x_CommTallies16 commtallies16; struct hfa384x_CommTallies32 commtallies32; struct hfa384x_ScanResult scanresult; @@ -772,12 +772,12 @@ struct hfa384x_KeyIDChanged { struct hfa384x_AuthRequest authreq; struct hfa384x_PSUserCount psusercnt; struct hfa384x_KeyIDChanged keyidchanged; -} __packed hfa384x_infodata_t; +} __packed; typedef struct hfa384x_InfFrame { u16 framelen; u16 infotype; - hfa384x_infodata_t info; + union hfa384x_infodata info; } __packed hfa384x_InfFrame_t; /* -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 16/87] staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_ScanResultSub_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/prism2sta.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 40cbe64..97a796e 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -659,7 +659,7 @@ struct hfa384x_CommTallies32 { } __packed; /*-- Inquiry Frame, Diagnose: Scan Results & Subfields--*/ -typedef struct hfa384x_ScanResultSub { +struct hfa384x_ScanResultSub { u16 chid; u16 anl; u16 sl; @@ -669,12 +669,12 @@ struct hfa384x_CommTallies32 { struct hfa384x_bytestr32 ssid; u8 supprates[10]; /* 802.11 info element */ u16 proberesp_rate; -} __packed hfa384x_ScanResultSub_t; +} __packed; typedef struct hfa384x_ScanResult { u16 rsvd; u16 scanreason; - hfa384x_ScanResultSub_t result[HFA384x_SCANRESULT_MAX]; + struct hfa384x_ScanResultSub result[HFA384x_SCANRESULT_MAX]; } __packed hfa384x_ScanResult_t; /*-- Inquiry Frame, Diagnose: ChInfo Results & Subfields--*/ diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index cd1cd58..d4f5957 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1041,7 +1041,7 @@ static void prism2sta_inf_scanresults(struct wlandevice *wlandev, /* Get the number of results, first in bytes, then in results */ nbss = (inf->framelen * sizeof(u16)) - sizeof(inf->infotype) - sizeof(inf->info.scanresult.scanreason); - nbss /= sizeof(hfa384x_ScanResultSub_t); + nbss /= sizeof(struct hfa384x_ScanResultSub); /* Print em */ pr_debug("rx scanresults, reason=%d, nbss=%d:\n", -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 29/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_txfrm_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 29d9bc5..2d6f6a9 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -808,10 +808,10 @@ struct hfa384x_InfFrame { /**/ /* Request (bulk OUT) packet contents */ -typedef struct hfa384x_usb_txfrm { +struct hfa384x_usb_txfrm { struct hfa384x_tx_frame desc; u8 data[WLAN_DATA_MAXLEN]; -} __packed hfa384x_usb_txfrm_t; +} __packed; typedef struct hfa384x_usb_cmdreq { u16 type; @@ -905,7 +905,7 @@ struct hfa384x_InfFrame { typedef union hfa384x_usbout { __le16 type; - hfa384x_usb_txfrm_t txfrm; + struct hfa384x_usb_txfrm txfrm; hfa384x_usb_cmdreq_t cmdreq; hfa384x_usb_wridreq_t wridreq; hfa384x_usb_rridreq_t rridreq; @@ -916,7 +916,7 @@ struct hfa384x_InfFrame { typedef union hfa384x_usbin { __le16 type; hfa384x_usb_rxfrm_t rxfrm; - hfa384x_usb_txfrm_t txfrm; + struct hfa384x_usb_txfrm txfrm; hfa384x_usb_infofrm_t infofrm; hfa384x_usb_cmdresp_t cmdresp; hfa384x_usb_wridresp_t wridresp; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 34/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_rmemreq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index da73cb1..28928c8 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -844,13 +844,13 @@ struct hfa384x_usb_wmemreq { u8 data[HFA384x_USB_RWMEM_MAXLEN]; } __packed; -typedef struct hfa384x_usb_rmemreq { +struct hfa384x_usb_rmemreq { u16 type; u16 frmlen; u16 offset; u16 page; u8 pad[56]; -} __packed hfa384x_usb_rmemreq_t; +} __packed; /**/ /* Response (bulk IN) packet contents */ @@ -910,7 +910,7 @@ struct hfa384x_usb_wmemreq { struct hfa384x_usb_wridreq wridreq; struct hfa384x_usb_rridreq rridreq; struct hfa384x_usb_wmemreq wmemreq; - hfa384x_usb_rmemreq_t rmemreq; + struct hfa384x_usb_rmemreq rmemreq; } __packed hfa384x_usbout_t; typedef union hfa384x_usbin { -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 30/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_cmdreq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 2d6f6a9..affdeef 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -813,14 +813,14 @@ struct hfa384x_usb_txfrm { u8 data[WLAN_DATA_MAXLEN]; } __packed; -typedef struct hfa384x_usb_cmdreq { +struct hfa384x_usb_cmdreq { u16 type; u16 cmd; u16 parm0; u16 parm1; u16 parm2; u8 pad[54]; -} __packed hfa384x_usb_cmdreq_t; +} __packed; typedef struct hfa384x_usb_wridreq { u16 type; @@ -906,7 +906,7 @@ struct hfa384x_usb_txfrm { typedef union hfa384x_usbout { __le16 type; struct hfa384x_usb_txfrm txfrm; - hfa384x_usb_cmdreq_t cmdreq; + struct hfa384x_usb_cmdreq cmdreq; hfa384x_usb_wridreq_t wridreq; hfa384x_usb_rridreq_t rridreq; hfa384x_usb_wmemreq_t wmemreq; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 11/87] staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_dbmcommsquality_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 41d8a87..1390236 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -264,7 +264,7 @@ * */ #defineHFA384x_RID_DBMCOMMSQUALITY_LEN \ - ((u16)sizeof(hfa384x_dbmcommsquality_t)) + ((u16)sizeof(struct hfa384x_dbmcommsquality)) #defineHFA384x_RID_JOINREQUEST_LEN \ ((u16)sizeof(struct hfa384x_JoinRequest_data)) @@ -461,11 +461,11 @@ struct hfa384x_commsquality { } __packed; /*-- Information Record: dmbcommsquality --*/ -typedef struct hfa384x_dbmcommsquality { +struct hfa384x_dbmcommsquality { u16 CQdbm_currBSS; u16 ASLdbm_currBSS; u16 ANLdbm_currFC; -} __packed hfa384x_dbmcommsquality_t; +} __packed; /* * FRAME STRUCTURES: Communication Frames -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 12/87] staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_tx_frame_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1390236..cb416ce 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -474,7 +474,7 @@ struct hfa384x_dbmcommsquality { * */ /*-- Communication Frame: Transmit Frame Structure --*/ -typedef struct hfa384x_tx_frame { +struct hfa384x_tx_frame { u16 status; u16 reserved1; u16 reserved2; @@ -499,7 +499,7 @@ struct hfa384x_dbmcommsquality { u8 dest_addr[6]; u8 src_addr[6]; u16 data_length;/* big endian format */ -} __packed hfa384x_tx_frame_t; +} __packed; /* * Communication Frames: Field Masks for Transmit Frames * @@ -809,7 +809,7 @@ struct hfa384x_dbmcommsquality { /* Request (bulk OUT) packet contents */ typedef struct hfa384x_usb_txfrm { - hfa384x_tx_frame_t desc; + struct hfa384x_tx_frame desc; u8 data[WLAN_DATA_MAXLEN]; } __packed hfa384x_usb_txfrm_t; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 9c29311..044ca4d 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -2566,7 +2566,7 @@ int hfa384x_drvr_txframe(hfa384x_t *hw, struct sk_buff *skb, union p80211_hdr *p80211_hdr, struct p80211_metawep *p80211_wep) { - int usbpktlen = sizeof(hfa384x_tx_frame_t); + int usbpktlen = sizeof(struct hfa384x_tx_frame); int result; int ret; char *ptr; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 15/87] staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_CommTallies32_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 8 drivers/staging/wlan-ng/prism2sta.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1ff46fe..40cbe64 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -634,7 +634,7 @@ struct hfa384x_CommTallies16 { u16 rxmsginbadmsgfrag; } __packed; -typedef struct hfa384x_CommTallies32 { +struct hfa384x_CommTallies32 { u32 txunicastframes; u32 txmulticastframes; u32 txfragments; @@ -656,7 +656,7 @@ struct hfa384x_CommTallies16 { u32 rxdiscardswepundecr; u32 rxmsginmsgfrag; u32 rxmsginbadmsgfrag; -} __packed hfa384x_CommTallies32_t; +} __packed; /*-- Inquiry Frame, Diagnose: Scan Results & Subfields--*/ typedef struct hfa384x_ScanResultSub { @@ -763,7 +763,7 @@ struct hfa384x_CommTallies16 { /*-- Collection of all Inf frames ---*/ typedef union hfa384x_infodata { struct hfa384x_CommTallies16 commtallies16; - hfa384x_CommTallies32_t commtallies32; + struct hfa384x_CommTallies32 commtallies32; hfa384x_ScanResult_t scanresult; hfa384x_ChInfoResult_t chinforesult; hfa384x_HScanResult_t hscanresult; @@ -1364,7 +1364,7 @@ struct prism2sta_accesslist { struct hfa384x_caplevel cap_act_ap_mfi; /* ap f/w to modem interface */ u32 psusercount;/* Power save user count. */ - hfa384x_CommTallies32_t tallies;/* Communication tallies. */ + struct hfa384x_CommTallies32 tallies; /* Communication tallies. */ u8 comment[WLAN_COMMENT_MAX + 1]; /* User comment */ /* Channel Info request results (AP only) */ diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index d918844..cd1cd58 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -997,7 +997,7 @@ static void prism2sta_inf_tallies(struct wlandevice *wlandev, * record length of the info record. */ - cnt = sizeof(hfa384x_CommTallies32_t) / sizeof(u32); + cnt = sizeof(struct hfa384x_CommTallies32) / sizeof(u32); if (inf->framelen > 22) { dst = (u32 *)&hw->tallies; src32 = (u32 *)&inf->info.commtallies32; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 37/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_cmdresp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 10 +- drivers/staging/wlan-ng/hfa384x_usb.c | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1113676..24e8ac4 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -865,15 +865,15 @@ struct hfa384x_usb_infofrm { struct hfa384x_InfFrame info; } __packed; -typedef struct hfa384x_usb_statusresp { +struct hfa384x_usb_statusresp { u16 type; u16 status; u16 resp0; u16 resp1; u16 resp2; -} __packed hfa384x_usb_cmdresp_t; +} __packed; -typedef hfa384x_usb_cmdresp_t hfa384x_usb_wridresp_t; +typedef struct hfa384x_usb_statusresp hfa384x_usb_wridresp_t; typedef struct hfa384x_usb_rridresp { u16 type; @@ -882,7 +882,7 @@ struct hfa384x_usb_infofrm { u8 data[HFA384x_RIDDATA_MAXLEN]; } __packed hfa384x_usb_rridresp_t; -typedef hfa384x_usb_cmdresp_t hfa384x_usb_wmemresp_t; +typedef struct hfa384x_usb_statusresp hfa384x_usb_wmemresp_t; typedef struct hfa384x_usb_rmemresp { u16 type; @@ -918,7 +918,7 @@ struct hfa384x_usb_infofrm { struct hfa384x_usb_rxfrm rxfrm; struct hfa384x_usb_txfrm txfrm; struct hfa384x_usb_infofrm infofrm; - hfa384x_usb_cmdresp_t cmdresp; + struct hfa384x_usb_statusresp cmdresp; hfa384x_usb_wridresp_t wridresp; hfa384x_usb_rridresp_t rridresp; hfa384x_usb_wmemresp_t wmemresp; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 76d1223..7d09f25 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -212,7 +212,7 @@ struct usbctlx_completor { static void hfa384x_cb_status(hfa384x_t *hw, const hfa384x_usbctlx_t *ctlx); static int -usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp, +usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp, hfa384x_cmdresult_t *result); static void @@ -621,7 +621,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) } static int -usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp, +usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp, hfa384x_cmdresult_t *result) { result->status = le16_to_cpu(cmdresp->status); @@ -652,7 +652,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) struct usbctlx_cmd_completor { struct usbctlx_completor head; - const hfa384x_usb_cmdresp_t *cmdresp; + const struct hfa384x_usb_statusresp *cmdresp; hfa384x_cmdresult_t *result; }; @@ -667,7 +667,7 @@ static inline int usbctlx_cmd_completor_fn(struct usbctlx_completor *head) static inline struct usbctlx_completor *init_cmd_completor( struct usbctlx_cmd_completor *completor, - const hfa384x_usb_cmdresp_t + const struct hfa384x_usb_statusresp *cmdresp, hfa384x_cmdresult_t *result) { -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 33/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_wmemreq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1300472..da73cb1 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -836,13 +836,13 @@ struct hfa384x_usb_rridreq { u8 pad[58]; } __packed; -typedef struct hfa384x_usb_wmemreq { +struct hfa384x_usb_wmemreq { u16 type; u16 frmlen; u16 offset; u16 page; u8 data[HFA384x_USB_RWMEM_MAXLEN]; -} __packed hfa384x_usb_wmemreq_t; +} __packed; typedef struct hfa384x_usb_rmemreq { u16 type; @@ -909,7 +909,7 @@ struct hfa384x_usb_rridreq { struct hfa384x_usb_cmdreq cmdreq; struct hfa384x_usb_wridreq wridreq; struct hfa384x_usb_rridreq rridreq; - hfa384x_usb_wmemreq_t wmemreq; + struct hfa384x_usb_wmemreq wmemreq; hfa384x_usb_rmemreq_t rmemreq; } __packed hfa384x_usbout_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 35/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_rxfrm_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 28928c8..b0de7cb 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -855,10 +855,10 @@ struct hfa384x_usb_rmemreq { /**/ /* Response (bulk IN) packet contents */ -typedef struct hfa384x_usb_rxfrm { +struct hfa384x_usb_rxfrm { struct hfa384x_rx_frame desc; u8 data[WLAN_DATA_MAXLEN]; -} __packed hfa384x_usb_rxfrm_t; +} __packed; typedef struct hfa384x_usb_infofrm { u16 type; @@ -915,7 +915,7 @@ struct hfa384x_usb_rmemreq { typedef union hfa384x_usbin { __le16 type; - hfa384x_usb_rxfrm_t rxfrm; + struct hfa384x_usb_rxfrm rxfrm; struct hfa384x_usb_txfrm txfrm; hfa384x_usb_infofrm_t infofrm; hfa384x_usb_cmdresp_t cmdresp; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index f1809af..76d1223 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -154,7 +154,7 @@ enum cmd_mode { #endif static void -hfa384x_int_rxmonitor(struct wlandevice *wlandev, hfa384x_usb_rxfrm_t *rxfrm); +hfa384x_int_rxmonitor(struct wlandevice *wlandev, struct hfa384x_usb_rxfrm *rxfrm); static void hfa384x_usb_defer(struct work_struct *data); @@ -3417,7 +3417,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) * interrupt */ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, - hfa384x_usb_rxfrm_t *rxfrm) + struct hfa384x_usb_rxfrm *rxfrm) { struct hfa384x_rx_frame *rxdesc = &(rxfrm->desc); unsigned int hdrlen = 0; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 19/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_ChInfoResult_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index beb97d9..8fee24b 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -688,10 +688,10 @@ struct hfa384x_ChInfoResultSub { #define HFA384x_CHINFORESULT_BSSACTIVE BIT(0) #define HFA384x_CHINFORESULT_PCFACTIVE BIT(1) -typedef struct hfa384x_ChInfoResult { +struct hfa384x_ChInfoResult { u16 scanchannels; struct hfa384x_ChInfoResultSub result[HFA384x_CHINFORESULT_MAX]; -} __packed hfa384x_ChInfoResult_t; +} __packed; /*-- Inquiry Frame, Diagnose: Host Scan Results & Subfields--*/ typedef struct hfa384x_HScanResultSub { @@ -765,7 +765,7 @@ struct hfa384x_ChInfoResultSub { struct hfa384x_CommTallies16 commtallies16; struct hfa384x_CommTallies32 commtallies32; struct hfa384x_ScanResult scanresult; - hfa384x_ChInfoResult_t chinforesult; + struct hfa384x_ChInfoResult chinforesult; hfa384x_HScanResult_t hscanresult; hfa384x_LinkStatus_t linkstatus; hfa384x_AssocStatus_t assocstatus; @@ -1371,7 +1371,7 @@ struct prism2sta_accesslist { struct { atomic_t done; u8 count; - hfa384x_ChInfoResult_t results; + struct hfa384x_ChInfoResult results; } channel_info; hfa384x_InfFrame_t *scanresults; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 39/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_rridresp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 8 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 18588d6..0ba5517 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -873,12 +873,12 @@ struct hfa384x_usb_statusresp { u16 resp2; } __packed; -typedef struct hfa384x_usb_rridresp { +struct hfa384x_usb_rridresp { u16 type; u16 frmlen; u16 rid; u8 data[HFA384x_RIDDATA_MAXLEN]; -} __packed hfa384x_usb_rridresp_t; +} __packed; typedef struct hfa384x_usb_statusresp hfa384x_usb_wmemresp_t; @@ -918,7 +918,7 @@ struct hfa384x_usb_statusresp { struct hfa384x_usb_infofrm infofrm; struct hfa384x_usb_statusresp cmdresp; struct hfa384x_usb_statusresp wridresp; - hfa384x_usb_rridresp_t rridresp; + struct hfa384x_usb_rridresp rridresp; hfa384x_usb_wmemresp_t wmemresp; hfa384x_usb_rmemresp_t rmemresp; hfa384x_usb_bufavail_t bufavail; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 7d09f25..c21c591 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -216,7 +216,7 @@ struct usbctlx_completor { hfa384x_cmdresult_t *result); static void -usbctlx_get_rridresult(const hfa384x_usb_rridresp_t *rridresp, +usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp, hfa384x_rridresult_t *result); /*---*/ @@ -636,7 +636,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) } static void -usbctlx_get_rridresult(const hfa384x_usb_rridresp_t *rridresp, +usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp, hfa384x_rridresult_t *result) { result->rid = le16_to_cpu(rridresp->rid); @@ -685,7 +685,7 @@ static inline struct usbctlx_completor *init_cmd_completor( struct usbctlx_rrid_completor { struct usbctlx_completor head; - const hfa384x_usb_rridresp_t *rridresp; + const struct hfa384x_usb_rridresp *rridresp; void *riddata; unsigned int riddatalen; }; @@ -713,7 +713,7 @@ static int usbctlx_rrid_completor_fn(struct usbctlx_completor *head) static inline struct usbctlx_completor *init_rrid_completor( struct usbctlx_rrid_completor *completor, - const hfa384x_usb_rridresp_t + const struct hfa384x_usb_rridresp *rridresp, void *riddata, unsigned int riddatalen) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 40/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_wmemresp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 0ba5517..28c008c 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -880,8 +880,6 @@ struct hfa384x_usb_rridresp { u8 data[HFA384x_RIDDATA_MAXLEN]; } __packed; -typedef struct hfa384x_usb_statusresp hfa384x_usb_wmemresp_t; - typedef struct hfa384x_usb_rmemresp { u16 type; u16 frmlen; @@ -919,7 +917,7 @@ struct hfa384x_usb_rridresp { struct hfa384x_usb_statusresp cmdresp; struct hfa384x_usb_statusresp wridresp; struct hfa384x_usb_rridresp rridresp; - hfa384x_usb_wmemresp_t wmemresp; + struct hfa384x_usb_statusresp wmemresp; hfa384x_usb_rmemresp_t rmemresp; hfa384x_usb_bufavail_t bufavail; hfa384x_usb_error_t usberror; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 44/87] staging: wlang-ng: avoid new typedef: hfa384x_usbout_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usbout_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 58b1ac5..2365edc 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -899,7 +899,7 @@ struct hfa384x_usb_error { /*--*/ /* Unions for packaging all the known packet types together */ -typedef union hfa384x_usbout { +union hfa384x_usbout { __le16 type; struct hfa384x_usb_txfrm txfrm; struct hfa384x_usb_cmdreq cmdreq; @@ -907,7 +907,7 @@ struct hfa384x_usb_error { struct hfa384x_usb_rridreq rridreq; struct hfa384x_usb_wmemreq wmemreq; struct hfa384x_usb_rmemreq rmemreq; -} __packed hfa384x_usbout_t; +} __packed; typedef union hfa384x_usbin { __le16 type; @@ -1183,7 +1183,7 @@ typedef void (*ctlx_usercb_t) (struct hfa384x *hw, struct list_head list; size_t outbufsize; - hfa384x_usbout_t outbuf;/* pkt buf for OUT */ + union hfa384x_usbout outbuf;/* pkt buf for OUT */ hfa384x_usbin_t inbuf; /* pkt buf for IN(a copy) */ CTLX_STATE state; /* Tracks running state */ @@ -1248,7 +1248,7 @@ struct prism2sta_accesslist { struct sk_buff *rx_urb_skb; struct urb tx_urb; struct urb ctlx_urb; - hfa384x_usbout_t txbuff; + union hfa384x_usbout txbuff; hfa384x_usbctlxq_t ctlxq; struct timer_list reqtimer; struct timer_list resptimer; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 45/87] staging: wlang-ng: avoid new typedef: hfa384x_usbin_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usbin_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 21 +++-- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 2365edc..f715f5f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -909,7 +909,7 @@ struct hfa384x_usb_error { struct hfa384x_usb_rmemreq rmemreq; } __packed; -typedef union hfa384x_usbin { +union hfa384x_usbin { __le16 type; struct hfa384x_usb_rxfrm rxfrm; struct hfa384x_usb_txfrm txfrm; @@ -922,7 +922,7 @@ struct hfa384x_usb_error { struct hfa384x_usb_bufavail bufavail; struct hfa384x_usb_error usberror; u8 boguspad[3000]; -} __packed hfa384x_usbin_t; +} __packed; /* * PD record structures. @@ -1184,7 +1184,7 @@ typedef void (*ctlx_usercb_t) (struct hfa384x *hw, size_t outbufsize; union hfa384x_usbout outbuf;/* pkt buf for OUT */ - hfa384x_usbin_t inbuf; /* pkt buf for IN(a copy) */ + union hfa384x_usbin inbuf; /* pkt buf for IN(a copy) */ CTLX_STATE state; /* Tracks running state */ diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index d76ec2a..9203880 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -169,13 +169,13 @@ enum cmd_mode { static void hfa384x_usbin_callback(struct urb *urb); static void -hfa384x_usbin_txcompl(struct wlandevice *wlandev, hfa384x_usbin_t *usbin); +hfa384x_usbin_txcompl(struct wlandevice *wlandev, union hfa384x_usbin *usbin); static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb); -static void hfa384x_usbin_info(struct wlandevice *wlandev, hfa384x_usbin_t *usbin); +static void hfa384x_usbin_info(struct wlandevice *wlandev, union hfa384x_usbin *usbin); -static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin, +static void hfa384x_usbin_ctlx(hfa384x_t *hw, union hfa384x_usbin *usbin, int urb_status); /*---*/ @@ -327,7 +327,7 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags) struct sk_buff *skb; int result; - skb = dev_alloc_skb(sizeof(hfa384x_usbin_t)); + skb = dev_alloc_skb(sizeof(union hfa384x_usbin)); if (!skb) { result = -ENOMEM; goto done; @@ -336,7 +336,7 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags) /* Post the IN urb */ usb_fill_bulk_urb(&hw->rx_urb, hw->usb, hw->endp_in, - skb->data, sizeof(hfa384x_usbin_t), + skb->data, sizeof(union hfa384x_usbin), hfa384x_usbin_callback, hw->wlandev); hw->rx_urb_skb = skb; @@ -2990,7 +2990,7 @@ static void hfa384x_usbin_callback(struct urb *urb) { struct wlandevice *wlandev = urb->context; hfa384x_t *hw; - hfa384x_usbin_t *usbin = (hfa384x_usbin_t *)urb->transfer_buffer; + union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; struct sk_buff *skb = NULL; int result; int urb_status; @@ -3166,7 +3166,7 @@ static void hfa384x_usbin_callback(struct urb *urb) * Call context: * interrupt */ -static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin, +static void hfa384x_usbin_ctlx(hfa384x_t *hw, union hfa384x_usbin *usbin, int urb_status) { hfa384x_usbctlx_t *ctlx; @@ -3286,7 +3286,7 @@ static void hfa384x_usbin_ctlx(hfa384x_t *hw, hfa384x_usbin_t *usbin, * interrupt */ static void hfa384x_usbin_txcompl(struct wlandevice *wlandev, - hfa384x_usbin_t *usbin) + union hfa384x_usbin *usbin) { u16 status; @@ -3318,7 +3318,7 @@ static void hfa384x_usbin_txcompl(struct wlandevice *wlandev, */ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb) { - hfa384x_usbin_t *usbin = (hfa384x_usbin_t *)skb->data; + union hfa384x_usbin *usbin = (union hfa384x_usbin *)skb->data; hfa384x_t *hw = wlandev->priv; int hdrlen; struct p80211_rxmeta *rxmeta; @@ -3517,7 +3517,8 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, * Call context: * interrupt
[PATCH 41/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_rmemresp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 28c008c..955f22d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -880,11 +880,11 @@ struct hfa384x_usb_rridresp { u8 data[HFA384x_RIDDATA_MAXLEN]; } __packed; -typedef struct hfa384x_usb_rmemresp { +struct hfa384x_usb_rmemresp { u16 type; u16 frmlen; u8 data[HFA384x_USB_RWMEM_MAXLEN]; -} __packed hfa384x_usb_rmemresp_t; +} __packed; typedef struct hfa384x_usb_bufavail { u16 type; @@ -918,7 +918,7 @@ struct hfa384x_usb_rridresp { struct hfa384x_usb_statusresp wridresp; struct hfa384x_usb_rridresp rridresp; struct hfa384x_usb_statusresp wmemresp; - hfa384x_usb_rmemresp_t rmemresp; + struct hfa384x_usb_rmemresp rmemresp; hfa384x_usb_bufavail_t bufavail; hfa384x_usb_error_t usberror; u8 boguspad[3000]; diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index c21c591..d76ec2a 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -744,7 +744,7 @@ static inline struct usbctlx_completor *init_rrid_completor( struct usbctlx_rmem_completor { struct usbctlx_completor head; - const hfa384x_usb_rmemresp_t *rmemresp; + const struct hfa384x_usb_rmemresp *rmemresp; void *data; unsigned int len; }; @@ -762,7 +762,7 @@ static int usbctlx_rmem_completor_fn(struct usbctlx_completor *head) static inline struct usbctlx_completor *init_rmem_completor( struct usbctlx_rmem_completor *completor, - hfa384x_usb_rmemresp_t + struct hfa384x_usb_rmemresp *rmemresp, void *data, unsigned int len) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 51/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_mfisuprange_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 2986d17..d558a1f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -963,12 +963,12 @@ struct hfa384x_pdr_nic_ramsize { u8 size[12];/* units of KB */ } __packed; -typedef struct hfa384x_pdr_mfisuprange { +struct hfa384x_pdr_mfisuprange { u16 id; u16 variant; u16 bottom; u16 top; -} __packed hfa384x_pdr_mfisuprange_t; +} __packed; typedef struct hfa384x_pdr_cfisuprange { u16 id; @@ -1099,7 +1099,7 @@ struct hfa384x_pdr_nic_ramsize { struct hfa384x_pdr_nic_serial nic_serial; struct hfa384x_pdr_mkk_measurements mkk_measurements; struct hfa384x_pdr_nic_ramsize nic_ramsize; - hfa384x_pdr_mfisuprange_t mfisuprange; + struct hfa384x_pdr_mfisuprange mfisuprange; hfa384x_pdr_cfisuprange_t cfisuprange; hfa384x_pdr_nicid_t nicid; hfa384x_pdr_refdac_measurements_t refdac_measurements; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 18/87] staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_ChInfoResultSub_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/prism2sta.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1da5a67..beb97d9 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -678,19 +678,19 @@ struct hfa384x_ScanResult { } __packed; /*-- Inquiry Frame, Diagnose: ChInfo Results & Subfields--*/ -typedef struct hfa384x_ChInfoResultSub { +struct hfa384x_ChInfoResultSub { u16 chid; u16 anl; u16 pnl; u16 active; -} __packed hfa384x_ChInfoResultSub_t; +} __packed; #define HFA384x_CHINFORESULT_BSSACTIVE BIT(0) #define HFA384x_CHINFORESULT_PCFACTIVE BIT(1) typedef struct hfa384x_ChInfoResult { u16 scanchannels; - hfa384x_ChInfoResultSub_t result[HFA384x_CHINFORESULT_MAX]; + struct hfa384x_ChInfoResultSub result[HFA384x_CHINFORESULT_MAX]; } __packed hfa384x_ChInfoResult_t; /*-- Inquiry Frame, Diagnose: Host Scan Results & Subfields--*/ diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 5dfa3fc..5773159 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1134,8 +1134,8 @@ static void prism2sta_inf_chinforesults(struct wlandevice *wlandev, le16_to_cpu(inf->info.chinforesult.scanchannels); for (i = 0, n = 0; i < HFA384x_CHINFORESULT_MAX; i++) { - hfa384x_ChInfoResultSub_t *result; - hfa384x_ChInfoResultSub_t *chinforesult; + struct hfa384x_ChInfoResultSub *result; + struct hfa384x_ChInfoResultSub *chinforesult; int chan; if (!(hw->channel_info.results.scanchannels & (1 << i))) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 20/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_HScanResultSub_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 6 +++--- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 8fee24b..343debb 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -694,7 +694,7 @@ struct hfa384x_ChInfoResult { } __packed; /*-- Inquiry Frame, Diagnose: Host Scan Results & Subfields--*/ -typedef struct hfa384x_HScanResultSub { +struct hfa384x_HScanResultSub { u16 chid; u16 anl; u16 sl; @@ -705,12 +705,12 @@ struct hfa384x_ChInfoResult { u8 supprates[10]; /* 802.11 info element */ u16 proberesp_rate; u16 atim; -} __packed hfa384x_HScanResultSub_t; +} __packed; typedef struct hfa384x_HScanResult { u16 nresult; u16 rsvd; - hfa384x_HScanResultSub_t result[HFA384x_HSCANRESULT_MAX]; + struct hfa384x_HScanResultSub result[HFA384x_HSCANRESULT_MAX]; } __packed hfa384x_HScanResult_t; /*-- Unsolicited Frame, MAC Mgmt: LinkStatus --*/ diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 1a98d69..1780875 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -371,7 +371,7 @@ int prism2mgmt_scan_results(struct wlandevice *wlandev, void *msgp) int result = 0; struct p80211msg_dot11req_scan_results *req; hfa384x_t *hw = wlandev->priv; - hfa384x_HScanResultSub_t *item = NULL; + struct hfa384x_HScanResultSub *item = NULL; int count; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 47/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_pcb_tracenum_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 7ecbf2f..a989198 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -933,9 +933,9 @@ struct hfa384x_pdr_pcb_partnum { u8 num[8]; } __packed; -typedef struct hfa384x_pdr_pcb_tracenum { +struct hfa384x_pdr_pcb_tracenum { u8 num[8]; -} __packed hfa384x_pdr_pcb_tracenum_t; +} __packed; typedef struct hfa384x_pdr_nic_serial { u8 num[12]; @@ -1095,7 +1095,7 @@ struct hfa384x_pdr_pcb_partnum { u16 code; union pdr { struct hfa384x_pdr_pcb_partnum pcb_partnum; - hfa384x_pdr_pcb_tracenum_t pcb_tracenum; + struct hfa384x_pdr_pcb_tracenum pcb_tracenum; hfa384x_pdr_nic_serial_t nic_serial; hfa384x_pdr_mkk_measurements_t mkk_measurements; hfa384x_pdr_nic_ramsize_t nic_ramsize; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 50/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_nic_ramsize_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 79f3761..2986d17 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -959,9 +959,9 @@ struct hfa384x_pdr_mkk_measurements { double rx_spur_l2; } __packed; -typedef struct hfa384x_pdr_nic_ramsize { +struct hfa384x_pdr_nic_ramsize { u8 size[12];/* units of KB */ -} __packed hfa384x_pdr_nic_ramsize_t; +} __packed; typedef struct hfa384x_pdr_mfisuprange { u16 id; @@ -1098,7 +1098,7 @@ struct hfa384x_pdr_mkk_measurements { struct hfa384x_pdr_pcb_tracenum pcb_tracenum; struct hfa384x_pdr_nic_serial nic_serial; struct hfa384x_pdr_mkk_measurements mkk_measurements; - hfa384x_pdr_nic_ramsize_t nic_ramsize; + struct hfa384x_pdr_nic_ramsize nic_ramsize; hfa384x_pdr_mfisuprange_t mfisuprange; hfa384x_pdr_cfisuprange_t cfisuprange; hfa384x_pdr_nicid_t nicid; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 38/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_wridresp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 24e8ac4..18588d6 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -873,8 +873,6 @@ struct hfa384x_usb_statusresp { u16 resp2; } __packed; -typedef struct hfa384x_usb_statusresp hfa384x_usb_wridresp_t; - typedef struct hfa384x_usb_rridresp { u16 type; u16 frmlen; @@ -919,7 +917,7 @@ struct hfa384x_usb_statusresp { struct hfa384x_usb_txfrm txfrm; struct hfa384x_usb_infofrm infofrm; struct hfa384x_usb_statusresp cmdresp; - hfa384x_usb_wridresp_t wridresp; + struct hfa384x_usb_statusresp wridresp; hfa384x_usb_rridresp_t rridresp; hfa384x_usb_wmemresp_t wmemresp; hfa384x_usb_rmemresp_t rmemresp; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 48/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_nic_serial_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index a989198..dcb181e 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -937,9 +937,9 @@ struct hfa384x_pdr_pcb_tracenum { u8 num[8]; } __packed; -typedef struct hfa384x_pdr_nic_serial { +struct hfa384x_pdr_nic_serial { u8 num[12]; -} __packed hfa384x_pdr_nic_serial_t; +} __packed; typedef struct hfa384x_pdr_mkk_measurements { double carrier_freq; @@ -1096,7 +1096,7 @@ struct hfa384x_pdr_pcb_tracenum { union pdr { struct hfa384x_pdr_pcb_partnum pcb_partnum; struct hfa384x_pdr_pcb_tracenum pcb_tracenum; - hfa384x_pdr_nic_serial_t nic_serial; + struct hfa384x_pdr_nic_serial nic_serial; hfa384x_pdr_mkk_measurements_t mkk_measurements; hfa384x_pdr_nic_ramsize_t nic_ramsize; hfa384x_pdr_mfisuprange_t mfisuprange; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 21/87] staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_HScanResult_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 343debb..123987f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -707,11 +707,11 @@ struct hfa384x_HScanResultSub { u16 atim; } __packed; -typedef struct hfa384x_HScanResult { +struct hfa384x_HScanResult { u16 nresult; u16 rsvd; struct hfa384x_HScanResultSub result[HFA384x_HSCANRESULT_MAX]; -} __packed hfa384x_HScanResult_t; +} __packed; /*-- Unsolicited Frame, MAC Mgmt: LinkStatus --*/ @@ -766,7 +766,7 @@ struct hfa384x_HScanResultSub { struct hfa384x_CommTallies32 commtallies32; struct hfa384x_ScanResult scanresult; struct hfa384x_ChInfoResult chinforesult; - hfa384x_HScanResult_t hscanresult; + struct hfa384x_HScanResult hscanresult; hfa384x_LinkStatus_t linkstatus; hfa384x_AssocStatus_t assocstatus; hfa384x_AuthReq_t authreq; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 49/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_mkk_measurements_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index dcb181e..79f3761 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -941,7 +941,7 @@ struct hfa384x_pdr_nic_serial { u8 num[12]; } __packed; -typedef struct hfa384x_pdr_mkk_measurements { +struct hfa384x_pdr_mkk_measurements { double carrier_freq; double occupied_band; double power_density; @@ -957,7 +957,7 @@ struct hfa384x_pdr_nic_serial { double rx_spur_f2; double rx_spur_l1; double rx_spur_l2; -} __packed hfa384x_pdr_mkk_measurements_t; +} __packed; typedef struct hfa384x_pdr_nic_ramsize { u8 size[12];/* units of KB */ @@ -1097,7 +1097,7 @@ struct hfa384x_pdr_nic_serial { struct hfa384x_pdr_pcb_partnum pcb_partnum; struct hfa384x_pdr_pcb_tracenum pcb_tracenum; struct hfa384x_pdr_nic_serial nic_serial; - hfa384x_pdr_mkk_measurements_t mkk_measurements; + struct hfa384x_pdr_mkk_measurements mkk_measurements; hfa384x_pdr_nic_ramsize_t nic_ramsize; hfa384x_pdr_mfisuprange_t mfisuprange; hfa384x_pdr_cfisuprange_t cfisuprange; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 42/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_bufavail_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 955f22d..09f7ce5 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -886,10 +886,10 @@ struct hfa384x_usb_rmemresp { u8 data[HFA384x_USB_RWMEM_MAXLEN]; } __packed; -typedef struct hfa384x_usb_bufavail { +struct hfa384x_usb_bufavail { u16 type; u16 frmlen; -} __packed hfa384x_usb_bufavail_t; +} __packed; typedef struct hfa384x_usb_error { u16 type; @@ -919,7 +919,7 @@ struct hfa384x_usb_rmemresp { struct hfa384x_usb_rridresp rridresp; struct hfa384x_usb_statusresp wmemresp; struct hfa384x_usb_rmemresp rmemresp; - hfa384x_usb_bufavail_t bufavail; + struct hfa384x_usb_bufavail bufavail; hfa384x_usb_error_t usberror; u8 boguspad[3000]; } __packed hfa384x_usbin_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 53/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_nicid_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 26d72a3..68267b5 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -977,12 +977,12 @@ struct hfa384x_pdr_cfisuprange { u16 top; } __packed; -typedef struct hfa384x_pdr_nicid { +struct hfa384x_pdr_nicid { u16 id; u16 variant; u16 major; u16 minor; -} __packed hfa384x_pdr_nicid_t; +} __packed; typedef struct hfa384x_pdr_refdac_measurements { u16 value[0]; @@ -1101,7 +1101,7 @@ struct hfa384x_pdr_cfisuprange { struct hfa384x_pdr_nic_ramsize nic_ramsize; struct hfa384x_pdr_mfisuprange mfisuprange; struct hfa384x_pdr_cfisuprange cfisuprange; - hfa384x_pdr_nicid_t nicid; + struct hfa384x_pdr_nicid nicid; hfa384x_pdr_refdac_measurements_t refdac_measurements; hfa384x_pdr_vgdac_measurements_t vgdac_measurements; hfa384x_pdr_level_compc_measurements_t level_compc_measurements; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 54/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_refdac_measurements_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 68267b5..47aa64a 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -984,9 +984,9 @@ struct hfa384x_pdr_nicid { u16 minor; } __packed; -typedef struct hfa384x_pdr_refdac_measurements { +struct hfa384x_pdr_refdac_measurements { u16 value[0]; -} __packed hfa384x_pdr_refdac_measurements_t; +} __packed; typedef struct hfa384x_pdr_vgdac_measurements { u16 value[0]; @@ -1102,7 +1102,7 @@ struct hfa384x_pdr_nicid { struct hfa384x_pdr_mfisuprange mfisuprange; struct hfa384x_pdr_cfisuprange cfisuprange; struct hfa384x_pdr_nicid nicid; - hfa384x_pdr_refdac_measurements_t refdac_measurements; + struct hfa384x_pdr_refdac_measurements refdac_measurements; hfa384x_pdr_vgdac_measurements_t vgdac_measurements; hfa384x_pdr_level_compc_measurements_t level_compc_measurements; hfa384x_pdr_mac_address_t mac_address; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 75/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_nic_config_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 9232855..ce85adf 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1070,9 +1070,9 @@ struct hfa384x_pdr_hfa3861_chcali { u16 value[17]; } __packed; -typedef struct hfa384x_pdr_hfa3861_nic_config { +struct hfa384x_pdr_hfa3861_nic_config { u16 config_bitmap; -} __packed hfa384x_pdr_nic_config_t; +} __packed; typedef struct hfa384x_pdr_hfo_delay { u8 hfo_delay; @@ -1123,7 +1123,7 @@ struct hfa384x_pdr_hfa3861_chcali { struct hfa384x_pdr_hfa3861_ifrf hfa3861_ifrf; struct hfa384x_pdr_hfa3861_chcalsp hfa3861_chcalsp; struct hfa384x_pdr_hfa3861_chcali hfa3861_chcali; - hfa384x_pdr_nic_config_t nic_config; + struct hfa384x_pdr_hfa3861_nic_config nic_config; hfa384x_hfo_delay_t hfo_delay; hfa384x_pdr_hfa3861_manf_testsp_t hfa3861_manf_testsp; hfa384x_pdr_hfa3861_manf_testi_t hfa3861_manf_testi; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 65/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_vgdac_setup_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index cebc52e..bab8665 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1029,9 +1029,9 @@ struct hfa384x_pdr_refdac_setup { u16 ch_value[14]; } __packed; -typedef struct hfa384x_pdr_vgdac_setup { +struct hfa384x_pdr_vgdac_setup { u16 ch_value[14]; -} __packed hfa384x_pdr_vgdac_setup_t; +} __packed; typedef struct hfa384x_pdr_level_comp_setup { u16 ch_value[14]; @@ -1113,7 +1113,7 @@ struct hfa384x_pdr_refdac_setup { struct hfa384x_pdr_privacy_option privacy_option; struct hfa384x_pdr_temptype temptype; struct hfa384x_pdr_refdac_setup refdac_setup; - hfa384x_pdr_vgdac_setup_t vgdac_setup; + struct hfa384x_pdr_vgdac_setup vgdac_setup; hfa384x_pdr_level_comp_setup_t level_comp_setup; hfa384x_pdr_trimdac_setup_t trimdac_setup; hfa384x_pdr_ifr_setting_t ifr_setting; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 52/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_cfisuprange_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index d558a1f..26d72a3 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -970,12 +970,12 @@ struct hfa384x_pdr_mfisuprange { u16 top; } __packed; -typedef struct hfa384x_pdr_cfisuprange { +struct hfa384x_pdr_cfisuprange { u16 id; u16 variant; u16 bottom; u16 top; -} __packed hfa384x_pdr_cfisuprange_t; +} __packed; typedef struct hfa384x_pdr_nicid { u16 id; @@ -1100,7 +1100,7 @@ struct hfa384x_pdr_mfisuprange { struct hfa384x_pdr_mkk_measurements mkk_measurements; struct hfa384x_pdr_nic_ramsize nic_ramsize; struct hfa384x_pdr_mfisuprange mfisuprange; - hfa384x_pdr_cfisuprange_t cfisuprange; + struct hfa384x_pdr_cfisuprange cfisuprange; hfa384x_pdr_nicid_t nicid; hfa384x_pdr_refdac_measurements_t refdac_measurements; hfa384x_pdr_vgdac_measurements_t vgdac_measurements; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 74/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_chcali_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 7d63dd8..9232855 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1066,9 +1066,9 @@ struct hfa384x_pdr_hfa3861_chcalsp { u16 value[14]; } __packed; -typedef struct hfa384x_pdr_hfa3861_chcali { +struct hfa384x_pdr_hfa3861_chcali { u16 value[17]; -} __packed hfa384x_pdr_hfa3861_chcali_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_nic_config { u16 config_bitmap; @@ -1122,7 +1122,7 @@ struct hfa384x_pdr_hfa3861_chcalsp { struct hfa384x_pdr_hfa3861_shadow hfa3861_shadow; struct hfa384x_pdr_hfa3861_ifrf hfa3861_ifrf; struct hfa384x_pdr_hfa3861_chcalsp hfa3861_chcalsp; - hfa384x_pdr_hfa3861_chcali_t hfa3861_chcali; + struct hfa384x_pdr_hfa3861_chcali hfa3861_chcali; hfa384x_pdr_nic_config_t nic_config; hfa384x_hfo_delay_t hfo_delay; hfa384x_pdr_hfa3861_manf_testsp_t hfa3861_manf_testsp; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 69/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_rfr_setting_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1400cb2..b51b568 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1046,9 +1046,9 @@ struct hfa384x_pdr_ifr_setting { u16 value[3]; } __packed; -typedef struct hfa384x_pdr_rfr_setting { +struct hfa384x_pdr_rfr_setting { u16 value[3]; -} __packed hfa384x_pdr_rfr_setting_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_baseline { u16 value[50]; @@ -1117,7 +1117,7 @@ struct hfa384x_pdr_ifr_setting { struct hfa384x_pdr_level_comp_setup level_comp_setup; struct hfa384x_pdr_trimdac_setup trimdac_setup; struct hfa384x_pdr_ifr_setting ifr_setting; - hfa384x_pdr_rfr_setting_t rfr_setting; + struct hfa384x_pdr_rfr_setting rfr_setting; hfa384x_pdr_hfa3861_baseline_t hfa3861_baseline; hfa384x_pdr_hfa3861_shadow_t hfa3861_shadow; hfa384x_pdr_hfa3861_ifrf_t hfa3861_ifrf; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 70/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_baseline_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index b51b568..306f3bb 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1050,9 +1050,9 @@ struct hfa384x_pdr_rfr_setting { u16 value[3]; } __packed; -typedef struct hfa384x_pdr_hfa3861_baseline { +struct hfa384x_pdr_hfa3861_baseline { u16 value[50]; -} __packed hfa384x_pdr_hfa3861_baseline_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_shadow { u32 value[32]; @@ -1118,7 +1118,7 @@ struct hfa384x_pdr_rfr_setting { struct hfa384x_pdr_trimdac_setup trimdac_setup; struct hfa384x_pdr_ifr_setting ifr_setting; struct hfa384x_pdr_rfr_setting rfr_setting; - hfa384x_pdr_hfa3861_baseline_t hfa3861_baseline; + struct hfa384x_pdr_hfa3861_baseline hfa3861_baseline; hfa384x_pdr_hfa3861_shadow_t hfa3861_shadow; hfa384x_pdr_hfa3861_ifrf_t hfa3861_ifrf; hfa384x_pdr_hfa3861_chcalsp_t hfa3861_chcalsp; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 56/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_compc_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_level_compc_measurements_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index b0a4b24..4fa91f0 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -992,9 +992,9 @@ struct hfa384x_pdr_vgdac_measurements { u16 value[0]; } __packed; -typedef struct hfa384x_pdr_level_comp_measurements { +struct hfa384x_pdr_level_comp_measurements { u16 value[0]; -} __packed hfa384x_pdr_level_compc_measurements_t; +} __packed; typedef struct hfa384x_pdr_mac_address { u8 addr[6]; @@ -1104,7 +1104,7 @@ struct hfa384x_pdr_vgdac_measurements { struct hfa384x_pdr_nicid nicid; struct hfa384x_pdr_refdac_measurements refdac_measurements; struct hfa384x_pdr_vgdac_measurements vgdac_measurements; - hfa384x_pdr_level_compc_measurements_t level_compc_measurements; + struct hfa384x_pdr_level_comp_measurements level_compc_measurements; hfa384x_pdr_mac_address_t mac_address; hfa384x_pdr_mkk_callname_t mkk_callname; hfa384x_pdr_regdomain_t regdomain; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 55/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_vgdac_measurements_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 47aa64a..b0a4b24 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -988,9 +988,9 @@ struct hfa384x_pdr_refdac_measurements { u16 value[0]; } __packed; -typedef struct hfa384x_pdr_vgdac_measurements { +struct hfa384x_pdr_vgdac_measurements { u16 value[0]; -} __packed hfa384x_pdr_vgdac_measurements_t; +} __packed; typedef struct hfa384x_pdr_level_comp_measurements { u16 value[0]; @@ -1103,7 +1103,7 @@ struct hfa384x_pdr_refdac_measurements { struct hfa384x_pdr_cfisuprange cfisuprange; struct hfa384x_pdr_nicid nicid; struct hfa384x_pdr_refdac_measurements refdac_measurements; - hfa384x_pdr_vgdac_measurements_t vgdac_measurements; + struct hfa384x_pdr_vgdac_measurements vgdac_measurements; hfa384x_pdr_level_compc_measurements_t level_compc_measurements; hfa384x_pdr_mac_address_t mac_address; hfa384x_pdr_mkk_callname_t mkk_callname; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 31/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_wridreq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index affdeef..e0cfe79 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -822,12 +822,12 @@ struct hfa384x_usb_cmdreq { u8 pad[54]; } __packed; -typedef struct hfa384x_usb_wridreq { +struct hfa384x_usb_wridreq { u16 type; u16 frmlen; u16 rid; u8 data[HFA384x_RIDDATA_MAXLEN]; -} __packed hfa384x_usb_wridreq_t; +} __packed; typedef struct hfa384x_usb_rridreq { u16 type; @@ -907,7 +907,7 @@ struct hfa384x_usb_cmdreq { __le16 type; struct hfa384x_usb_txfrm txfrm; struct hfa384x_usb_cmdreq cmdreq; - hfa384x_usb_wridreq_t wridreq; + struct hfa384x_usb_wridreq wridreq; hfa384x_usb_rridreq_t rridreq; hfa384x_usb_wmemreq_t wmemreq; hfa384x_usb_rmemreq_t rmemreq; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 79/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_end_of_pda_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 1d86ccf..45bc4a8 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1086,9 +1086,9 @@ struct hfa384x_pdr_hfa3861_manf_testi { u16 value[30]; } __packed; -typedef struct hfa384x_end_of_pda { +struct hfa384x_pdr_end_of_pda { u16 crc; -} __packed hfa384x_pdr_end_of_pda_t; +} __packed; typedef struct hfa384x_pdrec { u16 len;/* in words */ @@ -1127,7 +1127,7 @@ struct hfa384x_pdr_hfa3861_manf_testi { struct hfa384x_pdr_hfo_delay hfo_delay; struct hfa384x_pdr_hfa3861_manf_testsp hfa3861_manf_testsp; struct hfa384x_pdr_hfa3861_manf_testi hfa3861_manf_testi; - hfa384x_pdr_end_of_pda_t end_of_pda; + struct hfa384x_pdr_end_of_pda end_of_pda; } data; } __packed hfa384x_pdrec_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 46/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_pcb_partnum_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index f715f5f..7ecbf2f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -929,9 +929,9 @@ struct hfa384x_usb_error { * */ -typedef struct hfa384x_pdr_pcb_partnum { +struct hfa384x_pdr_pcb_partnum { u8 num[8]; -} __packed hfa384x_pdr_pcb_partnum_t; +} __packed; typedef struct hfa384x_pdr_pcb_tracenum { u8 num[8]; @@ -1094,7 +1094,7 @@ struct hfa384x_usb_error { u16 len;/* in words */ u16 code; union pdr { - hfa384x_pdr_pcb_partnum_t pcb_partnum; + struct hfa384x_pdr_pcb_partnum pcb_partnum; hfa384x_pdr_pcb_tracenum_t pcb_tracenum; hfa384x_pdr_nic_serial_t nic_serial; hfa384x_pdr_mkk_measurements_t mkk_measurements; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 26/87] staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_KeyIDChanged_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 4d078e2..532b1a7 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -755,10 +755,10 @@ struct hfa384x_PSUserCount { u16 usercnt; } __packed; -typedef struct hfa384x_KeyIDChanged { +struct hfa384x_KeyIDChanged { u8 sta_addr[ETH_ALEN]; u16 keyid; -} __packed hfa384x_KeyIDChanged_t; +} __packed; /*-- Collection of all Inf frames ---*/ typedef union hfa384x_infodata { @@ -771,7 +771,7 @@ struct hfa384x_PSUserCount { struct hfa384x_AssocStatus assocstatus; struct hfa384x_AuthRequest authreq; struct hfa384x_PSUserCount psusercnt; - hfa384x_KeyIDChanged_t keyidchanged; + struct hfa384x_KeyIDChanged keyidchanged; } __packed hfa384x_infodata_t; typedef struct hfa384x_InfFrame { -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 32/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_rridreq_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index e0cfe79..1300472 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -829,12 +829,12 @@ struct hfa384x_usb_wridreq { u8 data[HFA384x_RIDDATA_MAXLEN]; } __packed; -typedef struct hfa384x_usb_rridreq { +struct hfa384x_usb_rridreq { u16 type; u16 frmlen; u16 rid; u8 pad[58]; -} __packed hfa384x_usb_rridreq_t; +} __packed; typedef struct hfa384x_usb_wmemreq { u16 type; @@ -908,7 +908,7 @@ struct hfa384x_usb_wridreq { struct hfa384x_usb_txfrm txfrm; struct hfa384x_usb_cmdreq cmdreq; struct hfa384x_usb_wridreq wridreq; - hfa384x_usb_rridreq_t rridreq; + struct hfa384x_usb_rridreq rridreq; hfa384x_usb_wmemreq_t wmemreq; hfa384x_usb_rmemreq_t rmemreq; } __packed hfa384x_usbout_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 43/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_error_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 09f7ce5..58b1ac5 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -891,10 +891,10 @@ struct hfa384x_usb_bufavail { u16 frmlen; } __packed; -typedef struct hfa384x_usb_error { +struct hfa384x_usb_error { u16 type; u16 errortype; -} __packed hfa384x_usb_error_t; +} __packed; /*--*/ /* Unions for packaging all the known packet types together */ @@ -920,7 +920,7 @@ struct hfa384x_usb_bufavail { struct hfa384x_usb_statusresp wmemresp; struct hfa384x_usb_rmemresp rmemresp; struct hfa384x_usb_bufavail bufavail; - hfa384x_usb_error_t usberror; + struct hfa384x_usb_error usberror; u8 boguspad[3000]; } __packed hfa384x_usbin_t; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 57/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_mac_address_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 4fa91f0..644f097 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -996,9 +996,9 @@ struct hfa384x_pdr_level_comp_measurements { u16 value[0]; } __packed; -typedef struct hfa384x_pdr_mac_address { +struct hfa384x_pdr_mac_address { u8 addr[6]; -} __packed hfa384x_pdr_mac_address_t; +} __packed; typedef struct hfa384x_pdr_mkk_callname { u8 callname[8]; @@ -1105,7 +1105,7 @@ struct hfa384x_pdr_level_comp_measurements { struct hfa384x_pdr_refdac_measurements refdac_measurements; struct hfa384x_pdr_vgdac_measurements vgdac_measurements; struct hfa384x_pdr_level_comp_measurements level_compc_measurements; - hfa384x_pdr_mac_address_t mac_address; + struct hfa384x_pdr_mac_address mac_address; hfa384x_pdr_mkk_callname_t mkk_callname; hfa384x_pdr_regdomain_t regdomain; hfa384x_pdr_allowed_channel_t allowed_channel; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 58/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_mkk_callname_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 644f097..da7937d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1000,9 +1000,9 @@ struct hfa384x_pdr_mac_address { u8 addr[6]; } __packed; -typedef struct hfa384x_pdr_mkk_callname { +struct hfa384x_pdr_mkk_callname { u8 callname[8]; -} __packed hfa384x_pdr_mkk_callname_t; +} __packed; typedef struct hfa384x_pdr_regdomain { u16 numdomains; @@ -1106,7 +1106,7 @@ struct hfa384x_pdr_mac_address { struct hfa384x_pdr_vgdac_measurements vgdac_measurements; struct hfa384x_pdr_level_comp_measurements level_compc_measurements; struct hfa384x_pdr_mac_address mac_address; - hfa384x_pdr_mkk_callname_t mkk_callname; + struct hfa384x_pdr_mkk_callname mkk_callname; hfa384x_pdr_regdomain_t regdomain; hfa384x_pdr_allowed_channel_t allowed_channel; hfa384x_pdr_default_channel_t default_channel; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 59/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_regdomain_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index da7937d..acd7e1d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1004,10 +1004,10 @@ struct hfa384x_pdr_mkk_callname { u8 callname[8]; } __packed; -typedef struct hfa384x_pdr_regdomain { +struct hfa384x_pdr_regdomain { u16 numdomains; u16 domain[5]; -} __packed hfa384x_pdr_regdomain_t; +} __packed; typedef struct hfa384x_pdr_allowed_channel { u16 ch_bitmap; @@ -1107,7 +1107,7 @@ struct hfa384x_pdr_mkk_callname { struct hfa384x_pdr_level_comp_measurements level_compc_measurements; struct hfa384x_pdr_mac_address mac_address; struct hfa384x_pdr_mkk_callname mkk_callname; - hfa384x_pdr_regdomain_t regdomain; + struct hfa384x_pdr_regdomain regdomain; hfa384x_pdr_allowed_channel_t allowed_channel; hfa384x_pdr_default_channel_t default_channel; hfa384x_pdr_privacy_option_t privacy_option; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 36/87] staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_usb_infofrm_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index b0de7cb..1113676 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -860,10 +860,10 @@ struct hfa384x_usb_rxfrm { u8 data[WLAN_DATA_MAXLEN]; } __packed; -typedef struct hfa384x_usb_infofrm { +struct hfa384x_usb_infofrm { u16 type; struct hfa384x_InfFrame info; -} __packed hfa384x_usb_infofrm_t; +} __packed; typedef struct hfa384x_usb_statusresp { u16 type; @@ -917,7 +917,7 @@ struct hfa384x_usb_rxfrm { __le16 type; struct hfa384x_usb_rxfrm rxfrm; struct hfa384x_usb_txfrm txfrm; - hfa384x_usb_infofrm_t infofrm; + struct hfa384x_usb_infofrm infofrm; hfa384x_usb_cmdresp_t cmdresp; hfa384x_usb_wridresp_t wridresp; hfa384x_usb_rridresp_t rridresp; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 81/87] staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_cmdresult_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- drivers/staging/wlan-ng/hfa384x_usb.c | 16 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 57c394d..a1a347c 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1138,12 +1138,12 @@ struct hfa384x_pdrec { * --- Also, a collection of support types -- * */ -typedef struct hfa384x_statusresult { +struct hfa384x_cmdresult { u16 status; u16 resp0; u16 resp1; u16 resp2; -} hfa384x_cmdresult_t; +}; /* USB Control Exchange (CTLX): * A queue of the structure below is maintained for all of the @@ -1213,7 +1213,7 @@ typedef void (*ctlx_usercb_t) (struct hfa384x *hw, u16 parm1; u16 parm2; - hfa384x_cmdresult_t result; + struct hfa384x_cmdresult result; } hfa384x_metacmd_t; #defineMAX_GRP_ADDR32 diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 9203880..1e5f74c 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -213,7 +213,7 @@ struct usbctlx_completor { static int usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp, - hfa384x_cmdresult_t *result); + struct hfa384x_cmdresult *result); static void usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp, @@ -622,7 +622,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) static int usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp, - hfa384x_cmdresult_t *result) + struct hfa384x_cmdresult *result) { result->status = le16_to_cpu(cmdresp->status); result->resp0 = le16_to_cpu(cmdresp->resp0); @@ -647,13 +647,13 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) /* * Completor object: * This completor must be passed to hfa384x_usbctlx_complete_sync() -* when processing a CTLX that returns a hfa384x_cmdresult_t structure. +* when processing a CTLX that returns a struct hfa384x_cmdresult structure. */ struct usbctlx_cmd_completor { struct usbctlx_completor head; const struct hfa384x_usb_statusresp *cmdresp; - hfa384x_cmdresult_t *result; + struct hfa384x_cmdresult *result; }; static inline int usbctlx_cmd_completor_fn(struct usbctlx_completor *head) @@ -669,7 +669,7 @@ static inline struct usbctlx_completor *init_cmd_completor( *completor, const struct hfa384x_usb_statusresp *cmdresp, - hfa384x_cmdresult_t *result) + struct hfa384x_cmdresult *result) { completor->head.complete = usbctlx_cmd_completor_fn; completor->cmdresp = cmdresp; @@ -798,7 +798,7 @@ static inline struct usbctlx_completor *init_rmem_completor( static void hfa384x_cb_status(hfa384x_t *hw, const hfa384x_usbctlx_t *ctlx) { if (ctlx->usercb) { - hfa384x_cmdresult_t cmdresult; + struct hfa384x_cmdresult cmdresult; if (ctlx->state != CTLX_COMPLETE) { memset(&cmdresult, 0, sizeof(cmdresult)); @@ -1497,7 +1497,7 @@ static int hfa384x_usbctlx_complete_sync(hfa384x_t *hw, kfree(ctlx); } else if (mode == DOWAIT) { struct usbctlx_cmd_completor completor; - hfa384x_cmdresult_t wridresult; + struct hfa384x_cmdresult wridresult; result = hfa384x_usbctlx_complete_sync(hw, ctlx, @@ -1679,7 +1679,7 @@ static int hfa384x_usbctlx_complete_sync(hfa384x_t *hw, kfree(ctlx); } else if (mode == DOWAIT) { struct usbctlx_cmd_completor completor; - hfa384x_cmdresult_t wmemresult; + struct hfa384x_cmdresult wmemresult; result = hfa384x_usbctlx_complete_sync(hw, ctlx, -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 71/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_shadow_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 306f3bb..ebe434f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1054,9 +1054,9 @@ struct hfa384x_pdr_hfa3861_baseline { u16 value[50]; } __packed; -typedef struct hfa384x_pdr_hfa3861_shadow { +struct hfa384x_pdr_hfa3861_shadow { u32 value[32]; -} __packed hfa384x_pdr_hfa3861_shadow_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_ifrf { u32 value[20]; @@ -1119,7 +1119,7 @@ struct hfa384x_pdr_hfa3861_baseline { struct hfa384x_pdr_ifr_setting ifr_setting; struct hfa384x_pdr_rfr_setting rfr_setting; struct hfa384x_pdr_hfa3861_baseline hfa3861_baseline; - hfa384x_pdr_hfa3861_shadow_t hfa3861_shadow; + struct hfa384x_pdr_hfa3861_shadow hfa3861_shadow; hfa384x_pdr_hfa3861_ifrf_t hfa3861_ifrf; hfa384x_pdr_hfa3861_chcalsp_t hfa3861_chcalsp; hfa384x_pdr_hfa3861_chcali_t hfa3861_chcali; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 77/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testsp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_manf_testsp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 4817b01..42e29f0 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1078,9 +1078,9 @@ struct hfa384x_pdr_hfo_delay { u8 hfo_delay; } __packed; -typedef struct hfa384x_pdr_hfa3861_manf_testsp { +struct hfa384x_pdr_hfa3861_manf_testsp { u16 value[30]; -} __packed hfa384x_pdr_hfa3861_manf_testsp_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_manf_testi { u16 value[30]; @@ -1125,7 +1125,7 @@ struct hfa384x_pdr_hfo_delay { struct hfa384x_pdr_hfa3861_chcali hfa3861_chcali; struct hfa384x_pdr_hfa3861_nic_config nic_config; struct hfa384x_pdr_hfo_delay hfo_delay; - hfa384x_pdr_hfa3861_manf_testsp_t hfa3861_manf_testsp; + struct hfa384x_pdr_hfa3861_manf_testsp hfa3861_manf_testsp; hfa384x_pdr_hfa3861_manf_testi_t hfa3861_manf_testi; hfa384x_pdr_end_of_pda_t end_of_pda; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 80/87] staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdrec_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/prism2fw.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 45bc4a8..57c394d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1090,7 +1090,7 @@ struct hfa384x_pdr_end_of_pda { u16 crc; } __packed; -typedef struct hfa384x_pdrec { +struct hfa384x_pdrec { u16 len;/* in words */ u16 code; union pdr { @@ -1130,7 +1130,7 @@ struct hfa384x_pdr_end_of_pda { struct hfa384x_pdr_end_of_pda end_of_pda; } data; -} __packed hfa384x_pdrec_t; +} __packed; #ifdef __KERNEL__ /* diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index ca322fa..96aa211 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -105,7 +105,7 @@ struct s3inforec { struct pda { u8 buf[HFA384x_PDA_LEN_MAX]; - hfa384x_pdrec_t *rec[HFA384x_PDA_RECS_MAX]; + struct hfa384x_pdrec *rec[HFA384x_PDA_RECS_MAX]; unsigned int nrec; }; @@ -266,7 +266,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr, /* clear the pda and add an initial END record */ memset(&pda, 0, sizeof(pda)); - pda.rec[0] = (hfa384x_pdrec_t *)pda.buf; + pda.rec[0] = (struct hfa384x_pdrec *)pda.buf; pda.rec[0]->len = cpu_to_le16(2); /* len in words */ pda.rec[0]->code = cpu_to_le16(HFA384x_PDR_END_OF_PDA); pda.nrec = 1; @@ -599,7 +599,7 @@ static int mkpdrlist(struct pda *pda) curroff = 0; while (curroff < (HFA384x_PDA_LEN_MAX / 2 - 1) && le16_to_cpu(pda16[curroff + 1]) != HFA384x_PDR_END_OF_PDA) { - pda->rec[pda->nrec] = (hfa384x_pdrec_t *)&(pda16[curroff]); + pda->rec[pda->nrec] = (struct hfa384x_pdrec *)&(pda16[curroff]); if (le16_to_cpu(pda->rec[pda->nrec]->code) == HFA384x_PDR_NICID) { @@ -638,7 +638,7 @@ static int mkpdrlist(struct pda *pda) curroff, pda->nrec); return 1; } - pda->rec[pda->nrec] = (hfa384x_pdrec_t *)&(pda16[curroff]); + pda->rec[pda->nrec] = (struct hfa384x_pdrec *)&(pda16[curroff]); (pda->nrec)++; return 0; } -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 63/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_temptype_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index d84a25e..c1e5709 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1021,9 +1021,9 @@ struct hfa384x_pdr_privacy_option { u16 available; } __packed; -typedef struct hfa384x_pdr_temptype { +struct hfa384x_pdr_temptype { u16 type; -} __packed hfa384x_pdr_temptype_t; +} __packed; typedef struct hfa384x_pdr_refdac_setup { u16 ch_value[14]; @@ -,7 +,7 @@ struct hfa384x_pdr_privacy_option { struct hfa384x_pdr_allowed_channel allowed_channel; struct hfa384x_pdr_default_channel default_channel; struct hfa384x_pdr_privacy_option privacy_option; - hfa384x_pdr_temptype_t temptype; + struct hfa384x_pdr_temptype temptype; hfa384x_pdr_refdac_setup_t refdac_setup; hfa384x_pdr_vgdac_setup_t vgdac_setup; hfa384x_pdr_level_comp_setup_t level_comp_setup; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 78/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_manf_testi_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 42e29f0..1d86ccf 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1082,9 +1082,9 @@ struct hfa384x_pdr_hfa3861_manf_testsp { u16 value[30]; } __packed; -typedef struct hfa384x_pdr_hfa3861_manf_testi { +struct hfa384x_pdr_hfa3861_manf_testi { u16 value[30]; -} __packed hfa384x_pdr_hfa3861_manf_testi_t; +} __packed; typedef struct hfa384x_end_of_pda { u16 crc; @@ -1126,7 +1126,7 @@ struct hfa384x_pdr_hfa3861_manf_testsp { struct hfa384x_pdr_hfa3861_nic_config nic_config; struct hfa384x_pdr_hfo_delay hfo_delay; struct hfa384x_pdr_hfa3861_manf_testsp hfa3861_manf_testsp; - hfa384x_pdr_hfa3861_manf_testi_t hfa3861_manf_testi; + struct hfa384x_pdr_hfa3861_manf_testi hfa3861_manf_testi; hfa384x_pdr_end_of_pda_t end_of_pda; } data; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 82/87] staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_rridresult_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/hfa384x_usb.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index a1a347c..9390fdd 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1152,11 +1152,11 @@ struct hfa384x_cmdresult { /* The following hfa384x_* structures are arguments to * the usercb() for the different CTLX types. */ -typedef struct hfa384x_rridresult { +struct hfa384x_rridresult { u16 rid; const void *riddata; unsigned int riddata_len; -} hfa384x_rridresult_t; +}; enum ctlx_state { CTLX_START = 0, /* Start state, not queued */ diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 1e5f74c..17a90c5 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -217,7 +217,7 @@ struct usbctlx_completor { static void usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp, - hfa384x_rridresult_t *result); + struct hfa384x_rridresult *result); /*---*/ /* Low level req/resp CTLX formatters and submitters */ @@ -637,7 +637,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) static void usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp, - hfa384x_rridresult_t *result) + struct hfa384x_rridresult *result) { result->rid = le16_to_cpu(rridresp->rid); result->riddata = rridresp->data; @@ -693,7 +693,7 @@ struct usbctlx_rrid_completor { static int usbctlx_rrid_completor_fn(struct usbctlx_completor *head) { struct usbctlx_rrid_completor *complete; - hfa384x_rridresult_t rridresult; + struct hfa384x_rridresult rridresult; complete = (struct usbctlx_rrid_completor *)head; usbctlx_get_rridresult(complete->rridresp, &rridresult); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 61/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_default_channel_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 00dbe8a..a0ab29d 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1013,9 +1013,9 @@ struct hfa384x_pdr_allowed_channel { u16 ch_bitmap; } __packed; -typedef struct hfa384x_pdr_default_channel { +struct hfa384x_pdr_default_channel { u16 channel; -} __packed hfa384x_pdr_default_channel_t; +} __packed; typedef struct hfa384x_pdr_privacy_option { u16 available; @@ -1109,7 +1109,7 @@ struct hfa384x_pdr_allowed_channel { struct hfa384x_pdr_mkk_callname mkk_callname; struct hfa384x_pdr_regdomain regdomain; struct hfa384x_pdr_allowed_channel allowed_channel; - hfa384x_pdr_default_channel_t default_channel; + struct hfa384x_pdr_default_channel default_channel; hfa384x_pdr_privacy_option_t privacy_option; hfa384x_pdr_temptype_t temptype; hfa384x_pdr_refdac_setup_t refdac_setup; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 73/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_chcalsp_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 25f89ad9..7d63dd8 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1062,9 +1062,9 @@ struct hfa384x_pdr_hfa3861_ifrf { u32 value[20]; } __packed; -typedef struct hfa384x_pdr_hfa3861_chcalsp { +struct hfa384x_pdr_hfa3861_chcalsp { u16 value[14]; -} __packed hfa384x_pdr_hfa3861_chcalsp_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_chcali { u16 value[17]; @@ -1121,7 +1121,7 @@ struct hfa384x_pdr_hfa3861_ifrf { struct hfa384x_pdr_hfa3861_baseline hfa3861_baseline; struct hfa384x_pdr_hfa3861_shadow hfa3861_shadow; struct hfa384x_pdr_hfa3861_ifrf hfa3861_ifrf; - hfa384x_pdr_hfa3861_chcalsp_t hfa3861_chcalsp; + struct hfa384x_pdr_hfa3861_chcalsp hfa3861_chcalsp; hfa384x_pdr_hfa3861_chcali_t hfa3861_chcali; hfa384x_pdr_nic_config_t nic_config; hfa384x_hfo_delay_t hfo_delay; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 66/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_level_comp_setup_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index bab8665..4fc0760 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1033,9 +1033,9 @@ struct hfa384x_pdr_vgdac_setup { u16 ch_value[14]; } __packed; -typedef struct hfa384x_pdr_level_comp_setup { +struct hfa384x_pdr_level_comp_setup { u16 ch_value[14]; -} __packed hfa384x_pdr_level_comp_setup_t; +} __packed; typedef struct hfa384x_pdr_trimdac_setup { u16 trimidac; @@ -1114,7 +1114,7 @@ struct hfa384x_pdr_vgdac_setup { struct hfa384x_pdr_temptype temptype; struct hfa384x_pdr_refdac_setup refdac_setup; struct hfa384x_pdr_vgdac_setup vgdac_setup; - hfa384x_pdr_level_comp_setup_t level_comp_setup; + struct hfa384x_pdr_level_comp_setup level_comp_setup; hfa384x_pdr_trimdac_setup_t trimdac_setup; hfa384x_pdr_ifr_setting_t ifr_setting; hfa384x_pdr_rfr_setting_t rfr_setting; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 68/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_ifr_setting_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index ff4ebd6..1400cb2 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1042,9 +1042,9 @@ struct hfa384x_pdr_trimdac_setup { u16 trimqdac; } __packed; -typedef struct hfa384x_pdr_ifr_setting { +struct hfa384x_pdr_ifr_setting { u16 value[3]; -} __packed hfa384x_pdr_ifr_setting_t; +} __packed; typedef struct hfa384x_pdr_rfr_setting { u16 value[3]; @@ -1116,7 +1116,7 @@ struct hfa384x_pdr_trimdac_setup { struct hfa384x_pdr_vgdac_setup vgdac_setup; struct hfa384x_pdr_level_comp_setup level_comp_setup; struct hfa384x_pdr_trimdac_setup trimdac_setup; - hfa384x_pdr_ifr_setting_t ifr_setting; + struct hfa384x_pdr_ifr_setting ifr_setting; hfa384x_pdr_rfr_setting_t rfr_setting; hfa384x_pdr_hfa3861_baseline_t hfa3861_baseline; hfa384x_pdr_hfa3861_shadow_t hfa3861_shadow; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 76/87] staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_hfo_delay_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index ce85adf..4817b01 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1074,9 +1074,9 @@ struct hfa384x_pdr_hfa3861_nic_config { u16 config_bitmap; } __packed; -typedef struct hfa384x_pdr_hfo_delay { +struct hfa384x_pdr_hfo_delay { u8 hfo_delay; -} __packed hfa384x_hfo_delay_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_manf_testsp { u16 value[30]; @@ -1124,7 +1124,7 @@ struct hfa384x_pdr_hfa3861_nic_config { struct hfa384x_pdr_hfa3861_chcalsp hfa3861_chcalsp; struct hfa384x_pdr_hfa3861_chcali hfa3861_chcali; struct hfa384x_pdr_hfa3861_nic_config nic_config; - hfa384x_hfo_delay_t hfo_delay; + struct hfa384x_pdr_hfo_delay hfo_delay; hfa384x_pdr_hfa3861_manf_testsp_t hfa3861_manf_testsp; hfa384x_pdr_hfa3861_manf_testi_t hfa3861_manf_testi; hfa384x_pdr_end_of_pda_t end_of_pda; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 60/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_allowed_channel_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index acd7e1d..00dbe8a 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1009,9 +1009,9 @@ struct hfa384x_pdr_regdomain { u16 domain[5]; } __packed; -typedef struct hfa384x_pdr_allowed_channel { +struct hfa384x_pdr_allowed_channel { u16 ch_bitmap; -} __packed hfa384x_pdr_allowed_channel_t; +} __packed; typedef struct hfa384x_pdr_default_channel { u16 channel; @@ -1108,7 +1108,7 @@ struct hfa384x_pdr_regdomain { struct hfa384x_pdr_mac_address mac_address; struct hfa384x_pdr_mkk_callname mkk_callname; struct hfa384x_pdr_regdomain regdomain; - hfa384x_pdr_allowed_channel_t allowed_channel; + struct hfa384x_pdr_allowed_channel allowed_channel; hfa384x_pdr_default_channel_t default_channel; hfa384x_pdr_privacy_option_t privacy_option; hfa384x_pdr_temptype_t temptype; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 67/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_trimdac_setup_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 4fc0760..ff4ebd6 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1037,10 +1037,10 @@ struct hfa384x_pdr_level_comp_setup { u16 ch_value[14]; } __packed; -typedef struct hfa384x_pdr_trimdac_setup { +struct hfa384x_pdr_trimdac_setup { u16 trimidac; u16 trimqdac; -} __packed hfa384x_pdr_trimdac_setup_t; +} __packed; typedef struct hfa384x_pdr_ifr_setting { u16 value[3]; @@ -1115,7 +1115,7 @@ struct hfa384x_pdr_level_comp_setup { struct hfa384x_pdr_refdac_setup refdac_setup; struct hfa384x_pdr_vgdac_setup vgdac_setup; struct hfa384x_pdr_level_comp_setup level_comp_setup; - hfa384x_pdr_trimdac_setup_t trimdac_setup; + struct hfa384x_pdr_trimdac_setup trimdac_setup; hfa384x_pdr_ifr_setting_t ifr_setting; hfa384x_pdr_rfr_setting_t rfr_setting; hfa384x_pdr_hfa3861_baseline_t hfa3861_baseline; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 62/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_privacy_option_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index a0ab29d..d84a25e 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1017,9 +1017,9 @@ struct hfa384x_pdr_default_channel { u16 channel; } __packed; -typedef struct hfa384x_pdr_privacy_option { +struct hfa384x_pdr_privacy_option { u16 available; -} __packed hfa384x_pdr_privacy_option_t; +} __packed; typedef struct hfa384x_pdr_temptype { u16 type; @@ -1110,7 +1110,7 @@ struct hfa384x_pdr_default_channel { struct hfa384x_pdr_regdomain regdomain; struct hfa384x_pdr_allowed_channel allowed_channel; struct hfa384x_pdr_default_channel default_channel; - hfa384x_pdr_privacy_option_t privacy_option; + struct hfa384x_pdr_privacy_option privacy_option; hfa384x_pdr_temptype_t temptype; hfa384x_pdr_refdac_setup_t refdac_setup; hfa384x_pdr_vgdac_setup_t vgdac_setup; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 72/87] staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_pdr_hfa3861_ifrf_t Signed-off-by: Sergio Paracuellos Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index ebe434f..25f89ad9 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1058,9 +1058,9 @@ struct hfa384x_pdr_hfa3861_shadow { u32 value[32]; } __packed; -typedef struct hfa384x_pdr_hfa3861_ifrf { +struct hfa384x_pdr_hfa3861_ifrf { u32 value[20]; -} __packed hfa384x_pdr_hfa3861_ifrf_t; +} __packed; typedef struct hfa384x_pdr_hfa3861_chcalsp { u16 value[14]; @@ -1120,7 +1120,7 @@ struct hfa384x_pdr_hfa3861_shadow { struct hfa384x_pdr_rfr_setting rfr_setting; struct hfa384x_pdr_hfa3861_baseline hfa3861_baseline; struct hfa384x_pdr_hfa3861_shadow hfa3861_shadow; - hfa384x_pdr_hfa3861_ifrf_t hfa3861_ifrf; + struct hfa384x_pdr_hfa3861_ifrf hfa3861_ifrf; hfa384x_pdr_hfa3861_chcalsp_t hfa3861_chcalsp; hfa384x_pdr_hfa3861_chcali_t hfa3861_chcali; hfa384x_pdr_nic_config_t nic_config; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel