[PATCH] chardev: add missing line break in pr_warn
To fix super long dmesg error lines like
CHRDEV "dummy_stm.0" major number 224 goes below the dynamic allocation rangeCHRDEV
"dummy_stm.1" major number 223 goes below the dynamic allocation rangeswapper: page
allocation failure: order:8, mode:0x26040c0(GFP_KERNEL|__GFP_COMP|__GFP_NOTRACK)
After fix, it should look like
CHRDEV "dummy_stm.0" major number 224 goes below the dynamic allocation range
CHRDEV "dummy_stm.1" major number 223 goes below the dynamic allocation range
swapper: page allocation failure: order:8,
mode:0x26040c0(GFP_KERNEL|__GFP_COMP|__GFP_NOTRACK)
Reported-by: Philip Li
Signed-off-by: Fengguang Wu
---
fs/char_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/char_dev.c b/fs/char_dev.c
index 687471d..6edd825 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -92,7 +92,7 @@ __register_chrdev_region(unsigned int major, unsigned int
baseminor,
}
if (i < CHRDEV_MAJOR_DYN_END)
- pr_warn("CHRDEV \"%s\" major number %d goes below the
dynamic allocation range",
+ pr_warn("CHRDEV \"%s\" major number %d goes below the
dynamic allocation range\n",
name, i);
if (i == 0) {
--
2.8.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] PCI: hv: Fix interrupt cleanup path
SR-IOV disabled from the host causes a memory leak.
pci-hyperv usually first receives a PCI_EJECT notification
and then proceeds to delete the hpdev list entry in
hv_eject_device_work(). Later in hv_msi_free() since the
device is no longer on the device list hpdev is NULL
and hv_msi_free returns without freeing int_desc as part of
hv_int_desc_free().
Signed-off-by: Cathy Avery
---
drivers/pci/host/pci-hyperv.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index 7e9b2de..449d053 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -732,16 +732,18 @@ static void hv_msi_free(struct irq_domain *domain, struct
msi_domain_info *info,
pdev = msi_desc_to_pci_dev(msi);
hbus = info->data;
- hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));
- if (!hpdev)
+ int_desc = irq_data_get_irq_chip_data(irq_data);
+ if (!int_desc)
return;
- int_desc = irq_data_get_irq_chip_data(irq_data);
- if (int_desc) {
- irq_data->chip_data = NULL;
- hv_int_desc_free(hpdev, int_desc);
+ irq_data->chip_data = NULL;
+ hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));
+ if (!hpdev) {
+ kfree(int_desc);
+ return;
}
+ hv_int_desc_free(hpdev, int_desc);
put_pcichild(hpdev, hv_pcidev_ref_by_slot);
}
--
2.5.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] PCI: hv: Fix interrupt cleanup path
> -Original Message-
> From: Cathy Avery [mailto:cav...@redhat.com]
> Sent: Tuesday, July 12, 2016 8:31 AM
> To: KY Srinivasan ; Haiyang Zhang
> ; Jake Oshins ;
> bhelg...@google.com
> Cc: vkuzn...@redhat.com; de...@linuxdriverproject.org; linux-
> p...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: [PATCH] PCI: hv: Fix interrupt cleanup path
>
> SR-IOV disabled from the host causes a memory leak.
> pci-hyperv usually first receives a PCI_EJECT notification
> and then proceeds to delete the hpdev list entry in
> hv_eject_device_work(). Later in hv_msi_free() since the
> device is no longer on the device list hpdev is NULL
> and hv_msi_free returns without freeing int_desc as part of
> hv_int_desc_free().
>
> Signed-off-by: Cathy Avery
Acked-by: Jake Oshins
> ---
> drivers/pci/host/pci-hyperv.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 7e9b2de..449d053 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -732,16 +732,18 @@ static void hv_msi_free(struct irq_domain *domain,
> struct msi_domain_info *info,
>
> pdev = msi_desc_to_pci_dev(msi);
> hbus = info->data;
> - hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));
> - if (!hpdev)
> + int_desc = irq_data_get_irq_chip_data(irq_data);
> + if (!int_desc)
> return;
>
> - int_desc = irq_data_get_irq_chip_data(irq_data);
> - if (int_desc) {
> - irq_data->chip_data = NULL;
> - hv_int_desc_free(hpdev, int_desc);
> + irq_data->chip_data = NULL;
> + hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));
> + if (!hpdev) {
> + kfree(int_desc);
> + return;
> }
>
> + hv_int_desc_free(hpdev, int_desc);
> put_pcichild(hpdev, hv_pcidev_ref_by_slot);
> }
>
> --
> 2.5.0
I've tested this. It's a good fix. Please take it.
-- Jake Oshins
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
{Spam?} 为企业选拔人才是现代经理人必备的基本素质
devel 为企业选拔人才是现代经理人必备的基本素质 34 -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. 高效招聘与精准面试.xls Description: Binary data ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next,v3] tools: hv: Add a script to help bonding synthetic and VF NICs
From: Haiyang Zhang Date: Mon, 11 Jul 2016 17:06:42 -0700 > From: Haiyang Zhang > > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching > VF NIC (SRIOV virtual function). So the synthetic NIC and VF NIC can > function as one network device, and fail over to the synthetic NIC if VF is > down. > > Mayjor distros (RHEL, Ubuntu, SLES) supported by Hyper-V are supported by > this script. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4] [media] pci: Add tw5864 driver
On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_ prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I have found few micro-issues with checkpatch --strict and would like to resubmit), but would like to hear some second opinion. > It also might be better to issue something like a single > line dev_warn referring to the driver code and just leave > this comment in the driver sources. > > Something like: > > dev_warn(&pci_dev->dev, > "This driver has known defects in video quality\n"); Things get complicated if you consider mainstream distros and their years-behind kernels. The simplest way to preserve correspondence between state of driver and such notice is to contain the notice in the compiled driver. I hope the state of affairs will change to better someday :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon
Found and fixed few very minor coding style nits, will resubmit in few days, now still waiting for comments to v4. https://github.com/bluecherrydvr/linux/commits/tw5864 commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390 Author: Andrey Utkin Date: Wed Jul 13 05:00:28 2016 +0300 Fix checkpatch --strict issue CHECK: Alignment should match open parenthesis #3599: FILE: drivers/media/pci/tw5864/tw5864-video.c:539: +static int tw5864_fmt_vid_cap(struct file *file, void *priv, + struct v4l2_format *f) commit 11a09a1048af597ecf374507b08c809eed91b86d Author: Andrey Utkin Date: Wed Jul 13 04:59:34 2016 +0300 Fix checkpatch --strict issue CHECK: Please don't use multiple blank lines #3244: FILE: drivers/media/pci/tw5864/tw5864-video.c:184: commit 861b2ba8593db7abe89291a4ba85976519783f4a Author: Andrey Utkin Date: Wed Jul 13 04:58:37 2016 +0300 Fix checkpatch --strict issue CHECK: No space is necessary after a cast #3053: FILE: drivers/media/pci/tw5864/tw5864-util.c:36: + return (u8) tw_readl(TW5864_IND_DATA); ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
