[PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
From: Joglekar Tejas This patch fixes the error given by checkpatch.pl Signed-off-by: Joglekar Tejas --- drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c index 29a29d9..48b7723 100644 --- a/drivers/staging/rtl8723au/core/rtw_sreset.c +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter) /* pairwise key */ rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true); /* group key */ - rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0); + rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0); } } } -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
"Joglekar, Tejas (T.)" writes: > From: Joglekar Tejas > > This patch fixes the error given by checkpatch.pl > > Signed-off-by: Joglekar Tejas > --- > drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c > b/drivers/staging/rtl8723au/core/rtw_sreset.c > index 29a29d9..48b7723 100644 > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct > rtw_adapter *padapter) > /* pairwise key */ > rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, > true); > /* group key */ > - rtw_set_key23a(padapter,&padapter->securitypriv, > padapter->securitypriv.dot118021XGrpKeyid, 0); > + rtw_set_key23a(padapter, &padapter->securitypriv, > padapter->securitypriv.dot118021XGrpKeyid, 0); > } > } > } NAK! If you are 'fixing' checkpatch 'errors', do it properly and break down the line and solve the 80 character limit 'error' as well. Jes ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: make "unsigned int __force *" shorter
Use macro "uip" instead of "unsigned int __force *", like "vuip" in
arch/alpha/include/asm/core_cia.h.
Signed-off-by: Geliang Tang
---
drivers/staging/comedi/comedi_compat32.c | 3 +--
drivers/staging/comedi/comedi_compat32.h | 2 ++
drivers/staging/comedi/comedi_fops.c | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.c
b/drivers/staging/comedi/comedi_compat32.c
index f356386..adaef03 100644
--- a/drivers/staging/comedi/comedi_compat32.c
+++ b/drivers/staging/comedi/comedi_compat32.c
@@ -202,8 +202,7 @@ static int get_compat_cmd(struct comedi_cmd __user *cmd,
err |= __get_user(temp.uint, &cmd32->stop_arg);
err |= __put_user(temp.uint, &cmd->stop_arg);
err |= __get_user(temp.uptr, &cmd32->chanlist);
- err |= __put_user((unsigned int __force *)compat_ptr(temp.uptr),
- &cmd->chanlist);
+ err |= __put_user((uip)compat_ptr(temp.uptr), &cmd->chanlist);
err |= __get_user(temp.uint, &cmd32->chanlist_len);
err |= __put_user(temp.uint, &cmd->chanlist_len);
err |= __get_user(temp.uptr, &cmd32->data);
diff --git a/drivers/staging/comedi/comedi_compat32.h
b/drivers/staging/comedi/comedi_compat32.h
index 5ce77f3..8446273 100644
--- a/drivers/staging/comedi/comedi_compat32.h
+++ b/drivers/staging/comedi/comedi_compat32.h
@@ -33,4 +33,6 @@ long comedi_compat_ioctl(struct file *, unsigned int cmd,
unsigned long arg);
#endif /* CONFIG_COMPAT */
+#define uipunsigned int __force *
+
#endif /* _COMEDI_COMPAT32_H */
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 2ba9cdb..d37f4c5 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1714,7 +1714,7 @@ static int do_cmd_ioctl(struct comedi_device *dev,
dev_dbg(dev->class_dev, "test returned %d\n", ret);
cmd = async->cmd;
/* restore chanlist pointer before copying back */
- cmd.chanlist = (unsigned int __force *)user_chanlist;
+ cmd.chanlist = (uip)user_chanlist;
cmd.data = NULL;
if (copy_to_user(arg, &cmd, sizeof(cmd))) {
dev_dbg(dev->class_dev, "fault writing cmd\n");
@@ -1800,7 +1800,7 @@ static int do_cmdtest_ioctl(struct comedi_device *dev,
kfree(cmd.chanlist);/* free kernel copy of user chanlist */
/* restore chanlist pointer before copying back */
- cmd.chanlist = (unsigned int __force *)user_chanlist;
+ cmd.chanlist = (uip)user_chanlist;
if (copy_to_user(arg, &cmd, sizeof(cmd))) {
dev_dbg(dev->class_dev, "bad cmd address\n");
--
2.3.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: make "unsigned int __force *" shorter
On Sun, Jul 26, 2015 at 10:01:34PM +0800, Geliang Tang wrote: > Use macro "uip" instead of "unsigned int __force *", like "vuip" in > arch/alpha/include/asm/core_cia.h. > > Signed-off-by: Geliang Tang The original is easier to understand. Don't add pointless abstractions just to get around a single 80 character line. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote: > "Joglekar, Tejas (T.)" writes: > > From: Joglekar Tejas > > > > This patch fixes the error given by checkpatch.pl > > > > Signed-off-by: Joglekar Tejas > > --- > > drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c > > b/drivers/staging/rtl8723au/core/rtw_sreset.c > > index 29a29d9..48b7723 100644 > > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c > > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c > > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct > > rtw_adapter *padapter) > > /* pairwise key */ > > rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, > > true); > > /* group key */ > > - rtw_set_key23a(padapter,&padapter->securitypriv, > > padapter->securitypriv.dot118021XGrpKeyid, 0); > > + rtw_set_key23a(padapter, &padapter->securitypriv, > > padapter->securitypriv.dot118021XGrpKeyid, 0); > > } > > } > > } > > NAK! > > If you are 'fixing' checkpatch 'errors', do it properly and break down > the line and solve the 80 character limit 'error' as well. > > Jes Jes , Sure, I will break down the line, and remove the 80 character limit issue , before resending the patch. Thanks & Regards, Tejas Joglekar ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging:dgap :Compression of lines for immediate return
This patch compresses two lines into a single line if immediate return statement is found. Also,remove variable rc as it is no longer needed. It is done using tool Coccinelle. And semantic patch used for this is as follows: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; --- drivers/staging/dgap/dgap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 26b0446..2bb6c68 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, spin_unlock_irqrestore(&ch->ch_lock, lock_flags2); spin_unlock_irqrestore(&bd->bd_lock, lock_flags); - rc = put_user(C_CLOCAL(tty) ? 1 : 0, + return put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *) arg); - return rc; case TIOCSSOFTCAR: spin_unlock_irqrestore(&ch->ch_lock, lock_flags2); -- 2.1.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging:dgap :Compression of lines for immediate return
This patch compresses two lines into a single line if immediate return statement is found. Also,remove variable rc as it is no longer needed. It is done using tool Coccinelle. And semantic patch used for this is as follows: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; --- drivers/staging/dgap/dgap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 26b0446..2bb6c68 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, spin_unlock_irqrestore(&ch->ch_lock, lock_flags2); spin_unlock_irqrestore(&bd->bd_lock, lock_flags); - rc = put_user(C_CLOCAL(tty) ? 1 : 0, + return put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *) arg); - return rc; case TIOCSSOFTCAR: spin_unlock_irqrestore(&ch->ch_lock, lock_flags2); -- 2.1.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] drivers: staging : media : davinci_vpfe : dma365_resizer.c drivers: staging : media : davinci_vpfe : dma365_resizer.h
On Sun, Jul 26, 2015 at 11:03:28AM +0530, Bharadwaaj wrote: > From: "bhaaradw...@gmail.com" This has to match the string you use in the signed-off-by: line. > > Fixed some spelling mistake. > > Signed-off-by: Bharadwaaj Ramakrishnan Please add a ' ' before the '<' character. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c
On Sun, Jul 26, 2015 at 10:59:17AM +0530, Bharadwaaj wrote: > From: "bhaaradw...@gmail.com" Again, this has to match. Your subject alsh needs to say what you are doing, not just what file you are modifying. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: lustre: fixed 80-char rule
On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote: > This patch fixes 2 lines longer than 80 chars > > The first one is a function whose argument has been moved to next line. > The second one is a comment split on two lines > > The script checkpatch does not complain anymore > > Signed-off-by: Mario Bambagini > --- > drivers/staging/lustre/lustre/llite/llite_capa.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c > b/drivers/staging/lustre/lustre/llite/llite_capa.c > index 119f017..1f72066 100644 > --- a/drivers/staging/lustre/lustre/llite/llite_capa.c > +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c > @@ -70,7 +70,8 @@ static unsigned long long ll_capa_renewal_retries; > > static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa); > > -static inline void update_capa_timer(struct obd_capa *ocapa, unsigned long > expiry) > +static inline void update_capa_timer(struct obd_capa *ocapa, > +unsigned long expiry) This is wrong. Run your patch through checkpatch.pl --strict and it will help you. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[RFC PATCH] checkpatch: Make --strict the default for drivers/staging files and patches
Making --strict the default for staging may help some people
submit patches without obvious defects.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 34ca400..50693f5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2174,7 +2174,7 @@ sub process {
}
if ($found_file) {
- if ($realfile =~ m@^(drivers/net/|net/)@) {
+ if ($realfile =~
m@^(?:drivers/net/|net/|drivers/staging/)@) {
$check = 1;
} else {
$check = $check_orig;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: slicoss: Add blank line after variable declarations.
This patch fixes the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
+ unsigned long flags;
+ pshmem = (struct slic_shmem *)(unsigned long)
Signed-off-by: Ciprian Manea
---
drivers/staging/slicoss/slicoss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index a609f3e..8585970 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -2329,6 +2329,7 @@ static int slic_if_init(struct adapter *adapter, unsigned
long *flags)
if (!adapter->isp_initialized) {
unsigned long flags;
+
pshmem = (struct slic_shmem *)(unsigned long)
adapter->phys_shmem;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2 net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe
From: "K. Y. Srinivasan" Date: Wed, 22 Jul 2015 11:42:32 -0700 > The current code returns from probe without waiting for the proper handling > of subchannels that may be requested. If the netvsc driver were to be rapidly > loaded/unloaded, we can trigger a panic as the unload will be tearing > down state that may not have been fully setup yet. We fix this issue by making > sure that we return from the probe call only after ensuring that the > sub-channel offers in flight are properly handled. > > Reviewed-and-tested-by: Haiyang Zhang Signed-off-by: K. Y. Srinivasan Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/3] staging: most: core.c: remove semicolon at the end of define statement
Remove semicolon at the end of define statement to fix checkpatch warning. WARNING: macros should not use a trailing semicolon Signed-off-by: Chaehyun Lim --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 192b53d..261cb62 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -328,7 +328,7 @@ static ssize_t show_channel_starving(struct most_c_obj *c, #define create_show_channel_attribute(val) \ - static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL); + static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL) create_show_channel_attribute(available_directions); create_show_channel_attribute(available_datatypes); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/3] staging: most: core.c: move static static specifier into MOST_CHNL_ATTR
Move static specifier into MOST_CHNL_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Chaehyun Lim
---
drivers/staging/most/mostcore/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index 261cb62..2c998a2 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -111,7 +111,7 @@ struct most_c_attr {
#define to_channel_attr(a) container_of(a, struct most_c_attr, attr)
#define MOST_CHNL_ATTR(_name, _mode, _show, _store) \
- struct most_c_attr most_chnl_attr_##_name = \
+ static struct most_c_attr most_chnl_attr_##_name = \
__ATTR(_name, _mode, _show, _store)
/**
@@ -328,7 +328,7 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
#define create_show_channel_attribute(val) \
- static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
+ MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
create_show_channel_attribute(available_directions);
create_show_channel_attribute(available_datatypes);
@@ -477,7 +477,7 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj
*c,
}
#define create_channel_attribute(value) \
- static MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
+ MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
show_##value, \
store_##value)
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/3] staging: most: core.c: move static specifier into MOST_INST_ATTR
Move static specifier into MOST_INST_ATTR to fix checkpatch error. ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Chaehyun Lim --- drivers/staging/most/mostcore/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index f4f9034..192b53d 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -572,7 +572,7 @@ static void destroy_most_c_obj(struct most_c_obj *c) * ___I N S T A N C E___ */ #define MOST_INST_ATTR(_name, _mode, _show, _store) \ - struct most_inst_attribute most_inst_attr_##_name = \ + static struct most_inst_attribute most_inst_attr_##_name = \ __ATTR(_name, _mode, _show, _store) static struct list_head instance_list; @@ -696,7 +696,7 @@ static ssize_t show_interface(struct most_inst_obj *instance_obj, } #define create_inst_attribute(value) \ - static MOST_INST_ATTR(value, S_IRUGO, show_##value, NULL) + MOST_INST_ATTR(value, S_IRUGO, show_##value, NULL) create_inst_attribute(description); create_inst_attribute(interface); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC
Hi, This is not called in IRQ context and not even held in the spin lock. All of the macros in the driver for the Linux APIs will be removed soon. I expect all of concerns will be also removed at that time. Thanks, Tony. On 2015년 07월 24일 09:44, Dan Carpenter wrote: On Fri, Jul 24, 2015 at 08:55:53AM +0900, Chaehyun Lim wrote: Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim --- V2: Use GFP_KERNEL flag instead of GFP_ATOMIC This is probably the correct thing but how did you check that we aren't holding a spin_lock or in IRQ context? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Cho, Tony Manager, Staff Engineer | Connectivity System Software Team | Atmel Korea (Wireless solutions BU) #409, Kins Tower, Jeongja-Dong, Bundang-Gu, Seongnam-Si, Gyeonggi-Do, 463-782, Korea Phone:82 31 784 8400(Ext. 317); Mobile: 82 10 7232 1523 email: tony@atmel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:dgap :Compression of lines for immediate return
On Sun, Jul 26, 2015 at 11:03:40PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return > statement > is found. Also,remove variable rc as it is no longer needed. > It is done using tool Coccinelle. And semantic patch used for this is as > follows: > > @@ > expression ret; > identifier f; > @@ > > -ret = > +return > f(...); > -return ret; > --- You have missed the Signed-off-by: regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:dgap :Compression of lines for immediate return
On Sun, Jul 26, 2015 at 11:04:54PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return > statement > is found. Also,remove variable rc as it is no longer needed. > It is done using tool Coccinelle. And semantic patch used for this is as > follows: > > @@ > expression ret; > identifier f; > @@ > > -ret = > +return > f(...); > -return ret; > --- same , Signed-off-by: problem. But i just realised that you have sent the same patch 3 times. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/5] staging: lustre: Add one space after ', ' in parameters list.
On Sat, Jul 25, 2015 at 09:49:19AM +0800, Incarnation P. Lee wrote:
> From: "Pan Li"
>
> Add one space after ',' in function call parameters list.
> Signed-off-by: Pan Li
>
> ---
This has already been done by 574150f0d275 ("staging:lustre: fix "space
required after that ', '" error in cl_page.c").
I think you need to refresh your tree.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging
On Sat, Jul 18, 2015 at 09:38:57AM +0530, Sudip Mukherjee wrote: > Now since all cleanups are done and the code is ready to be merged lets > move it out of staging into fbdev location. Hi Tomi, A gentle ping regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] sm750fb: coding style fixes lines over 80 chars
On Tue, Jul 21, 2015 at 03:17:06PM +0530, Vinay Simha wrote: > Joe, > > Just want to confirm, shall i delete this code in sm750_help.h, even the > FIELD_START and FIELD_END is not required. If they are not used anywhere feel free to send a patch to delete them. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8192u: Fix checkpatch issue with comma in r819xU_firmware.c
Add space after ',' to fix the error message provided by checkpatch.pl:
ERROR: space required after that ','
Signed-off-by: Freeman Zhang
---
drivers/staging/rtl8192u/r819xU_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index 742725e..a7d3033 100644
--- a/drivers/staging/rtl8192u/r819xU_firmware.c
+++ b/drivers/staging/rtl8192u/r819xU_firmware.c
@@ -91,7 +91,7 @@ static bool fw_download_code(struct net_device *dev, u8
*code_virtual_address,
if (!priv->ieee80211->check_nic_enough_desc(dev, index) ||
(!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) ||
(priv->ieee80211->queue_stop)) {
-
RT_TRACE(COMP_FIRMWARE,"=>
tx full!\n");
+ RT_TRACE(COMP_FIRMWARE,
"=> tx full!\n");
skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb);
} else {
priv->ieee80211->softmac_hard_start_xmit(skb, dev);
@@ -242,7 +242,7 @@ bool init_firmware(struct net_device *dev)
* or read image file from array. Default load from IMG file
*/
if (rst_opt == OPT_SYSTEM_RESET) {
- rc = request_firmware(&fw_entry,
fw_name[init_step],&priv->udev->dev);
+ rc = request_firmware(&fw_entry, fw_name[init_step],
&priv->udev->dev);
if (rc < 0) {
RT_TRACE(COMP_ERR, "request firmware fail!\n");
goto download_firmware_fail;
@@ -254,12 +254,12 @@ bool init_firmware(struct net_device *dev)
}
if (init_step != FW_INIT_STEP1_MAIN) {
-
memcpy(pfirmware->firmware_buf,fw_entry->data,fw_entry->size);
+ memcpy(pfirmware->firmware_buf, fw_entry->data,
fw_entry->size);
mapped_file = pfirmware->firmware_buf;
file_length = fw_entry->size;
} else {
memset(pfirmware->firmware_buf, 0, 128);
-
memcpy(&pfirmware->firmware_buf[128],fw_entry->data,fw_entry->size);
+ memcpy(&pfirmware->firmware_buf[128],
fw_entry->data, fw_entry->size);
mapped_file = pfirmware->firmware_buf;
file_length = fw_entry->size + 128;
}
@@ -319,7 +319,7 @@ bool init_firmware(struct net_device *dev)
rt_status = CPUcheck_firmware_ready(dev);
if (!rt_status) {
- RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready
fail(%d)!\n",rt_status);
+ RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready
fail(%d)!\n", rt_status);
goto download_firmware_fail;
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
