Re: [PATCH] Staging: dgnc: dgnc_cls.h: fixed four coding style warnings
On Sat, Jan 24, 2015 at 10:49:08AM +0530, Sakshi Bansal wrote:
> Fixed 80 line warning in the code comments.
>
> Signed-off-by: Sakshi Bansal
> ---
> drivers/staging/dgnc/dgnc_cls.h | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
> index 465d79a..7444b00 100644
> --- a/drivers/staging/dgnc/dgnc_cls.h
> +++ b/drivers/staging/dgnc/dgnc_cls.h
> @@ -38,7 +38,8 @@
> struct cls_uart_struct {
> u8 txrx;/* WR RHR/THR - Holding Reg */
> u8 ier; /* WR IER - Interrupt Enable Reg */
> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo
> Control Reg */
> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo
> +Control Reg */
These aren't correct kernel style. To be honest the original looks fine
with me. (No one cares about checkpatch except if it makes the code
better for human beings).
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: dgnc: dgnc_driver.c: fixed twelve coding style warnings
The "twelve" in the subject is not important and sort of misleading. Run your patches through checkpatch.pl --strict please. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8192u: r8192U_core: Fix compile issue when CONFIG_WIRELESS_EXT is not defined
This patch gets rid of the following error when compiling r8192U_core.c and CONFIG_WIRELESS_EXT is not defined: drivers/staging/rtl8192u/r8192U_core.c: In function ‘rtl8192_usb_probe’: drivers/staging/rtl8192u/r8192U_core.c:4697:5: error: ‘struct net_device’ has no member named ‘wireless_handlers’ dev->wireless_handlers = (struct iw_handler_def *) &r8192_wx_handlers_def; ^ Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/rtl8192u/r8192U_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index e031a25..396a11f 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -4694,7 +4694,9 @@ static int rtl8192_usb_probe(struct usb_interface *intf, dev->netdev_ops = &rtl8192_netdev_ops; +#ifdef CONFIG_WIRELESS_EXT dev->wireless_handlers = (struct iw_handler_def *) &r8192_wx_handlers_def; +#endif dev->type = ARPHRD_ETHER; -- 2.1.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... netdev_info was used since it is a network subsystem Signed-off-by: Heba Aamer --- drivers/staging/rtl8712/usb_intf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c index 7d0d171..7748a75 100644 --- a/drivers/staging/rtl8712/usb_intf.c +++ b/drivers/staging/rtl8712/usb_intf.c @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf, struct net_device *pnetdev; struct usb_device *udev; - printk(KERN_INFO "r8712u: Staging version\n"); + netdev_info(pnetdev, "r8712u: Staging version\n"); /* In this probe function, O.S. will provide the usb interface pointer * to driver. We have to increase the reference count of the usb device * structure by using the usb_get_dev function. -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
