[patch v4] Documentation/email-clients.txt: add a section about git

2014-05-15 Thread Dan Carpenter 
These days most people use git to send patches so I have added a section
about that.

Signed-off-by: Dan Carpenter 
---
v2: fix typo in commit message
v3: update git am and log commands.  Mention the man pages.
v4: s/list/appropriate mailing list(s)/

diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
index 4e30eba..9293477 100644
--- a/Documentation/email-clients.txt
+++ b/Documentation/email-clients.txt
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ==
 
+Git
+--
+These days most developers use `git send-email` instead of regular
+email clients.  The man page for this is quite good.  On the receiving
+end, maintainers use `git am` to apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `git am raw_email.txt` and
+then review the changelog with `git log`.  When that works then send
+the patch to the appropriate mailing list(s).
+
 General Preferences
 --
 Patches for the Linux kernel are submitted via email, preferably as
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: socklnd: Remove unnecessary line continuation

2014-05-15 Thread Masaru Nomura 
Remove unnecessary line continuation '\' in socklnd.c to meet
kernel coding style.

Signed-off-by: Masaru Nomura 
---
 .../staging/lustre/lnet/klnds/socklnd/socklnd.c|   19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c 
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
index 21d36ee..a82ac03 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
@@ -650,8 +650,7 @@ ksocknal_get_conn_by_idx (lnet_ni_t *ni, int index)
conn = list_entry (ctmp, ksock_conn_t,
   ksnc_list);
ksocknal_conn_addref(conn);
-   read_unlock(&ksocknal_data. \
-ksnd_global_lock);
+   read_unlock(&ksocknal_data.ksnd_global_lock);
return (conn);
}
}
@@ -2299,12 +2298,12 @@ ksocknal_base_shutdown(void)
for (j = 0; j < info->ksi_nthreads_max; j++) {
 
sched = &info->ksi_scheds[j];
-   LASSERT(list_empty(&sched->\
-  kss_tx_conns));
-   LASSERT(list_empty(&sched->\
-  kss_rx_conns));
-   LASSERT(list_empty(&sched-> \
- kss_zombie_noop_txs));
+   LASSERT(list_empty(
+   &sched->kss_tx_conns));
+   LASSERT(list_empty(
+   &sched->kss_rx_conns));
+   LASSERT(list_empty(
+   &sched->kss_zombie_noop_txs));
LASSERT(sched->kss_nconns == 0);
}
}
@@ -2683,8 +2682,8 @@ ksocknal_search_new_ipif(ksock_net_t *net)
list_for_each_entry(tmp, &ksocknal_data.ksnd_nets,
ksnn_list) {
for (j = 0; !found && j < tmp->ksnn_ninterfaces; j++) {
-   char *ifnam2 = &tmp->ksnn_interfaces[j].\
-ksni_name[0];
+   char *ifnam2 =
+   &tmp->ksnn_interfaces[j].ksni_name[0];
char *colon2 = strchr(ifnam2, ':');
 
if (colon2 != NULL)
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: socklnd: Remove unnecessary return brackets

2014-05-15 Thread Masaru Nomura 
Remove unnecessary brackets from return statements in socklnd.c,
socklnd.h, socklnd_cb.c and socklnd_lib-linux.c to meet
kernel coding style.

Signed-off-by: Masaru Nomura 
---
 .../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd.h|4 +-
 .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c |   82 ++--
 .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c  |   26 +++
 4 files changed, 59 insertions(+), 59 deletions(-)

diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c 
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
index a391d13..1fb1f8e 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
@@ -459,7 +459,7 @@ ksocknal_add_peer (lnet_ni_t *ni, lnet_process_id_t id, 
__u32 ipaddr, int port)
 
if (id.nid == LNET_NID_ANY ||
id.pid == LNET_PID_ANY)
-   return (-EINVAL);
+   return -EINVAL;
 
/* Have a brand new peer ready... */
rc = ksocknal_create_peer(&peer, ni, id);
@@ -469,7 +469,7 @@ ksocknal_add_peer (lnet_ni_t *ni, lnet_process_id_t id, 
__u32 ipaddr, int port)
route = ksocknal_create_route (ipaddr, port);
if (route == NULL) {
ksocknal_peer_decref(peer);
-   return (-ENOMEM);
+   return -ENOMEM;
}
 
write_lock_bh(&ksocknal_data.ksnd_global_lock);
@@ -1951,7 +1951,7 @@ ksocknal_add_interface(lnet_ni_t *ni, __u32 ipaddress, 
__u32 netmask)
 
if (ipaddress == 0 ||
netmask == 0)
-   return (-EINVAL);
+   return -EINVAL;
 
write_lock_bh(&ksocknal_data.ksnd_global_lock);
 
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h 
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
index df2be7a..109a239 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
@@ -418,7 +418,7 @@ ksocknal_nid2peerlist (lnet_nid_t nid)
 {
unsigned int hash = ((unsigned int)nid) % 
ksocknal_data.ksnd_peer_hash_size;
 
-   return (&ksocknal_data.ksnd_peers [hash]);
+   return &ksocknal_data.ksnd_peers[hash];
 }
 
 static inline void
@@ -452,7 +452,7 @@ ksocknal_connsock_addref (ksock_conn_t *conn)
}
read_unlock(&ksocknal_data.ksnd_global_lock);
 
-   return (rc);
+   return rc;
 }
 
 static inline void
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c 
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
index bdf95ea..75bd658 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
@@ -120,7 +120,7 @@ ksocknal_send_iov (ksock_conn_t *conn, ksock_tx_t *tx)
rc = ksocknal_lib_send_iov(conn, tx);
 
if (rc <= 0)/* sent nothing? */
-   return (rc);
+   return rc;
 
nob = rc;
LASSERT (nob <= tx->tx_resid);
@@ -133,7 +133,7 @@ ksocknal_send_iov (ksock_conn_t *conn, ksock_tx_t *tx)
if (nob < (int) iov->iov_len) {
iov->iov_base = (void *)((char *)iov->iov_base + nob);
iov->iov_len -= nob;
-   return (rc);
+   return rc;
}
 
nob -= iov->iov_len;
@@ -141,7 +141,7 @@ ksocknal_send_iov (ksock_conn_t *conn, ksock_tx_t *tx)
tx->tx_niov--;
} while (nob != 0);
 
-   return (rc);
+   return rc;
 }
 
 int
@@ -158,7 +158,7 @@ ksocknal_send_kiov (ksock_conn_t *conn, ksock_tx_t *tx)
rc = ksocknal_lib_send_kiov(conn, tx);
 
if (rc <= 0)/* sent nothing? */
-   return (rc);
+   return rc;
 
nob = rc;
LASSERT (nob <= tx->tx_resid);
@@ -179,7 +179,7 @@ ksocknal_send_kiov (ksock_conn_t *conn, ksock_tx_t *tx)
tx->tx_nkiov--;
} while (nob != 0);
 
-   return (rc);
+   return rc;
 }
 
 int
@@ -198,7 +198,7 @@ ksocknal_transmit (ksock_conn_t *conn, ksock_tx_t *tx)
rc = ksocknal_connsock_addref(conn);
if (rc != 0) {
LASSERT (conn->ksnc_closing);
-   return (-ESHUTDOWN);
+   return -ESHUTDOWN;
}
 
do {
@@ -245,7 +245,7 @@ ksocknal_transmit (ksock_conn_t *conn, ksock_tx_t *tx)
} while (tx->tx_resid != 0);
 
ksocknal_connsock_decref(conn);
-   return (rc);
+   return rc;
 }
 
 int
@@ -262,7 +262,7 @@ ksocknal_recv_iov (ksock_conn_t *conn)
rc = ksocknal_lib_recv_iov(conn);
 
if (rc <= 0)
-   return (rc);
+   return rc;
 
/* received something... */
nob = rc;
@@ -282,7 +282,7 @@ ksocknal_recv_iov (ksock_conn_t *conn)
if (nob < (int)iov->iov_len) {
iov->iov_len -= nob;

Re: [PATCH] Staging:dgnc:dgnc_driver open/close braces

2014-05-15 Thread Greg KH 
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote:
> ERROR: that open brace { should be on the previous line
> ERROR: else should follow close brace '}
> ERROR: space required before the open parenthesis '(
> ERROR: trailing whitespace
> ERROR: open brace '{' following function declarations go on the next line
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> 
> Signed-off-by: Paul McQuade 
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 22 ++
>  1 file changed, 10 insertions(+), 12 deletions(-)

There is something really odd in this patch that git refuses to apply
it.  Can you please refresh it and send it again, after verifying that
it will apply properly on your side?

The error I get is:

Applying: Staging:dgnc:dgnc_driver open/close braces
fatal: patch fragment without header at line 77: @@ -895,7 +893,7 @@ int 
dgnc_ms_sleep(ulong ms)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: dgnc: Fix smatch warning for redundant null check in dgnc_driver.c

2014-05-15 Thread Greg KH 
On Wed, May 07, 2014 at 02:41:48PM +0300, Ebru Akagunduz wrote:
> Fix smatch warning "dgnc_cleanup_board() info:
> redundant null check on brd->flipbuf calling kfree()"
> in dgnc_driver.c
> 
> Signed-off-by: Ebru Akagunduz 
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c 
> b/drivers/staging/dgnc/dgnc_driver.c
> index b1a39b2..e579ba3 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -463,8 +463,7 @@ static void dgnc_cleanup_board(struct dgnc_board *brd)
>   }
>   }
>  
> - if (brd->flipbuf)
> - kfree(brd->flipbuf);
> + kfree(brd->flipbuf);
>  
>   dgnc_Board[brd->boardnum] = NULL;
>  

Sorry, someone else sent this same patch before you did :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Konrad Zapalowicz 
This commit fixes the following sparse warning:

drivers/staging/rtl8723au/os_dep/os_intfs.c:
- 322:14: warning: restricted __be16 degrades to integer

Signed-off-by: Konrad Zapalowicz 
---
 drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c 
b/drivers/staging/rtl8723au/os_dep/os_intfs.c
index 57eca7a..31a70af 100644
--- a/drivers/staging/rtl8723au/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723au/os_dep/os_intfs.c
@@ -319,7 +319,7 @@ u16 rtw_recv_select_queue23a(struct sk_buff *skb)
 
memcpy(ð_type, pdata + (ETH_ALEN << 1), 2);
switch (eth_type) {
-   case htons(ETH_P_IP):
+   case be16_to_cpu(htons(ETH_P_IP)):
piphdr = (struct iphdr *)(pdata + ETH_HLEN);
dscp = piphdr->tos & 0xfc;
priority = dscp >> 5;
-- 
1.8.1.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c

2014-05-15 Thread Greg KH 
On Wed, May 14, 2014 at 10:12:46AM +0200, Tobias Klauser wrote:
> On 2014-05-13 at 16:43:57 +0200, Masanari Iida  wrote:
> > This patch replaced printk with pr_info.
> 
> It would be even better to use dev_err(), since these are error messages
> and you can use the struct dev from link->dev. You can also drop the
> "ft1000:" prefix then.

I agree, that's the better fix here.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Dan Carpenter 
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote:
> This commit fixes the following sparse warning:
> 
> drivers/staging/rtl8723au/os_dep/os_intfs.c:
> - 322:14: warning: restricted __be16 degrades to integer
> 
> Signed-off-by: Konrad Zapalowicz 
> ---
>  drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c 
> b/drivers/staging/rtl8723au/os_dep/os_intfs.c
> index 57eca7a..31a70af 100644
> --- a/drivers/staging/rtl8723au/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723au/os_dep/os_intfs.c
> @@ -319,7 +319,7 @@ u16 rtw_recv_select_queue23a(struct sk_buff *skb)
>  
>   memcpy(ð_type, pdata + (ETH_ALEN << 1), 2);
>   switch (eth_type) {
> - case htons(ETH_P_IP):
> + case be16_to_cpu(htons(ETH_P_IP)):

You should be more careful.  This would have just made the code buggy.

Anyway someone already cleaned up this code.  You should be working
against linux-next.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch v4] Documentation/email-clients.txt: add a section about git

2014-05-15 Thread Randy Dunlap 
On 05/15/2014 02:33 AM, Dan Carpenter wrote:
> These days most people use git to send patches so I have added a section
> about that.
> 
> Signed-off-by: Dan Carpenter 

Applied.  Thanks.

> ---
> v2: fix typo in commit message
> v3: update git am and log commands.  Mention the man pages.
> v4: s/list/appropriate mailing list(s)/
> 
> diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
> index 4e30eba..9293477 100644
> --- a/Documentation/email-clients.txt
> +++ b/Documentation/email-clients.txt
> @@ -1,6 +1,17 @@
>  Email clients info for Linux
>  ==
>  
> +Git
> +--
> +These days most developers use `git send-email` instead of regular
> +email clients.  The man page for this is quite good.  On the receiving
> +end, maintainers use `git am` to apply the patches.
> +
> +If you are new to git then send your first patch to yourself.  Save it
> +as raw text including all the headers.  Run `git am raw_email.txt` and
> +then review the changelog with `git log`.  When that works then send
> +the patch to the appropriate mailing list(s).
> +
>  General Preferences
>  --
>  Patches for the Linux kernel are submitted via email, preferably as
> ___


-- 
~Randy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: use pr_err() instead of KERN_ERR

2014-05-15 Thread Greg Kroah-Hartman 
On Sun, Apr 13, 2014 at 09:22:16PM +1000, Vitaly Osipov wrote:
> All files in drivers/staging/wlan-ng updated to use pr_err
> 
> Signed-off-by: Vitaly Osipov 
> ---
>  drivers/staging/wlan-ng/p80211conv.c   |   24 +--
>  drivers/staging/wlan-ng/p80211netdev.c |7 ++-
>  drivers/staging/wlan-ng/p80211req.c|3 +-
>  drivers/staging/wlan-ng/prism2fw.c |   65 +++-
>  drivers/staging/wlan-ng/prism2mgmt.c   |   74 
> +---
>  drivers/staging/wlan-ng/prism2mib.c|2 +-
>  6 files changed, 70 insertions(+), 105 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211conv.c 
> b/drivers/staging/wlan-ng/p80211conv.c
> index 3df753b..7e6c7b6 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -195,8 +195,7 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 
> ethconv,
>   memcpy(p80211_hdr->a3.a3, &e_hdr.saddr, ETH_ALEN);
>   break;
>   default:
> - printk(KERN_ERR
> -"Error: Converting eth to wlan in unknown mode.\n");
> + pr_err("Error: Converting eth to wlan in unknown mode.\n");

This is a network driver, why can't it use netdev_err()?  Or at the
least dev_err()?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: Fix sparse warnings

2014-05-15 Thread Greg KH 
On Sun, Apr 13, 2014 at 10:09:49PM +0530, c...@slynux.com wrote:
> From: Sarath Lakshman 

This doesn't match your From: line, why?

> 
> Fixed missed declarations for few non-static functions.
> 
> Signed-off-by: Sarath Lakshman 
> ---
>  drivers/staging/wlan-ng/cfg80211.c   | 1 +
>  drivers/staging/wlan-ng/prism2mgmt.h | 6 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c 
> b/drivers/staging/wlan-ng/cfg80211.c
> index f76f95c..662581c 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -1,4 +1,5 @@
>  /* cfg80211 Interface for prism2_usb module */
> +#include "prism2mgmt.h"
>  
>  
>  /* Prism2 channel/frequency/bitrate declarations */
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h 
> b/drivers/staging/wlan-ng/prism2mgmt.h
> index 190d390..ad049ad 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -60,6 +60,8 @@
>  #ifndef _PRISM2MGMT_H
>  #define _PRISM2MGMT_H
>  
> +#include "hfa384x.h"
> +
>  extern int prism2_reset_holdtime;
>  extern int prism2_reset_settletime;
>  
> @@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data);
>  void prism2sta_commsqual_defer(struct work_struct *data);
>  void prism2sta_commsqual_timer(unsigned long data);
>  
> +void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> +void prism2_disconnected(wlandevice_t *wlandev);
> +void prism2_roamed(wlandevice_t *wlandev);

What about the existing declarations of these functions?  Shouldn't they
be removed?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()

2014-05-15 Thread Greg KH 
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> Fix some coding style issues concerning printk() usage.
> 
> Signed-off-by: Denis Pithon 
> ---
>  drivers/staging/wlan-ng/p80211netdev.c | 17 +
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c 
> b/drivers/staging/wlan-ng/p80211netdev.c
> index 61a3092..3577d20 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -384,8 +384,9 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff 
> *skb,
>*/
>   if (skb->protocol != ETH_P_80211_RAW) {
>   netif_start_queue(wlandev->netdev);
> - printk(KERN_NOTICE
> -"Tx attempt prior to association, frame 
> dropped.\n");
> + pr_notice(
> +"Tx attempt prior to association, frame dropped\n"
> + );

Can't these be netdev messages, or at the least, dev_* messages?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Fix for possible null pointer dereference in node.c

2014-05-15 Thread Rickard Strandqvist 
There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
---
 drivers/staging/tidspbridge/rmgr/node.c |4 ++--
 1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)

diff --git a/drivers/staging/tidspbridge/rmgr/node.c 
b/drivers/staging/tidspbridge/rmgr/node.c
index 9d3044a..94c2cce 100644
--- a/drivers/staging/tidspbridge/rmgr/node.c
+++ b/drivers/staging/tidspbridge/rmgr/node.c
@@ -2361,8 +2361,7 @@ static void delete_node(struct node_object *hnode,
struct node_taskargs task_arg_obj;
 #ifdef DSP_DMM_DEBUG
struct dmm_object *dmm_mgr;
-   struct proc_object *p_proc_object =
-   (struct proc_object *)hnode->processor;
+   struct proc_object *p_proc_object;
 #endif
int status;
if (!hnode)
@@ -2431,6 +2430,7 @@ static void delete_node(struct node_object *hnode,
dsp_heap_res_addr,
pr_ctxt);
 #ifdef DSP_DMM_DEBUG
+   p_proc_object = (struct proc_object *)hnode->processor;
status = dmm_get_handle(p_proc_object, &dmm_mgr);
if (dmm_mgr)
dmm_mem_map_dump(dmm_mgr);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sep: fix coding style issue

2014-05-15 Thread Greg KH 
On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
> This is a patch to fix coding style issue found by
> scripts/checkpatch.pl utility.
> 
> Signed-off-by: Clément Calmels 
> ---
>  drivers/staging/sep/sep_dev.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
> index 5f6a07f..5faeefa1 100644
> --- a/drivers/staging/sep/sep_dev.h
> +++ b/drivers/staging/sep/sep_dev.h
> @@ -139,12 +139,14 @@ struct sep_queue_info {
>  static inline void sep_write_reg(struct sep_device *dev, int reg, u32 value)
>  {
>   void __iomem *addr = dev->reg_addr + reg;
> +
>   writel(value, addr);
>  }
>  
>  static inline u32 sep_read_reg(struct sep_device *dev, int reg)
>  {
>   void __iomem *addr = dev->reg_addr + reg;
> +
>   return readl(addr);
>  }
>  
> @@ -152,6 +154,7 @@ static inline u32 sep_read_reg(struct sep_device *dev, 
> int reg)
>  static inline void sep_wait_sram_write(struct sep_device *dev)
>  {
>   u32 reg_val;
> +
>   do {
>   reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
>   } while (!(reg_val & 1));

Someone else already sent in this same patch, sorry.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Fix for possible null pointer dereference in node.c

2014-05-15 Thread Greg Kroah-Hartman 
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
> 
> Was largely found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist 
> ---
>  drivers/staging/tidspbridge/rmgr/node.c |4 ++--
>  1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)

Please work a bit on your Subject lines to make it easier to figure out
where the patches belong.

For this one, it should be:
Subject: staging: tidspridge: fix for possible null pointer dereference 
in node.c
or:
Subject: staging: tidspridge: node.c: fix for possible null pointer 
dereference

That way people can figure out _what_ node.c file you are referring to
and to see if they care about it or not :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Fix for possible null pointer dereference in node.c

2014-05-15 Thread Rickard Strandqvist 
Hi all, and Greg!

Good idea!
I will do it in all the other mail.


Best regards
Rickard Strandqvist


2014-05-16 0:08 GMT+02:00 Greg Kroah-Hartman :
> On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist 
>> ---
>>  drivers/staging/tidspbridge/rmgr/node.c |4 ++--
>>  1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)
>
> Please work a bit on your Subject lines to make it easier to figure out
> where the patches belong.
>
> For this one, it should be:
> Subject: staging: tidspridge: fix for possible null pointer 
> dereference in node.c
> or:
> Subject: staging: tidspridge: node.c: fix for possible null pointer 
> dereference
>
> That way people can figure out _what_ node.c file you are referring to
> and to see if they care about it or not :)
>
> thanks,
>
> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

staging: dgap/dgnc maintainers list

2014-05-15 Thread Christian Engelmayer 
Hi,

As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
to add Mark to the maintainers list for dgap, while the patch addresses the
dgnc entry. Was that the intention?

https://lkml.org/lkml/2014/4/25/275

Regards,
Christian

---

commit 542f3d5af89c15d0b4e80bbf927d252efa0e48c3
Author: Mark Hounschell 
Date:   Fri Apr 25 14:32:15 2014 -0400

staging: dgap: Add Mark Hounschell to maintainers list for dgap

Add Mark Hounschell to the MAINTAINERs list for the dgap driver

Signed-off-by: Mark Hounschell 
Suggested-by: Dan Carpenter 
Cc: Greg Kroah-Hartman 
Signed-off-by: Greg Kroah-Hartman 

diff --git a/MAINTAINERS b/MAINTAINERS
index da68679..610c982 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2789,6 +2789,7 @@ F:sound/soc/codecs/da[79]*.[ch]
 
 DIGI NEO AND CLASSIC PCI PRODUCTS
 M: Lidza Louina 
+M: Mark Hounschell 
 L: driverdev-devel@linuxdriverproject.org
 S: Maintained
 F: drivers/staging/dgnc/
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Fix for possible null pointer dereference in node.c

2014-05-15 Thread Dan Carpenter 
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
> 

None of the callers pass in a NULL hnode so there isn't actually a NULL
dereference here.  You could just remove the check.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: staging: dgap/dgnc maintainers list

2014-05-15 Thread Dan Carpenter 
On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
> Hi,
> 
> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
> to add Mark to the maintainers list for dgap, while the patch addresses the
> dgnc entry. Was that the intention?

No, it wasn't at all.  Mark, please send a patch which moves you to the
correct MAINTAINERS section.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH/V2] staging: ft1000: Convert printk to dev_err in ft1000_cs.c

2014-05-15 Thread Masanari Iida 
This patch converts printk to dev_err in ft1000_cs.c

Signed-off-by: Masanari Iida 
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c 
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
index f376ca4..1f8b3ca 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
@@ -95,20 +95,20 @@ static int ft1000_config(struct pcmcia_device *link)
/* setup IO window */
ret = pcmcia_loop_config(link, ft1000_confcheck, NULL);
if (ret) {
-   printk(KERN_INFO "ft1000: Could not configure pcmcia\n");
+   dev_err(&link->dev, "Could not configure pcmcia\n");
return -ENODEV;
}
 
/* configure device */
ret = pcmcia_enable_device(link);
if (ret) {
-   printk(KERN_INFO "ft1000: could not enable pcmcia\n");
+   dev_err(&link->dev, "Could not enable pcmcia\n");
goto failed;
}
 
link->priv = init_ft1000_card(link, &ft1000_reset);
if (!link->priv) {
-   printk(KERN_INFO "ft1000: Could not register as network 
device\n");
+   dev_err(&link->dev, "Could not register as network device\n");
goto failed;
}
 
-- 
2.0.0.rc3.2.g998f840

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel