[PATCH] ion: remove duplicated clearing of sg_table initialization

2014-04-22 Thread Gioh Kim 
Hi,

I found a duplicated zeroing at sg_table initialization in ION of linux-
3.15.0-rc2 version.
Here is my patch.

Subject: [PATCH] ion: remove duplicated clearing of sg_table initialization

Because sg_table is cleared in sg_alloc_table via memset
we don't need to use kzalloc to allocate sg_table.

Signed-off-by: Gioh Kim 
---
 drivers/staging/android/ion/ion_carveout_heap.c |2 +-
 drivers/staging/android/ion/ion_chunk_heap.c|2 +-
 drivers/staging/android/ion/ion_system_heap.c   |4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
b/drivers/staging/android/ion/ion_carveout_heap.c
index 3cb05b9..dcb6f21 100644
--- a/drivers/staging/android/ion/ion_carveout_heap.c
+++ b/drivers/staging/android/ion/ion_carveout_heap.c
@@ -81,7 +81,7 @@ static int ion_carveout_heap_allocate(struct ion_heap
*heap,
if (align > PAGE_SIZE)
return -EINVAL;

-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
return -ENOMEM;
ret = sg_alloc_table(table, 1, GFP_KERNEL);
diff --git a/drivers/staging/android/ion/ion_chunk_heap.c
b/drivers/staging/android/ion/ion_chunk_heap.c
index d40f5f8..3f2c12b 100644
--- a/drivers/staging/android/ion/ion_chunk_heap.c
+++ b/drivers/staging/android/ion/ion_chunk_heap.c
@@ -55,7 +55,7 @@ static int ion_chunk_heap_allocate(struct ion_heap *heap,
if (allocated_size > chunk_heap->size - chunk_heap->allocated)
return -ENOMEM;

-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
return -ENOMEM;
ret = sg_alloc_table(table, num_chunks, GFP_KERNEL);
diff --git a/drivers/staging/android/ion/ion_system_heap.c
b/drivers/staging/android/ion/ion_system_heap.c
index c923633..0663a7f 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -166,7 +166,7 @@ static int ion_system_heap_allocate(struct ion_heap
*heap,
max_order = info->order;
i++;
}
-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
goto err;

@@ -356,7 +356,7 @@ static int ion_system_contig_heap_allocate(struct
ion_heap *heap,
for (i = len >> PAGE_SHIFT; i < (1 << order); i++)
__free_page(page + i);

-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table) {
ret = -ENOMEM;
goto out;
--
1.7.9.5



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl definition

2014-04-22 Thread Dan Carpenter 
I like the idea of this patch but the v2 version still doesn't compile.
I don't understand how you can write such a nice patch and not even test
that it compiles.  Twice.  That's not ok.

On Sun, Apr 20, 2014 at 06:05:38PM +, Son P. Nguyen wrote:
> From: "Son P. Nguyen" 

Don't include this when you are sending your own patch.

> 
> Fixed dgnc_pci_tbl definition for correct coding style

This description is not enough.

> 
> PS: This is for task 10 of eudyptula-challenge.

Don't include this line.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging/android: Remove ram_console.h

2014-04-22 Thread Bintian Wang 
ram_console is replaced by pstore and pstore_ram drivers,
and there is no code to use this head file, so remove it.

Signed-off-by: Bintian Wang 
---
 drivers/staging/android/ram_console.h |   22 --
 1 file changed, 22 deletions(-)
 delete mode 100644 drivers/staging/android/ram_console.h

diff --git a/drivers/staging/android/ram_console.h 
b/drivers/staging/android/ram_console.h
deleted file mode 100644
index 9f1125c..000
--- a/drivers/staging/android/ram_console.h
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * Copyright (C) 2010 Google, Inc.
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- */
-
-#ifndef _INCLUDE_LINUX_PLATFORM_DATA_RAM_CONSOLE_H_
-#define _INCLUDE_LINUX_PLATFORM_DATA_RAM_CONSOLE_H_
-
-struct ram_console_platform_data {
-   const char *bootinfo;
-};
-
-#endif /* _INCLUDE_LINUX_PLATFORM_DATA_RAM_CONSOLE_H_ */
-- 
1.7.9.5


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 2/3] staging: gdm72xx: Minor cleanup

2014-04-22 Thread Dan Carpenter 
On Sun, Apr 20, 2014 at 11:36:54AM +0800, Michalis Pappas wrote:
> 
> Removed line related to replacement of kernel_thread with kthread,
> as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8.
> 

In the future, the way to specify a commit is:
ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function
kernel_thread')

It's hard to remember which git hash goes with which commit.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 3/3] staging: gdm72xx: Minor cleanup

2014-04-22 Thread Dan Carpenter 
These patches are all good but the subjects for all three are the same
and quite bad.  Please fix this and resend.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/26] staging: comedi: round 2 of async command support cleanup

2014-04-22 Thread Ian Abbott 

On 2014-04-17 18:07, H Hartley Sweeten wrote:

This series continues the cleanup of the comedi async command support.

H Hartley Sweeten (26):
   staging: comedi: drivers: core validates chanlist_len max
   staging: comedi: drivers: properly validate cmd->scan_end_arg
   staging: comedi: addi_apci_3xxx: fix ai subdevice 'len_chanlist'
   staging: comedi: adl_pci9111: rename local var in pci9111_ai_do_cmd_test()
   staging: comedi: comedi_test: ao subdevice does not support async commands
   staging: comedi: hwdrv_apci3200: properly validata the ai cmd->start_arg
   staging: comedi: adl_pci9118: fix the ai cmd->start_arg validation and use
   staging: comedi: amplc_dio200_common: fix the cmd->start_arg use
   staging: comedi: amplc_pci224: fix the ao cmd->start_arg use
   staging: comedi: amplc_pci230: fix the ai/ao cmd->start_arg use for TRIG_INT
   staging: comedi: cb_pcidas: clarify the ai cmd->start_arg validation
   staging: comedi: cb_pcidas: fix the ao cmd->start_arg use for TRIG_INT
   staging: comedi: cb_pcidas64: validate the ai/ao cmd->start_arg
   staging: comedi: dt282x: fix the ao cmd->start_arg use for TRIG_INT
   staging: comedi: gsc_hpdi: validate the cmd->start_arg
   staging: comedi: me4000: validate the cmd->start_arg
   staging: comedi: ni_pcidio: fix the cmd->start_arg use for TRIG_INT
   staging: comedi: ni_tiocmd: clarify the cmd->start_arg validation and use
   staging: comedi: ni_labpc: clarify the cmd->start_arg validation
   staging: comedi: pcmmio: fix the cmd->start_arg use for TRIG_INT
   staging: comedi: pcmuio: fix the cmd->start_arg use for TRIG_INT
   staging: comedi: s626: clarify the cmd->start_arg validation and use
   staging: comedi: usbduxsigma: fix the ai/ao cmd->start_arg use for TRIG_INT
   staging: comedi: usbduxfast: fix the cmd->start_arg validation and use
   staging: comedi: usbdux: fix the cmd->start_arg use
   staging: comedi: ni_mio_common: clarify the cmd->start_arg validation and use

  drivers/staging/comedi/drivers/8255.c  |  3 +-
  .../comedi/drivers/addi-data/hwdrv_apci3120.c  |  4 +-
  .../comedi/drivers/addi-data/hwdrv_apci3200.c  | 43 -
  drivers/staging/comedi/drivers/addi_apci_1032.c|  3 +-
  drivers/staging/comedi/drivers/addi_apci_3xxx.c| 40 ++--
  drivers/staging/comedi/drivers/adl_pci9111.c   | 57 -
  drivers/staging/comedi/drivers/adl_pci9118.c   | 19 --
  .../staging/comedi/drivers/amplc_dio200_common.c   | 27 +++-
  drivers/staging/comedi/drivers/amplc_pc236.c   |  3 +-
  drivers/staging/comedi/drivers/amplc_pci224.c  | 31 -
  drivers/staging/comedi/drivers/amplc_pci230.c  | 14 ++--
  drivers/staging/comedi/drivers/cb_pcidas.c | 10 +--
  drivers/staging/comedi/drivers/cb_pcidas64.c   | 16 -
  drivers/staging/comedi/drivers/comedi_parport.c|  3 +-
  drivers/staging/comedi/drivers/comedi_test.c   |  4 --
  drivers/staging/comedi/drivers/dt282x.c|  8 ++-
  drivers/staging/comedi/drivers/gsc_hpdi.c  |  2 +
  drivers/staging/comedi/drivers/me4000.c|  2 +
  drivers/staging/comedi/drivers/ni_6527.c   |  3 +-
  drivers/staging/comedi/drivers/ni_65xx.c   |  3 +-
  drivers/staging/comedi/drivers/ni_labpc.c  |  8 ++-
  drivers/staging/comedi/drivers/ni_mio_common.c | 74 --
  drivers/staging/comedi/drivers/ni_pcidio.c |  6 +-
  drivers/staging/comedi/drivers/ni_tiocmd.c | 18 --
  drivers/staging/comedi/drivers/pcl726.c|  3 +-
  drivers/staging/comedi/drivers/pcl812.c|  1 -
  drivers/staging/comedi/drivers/pcmmio.c| 22 +++
  drivers/staging/comedi/drivers/pcmuio.c| 22 +++
  drivers/staging/comedi/drivers/rtd520.c|  6 +-
  drivers/staging/comedi/drivers/s626.c  | 19 --
  drivers/staging/comedi/drivers/usbdux.c| 22 ---
  drivers/staging/comedi/drivers/usbduxfast.c| 21 ++
  drivers/staging/comedi/drivers/usbduxsigma.c   | 12 ++--
  33 files changed, 283 insertions(+), 246 deletions(-)



All looks fine!

Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587 )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging:dgap:dgap_tty.c: Upgraded driver to use Mutex instead of semaphore

2014-04-22 Thread Dan Carpenter 
On Thu, Apr 17, 2014 at 09:25:32PM +0530, Kumar Gaurav wrote:
> dgap driver uses semaphore for obtaining lock. I upgraded it to use MUTEX.
> 

You are patching ancient code that doesn't exist.  Work against
linux-next.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-22 Thread Dan Carpenter 
Out of curiosity, have you tested this patch?

On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote:
> This patch fixes two sparse warnings related to lcd_write :
> warning: incorrect type in argument 1 (different address spaces)
> warning: incorrect type in initializer (incompatible argument 2 
> (different address spaces))
> 
> lcd_write can be used from kernel space (in panel_lcd_print) or from user
> space. So we introduce the lcd_write_char function that will write a char to
> the device. We modify lcd_write and panel_lcd_print to use it. Finally we add
> __user annotation missing in lcd_write.
> 
> 
> Signed-off-by: Bastien Armand 
> ---
>  drivers/staging/panel/panel.c |  205 
> ++---
>  1 file changed, 109 insertions(+), 96 deletions(-)
> 
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 1569e26..dc34254 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -1217,111 +1217,113 @@ static inline int handle_lcd_special_code(void)
>   return processed;
>  }
> 
> +static void lcd_write_char(char c)
> +{
> + /* first, we'll test if we're in escape mode */
> + if ((c != '\n') && lcd_escape_len >= 0) {
> + /* yes, let's add this char to the buffer */
> + lcd_escape[lcd_escape_len++] = c;
> + lcd_escape[lcd_escape_len] = 0;
> + } else {
> + /* aborts any previous escape sequence */
> + lcd_escape_len = -1;
> +
> + switch (c) {
> + case LCD_ESCAPE_CHAR:
> + /* start of an escape sequence */
> + lcd_escape_len = 0;
> + lcd_escape[lcd_escape_len] = 0;
> + break;
> + case '\b':
> + /* go back one char and clear it */
> + if (lcd_addr_x > 0) {
> + /* check if we're not at the
> +end of the line */
> + if (lcd_addr_x < lcd_bwidth)
> + /* back one char */
> + lcd_write_cmd(0x10);
> + lcd_addr_x--;
> + }
> + /* replace with a space */
> + lcd_write_data(' ');
> + /* back one char again */
> + lcd_write_cmd(0x10);
> + break;
> + case '\014':
> + /* quickly clear the display */
> + lcd_clear_fast();
> + break;
> + case '\n':
> + /* flush the remainder of the current line and
> +go to the beginning of the next line */
> + for (; lcd_addr_x < lcd_bwidth; lcd_addr_x++)
> + lcd_write_data(' ');
> + lcd_addr_x = 0;
> + lcd_addr_y = (lcd_addr_y + 1) % lcd_height;
> + lcd_gotoxy();
> + break;
> + case '\r':
> + /* go to the beginning of the same line */
> + lcd_addr_x = 0;
> + lcd_gotoxy();
> + break;
> + case '\t':
> + /* print a space instead of the tab */
> + lcd_print(' ');
> + break;
> + default:
> + /* simply print this char */
> + lcd_print(c);
> + break;
> + }
> + }
> +
> + /* now we'll see if we're in an escape mode and if the current
> +escape sequence can be understood. */
> + if (lcd_escape_len >= 2) {
> + int processed = 0;
> +
> + if (!strcmp(lcd_escape, "[2J")) {
> + /* clear the display */
> + lcd_clear_fast();
> + processed = 1;
> + } else if (!strcmp(lcd_escape, "[H")) {
> + /* cursor to home */
> + lcd_addr_x = lcd_addr_y = 0;
> + lcd_gotoxy();
> + processed = 1;
> + }
> + /* codes starting with ^[[L */
> + else if ((lcd_escape_len >= 3) &&
> +  (lcd_escape[0] == '[') &&
> +  (lcd_escape[1] == 'L')) {
> + processed = handle_lcd_special_code();
> + }
> +
> + /* LCD special escape codes */
> + /* flush the escape sequence if it's been processed
> +or if it is getting too long. */
> + if (processed || (lcd_escape_len >= LCD_ESCAPE_LEN))
> + lcd_escape_len = -1;
> + } /* escape codes */
> +}
> +
>  static ssize_t lcd_write(struct file *file,
> -  const char *buf, size_t count, lo

Re: [PATCH] ced1401 coding style fixes

2014-04-22 Thread Dan Carpenter 
The subject is in the wrong format.  It should be:

[PATCH 1/3] Staging: ced1401: fix long lines
[PATCH 2/3] Staging: ced1401: add blank lines after declarations
[PATCH 3/3] Staging: ced1401: remove unused typedefs

Btw, break it up into 3 patches.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread Dan Carpenter 
On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
> _ReadLEDSetting() doesn't read led settings this function actually
> initialize  member variables of struct led_priv, we should do that
> inside rtl8188eu_InitSwLeds().
> 

This seems like a bugfix or is it just a cleanup?  It's not clear to me
from the patch description.  Have you tested this patch?

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code.

2014-04-22 Thread Dan Carpenter 
Minor white space complaints.

On Sun, Apr 20, 2014 at 02:17:13PM +0530, navin patidar wrote:
> @@ -1334,7 +316,7 @@ static void SwLedControlMode4(struct adapter *padapter, 
> enum LED_CTL_MODE LedAct
>   else
>   pLed->BlinkingLedState = RTW_LED_ON;
>   _set_timer(&(pLed->BlinkTimer), 
> LED_BLINK_SCAN_INTERVAL_ALPHA);
> - }
> +  }
>   break;
>   case LED_CTL_TX:
>   case LED_CTL_RX:
> @@ -1345,6 +327,10 @@ static void SwLedControlMode4(struct adapter *padapter, 
> enum LED_CTL_MODE LedAct

A stray space character was accidentally added here.  You can fix minor
things like that in a later patch.

>   _cancel_timer_ex(&(pLed->BlinkTimer));
>   pLed->bLedNoLinkBlinkInProgress = false;
>   }
> + if (pLed->bLedLinkBlinkInProgress) {
> + _cancel_timer_ex(&(pLed->BlinkTimer));
> + pLed->bLedLinkBlinkInProgress = false;
> + }
>   pLed->bLedBlinkInProgress = true;
>   pLed->CurrLedState = LED_BLINK_TXRX;
>   pLed->BlinkTimes = 2;
> @@ -1357,22 +343,15 @@ static void SwLedControlMode4(struct adapter 
> *padapter, enum LED_CTL_MODE LedAct
>   break;
>   case LED_CTL_START_WPS: /* wait until xinpin finish */
>   case LED_CTL_START_WPS_BOTTON:
> - if (pLed1->bLedWPSBlinkInProgress) {
> - pLed1->bLedWPSBlinkInProgress = false;
> - _cancel_timer_ex(&(pLed1->BlinkTimer));
> -
> - pLed1->BlinkingLedState = RTW_LED_OFF;
> - pLed1->CurrLedState = RTW_LED_OFF;
> -
> - if (pLed1->bLedOn)
> - _set_timer(&(pLed->BlinkTimer), 0);
> - }
> -
> - if (!pLed->bLedWPSBlinkInProgress) {
> +  if (!pLed->bLedWPSBlinkInProgress) {

And another here.

>   if (pLed->bLedNoLinkBlinkInProgress) {
>   _cancel_timer_ex(&(pLed->BlinkTimer));
>   pLed->bLedNoLinkBlinkInProgress = false;
>   }
> + if (pLed->bLedLinkBlinkInProgress) {
> + _cancel_timer_ex(&(pLed->BlinkTimer));
> +  pLed->bLedLinkBlinkInProgress = false;
> + }
>   if (pLed->bLedBlinkInProgress) {
>   _cancel_timer_ex(&(pLed->BlinkTimer));
>   pLed->bLedBlinkInProgress = false;
> @@ -1383,56 +362,44 @@ static void SwLedControlMode4(struct adapter 
> *padapter, enum LED_CTL_MODE LedAct
>   }
>   pLed->bLedWPSBlinkInProgress = true;
>   pLed->CurrLedState = LED_BLINK_WPS;
> - if (pLed->bLedOn) {
> + if (pLed->bLedOn)
>   pLed->BlinkingLedState = RTW_LED_OFF;
> - _set_timer(&(pLed->BlinkTimer), 
> LED_BLINK_SLOWLY_INTERVAL);
> - } else {
> + else
>   pLed->BlinkingLedState = RTW_LED_ON;
> - _set_timer(&(pLed->BlinkTimer), 
> LED_BLINK_NORMAL_INTERVAL);
> - }
> - }
> + _set_timer(&(pLed->BlinkTimer), 
> LED_BLINK_SCAN_INTERVAL_ALPHA);
> +  }
>   break;
> - case LED_CTL_STOP_WPS:  /* WPS connect success */
> - if (pLed->bLedWPSBlinkInProgress) {
> + case LED_CTL_STOP_WPS:
> + if (pLed->bLedNoLinkBlinkInProgress) {
>   _cancel_timer_ex(&(pLed->BlinkTimer));
> - pLed->bLedWPSBlinkInProgress = false;
> + pLed->bLedNoLinkBlinkInProgress = false;
>   }
> -
> - pLed->bLedNoLinkBlinkInProgress = true;
> - pLed->CurrLedState = LED_BLINK_SLOWLY;
> - if (pLed->bLedOn)
> - pLed->BlinkingLedState = RTW_LED_OFF;
> - else
> - pLed->BlinkingLedState = RTW_LED_ON;
> - _set_timer(&(pLed->BlinkTimer), 
> LED_BLINK_NO_LINK_INTERVAL_ALPHA);
> -
> - break;
> - case LED_CTL_STOP_WPS_FAIL: /* WPS authentication fail */
> - if (pLed->bLedWPSBlinkInProgress) {
> + if (pLed->bLedLinkBlinkInProgress) {
>   _cancel_timer_ex(&(pLed->BlinkTimer));
> - pLed->bLedWPSBlinkInProgress = false;
> +  pLed->bLedLinkBlinkInProgress = false;

Another here.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-22 Thread Dan Carpenter 
It's ok to renumber all of these?  It's not something the firmware will
care about?  Have you tested this?  Same for patch 10/10.

(These questions are just questions.  I don't ask rhetorical questions
on email.  I don't know the answers).

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: android: Fix warning cast removes address space of expression

2014-04-22 Thread Dan Carpenter 
On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote:
> Fix sparse warning "cast removes address space of expression"
> Add lost flag "__user" due to cast
> 
> Signed-off-by: Camille Bordignon 

This one is the most perfect version of this patch yet.  Unfortunately
a couple other people sent it before you.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] ion: remove duplicated clearing of sg_table initialization

2014-04-22 Thread Dan Carpenter 
Patch is corrupt and doesn't apply.  Read Documentation/email-clients.txt
or use git send-email.  Send it to yourself.  Save the raw email,
including headers and everything, and `cat raw_email.txt | git am`.
Review the changelog.  When it works then resend it to the list.

On Tue, Apr 22, 2014 at 05:27:04PM +0900, Gioh Kim wrote:
> Hi,
> 
> I found a duplicated zeroing at sg_table initialization in ION of linux-
> 3.15.0-rc2 version.

Work against linux-next for this.

> Here is my patch.
> 
> Subject: [PATCH] ion: remove duplicated clearing of sg_table initialization

Add the "Staging: android: " prefix.  You will have to make the subject
shorter so it will fit.

[PATCH] Staging: android: ion:  duplicated clearing of sg_table

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: iio: Fix typo in iio

2014-04-22 Thread Masanari Iida 
Correct spelling typo in comment within staging/iio

Signed-off-by: Masanari Iida 
---
 drivers/staging/iio/adc/ad7606.h| 4 ++--
 drivers/staging/iio/adc/ad7816.c| 2 +-
 drivers/staging/iio/adc/ad799x.h| 2 +-
 drivers/staging/iio/addac/adt7316.c | 4 ++--
 drivers/staging/iio/cdc/ad7152.c| 2 +-
 drivers/staging/iio/cdc/ad7746.c| 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h
index 93c7299..ec89d05 100644
--- a/drivers/staging/iio/adc/ad7606.h
+++ b/drivers/staging/iio/adc/ad7606.h
@@ -14,7 +14,7 @@
  */
 
 /**
- * struct ad7606_platform_data - platform/board specifc information
+ * struct ad7606_platform_data - platform/board specific information
  * @default_os:default oversampling value {0, 2, 4, 8, 16, 32, 
64}
  * @default_range: default range +/-{5000, 1} mVolt
  * @gpio_convst:   number of gpio connected to the CONVST pin
@@ -41,7 +41,7 @@ struct ad7606_platform_data {
 };
 
 /**
- * struct ad7606_chip_info - chip specifc information
+ * struct ad7606_chip_info - chip specific information
  * @name:  identification string for chip
  * @int_vref_mv:   the internal reference voltage
  * @channels:  channel specification
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 2369cf2..158d770 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -40,7 +40,7 @@
 
 
 /*
- * struct ad7816_chip_info - chip specifc information
+ * struct ad7816_chip_info - chip specific information
  */
 
 struct ad7816_chip_info {
diff --git a/drivers/staging/iio/adc/ad799x.h b/drivers/staging/iio/adc/ad799x.h
index fc8c852..70ddfa2 100644
--- a/drivers/staging/iio/adc/ad799x.h
+++ b/drivers/staging/iio/adc/ad799x.h
@@ -76,7 +76,7 @@ enum {
 struct ad799x_state;
 
 /**
- * struct ad799x_chip_info - chip specifc information
+ * struct ad799x_chip_info - chip specific information
  * @channel:   channel specification
  * @num_channels:  number of channels
  * @monitor_mode:  whether the chip supports monitor interrupts
diff --git a/drivers/staging/iio/addac/adt7316.c 
b/drivers/staging/iio/addac/adt7316.c
index 9f0ebb3..5f1770e 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -172,7 +172,7 @@
 #define ID_ADT75XX 0x10
 
 /*
- * struct adt7316_chip_info - chip specifc information
+ * struct adt7316_chip_info - chip specific information
  */
 
 struct adt7316_chip_info {
@@ -208,7 +208,7 @@ struct adt7316_chip_info {
(ADT7316_TEMP_INT_MASK)
 
 /*
- * struct adt7316_chip_info - chip specifc information
+ * struct adt7316_chip_info - chip specific information
  */
 
 struct adt7316_limit_regs {
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index f2c309d..87110d9 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -78,7 +78,7 @@ enum {
 };
 
 /*
- * struct ad7152_chip_info - chip specifc information
+ * struct ad7152_chip_info - chip specific information
  */
 
 struct ad7152_chip_info {
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index cbb1588..e6e9eaa 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -91,7 +91,7 @@
 #define AD7746_CAPDAC_DACP(x)  ((x) & 0x7F)
 
 /*
- * struct ad7746_chip_info - chip specifc information
+ * struct ad7746_chip_info - chip specific information
  */
 
 struct ad7746_chip_info {
-- 
2.0.0.rc0.26.g779792a

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging:lustre: use gfp_t instead of int

2014-04-22 Thread Vitaly Osipov 
Fixed several sparse "warning: incorrect type" by replacing int
declarations with gfp_t

Signed-off-by: Vitaly Osipov 
---
 .../staging/lustre/include/linux/libcfs/libcfs.h   |1 +
 drivers/staging/lustre/lustre/libcfs/module.c  |3 ++-
 drivers/staging/lustre/lustre/libcfs/tracefile.c   |4 ++--
 drivers/staging/lustre/lustre/libcfs/tracefile.h   |2 +-
 .../staging/lustre/lustre/obdecho/echo_client.c|2 +-
 5 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h 
b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
index 4a6c7da..26b53f6 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs.h
@@ -42,6 +42,7 @@
 #endif
 
 #include 
+#include 
 
 #include "curproc.h"
 
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c 
b/drivers/staging/lustre/lustre/libcfs/module.c
index 24ae26d..b16ee08 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/drivers/staging/lustre/lustre/libcfs/module.c
@@ -87,7 +87,8 @@ kportal_memhog_free (struct libcfs_device_userstate *ldu)
 }
 
 int
-kportal_memhog_alloc (struct libcfs_device_userstate *ldu, int npages, int 
flags)
+kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages,
+gfp_t flags)
 {
struct page **level0p;
struct page **level1p;
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c 
b/drivers/staging/lustre/lustre/libcfs/tracefile.c
index c8599ee..50d4218 100644
--- a/drivers/staging/lustre/lustre/libcfs/tracefile.c
+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.c
@@ -66,7 +66,7 @@ cfs_tage_from_list(struct list_head *list)
return list_entry(list, struct cfs_trace_page, linkage);
 }
 
-static struct cfs_trace_page *cfs_tage_alloc(int gfp)
+static struct cfs_trace_page *cfs_tage_alloc(gfp_t gfp)
 {
struct page *page;
struct cfs_trace_page *tage;
@@ -114,7 +114,7 @@ static void cfs_tage_to_tail(struct cfs_trace_page *tage,
list_move_tail(&tage->linkage, queue);
 }
 
-int cfs_trace_refill_stock(struct cfs_trace_cpu_data *tcd, int gfp,
+int cfs_trace_refill_stock(struct cfs_trace_cpu_data *tcd, gfp_t gfp,
   struct list_head *stock)
 {
int i;
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.h 
b/drivers/staging/lustre/lustre/libcfs/tracefile.h
index 7e8d17c..55ecfc9 100644
--- a/drivers/staging/lustre/lustre/libcfs/tracefile.h
+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.h
@@ -307,7 +307,7 @@ cfs_trace_put_tcd (struct cfs_trace_cpu_data *tcd)
put_cpu();
 }
 
-int cfs_trace_refill_stock(struct cfs_trace_cpu_data *tcd, int gfp,
+int cfs_trace_refill_stock(struct cfs_trace_cpu_data *tcd, gfp_t gfp,
   struct list_head *stock);
 
 
diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c 
b/drivers/staging/lustre/lustre/obdecho/echo_client.c
index 754aa8e..a7f5e41 100644
--- a/drivers/staging/lustre/lustre/obdecho/echo_client.c
+++ b/drivers/staging/lustre/lustre/obdecho/echo_client.c
@@ -2432,7 +2432,7 @@ static int echo_client_kbrw(struct echo_device *ed, int 
rw, struct obdo *oa,
int  i;
int  rc;
int  verify;
-   int  gfp_mask;
+   gfp_tgfp_mask;
int  brw_flags = 0;
 
verify = (ostid_id(&oa->o_oi) != ECHO_PERSISTENT_OBJID &&
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread navin patidar 
Hi dan

it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK  TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.

Tested-by: navin patidar 

regards,
--navin-patidar

On Tue, Apr 22, 2014 at 3:41 PM, Dan Carpenter  wrote:
> On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
>> _ReadLEDSetting() doesn't read led settings this function actually
>> initialize  member variables of struct led_priv, we should do that
>> inside rtl8188eu_InitSwLeds().
>>
>
> This seems like a bugfix or is it just a cleanup?  It's not clear to me
> from the patch description.  Have you tested this patch?
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread Dan Carpenter 
On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
> Hi dan
> 
> it's just a cleanup patch and i also tested all patches of this patch
> series on the hardware (TP-LINK  TL-WN723N).
> my mistake i should have added "Tested-by" tag for all patches.
> 
> Tested-by: navin patidar 

No no.  It's not necesary to add a tested by to everything.  It was just
something I was curious about.  The patches looked ok.  If you hadn't
tested them I would review them a second time more carefully.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread Larry Finger 

On 04/22/2014 09:14 AM, Dan Carpenter wrote:

On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:

Hi dan

it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK  TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.

Tested-by: navin patidar 


No no.  It's not necesary to add a tested by to everything.  It was just
something I was curious about.  The patches looked ok.  If you hadn't
tested them I would review them a second time more carefully.


To me, the opposite case is true. If you have not tested, then you need to 
explicitly state "compile tested only" in the commit message. Without saying 
that, your signed-off-by is implying that you have tested, as well as declaring 
that you own the copyright to the material.


Larry

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread Dan Carpenter 
I sometimes mark my patches as untested and there are a couple other
people who do as well.  For the staging tree probably 80% of the patches
are not tested.  I kind of know who regular developers are and who tests
their patches.

But one thing I really want to stress is that if I ask something about a
patch, it doesn't mean I'm annoyed.  It just means I was curious.

regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-22 Thread K. Y. Srinivasan 
We send packets using a copy-free mechanism (this is the Guest to Host transport
via VMBUS). While this is obviously optimal for large packets,
it may not be optimal for small packets. Hyper-V host supports
a second mechanism for sending packets that is "copy based". We implement that
mechanism in this patch.

With this patch (and all of the other offload and VRSS patches), we are now able
to almost saturate a 10G interface between Linux VMs on Hyper-V
on different hosts - close to  9 Gbps as measured via iperf.

Signed-off-by: K. Y. Srinivasan 
Reviewed-by: Haiyang Zhang 
---
 drivers/net/hyperv/hyperv_net.h |   14 +++
 drivers/net/hyperv/netvsc.c |  226 +--
 drivers/net/hyperv/netvsc_drv.c |3 +-
 3 files changed, 234 insertions(+), 9 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index d1f7826..4b7df5a 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -140,6 +140,8 @@ struct hv_netvsc_packet {
void *send_completion_ctx;
void (*send_completion)(void *context);
 
+   u32 send_buf_index;
+
/* This points to the memory after page_buf */
struct rndis_message *rndis_msg;
 
@@ -582,6 +584,9 @@ struct nvsp_message {
 
 #define NETVSC_RECEIVE_BUFFER_SIZE (1024*1024*16)  /* 16MB */
 #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY  (1024*1024*15)  /* 15MB */
+#define NETVSC_SEND_BUFFER_SIZE(1024 * 1024)   /* 1MB 
*/
+#define NETVSC_INVALID_INDEX   -1
+
 
 #define NETVSC_RECEIVE_BUFFER_ID   0xcafe
 
@@ -607,6 +612,15 @@ struct netvsc_device {
u32 recv_section_cnt;
struct nvsp_1_receive_buffer_section *recv_section;
 
+   /* Send buffer allocated by us */
+   void *send_buf;
+   u32 send_buf_size;
+   u32 send_buf_gpadl_handle;
+   u32 send_section_cnt;
+   u32 send_section_size;
+   unsigned long *send_section_map;
+   int map_words;
+
/* Used for NetVSP initialization protocol */
struct completion channel_init_wait;
struct nvsp_message channel_init_pkt;
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index bbee446..9ee2d78 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "hyperv_net.h"
 
@@ -80,7 +81,7 @@ get_in_err:
 }
 
 
-static int netvsc_destroy_recv_buf(struct netvsc_device *net_device)
+static int netvsc_destroy_buf(struct netvsc_device *net_device)
 {
struct nvsp_message *revoke_packet;
int ret = 0;
@@ -146,10 +147,62 @@ static int netvsc_destroy_recv_buf(struct netvsc_device 
*net_device)
net_device->recv_section = NULL;
}
 
+   /* Deal with the send buffer we may have setup.
+* If we got a  send section size, it means we received a
+* SendsendBufferComplete msg (ie sent
+* NvspMessage1TypeSendReceiveBuffer msg) therefore, we need
+* to send a revoke msg here
+*/
+   if (net_device->send_section_size) {
+   /* Send the revoke receive buffer */
+   revoke_packet = &net_device->revoke_packet;
+   memset(revoke_packet, 0, sizeof(struct nvsp_message));
+
+   revoke_packet->hdr.msg_type =
+   NVSP_MSG1_TYPE_REVOKE_SEND_BUF;
+   revoke_packet->msg.v1_msg.revoke_recv_buf.id = 0;
+
+   ret = vmbus_sendpacket(net_device->dev->channel,
+  revoke_packet,
+  sizeof(struct nvsp_message),
+  (unsigned long)revoke_packet,
+  VM_PKT_DATA_INBAND, 0);
+   /* If we failed here, we might as well return and
+* have a leak rather than continue and a bugchk
+*/
+   if (ret != 0) {
+   netdev_err(ndev, "unable to send "
+  "revoke send buffer to netvsp\n");
+   return ret;
+   }
+   }
+   /* Teardown the gpadl on the vsp end */
+   if (net_device->send_buf_gpadl_handle) {
+   ret = vmbus_teardown_gpadl(net_device->dev->channel,
+  net_device->send_buf_gpadl_handle);
+
+   /* If we failed here, we might as well return and have a leak
+* rather than continue and a bugchk
+*/
+   if (ret != 0) {
+   netdev_err(ndev,
+  "unable to teardown send buffer's gpadl\n");
+   return ret;
+   }
+   net_device->recv_buf_gpadl_handle = 0;
+   }
+   if (net_device->send_buf) {
+   /* Free up the receive buffer */
+   free_pages((unsigne

[PATCH v3 2/6] Staging: rts5139: Fixed multi-line code alignment

2014-04-22 Thread Fabio Falzoi 
Multi-line code aligned with open parenthesis.

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 21 ++---
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 9d9c706..28f4631 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -291,15 +291,15 @@ static int rts51x_control_thread(void *__chip)
 */
else if (chip->srb->device->id) {
RTS51X_DEBUGP("Bad target number (%d:%d)\n",
-  chip->srb->device->id,
-  chip->srb->device->lun);
+ chip->srb->device->id,
+ chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
}
 
else if (chip->srb->device->lun > chip->max_lun) {
RTS51X_DEBUGP("Bad LUN (%d:%d)\n",
-  chip->srb->device->id,
-  chip->srb->device->lun);
+ chip->srb->device->id,
+ chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
}
 
@@ -433,12 +433,12 @@ static int associate_dev(struct rts51x_chip *chip, struct 
usb_interface *intf)
rts51x->pusb_intf = intf;
rts51x->ifnum = intf->cur_altsetting->desc.bInterfaceNumber;
RTS51X_DEBUGP("Vendor: 0x%04x, Product: 0x%04x, Revision: 0x%04x\n",
-  le16_to_cpu(rts51x->pusb_dev->descriptor.idVendor),
-  le16_to_cpu(rts51x->pusb_dev->descriptor.idProduct),
-  le16_to_cpu(rts51x->pusb_dev->descriptor.bcdDevice));
+ le16_to_cpu(rts51x->pusb_dev->descriptor.idVendor),
+ le16_to_cpu(rts51x->pusb_dev->descriptor.idProduct),
+ le16_to_cpu(rts51x->pusb_dev->descriptor.bcdDevice));
RTS51X_DEBUGP("Interface Subclass: 0x%02x, Protocol: 0x%02x\n",
-  intf->cur_altsetting->desc.bInterfaceSubClass,
-  intf->cur_altsetting->desc.bInterfaceProtocol);
+ intf->cur_altsetting->desc.bInterfaceSubClass,
+ intf->cur_altsetting->desc.bInterfaceProtocol);
 
/* Store our private data in the interface */
usb_set_intfdata(intf, chip);
@@ -569,8 +569,7 @@ static int get_pipes(struct rts51x_chip *chip)
}
 
if (!ep_in || !ep_out) {
-   RTS51X_DEBUGP("Endpoint sanity check failed!"
-   "Rejecting dev.\n");
+   RTS51X_DEBUGP("Endpoint sanity check failed! Rejecting dev.\n");
return -EIO;
}
 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 0/6] Staging: rts5139: Fix coding style

2014-04-22 Thread Fabio Falzoi 
Fix some coding style issues in rts51x.c (from rts5139 module).

Changes in v3:
* removed all the Out Of Memory messages
* redefined pr_fmt to add a prefix to each pr_.
Changes in v2:
* patch splitted to have just one specific coding style issue fixed at a time

Fabio Falzoi (6):
  Staging: rts5139: Camel case labels replaced
  Staging: rts5139: Fixed multi-line code alignment
  Staging: rts5139: Splitted one-line multiple assignment
  Staging: rts5139: Use standard pr_ prefixing
  Staging: rts5139: Removed OOM messages
  Staging: rts5139: More appropriate use of sizeof operand

 drivers/staging/rts5139/rts51x.c | 125 ++-
 1 file changed, 57 insertions(+), 68 deletions(-)

-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 1/6] Staging: rts5139: Camel case labels replaced

2014-04-22 Thread Fabio Falzoi 
Replace camel case labels with linux coding style compliant names.

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index c8d06d4..9d9c706 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -273,7 +273,7 @@ static int rts51x_control_thread(void *__chip)
/* has the command timed out *already* ? */
if (test_bit(FLIDX_TIMED_OUT, &chip->usb->dflags)) {
chip->srb->result = DID_ABORT << 16;
-   goto SkipForAbort;
+   goto abort;
}
 
scsi_unlock(host);
@@ -316,7 +316,7 @@ static int rts51x_control_thread(void *__chip)
if (chip->srb->result != DID_ABORT << 16)
chip->srb->scsi_done(chip->srb);
else
-SkipForAbort :
+abort :
RTS51X_DEBUGP("scsi command aborted\n");
 
/* If an abort request was received we need to signal that
@@ -763,17 +763,17 @@ static int rts51x_probe(struct usb_interface *intf,
/* Associate the us_data structure with the USB device */
result = associate_dev(chip, intf);
if (result)
-   goto BadDevice;
+   goto bad_device;
 
/* Find the endpoints and calculate pipe values */
result = get_pipes(chip);
if (result)
-   goto BadDevice;
+   goto bad_device;
 
/* Acquire all the other resources and add the host */
result = rts51x_acquire_resources(chip);
if (result)
-   goto BadDevice;
+   goto bad_device;
 
/* Start up our control thread */
th = kthread_run(rts51x_control_thread, chip, RTS51X_CTL_THREAD);
@@ -781,14 +781,14 @@ static int rts51x_probe(struct usb_interface *intf,
printk(KERN_WARNING RTS51X_TIP
   "Unable to start control thread\n");
result = PTR_ERR(th);
-   goto BadDevice;
+   goto bad_device;
}
rts51x->ctl_thread = th;
 
result = scsi_add_host(rts51x_to_host(chip), &rts51x->pusb_intf->dev);
if (result) {
printk(KERN_WARNING RTS51X_TIP "Unable to add the scsi host\n");
-   goto BadDevice;
+   goto bad_device;
}
scsi_scan_host(rts51x_to_host(chip));
 
@@ -798,7 +798,7 @@ static int rts51x_probe(struct usb_interface *intf,
printk(KERN_WARNING RTS51X_TIP
   "Unable to start polling thread\n");
result = PTR_ERR(th);
-   goto BadDevice;
+   goto bad_device;
}
rts51x->polling_thread = th;
 
@@ -813,7 +813,7 @@ static int rts51x_probe(struct usb_interface *intf,
return 0;
 
/* We come here if there are any problems */
-BadDevice:
+bad_device:
RTS51X_DEBUGP("rts51x_probe() failed\n");
release_everything(chip);
return result;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

2014-04-22 Thread Fabio Falzoi 
Define pr_fmt macro to prefix every pr_ function in standard way.

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 100 +++
 1 file changed, 50 insertions(+), 50 deletions(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 2be6210..8a0f9ae 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -23,6 +23,8 @@
  *   No. 450, Shenhu Road, Suzhou Industry Park, Suzhou, China
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include 
 #include 
 #include 
@@ -109,13 +111,13 @@ static inline void usb_autopm_disable(struct 
usb_interface *intf)
 
 static void rts51x_try_to_enter_ss(struct rts51x_chip *chip)
 {
-   RTS51X_DEBUGP("Ready to enter SS state\n");
+   pr_debug("Ready to enter SS state\n");
usb_autopm_enable(chip->usb->pusb_intf);
 }
 
 void rts51x_try_to_exit_ss(struct rts51x_chip *chip)
 {
-   RTS51X_DEBUGP("Exit from SS state\n");
+   pr_debug("Exit from SS state\n");
usb_autopm_disable(chip->usb->pusb_intf);
 }
 
@@ -123,7 +125,7 @@ int rts51x_suspend(struct usb_interface *iface, 
pm_message_t message)
 {
struct rts51x_chip *chip = usb_get_intfdata(iface);
 
-   RTS51X_DEBUGP("%s, message.event = 0x%x\n", __func__, message.event);
+   pr_debug("%s, message.event = 0x%x\n", __func__, message.event);
 
/* Wait until no command is running */
mutex_lock(&chip->usb->dev_mutex);
@@ -132,11 +134,11 @@ int rts51x_suspend(struct usb_interface *iface, 
pm_message_t message)
rts51x_do_before_power_down(chip);
 
if (message.event == PM_EVENT_AUTO_SUSPEND) {
-   RTS51X_DEBUGP("Enter SS state");
+   pr_debug("Enter SS state");
chip->resume_from_scsi = 0;
RTS51X_SET_STAT(chip, STAT_SS);
} else {
-   RTS51X_DEBUGP("Enter SUSPEND state");
+   pr_debug("Enter SUSPEND state");
RTS51X_SET_STAT(chip, STAT_SUSPEND);
}
 
@@ -151,7 +153,7 @@ int rts51x_resume(struct usb_interface *iface)
 {
struct rts51x_chip *chip = usb_get_intfdata(iface);
 
-   RTS51X_DEBUGP("%s\n", __func__);
+   pr_debug("%s\n", __func__);
 
if (!RTS51X_CHK_STAT(chip, STAT_SS) || !chip->resume_from_scsi) {
mutex_lock(&chip->usb->dev_mutex);
@@ -159,7 +161,7 @@ int rts51x_resume(struct usb_interface *iface)
if (chip->option.ss_en) {
if (GET_PM_USAGE_CNT(chip) <= 0) {
/* Remote wake up, increase pm_usage_cnt */
-   RTS51X_DEBUGP("Incr pm_usage_cnt\n");
+   pr_debug("Incr pm_usage_cnt\n");
SET_PM_USAGE_CNT(chip, 1);
}
}
@@ -179,7 +181,7 @@ int rts51x_reset_resume(struct usb_interface *iface)
 {
struct rts51x_chip *chip = usb_get_intfdata(iface);
 
-   RTS51X_DEBUGP("%s\n", __func__);
+   pr_debug("%s\n", __func__);
 
mutex_lock(&chip->usb->dev_mutex);
 
@@ -219,7 +221,7 @@ static int rts51x_pre_reset(struct usb_interface *iface)
 {
struct rts51x_chip *chip = usb_get_intfdata(iface);
 
-   RTS51X_DEBUGP("%s\n", __func__);
+   pr_debug("%s\n", __func__);
 
/* Make sure no command runs during the reset */
mutex_lock(&chip->usb->dev_mutex);
@@ -230,7 +232,7 @@ static int rts51x_post_reset(struct usb_interface *iface)
 {
struct rts51x_chip *chip = usb_get_intfdata(iface);
 
-   RTS51X_DEBUGP("%s\n", __func__);
+   pr_debug("%s\n", __func__);
 
/* Report the reset to the SCSI core */
/* usb_stor_report_bus_reset(us); */
@@ -252,7 +254,7 @@ static int rts51x_control_thread(void *__chip)
break;
 
if (test_bit(FLIDX_DISCONNECTING, &chip->usb->dflags)) {
-   RTS51X_DEBUGP("-- exiting from rts51x-control\n");
+   pr_debug("-- exiting from rts51x-control\n");
break;
}
 
@@ -266,7 +268,7 @@ static int rts51x_control_thread(void *__chip)
if (chip->srb == NULL) {
scsi_unlock(host);
mutex_unlock(&chip->usb->dev_mutex);
-   RTS51X_DEBUGP("-- exiting from control thread\n");
+   pr_debug("-- exiting from control thread\n");
break;
}
 
@@ -282,7 +284,7 @@ static int rts51x_control_thread(void *__chip)
 * is UNKNOWN
 */
if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) {
-   RTS51X_DEBUGP("UNKNOWN data direction\n");
+   pr_debug("UNKNOWN data direction\n");
chip->srb->result = DID_ERROR << 16;
}
 
@@ -290,16 +292,16 @@ static int rts51x_contr

[PATCH v3 3/6] Staging: rts5139: Splitted one-line multiple assignment

2014-04-22 Thread Fabio Falzoi 
Splitted a multiple assignment on two separate lines.

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 28f4631..2be6210 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -607,7 +607,8 @@ static int rts51x_acquire_resources(struct rts51x_chip 
*chip)
return -ENOMEM;
}
 
-   chip->cmd_buf = chip->rsp_buf = rts51x->iobuf;
+   chip->cmd_buf = rts51x->iobuf;
+   chip->rsp_buf = rts51x->iobuf;
 
rts51x_init_options(chip);
 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 5/6] Staging: rts5139: Removed OOM messages

2014-04-22 Thread Fabio Falzoi 
All allocation Out Of Memory messages removed.
We rely on the generic OOM message in dump_stack().

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 17 +++--
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 8a0f9ae..6120410 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -460,7 +460,6 @@ static int associate_dev(struct rts51x_chip *chip, struct 
usb_interface *intf)
rts51x->cr = usb_buffer_alloc(rts51x->pusb_dev, sizeof(*rts51x->cr),
  GFP_KERNEL, &rts51x->cr_dma);
if (!rts51x->cr) {
-   pr_debug("usb_ctrlrequest allocation failed\n");
usb_set_intfdata(intf, NULL);
return -ENOMEM;
}
@@ -468,7 +467,6 @@ static int associate_dev(struct rts51x_chip *chip, struct 
usb_interface *intf)
rts51x->iobuf = usb_buffer_alloc(rts51x->pusb_dev, RTS51X_IOBUF_SIZE,
 GFP_KERNEL, &rts51x->iobuf_dma);
if (!rts51x->iobuf) {
-   pr_debug("I/O buffer allocation failed\n");
usb_set_intfdata(intf, NULL);
return -ENOMEM;
}
@@ -598,16 +596,12 @@ static int rts51x_acquire_resources(struct rts51x_chip 
*chip)
int retval;
 
rts51x->current_urb = usb_alloc_urb(0, GFP_KERNEL);
-   if (!rts51x->current_urb) {
-   pr_debug("URB allocation failed\n");
+   if (!rts51x->current_urb)
return -ENOMEM;
-   }
 
rts51x->intr_urb = usb_alloc_urb(0, GFP_KERNEL);
-   if (!rts51x->intr_urb) {
-   pr_debug("URB allocation failed\n");
+   if (!rts51x->intr_urb)
return -ENOMEM;
-   }
 
chip->cmd_buf = rts51x->iobuf;
chip->rsp_buf = rts51x->iobuf;
@@ -726,11 +720,8 @@ static int rts51x_probe(struct usb_interface *intf,
pr_debug("%s detected\n", RTS51X_NAME);
 
rts51x = kzalloc(sizeof(struct rts51x_usb), GFP_KERNEL);
-   if (!rts51x) {
-   pr_warn(RTS51X_TIP
-   "Unable to allocate rts51x_usb\n");
+   if (!rts51x)
return -ENOMEM;
-   }
 
/*
 * Ask the SCSI layer to allocate a host structure, with extra
@@ -738,8 +729,6 @@ static int rts51x_probe(struct usb_interface *intf,
 */
host = scsi_host_alloc(&rts51x_host_template, sizeof(*chip));
if (!host) {
-   pr_warn(RTS51X_TIP
-   "Unable to allocate the scsi host\n");
kfree(rts51x);
return -ENOMEM;
}
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 6/6] Staging: rts5139: More appropriate use of sizeof operand

2014-04-22 Thread Fabio Falzoi 
Use the pointer rts51x to get the size of the struct.

Signed-off-by: Fabio Falzoi 
---
 drivers/staging/rts5139/rts51x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 6120410..8529cba 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -719,7 +719,7 @@ static int rts51x_probe(struct usb_interface *intf,
 
pr_debug("%s detected\n", RTS51X_NAME);
 
-   rts51x = kzalloc(sizeof(struct rts51x_usb), GFP_KERNEL);
+   rts51x = kzalloc(sizeof(*rts51x), GFP_KERNEL);
if (!rts51x)
return -ENOMEM;
 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 1/6] Staging: rts5139: Camel case labels replaced

2014-04-22 Thread Dan Carpenter 
On Tue, Apr 22, 2014 at 11:22:59PM +0200, Fabio Falzoi wrote:
> @@ -316,7 +316,7 @@ static int rts51x_control_thread(void *__chip)
>   if (chip->srb->result != DID_ABORT << 16)
>   chip->srb->scsi_done(chip->srb);
>   else
> -SkipForAbort :
> +abort :

Just a comment (no need to resend).  Next time remove the space before
the colon.

abort:

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

2014-04-22 Thread Dan Carpenter 
On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote:
> Define pr_fmt macro to prefix every pr_ function in standard way.
> 

In the end we will want to remove all these debugging messages.  The
error conditions probably already have a print, the function tracing is
done better with ftrace, etc.

Also the pr_ functions have fallen out of fashion and all the cool kids
use dev_ prefixed printks now.  (Doesn't really apply to this patch per
se).

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

2014-04-22 Thread Dan Carpenter 
On Wed, Apr 23, 2014 at 01:07:57AM +0300, Dan Carpenter wrote:
> On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote:
> > Define pr_fmt macro to prefix every pr_ function in standard way.
> > 
> 
> In the end we will want to remove all these debugging messages.

Ah.  I see that you do remove some in a later patch.

Fine fine.  I have no problems with this patchset.  Seems like a nice
cleanup.  Thanks.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: iio: Fix typo in iio

2014-04-22 Thread Randy Dunlap 
On 04/22/14 04:23, Masanari Iida wrote:
> Correct spelling typo in comment within staging/iio
> 
> Signed-off-by: Masanari Iida 

Acked-by: Randy Dunlap 

Thanks.

> ---
>  drivers/staging/iio/adc/ad7606.h| 4 ++--
>  drivers/staging/iio/adc/ad7816.c| 2 +-
>  drivers/staging/iio/adc/ad799x.h| 2 +-
>  drivers/staging/iio/addac/adt7316.c | 4 ++--
>  drivers/staging/iio/cdc/ad7152.c| 2 +-
>  drivers/staging/iio/cdc/ad7746.c| 2 +-
>  6 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7606.h 
> b/drivers/staging/iio/adc/ad7606.h
> index 93c7299..ec89d05 100644
> --- a/drivers/staging/iio/adc/ad7606.h
> +++ b/drivers/staging/iio/adc/ad7606.h
> @@ -14,7 +14,7 @@
>   */
>  
>  /**
> - * struct ad7606_platform_data - platform/board specifc information
> + * struct ad7606_platform_data - platform/board specific information
>   * @default_os:  default oversampling value {0, 2, 4, 8, 16, 32, 
> 64}
>   * @default_range:   default range +/-{5000, 1} mVolt
>   * @gpio_convst: number of gpio connected to the CONVST pin
> @@ -41,7 +41,7 @@ struct ad7606_platform_data {
>  };
>  
>  /**
> - * struct ad7606_chip_info - chip specifc information
> + * struct ad7606_chip_info - chip specific information
>   * @name:identification string for chip
>   * @int_vref_mv: the internal reference voltage
>   * @channels:channel specification
> diff --git a/drivers/staging/iio/adc/ad7816.c 
> b/drivers/staging/iio/adc/ad7816.c
> index 2369cf2..158d770 100644
> --- a/drivers/staging/iio/adc/ad7816.c
> +++ b/drivers/staging/iio/adc/ad7816.c
> @@ -40,7 +40,7 @@
>  
>  
>  /*
> - * struct ad7816_chip_info - chip specifc information
> + * struct ad7816_chip_info - chip specific information
>   */
>  
>  struct ad7816_chip_info {
> diff --git a/drivers/staging/iio/adc/ad799x.h 
> b/drivers/staging/iio/adc/ad799x.h
> index fc8c852..70ddfa2 100644
> --- a/drivers/staging/iio/adc/ad799x.h
> +++ b/drivers/staging/iio/adc/ad799x.h
> @@ -76,7 +76,7 @@ enum {
>  struct ad799x_state;
>  
>  /**
> - * struct ad799x_chip_info - chip specifc information
> + * struct ad799x_chip_info - chip specific information
>   * @channel: channel specification
>   * @num_channels:number of channels
>   * @monitor_mode:whether the chip supports monitor interrupts
> diff --git a/drivers/staging/iio/addac/adt7316.c 
> b/drivers/staging/iio/addac/adt7316.c
> index 9f0ebb3..5f1770e 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -172,7 +172,7 @@
>  #define ID_ADT75XX   0x10
>  
>  /*
> - * struct adt7316_chip_info - chip specifc information
> + * struct adt7316_chip_info - chip specific information
>   */
>  
>  struct adt7316_chip_info {
> @@ -208,7 +208,7 @@ struct adt7316_chip_info {
>   (ADT7316_TEMP_INT_MASK)
>  
>  /*
> - * struct adt7316_chip_info - chip specifc information
> + * struct adt7316_chip_info - chip specific information
>   */
>  
>  struct adt7316_limit_regs {
> diff --git a/drivers/staging/iio/cdc/ad7152.c 
> b/drivers/staging/iio/cdc/ad7152.c
> index f2c309d..87110d9 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -78,7 +78,7 @@ enum {
>  };
>  
>  /*
> - * struct ad7152_chip_info - chip specifc information
> + * struct ad7152_chip_info - chip specific information
>   */
>  
>  struct ad7152_chip_info {
> diff --git a/drivers/staging/iio/cdc/ad7746.c 
> b/drivers/staging/iio/cdc/ad7746.c
> index cbb1588..e6e9eaa 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -91,7 +91,7 @@
>  #define AD7746_CAPDAC_DACP(x)((x) & 0x7F)
>  
>  /*
> - * struct ad7746_chip_info - chip specifc information
> + * struct ad7746_chip_info - chip specific information
>   */
>  
>  struct ad7746_chip_info {
> 


-- 
~Randy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 0/3] staging: gdm72xx: Minor cleanup

2014-04-22 Thread Michalis Pappas 
The following patches perform various cleanups on the gdm72xx driver.

PATCH 1/3 fixes some small coding style issues
PATCH 2/3 removes an already completed item from the TODO list
PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions

After all patches have been applied, the only remaining issue on the
TODO list is to conform to the coding standards. The remaining issues
reported by checkpatch.pl are probably pedantic, so if agreed, that task
can be removed from the list too.

-Michalis
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 1/3] staging: gdm72xx: Coding style fixes

2014-04-22 Thread Michalis Pappas 

Minor white-space fixes as suggested by checkpatch.pl.

Signed-off-by: Michalis Pappas 
---
 drivers/staging/gdm72xx/gdm_qos.c   | 2 +-
 drivers/staging/gdm72xx/gdm_wimax.c | 2 ++
 drivers/staging/gdm72xx/usb_boot.c  | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/gdm72xx/gdm_qos.c 
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..245109e 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -377,7 +377,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int 
size)
index = get_csr(qcb, SFID, 1);
if (index == -1) {
netdev_err(nic->netdev,
-  "QoS ERROR: csr Update Error / Wrong index (%d) \n",
+  "QoS ERROR: csr Update Error / Wrong index (%d)\n",
   index);
return;
}
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c 
b/drivers/staging/gdm72xx/gdm_wimax.c
index 05ce2a2..5d05cdb 100644
--- a/drivers/staging/gdm72xx/gdm_wimax.c
+++ b/drivers/staging/gdm72xx/gdm_wimax.c
@@ -199,6 +199,7 @@ static void gdm_wimax_event_rcv(struct net_device *dev, u16 
type, void *msg,
u8 *buf = (u8 *) msg;
u16 hci_cmd =  (buf[0]<<8) | buf[1];
u16 hci_len = (buf[2]<<8) | buf[3];
+
netdev_dbg(dev, "H=>D: 0x%04x(%d)\n", hci_cmd, hci_len);
 
gdm_wimax_send(nic, msg, len);
@@ -310,6 +311,7 @@ static int gdm_wimax_event_send(struct net_device *dev, 
char *buf, int size)
 
u16 hci_cmd =  ((u8)buf[0]<<8) | (u8)buf[1];
u16 hci_len = ((u8)buf[2]<<8) | (u8)buf[3];
+
netdev_dbg(dev, "D=>H: 0x%04x(%d)\n", hci_cmd, hci_len);
 
spin_lock_irqsave(&wm_event.evt_lock, flags);
diff --git a/drivers/staging/gdm72xx/usb_boot.c 
b/drivers/staging/gdm72xx/usb_boot.c
index 0d45eb6..4d7c61c 100644
--- a/drivers/staging/gdm72xx/usb_boot.c
+++ b/drivers/staging/gdm72xx/usb_boot.c
@@ -67,6 +67,7 @@ struct fw_info {
 static void array_le32_to_cpu(u32 *arr, int num)
 {
int i;
+
for (i = 0; i < num; i++, arr++)
*arr = __le32_to_cpu(*arr);
 }
-- 
1.7.12.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 2/3] staging: gdm72xx: Removed completed task from TODO list

2014-04-22 Thread Michalis Pappas 

Removed line related to replacement of kernel_thread with kthread, as issue 
was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function 
kernel_thread')

Signed-off-by: Michalis Pappas 
---
 drivers/staging/gdm72xx/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gdm72xx/TODO b/drivers/staging/gdm72xx/TODO
index 5ab27fb..62d0cd6 100644
--- a/drivers/staging/gdm72xx/TODO
+++ b/drivers/staging/gdm72xx/TODO
@@ -1,3 +1,2 @@
 TODO:
-- Replace kernel_thread with kthread in gdm_usb.c
 - Clean up coding style to meet kernel standard.
-- 
1.7.12.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 3/3] staging: gdm72xx: Removed direct comparisons on jiffies

2014-04-22 Thread Michalis Pappas 

Replaced comparisons on jiffies values with wrap-safe functions.

Signed-off-by: Michalis Pappas 
---
 drivers/staging/gdm72xx/gdm_usb.c   | 2 +-
 drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gdm72xx/gdm_usb.c 
b/drivers/staging/gdm72xx/gdm_usb.c
index 20539d8..9ddf8f5 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -730,7 +730,7 @@ static int k_mode_thread(void *arg)
spin_unlock_irqrestore(&k_lock, flags2);
 
expire = jiffies + K_WAIT_TIME;
-   while (jiffies < expire)
+   while (time_before(jiffies, expire))
schedule_timeout(K_WAIT_TIME);
 
spin_lock_irqsave(&rx->lock, flags);
diff --git a/drivers/staging/gdm72xx/sdio_boot.c 
b/drivers/staging/gdm72xx/sdio_boot.c
index cbe5dcf..2c02842 100644
--- a/drivers/staging/gdm72xx/sdio_boot.c
+++ b/drivers/staging/gdm72xx/sdio_boot.c
@@ -41,11 +41,11 @@ static u8 *tx_buf;
 
 static int ack_ready(struct sdio_func *func)
 {
-   unsigned long start = jiffies;
+   unsigned long wait = jiffies + HZ;
u8 val;
int ret;
 
-   while ((jiffies - start) < HZ) {
+   while (time_before(jiffies, wait)) {
val = sdio_readb(func, 0x13, &ret);
if (val & 0x01)
return 1;
-- 
1.7.12.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: android: ion: duplicated clearing of sg_table

2014-04-22 Thread gioh.kim 
From: "gioh.kim" 

Because sg_table is cleared in sg_alloc_table via memset we don't need to use
kzalloc to allocate sg_table.

Signed-off-by: Gioh Kim 
---
 drivers/staging/android/ion/ion_carveout_heap.c |2 +-
 drivers/staging/android/ion/ion_chunk_heap.c|2 +-
 drivers/staging/android/ion/ion_system_heap.c   |4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/ion/ion_carveout_heap.c 
b/drivers/staging/android/ion/ion_carveout_heap.c
index 3cb05b9..dcb6f21 100644
--- a/drivers/staging/android/ion/ion_carveout_heap.c
+++ b/drivers/staging/android/ion/ion_carveout_heap.c
@@ -81,7 +81,7 @@ static int ion_carveout_heap_allocate(struct ion_heap *heap,
if (align > PAGE_SIZE)
return -EINVAL;
 
-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
return -ENOMEM;
ret = sg_alloc_table(table, 1, GFP_KERNEL);
diff --git a/drivers/staging/android/ion/ion_chunk_heap.c 
b/drivers/staging/android/ion/ion_chunk_heap.c
index d40f5f8..3f2c12b 100644
--- a/drivers/staging/android/ion/ion_chunk_heap.c
+++ b/drivers/staging/android/ion/ion_chunk_heap.c
@@ -55,7 +55,7 @@ static int ion_chunk_heap_allocate(struct ion_heap *heap,
if (allocated_size > chunk_heap->size - chunk_heap->allocated)
return -ENOMEM;
 
-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
return -ENOMEM;
ret = sg_alloc_table(table, num_chunks, GFP_KERNEL);
diff --git a/drivers/staging/android/ion/ion_system_heap.c 
b/drivers/staging/android/ion/ion_system_heap.c
index c923633..0663a7f 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -166,7 +166,7 @@ static int ion_system_heap_allocate(struct ion_heap *heap,
max_order = info->order;
i++;
}
-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table)
goto err;
 
@@ -356,7 +356,7 @@ static int ion_system_contig_heap_allocate(struct ion_heap 
*heap,
for (i = len >> PAGE_SHIFT; i < (1 << order); i++)
__free_page(page + i);
 
-   table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+   table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!table) {
ret = -ENOMEM;
goto out;
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] ion: remove duplicated clearing of sg_table initialization

2014-04-22 Thread Gioh Kim 
Thank you for your advice.
I sent the patch again.

> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, April 22, 2014 7:47 PM
> To: Gioh Kim
> Cc: 'Greg Kroah-Hartman'; 'John Stultz'; 'Rebecca Schultz Zavin'; 
> de...@driverdev.osuosl.org; �̰�ȣ
> Subject: Re: [PATCH] ion: remove duplicated clearing of sg_table 
> initialization
> 
> Patch is corrupt and doesn't apply.  Read Documentation/email-clients.txt
> or use git send-email.  Send it to yourself.  Save the raw email,
> including headers and everything, and `cat raw_email.txt | git am`.
> Review the changelog.  When it works then resend it to the list.
> 
> On Tue, Apr 22, 2014 at 05:27:04PM +0900, Gioh Kim wrote:
> > Hi,
> >
> > I found a duplicated zeroing at sg_table initialization in ION of linux-
> > 3.15.0-rc2 version.
> 
> Work against linux-next for this.
> 
> > Here is my patch.
> >
> > Subject: [PATCH] ion: remove duplicated clearing of sg_table initialization
> 
> Add the "Staging: android: " prefix.  You will have to make the subject
> shorter so it will fit.
> 
> [PATCH] Staging: android: ion:  duplicated clearing of sg_table
> 
> regards,
> dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-22 Thread navin patidar 
dan, It is ok to rearrange and remove members of  enum LED_STATE_871x
and  enum LED_CTL_MODE.
these enum are not related to firmware .

regards,
--navin-patidar

On Tue, Apr 22, 2014 at 4:05 PM, Dan Carpenter  wrote:
> It's ok to renumber all of these?  It's not something the firmware will
> care about?  Have you tested this?  Same for patch 10/10.
>
> (These questions are just questions.  I don't ask rhetorical questions
> on email.  I don't know the answers).
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread navin patidar 
On Tue, Apr 22, 2014 at 7:58 PM, Larry Finger  wrote:
>
> To me, the opposite case is true. If you have not tested, then you need to
> explicitly state "compile tested only" in the commit message. Without saying
> that, your signed-off-by is implying that you have tested, as well as
> declaring that you own the copyright to the material.

I didn't know that  signed-off-by implies both tested and authored.
thanks for clearing that up.

regards,
--navin-patidar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel