[PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
Signed-off-by: Avinash Kumar
---
drivers/staging/dgnc/dpacompat.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index f96963b..b451c10 100644
--- a/drivers/staging/dgnc/dpacompat.h
+++ b/drivers/staging/dgnc/dpacompat.h
@@ -24,7 +24,7 @@
* This structure holds data needed for the intelligent <--> nonintelligent
* DPA translation
*/
- struct ni_info {
+struct ni_info {
int board;
int channel;
int dtr;
@@ -51,7 +51,7 @@
#define RW_READ1
#define RW_WRITE2
-#define DIGI_KME('e'<<8) | 98 /* Read/Write Host */
+#define DIGI_KME(('e'<<8) | 98) /* Read/Write Host */
#define SUBTYPE 0007
#define T_PCXI
@@ -106,10 +106,10 @@
/* Ioctls needed for dpa operation */
-#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */
-#define DIGI_GETBD ('d'<<8) | 249 /* get board info */
-#define DIGI_GET_NI_INFO ('d'<<8) | 250/* nonintelligent state
snfo */
+#define DIGI_GETDD (('d'<<8) | 248) /* get driver info */
+#define DIGI_GETBD (('d'<<8) | 249) /* get board info */
+#define DIGI_GET_NI_INFO (('d'<<8) | 250) /* nonintelligent state snfo */
/* Other special ioctls */
-#define DIGI_TIMERIRQ ('d'<<8) | 251 /* Enable/disable RS_TIMER use
*/
-#define DIGI_LOOPBACK ('d'<<8) | 252 /* Enable/disable UART internal
loopback */
+#define DIGI_TIMERIRQ (('d'<<8) | 251)/* Enable/disable RS_TIMER use*/
+#define DIGI_LOOPBACK (('d'<<8) | 252)/* Enable/disable UART internal
loopback*/
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
On Thu, Jan 30, 2014 at 06:18:48PM +0530, Avinash kumar wrote: > drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings Which warnings? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
On Thu, Jan 30, 2014 at 07:52:27PM +0530, Avinash Kumar wrote: > Apologies for not including in the body of the email. Please resend this with the information properly in the patch changelog entry. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings
drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported
warnings
sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file
drivers/staging/dgnc/dpacompat.h
drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values should
be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values should
be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values should
be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values should
be enclosed in parenthesis
drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters
drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values should
be enclosed in parenthesis
total: 5 errors, 2 warnings, 115 lines checked
Signed-off-by: Avinash Kumar
---
drivers/staging/dgnc/dpacompat.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index f96963b..b451c10 100644
--- a/drivers/staging/dgnc/dpacompat.h
+++ b/drivers/staging/dgnc/dpacompat.h
@@ -24,7 +24,7 @@
* This structure holds data needed for the intelligent <--> nonintelligent
* DPA translation
*/
- struct ni_info {
+struct ni_info {
int board;
int channel;
int dtr;
@@ -51,7 +51,7 @@
#define RW_READ1
#define RW_WRITE2
-#define DIGI_KME('e'<<8) | 98 /* Read/Write Host */
+#define DIGI_KME(('e'<<8) | 98) /* Read/Write Host */
#define SUBTYPE 0007
#define T_PCXI
@@ -106,10 +106,10 @@
/* Ioctls needed for dpa operation */
-#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */
-#define DIGI_GETBD ('d'<<8) | 249 /* get board info */
-#define DIGI_GET_NI_INFO ('d'<<8) | 250/* nonintelligent state
snfo */
+#define DIGI_GETDD (('d'<<8) | 248) /* get driver info */
+#define DIGI_GETBD (('d'<<8) | 249) /* get board info */
+#define DIGI_GET_NI_INFO (('d'<<8) | 250) /* nonintelligent state snfo */
/* Other special ioctls */
-#define DIGI_TIMERIRQ ('d'<<8) | 251 /* Enable/disable RS_TIMER use
*/
-#define DIGI_LOOPBACK ('d'<<8) | 252 /* Enable/disable UART internal
loopback */
+#define DIGI_TIMERIRQ (('d'<<8) | 251)/* Enable/disable RS_TIMER use*/
+#define DIGI_LOOPBACK (('d'<<8) | 252)/* Enable/disable UART internal
loopback*/
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
imx-hdmi fails to build with v3.13-10094-g9b0cd30
Hi All,
After the DRM merge the imx-hdmi driver fails to build with the error
below. I'm somewhat surprised this wasn't hit in linux-next.
josh
drivers/staging/imx-drm/imx-hdmi.c:55:6: error: nested redefinition of
'enum hdmi_colorimetry'
enum hdmi_colorimetry {
^
drivers/staging/imx-drm/imx-hdmi.c:55:6: error: redeclaration of 'enum
hdmi_colorimetry'
In file included from include/drm/drm_crtc.h:33:0,
from include/drm/drmP.h:711,
from drivers/staging/imx-drm/imx-hdmi.c:24:
include/linux/hdmi.h:48:6: note: originally defined here
enum hdmi_colorimetry {
^
make[3]: *** [drivers/staging/imx-drm/imx-hdmi.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [drivers/staging/imx-drm] Error 2
make[1]: *** [drivers/staging] Error 2
make[1]: *** Waiting for unfinished jobs
make: *** [drivers] Error 2
+ exit 1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-hdmi fails to build with v3.13-10094-g9b0cd30
On Thu, Jan 30, 2014 at 5:28 PM, Josh Boyer wrote: > Hi All, > > After the DRM merge the imx-hdmi driver fails to build with the error > below. I'm somewhat surprised this wasn't hit in linux-next. > Sachin has already sent a patch to fix this issue: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-January/045167.html Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-hdmi fails to build with v3.13-10094-g9b0cd30
On Thu, Jan 30, 2014 at 2:31 PM, Fabio Estevam wrote: > On Thu, Jan 30, 2014 at 5:28 PM, Josh Boyer wrote: >> Hi All, >> >> After the DRM merge the imx-hdmi driver fails to build with the error >> below. I'm somewhat surprised this wasn't hit in linux-next. >> > > Sachin has already sent a patch to fix this issue: > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-January/045167.html Wonderful. Thanks for the quick response. Out of curiosity, was this hit in linux-next? Or is the config option not enabled in any of the configs built there? josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-hdmi fails to build with v3.13-10094-g9b0cd30
On Thu, Jan 30, 2014 at 5:33 PM, Josh Boyer wrote: > On Thu, Jan 30, 2014 at 2:31 PM, Fabio Estevam wrote: >> On Thu, Jan 30, 2014 at 5:28 PM, Josh Boyer >> wrote: >>> Hi All, >>> >>> After the DRM merge the imx-hdmi driver fails to build with the error >>> below. I'm somewhat surprised this wasn't hit in linux-next. >>> >> >> Sachin has already sent a patch to fix this issue: >> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-January/045167.html > > Wonderful. Thanks for the quick response. > > Out of curiosity, was this hit in linux-next? Or is the config option > not enabled in any of the configs built there? The imx-hdmi driver is not enabled in imx_v6_v7_defconfig yet. Russell King has a large series of patches for imx-drm that among other things, it will add the device tree pieces as well as select the imx-hdmi in imx_v6_v7_defconfig. Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:octeon-usb: Fixed Few coding style errors
fixed below errors - only few listed
octeon-hcd.c:162: ERROR: spaces prohibited around that ':' (ctx:WxW)
cteon-hcd.c:249: ERROR: Macros with complex values should be enclosed in
parenthesis
octeon-hcd.c:992: WARNING: braces {} are not necessary for single statement
blocks
octeon-hcd.c:3228: ERROR: return is not a function, parentheses are not required
Signed-off-by: Surendra Patil
---
drivers/staging/octeon-usb/octeon-hcd.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 47e0a91..b25e0f8 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -159,13 +159,13 @@ enum cvmx_usb_complete {
* status call.
*/
struct cvmx_usb_port_status {
- uint32_t reserved : 25;
- uint32_t port_enabled : 1;
- uint32_t port_over_current : 1;
- uint32_t port_powered : 1;
- enum cvmx_usb_speed port_speed : 2;
- uint32_t connected : 1;
- uint32_t connect_change : 1;
+ uint32_t reserved:25;
+ uint32_t port_enabled:1;
+ uint32_t port_over_current:1;
+ uint32_t port_powered:1;
+ enum cvmx_usb_speed port_speed:2;
+ uint32_t connected:1;
+ uint32_t connect_change:1;
};
/**
@@ -181,11 +181,11 @@ struct cvmx_usb_port_status {
union cvmx_usb_control_header {
uint64_t u64;
struct {
- uint64_t request_type : 8;
- uint64_t request: 8;
- uint64_t value : 16;
- uint64_t index : 16;
- uint64_t length : 16;
+ uint64_t request_type:8;
+ uint64_t request:8;
+ uint64_t value:16;
+ uint64_t index:16;
+ uint64_t length:16;
} s;
};
@@ -246,7 +246,7 @@ enum cvmx_usb_pipe_flags {
};
/* Normal prefetch that use the pref instruction. */
-#define CVMX_PREFETCH(address, offset) asm volatile ("pref %[type],
%[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n" (0))
+#define CVMX_PREFETCH(address, offset) (asm volatile ("pref %[type],
%[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n"
(0)))
/* Maximum number of times to retry failed transactions */
#define MAX_RETRIES3
@@ -989,9 +989,8 @@ static int cvmx_usb_enable(struct cvmx_usb_state *usb)
return 0;
/* If there is nothing plugged into the port then fail immediately */
- if (!usb->usbcx_hprt.s.prtconnsts) {
+ if (!usb->usbcx_hprt.s.prtconnsts)
return -ETIMEDOUT;
- }
/* Program the port reset bit to start the reset process */
USB_SET_FIELD32(CVMX_USBCX_HPRT(usb->index), union cvmx_usbcx_hprt,
prtrst, 1);
@@ -3225,7 +3224,7 @@ static int octeon_usb_hub_status_data(struct usb_hcd
*hcd, char *buf)
buf[0] = 0;
buf[0] = port_status.connect_change << 1;
- return (buf[0] != 0);
+ return buf[0] != 0;
}
static int octeon_usb_hub_control(struct usb_hcd *hcd, u16 typeReq, u16
wValue, u16 wIndex, char *buf, u16 wLength)
--
1.8.3.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] drivers:staging:octeon-usb: Fixed Bitfields coding style errors
Fixed Below coding style errors -
octeon-hcd.h:146: ERROR: spaces prohibited around that ':' (ctx:WxW)
octeon-hcd.h:147: ERROR: spaces prohibited around that ':' (ctx:WxW)
total: 243 errors, 0 warnings, 1819 lines checked - fixed all errors
Signed-off-by: Surendra Patil
---
drivers/staging/octeon-usb/octeon-hcd.h | 486
1 file changed, 243 insertions(+), 243 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.h
b/drivers/staging/octeon-usb/octeon-hcd.h
index 42fe4fe..c534e317 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.h
+++ b/drivers/staging/octeon-usb/octeon-hcd.h
@@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
* * 1'b1: Unmask the interrupt assertion to the application.
*/
struct cvmx_usbcx_gahbcfg_s {
- uint32_t reserved_9_31 : 23;
- uint32_t ptxfemplvl : 1;
- uint32_t nptxfemplvl: 1;
- uint32_t reserved_6_6 : 1;
- uint32_t dmaen : 1;
- uint32_t hbstlen: 4;
- uint32_t glblintrmsk: 1;
+ uint32_t reserved_9_31:23;
+ uint32_t ptxfemplvl:1;
+ uint32_t nptxfemplvl:1;
+ uint32_t reserved_6_6:1;
+ uint32_t dmaen:1;
+ uint32_t hbstlen:4;
+ uint32_t glblintrmsk:1;
} s;
};
@@ -209,16 +209,16 @@ union cvmx_usbcx_ghwcfg3 {
* * Others: Reserved
*/
struct cvmx_usbcx_ghwcfg3_s {
- uint32_t dfifodepth : 16;
- uint32_t reserved_13_15 : 3;
- uint32_t ahbphysync : 1;
- uint32_t rsttype: 1;
- uint32_t optfeature : 1;
- uint32_t vendor_control_interface_support : 1;
- uint32_t i2c_selection : 1;
- uint32_t otgen : 1;
- uint32_t pktsizewidth : 3;
- uint32_t xfersizewidth : 4;
+ uint32_t dfifodepth:16;
+ uint32_t reserved_13_15:3;
+ uint32_t ahbphysync:1;
+ uint32_t rsttype:1;
+ uint32_t optfeature:1;
+ uint32_t vendor_control_interface_support:1;
+ uint32_t i2c_selection:1;
+ uint32_t otgen:1;
+ uint32_t pktsizewidth:3;
+ uint32_t xfersizewidth:4;
} s;
};
@@ -275,38 +275,38 @@ union cvmx_usbcx_gintmsk {
* @modemismsk: Mode Mismatch Interrupt Mask (ModeMisMsk)
*/
struct cvmx_usbcx_gintmsk_s {
- uint32_t wkupintmsk : 1;
- uint32_t sessreqintmsk : 1;
- uint32_t disconnintmsk : 1;
- uint32_t conidstschngmsk: 1;
- uint32_t reserved_27_27 : 1;
- uint32_t ptxfempmsk : 1;
- uint32_t hchintmsk : 1;
- uint32_t prtintmsk : 1;
- uint32_t reserved_23_23 : 1;
- uint32_t fetsuspmsk : 1;
- uint32_t incomplpmsk: 1;
- uint32_t incompisoinmsk : 1;
- uint32_t oepintmsk : 1;
- uint32_t inepintmsk : 1;
- uint32_t epmismsk : 1;
- uint32_t reserved_16_16 : 1;
- uint32_t eopfmsk: 1;
- uint32_t isooutdropmsk : 1;
- uint32_t enumdonemsk: 1;
- uint32_t usbrstmsk : 1;
- uint32_t usbsuspmsk : 1;
- uint32_t erlysuspmsk: 1;
- uint32_t i2cint : 1;
- uint32_t ulpickintmsk : 1;
- uint32_t goutnakeffmsk : 1;
- uint32_t ginnakeffmsk : 1;
- uint32_t nptxfempmsk: 1;
- uint32_t rxflvlmsk : 1;
- uint32_t sofmsk : 1;
- uint32_t otgintmsk : 1;
- uint32_t modemismsk : 1;
- uint32_t reserved_0_0 : 1;
+ uint32_t wkupintmsk:1;
+ uint32_t sessreqintmsk:1;
+ uint32_t disconnintmsk:1;
+ uint32_t conidstschngmsk:1;
+ uint32_t reserved_27_27:1;
+ uint32_t ptxfempmsk:1;
+ uint32_t hchintmsk:1;
+ uint32_t prtintmsk:1;
+ uint32_t reserved_23_23:1;
+ uint32_t fetsuspmsk:1;
+ uint32_t incomplpmsk:1;
+ ui
