[PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c
This patch marks the function hv_synic_free_cpu() as static in hv.c
because it is not used outside this file.
Thus, it also eliminates the following warning in hv.c:
drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’
[-Wmissing-prototypes]
Signed-off-by: Rashika Kheria
---
drivers/hv/hv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index f0c5e07..bcb4950 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -301,7 +301,7 @@ err:
return -ENOMEM;
}
-void hv_synic_free_cpu(int cpu)
+static void hv_synic_free_cpu(int cpu)
{
kfree(hv_context.event_dpc[cpu]);
if (hv_context.synic_event_page[cpu])
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c
On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> This patch marks the function hv_synic_free_cpu() as static in hv.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in hv.c:
> drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/hv/hv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index f0c5e07..bcb4950 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -301,7 +301,7 @@ err:
> return -ENOMEM;
> }
>
> -void hv_synic_free_cpu(int cpu)
> +static void hv_synic_free_cpu(int cpu)
> {
> kfree(hv_context.event_dpc[cpu]);
> if (hv_context.synic_event_page[cpu])
> --
> 1.7.9.5
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c
> -Original Message-
> From: Josh Triplett [mailto:j...@joshtriplett.org]
> Sent: Saturday, December 14, 2013 12:57 PM
> To: Rashika Kheria
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan; Haiyang Zhang;
> de...@linuxdriverproject.org
> Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as
> static
> in hv.c
>
> On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> > This patch marks the function hv_synic_free_cpu() as static in hv.c
> > because it is not used outside this file.
> >
> > Thus, it also eliminates the following warning in hv.c:
> > drivers/hv/hv.c:304:6: warning: no previous prototype for
> > ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
>
> Reviewed-by: Josh Triplett
Thank you.
Signed-off-by: K. Y. Srinivasan
>
> > drivers/hv/hv.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index f0c5e07..bcb4950 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -301,7 +301,7 @@ err:
> > return -ENOMEM;
> > }
> >
> > -void hv_synic_free_cpu(int cpu)
> > +static void hv_synic_free_cpu(int cpu)
> > {
> > kfree(hv_context.event_dpc[cpu]);
> > if (hv_context.synic_event_page[cpu])
> > --
> > 1.7.9.5
> >
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/8] staging:bcm:InterfaceDld: fix checkpatch error
On Sat, Dec 14, 2013 at 4:41 AM, Dan Carpenter wrote:
> On Sat, Dec 14, 2013 at 01:05:29AM +0530, Gokulnath A wrote:
>> fixed all the errors found by checkpatch.pl
>>
>
> This is not very useful. The subjects of this patch series could be
> improved as well.
i will take care of it, in the next set of patches.
>
>> Signed-off-by: Gokulnath A
>> ---
>> drivers/staging/bcm/InterfaceDld.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/bcm/InterfaceDld.c
>> b/drivers/staging/bcm/InterfaceDld.c
>> index 463bdee..a8d0063 100644
>> --- a/drivers/staging/bcm/InterfaceDld.c
>> +++ b/drivers/staging/bcm/InterfaceDld.c
>> @@ -115,7 +115,7 @@ int InterfaceFileReadbackFromChip(PVOID arg, struct file
>> *flp, unsigned int on_c
>> while (len) {
>> if (*(unsigned int *)&buff_readback[len] !=
>> *(unsigned int *)&buff[len]) {
>>
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT,
>> DBG_LVL_ALL, "Firmware Download is not proper %d", fw_down);
>> -
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT,
>> DBG_LVL_ALL, "Val from Binary %x, Val From Read Back %x ", *(unsigned int
>> *)&buff[len], *(unsigned int*)&buff_readback[len]);
>> +
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT,
>> DBG_LVL_ALL, "Val from Binary %x, Val From Read Back %x ", *(unsigned int
>> *)&buff[len], *(unsigned int *)&buff_readback[len]);
>>
>> BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_INITEXIT, MP_INIT,
>> DBG_LVL_ALL, "len =%x!!!", len);
>
> Really this whole block of text is garbage. I'm not sure it makes sense
> to worry about a tiny missing space when the whole block is so rubbish.
> Fixing it up properly is a bit difficult, but it's really what we need.
i will cleanup the code, and send the patch.
Thanks for the review comments.
>
> regards,
> dan carpenter
>
>
Thanks and Regards
Gokulnath A
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
