[PATCH] Drivers: staging: ft1000-usb: ft1000_proc.c: fixed a few styling issues.
Fixed a few styling issues, particularly: Lines 36,42: Inserted a space before the open paranthesis. Line 50: Removed space between function name and open parenthesis. Lines 56,57: Removed trailing whitespace. lines: 130, 133: Replaced spaces with tabs for identation. Signed-off-by: Aldo Iljazi --- drivers/staging/ft1000/ft1000-usb/ft1000_proc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c index 5ead942..2575d0d 100644 --- a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c @@ -33,13 +33,13 @@ #define seq_putx(m, message, size, var) \ seq_printf(m, message); \ - for(i = 0; i < (size - 1); i++) \ + for (i = 0; i < (size - 1); i++) \ seq_printf(m, "%02x:", var[i]); \ seq_printf(m, "%02x\n", var[i]) #define seq_putd(m, message, size, var) \ seq_printf(m, message); \ - for(i = 0; i < (size - 1); i++) \ + for (i = 0; i < (size - 1); i++) \ seq_printf(m, "%d.", var[i]); \ seq_printf(m, "%d\n", var[i]) @@ -47,14 +47,14 @@ #define FTNET_PROC init_net.proc_net -int ft1000_read_dpram16 (struct ft1000_usb *ft1000dev, u16 indx, +int ft1000_read_dpram16(struct ft1000_usb *ft1000dev, u16 indx, u8 *buffer, u8 highlow); static int ft1000ReadProc(struct seq_file *m, void *v) { - static const char *status[] = { - "Idle (Disconnect)", + static const char *status[] = { + "Idle (Disconnect)", "Searching", "Active (Connected)", "Waiting for L2", @@ -127,10 +127,10 @@ static int ft1000ReadProc(struct seq_file *m, void *v) } seq_printf(m, "Connection Time: %02ld:%02ld:%02ld\n", - ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60)); + ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60)); seq_printf(m, "Connection Time[s]: %ld\n", delta); seq_printf(m, "Asic ID: %s\n", - (info->AsicID) == ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE ASIC"); + (info->AsicID) == ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE ASIC"); seq_putx(m, "SKU: ", SKUSZ, info->Sku); seq_putx(m, "EUI64: ", EUISZ, info->eui64); seq_putd(m, "DSP version number: ", DSPVERSZ, info->DspVer); -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 21/31] staging: nvec: use reset framework
On Friday 15 November 2013 13:54:16 Stephen Warren wrote: > From: Stephen Warren > > Tegra's clock driver now provides an implementation of the common > reset API (include/linux/reset.h). Use this instead of the old Tegra- > specific API; that will soon be removed. > > Cc: tred...@nvidia.com > Cc: pdeschrij...@nvidia.com > Cc: linux-te...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: Julian Andres Klode > Cc: Marc Dietrich > Cc: ac...@lists.launchpad.net > Cc: Greg Kroah-Hartman > Cc: de...@driverdev.osuosl.org > Signed-off-by: Stephen Warren Acked-by: Marc Dietrich > --- > This patch is part of a series with strong internal depdendencies. I'm > looking for an ack so that I can take the entire series through the Tegra > and arm-soc trees. The series will be part of a stable branch that can be > merged into other subsystems if needed to avoid/resolve dependencies. > --- > drivers/staging/nvec/nvec.c | 11 --- > drivers/staging/nvec/nvec.h | 5 - > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 3066ee2e753b..9de4cd13d9ab 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -36,7 +36,6 @@ > #include > #include > #include > -#include > > #include "nvec.h" > > @@ -733,9 +732,9 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) > > clk_prepare_enable(nvec->i2c_clk); > > - tegra_periph_reset_assert(nvec->i2c_clk); > + reset_control_assert(nvec->rst); > udelay(2); > - tegra_periph_reset_deassert(nvec->i2c_clk); > + reset_control_deassert(nvec->rst); > > val = I2C_CNFG_NEW_MASTER_SFM | I2C_CNFG_PACKET_MODE_EN | > (0x2 << I2C_CNFG_DEBOUNCE_CNT_SHIFT); > @@ -836,6 +835,12 @@ static int tegra_nvec_probe(struct platform_device > *pdev) return -ENODEV; > } > > + nvec->rst = devm_reset_control_get(&pdev->dev, "i2c"); > + if (IS_ERR(nvec->rst)) { > + dev_err(nvec->dev, "failed to get controller reset\n"); > + return PTR_ERR(nvec->rst); > + } > + > nvec->base = base; > nvec->irq = res->start; > nvec->i2c_clk = i2c_clk; > diff --git a/drivers/staging/nvec/nvec.h b/drivers/staging/nvec/nvec.h > index e880518935fb..e271375053fa 100644 > --- a/drivers/staging/nvec/nvec.h > +++ b/drivers/staging/nvec/nvec.h > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -109,7 +110,8 @@ struct nvec_msg { > * @irq: The IRQ of the I2C device > * @i2c_addr: The address of the I2C slave > * @base: The base of the memory mapped region of the I2C device > - * @clk: The clock of the I2C device > + * @i2c_clk: The clock of the I2C device > + * @rst: The reset of the I2C device > * @notifier_list: Notifiers to be called on received messages, see > * nvec_register_notifier() > * @rx_data: Received messages that have to be processed > @@ -139,6 +141,7 @@ struct nvec_chip { > int i2c_addr; > void __iomem *base; > struct clk *i2c_clk; > + struct reset_control *rst; > struct atomic_notifier_head notifier_list; > struct list_head rx_data, tx_data; > struct notifier_block nvec_status_notifier; ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel