[PATCH] drivers: staging: rtl8188eu: use 'ccflags-y' instead of EXTRA_CFLAGS in Makefile

2013-10-23 Thread Chen Gang 
If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
for arc architecture, with allmodconfig), it can not pass compiling,
the related error:

  drivers/staging/rtl8188eu/core/rtw_ap.c:22:27: fatal error: osdep_service.h: 
No such file or directory


Signed-off-by: Chen Gang 
---
 drivers/staging/rtl8188eu/Makefile |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rtl8188eu/Makefile 
b/drivers/staging/rtl8188eu/Makefile
index 1639a45..385fce1 100644
--- a/drivers/staging/rtl8188eu/Makefile
+++ b/drivers/staging/rtl8188eu/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -I$(src)/include
+ccflags-y += -I$(src)/include
 
 r8188eu-y :=   \
core/rtw_ap.o   \
-- 
1.7.7.6
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Patch v2][ 03/37] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-10-23 Thread Ville Syrjälä 
On Wed, Oct 23, 2013 at 04:48:51PM +0200, Denis Carikli wrote:
> Hi,
> 
> On 10/18/2013 09:46 AM, Ville Syrjälä wrote:
> >> +#define DRM_MODE_FLAG_PDATEN  (1<<22)
> >> +#define DRM_MODE_FLAG_NDATEN  (1<<23)
> >> +#define DRM_MODE_FLAG_PPIXDATEDGE (1<<24)
> >> +#define DRM_MODE_FLAG_NPIXDATEDGE (1<<25)
> >
> > Do we really need to make this stuff visible to userspace?
> > And there's no documentation to explain any of it.
> 
> DRM_MODE_FLAG_PDATEN and DRM_MODE_FLAG_NDATEN were meant to represent 
> the data enable polarity.
> 
> DRM_MODE_FLAG_PPIXDATEDGE and DRM_MODE_FLAG_NPIXDATEDGE were meant to 
> represent the clock polarity.
> 
> What would you recommend to represent theses polarities?

I don't really care that much how you represent them. Just wondering
if userspace has any business dictating those, and it not, then they
shouldn't be DRM_MODE flags.

-- 
Ville Syrjälä
Intel OTC
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: rtl8188eu: use 'ccflags-y' instead of EXTRA_CFLAGS in Makefile

2013-10-23 Thread Larry Finger 

On 10/23/2013 03:52 AM, Chen Gang wrote:

If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
for arc architecture, with allmodconfig), it can not pass compiling,
the related error:

   drivers/staging/rtl8188eu/core/rtw_ap.c:22:27: fatal error: osdep_service.h: 
No such file or directory


Signed-off-by: Chen Gang 


The build fails for x86_64 if EXTRA_CFLAGS is added to the command line. I learn 
something new every day.


Your change is correct, but as we already have an addition to ccflags-y at the 
end of Makefile, I would prefer that the new one be combined with the old. The 
patch would look something like


diff --git a/drivers/staging/rtl8188eu/Makefile 
b/drivers/staging/rtl8188eu/Makefile
index 1639a45..d1173ab 100644
--- a/drivers/staging/rtl8188eu/Makefile
+++ b/drivers/staging/rtl8188eu/Makefile
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -I$(src)/include
-
 r8188eu-y :=   \
core/rtw_ap.o   \
core/rtw_br_ext.o   \
@@ -67,4 +65,4 @@ r8188eu-y :=  \

 obj-$(CONFIG_R8188EU)  := r8188eu.o

-ccflags-y += -D__CHECK_ENDIAN__
+ccflags-y += -D__CHECK_ENDIAN__ -I$(src)/include

With that change, you may add

Acked-by: Larry Finger 

Thanks,

Larry

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Patch v2][ 03/37] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-10-23 Thread Matt Sealey 
On Thu, Oct 17, 2013 at 10:02 AM, Denis Carikli  wrote:
> Without that fix, drivers using the drm_display_mode_from_videomode
>   function will not be able to get certain information because
>   some DISPLAY_FLAGS_* have no corresponding DRM_MODE_FLAG_*.
>
> Cc: Greg Kroah-Hartman 
> Cc: driverdev-devel@linuxdriverproject.org
> Cc: David Airlie 
> Cc: dri-de...@lists.freedesktop.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: Fabio Estevam 
> Cc: Sascha Hauer 
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: Eric Bénard 
> Signed-off-by: Denis Carikli 
> ---
>  drivers/gpu/drm/drm_modes.c |9 +
>  include/uapi/drm/drm_mode.h |4 
>  2 files changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index b073315..353aaae 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -537,6 +537,15 @@ int drm_display_mode_from_videomode(const struct 
> videomode *vm,
> dmode->flags |= DRM_MODE_FLAG_DBLSCAN;
> if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
> dmode->flags |= DRM_MODE_FLAG_DBLCLK;
> +   if (vm->flags & DISPLAY_FLAGS_DE_LOW)
> +   dmode->flags |= DRM_MODE_FLAG_NDATEN;
> +   if (vm->flags & DISPLAY_FLAGS_DE_HIGH)
> +   dmode->flags |= DRM_MODE_FLAG_PDATEN;
> +   if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE)
> +   dmode->flags |= DRM_MODE_FLAG_PPIXDATEDGE;
> +   if (vm->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
> +   dmode->flags |= DRM_MODE_FLAG_NPIXDATEDGE;

Is there any reason these aren't named after the original
DISPLAY_FLAGS? DRM_MODE_FLAG_PIXDATA_POSEDGE is easier to get your
head around if you know it is mapped from the DISPLAY_FLAGS_ version.
PDATEN and PPIXDATEDGE don't exactly map to things like EDID field
names either..

> +#define DRM_MODE_FLAG_PPIXDATEDGE  (1<<24)
> +#define DRM_MODE_FLAG_NPIXDATEDGE  (1<<25)

-- 
Matt Sealey 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Patch v2][ 03/37] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-10-23 Thread Denis Carikli 

Hi,

On 10/18/2013 09:46 AM, Ville Syrjälä wrote:

+#define DRM_MODE_FLAG_PDATEN   (1<<22)
+#define DRM_MODE_FLAG_NDATEN   (1<<23)
+#define DRM_MODE_FLAG_PPIXDATEDGE  (1<<24)
+#define DRM_MODE_FLAG_NPIXDATEDGE  (1<<25)


Do we really need to make this stuff visible to userspace?
And there's no documentation to explain any of it.


DRM_MODE_FLAG_PDATEN and DRM_MODE_FLAG_NDATEN were meant to represent 
the data enable polarity.


DRM_MODE_FLAG_PPIXDATEDGE and DRM_MODE_FLAG_NPIXDATEDGE were meant to 
represent the clock polarity.


What would you recommend to represent theses polarities?

Denis.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] drivers: staging: bcm: Removed a developer debug statement.

2013-10-23 Thread Chuong Ngo 
Removed a developer debug statement per the TODO list.  Additionally, removed 
braces for the if-statement to match coding style.

Signed-off-by: Chuong Ngo 
---
 drivers/staging/bcm/Bcmchar.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index f91bc1f..41554c8 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -49,11 +49,8 @@ static int bcm_char_release(struct inode *inode, struct file 
*filp)
 
pTarang = (struct bcm_tarang_data *)filp->private_data;
 
-   if (pTarang == NULL) {
-   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
-   "ptarang is null\n");
+   if (pTarang == NULL)
return 0;
-   }
 
Adapter = pTarang->Adapter;
 
-- 
1.8.4.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 7/8] staging: Remove OOM message after input_allocate_device

2013-10-23 Thread Joe Perches 
Emitting an OOM message isn't necessary after input_allocate_device
as there's a generic OOM and a dump_stack already done.

Signed-off-by: Joe Perches 
---
 drivers/staging/cptm1217/clearpad_tm1217.c| 2 --
 drivers/staging/iio/adc/mxs-lradc.c   | 4 +---
 drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 --
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c 
b/drivers/staging/cptm1217/clearpad_tm1217.c
index 42a5f5c..ca4c2c6 100644
--- a/drivers/staging/cptm1217/clearpad_tm1217.c
+++ b/drivers/staging/cptm1217/clearpad_tm1217.c
@@ -457,8 +457,6 @@ static int cp_tm1217_probe(struct i2c_client *client,
for (i = 0; i < TOUCH_SUPPORTED; i++) {
input_dev = input_allocate_device();
if (input_dev == NULL) {
-   dev_err(ts->dev,
-   "cp_tm1217:Input Device Struct alloc failed\n");
retval = -ENOMEM;
goto fail;
}
diff --git a/drivers/staging/iio/adc/mxs-lradc.c 
b/drivers/staging/iio/adc/mxs-lradc.c
index 9da64bf..696fbb3 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -529,10 +529,8 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
return 0;
 
input = input_allocate_device();
-   if (!input) {
-   dev_err(dev, "Failed to allocate TS device!\n");
+   if (!input)
return -ENOMEM;
-   }
 
input->name = DRIVER_NAME;
input->id.bustype = BUS_HOST;
diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c 
b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
index 386362c..28b3930 100644
--- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
+++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
@@ -911,8 +911,6 @@ static int synaptics_rmi4_probe
 
rmi4_data->input_dev = input_allocate_device();
if (rmi4_data->input_dev == NULL) {
-   dev_err(&client->dev, "%s:input device alloc failed\n",
-   __func__);
retval = -ENOMEM;
goto err_input;
}
-- 
1.8.1.2.459.gbcd45b4.dirty

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: bcm: Removed a developer debug statement.

2013-10-23 Thread Dan Carpenter 
On Wed, Oct 23, 2013 at 03:11:20PM -0400, Chuong Ngo wrote:
> Removed a developer debug statement per the TODO list.  Additionally, removed 
> braces for the if-statement to match coding style.

Line wrap the changelog at 72 characters.  You don't really need to
mention the removed braces because that's too obvious to bother
commenting on.

My guess is that Greg will probably be willing to apply this as is so
don't worry about resending unless he requests it.  (He normally seems
to let newbies get by with one line wrapping warning before he starts
making you redo it).

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: rtl8188eu: use 'ccflags-y' instead of EXTRA_CFLAGS in Makefile

2013-10-23 Thread Larry Finger 
On 10/23/2013 08:10 PM, Chen Gang wrote:
> On 10/24/2013 12:06 AM, Larry Finger wrote:
>> On 10/23/2013 03:52 AM, Chen Gang wrote:
>>> If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
>>> for arc architecture, with allmodconfig), it can not pass compiling,
>>> the related error:
>>>
>>> drivers/staging/rtl8188eu/core/rtw_ap.c:22:27: fatal error:
>>> osdep_service.h: No such file or directory
>>>
>>>
>>> Signed-off-by: Chen Gang 
>>
>> The build fails for x86_64 if EXTRA_CFLAGS is added to the command line.
>> I learn something new every day.
>>
>> Your change is correct, but as we already have an addition to ccflags-y
>> at the end of Makefile, I would prefer that the new one be combined with
>> the old. The patch would look something like
>>
>> diff --git a/drivers/staging/rtl8188eu/Makefile
>> b/drivers/staging/rtl8188eu/Makefile
>> index 1639a45..d1173ab 100644
>> --- a/drivers/staging/rtl8188eu/Makefile
>> +++ b/drivers/staging/rtl8188eu/Makefile
>> @@ -1,5 +1,3 @@
>> -EXTRA_CFLAGS += -I$(src)/include
>> -
>>   r8188eu-y :=   \
>>  core/rtw_ap.o   \
>>  core/rtw_br_ext.o   \
>> @@ -67,4 +65,4 @@ r8188eu-y :=  \
>>
>>   obj-$(CONFIG_R8188EU)  := r8188eu.o
>>
>> -ccflags-y += -D__CHECK_ENDIAN__
>> +ccflags-y += -D__CHECK_ENDIAN__ -I$(src)/include
>>
>> With that change, you may add
>>
>> Acked-by: Larry Finger 
>>
> 
> Oh, sorry, it is my careless fault, it should be what you said.
> 
> If need let me send patch v2 again, please let me know.

Yes, please do.

Larry


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: rtl8188eu: use 'ccflags-y' instead of EXTRA_CFLAGS in Makefile

2013-10-23 Thread Chen Gang 
On 10/24/2013 12:06 AM, Larry Finger wrote:
> On 10/23/2013 03:52 AM, Chen Gang wrote:
>> If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
>> for arc architecture, with allmodconfig), it can not pass compiling,
>> the related error:
>>
>>drivers/staging/rtl8188eu/core/rtw_ap.c:22:27: fatal error:
>> osdep_service.h: No such file or directory
>>
>>
>> Signed-off-by: Chen Gang 
> 
> The build fails for x86_64 if EXTRA_CFLAGS is added to the command line.
> I learn something new every day.
> 
> Your change is correct, but as we already have an addition to ccflags-y
> at the end of Makefile, I would prefer that the new one be combined with
> the old. The patch would look something like
> 
> diff --git a/drivers/staging/rtl8188eu/Makefile
> b/drivers/staging/rtl8188eu/Makefile
> index 1639a45..d1173ab 100644
> --- a/drivers/staging/rtl8188eu/Makefile
> +++ b/drivers/staging/rtl8188eu/Makefile
> @@ -1,5 +1,3 @@
> -EXTRA_CFLAGS += -I$(src)/include
> -
>  r8188eu-y :=   \
> core/rtw_ap.o   \
> core/rtw_br_ext.o   \
> @@ -67,4 +65,4 @@ r8188eu-y :=  \
> 
>  obj-$(CONFIG_R8188EU)  := r8188eu.o
> 
> -ccflags-y += -D__CHECK_ENDIAN__
> +ccflags-y += -D__CHECK_ENDIAN__ -I$(src)/include
> 
> With that change, you may add
> 
> Acked-by: Larry Finger 
> 

Oh, sorry, it is my careless fault, it should be what you said.

If need let me send patch v2 again, please let me know.

> Thanks,
> 
> Larry
> 
> 
> 

Thanks.
-- 
Chen Gang
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/8] treewide: Remove OOM message after input_alloc_device

2013-10-23 Thread Joe Perches 
Joe Perches (8):
  Documentation: Remove OOM message after input_allocate_device
  cell: Remove OOM message after input_allocate_device
  hid: Remove OOM message after input_allocate_device
  input: Remove OOM message after input_allocate_device
  media: Remove OOM message after input_allocate_device
  platform:x86: Remove OOM message after input_allocate_device
  staging: Remove OOM message after input_allocate_device
  sound: Remove OOM message after input_allocate_device

 Documentation/input/input-programming.txt | 1 -
 arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
 drivers/hid/hid-input.c   | 1 -
 drivers/hid/hid-picolcd_core.c| 5 ++---
 drivers/input/joystick/as5011.c   | 2 --
 drivers/input/joystick/db9.c  | 1 -
 drivers/input/joystick/gamecon.c  | 4 +---
 drivers/input/joystick/turbografx.c   | 1 -
 drivers/input/joystick/walkera0701.c  | 1 -
 drivers/input/keyboard/amikbd.c   | 4 +---
 drivers/input/keyboard/davinci_keyscan.c  | 1 -
 drivers/input/keyboard/gpio_keys.c| 1 -
 drivers/input/keyboard/lpc32xx-keys.c | 1 -
 drivers/input/keyboard/max7359_keypad.c   | 1 -
 drivers/input/keyboard/mcs_touchkey.c | 1 -
 drivers/input/keyboard/mpr121_touchkey.c  | 1 -
 drivers/input/keyboard/nomadik-ske-keypad.c   | 1 -
 drivers/input/keyboard/opencores-kbd.c| 1 -
 drivers/input/keyboard/pmic8xxx-keypad.c  | 1 -
 drivers/input/keyboard/pxa27x_keypad.c| 1 -
 drivers/input/keyboard/pxa930_rotary.c| 1 -
 drivers/input/keyboard/qt1070.c   | 1 -
 drivers/input/keyboard/qt2160.c   | 1 -
 drivers/input/keyboard/sh_keysc.c | 1 -
 drivers/input/keyboard/tc3589x-keypad.c   | 1 -
 drivers/input/keyboard/tnetv107x-keypad.c | 1 -
 drivers/input/keyboard/w90p910_keypad.c   | 1 -
 drivers/input/misc/88pm80x_onkey.c| 1 -
 drivers/input/misc/88pm860x_onkey.c   | 1 -
 drivers/input/misc/arizona-haptics.c  | 4 +---
 drivers/input/misc/atlas_btns.c   | 4 +---
 drivers/input/misc/da9052_onkey.c | 1 -
 drivers/input/misc/da9055_onkey.c | 4 +---
 drivers/input/misc/ideapad_slidebar.c | 1 -
 drivers/input/misc/ims-pcu.c  | 7 +--
 drivers/input/misc/kxtj9.c| 4 +---
 drivers/input/misc/max8997_haptic.c   | 1 -
 drivers/input/misc/mc13783-pwrbutton.c| 4 +---
 drivers/input/misc/mpu3050.c  | 1 -
 drivers/input/misc/pcf8574_keypad.c   | 1 -
 drivers/input/misc/pm8xxx-vibrator.c  | 1 -
 drivers/input/misc/pmic8xxx-pwrkey.c  | 1 -
 drivers/input/misc/pwm-beeper.c   | 1 -
 drivers/input/misc/twl4030-pwrbutton.c| 4 +---
 drivers/input/misc/twl6040-vibra.c| 1 -
 drivers/input/mouse/appletouch.c  | 4 +---
 drivers/input/mouse/bcm5974.c | 4 +---
 drivers/input/mouse/cyapa.c   | 4 +---
 drivers/input/mouse/inport.c  | 1 -
 drivers/input/mouse/logibm.c  | 1 -
 drivers/input/mouse/pc110pad.c| 1 -
 drivers/input/mouse/pxa930_trkball.c  | 1 -
 drivers/input/tablet/aiptek.c | 5 +
 drivers/input/tablet/gtco.c   | 1 -
 drivers/input/touchscreen/88pm860x-ts.c   | 1 -
 drivers/input/touchscreen/atmel_mxt_ts.c  | 1 -
 drivers/input/touchscreen/atmel_tsadcc.c  | 1 -
 drivers/input/touchscreen/bu21013_ts.c| 1 -
 drivers/input/touchscreen/cyttsp4_core.c  | 2 --
 drivers/input/touchscreen/da9034-ts.c | 1 -
 drivers/input/touchscreen/edt-ft5x06.c| 1 -
 drivers/input/touchscreen/eeti_ts.c   | 5 +
 drivers/input/touchscreen/htcpen.c| 1 -
 drivers/input/touchscreen/intel-mid-touch.c   | 1 -
 drivers/input/touchscreen/lpc32xx_ts.c| 1 -
 drivers/input/touchscreen/mcs5000_ts.c| 1 -
 drivers/input/touchscreen/migor_ts.c  | 1 -
 drivers/input/touchscreen/mk712.c | 1 -
 drivers/input/touchscreen/pixcir_i2c_ts.c | 1 -
 drivers/input/touchscreen/s3c2410_ts.c| 1 -
 drivers/input/touchscreen/ti_am335x_tsc.c | 1 -
 drivers/input/touchscreen/tnetv107x-ts.c  | 1 -
 drivers/media/rc/imon.c   | 8 ++--
 drivers/media/usb/em28xx/em28xx-input.c   | 4 +---
 drivers/media/usb/pwc/pwc-if.c| 1 -
 drivers/platform/x86/asus-laptop.c| 5 ++---
 drivers/platform/x86/eeepc-laptop.c   | 4 +---
 drivers/platform/x86/ideapad-laptop.c | 4 +---
 drivers/platform/x86/intel_mid_powerbtn.c | 4 +---
 drivers/platform/x86/panasonic-laptop.c   | 5 +
 drivers/platform/x86/thinkpad_acpi.c  | 1 -
 drivers/platform/x86/topstar-laptop.c | 4 +---
 drivers/platform/x86/toshiba_acpi.c   | 4 +---
 drivers/staging/cptm1217/clearpad

[PATCH v2] drivers: staging: rtl8188eu: use 'ccflags-y' instead of EXTRA_CFLAGS in Makefile

2013-10-23 Thread Chen Gang 
If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
for arc architecture, with allmodconfig), it can not pass compiling,
the related error:

  drivers/staging/rtl8188eu/core/rtw_ap.c:22:27: fatal error: osdep_service.h: 
No such file or directory


Signed-off-by: Chen Gang 
Acked-by: Larry Finger 
---
 drivers/staging/rtl8188eu/Makefile |4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/Makefile 
b/drivers/staging/rtl8188eu/Makefile
index 0bd32de..0a617b4 100644
--- a/drivers/staging/rtl8188eu/Makefile
+++ b/drivers/staging/rtl8188eu/Makefile
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -I$(src)/include
-
 r8188eu-y :=   \
core/rtw_ap.o   \
core/rtw_br_ext.o   \
@@ -66,4 +64,4 @@ r8188eu-y :=  \
 
 obj-$(CONFIG_R8188EU)  := r8188eu.o
 
-ccflags-y += -D__CHECK_ENDIAN__
+ccflags-y += -D__CHECK_ENDIAN__ -I$(src)/include
-- 
1.7.7.6
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH NEXT 1/5] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

2013-10-23 Thread Larry Finger 
Sparse checking results in the following warnings:

  CHECK   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes 
address space of expression
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3935:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3935:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3935:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3937:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3937:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3937:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3939:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3939:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3939:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3941:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3941:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3941:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3944:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3944:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3944:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3946:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3946:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3946:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38: warning: incorrect type 
in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:expected void const 
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:got void [noderef] 
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3963:9: warning: cast removes 
address space of expression

Signed-off-by: Larry Finger 
---
 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c 
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index ae54587..5dc3fed 100644
--- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
@@ -3929,24 +3929,24 @@ static int rtw_p2p_get(struct net_device *dev,
struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
 
if (padapter->bShowGetP2PState)
-   DBG_88E("[%s] extra = %s\n", __func__, (char 
*)wrqu->data.pointer);
-   if (!memcmp(wrqu->data.pointer, "status", 6)) {
+   DBG_88E("[%s] extra = %s\n", __func__, (__force char 
*)wrqu->data.pointer);
+   if (!memcmp((__force const char *)wrqu->data.pointer, "status", 6)) {
rtw_p2p_get_status(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "role", 4)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, "role", 
4)) {
rtw_p2p_get_role(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "peer_ifa", 8)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, 
"peer_ifa", 8)) {
rtw_p2p_get_peer_ifaddr(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "req_cm", 6)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, "req_cm", 
6)) {
rtw_p2p_get_req_cm(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "peer_deva", 9)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, 
"peer_deva", 9)) {
/*  Get the P2P device address when receiving the provision 
discovery request frame. */
rtw_p2p_get_peer_devaddr(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "group_id", 8)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, 
"group_id", 8)) {
rtw_p2p_get_groupid(dev, info, wrqu, extra);
-   } else if (!memcmp(wrqu->data.pointer, "peer_deva_inv", 9)) {
+   } else if (!memcmp((__force const char *)wrqu->data.pointer, 
"peer_deva_inv", 9)) {
/*  Get the P2P de

[PATCH NEXT 5/5] staging: r8188eu: Fix sparse warnings in rtl_p2p.c

2013-10-23 Thread Larry Finger 
Sparse displays the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_p2p.c
drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15:expected unsigned short 
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15:expected unsigned short 
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15:expected unsigned short 
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:expected unsigned short 
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:got restricted __le16 
*

Signed-off-by: Larry Finger 
---
 drivers/staging/rtl8188eu/core/rtw_p2p.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_p2p.c 
b/drivers/staging/rtl8188eu/core/rtw_p2p.c
index 8cf915f..f46cab1 100644
--- a/drivers/staging/rtl8188eu/core/rtw_p2p.c
+++ b/drivers/staging/rtl8188eu/core/rtw_p2p.c
@@ -135,7 +135,7 @@ static void issue_group_disc_req(struct wifidirect_info 
*pwdinfo, u8 *da)
struct pkt_attrib   *pattrib;
unsigned char   *pframe;
struct rtw_ieee80211_hdr*pwlanhdr;
-   unsigned short  *fctrl;
+   __le16 *fctrl;
struct adapter *padapter = pwdinfo->padapter;
struct xmit_priv*pxmitpriv = 
&(padapter->xmitpriv);
struct mlme_ext_priv*pmlmeext = &(padapter->mlmeextpriv);
@@ -192,7 +192,7 @@ static void issue_p2p_devdisc_resp(struct wifidirect_info 
*pwdinfo, u8 *da, u8 s
struct pkt_attrib   *pattrib;
unsigned char   *pframe;
struct rtw_ieee80211_hdr*pwlanhdr;
-   unsigned short  *fctrl;
+   __le16 *fctrl;
struct adapter *padapter = pwdinfo->padapter;
struct xmit_priv*pxmitpriv = 
&(padapter->xmitpriv);
struct mlme_ext_priv*pmlmeext = &(padapter->mlmeextpriv);
@@ -272,7 +272,7 @@ static void issue_p2p_provision_resp(struct wifidirect_info 
*pwdinfo, u8 *raddr,
struct pkt_attrib   *pattrib;
unsigned char   *pframe;
struct rtw_ieee80211_hdr*pwlanhdr;
-   unsigned short  *fctrl;
+   __le16 *fctrl;
struct xmit_priv*pxmitpriv = 
&(padapter->xmitpriv);
struct mlme_ext_priv*pmlmeext = &(padapter->mlmeextpriv);
 
@@ -342,7 +342,7 @@ static void issue_p2p_presence_resp(struct wifidirect_info 
*pwdinfo, u8 *da, u8
struct pkt_attrib   *pattrib;
unsigned char   *pframe;
struct rtw_ieee80211_hdr*pwlanhdr;
-   unsigned short  *fctrl;
+   __le16 *fctrl;
struct adapter *padapter = pwdinfo->padapter;
struct xmit_priv*pxmitpriv = 
&(padapter->xmitpriv);
struct mlme_ext_priv*pmlmeext = &(padapter->mlmeextpriv);
-- 
1.8.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH NEXT 4/5] staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c

2013-10-23 Thread Larry Finger 
Sparse displays the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15:got restricted __le16 
*
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15: warning: incorrect type 
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15:expected unsigned 
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15:got re

[PATCH 0/5 NEXT V2] staging: r8188eu: Fix sparse warnings.

2013-10-23 Thread Larry Finger 
This set of patches resubmits the set of fixes for sparse warnings. The two that
were criticized have been removed, and this set should not have white-space
damage.

Signed-off-by: Larry Finger 


Larry Finger (5):
  staging: r8188eu: Fix sparse warnings in ioctl_linux.c
  staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c
  staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c
  staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c
  staging: r8188eu: Fix sparse warnings in rtl_p2p.c

 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c  | 41 +-
 drivers/staging/rtl8188eu/core/rtw_p2p.c   |  8 ++---
 drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c   |  8 ++---
 drivers/staging/rtl8188eu/include/ieee80211.h  | 16 +-
 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 20 ++---
 6 files changed, 47 insertions(+), 46 deletions(-)

-- 
1.8.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH NEXT 3/5] staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c

2013-10-23 Thread Larry Finger 
Sparse displays the following:

  CHECK   drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:got restricted __le16 
*
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:got restricted __le16 
*
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:got restricted __le16 
*
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:got restricted __le16 
*

Signed-off-by: Larry Finger 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 0b0c68c..8be2ad7 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -273,7 +273,7 @@ void rtl8188e_set_FwMediaStatus_cmd(struct adapter *adapt, 
__le16 mstatus_rpt)
 static void ConstructBeacon(struct adapter *adapt, u8 *pframe, u32 *pLength)
 {
struct rtw_ieee80211_hdr*pwlanhdr;
-   u16 *fctrl;
+   __le16 *fctrl;
u32 rate_len, pktlen;
struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
struct mlme_ext_info*pmlmeinfo = &(pmlmeext->mlmext_info);
@@ -360,7 +360,7 @@ static void ConstructPSPoll(struct adapter *adapt, u8 
*pframe, u32 *pLength)
struct rtw_ieee80211_hdr*pwlanhdr;
struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
struct mlme_ext_info*pmlmeinfo = &(pmlmeext->mlmext_info);
-   u16 *fctrl;
+   __le16 *fctrl;
 
pwlanhdr = (struct rtw_ieee80211_hdr *)pframe;
 
@@ -391,7 +391,7 @@ static void ConstructNullFunctionData(struct adapter 
*adapt, u8 *pframe,
u8 bForcePowerSave)
 {
struct rtw_ieee80211_hdr*pwlanhdr;
-   u16 *fctrl;
+   __le16 *fctrl;
u32 pktlen;
struct mlme_priv *pmlmepriv = &adapt->mlmepriv;
struct wlan_network *cur_network = &pmlmepriv->cur_network;
@@ -450,7 +450,7 @@ static void ConstructNullFunctionData(struct adapter 
*adapt, u8 *pframe,
 static void ConstructProbeRsp(struct adapter *adapt, u8 *pframe, u32 *pLength, 
u8 *StaAddr, bool bHideSSID)
 {
struct rtw_ieee80211_hdr*pwlanhdr;
-   u16 *fctrl;
+   __le16 *fctrl;
u8 *mac, *bssid;
u32 pktlen;
struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
-- 
1.8.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH NEXT 2/5] staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c

2013-10-23 Thread Larry Finger 
Sparse reports the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to 
restricted __le16

Signed-off-by: Larry Finger 
---
 drivers/staging/rtl8188eu/include/ieee80211.h | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h 
b/drivers/staging/rtl8188eu/include/ieee80211.h
index cd37ea4..c4d38d1 100644
--- a/drivers/staging/rtl8188eu/include/ieee80211.h
+++ b/drivers/staging/rtl8188eu/include/ieee80211.h
@@ -306,8 +306,8 @@ struct ieee_ibss_seq {
 };
 
 struct rtw_ieee80211_hdr {
-   u16 frame_ctl;
-   u16 duration_id;
+   __le16 frame_ctl;
+   __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
@@ -316,8 +316,8 @@ struct rtw_ieee80211_hdr {
 } __packed;
 
 struct rtw_ieee80211_hdr_3addr {
-   u16 frame_ctl;
-   u16 duration_id;
+   __le16 frame_ctl;
+   __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
@@ -325,8 +325,8 @@ struct rtw_ieee80211_hdr_3addr {
 } __packed;
 
 struct rtw_ieee80211_hdr_qos {
-   u16 frame_ctl;
-   u16 duration_id;
+   __le16 frame_ctl;
+   __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
@@ -336,8 +336,8 @@ struct rtw_ieee80211_hdr_qos {
 }  __packed;
 
 struct rtw_ieee80211_hdr_3addr_qos {
-   u16 frame_ctl;
-   u16 duration_id;
+   __le16 frame_ctl;
+   __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
-- 
1.8.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] Staging: vt6656: fix code indenting error in power.c

2013-10-23 Thread Johannes Löthberg 
This patch fixes a code indentation error found by checkpatch.pl
where a line was indented with spaces instead of tabs

Signed-off-by: Johannes Löthberg 
---
 drivers/staging/vt6656/power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index 3002061..a14a2bf 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
+ sizeof(struct vnt_tx_mgmt));
 
flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
-WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
+   WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
 
if (pDevice->bEnablePSMode)
flags |= WLAN_SET_FC_PWRMGT(1);
-- 
1.8.4.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/2] Staging: vt6656: fix two coding style issues

2013-10-23 Thread Johannes Löthberg 
This patchset fixes two coding style issues reported by checkpatch.pl in
drivers/staging/vt6656, one warning and one error

Johannes Löthberg (2):
  Staging: vt6656: fix a brace coding style issue in power.c
  Staging: vt6656: fix code indenting error in power.c

 drivers/staging/vt6656/power.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
1.8.4.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c

2013-10-23 Thread Johannes Löthberg 
This patch fixes a brace warning in power.c found by checkpatch.pl

Signed-off-by: Johannes Löthberg 
---
 drivers/staging/vt6656/power.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index edc8975..3002061 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -233,9 +233,8 @@ void PSvSendPSPOLL(struct vnt_private *pDevice)
pTxPacket->cbPayloadLen = 0;
 
/* log failure if sending failed */
-   if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING) {
+   if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING)
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send PS-Poll packet 
failed..\n");
-   }
 }
 
 /*
-- 
1.8.4.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel