[PATCH] Staging: android: Fix timed_gpio_probe() 'ret' value in case of NULL platform_data
From: Elad Wexler 'timed_gpio_probe()' shall return -ENXIO (no such address or device) in case of NULL platform data. -EBUSY doesn't reflect this error. Signed-off-by: Elad Wexler --- drivers/staging/android/timed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index e814514..964a03a 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/timed_gpio.c @@ -88,7 +88,7 @@ static int timed_gpio_probe(struct platform_device *pdev) int i, ret; if (!pdata) - return -EBUSY; + return -ENXIO; gpio_data = kzalloc(sizeof(struct timed_gpio_data) * pdata->num_gpios, GFP_KERNEL); -- 1.8.3.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
(X)Ubuntu Bug 1218995: Hyper-V Synthetic Video Frame Buffer Driver not working
Hi, I encountered a possible bug with the hyperv_fb module. After verifying that the bug is not caused by Ubuntu kernel patches, I have been guided to report the bug here. I hope this information can help to solve the problem. I am running Xubuntu 13.10 in a Hyper-V machine on Windows 8 Pro. According to the kernel module description the kernel driver should allow for FullHD resoltuion and should eliminate the double mouse courser. Here neither of that happens though, screen resolution is limited to 1152x864 like it was with 13.04 before the framebuffer driver was added and I still have double mouse coursers. lsmod verifies hyperv_fb module to be loaded. So there must be something which stops the enhancements from working correctly. I am running the current 3.11 vanilla kernel, so the problem is not caused by any Ubuntu specific patches. Downstream bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1218995 Below you find some technical information (collected according to the guide from https://wiki.ubuntu.com/Bugs/Upstream/kernel): jan@XubuntuVM-Jan-Desktop:~$ cat /proc/version Linux version 3.11.0-031100-generic (apw@gomeisa) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #201309021735 SMP Mon Sep 2 21:36:21 UTC 2013 jan@XubuntuVM-Jan-Desktop:~$ lsb_release -rd Description:Ubuntu Saucy Salamander (development branch) Release:13.10 jan@XubuntuVM-Jan-Desktop:/usr/src/linux-headers-3.11.0-031100/scripts$ sh ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux XubuntuVM-Jan-Desktop 3.11.0-031100-generic #201309021735 SMP Mon Sep 2 21:36:21 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux Gnu C 4.8 Gnu make 3.81 binutils 2.23.52.20130828 util-linux 2.20.1 mount support module-init-tools 9 e2fsprogs 1.42.8 pcmciautils018 PPP2.4.5 Linux C Library2.17 Dynamic linker (ldd) 2.17 Procps 3.3.3 Net-tools 1.60 Kbd1.15.5 Sh-utils 8.20 wireless-tools 30 Modules Loaded rfcomm bnep bluetooth parport_pc ppdev psmouse hid_generic joydev hid_hyperv serio_raw lp microcode hid hyperv_fb hv_balloon parport i2c_piix4 mac_hid hv_netvsc hv_utils hv_storvsc hv_vmbus floppy jan@XubuntuVM-Jan-Desktop:~$ cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 30 model name : Intel(R) Core(TM) i5 CPU 750 @ 2.67GHz stepping: 5 microcode : 0x cpu MHz : 2659.988 cache size : 8192 KB fpu : yes fpu_exception : yes cpuid level : 11 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx lm constant_tsc rep_good nopl pni ssse3 cx16 sse4_1 sse4_2 popcnt hypervisor lahf_lm bogomips: 5319.97 clflush size: 64 cache_alignment : 64 address sizes : 36 bits physical, 48 bits virtual power management: jan@XubuntuVM-Jan-Desktop:~$ cat /proc/modules rfcomm 74589 4 - Live 0x bnep 23966 2 - Live 0x bluetooth 391564 10 rfcomm,bnep, Live 0x parport_pc 32866 0 - Live 0x ppdev 17711 0 - Live 0x psmouse 104064 0 - Live 0x hid_generic 12548 0 - Live 0x joydev 17613 0 - Live 0x hid_hyperv 13207 0 - Live 0x serio_raw 13413 0 - Live 0x lp 17799 0 - Live 0x microcode 23650 0 - Live 0x hid 105557 2 hid_generic,hid_hyperv, Live 0x hyperv_fb 17514 1 - Live 0x hv_balloon 21788 0 [permanent], Live 0x parport 42466 3 parport_pc,ppdev,lp, Live 0x i2c_piix4 22299 0 - Live 0x mac_hid 13253 0 - Live 0x hv_netvsc 31648 0 - Live 0x hv_utils 18348 0 - Live 0x hv_storvsc 22328 2 - Live 0x hv_vmbus 48391 6 hid_hyperv,hyperv_fb,hv_balloon,hv_netvsc,hv_utils,hv_storvsc, Live 0x floppy 70206 0 - Live 0x jan@XubuntuVM-Jan-Desktop:~$ cat /proc/ioports -0cf7 : PCI Bus :00 -001f : dma1 0020-0021 : pic1 0022-0022 : ACPI PM2_CNT_BLK 0040-0043 : timer0 0050-0053 : timer1 0060-0060 : keyboard 0064-0064 : keyboard 0070-0071 : rtc0 0080-008f : dma page reg 00a0-00a1 : pic2 00c0-00df : dma2 00f0-00ff : fpu 0160-016f : pnp 00:09 0170-0177 : :00:07.1 0170-0177 : ata_piix 01e0-01ef : pnp 00:09 01f0-01f7 : :00:07.1 01f0-01f7 : ata_piix 0278-027f : pnp 00:09 02f8-02ff : serial 0370-0371 : pnp 00:0a 0376-0376 : :00:07.1 0376-0376 : ata_piix 0378-037f : pnp 00:09 03f2-03f2 : flop
[PATCH] staging: lustre: Fix typo in lustre/llite
Correct spelling typo in lustre/llite
Correct double words "to to"
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c| 6 +++---
drivers/staging/lustre/lustre/llite/llite_close.c | 2 +-
drivers/staging/lustre/lustre/llite/statahead.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index 09844be..28fe04e 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -743,7 +743,7 @@ int ll_dir_setstripe(struct inode *inode, struct
lov_user_md *lump,
/* In the following we use the fact that LOV_USER_MAGIC_V1 and
LOV_USER_MAGIC_V3 have the same initial fields so we do not
-need the make the distiction between the 2 versions */
+need the make the distinction between the 2 versions */
if (set_default && mgc->u.cli.cl_mgc_mgsexp) {
char *param = NULL;
char *buf;
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/lustre/lustre/llite/file.c
index bc534db..8c4b4fa 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -364,7 +364,7 @@ static int ll_intent_file_open(struct file *file, void *lmm,
that case that lock is also ok */
/* We can also get here if there was cached open handle in revalidate_it
* but it disappeared while we were getting from there to ll_file_open.
-* But this means this file was closed and immediatelly opened which
+* But this means this file was closed and immediately opened which
* makes a good candidate for using OPEN lock */
/* If lmmsize & lmm are not 0, we are just setting stripe info
* parameters. No need for the open lock */
@@ -2456,8 +2456,8 @@ static int ll_inode_revalidate_fini(struct inode *inode,
int rc)
if (rc == -ENOENT) {
clear_nlink(inode);
/* This path cannot be hit for regular files unless in
-* case of obscure races, so no need to to validate
-* size. */
+* case of obscure races, so no need to validate size.
+*/
if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return 0;
} else if (rc != 0) {
diff --git a/drivers/staging/lustre/lustre/llite/llite_close.c
b/drivers/staging/lustre/lustre/llite/llite_close.c
index 1f5825c..e2996c4 100644
--- a/drivers/staging/lustre/lustre/llite/llite_close.c
+++ b/drivers/staging/lustre/lustre/llite/llite_close.c
@@ -159,7 +159,7 @@ void ll_ioepoch_close(struct inode *inode, struct
md_op_data *op_data,
}
if (flags & LLIF_DONE_WRITING) {
/* Some pages are still dirty, it is early to send
-* DONE_WRITE. Wait untill all pages will be flushed
+* DONE_WRITE. Wait until all pages will be flushed
* and try DONE_WRITE again later. */
LASSERT(!(lli->lli_flags & LLIF_DONE_WRITING));
lli->lli_flags |= LLIF_DONE_WRITING;
diff --git a/drivers/staging/lustre/lustre/llite/statahead.c
b/drivers/staging/lustre/lustre/llite/statahead.c
index 8eaa38e9..f6b5f4b9 100644
--- a/drivers/staging/lustre/lustre/llite/statahead.c
+++ b/drivers/staging/lustre/lustre/llite/statahead.c
@@ -647,7 +647,7 @@ static void ll_post_statahead(struct ll_statahead_info *sai)
*/
LASSERT(fid_is_zero(&minfo->mi_data.op_fid2));
- /* XXX: No fid in reply, this is probaly cross-ref case.
+ /* XXX: No fid in reply, this is probably cross-ref case.
* SA can't handle it yet. */
if (body->valid & OBD_MD_MDS)
GOTO(out, rc = -EAGAIN);
--
1.8.4.273.ga194ead
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: lustre: Fix typo in lustre/llite
On 09/14/13 19:00, Masanari Iida wrote:
> Correct spelling typo in lustre/llite
> Correct double words "to to"
>
>
> diff --git a/drivers/staging/lustre/lustre/llite/dir.c
> b/drivers/staging/lustre/lustre/llite/dir.c
> index 09844be..28fe04e 100644
> --- a/drivers/staging/lustre/lustre/llite/dir.c
> +++ b/drivers/staging/lustre/lustre/llite/dir.c
> @@ -743,7 +743,7 @@ int ll_dir_setstripe(struct inode *inode, struct
> lov_user_md *lump,
>
> /* In the following we use the fact that LOV_USER_MAGIC_V1 and
>LOV_USER_MAGIC_V3 have the same initial fields so we do not
> - need the make the distiction between the 2 versions */
> + need the make the distinction between the 2 versions */
to make
> if (set_default && mgc->u.cli.cl_mgc_mgsexp) {
> char *param = NULL;
> char *buf;
--
~Randy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH/v2] staging: lustre: Fix typo in lustre/llite
Correct spelling typo in lustre/llite
Correct double words "to to"
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c| 6 +++---
drivers/staging/lustre/lustre/llite/llite_close.c | 2 +-
drivers/staging/lustre/lustre/llite/statahead.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index 09844be..1f07903 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -743,7 +743,7 @@ int ll_dir_setstripe(struct inode *inode, struct
lov_user_md *lump,
/* In the following we use the fact that LOV_USER_MAGIC_V1 and
LOV_USER_MAGIC_V3 have the same initial fields so we do not
-need the make the distiction between the 2 versions */
+need to make the distinction between the 2 versions */
if (set_default && mgc->u.cli.cl_mgc_mgsexp) {
char *param = NULL;
char *buf;
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/lustre/lustre/llite/file.c
index bc534db..8c4b4fa 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -364,7 +364,7 @@ static int ll_intent_file_open(struct file *file, void *lmm,
that case that lock is also ok */
/* We can also get here if there was cached open handle in revalidate_it
* but it disappeared while we were getting from there to ll_file_open.
-* But this means this file was closed and immediatelly opened which
+* But this means this file was closed and immediately opened which
* makes a good candidate for using OPEN lock */
/* If lmmsize & lmm are not 0, we are just setting stripe info
* parameters. No need for the open lock */
@@ -2456,8 +2456,8 @@ static int ll_inode_revalidate_fini(struct inode *inode,
int rc)
if (rc == -ENOENT) {
clear_nlink(inode);
/* This path cannot be hit for regular files unless in
-* case of obscure races, so no need to to validate
-* size. */
+* case of obscure races, so no need to validate size.
+*/
if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return 0;
} else if (rc != 0) {
diff --git a/drivers/staging/lustre/lustre/llite/llite_close.c
b/drivers/staging/lustre/lustre/llite/llite_close.c
index 1f5825c..e2996c4 100644
--- a/drivers/staging/lustre/lustre/llite/llite_close.c
+++ b/drivers/staging/lustre/lustre/llite/llite_close.c
@@ -159,7 +159,7 @@ void ll_ioepoch_close(struct inode *inode, struct
md_op_data *op_data,
}
if (flags & LLIF_DONE_WRITING) {
/* Some pages are still dirty, it is early to send
-* DONE_WRITE. Wait untill all pages will be flushed
+* DONE_WRITE. Wait until all pages will be flushed
* and try DONE_WRITE again later. */
LASSERT(!(lli->lli_flags & LLIF_DONE_WRITING));
lli->lli_flags |= LLIF_DONE_WRITING;
diff --git a/drivers/staging/lustre/lustre/llite/statahead.c
b/drivers/staging/lustre/lustre/llite/statahead.c
index 8eaa38e9..f6b5f4b9 100644
--- a/drivers/staging/lustre/lustre/llite/statahead.c
+++ b/drivers/staging/lustre/lustre/llite/statahead.c
@@ -647,7 +647,7 @@ static void ll_post_statahead(struct ll_statahead_info *sai)
*/
LASSERT(fid_is_zero(&minfo->mi_data.op_fid2));
- /* XXX: No fid in reply, this is probaly cross-ref case.
+ /* XXX: No fid in reply, this is probably cross-ref case.
* SA can't handle it yet. */
if (body->valid & OBD_MD_MDS)
GOTO(out, rc = -EAGAIN);
--
1.8.4.273.ga194ead
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: lustre: lustre/libcfs
Correct spelling typo in luster/libcfs
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/libcfs/hash.c| 2 +-
drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 2 +-
drivers/staging/lustre/lustre/libcfs/prng.c| 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c
b/drivers/staging/lustre/lustre/libcfs/hash.c
index 0dd12c8..29ce380 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -1965,7 +1965,7 @@ cfs_hash_rehash_worker(cfs_workitem_t *wi)
if (bkts != NULL)
cfs_hash_buckets_free(bkts, bsize, new_size, old_size);
if (rc != 0)
- CDEBUG(D_INFO, "early quit of of rehashing: %d\n", rc);
+ CDEBUG(D_INFO, "early quit of rehashing: %d\n", rc);
/* return 1 only if cfs_wi_exit is called */
return rc == -ESRCH;
}
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
b/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
index ea9e949..6a26c66 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
@@ -167,7 +167,7 @@ static int cfs_access_process_vm(struct task_struct *tsk,
unsigned long addr,
return 0;
down_read(&mm->mmap_sem);
- /* ignore errors, just check how much was sucessfully transfered */
+ /* ignore errors, just check how much was successfully transferred */
while (len) {
int bytes, rc, offset;
void *maddr;
diff --git a/drivers/staging/lustre/lustre/libcfs/prng.c
b/drivers/staging/lustre/lustre/libcfs/prng.c
index 69224d8..f87e9e5 100644
--- a/drivers/staging/lustre/lustre/libcfs/prng.c
+++ b/drivers/staging/lustre/lustre/libcfs/prng.c
@@ -70,7 +70,7 @@ static unsigned int seed_y = 362436069;
* cfs_rand - creates new seeds
*
* First it creates new seeds from the previous seeds. Then it generates a
- * new psuedo random number for use.
+ * new pseudo random number for use.
*
* Returns a pseudo-random 32-bit integer
*/
@@ -84,7 +84,7 @@ unsigned int cfs_rand(void)
EXPORT_SYMBOL(cfs_rand);
/**
- * cfs_srand - sets the inital seed
+ * cfs_srand - sets the initial seed
* @seed1 : (seed_x) should have the most entropy in the low bits of the word
* @seed2 : (seed_y) should have the most entropy in the high bits of the word
*
--
1.8.4.273.ga194ead
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH/v2] staging: lustre: Fix typo in lustre/libcfs
Correct spelling typos in comment and debug message,
within luster/libcfs
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/libcfs/hash.c| 2 +-
drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 2 +-
drivers/staging/lustre/lustre/libcfs/prng.c| 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c
b/drivers/staging/lustre/lustre/libcfs/hash.c
index 0dd12c8..29ce380 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -1965,7 +1965,7 @@ cfs_hash_rehash_worker(cfs_workitem_t *wi)
if (bkts != NULL)
cfs_hash_buckets_free(bkts, bsize, new_size, old_size);
if (rc != 0)
- CDEBUG(D_INFO, "early quit of of rehashing: %d\n", rc);
+ CDEBUG(D_INFO, "early quit of rehashing: %d\n", rc);
/* return 1 only if cfs_wi_exit is called */
return rc == -ESRCH;
}
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
b/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
index ea9e949..6a26c66 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c
@@ -167,7 +167,7 @@ static int cfs_access_process_vm(struct task_struct *tsk,
unsigned long addr,
return 0;
down_read(&mm->mmap_sem);
- /* ignore errors, just check how much was sucessfully transfered */
+ /* ignore errors, just check how much was successfully transferred */
while (len) {
int bytes, rc, offset;
void *maddr;
diff --git a/drivers/staging/lustre/lustre/libcfs/prng.c
b/drivers/staging/lustre/lustre/libcfs/prng.c
index 69224d8..f87e9e5 100644
--- a/drivers/staging/lustre/lustre/libcfs/prng.c
+++ b/drivers/staging/lustre/lustre/libcfs/prng.c
@@ -70,7 +70,7 @@ static unsigned int seed_y = 362436069;
* cfs_rand - creates new seeds
*
* First it creates new seeds from the previous seeds. Then it generates a
- * new psuedo random number for use.
+ * new pseudo random number for use.
*
* Returns a pseudo-random 32-bit integer
*/
@@ -84,7 +84,7 @@ unsigned int cfs_rand(void)
EXPORT_SYMBOL(cfs_rand);
/**
- * cfs_srand - sets the inital seed
+ * cfs_srand - sets the initial seed
* @seed1 : (seed_x) should have the most entropy in the low bits of the word
* @seed2 : (seed_y) should have the most entropy in the high bits of the word
*
--
1.8.4.273.ga194ead
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
