[regression] [git pull] drm for 4.3
On Wed, Sep 23, 2015 at 11:07:56AM +, Lankhorst, Maarten wrote: > Hey, > > Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]: > > On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote: > > > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote: > > > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote: > > > > > Cc'ing Maarten and Matt; I'm guessing this may be related to one of > > > > > their recent patches. > > > > > > Sounds like this showed up before my recent work, but I think I might > > > have seen similar problems while working on atomic watermarks; the > > > issues I was seeing were because the initial hardware readout could > > > leave primary->visible set to true even when the CRTC was off. My > > > series (which is still under development) contains this patch to fix > > > that: > > > > > > http://patchwork.freedesktop.org/patch/59564/ > > > > > > Does applying that help with the problems reported here? > > > > No difference at all for me. > Looks like a (reopened) dup of 91952? > > Can you apply "[PATCH] drm/i915: Add primary plane to mask if it's > visible", and get me the results? This doesn't apply on top of Linus' current tree. If you let me know what it's dependant on, I'll do a build with those patches tomorrow. Dave
[regression] [git pull] drm for 4.3
On Thu, Sep 24, 2015 at 04:26:28PM +0300, Jani Nikula wrote:
> On Thu, 24 Sep 2015, "davej at codemonkey.org.uk" codemonkey.org.uk> wrote:
> > On Wed, Sep 23, 2015 at 11:07:56AM +, Lankhorst, Maarten wrote:
> > > Hey,
> > >
> > > Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]:
> > > > On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote:
> > > > > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote:
> > > > > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote:
> > > > > > > Cc'ing Maarten and Matt; I'm guessing this may be related to
> > one of
> > > > > > > their recent patches.
> > > > >
> > > > > Sounds like this showed up before my recent work, but I think I
> > might
> > > > > have seen similar problems while working on atomic watermarks; the
> > > > > issues I was seeing were because the initial hardware readout could
> > > > > leave primary->visible set to true even when the CRTC was off. My
> > > > > series (which is still under development) contains this patch to
> > fix
> > > > > that:
> > > > >
> > > > > http://patchwork.freedesktop.org/patch/59564/
> > > > >
> > > > > Does applying that help with the problems reported here?
> > > >
> > > > No difference at all for me.
> > > Looks like a (reopened) dup of 91952?
> > >
> > > Can you apply "[PATCH] drm/i915: Add primary plane to mask if it's
> > > visible", and get me the results?
> >
> > This doesn't apply on top of Linus' current tree.
> > If you let me know what it's dependant on, I'll do a build with
> > those patches tomorrow.
>
> It's now part of the drm-intel-fixes pull request [1], maybe it's
> easiest to pull that in? Just four commits on top of
> v4.3-rc2. Alternatively pick it up from our repo [2].
The warning on boot seems to be gone as of rc3, but I can now trigger this
pretty easily..
WARNING: CPU: 2 PID: 28911 at drivers/gpu/drm/drm_atomic.c:889
drm_atomic_get_property+0x244/0x2d0()
CPU: 2 PID: 28911 Comm: trinity-c313 Not tainted 4.3.0-rc3-think+ #14
0379 8801a1377c88 8e35d5ec
8801a1377cc0 8e07a862 880500b392b8 880500a13008
880500b39290 8804fe3806d8 88003fa45668 8801a1377cd0
Call Trace:
[] dump_stack+0x4e/0x82
[] warn_slowpath_common+0x82/0xc0
[] warn_slowpath_null+0x1a/0x20
[] drm_atomic_get_property+0x244/0x2d0
[] drm_object_property_get_value+0x6c/0x70
[] dpms_show+0x2f/0x70
[] dev_attr_show+0x20/0x50
[] ? sysfs_file_ops+0x41/0x60
[] sysfs_kf_seq_show+0xb7/0x110
[] kernfs_seq_show+0x26/0x30
[] seq_read+0xe6/0x430
[] kernfs_fop_read+0x127/0x170
[] ? mutex_lock_nested+0x26b/0x3f0
[] __vfs_read+0x28/0xe0
[] ? mutex_lock_nested+0x287/0x3f0
[] ? __fdget_pos+0x49/0x50
[] ? __fdget_pos+0x49/0x50
[] vfs_read+0x86/0x130
[] SyS_read+0x49/0xb0
[] entry_SYSCALL_64_fastpath+0x12/0x6f
---[ end trace e053063c697a1355 ]---
887 case DRM_MODE_OBJECT_CONNECTOR: {
888 struct drm_connector *connector = obj_to_connector(obj);
889
WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
890 ret = drm_atomic_connector_get_property(connector,
891 connector->state, property, val);
892 break;
893 }
[regression] [git pull] drm for 4.3
On Wed, Sep 30, 2015 at 08:56:26AM +0200, Daniel Vetter wrote:
> > The warning on boot seems to be gone as of rc3, but I can now trigger this
> > pretty easily..
>
> http://patchwork.freedesktop.org/patch/60618/
Back from several weeks of travel.. I tried again with rc6, and
I'm still seeing the same traces.
Dave
> > WARNING: CPU: 2 PID: 28911 at drivers/gpu/drm/drm_atomic.c:889
> > drm_atomic_get_property+0x244/0x2d0()
> > CPU: 2 PID: 28911 Comm: trinity-c313 Not tainted 4.3.0-rc3-think+ #14
> > 0379 8801a1377c88 8e35d5ec
> > 8801a1377cc0 8e07a862 880500b392b8 880500a13008
> > 880500b39290 8804fe3806d8 88003fa45668 8801a1377cd0
> > Call Trace:
> > [] dump_stack+0x4e/0x82
> > [] warn_slowpath_common+0x82/0xc0
> > [] warn_slowpath_null+0x1a/0x20
> > [] drm_atomic_get_property+0x244/0x2d0
> > [] drm_object_property_get_value+0x6c/0x70
> > [] dpms_show+0x2f/0x70
> > [] dev_attr_show+0x20/0x50
> > [] ? sysfs_file_ops+0x41/0x60
> > [] sysfs_kf_seq_show+0xb7/0x110
> > [] kernfs_seq_show+0x26/0x30
> > [] seq_read+0xe6/0x430
> > [] kernfs_fop_read+0x127/0x170
> > [] ? mutex_lock_nested+0x26b/0x3f0
> > [] __vfs_read+0x28/0xe0
> > [] ? mutex_lock_nested+0x287/0x3f0
> > [] ? __fdget_pos+0x49/0x50
> > [] ? __fdget_pos+0x49/0x50
> > [] vfs_read+0x86/0x130
> > [] SyS_read+0x49/0xb0
> > [] entry_SYSCALL_64_fastpath+0x12/0x6f
> > ---[ end trace e053063c697a1355 ]---
> >
> > 887 case DRM_MODE_OBJECT_CONNECTOR: {
> > 888 struct drm_connector *connector =
> > obj_to_connector(obj);
> > 889
> > WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
> > 890 ret = drm_atomic_connector_get_property(connector,
> > 891 connector->state, property, val);
> > 892 break;
> > 893 }
> >
> > ___
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
---end quoted text---
[Intel-gfx] [regression] [git pull] drm for 4.3
On Tue, Oct 20, 2015 at 03:33:27PM +1000, Dave Airlie wrote: > On 20 October 2015 at 07:54, Daniel Vetter wrote: > > On Mon, Oct 19, 2015 at 04:19:08PM -0400, davej at codemonkey.org.uk wrote: > >> On Wed, Sep 30, 2015 at 08:56:26AM +0200, Daniel Vetter wrote: > >> > >> > > The warning on boot seems to be gone as of rc3, but I can now > >> trigger this pretty easily.. > >> > > >> > http://patchwork.freedesktop.org/patch/60618/ > >> > >> Back from several weeks of travel.. I tried again with rc6, and > >> I'm still seeing the same traces. > > > > Oh crap, applied patch to wrong tree. We need to cherry-pick > > > > commit 621bd0f6982badd6483acb191eb7b6226a578328 > > Author: Daniel Vetter > > Date: Tue Sep 29 09:56:53 2015 +0200 > > > > drm: Fix locking for sysfs dpms file > > > > to drm-fixes. Sorry about that screw-up. Dave, can you pls do that one? It > > even comes with the needed cc: stable included (since the locking breakage > > was done in 4.0, it only surface due to a new warning in 4.3). > > That is already in Linus's tree, I picked it last week I think. Yeah, that's in the tree I'm testing. Dave
