Re: drm core/helpers and MIT license
Hi Daniel, I don't think we can make any complaints about GPL being more widely used in the DRM code. It's nice to have the code at all, the MIT license is a bonus. Thanks for writing it and bearing with us. Would rewrites done purely for licensing reasons be accepted upstream? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 3/3] drm/vmwgfx: Correct typo in comment
On Wed, Feb 26, 2020 at 04:07:39PM +0100, Thomas Hellström (VMware) wrote: > On 2/23/20 9:40 PM, Maya Rashish wrote: > > Signed-off-by: Maya Rashish > > Signed-off-by: Thomas Klausner > > Co-authored-by: Thomas Klausner > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > > b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > > index f47d5710cc95..5195c19d25a4 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > > @@ -2016,7 +2016,7 @@ void vmw_disable_vblank(struct drm_device *dev, > > unsigned int pipe) > >* plugin and generate DRM uevent > >* @dev_priv: device private > >* @num_rects: number of drm_rect in rects > > - * @rects: toplogy to update > > + * @rects: topology to update > >*/ > > static int vmw_du_update_layout(struct vmw_private *dev_priv, > > unsigned int num_rects, struct drm_rect *rects) > > Reviewed-by: Thomas Hellstrom > > I'll include in the next vmwgfx-next pull request. > > Out of curiosity, how was this patch co-authored :-) ? > > Thanks, > > Thomas > Hi Thomas, We have a local fork of the drm subsystem & drivers. I went over the local diffs to see if any of them are of interest to upstream. The commit was done to the fork by someone who immediately forgot about it and didn't send a patch upstream himself. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] Remove redundant memclear
drmMalloc will zero out the memory for us
---
xf86drm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 2ac3f26..879f85b 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -866,8 +866,6 @@ drmVersionPtr drmGetVersion(int fd)
drmVersionPtr retval;
drm_version_t *version = drmMalloc(sizeof(*version));
-memclear(*version);
-
if (drmIoctl(fd, DRM_IOCTL_VERSION, version)) {
drmFreeKernelVersion(version);
return NULL;
--
2.13.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer
It's GCC's -Wpointer-arith.
I'm stealing your code for another project that happened to have it on
by default. I'm trying to look for opportunities to contribute back
positive changes :-)
On Wed, May 23, 2018 at 11:09:28AM +0200, Daniel Vetter wrote:
> On Tue, May 22, 2018 at 11:33:35AM +0300, Jani Nikula wrote:
> > On Mon, 21 May 2018, Maya Rashish wrote:
> > > In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't
> > > legal for void *.
> >
> > Well, this isn't pedantic C, it's GCC. There are tons of pointer
> > arithmetics for void pointers all over the kernel.
>
> I thought C99 even deprecated char * as the generic pointer, recommending
> void * instead, which guarantees the exact same pointer arithmetic as char
> * (but has the special casting rules).
>
> Which static checker came up with this?
> -Daniel
>
> >
> > BR,
> > Jani.
> >
> > > ---
> > > include/drm/drm_dp_helper.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > > index 62903bae..06f9a61f 100644
> > > --- a/include/drm/drm_dp_helper.h
> > > +++ b/include/drm/drm_dp_helper.h
> > > @@ -1058,7 +1058,7 @@ struct drm_dp_aux_msg {
> > > unsigned int address;
> > > u8 request;
> > > u8 reply;
> > > - void *buffer;
> > > + char *buffer;
> > > size_t size;
> > > };
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
> > ___
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
