Re: [PATCH v3 12/17] dt-bindings: usb-switch: Extend for DisplayPort altmode
On Mon, 19 Aug 2024 15:38:26 -0700, Stephen Boyd wrote: > Extend the usb-switch binding to support DisplayPort (DP) alternate > modes. A third port for the DP signal is necessary when a mode-switch is > muxing USB and DP together onto a usb type-c connector. Add data-lanes > to the usbc output node to allow a device using this binding to remap > the data lanes on the output. Add an example to show how this new port > can be used. > > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: Benson Leung > Cc: Guenter Roeck > Cc: Prashant Malani > Cc: Tzung-Bi Shih > Cc: > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd > --- > .../devicetree/bindings/usb/usb-switch.yaml | 90 +++++++ > 1 file changed, 90 insertions(+) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb
On Mon, 19 Aug 2024 15:38:27 -0700, Stephen Boyd wrote:
> This binding is about USB type-c control. Move the binding to the usb
> directory as it's a better home than chrome.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leung
> Cc: Guenter Roeck
> Cc: Prashant Malani
> Cc: Tzung-Bi Shih
> Cc:
> Cc:
> Cc: Pin-yen Lin
> Suggested-by: Krzysztof Kozlowski
> Signed-off-by: Stephen Boyd
> ---
> Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +-
> .../bindings/{chrome => usb}/google,cros-ec-typec.yaml| 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> rename Documentation/devicetree/bindings/{chrome =>
> usb}/google,cros-ec-typec.yaml (90%)
>
Reviewed-by: Rob Herring (Arm)
Re: [PATCH v3 14/17] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode
On Mon, 19 Aug 2024 15:38:28 -0700, Stephen Boyd wrote: > Add a DT graph binding to google,cros-ec-typec so that it can combine > DisplayPort (DP) and USB SuperSpeed (SS) data into a USB type-c endpoint > that is connected to the usb-c-connector node's SS endpoint. This also > allows us to connect the DP and USB nodes in the graph to the USB type-c > connectors, providing the full picture of the USB type-c data flows in > the system. > > Allow there to be multiple typec nodes underneath the EC node so that > one DT graph exists per DP bridge. The EC is actually controlling TCPCs > and redrivers that combine the DP and USB signals together so this more > accurately reflects the hardware design without introducing yet another > DT node underneath the EC for USB type-c. > > If the type-c ports are being shared between a single DP controller then > the ports need to know about each other and determine a policy to drive > DP to one type-c port. If the type-c ports each have their own dedicated > DP controller then they're able to operate independently and enter/exit > DP altmode independently as well. We can't connect the DP controller's > endpoint to one usb-c-connector port@1 endpoint and the USB controller's > endpoint to another usb-c-connector port@1 endpoint either because the > DP muxing case would have DP connected to two usb-c-connector endpoints > which the graph binding doesn't support. > > Therefore, one typec node is required per the capabilities of the type-c > port(s) being managed. This also lets us indicate which type-c ports the > DP controller is wired to. For example, if DP was connected to ports 0 > and 2, while port 1 was connected to another DP controller we wouldn't > be able to implement that without having some other DT property to > indicate which output ports are connected to the DP endpoint. > > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: Lee Jones > Cc: Benson Leung > Cc: Guenter Roeck > Cc: Prashant Malani > Cc: Tzung-Bi Shih > Cc: > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd > --- > .../bindings/mfd/google,cros-ec.yaml | 7 +- > .../bindings/usb/google,cros-ec-typec.yaml| 229 ++ > 2 files changed, 233 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v1 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Mon, 02 Sep 2024 20:55:00 +0800, Jianeng Ceng wrote: > This is v1 of the MT8186 Chromebook device tree series. > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 11 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++ > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 27 > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 108 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: touchpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: sound: 'model' is a required property from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: sound: 'model' is a required property from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
Re: [PATCH v2 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Tue, 03 Sep 2024 14:16:01 +0800, Jianeng Ceng wrote: > This is v2 of the MT8186 Chromebook device tree series. > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 11 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++ > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 27 > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 108 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: touchpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: sound: 'model' is a required property from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: sound: 'model' is a required property from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
Re: [PATCH v4 0/9] Add device tree for ArmSoM Sige 5 board
On Tue, 03 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current corresponding drivers. > > Note that as is, the rockchip gpio driver needs the gpio nodes > to be children of the pinctrl node, even though this is deprecated. > > When the driver supports it, they can be moved out of the pinctrl node. > > The power-domain@RK3576_PD_USB is a child of power-domain@RK3576_PD_VOP. > That looks strange but it is how the hardware is, and confirmed by > Rockchip: The NOC bus of USB passes through the PD of VOP, so it relies on > VOP PD. > > The other bindings have been applied on next. > > Changes since v3: > - Dropped mmc dt-bindings (submitted in [2]) > - Dropped syscon dt-bindings (applied in [3]) > - Fix gpu interrupt names mapping > - (Fix email headers overwriting) > > Changes since v2: > - Fix LEDs in armsom dts > - mmc: Move allOf after the required block > - Remove saradc dt-binding commit (already applied) > - Remove opp-microvolt-L* fields > - Reword mali commit message > - Use rgmii-id and remove delays on gmac nodes > > Changes since v1: > - Add eMMC support > - Add gpu node > - Add rtc node > - Add spi compatible dt-bindings > - Add watchdog support > - Dropped timer compatible commit (applied in [0]) > - Move ethernet aliases to board dt > - Move mmio nodes to soc node > - Removed cru grf phandle > - Removed gpio aliases > - Removed grf compatibles (applied in [1]) > - Removed pinctrl php-grf phandle > - Removed v2-tuning for sdcard > - Renamed clock nodes > - Renamed regulators do match regulator-vcc-- > - Renamed the rkvdec_sram node to vdec_sram to match prior generations > - Reorder fields consistently in nodes > - Use correct #power-domain-cells values > > [0]: > https://lore.kernel.org/all/918bb9e4-02d9-4dca-bed2-28bb123bd...@linaro.org/ > [1]: > https://lore.kernel.org/all/172441646605.877570.807594226105.b4...@sntech.de/ > [2]: > https://lore.kernel.org/all/20240903145615.9302-1-detlev.casan...@collabora.com/ > [3]: > https://lore.kernel.org/all/172500660860.97285.13837050366813522297.b4...@kernel.org/ > > Detlev. > > Detlev Casanova (9): > dt-bindings: arm: rockchip: Add ArmSoM Sige 5 > dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml > dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible > dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576 > dt-bindings: gpu: Add rockchip,rk3576-mali compatible > dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible > spi: dt-bindings: Add rockchip,rk3576-spi compatible > arm64: dts: rockchip: Add rk3576 SoC base DT > arm64: dts: rockchip: Add rk3576-armsom-sige5 board > > .../devicetree/bindings/arm/rockchip.yaml |5 + > .../devicetree/bindings/arm/rockchip/pmu.yaml |2 + > .../bindings/gpu/arm,mali-bifrost.yaml|1 + > .../devicetree/bindings/i2c/i2c-rk3x.yaml |1 + > .../bindings/serial/snps-dw-apb-uart.yaml |1 + > .../devicetree/bindings/spi/spi-rockchip.yaml |1 + > .../bindings/watchdog/snps,dw-wdt.yaml|1 + > arch/arm64/boot/dts/rockchip/Makefile |1 + > .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 659 ++ > .../boot/dts/rockchip/rk3576-pinctrl.dtsi | 5775 + > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 1644 + > 11 files changed, 8091 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-pinctrl.dtsi > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576.dtsi > > -- > 2.46.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3576-armsom-sige5.dtb' for 20240903152308.13565-1-detlev.casan...@collabora.com: arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: clock-controller@2720: 'rockchip,grf' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/clock/rockchip,rk3576-cru.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: gpu@2780: interrupt-names:0: 'job' was expected from schema $id: http://devicetree.org/schemas/gpu/arm,mali-bifrost.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: gpu@2780: interrupt-names:2: 'gpu' was expected from schema $id: http://devicetree.org/schemas/gp
Re: [PATCH v3 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks
On Wed, 04 Sep 2024 16:50:37 +0800, Jianeng Ceng wrote: > MT8186 ponyta, known as huaqin custom lable, is a > MT8186 based laptop. It is based on the "corsola" design. > It includes LTE, touchpad combinations. > > Signed-off-by: Jianeng Ceng > --- > Changes in v2: > - PATCH 2/2: Modify the dtb name without rev2. > - Link to > v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com/ > > --- > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++ > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 27 > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 4 files changed, 97 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240904085037.2133607-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: ['google,ponyta-sku1', 'google,ponyta', 'mediatek,mt8186'] is too long ['google,ponyta-sku1', 'google,ponyta', 'mediatek,mt8186'] is too short 'google,ponyta-sku1' is not one of ['mediatek,mt2701-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt2712-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt6580-evbp1'] 'google,ponyta-sku1' is not one of ['prestigio,pmt5008-3g'] 'google,ponyta-sku1' is not one of ['fairphone,fp1', 'mundoreader,bq-aquaris5'] 'google,ponyta-sku1' is not one of ['mediatek,mt6592-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt6755-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt6765-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt6779-evb'] 'google,ponyta-sku1' is not one of ['mediatek,mt6795-evb', 'sony,xperia-m5'] 'google,ponyta-sku1' is not one of ['archermind,mt6797-x20-dev', 'mediatek,mt6797-evb'] 'google,ponyta-sku1' is not one of ['bananapi,bpi-r64', 'mediatek,mt7622-rfb1'] 'google,ponyta-sku1' is not one of ['mediatek,mt7623a-rfb-emmc', 'mediatek,mt7623a-rfb-nand', 'mediatek,mt7623n-rfb-emmc', 'bananapi,bpi-r2'] 'google,ponyta-sku1' is not one of ['mediatek,mt7629-rfb'] 'google,ponyta-sku1' is not one of ['cudy,wr3000-v1', 'openwrt,one', 'xiaomi,ax3000t'] 'google,ponyta-sku1' is not one of ['acelink,ew-7886cax', 'bananapi,bpi-r3', 'bananapi,bpi-r3mini', 'mediatek,mt7986a-rfb'] 'google,ponyta-sku1' is not one of ['mediatek,mt7986b-rfb'] 'google,ponyta-sku1' is not one of ['bananapi,bpi-r4'] 'google,ponyta-sku1' is not one of ['mediatek,mt8127-moose'] 'google,ponyta-sku1' is not one of ['mediatek,mt8135-evbp1'] 'google,ponyta-sku1' is not one of ['mediatek,mt8167-pumpkin'] 'google,elm-rev8' was expected 'google,hana-rev6' was expected 'google,hana-rev7' was expected 'google,ponyta-sku1' is not one of ['mediatek,mt8173-evb'] 'google,burnet' was expected 'google,cozmo' was expected 'google,damu' was expected 'google,ponyta-sku1' is not one of ['google,fennel-sku0', 'google,fennel-sku1', 'google,fennel-sku2', 'google,fennel-sku6', 'google,fennel-sku7'] 'google,ponyta-sku1' is not one of ['google,juniper-sku16', 'google,juniper-sku17'] 'google,kakadu-rev3' was expected 'google,kakadu-rev3-sku22' was expected 'google,kappa' was expected 'google,ponyta-sku1' is not one of ['google,katsu-sku32', 'google,katsu-sku38'] 'google,ponyta-sku1' is not one of ['google,kodama-sku16', 'google,kodama-sku272', 'google,kodama-sku288', 'google,kodama-sku32'] 'google,ponyta-sku1' is not one of ['google,krane-sku0', 'google,krane-sku176'] 'google,ponyta-sku1' is not one of ['google,makomo-sku0', 'google,makomo-sku1'] 'google,ponyta-sku1' is not one of ['google,pico-sku1', 'google,pico-sku2'] 'google,ponyta-sku1' is not one of ['google,willow-sku0', 'google,willow-sku1'] 'google,ponyta-sku1' is not one of ['mediatek,mt8183-evb'] 'google,ponyta-sku1' is not one of [
Re: [PATCH v2] dt-bindings: lcdif: Document the dmas/dma-names properties
On Wed, 04 Sep 2024 07:40:27 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX28 has an RX DMA channel associated with the LCDIF controller. > > Document the 'dmas' and 'dma-names' properties to fix the following > dt-schema warnings: > > lcdif@8003: 'dma-names', 'dmas' do not match any of the regexes: > 'pinctrl-[0-9]+' > > Signed-off-by: Fabio Estevam > Reviewed-by: Krzysztof Kozlowski > --- > Changes since v1: > - Add a blank line before the examples. (Krzysztof) > > .../bindings/display/fsl,lcdif.yaml | 20 +++ > 1 file changed, 20 insertions(+) > Applied, thanks!
Re: [PATCH v3 1/2] dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel
On Wed, 04 Sep 2024 13:23:21 +1200, Ryan Walklin wrote:
> The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
> OEM used in a number of handheld gaming devices made by Anbernic.
> Previously committed using the OEM serial without a vendor prefix,
> however following subsequent discussion the preference is to use the
> integrating device vendor and name where the OEM is unknown.
>
> There are 4 RG35XX series devices from Anbernic based on an Allwinner
> H700 SoC using this panel, with the -Plus variant introduced first.
> Therefore the -Plus is used as the fallback for the subsequent -H,
> -2024, and -SP devices.
>
> Alter the filename and compatible string to reflect the convention.
>
> Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
> Signed-off-by: Ryan Walklin
>
> --
> Changelog v1..v2:
> - Use known panel serial for compatible name rather than referencing
> integrating devices as per feedback [1] from DT maintainers.
>
> Changelog v2..v3:
> - Use integrating device names rather than panel serial number for
>compatible string as per further maintainer feedback [2].
>
> [1]
> https://lore.kernel.org/linux-devicetree/8b4519fc-0fba-48fe-bfb4-318818b47...@app.fastmail.com/#t
>
> [2]
> https://lore.kernel.org/dri-devel/6ab54fb5-8723-457d-b5e6-483f82faf...@app.fastmail.com/
> ---
> ...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++
> 1 file changed, 11 insertions(+), 4 deletions(-)
> rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml =>
> anbernic,rg35xx-plus-panel.yaml} (67%)
>
Acked-by: Rob Herring (Arm)
Re: [PATCH v4 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Fri, 06 Sep 2024 16:57:37 +0800, Jianeng Ceng wrote: > This is v4 of the MT8186 Chromebook device tree series. > --- > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to > v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v3: > - PATCH 0/2: Add the modify records. > - PATCH 1/2: Modify lable to label. > - Link to > v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v2: > - PATCH 2/2: Modify the dtb name without rev2. > - Link to > v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com/ > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 11 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++ > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 27 > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 108 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240906085739.1322676-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: touchpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml arch/arm64/boot/dts/mediatek/mt8186-co
Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled
On Mon, 08 Jul 2024 17:18:56 +0200, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > It allows to disable Burst video mode > > Co-developed-by: Noah J. Rosa > Signed-off-by: Noah J. Rosa > Signed-off-by: Stefano Radaelli > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml: burst-mode-disabled: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708151857.40538-1-stefano.radaell...@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v4 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis
On Mon, 08 Jul 2024 17:01:13 +0200, Marek Vasut wrote: > Document default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis setting of 0 dB > is not useful. The preemphasis can be set separately for both DP lanes > in range 0=0dB, 1=3.5dB, 2=6dB . > > This is an endpoint property, not a port property, because the TC9595 > datasheet does mention that the DP might operate in some sort of split > mode, where each DP lane is used to feed one display, so in that case > there might be two endpoints. > > Signed-off-by: Marek Vasut > --- > Cc: Alexander Stein > Cc: Andrzej Hajda > Cc: Conor Dooley > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Robert Foss > Cc: Thomas Zimmermann > Cc: devicet...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: ker...@dh-electronics.com > --- > V2: - Fix the type to u8 array > - Fix the enum items to match what they represent > V3: - Update commit message, expand on this being an endpoint property > V4: - Fix ref: /schemas/graph.yaml#/$defs/port-base and add > unevaluatedProperties > --- > .../display/bridge/toshiba,tc358767.yaml | 21 ++- > 1 file changed, 20 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS
On Tue, 16 Jul 2024 01:39:52 +0530, Aradhya Bhatia wrote: > The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the > support for the OLDI TXes. > > The AM625 DSS VP1 (port@0) can connect and control 2 OLDI TXes, to use > them in dual-link or cloned single-link OLDI modes. Add support for an > additional endpoint under the port@0 to accurately depict the data flow > path. > > Signed-off-by: Aradhya Bhatia > --- > .../bindings/display/ti/ti,am65x-dss.yaml | 134 ++ > 1 file changed, 134 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml: oldi-txes: Missing additionalProperties/unevaluatedProperties constraint doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240715200953.1213284-4-a-bhat...@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 04/16] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller
On Fri, 12 Jul 2024 17:32:31 +0800, Liu Ying wrote: > i.MX8qxp Display Controller has a built-in interrupt controller to support > Enable/Status/Preset/Clear interrupt bit. > > Signed-off-by: Liu Ying > --- > v2: > * Drop unneeded "|". (Krzysztof) > > .../fsl,imx8qxp-dc-intc.yaml | 318 ++ > 1 file changed, 318 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/interrupt-controller/fsl,imx8qxp-dc-intc.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 3/3] dt-bindings: Batch-update Konrad Dybcio's email
On Fri, 26 Jul 2024 13:18:25 +0200, Konrad Dybcio wrote: > Use my @kernel.org address everywhere. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,gcc-sm6125.yaml| 2 > +- > Documentation/devicetree/bindings/clock/qcom,gcc-sm6350.yaml| 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6115-gpucc.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6125-gpucc.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6350-camcc.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6375-dispcc.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml| 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm6375-gpucc.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml| 2 > +- > Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 2 > +- > Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml | 2 > +- > .../devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml | 2 > +- > Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml| 2 > +- > Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml| 2 > +- > Documentation/devicetree/bindings/interconnect/qcom,sc8280xp-rpmh.yaml | 2 > +- > Documentation/devicetree/bindings/interconnect/qcom,sm8450-rpmh.yaml| 2 > +- > Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 2 > +- > Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-tlmm.yaml| 2 > +- > Documentation/devicetree/bindings/pinctrl/qcom,sm6350-tlmm.yaml | 2 > +- > Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 2 > +- > Documentation/devicetree/bindings/remoteproc/qcom,rpm-proc.yaml | 2 > +- > Documentation/devicetree/bindings/soc/qcom/qcom,rpm-master-stats.yaml | 2 > +- > 24 files changed, 24 insertions(+), 24 deletions(-) > Applied, thanks!
Re: [PATCH 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a
On Mon, 29 Jul 2024 21:38:45 -0400, Richard Acayan wrote: > This adds support for the speed-binned A615 GPU on SDM670. > > Richard Acayan (4): > dt-bindings: display/msm/gmu: Add SDM670 compatible > drm/msm/adreno: add a615 support > arm64: dts: qcom: sdm670: add gpu > arm64: dts: qcom: sdm670-google-common: enable gpu > > .../devicetree/bindings/display/msm/gmu.yaml | 1 + > .../boot/dts/qcom/sdm670-google-sargo.dts | 13 ++ > arch/arm64/boot/dts/qcom/sdm670.dtsi | 168 ++ > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 27 +++ > 4 files changed, 209 insertions(+) > > -- > 2.45.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/sdm670-google-sargo.dtb' for 20240730013844.41951-6-mailingrad...@gmail.com: arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb: iommu@504: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2'] is too long ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2'] is too short 'qcom,sdm670-smmu-v2' is not one of ['qcom,msm8996-smmu-v2', 'qcom,msm8998-smmu-v2', 'qcom,sdm630-smmu-v2', 'qcom,sm6375-smmu-v2'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,qdu1000-smmu-500', 'qcom,sa8775p-smmu-500', 'qcom,sc7180-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sdm670-smmu-500', 'qcom,sdm845-smmu-500', 'qcom,sdx55-smmu-500', 'qcom,sdx65-smmu-500', 'qcom,sdx75-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6125-smmu-500', 'qcom,sm6350-smmu-500', 'qcom,sm6375-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500', 'qcom,sm8550-smmu-500', 'qcom,sm8650-smmu-500', 'qcom,x1e80100-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,sc7180-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sdm845-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6350-smmu-500', 'qcom,sm6375-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,sa8775p-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6125-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500', 'qcom,sm8550-smmu-500', 'qcom,sm8650-smmu-500', 'qcom,x1e80100-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,sc7280-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,msm8996-smmu-v2', 'qcom,sc7180-smmu-v2', 'qcom,sdm630-smmu-v2', 'qcom,sdm845-smmu-v2', 'qcom,sm6350-smmu-v2', 'qcom,sm7150-smmu-v2'] 'qcom,sdm845-smmu-v2' was expected 'marvell,ap806-smmu-500' was expected 'qcom,sdm670-smmu-v2' is not one of ['nvidia,tegra186-smmu', 'nvidia,tegra194-smmu', 'nvidia,tegra234-smmu'] 'arm,mmu-500' was expected 'qcom,sdm670-smmu-v2' is not one of ['arm,mmu-400', 'arm,mmu-401'] 'qcom,sdm670-smmu-v2' is not one of ['arm,smmu-v1', 'arm,smmu-v2', 'arm,mmu-400', 'arm,mmu-401', 'arm,mmu-500', 'cavium,smmu-v2'] 'qcom,smmu-v2' was expected 'qcom,smmu-500' was expected 'nvidia,smmu-500' was expected 'arm,smmu-v2' was expected 'arm,smmu-v1' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb: /soc@0/iommu@504: failed to match any schema with compatible: ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2']
[PATCH] drm: vc4: Use of_property_present()
Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.
Signed-off-by: Rob Herring (Arm)
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index d57c4a5948c8..049de06460d5 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -2211,7 +2211,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
struct device *dev = &vc4_hdmi->pdev->dev;
struct platform_device *codec_pdev;
const __be32 *addr;
- int index, len;
+ int index;
int ret;
/*
@@ -2234,7 +2234,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
- if (!of_find_property(dev->of_node, "dmas", &len) || !len) {
+ if (!of_property_present(dev->of_node, "dmas")) {
dev_warn(dev,
"'dmas' DT property is missing or empty, no HDMI
audio\n");
return 0;
--
2.43.0
[PATCH] drm: mediatek: Drop unnecessary check for property presence
of_property_read_u32() returns -EINVAL if a property is not present, so
the preceeding check for presence with of_find_property() can be
dropped. Really, what the errno is shouldn't matter. Either the property
can be read and used or it can't and is ignored.
This is part of a larger effort to remove callers of of_find_property()
and similar functions. of_find_property() leaks the DT struct property
and data pointers which is a problem for dynamically allocated nodes
which may be freed.
Signed-off-by: Rob Herring (Arm)
---
drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
index 634bbba5d43f..07243f372260 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
@@ -341,14 +341,11 @@ static int mtk_disp_rdma_probe(struct platform_device
*pdev)
dev_dbg(dev, "get mediatek,gce-client-reg fail!\n");
#endif
- if (of_find_property(dev->of_node, "mediatek,rdma-fifo-size", &ret)) {
- ret = of_property_read_u32(dev->of_node,
- "mediatek,rdma-fifo-size",
- &priv->fifo_size);
- if (ret)
- return dev_err_probe(dev, ret,
-"Failed to get rdma fifo size\n");
- }
+ ret = of_property_read_u32(dev->of_node,
+ "mediatek,rdma-fifo-size",
+ &priv->fifo_size);
+ if (ret && (ret != -EINVAL))
+ return dev_err_probe(dev, ret, "Failed to get rdma fifo
size\n");
/* Disable and clear pending interrupts */
writel(0x0, priv->regs + DISP_REG_RDMA_INT_ENABLE);
--
2.43.0
[PATCH] drm: bridge: anx7625: Use of_property_read_variable_u8_array()
There's no need to get the length of an DT array property before
parsing the array. of_property_read_variable_u8_array() takes a minimum
and maximum length and returns the actual length (or error code).
This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.
Signed-off-by: Rob Herring (Arm)
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 88e4aa5830f3..a2e9bb485c36 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1647,25 +1647,15 @@ static int anx7625_get_swing_setting(struct device *dev,
{
int num_regs;
- if (of_get_property(dev->of_node,
- "analogix,lane0-swing", &num_regs)) {
- if (num_regs > DP_TX_SWING_REG_CNT)
- num_regs = DP_TX_SWING_REG_CNT;
-
+ num_regs = of_property_read_variable_u8_array(dev->of_node,
"analogix,lane0-swing",
+ pdata->lane0_reg_data, 1,
DP_TX_SWING_REG_CNT);
+ if (num_regs > 0)
pdata->dp_lane0_swing_reg_cnt = num_regs;
- of_property_read_u8_array(dev->of_node, "analogix,lane0-swing",
- pdata->lane0_reg_data, num_regs);
- }
-
- if (of_get_property(dev->of_node,
- "analogix,lane1-swing", &num_regs)) {
- if (num_regs > DP_TX_SWING_REG_CNT)
- num_regs = DP_TX_SWING_REG_CNT;
+ num_regs = of_property_read_variable_u8_array(dev->of_node,
"analogix,lane1-swing",
+ pdata->lane1_reg_data, 1,
DP_TX_SWING_REG_CNT);
+ if (num_regs > 0)
pdata->dp_lane1_swing_reg_cnt = num_regs;
- of_property_read_u8_array(dev->of_node, "analogix,lane1-swing",
- pdata->lane1_reg_data, num_regs);
- }
return 0;
}
--
2.43.0
Re: [PATCH v2 1/3] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller
On Thu, 01 Aug 2024 05:25:52 +0300, Cristian Ciocaltea wrote:
> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1
> Quad-Pixel (QP) TX controller IP.
>
> Since this is a new IP block, quite different from those used in the
> previous generations of Rockchip SoCs, add a dedicated binding file.
>
> Signed-off-by: Cristian Ciocaltea
> ---
> .../display/rockchip/rockchip,dw-hdmi-qp.yaml | 188
> +
> 1 file changed, 188 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi-qp.example.dtb:
hdmi@fde8: False schema does not allow {'compatible':
['rockchip,rk3588-dw-hdmi-qp'], 'reg': [[0, 425984, 0, 131072]], 'clocks':
[[4294967295, 528], [4294967295, 529], [4294967295, 530], [4294967295, 564],
[4294967295, 594], [4294967295, 717]], 'clock-names': ['pclk', 'earc', 'ref',
'aud', 'hdp', 'hclk_vo1'], 'interrupts': [[0, 169, 4, 0], [0, 170, 4, 0], [0,
171, 4, 0], [0, 172, 4, 0], [0, 360, 4, 0]], 'interrupt-names': ['avp', 'cec',
'earc', 'main', 'hpd'], 'phys': [[4294967295]], 'phy-names': ['hdmi'],
'power-domains': [[4294967295, 26]], 'resets': [[4294967295, 462], [4294967295,
560]], 'reset-names': ['ref', 'hdp'], 'rockchip,grf': [[4294967295]],
'rockchip,vo1_grf': [[4294967295]], '#sound-dai-cells': 0, 'ports':
{'#address-cells': 1, '#size-cells': 0, 'port@0': {'reg': [[0]], 'endpoint':
{'remote-endpoint': [[4294967295]]}}, 'port@1': {'reg': [[1]]
, 'endpoint': {'remote-endpoint': [[4294967295]]}}}, '$nodename':
['hdmi@fde8']}
from schema $id:
http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi-qp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi-qp.example.dtb:
hdmi@fde8: Unevaluated properties are not allowed ('reg' was unexpected)
from schema $id:
http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi-qp.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240801-b4-rk3588-bridge-upstream-v2-1-9fa657a4e...@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a
On Tue, 06 Aug 2024 17:44:54 -0400, Richard Acayan wrote: > This adds support for the speed-binned A615 GPU on SDM670. > > Changes since v1 (20240730013844.41951-6-mailingrad...@gmail.com): > - add Acked-by tag (1/4) > - add OPPs exclusive to some speed bins (3/4) > - enable GMU by default (3/4) > > Richard Acayan (4): > dt-bindings: display/msm/gmu: Add SDM670 compatible > drm/msm/adreno: add a615 support > arm64: dts: qcom: sdm670: add gpu > arm64: dts: qcom: sdm670-google-sargo: enable gpu > > .../devicetree/bindings/display/msm/gmu.yaml | 1 + > .../boot/dts/qcom/sdm670-google-sargo.dts | 9 + > arch/arm64/boot/dts/qcom/sdm670.dtsi | 180 ++ > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 27 +++ > 4 files changed, 217 insertions(+) > > -- > 2.46.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/sdm670-google-sargo.dtb' for 20240806214452.16406-7-mailingrad...@gmail.com: arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb: iommu@504: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2'] is too long ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2'] is too short 'qcom,sdm670-smmu-v2' is not one of ['qcom,msm8996-smmu-v2', 'qcom,msm8998-smmu-v2', 'qcom,sdm630-smmu-v2', 'qcom,sm6375-smmu-v2'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,qdu1000-smmu-500', 'qcom,sa8775p-smmu-500', 'qcom,sc7180-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sdm670-smmu-500', 'qcom,sdm845-smmu-500', 'qcom,sdx55-smmu-500', 'qcom,sdx65-smmu-500', 'qcom,sdx75-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6125-smmu-500', 'qcom,sm6350-smmu-500', 'qcom,sm6375-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500', 'qcom,sm8550-smmu-500', 'qcom,sm8650-smmu-500', 'qcom,x1e80100-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,sc7180-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sdm845-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6350-smmu-500', 'qcom,sm6375-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,qcm2290-smmu-500', 'qcom,sa8775p-smmu-500', 'qcom,sc7280-smmu-500', 'qcom,sc8180x-smmu-500', 'qcom,sc8280xp-smmu-500', 'qcom,sm6115-smmu-500', 'qcom,sm6125-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500', 'qcom,sm8350-smmu-500', 'qcom,sm8450-smmu-500', 'qcom,sm8550-smmu-500', 'qcom,sm8650-smmu-500', 'qcom,x1e80100-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,sc7280-smmu-500', 'qcom,sm8150-smmu-500', 'qcom,sm8250-smmu-500'] 'qcom,sdm670-smmu-v2' is not one of ['qcom,msm8996-smmu-v2', 'qcom,sc7180-smmu-v2', 'qcom,sdm630-smmu-v2', 'qcom,sdm845-smmu-v2', 'qcom,sm6350-smmu-v2', 'qcom,sm7150-smmu-v2'] 'qcom,sdm845-smmu-v2' was expected 'marvell,ap806-smmu-500' was expected 'qcom,sdm670-smmu-v2' is not one of ['nvidia,tegra186-smmu', 'nvidia,tegra194-smmu', 'nvidia,tegra234-smmu'] 'arm,mmu-500' was expected 'qcom,sdm670-smmu-v2' is not one of ['arm,mmu-400', 'arm,mmu-401'] 'qcom,sdm670-smmu-v2' is not one of ['arm,smmu-v1', 'arm,smmu-v2', 'arm,mmu-400', 'arm,mmu-401', 'arm,mmu-500', 'cavium,smmu-v2'] 'qcom,smmu-v2' was expected 'qcom,smmu-500' was expected 'nvidia,smmu-500' was expected 'arm,smmu-v2' was expected 'arm,smmu-v1' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb: /soc@0/iommu@504: failed to match any schema with compatible: ['qcom,sdm670-smmu-v2', 'qcom,adreno-smmu', 'qcom,smmu-v2']
Re: [PATCH v2] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible
On Fri, 09 Aug 2024 17:13:14 +0200, Yannick Fertre wrote:
> Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce
> new clocks (bus, ref & lvds). Bus clock was separated from lcd clock.
> New sources are possible for lcd clock (lvds / ref).
>
> Signed-off-by: Yannick Fertre
> ---
> Changes in v2: Rework clock property.
> .../bindings/display/st,stm32-ltdc.yaml | 51 +++
> 1 file changed, 41 insertions(+), 10 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml:
allOf:0:else:properties:clocks: {'maxItems': 1, 'items': [{'description': 'Lcd
Clock'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml:
allOf:0:then:properties:clocks: {'maxItems': 4, 'items': [{'description': 'Lcd
Clock'}, {'description': 'Bus Clock'}, {'description': 'Reference Clock'},
{'description': 'Lvds Clock'}]} should not be valid under {'required':
['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.example.dtb:
display-controller@40016800: 'clock-names', 'clocks' do not match any of the
regexes: 'pinctrl-[0-9]+'
from schema $id:
http://devicetree.org/schemas/display/st,stm32-ltdc.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809151314.221746-1-yannick.fer...@foss.st.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector
On Fri, 09 Aug 2024 17:34:49 +0200, Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. > > Signed-off-by: Luca Ceresoli > > --- > > Changed in v3: > - change the layout to only add subnodes, not properties > - add the 'nobus-devices' node description to hold devices not on any bus > - add 'i2c-*' nodes for the I2C busses, using a i2c-parent phandle > - and the 'dsi' node for the DSI bus > - move the entire port@1 node to the overlay (not only the remote-endpoint >property) > - remove the overlay examples (Overlays in examples are not supported) > - add more clarifying descriptions and comments for examples > - some rewording > > This patch was added in v2. > --- > .../connector/ge,sunh-addon-connector.yaml | 185 > + > MAINTAINERS| 5 + > 2 files changed, 190 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: /: 'compatible' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: /: 'model' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: /: '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb: /: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809-hotplug-drm-bridge-v3-1-b4c178380...@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true
On Wed, 14 Aug 2024 15:16:56 -0400, Frank Li wrote: > Add property panel-timing: true to allow use 'panel-timing', which defined > in panel-common.yaml. > > Fix below warning: > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: > 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: > http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml# > > Suggested-by: Liu Ying > Signed-off-by: Frank Li > --- > Change from v2 to v3 > - move it after enable-gpios: true' to sort the referenced properties > alphabetically > > Change from v1 to v2 > - add panel-timing instead of change to unevaluatedProperties > --- > .../bindings/display/panel/panel-simple-lvds-dual-ports.yaml | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks!
Re: [PATCH v3 08/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller
On Wed, 24 Jul 2024 17:29:39 +0800, Liu Ying wrote: > i.MX8qxp Display Controller(DC) is comprised of three main components that > include a blit engine for 2D graphics accelerations, display controller for > display output processing, as well as a command sequencer. > > Signed-off-by: Liu Ying > --- > v3: > * No change. > > v2: > * Drop fsl,dc-*-id DT properties from example. (Krzysztof) > * Use generic pmu pattern property. (Krzysztof) > > .../bindings/display/imx/fsl,imx8qxp-dc.yaml | 236 ++ > 1 file changed, 236 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900
On Thu, 09 May 2024 14:43:35 +0800, Zhaoxiong Lv wrote: > From: lvzhaoxiong > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong > --- > Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts' Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240509064336.9803-1-lvzhaoxi...@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 1/5] dt-bindings: connector: add GE SUNH hotplug addon connector
On Fri, 10 May 2024 09:10:37 +0200, Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. > > Signed-off-by: Luca Ceresoli > > --- > > NOTE: the second and third examples fail 'make dt_binding_check' because > they are example of DT overlay code -- I'm not aware of a way to > validate overlay examples as of now > > This patch is new in v2. > --- > .../connector/ge,sunh-addon-connector.yaml | 197 > + > MAINTAINERS| 5 + > 2 files changed, 202 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dts:49.9-14 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/connector/ge,sunh-addon-connector.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240510-hotplug-drm-bridge-v2-1-ec32f2c66...@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 08/10] media: dt-bindings: Add Chameleon v3 video interface
On Tue, 07 May 2024 15:54:11 +, Paweł Anikiel wrote: > Add dt binding for the video interface present on the Google > Chameleon v3. The Chameleon v3 uses the video interface to capture > a single video source from a given HDMI or DP connector and write > the resulting frames to memory. > > Signed-off-by: Paweł Anikiel > --- > .../bindings/media/google,chv3-video.yaml | 64 +++ > 1 file changed, 64 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/media/google,chv3-video.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v3 05/10] media: dt-bindings: video-interfaces: Support DisplayPort MST
On Tue, 07 May 2024 15:54:08 +, Paweł Anikiel wrote: > Add a DisplayPort bus type and a multi-stream-support property > indicating whether the interface supports MST. > > Signed-off-by: Paweł Anikiel > --- > .../devicetree/bindings/media/video-interfaces.yaml| 7 +++ > include/dt-bindings/media/video-interfaces.h | 2 ++ > 2 files changed, 9 insertions(+) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 1/5] dt-bindings: display: panel: mipi-dbi-spi: Add a pixel format property
On Sun, 12 May 2024 17:25:38 +0200, Noralf Trønnes wrote: > The MIPI DBI 2.0 specification (2005) lists only two pixel formats for > the Type C Interface (SPI) and that is 3-bits/pixel RGB111 with > 2 options for bit layout. > > For Type A and B (parallel) the following formats are listed: RGB332, > RGB444, RGB565, RGB666 and RGB888 (some have 2 options for the bit layout). > > Many MIPI DBI compatible controllers support all interface types on the > same chip and often the manufacturers have chosen to provide support for > the Type A/B interface pixel formats also on the Type C interface. > > Some chips provide many pixel formats with optional bit layouts over SPI, > but the most common by far are RGB565 and RGB666. So even if the > specification doesn't list these formats for the Type C interface, the > industry has chosen to include them. > > The MIPI DCS specification lists the standard commands that can be sent > over the MIPI DBI interface. The set_address_mode (36h) command has one > bit in the parameter that controls RGB/BGR order: > This bit controls the RGB data latching order transferred from the > peripheral’s frame memory to the display device. > This means that each supported RGB format also has a BGR variant. > > Based on this rationale document the following pixel formats describing > the bit layout going over the wire: > - RGB111 (option 1): x2r1g1b1r1g1b1 (2 pixels per byte) > - BGR111 (option 1): x2b1g1r1b1g1r1 (2 pixels per byte) > - RGB111 (option 2): x1r1g1b1x1r1g1b1 (2 pixels per byte) > - BGR111 (option 2): x1b1g1r1x1b1g1r1 (2 pixels per byte) > - RGB565: r5g6b5 (2 bytes) > - BGR565: b5g6r5 (2 bytes) > - RGB666: r6x2g6x2b6x2 (3 bytes) > - BGR666: b6x2g6x2r6x2 (3 bytes) > (x: don't care) > > v2: > - Use 'default: r5g6b5' (Rob) > > Signed-off-by: Noralf Trønnes > --- > .../bindings/display/panel/panel-mipi-dbi-spi.yaml | 30 > ++ > 1 file changed, 30 insertions(+) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH] dt-bindings: display: Reorganize legacy eDP panel bindings
On Mon, 20 May 2024 15:38:17 -0700, Douglas Anderson wrote: > Back in the day, we used to need to list the exact panel in dts for > eDP panels. This led to all sorts of problems including a large number > of cases where people listed a bogus panel in their device tree > because of the needs of second sourcing (and third sourcing, and > fourth sourcing, ...). Back when we needed to add eDP panels to dts > files we used to list them in "panel-simple.yaml". > > These days we have the new way of doing things as documented in > "panel-edp.yaml". We can just list the compatible "edp-panel", add > some timing info to the source code, and we're good to go. There's not > really good reasons not to use this new method. > > To try to make it obvious that we shouldn't add new compatible strings > for eDP panels, let's move them all out of the old "panel-simple.yaml" > file to their own file: "panel-edp-legacy.yaml". This new file will > have a description that makes it obvious that we shouldn't use it for > new panels. > > While we're doing this: > - We can remove eDP-specific properties from panel-simple.yaml since > there are no more panels there. > - We don't need to copy non-eDP properties to the > "panel-edp-legacy.yaml". > - We'll fork off a separate yaml file for "samsung,atna33xc20.yaml". > This is an eDP panel which isn't _quite_ handled by the generic > "edp-panel" compatible since it's not allowed to have an external > backlight (it has one builtin) and it absolutely requires an > "enable" GPIO. > - We'll un-fork the "sharp,ld-d5116z01b.yaml" and put it in > "panel-edp-legacy.yaml" since there doesn't appear to be any reason > for it to be separate. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Douglas Anderson > --- > > .../display/panel/panel-edp-legacy.yaml | 127 ++ > .../bindings/display/panel/panel-simple.yaml | 58 > .../display/panel/samsung,atna33xc20.yaml | 95 + > .../display/panel/sharp,ld-d5116z01b.yaml | 30 - > 4 files changed, 222 insertions(+), 88 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/panel/panel-edp-legacy.yaml > create mode 100644 > Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml > delete mode 100644 > Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH] dt-bindings: display: synopsys, dw-hdmi: Mark ddc-i2c-bus as deprecated
On Tue, 21 May 2024 12:40:47 +0200, Marek Vasut wrote: > The ddc-i2c-bus property should be placed in connector node, > mark the HDMI TX side property as deprecated. > > Signed-off-by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: Conor Dooley > Cc: Daniel Vetter > Cc: David Airlie > Cc: Fabio Estevam > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Maarten Lankhorst > Cc: Mark Yao > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Pengutronix Kernel Team > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Robert Foss > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Thomas Zimmermann > Cc: devicet...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: i...@lists.linux.dev > Cc: ker...@dh-electronics.com > Cc: linux-arm-ker...@lists.infradead.org > --- > .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel
On Fri, 24 May 2024 22:33:13 +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM, used in a number of handheld gaming devices made by Anbernic. > > Add a device tree binding for the panel. > > Signed-off-by: Ryan Walklin > --- > .../bindings/display/panel/wl-355608-a8.yaml | 68 +++ > 1 file changed, 68 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/panel/wl-355608-a8.example.dtb: /example-0/spi/panel@0: failed to match any schema with compatible: ['wl_355608_a8'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240524103506.187277-2-r...@testtoast.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver
On Sun, 26 May 2024 07:08:04 +0800, Jason-JH.Lin wrote:
> 1. Add mboxes property to define a GCE loopping thread as a secure IRQ
> handler.
> The CMDQ secure driver requests a mbox channel and sends a looping
> command to the GCE thread. The looping command will wait for a secure
> packet done event signal from secure world and then jump back to the
> first instuction. Each time it waits for an event, it notifies the
> CMDQ driver to perform the same action as the IRQ handler.
>
> 2. Add gce-events property from gce-props.yaml to define a
> secure packet done signal in secure world.
> There are 1024 events IDs for GCE to use to execute instructions in
> the specific event happened. These events could be signaled by HW or SW
> and their value would be different in different SoC because of HW event
> IDs distribution range from 0 to 1023.
> If we set a static event ID: 855 for mt8188, it might be conflict the
> event ID original set in mt8195.
> So we define an event ID that will be set when GCE runs to the end of
> secure cmdq packet in the secure world.
>
> This can reduce the latency of software communication between normal
> world and secure world. In addition, we can also remove the complex
> logic after the secure packet done in the secure world.
>
> Signed-off-by: Jason-JH.Lin
> Signed-off-by: Hsiao Chien Sung
> ---
> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.example.dtb:
mailbox@10212000: False schema does not allow {'compatible':
['mediatek,mt8173-gce'], 'reg': [[0, 270606336, 0, 4096]], 'interrupts': [[0,
135, 8]], '#mbox-cells': [[2]], 'clocks': [[4294967295, 4]], 'clock-names':
['gce'], '$nodename': ['mailbox@10212000']}
from schema $id:
http://devicetree.org/schemas/mailbox/mediatek,gce-mailbox.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240525230810.24623-3-jason-jh@mediatek.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH RESEND,v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver
On Sun, 26 May 2024 22:44:37 +0800, Jason-JH.Lin wrote:
> 1. Add mboxes property to define a GCE loopping thread as a secure IRQ
> handler.
> The CMDQ secure driver requests a mbox channel and sends a looping
> command to the GCE thread. The looping command will wait for a secure
> packet done event signal from secure world and then jump back to the
> first instuction. Each time it waits for an event, it notifies the
> CMDQ driver to perform the same action as the IRQ handler.
>
> 2. Add gce-events property from gce-props.yaml to define a
> secure packet done signal in secure world.
> There are 1024 events IDs for GCE to use to execute instructions in
> the specific event happened. These events could be signaled by HW or SW
> and their value would be different in different SoC because of HW event
> IDs distribution range from 0 to 1023.
> If we set a static event ID: 855 for mt8188, it might be conflict the
> event ID original set in mt8195.
> So we define an event ID that will be set when GCE runs to the end of
> secure cmdq packet in the secure world.
>
> This can reduce the latency of software communication between normal
> world and secure world. In addition, we can also remove the complex
> logic after the secure packet done in the secure world.
>
> Signed-off-by: Jason-JH.Lin
> Signed-off-by: Hsiao Chien Sung
> ---
> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.example.dtb:
mailbox@10212000: False schema does not allow {'compatible':
['mediatek,mt8173-gce'], 'reg': [[0, 270606336, 0, 4096]], 'interrupts': [[0,
135, 8]], '#mbox-cells': [[2]], 'clocks': [[4294967295, 4]], 'clock-names':
['gce'], '$nodename': ['mailbox@10212000']}
from schema $id:
http://devicetree.org/schemas/mailbox/mediatek,gce-mailbox.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2024052613.14345-3-jason-jh@mediatek.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [DO NOT MERGE v8 24/36] dt-binding: sh: cpus: Add SH CPUs json-schema
On Wed, 29 May 2024 17:01:10 +0900, Yoshinori Sato wrote: > Renesas SH series and compatible ISA CPUs. > > Signed-off-by: Yoshinori Sato > --- > .../devicetree/bindings/sh/cpus.yaml | 63 +++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sh/cpus.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sh/cpus.example.dtb: cpu@0: 'clock-names', 'dcache-line-size', 'dcache-size', 'icache-line-size', 'icache-size' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/sh/cpus.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/d54cb668f3f19221fdbf34a70a9123fb3a6b4004.1716965617.git.ys...@users.sourceforge.jp The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [DO NOT MERGE v8 22/36] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema
On Wed, 29 May 2024 17:01:08 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > .../bindings/display/smi,sm501.yaml | 443 ++ > 1 file changed, 443 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/smi,sm501.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/smi,sm501.yaml: crt: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/smi,sm501.yaml: panel: Missing additionalProperties/unevaluatedProperties constraint doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2fb214e148e74fb0acc202543dca8dd8a170a6e6.1716965617.git.ys...@users.sourceforge.jp The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705
On Tue, 18 Jun 2024 16:59:38 +0300, Dzmitry Sankouski wrote:
> maxim,max77705 is MAX77705 pmic binding part
>
> Signed-off-by: Dzmitry Sankouski
> ---
> .../devicetree/bindings/mfd/maxim,max77705.yaml| 112
> +
> MAINTAINERS| 1 +
> 2 files changed, 113 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
pmic@66: charger: False schema does not allow {'compatible':
['maxim,max77705-charger'], 'monitored-battery': [[4294967295]], 'phandle':
[[2]]}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
pmic@66: fuelgauge: False schema does not allow {'compatible':
['maxim,max77705-fg'], 'monitored-battery': [[4294967295]], 'power-supplies':
[[2]], 'rsense': [[5]]}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
pmic@66: haptic: False schema does not allow {'compatible':
['maxim,max77705-haptic'], 'haptic-supply': [[4294967295]], 'pwms':
[[4294967295, 0, 5]]}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
pmic@66: leds: False schema does not allow {'compatible':
['maxim,max77705-led'], '#address-cells': [[1]], '#size-cells': [[0]], 'led@1':
{'reg': [[1]], 'label': ['red:usr1']}, 'led@2': {'reg': [[2]], 'label':
['green:usr2']}, 'led@3': {'reg': [[3]], 'label': ['blue:usr3']}}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
/example-0/i2c14/pmic@66/leds: failed to match any schema with compatible:
['maxim,max77705-led']
Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
/example-0/i2c14/pmic@66/charger: failed to match any schema with compatible:
['maxim,max77705-charger']
Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
/example-0/i2c14/pmic@66/fuelgauge: failed to match any schema with compatible:
['maxim,max77705-fg']
Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb:
/example-0/i2c14/pmic@66/haptic: failed to match any schema with compatible:
['maxim,max77705-haptic']
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-4-e3f666201...@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05
On Tue, 18 Jun 2024 16:59:43 +0300, Dzmitry Sankouski wrote: > add samsung,s2dos05 core MFD module binding > > Signed-off-by: Dzmitry Sankouski > --- > .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 > ++ > MAINTAINERS| 1 + > 2 files changed, 90 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mfd/samsung,s2dos05.example.dtb: /example-0/i2c/pmic@60: failed to match any schema with compatible: ['samsung,s2dos05'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-9-e3f666201...@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705
On Tue, 18 Jun 2024 16:59:41 +0300, Dzmitry Sankouski wrote: > add maxim,max77705 fuel gauge binding part > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/power/supply/maxim,max77705-fg.yaml | 35 > ++ > 1 file changed, 35 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: fuelgauge: 'monitored-battery', 'power-supplies' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: fuelgauge: 'monitored-battery', 'power-supplies' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/power/supply/maxim,max77705-fg.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-7-e3f666201...@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 18/23] dt-bindings: allwinner: add H616 DE33 bus, clock and display bindings
On Thu, 20 Jun 2024 23:29:56 +1200, Ryan Walklin wrote:
> The Allwinner H616 and variants have a new display engine revision
> (DE33).
>
> Add display engine bus, clock and mixer bindings for the DE33.
>
> Signed-off-by: Ryan Walklin
> ---
> .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 ---
> .../bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 +
> .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 +
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml:27:9:
[warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.example.dtb:
bus@100: compatible: ['allwinner,sun50i-a64-de2'] is valid under each of
{'items': [{'const': 'allwinner,sun50i-a64-de2'}], 'type': 'array', 'minItems':
1, 'maxItems': 1}, {'items': [{'const': 'allwinner,sun50i-a64-de2'}], 'type':
'array', 'minItems': 1, 'maxItems': 1}
from schema $id:
http://devicetree.org/schemas/bus/allwinner,sun50i-a64-de2.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240620113150.83466-19-r...@testtoast.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell
On Mon, 24 Jun 2024 03:30:26 +0200, Caleb Connolly wrote: > Document the Synaptics TCM oncell series of touchscreens, starting with > the s3908. > > Signed-off-by: Caleb Connolly > --- > .../input/touchscreen/syna,tcm-oncell.yaml | 66 > ++ > 1 file changed, 66 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/input/touchscreen/syna,s3908.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dts:27.13-26: Warning (reg_format): /example-0/i2c/touchscreen@4b:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dts:21.13-36.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dts:21.13-36.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dts:25.26-35.13: Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@4b: Relying on default #address-cells value Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dts:25.26-35.13: Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@4b: Relying on default #size-cells value Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240624-oneplus8-v1-2-388eecf2d...@postmarketos.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 1/8] dt-bindings: panel: document Samsung AMB655X
On Sun, 30 Jun 2024 20:36:24 +0200, Caleb Connolly wrote: > Describe the Samsung AMB655X panel. It has three supplies. > > Signed-off-by: Caleb Connolly > --- > .../bindings/display/panel/samsung,amb655x.yaml| 63 > ++ > 1 file changed, 63 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dts:20.11-21: Warning (reg_format): /example-0/panel@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240630-oneplus8-v2-1-c4a1f8da7...@postmarketos.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings
On Tue, 07 May 2024 21:52:28 +0800, Cong Yang wrote: > In V1, discussed with Doug and Linus [1], we need break out as separate > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02" > and in this series "BOE nv110wum-l60" "IVO t109nw41" panels use same > controller, they have some common CMDS. So add new documentation for > this panels. > > For himax83102-j02 controller, no need 3v3 supply, so remove it. > > [1]: > https://lore.kernel.org/all/CACRpkdbzYZAS0=zbqjuc4cb2wj4s1h6n6asazqvdmv95r3z...@mail.gmail.com > > Signed-off-by: Cong Yang > --- > Chage since V4: > > - Update commit message and add fallback compatible. > > V3: > https://lore.kernel.org/all/20240424023010.2099949-2-yangco...@huaqin.corp-partner.google.com > > Chage since V3: > > - Update commit message. > > V2: > https://lore.kernel.org/all/20240422090310.3311429-2-yangco...@huaqin.corp-partner.google.com > > --- > .../display/panel/boe,tv101wum-nl6.yaml | 2 - > .../bindings/display/panel/himax,hx83102.yaml | 73 +++ > 2 files changed, 73 insertions(+), 2 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: panel@0: compatible:0: 'starry,himax83102-j02, himax,hx83102' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$' from schema $id: http://devicetree.org/schemas/dt-core.yaml# Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['starry,himax83102-j02, himax,hx83102'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240507135234.1356855-2-yangco...@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 1/3] dt-bindings: display: mediatek: Add OF graph support for board path
On Thu, 02 May 2024 13:56:20 +0200, AngeloGioacchino Del Regno wrote: > The display IPs in MediaTek SoCs support being interconnected with > different instances of DDP IPs (for example, merge0 or merge1) and/or > with different DDP IPs (for example, rdma can be connected with either > color, dpi, dsi, merge, etc), forming a full Display Data Path that > ends with an actual display. > > The final display pipeline is effectively board specific, as it does > depend on the display that is attached to it, and eventually on the > sensors supported by the board (for example, Adaptive Ambient Light > would need an Ambient Light Sensor, otherwise it's pointless!), other > than the output type. > > Add support for OF graphs to most of the MediaTek DDP (display) bindings > to add flexibility to build custom hardware paths, hence enabling board > specific configuration of the display pipeline and allowing to finally > migrate away from using hardcoded paths. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,aal.yaml| 40 +++ > .../display/mediatek/mediatek,ccorr.yaml | 21 ++ > .../display/mediatek/mediatek,color.yaml | 22 ++ > .../display/mediatek/mediatek,dither.yaml | 22 ++ > .../display/mediatek/mediatek,dpi.yaml| 25 +++- > .../display/mediatek/mediatek,dsc.yaml| 24 +++ > .../display/mediatek/mediatek,dsi.yaml| 27 - > .../display/mediatek/mediatek,ethdr.yaml | 22 ++ > .../display/mediatek/mediatek,gamma.yaml | 19 + > .../display/mediatek/mediatek,merge.yaml | 23 +++ > .../display/mediatek/mediatek,od.yaml | 22 ++ > .../display/mediatek/mediatek,ovl-2l.yaml | 22 ++ > .../display/mediatek/mediatek,ovl.yaml| 22 ++ > .../display/mediatek/mediatek,postmask.yaml | 21 ++ > .../display/mediatek/mediatek,rdma.yaml | 22 ++ > .../display/mediatek/mediatek,ufoe.yaml | 21 ++ > 16 files changed, 372 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v3 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path
On Thu, 02 May 2024 13:56:21 +0200, AngeloGioacchino Del Regno wrote: > Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths > per HW instance (so potentially up to six displays for multi-vdo SoCs). > > The MMSYS or VDOSYS is always the first component in the DDP pipeline, > so it only supports an output port with multiple endpoints - where each > endpoint defines the starting point for one of the (currently three) > possible hardware paths. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 23 +++ > 1 file changed, 23 insertions(+) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v5 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Mon, 09 Sep 2024 10:31:46 +0800, Jianeng Ceng wrote: > This is v5 of the MT8186 Chromebook device tree series. > --- > Changes in v5: > - PATCH 1/2: Remove sku2147483647. > - PATCH 2/2: Remove sku2147483647. > - Link to > v4:https://lore.kernel.org/all/20240906085739.1322676-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to > v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v3: > - PATCH 0/2: Add the modify records. > - PATCH 1/2: Modify lable to label. > - Link to > v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v2: > - PATCH 2/2: Modify the dtb name without rev2. > - Link to > v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com/ > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 10 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 23 ++ > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 27 > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 106 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240909023148.1677936-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: touchpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml arch/arm64/boot/dts/medi
Re: [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs
On Tue, 10 Sep 2024 14:19:19 +0300, Tomi Valkeinen wrote: > The DP subsystem for ZynqMP supports audio via two channels, and the DP > DMA has dma-engines for those channels. For some reason the DT binding > has not specified those channels, even if the picture included in > xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs. > > This hasn't caused any issues as the drivers have not supported audio, > and has thus gone unnoticed. > > To make it possible to add the audio support to the driver, add the two > audio DMAs to the binding. While strictly speaking this is an ABI break, > there should be no regressions caused by this as we're adding new > entries at the end of the dmas list, and, after the audio support has > been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver > will treat the audio DMAs as optional to also support the old bindings. > > Signed-off-by: Tomi Valkeinen > --- > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml| 10 > ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on SA8775P
On Thu, 12 Sep 2024 12:44:33 +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > .../display/msm/qcom,sa8775p-mdss.yaml| 225 ++ > 1 file changed, 225 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml: ^display-controller@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml: ^displayport-controller@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dts:24:18: fatal error: dt-bindings/clock/qcom,sa8775p-dispcc.h: No such file or directory 24 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:442: Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1432: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240912071437.1708969-2-quic_ma...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for SA8775P
On Thu, 12 Sep 2024 12:44:34 +0530, Mahadevan wrote: > Document the DPU for Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > .../display/msm/qcom,sa8775p-dpu.yaml | 120 ++ > 1 file changed, 120 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-dpu.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240912071437.1708969-3-quic_ma...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v7 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Fri, 13 Sep 2024 11:15:03 +0800, Jianeng Ceng wrote: > This is v7 of the MT8186 Chromebook device tree series. > --- > Changes in v7: > - PATCH 2/2: Remove prototype sku. > - PATCH 2/2: Disable the other trackpad to enable one of them. > - Link to > v5:https://lore.kernel.org/all/20240913015503.4192806-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v6: > - No change. > > Changes in v5: > - PATCH 1/2: Remove sku2147483647. > - PATCH 2/2: Remove sku2147483647. > - Link to > v4:https://lore.kernel.org/all/20240906085739.1322676-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to > v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v3: > - PATCH 0/2: Add the modify records. > - PATCH 1/2: Modify lable to label. > - Link to > v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v2: > - PATCH 2/2: Modify the dtb name without rev2. > - Link to > v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com/ > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 10 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 18 > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 22 ++ > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 96 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240913031505.372868-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/
Re: [PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705
On Fri, 13 Sep 2024 18:07:48 +0300, Dzmitry Sankouski wrote: > Add maxim,max77705 core binding part. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove interrupt-names property > - remove obvious reg description > - split long(>80) lines > --- > .../devicetree/bindings/mfd/maxim,max77705.yaml| 169 > + > MAINTAINERS| 1 + > 2 files changed, 170 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: fuel_gauge: 'shunt-resistor-micro-ohms' is a required property from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240913-starqltechn_integration_upstream-v4-5-2d2efd5c5...@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta
On Sat, 14 Sep 2024 14:31:20 +0800, Jianeng Ceng wrote: > This is v8 of the MT8186 Chromebook device tree series. > --- > Changes in v8: > - PATCH 1/2: Remove custom label. > - PATCH 2/2: Change the commit about ponyta. > - Link to > v7:https://lore.kernel.org/all/20240913031505.372868-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v7: > - PATCH 2/2: Remove prototype sku. > - PATCH 2/2: Disable the other trackpad to enable one of them. > - Link to > v5:https://lore.kernel.org/all/20240913015503.4192806-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v6: > - No change. > > Changes in v5: > - PATCH 1/2: Remove sku2147483647. > - PATCH 2/2: Remove sku2147483647. > - Link to > v4:https://lore.kernel.org/all/20240906085739.1322676-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to > v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v3: > - PATCH 0/2: Add the modify records. > - PATCH 1/2: Modify lable to label. > - Link to > v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ > > Changes in v2: > - PATCH 2/2: Modify the dtb name without rev2. > - Link to > v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjian...@huaqin.corp-partner.google.com/ > > Jianeng Ceng (2): > dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook > arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks > > .../devicetree/bindings/arm/mediatek.yaml | 10 + > arch/arm64/boot/dts/mediatek/Makefile | 2 + > .../mediatek/mt8186-corsola-ponyta-sku0.dts | 18 > .../mediatek/mt8186-corsola-ponyta-sku1.dts | 22 ++ > .../dts/mediatek/mt8186-corsola-ponyta.dtsi | 44 +++ > 5 files changed, 96 insertions(+) > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts > create mode 100644 > arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240914063122.1622196-1-cengjian...@huaqin.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: [
Re: [DO NOT MERGE v8 21/36] dt-bindings: serial: renesas,scif: Add scif-sh7751.
On Wed, 29 May 2024 17:01:07 +0900, Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato > Reviewed-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH] dt-bindings: display: bridge: tc358767: Keep enum sorted
On Fri, 31 May 2024 22:30:18 +0200, Marek Vasut wrote: > Keep the list sorted numerically. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: Conor Dooley > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Robert Foss > Cc: Thomas Zimmermann > Cc: devicet...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: ker...@dh-electronics.com > --- > .../devicetree/bindings/display/bridge/toshiba,tc358767.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)
On Wed, 05 Jun 2024 12:56:59 +0200, Krzysztof Kozlowski wrote: > DSI-attached devices could respond to more than one virtual channel > number, thus their bindings are supposed to constrain the 'reg' property > to match hardware. Add missing 'reg' constrain for DSI-attached display > panels, based on DTS sources in Linux kernel (assume all devices take > only one channel number). > > Few bindings missed previous fixup: LG SW43408 and Raydium RM69380. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This should apply on any tree. > --- > .../devicetree/bindings/display/panel/lg,sw43408.yaml| 4 +++- > .../devicetree/bindings/display/panel/raydium,rm69380.yaml | 5 +++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > Applied, thanks!
Re: [PATCH v3 2/4] dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998
On Thu, 06 Jun 2024 18:07:48 +0200, Marc Gonzalez wrote: > HDMI TX block embedded in the APQ8098. > > Signed-off-by: Marc Gonzalez > --- > .../devicetree/bindings/display/msm/hdmi.yaml | 28 > -- > 1 file changed, 26 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 3/4] dt-bindings: display/msm: Add SM7150 DPU
On Wed, 12 Jun 2024 01:37:42 +0300, Danila Tikhonov wrote: > Document the DPU hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 145 ++ > 1 file changed, 145 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.example.dts:24:18: fatal error: dt-bindings/clock/qcom,sm7150-dispcc.h: No such file or directory 24 | #include | ^~~~ compilation terminated. make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611223743.113223-4-dan...@jiaxyga.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 1/4] dt-bindings: display/msm: Add SM7150 MDSS
On Wed, 12 Jun 2024 01:37:40 +0300, Danila Tikhonov wrote: > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- > .../display/msm/qcom,sm7150-mdss.yaml | 460 ++ > 1 file changed, 460 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,sm7150-dispcc.h: No such file or directory 25 | #include | ^~~~ compilation terminated. make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611223743.113223-2-dan...@jiaxyga.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 0/9] New DRM accel driver for Rockchip's RKNN NPU
On Wed, 12 Jun 2024 15:52:53 +0200, Tomeu Vizoso wrote: > This series adds a new driver for the NPU that Rockchip includes in its > newer SoCs, developed by them on the NVDLA base. > > In its current form, it supports the specific NPU in the RK3588 SoC. > > The userspace driver is part of Mesa and an initial draft can be found at: > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29698 > > Signed-off-by: Tomeu Vizoso > --- > Tomeu Vizoso (9): > iommu/rockchip: Add compatible for rockchip,rk3588-iommu > iommu/rockchip: Attach multiple power domains > dt-bindings: mailbox: rockchip,rknn: Add bindings > arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s > arm64: dts: rockchip: Enable the NPU on quartzpro64 > accel/rocket: Add a new driver for Rockchip's NPU > accel/rocket: Add IOCTL for BO creation > accel/rocket: Add job submission IOCTL > accel/rocket: Add IOCTLs for synchronizing memory accesses > > .../devicetree/bindings/npu/rockchip,rknn.yaml | 123 + > MAINTAINERS|8 + > .../arm64/boot/dts/rockchip/rk3588-quartzpro64.dts |8 + > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 53 + > drivers/accel/Kconfig |1 + > drivers/accel/Makefile |1 + > drivers/accel/rocket/Kconfig | 13 + > drivers/accel/rocket/Makefile | 10 + > drivers/accel/rocket/rocket_core.c | 155 + > drivers/accel/rocket/rocket_core.h | 48 + > drivers/accel/rocket/rocket_device.c | 39 + > drivers/accel/rocket/rocket_device.h | 40 + > drivers/accel/rocket/rocket_drv.c | 243 ++ > drivers/accel/rocket/rocket_drv.h | 16 + > drivers/accel/rocket/rocket_gem.c | 136 + > drivers/accel/rocket/rocket_gem.h | 33 + > drivers/accel/rocket/rocket_job.c | 708 > drivers/accel/rocket/rocket_job.h | 49 + > drivers/accel/rocket/rocket_registers.h| 4449 > > drivers/iommu/rockchip-iommu.c | 39 + > include/uapi/drm/rocket_accel.h| 116 + > 21 files changed, 6288 insertions(+) > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240612-6-10-rocket-9316defc14c7 > > Best regards, > -- > Tomeu Vizoso > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3588-quartzpro64.dtb' for 20240612-6-10-rocket-v1-0-060e48eea...@tomeuvizoso.net: arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rk3588-iommu'] is too short 'rockchip,rk3588-iommu' is not one of ['rockchip,iommu', 'rockchip,rk3568-iommu'] from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: reg: [[0, 4255879168, 0, 256], [0, 4255883264, 0, 256], [0, 4255948800, 0, 256], [0, 4256014336, 0, 256]] is too long from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: interrupts: [[0, 110, 4, 0], [0, 111, 4, 0], [0, 112, 4, 0]] is too long from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: clocks: [[28, 287], [28, 276], [28, 278], [28, 288], [28, 277], [28, 279]] is too long from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: clock-names:0: 'aclk' was expected from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: clock-names:1: 'iface' was expected from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: clock-names: ['aclk0', 'aclk1', 'aclk2', 'iface0', 'iface1', 'iface2'] is too long from schema $id: http://devicetree.org/schemas/iommu/rockchip,iommu.yaml# arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb: iommu@fdab9000: power-domains: [[30, 9], [30, 10], [30, 11]] is too long fro
Re: [PATCH 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml
On Tue, 08 Oct 2024 18:00:58 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > Additional Changes: > - Remove mfd parent node at example. > - Ref to backlight's common.yaml > > Signed-off-by: Frank Li > --- > .../leds/backlight/zii,rave-sp-backlight.txt | 23 -- > .../leds/backlight/zii,rave-sp-backlight.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 23 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-2-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 3/5] dt-bindings: nvmem: convert zii,rave-sp-eeprom.txt to yaml format
On Tue, 08 Oct 2024 18:00:59 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-eeprom.txt to yaml format. > Additional changes: > - Add ref to nvme.yaml. > - Add reg property. > - Remove mfd at example. > > Signed-off-by: Frank Li > --- > .../bindings/nvmem/zii,rave-sp-eeprom.txt | 40 > .../bindings/nvmem/zii,rave-sp-eeprom.yaml | 54 > ++ > 2 files changed, 54 insertions(+), 40 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-3-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 4/5] dt-bindings: watchdog: convert zii,rave-sp-wdt.txt to yaml format
On Tue, 08 Oct 2024 18:01:00 -0400, Frank Li wrote: > Convert device binding doc zii,rave-sp-wdt.txt to yaml format. > Additional changes: > - Ref to watchdog.yaml. > - Remove mfd node in example. > - Remove eeprom part in example. > > Signed-off-by: Frank Li > --- > .../bindings/watchdog/zii,rave-sp-wdt.txt | 39 -- > .../bindings/watchdog/zii,rave-sp-wdt.yaml | 47 > ++ > 2 files changed, 47 insertions(+), 39 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-4-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 1/5] dt-bindings: input: convert zii,rave-sp-pwrbutton.txt to yaml
On Tue, 08 Oct 2024 18:00:57 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-pwrbutton.txt to yaml format. > Additional changes: > - add ref to input.yaml. > - remove mfd node in example. > > Signed-off-by: Frank Li > --- > .../bindings/input/zii,rave-sp-pwrbutton.txt | 22 - > .../bindings/input/zii,rave-sp-pwrbutton.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 22 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-zii_yaml-v1-1-d06ba7e26...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v1 1/5] dt-bindings: dmaengine: qcom: gpi: Add additional arg to dma-cell property
On Tue, 15 Oct 2024 17:37:46 +0530, Jyothi Kumar Seerapu wrote: > When high performance with multiple i2c messages in a single transfer > is required, employ Block Event Interrupt (BEI) to trigger interrupts > after specific messages transfer and the last message transfer, > thereby reducing interrupts. > > For each i2c message transfer, a series of Transfer Request Elements(TREs) > must be programmed, including config tre for frequency configuration, > go tre for holding i2c address and dma tre for holding dma buffer address, > length as per the hardware programming guide. For transfer using BEI, > multiple I2C messages may necessitate the preparation of config, go, > and tx DMA TREs. However, a channel TRE size of 64 is often insufficient, > potentially leading to failures due to inadequate memory space. > > Add additional argument to dma-cell property for channel TRE size. > With this, adjust the channel TRE size via the device tree. > The default size is 64, but clients can modify this value based on > their specific requirements. > > Signed-off-by: Jyothi Kumar Seerapu > --- > Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: properties:#dma-cells: 'minItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf'] from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: properties:#dma-cells: 'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf'] from schema $id: http://devicetree.org/meta-schemas/core.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241015120750.21217-2-quic_jseer...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v4 2/5] dt-bindings: display/msm: Document the DPU for SA8775P
On Wed, 09 Oct 2024 20:02:02 +0530, Mahadevan wrote:
> Document the DPU for Qualcomm SA8775P platform.
>
> Signed-off-by: Mahadevan
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb:
display-controller@ae01000: clock-names:0: 'nrt_bus' was expected
from schema $id:
http://devicetree.org/schemas/display/msm/qcom,sm8650-dpu.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb:
display-controller@ae01000: Unevaluated properties are not allowed
('clock-names' was unexpected)
from schema $id:
http://devicetree.org/schemas/display/msm/qcom,sm8650-dpu.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009-patchv3_1-v4-2-cd683a9ca...@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml
On Thu, 10 Oct 2024 11:42:39 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > Additional Changes: > - Remove mfd parent node at example. > - Ref to backlight's common.yaml > > Signed-off-by: Frank Li > --- > .../leds/backlight/zii,rave-sp-backlight.txt | 23 -- > .../leds/backlight/zii,rave-sp-backlight.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 23 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241010-zii_yaml-v2-2-0ab730607...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml
On Thu, 10 Oct 2024 11:42:39 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > Additional Changes: > - Remove mfd parent node at example. > - Ref to backlight's common.yaml > > Signed-off-by: Frank Li > --- > .../leds/backlight/zii,rave-sp-backlight.txt | 23 -- > .../leds/backlight/zii,rave-sp-backlight.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 23 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 1/5] dt-bindings: input: convert zii,rave-sp-pwrbutton.txt to yaml
On Thu, 10 Oct 2024 11:42:38 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-pwrbutton.txt to yaml format. > Additional changes: > - add ref to input.yaml. > - remove mfd node in example. > > Signed-off-by: Frank Li > --- > .../bindings/input/zii,rave-sp-pwrbutton.txt | 22 - > .../bindings/input/zii,rave-sp-pwrbutton.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 22 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241010-zii_yaml-v2-1-0ab730607...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 3/5] dt-bindings: nvmem: convert zii,rave-sp-eeprom.txt to yaml format
On Thu, 10 Oct 2024 11:42:40 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-eeprom.txt to yaml format. > Additional changes: > - Add ref to nvme.yaml. > - Add reg property. > - Remove mfd at example. > > Signed-off-by: Frank Li > --- > .../bindings/nvmem/zii,rave-sp-eeprom.txt | 40 > .../bindings/nvmem/zii,rave-sp-eeprom.yaml | 54 > ++ > 2 files changed, 54 insertions(+), 40 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241010-zii_yaml-v2-3-0ab730607...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 4/5] dt-bindings: watchdog: convert zii,rave-sp-wdt.txt to yaml format
On Thu, 10 Oct 2024 11:42:41 -0400, Frank Li wrote: > Convert device binding doc zii,rave-sp-wdt.txt to yaml format. > Additional changes: > - Ref to watchdog.yaml. > - Remove mfd node in example. > - Remove eeprom part in example. > > Signed-off-by: Frank Li > --- > .../bindings/watchdog/zii,rave-sp-wdt.txt | 39 -- > .../bindings/watchdog/zii,rave-sp-wdt.yaml | 47 > ++ > 2 files changed, 47 insertions(+), 39 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241010-zii_yaml-v2-4-0ab730607...@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 3/5] dt-bindings: nvmem: convert zii,rave-sp-eeprom.txt to yaml format
On Thu, 10 Oct 2024 11:42:40 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-eeprom.txt to yaml format. > Additional changes: > - Add ref to nvme.yaml. > - Add reg property. > - Remove mfd at example. > > Signed-off-by: Frank Li > --- > .../bindings/nvmem/zii,rave-sp-eeprom.txt | 40 > .../bindings/nvmem/zii,rave-sp-eeprom.yaml | 54 > ++ > 2 files changed, 54 insertions(+), 40 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 1/5] dt-bindings: input: convert zii,rave-sp-pwrbutton.txt to yaml
On Thu, 10 Oct 2024 11:42:38 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-pwrbutton.txt to yaml format. > Additional changes: > - add ref to input.yaml. > - remove mfd node in example. > > Signed-off-by: Frank Li > --- > .../bindings/input/zii,rave-sp-pwrbutton.txt | 22 - > .../bindings/input/zii,rave-sp-pwrbutton.yaml | 36 > ++ > 2 files changed, 36 insertions(+), 22 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 4/5] dt-bindings: watchdog: convert zii,rave-sp-wdt.txt to yaml format
On Thu, 10 Oct 2024 11:42:41 -0400, Frank Li wrote: > Convert device binding doc zii,rave-sp-wdt.txt to yaml format. > Additional changes: > - Ref to watchdog.yaml. > - Remove mfd node in example. > - Remove eeprom part in example. > > Signed-off-by: Frank Li > --- > .../bindings/watchdog/zii,rave-sp-wdt.txt | 39 -- > .../bindings/watchdog/zii,rave-sp-wdt.yaml | 47 > ++ > 2 files changed, 47 insertions(+), 39 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2 5/5] dt-bindings: mfd: convert zii, rave-sp.txt to yaml format
On Thu, 10 Oct 2024 11:42:42 -0400, Frank Li wrote: > Convert device binding doc zii,rave-sp.txt to yaml format. > Additional change: > - ref to other zii yaml files. > - remove rave-sp-hwmon and rave-sp-leds. > > Signed-off-by: Frank Li > --- > .../devicetree/bindings/mfd/zii,rave-sp.txt| 39 -- > .../devicetree/bindings/mfd/zii,rave-sp.yaml | 63 > ++ > 2 files changed, 63 insertions(+), 39 deletions(-) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 3/5] dt-bindings: display/msm: merge SM8350 DPU into SC7280
On Thu, 03 Oct 2024 10:14:20 +0200, Krzysztof Kozlowski wrote: > Split of the bindings was artificial and not helping - we end up with > multiple binding files for very similar devices thus increasing the > chances of using different order of reg and clocks entries. > > Unify DPU bindings of SC7280 and SM8350, because they are the same. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/display/msm/qcom,sc7280-dpu.yaml | 1 + > .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120 > - > 2 files changed, 1 insertion(+), 120 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 4/5] dt-bindings: display/msm: merge SM8450 DPU into SC7280
On Thu, 03 Oct 2024 10:14:21 +0200, Krzysztof Kozlowski wrote: > Split of the bindings was artificial and not helping - we end up with > multiple binding files for very similar devices thus increasing the > chances of using different order of reg and clocks entries. > > Unify DPU bindings of SC7280 and SM8450, because they are the same. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/display/msm/qcom,sc7280-dpu.yaml | 2 + > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 139 > - > 2 files changed, 2 insertions(+), 139 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 1/5] dt-bindings: display/msm: merge SC8280XP DPU into SC7280
On Thu, 03 Oct 2024 10:14:18 +0200, Krzysztof Kozlowski wrote: > Split of the bindings was artificial and not helping - we end up with > multiple binding files for very similar devices thus increasing the > chances of using different order of reg and clocks entries. > > Unify DPU bindings of SC7280 and SC8280XP, because they are the same. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/display/msm/qcom,sc7280-dpu.yaml | 5 +- > .../bindings/display/msm/qcom,sc8280xp-dpu.yaml| 122 > - > 2 files changed, 4 insertions(+), 123 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 5/5] dt-bindings: display/msm: merge SM8550 DPU into SC7280
On Thu, 03 Oct 2024 10:14:22 +0200, Krzysztof Kozlowski wrote: > Split of the bindings was artificial and not helping - we end up with > multiple binding files for very similar devices thus increasing the > chances of using different order of reg and clocks entries. > > Unify DPU bindings of SC7280 and SM8550, because they are the same. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/display/msm/qcom,sc7280-dpu.yaml | 2 + > .../bindings/display/msm/qcom,sm8550-dpu.yaml | 133 > - > 2 files changed, 2 insertions(+), 133 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width
On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. Deprecate > "data-lines" and use the common property. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 05/37] dt-bindings: display: Add BCM2712 HVS bindings
On Wed, 23 Oct 2024 17:50:02 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 has a completely different HVS than the previous > generations, so let's add a new compatible for it. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 04/37] dt-bindings: display: Add BCM2712 HDMI bindings
On Wed, 23 Oct 2024 17:50:01 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 HDMI controller uses a slightly different HDMI controller > than the BCM2711, and a completely different PHY. > > Let's introduce a new compatible for it. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH 07/37] dt-bindings: display: Add BCM2712 MOP bindings
On Wed, 23 Oct 2024 17:50:04 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 has a MOP controller which is basically a new revision of > the TXP. > > Express that by adding a new compatible for it. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH 09/37] dt-bindings: display: Add BCM2712 KMS driver bindings
On Wed, 23 Oct 2024 17:50:06 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 SoC comes with a new variation of the videocore display > pipeline. Let's create a new compatible for it. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH v3 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback
On Tue, 29 Oct 2024 16:16:38 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam > --- > Changes since v2: > - Only document fsl,imx6sx-lcdif with a fallback. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/fsl,lcdif.example.dtb: display-controller@222: compatible: 'oneOf' conditional failed, one must be fixed: ['fsl,imx6sx-lcdif'] is too short 'fsl,imx6sx-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif'] 'fsl,imx6sx-lcdif' is not one of ['fsl,imx6sl-lcdif', 'fsl,imx6sll-lcdif', 'fsl,imx6ul-lcdif', 'fsl,imx7d-lcdif', 'fsl,imx8mm-lcdif', 'fsl,imx8mn-lcdif', 'fsl,imx8mq-lcdif'] from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241029191640.379315-1-feste...@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
On Fri, 01 Nov 2024 10:54:05 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > > This causes dt-schema warnings as the current binding only > allow 'fsl,imx6sx-lcdif' as fallback. > > ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long > ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long > > The imx6sx-lcdif programming model has more advanced features, such > as overlay plane and the CRC32 support than the imx28-lcdif IP. > > Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific > fsl,imx28-lcdif fallback: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This helps keeping DT compatibility as well as using the more advanced > lcdif features found on imx6sl and imx6sll. > > Signed-off-by: Fabio Estevam > --- > Changes since v3: > - None. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback
On Fri, 01 Nov 2024 10:54:04 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam > --- > Changes since v3: > - Also update the example. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Acked-by: Rob Herring (Arm)
Re: [PATCH v5 08/13] dt-bindings: display: Document dual-link LVDS display common properties
On Mon, 04 Nov 2024 11:28:01 +0800, Liu Ying wrote: > Dual-link LVDS displays receive odd pixels and even pixels separately from > dual LVDS links. One link receives odd pixels and the other receives even > pixels. Some of those displays may also use only one LVDS link to receive > all pixels, being odd and even agnostic. Document common properties for > those displays by extending LVDS display common properties defined in > lvds.yaml. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Liu Ying > --- > v5: > * Use patternProperties to define port@0 and port@1. (Biju) > * Require port@0 or port@1. > > v4: > * Squash change for advantech,idk-2121wr.yaml and > panel-simple-lvds-dual-ports.yaml with lvds-dual-ports.yaml. (Rob) > * Improve description in lvds-dual-ports.yaml. (Krzysztof) > > v3: > * New patch. (Dmitry) > > .../bindings/display/lvds-dual-ports.yaml | 63 +++ > .../display/panel/advantech,idk-2121wr.yaml | 14 + > .../panel/panel-simple-lvds-dual-ports.yaml | 20 +- > 3 files changed, 65 insertions(+), 32 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/lvds-dual-ports.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH v2] dt-bindings: display: mediatek: dp: Reference common DAI properties
On Tue, 05 Nov 2024 17:00:28 +0800, Fei Shao wrote: > The MediaTek DP hardware supports audio and exposes a DAI, so the > '#sound-dai-cells' property is needed for describing the DAI links. > > Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be > used, and filter out non-DP compatibles as MediaTek eDP in the same > binding doesn't support audio. > > This fixes dtbs_check error: > '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Fei Shao > --- > > Changes in v2: > - reference to dai-common.yaml since the hardware exposes DAI > and update to `unevaluatedProperties: false` > - update commit message > > .../display/mediatek/mediatek,dp.yaml | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm)
[PATCH] drm: Use of_property_present() for non-boolean properties
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.
Signed-off-by: Rob Herring (Arm)
---
drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
drivers/gpu/drm/bridge/sii902x.c | 2 +-
drivers/gpu/drm/drm_panel.c | 2 +-
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c
b/drivers/gpu/drm/bridge/ite-it66121.c
index 925e42f46cd8..0eae7c01b975 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -1480,7 +1480,7 @@ static int it66121_audio_codec_init(struct it66121_ctx
*ctx, struct device *dev)
dev_dbg(dev, "%s\n", __func__);
- if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) {
+ if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
dev_info(dev, "No \"#sound-dai-cells\", no audio\n");
return 0;
}
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 7f91b0db161e..f73e1174a5ad 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -850,7 +850,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
u8 lanes[4];
int num_lanes, i;
- if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) {
+ if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",
__func__);
return 0;
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index 19ab0a794add..46d61cc871ca 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -413,7 +413,7 @@ bool drm_is_panel_follower(struct device *dev)
* don't bother trying to parse it here. We just need to know if the
* property is there.
*/
- return of_property_read_bool(dev->of_node, "panel");
+ return of_property_present(dev->of_node, "panel");
}
EXPORT_SYMBOL(drm_is_panel_follower);
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 185d7de0bf37..78cac4ecc58f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1831,7 +1831,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host
*msm_host)
msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL);
ret = 0;
- if (of_property_read_bool(np, "syscon-sfpb")) {
+ if (of_property_present(np, "syscon-sfpb")) {
msm_host->sfpb = syscon_regmap_lookup_by_phandle(np,
"syscon-sfpb");
if (IS_ERR(msm_host->sfpb)) {
--
2.45.2
Re: [PATCH v4 09/13] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter
On Mon, 28 Oct 2024 10:37:36 +0800, Liu Ying wrote: > Document ITE IT6263 LVDS to HDMI converter. > > Product link: > https://www.ite.com.tw/en/product/cate1/IT6263 > > Signed-off-by: Liu Ying > --- > v4: > * Require dual-lvds-odd-pixels or dual-lvds-even-pixels DT properties for > port@1. > * Drop "data-mirror: true"(30-bit LVDS data bit order is not reversed). > > v3: > * Reference lvds-dual-ports.yaml. (Dmitry) > * Add data-mapping DT property. (Dmitry, Biju) > * Allow data-mirror. > * Drop ite,lvds-link-num-data-lanes DT property. (Dmitry, Biju) > > v2: > * Document number of LVDS link data lanes. (Biju) > * Simplify ports property by dropping "oneOf". (Rob) > > .../bindings/display/bridge/ite,it6263.yaml | 250 ++ > 1 file changed, 250 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/ite,it6263.yaml > Reviewed-by: Rob Herring (Arm)
Re: [PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A
On Wed, 23 Oct 2024 14:44:09 +0200, Rouven Czerwinski wrote: > The LXD M9189A is a 1024x600 MIPI-DSI panel. > > Signed-off-by: Rouven Czerwinski > --- > .../bindings/display/panel/lxd,m9189a.yaml| 64 +++ > 1 file changed, 64 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Warning: Duplicate compatible "ronbo,rb070d30" found in schemas matching "$id": http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml# http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml# Documentation/devicetree/bindings/display/panel/lxd,m9189a.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['lxd,m9189a'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241023124411.1153552-2-r.czerwin...@pengutronix.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 00/36] drm/vc4: Add support for BCM2712 / Pi5 display hardware
On Fri, 25 Oct 2024 18:15:31 +0100, Dave Stevenson wrote: > This series adds the required DRM, clock, and DT changes > required to support the display hardware on Pi5. > There are a couple of minor fixes first before the main patches. > > Many of the patches were authored by Maxime whilst working > for us, however there have been a number of fixes squashed > into his original patches as issues have been found. I also > reworked the way UBM allocations are done to avoid double > buffering of the handles as they are quite a limited resource. > > There are 2 variants of the IP. Most Pi5's released to date > have used the C1 step of the SoC, whilst the 2GB Pi5 released > in August is using the D0 step, as will other boards in future. > > Due to various reasons the register map got reworked between > the steps, so there is extra code to handle the differences. > Which step is in use is read out of the hardware, so they > share a compatible string. > > Thanks! > > Signed-off-by: Dave Stevenson > --- > Changes in v2: > - Collected Acks and R-b tags > - Dropped patch 1 "drm/vc4: Limit max_bpc to 8 on Pi0-3". Already fixed as > noted by Maxime. > - Fix unintialised var "mux" in vc6_hvs_pv_muxing_commit. > - Fixed uninitialised var "reg" in vc4_hvs_cob_init. > - Make bcm2712_mop_data and bcm2712_moplet_data static. > - Removed the "disable_turbo" line from the struct in > raspberrypi_clock_property > - I'm confused by the CI error "performing pointer arithmetic on a null > pointer has undefined behavior" for PCI_IOBASE as I'm not using it. > - Link to v1: > https://lore.kernel.org/r/20241023-drm-vc4-2712-support-v1-0-1cc2d5594...@raspberrypi.com > > --- > Dave Stevenson (11): > drm/vc4: Use of_device_get_match_data to set generation > drm/vc4: Fix reading of frame count on GEN5 / Pi4 > drm/vc4: drv: Add support for 2712 D-step > drm/vc4: hvs: Add in support for 2712 D-step. > drm/vc4: plane: Add support for 2712 D-step. > drm/vc4: hdmi: Support 2712 D-step register map > drm/vc4: Enable bg_fill if there are no planes enabled > drm/vc4: Drop planes that are completely off-screen or 0 crtc size > arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT > arm64: dts: broadcom: Add display pipeline support to BCM2712 > arm64: dts: broadcom: Add DT for D-step version of BCM2712 > > Dom Cobley (3): > clk: bcm: rpi: Add ISP to exported clocks > clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks > clk: bcm: rpi: Enable minimize for all firmware clocks > > Maxime Ripard (22): > dt-bindings: display: Add BCM2712 HDMI bindings > dt-bindings: display: Add BCM2712 HVS bindings > dt-bindings: display: Add BCM2712 PixelValve bindings > dt-bindings: display: Add BCM2712 MOP bindings > dt-bindings: display: Add BCM2712 MOPLET bindings > dt-bindings: display: Add BCM2712 KMS driver bindings > drm/vc4: drv: Support BCM2712 > drm/vc4: hvs: Add support for BCM2712 HVS > drm/vc4: crtc: Add support for BCM2712 PixelValves > drm/vc4: hdmi: Add support for BCM2712 HDMI controllers > drm/vc4: txp: Introduce structure to deal with revision differences > drm/vc4: txp: Rename TXP data structure > drm/vc4: txp: Add byte enable toggle bit > drm/vc4: txp: Add horizontal and vertical size offset toggle bit > drm/vc4: txp: Handle 40-bits DMA Addresses > drm/vc4: txp: Move the encoder type in the variant structure > drm/vc4: txp: Add a new TXP encoder type > drm/vc4: txp: Add support for BCM2712 MOP > drm/vc4: txp: Add BCM2712 MOPLET support > drm/vc4: Add additional warn_on for incorrect revisions > clk: bcm: rpi: Create helper to retrieve private data > clk: bcm: rpi: Add disp clock > > .../bindings/display/brcm,bcm2711-hdmi.yaml| 2 + > .../bindings/display/brcm,bcm2835-hvs.yaml | 5 +- > .../bindings/display/brcm,bcm2835-pixelvalve0.yaml | 3 + > .../bindings/display/brcm,bcm2835-txp.yaml | 5 +- > .../bindings/display/brcm,bcm2835-vc4.yaml | 1 + > arch/arm64/boot/dts/broadcom/Makefile | 1 + > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 37 + > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 42 + > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 188 + > drivers/clk/bcm/clk-raspberrypi.c | 33 +- > drivers/gpu/drm/vc4/tests/vc4_mock.c | 8 +- > drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 106 +-- > drivers/gpu/drm/vc4/vc4_crtc.c | 96 ++- > drivers/gpu/drm/vc4/vc4_drv.c | 19 +- > drivers/gpu/drm/vc4/vc4_drv.h | 54 +- > drivers/gpu/drm/vc4/vc4_hdmi.c | 107 ++- > drivers/gpu/drm/vc4/vc4_hdmi.h | 4 + > drivers/gpu/drm/vc4/vc4_hdmi_phy.c | 640 +++
Re: [PATCH v3 00/10] Initial support for Samsung Galaxy Tab 2 series
On Fri, 08 Nov 2024 20:04:29 +, Mithil Bavishi wrote: > This series adds initial support for the Samsung Galaxy Tab 2 > (samsung-espresso7/10) series of devices. It adds support for 6 variants > (P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them > based on 3G and WiFi, but since they use different panel, touch > controllers, batteries, I decided to categorise them based on screen > size as espresso7 and espresso10. > > It adds basic functionality for both the models including panel, drm, > sdcard, touchscreen, mmc, wifi, bluetooth, keys, battery, fuel gauge, > pmic, sensors. > > Signed-off-by: Mithil Bavishi > --- > Changes in v3 > - Use device tree from the correct branch > - Fix commit subjects to matching the subsystem > - Add Doestek vendor > - Add compatible for LVDS encoder > - Add compatibles for 7 and 10 inch panels > - Clean up device tree using "make CHECK_DTBS=y" > - Link to v2: > https://lore.kernel.org/all/20241030211215.347710-1-bavishimit...@gmail.com/ > Changes in v2 > - Fix node names in common dtsi to have - instead of _ > - Removed import for twl6030.dtsi > - Edited dts to completely use twl6032 nodes > - Fixed typo ldosb -> ldousb > - Link to v1: > https://lore.kernel.org/all/20241030194136.297648-1-bavishimit...@gmail.com/ > > -- > Mithil Bavishi (10): > ARM: dts: twl6032: Add DTS file for TWL6032 PMIC > dt-bindings: vendor-prefixes: Add Doestek > dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am > dt-bindings: display: panel-lvds: Add compatible for Samsung > LTN070NL01 Panel > dt-bindings: display: panel-lvds: Add compatible for Samsung > LTN101AL03 Panel > ARM: dts: ti: omap: espresso-common: Add common device tree for > Samsung Galaxy Tab 2 series > dt-bindings: omap: Add Samsung Galaxy Tab 2 7.0 > ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy > Tab 2 7.0 > dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1 > ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy > Tab 2 10.1 > > .../devicetree/bindings/arm/ti/omap.yaml | 2 + > .../bindings/display/bridge/lvds-codec.yaml | 1 + > .../bindings/display/panel/panel-lvds.yaml| 4 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > .../omap/omap4-samsung-espresso-common.dtsi | 680 ++ > .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 +++ > .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 ++ > arch/arm/boot/dts/ti/omap/twl6032.dtsi| 77 ++ > 8 files changed, 938 insertions(+) > create mode 100644 > arch/arm/boot/dts/ti/omap/omap4-samsung-espresso-common.dtsi > create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts > create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts > create mode 100644 arch/arm/boot/dts/ti/omap/twl6032.dtsi > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y ti/omap/omap4-samsung-espresso10.dtb ti/omap/omap4-samsung-espresso7.dtb' for 20241108200440.7562-1-bavishimit...@gmail.com: arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: sram@40304000: '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: sram@40304000: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: sram@40304000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: /interrupt-controller@48281000: failed to match any schema with compatible: ['ti,omap4-wugen-mpu'] arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: ocp: $nodename:0: 'ocp' does not match '^bus(@[0-9a-f]+)?$' from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml# arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: /ocp/l3-noc@4400: failed to match any schema with compatible: ['ti,omap4-l3-noc'] arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: interconnect@4a30: $nodename:0: 'interconnect@4a30' does not match '^bus(@[0-9a-f]+)?$' from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml# arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb: /ocp/interconnect@4a30: failed to match any schema with compatible: ['ti,omap4-l4-wkup', 'simple-pm-bus'] arch/arm/boot/dts/ti
Re: [PATCH 08/37] dt-bindings: display: Add BCM2712 MOPLET bindings
On Wed, 23 Oct 2024 17:50:05 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 has a MOPLET controller which is basically a TXP without the > transpose feature. > > Express that by adding a new compatible for it. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH 06/37] dt-bindings: display: Add BCM2712 PixelValve bindings
On Wed, 23 Oct 2024 17:50:03 +0100, Dave Stevenson wrote: > From: Maxime Ripard > > The BCM2712 has 3 different pixelvalves that are similar to the ones > found in the previous generations but with slightly different > capabilities. > > Express that using a new set of compatibles. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- > .../devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml | 3 > +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring (Arm)
Re: [PATCH v2 3/9] dt-bindings: display/msm: Add QCS615 MDSS & DPU
On Wed, 13 Nov 2024 19:51:45 +0800, Fange Zhang wrote: > From: Li Liu > > Document the MDSS and DPU hardware found on the Qualcomm QCS615 platform. > > Signed-off-by: Li Liu > Signed-off-by: Fange Zhang > --- > .../bindings/display/msm/qcom,qcs615-dpu.yaml | 118 ++ > .../bindings/display/msm/qcom,qcs615-mdss.yaml | 252 > + > 2 files changed, 370 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/msm/qcom,qcs615-mdss.example.dts:24:18: fatal error: dt-bindings/clock/qcom,qcs615-dispcc.h: No such file or directory 24 | #include | ^~~~ compilation terminated. make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/display/msm/qcom,qcs615-mdss.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241113-add-display-support-for-qcs615-platform-v2-3-2873eb6fb...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example
On Tue, 12 Nov 2024 05:21:24 +0200, Dmitry Baryshkov wrote:
> Add p1 region to the list of DP registers in the SA8775p example. This
> fixes the following warning:
>
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb:
> displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192],
> [183848960, 1904], [183853056, 156]] is too short
>
> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
> Reported-by: Rob Herring
> Closes:
> https://lore.kernel.org/dri-devel/cal_jsqj0zoyazagztyj8xmspy+yzrbf-yg1vpn6tfofxqaw...@mail.gmail.com/c
> Signed-off-by: Dmitry Baryshkov
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1:
> https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5...@linaro.org
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm)
Re: [PATCH v4 6/9] dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible
On Tue, 03 Sep 2024 11:22:36 -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova > Acked-by: Krzysztof Kozlowski > Acked-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks!
Re: [PATCH 2/3] dt-bindings: display/msm/gmu: Add Adreno 663 GMU
On Wed, 18 Sep 2024 02:08:42 +0530, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Document Adreno 663 GMU in the dt-binding specification. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oommen > --- > Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)
