Re: [alsa-devel] [PATCH 8/8] ASoC: AMD: Add machine driver for cz rt5650

2017-06-25 Thread Pierre-Louis Bossart



+static const struct acpi_device_id cz_audio_acpi_match[] = {
+   { "I2SC1002", 0 },
This one goes on my list of _HID that don't follow ACPI/PCI 
vendorID/PartID conventions.
AMD shoud use the "AMDI" ACPI ID or the 0x1002 PCI ID for the 4 first 
characters, if everyone does what they feel like one day we'll have a 
conflict between devices and probe the wrong driver...



+   {},
+};
+
+static struct platform_driver cz_pcm_driver = {
+   .driver = {
+   .name = "cz-rt5645",
+   .acpi_match_table = ACPI_PTR(cz_audio_acpi_match),
+   .pm = &snd_soc_pm_ops,
+   },
+   .probe = cz_probe,
+   .remove = cz_remove,
+};
+
+module_platform_driver(cz_pcm_driver);
+
+MODULE_AUTHOR("akshu.agra...@amd.com");
+MODULE_DESCRIPTION("cz-rt5645 audio support");
+MODULE_LICENSE("GPL v2");


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

2018-07-19 Thread Pierre-Louis Bossart



On 07/17/2018 04:26 AM, Takashi Iwai wrote:

Hi,

this is a preliminiary patch set to convert the existing i915 /
HD-audio component binding to be applicable to other drivers like
radeon / amdgpu.  This patchset itself doesn't change the
functionality but only renames and split to a new drm_audio_component
stuff from i915_audio_component.

The actual usage of the new API will follow once after this one gets
reviewed / accepted.  The whole patches (including this patchset) are
found in topic/hda-acomp branch of sound.git tree.

BTW, since the whole stuff is about the audio binding, I suppose these
will go through sound git tree.  Let me know if anyone has concerns.
No objections but a slight concern that this will conflict with the 
HDAudio+DSP patches that I was about to resubmit on top of your 
topic/hda-core-intel branch. the two series touch the same files so it'd 
be a miracle if there is no issue.

How do you want to deal with this?



Thanks!

Takashi

===

v1->v2:
* Change to SPDX for the new drm_audio_component.h
* Fix remaining i915 word in drm_audio_component.h comments
* Fix NULL dereference in master_bind / _unbind ops

===

Takashi Iwai (3):
   drm/i915: Split audio component to a generic type
   ALSA: hda/i915: Associate audio component with devres
   ALSA: hda: Make audio component support more generic

  drivers/gpu/drm/i915/Kconfig   |   1 +
  drivers/gpu/drm/i915/intel_audio.c |  22 +-
  include/drm/drm_audio_component.h  | 118 ++
  include/drm/i915_component.h   |  85 +---
  include/sound/hda_component.h  |  61 ++
  include/sound/hda_i915.h   |  37 +---
  include/sound/hdaudio.h|   6 +-
  sound/hda/Kconfig  |   7 +-
  sound/hda/Makefile |   1 +
  sound/hda/hdac_component.c | 335 +
  sound/hda/hdac_i915.c  | 335 ++---
  sound/pci/hda/patch_hdmi.c |  57 +++--
  sound/soc/codecs/hdac_hdmi.c   |  10 +-
  13 files changed, 607 insertions(+), 468 deletions(-)
  create mode 100644 include/drm/drm_audio_component.h
  create mode 100644 include/sound/hda_component.h
  create mode 100644 sound/hda/hdac_component.c



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

2018-07-20 Thread Pierre-Louis Bossart

On 7/19/18 12:50 AM, Takashi Iwai wrote:

On Wed, 18 Jul 2018 22:54:35 +0200,
Pierre-Louis Bossart wrote:




On 07/17/2018 04:26 AM, Takashi Iwai wrote:

Hi,

this is a preliminiary patch set to convert the existing i915 /
HD-audio component binding to be applicable to other drivers like
radeon / amdgpu.  This patchset itself doesn't change the
functionality but only renames and split to a new drm_audio_component
stuff from i915_audio_component.

The actual usage of the new API will follow once after this one gets
reviewed / accepted.  The whole patches (including this patchset) are
found in topic/hda-acomp branch of sound.git tree.

BTW, since the whole stuff is about the audio binding, I suppose these
will go through sound git tree.  Let me know if anyone has concerns.

No objections but a slight concern that this will conflict with the
HDAudio+DSP patches that I was about to resubmit on top of your
topic/hda-core-intel branch. the two series touch the same files so
it'd be a miracle if there is no issue.
How do you want to deal with this?


Does it conflict severely?  If it's trivial, it can be resolved at
merge time, too.  The changes in my patchset are fairly trivial, so it
shouldn't be too hard.


I was able to make things work by taking your topic/hda-core-intel, 
merge it on Mark's for-next, then add my additional changes and these 
DRM changes. The last two can be done in any order. But I am getting 
some conflicts if I try to apply these DRM changes first, not sure why 
git is complaining though, the changes look trivial enough.
So yes it looks possible to deal with the two series in parallel, will 
send my update later today.

Thanks
-Pierre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

2018-07-20 Thread Pierre-Louis Bossart

On 7/19/18 1:56 PM, Takashi Iwai wrote:

On Thu, 19 Jul 2018 15:05:45 +0200,
Pierre-Louis Bossart wrote:


On 7/19/18 12:50 AM, Takashi Iwai wrote:

On Wed, 18 Jul 2018 22:54:35 +0200,
Pierre-Louis Bossart wrote:




On 07/17/2018 04:26 AM, Takashi Iwai wrote:

Hi,

this is a preliminiary patch set to convert the existing i915 /
HD-audio component binding to be applicable to other drivers like
radeon / amdgpu.  This patchset itself doesn't change the
functionality but only renames and split to a new drm_audio_component
stuff from i915_audio_component.

The actual usage of the new API will follow once after this one gets
reviewed / accepted.  The whole patches (including this patchset) are
found in topic/hda-acomp branch of sound.git tree.

BTW, since the whole stuff is about the audio binding, I suppose these
will go through sound git tree.  Let me know if anyone has concerns.

No objections but a slight concern that this will conflict with the
HDAudio+DSP patches that I was about to resubmit on top of your
topic/hda-core-intel branch. the two series touch the same files so
it'd be a miracle if there is no issue.
How do you want to deal with this?


Does it conflict severely?  If it's trivial, it can be resolved at
merge time, too.  The changes in my patchset are fairly trivial, so it
shouldn't be too hard.


I was able to make things work by taking your topic/hda-core-intel,
merge it on Mark's for-next, then add my additional changes and these
DRM changes. The last two can be done in any order. But I am getting
some conflicts if I try to apply these DRM changes first, not sure why
git is complaining though, the changes look trivial enough.
So yes it looks possible to deal with the two series in parallel, will
send my update later today.


OK, since my changes are relatively trivial to deal with, I merge the
changes to for-next branch now.

If your patches can be respinned, maybe it's easier to be rebased on
top of these merges.


I was planning to resend them tomorrow after internal reviews (mostly 
changes in the detection/enablement of the HDaudio+DSP case). If you 
want to take a look in the mean time the patches are here: 
https://github.com/plbossart/sound/commits/upstream/hda2


I can rebase them as needed, no big deal.
Thanks
-Pierre



Mark, could you merge topic/drm_audio_component branch into yours, if
Pierre's patchset won't go in immediately?  It's an immutable branch,
including already topic/hda-core-intel in itself.


thanks,

Takashi



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel