Re: [PATCH] drm: Permit video-buffers writecombine mapping for MIPS
Hi Serge,
On Tue, Apr 23, 2019 at 03:31:22PM +0300, Serge Semin wrote:
> Since commit 4b050ba7a66c ("MIPS: pgtable.h: Implement the
> pgprot_writecombine function for MIPS") and commit c4687b15a848 ("MIPS: Fix
> definition of pgprot_writecombine()") write-combine vma mapping is
> available to be used by kernel subsystems for MIPS. In particular the
> uncached accelerated attribute is requested to be set by ioremap_wc()
> method and by generic PCI memory pages/ranges mapping methods. The same
> is done by the drm_io_prot()/ttm_io_prot() functions in case if
> write-combine flag is set for vma's passed for mapping. But for some
> reason the pgprot_writecombine() method calling is ifdefed to be a
> platform-specific with MIPS system being marked as lacking of one. At the
> very least it doesn't reflect the current MIPS platform implementation.
> So in order to improve the DRM subsystem performance on MIPS with UCA
> mapping enabled, we need to have pgprot_writecombine() called for buffers,
> which need store operations being combined. In case if particular MIPS
> chip doesn't support the UCA attribute, the mapping will fall back to
> noncached.
>
> Cc: Ralf Baechle
> Cc: Paul Burton
> Cc: James Hogan
> Signed-off-by: Vadim V. Vlasov
> Signed-off-by: Serge Semin
> ---
> drivers/gpu/drm/drm_vm.c | 5 +++--
> drivers/gpu/drm/ttm/ttm_bo_util.c | 4 ++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
Looks good to me:
Reviewed-by: Paul Burton
Thanks,
Paul
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree
Hi Paul,
On Thu, Jul 25, 2019 at 06:02:06PM -0400, Paul Cercueil wrote:
> Move all the platform data to devicetree.
Nice! :)
> The only bit dropped is the PWM beeper, which requires the PWM driver
> to be updated. I figured it's okay to remove it here since it's really
> a non-critical device, and it'll be re-introduced soon enough.
OK, I can see that being a price worth paying. Though it's possible to
include the binding at least for that in this series I'd be even
happier. Actually I see we already have
Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt
in mainline - what needs to change with it?
> + spi {
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&gpc 23 GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&gpc 22 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&gpc 21 GPIO_ACTIVE_LOW>;
> + num-chipselects = <1>;
> +
> + spi@0 {
> + compatible = "ili8960";
Should this be "ilitek,ili8960"?
Is there a binding & driver for this submitted somewhere? If not then do
we need this at all? It doesn't look like the existing platform data
would actually lead to a driver being loaded so I'm wondering if we can
just drop this until such a driver (or at least a documented DT binding)
exists.
Thanks,
Paul
Re: [PATCH 01/11] MIPS: DTS: jz4740: Add missing nodes
Hello, Paul Cercueil wrote: > Add nodes for the MMC, AIC, ADC, CODEC, MUSB, LCD, memory, > and BCH controllers. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 03/11] MIPS: configs: LB60: update defconfig
Hello, Paul Cercueil wrote: > Update the defconfig to select the new drivers instead of the old ones. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 05/11] video/fbdev: Drop JZ4740 driver
Hello, Paul Cercueil wrote: > The JZ4740 fbdev driver has been replaced with the ingenic-drm driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Sam Ravnborg Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 06/11] dma: Drop JZ4740 driver
Hello, Paul Cercueil wrote: > The newer and better JZ4780 driver is now used to provide DMA > functionality on the JZ4740. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Vinod Koul Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 07/11] mtd: rawnand: Drop obsolete JZ4740 NAND driver
Hello, Paul Cercueil wrote: > It has been replaced with the newer Ingenic NAND driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Miquel Raynal Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 09/11] hwmon: Drop obsolete JZ4740 driver
Hello, Paul Cercueil wrote: > The JZ4740 boards now use the iio-hwmon driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Guenter Roeck Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 11/11] MIPS: jz4740: Drop dead code
Hello, Paul Cercueil wrote: > Remove all the source files that are not used anywhere anymore. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree
Hello, Paul Cercueil wrote: > Move all the platform data to devicetree. > > The only bit dropped is the PWM beeper, which requires the PWM driver > to be updated. I figured it's okay to remove it here since it's really > a non-critical device, and it'll be re-introduced soon enough. > > The other change is the CS line of the SPI is now set as active low. The > SPI core would have forced "active low" anyway, unless the 'spi-cs-high' > property is set. > > In the process of moving to devicetree, we also switched to new drivers: > - We use the simple-audio-card and simple-amplifier drivers instead of > the custom ASoC code; > - We use the new Ingenic DRM driver coupled with the GiantPlus GPM940B0 > DRM panel driver instead of the old framebuffer driver; > - We use the new jz4780-dma driver instead of the old jz4740-dma one; > - We use the ingenic-nand and jz4740-ecc drivers instead of the old > jz4740-nand driver; > - We use ingenic-battery instead of jz4740-battery; > - We use iio-hwmon instead of jz4740-hwmon; > - We use ingenic-iio instead of the old jz4740-adc MFD driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 08/11] power/supply: Drop obsolete JZ4740 driver
Hello, Paul Cercueil wrote: > It has been replaced with the more mature ingenic-battery driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Sebastian Reichel Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH 04/11] ASoC: jz4740: Drop lb60 board code
Hello, Paul Cercueil wrote: > The board now uses the simple-audio-card driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > Acked-by: Mark Brown Applied to mips-next. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.bur...@mips.com to report it. ]
Re: [PATCH v2 0/3] Improve MIPS Magnum support
Hello,
Finn Thain wrote:
> A few minor patches are needed to more easily boot a MIPS Magnum build
> under QEMU. This series fixes a build failure in the g364fb driver and
> modifies jazz_defconfig for use with 'qemu-system-mips64el -M magnum'.
>
> Note that QEMU's dp8393x implementation has bugs, one of which prevents
> the Linux jazzsonic driver from probing the chip. I have fixed the bugs
> that I know of in a series of patches at,
> https://github.com/fthain/qemu/commits/sonic
>
> Changed since v1:
> - Added reviewed-by and tested-by tags from Philippe Mathieu-Daudé.
> - Rebased.
>
>
> Finn Thain (3):
> fbdev/g364fb: Fix build failure
> mips/jazz: Remove redundant settings and shrink jazz_defconfig
> mips/jazz: Update jazz_defconfig for MIPS Magnum
Series applied to mips-next.
> fbdev/g364fb: Fix build failure
> commit c584f9532115
> https://git.kernel.org/mips/c/c584f9532115
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Finn Thain
> Acked-by: Bartlomiej Zolnierkiewicz
> Tested-by: Philippe Mathieu-Daudé
> Signed-off-by: Paul Burton
>
> mips/jazz: Remove redundant settings and shrink jazz_defconfig
> commit a7047b8dd098
> https://git.kernel.org/mips/c/a7047b8dd098
>
> Tested-by: Philippe Mathieu-Daudé
> Signed-off-by: Finn Thain
> Signed-off-by: Paul Burton
>
> mips/jazz: Update jazz_defconfig for MIPS Magnum
> commit 91f40e896444
> https://git.kernel.org/mips/c/91f40e896444
>
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu-Daudé
> Signed-off-by: Finn Thain
> Signed-off-by: Paul Burton
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paulbur...@kernel.org to report it. ]
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
