Re: [PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3
On 11:06-20201108, Sam Ravnborg wrote:
> Hi Nishanth
>
> On Mon, Oct 26, 2020 at 11:54:41AM -0500, Nishanth Menon wrote:
> > With the integration of chip-id detection scheme in kernel[1], there
> > is no specific need to maintain multitudes of SoC specific config
> > options, discussed as per [2], we have deprecated the usage in other
> > places for v5.10-rc1. Fix the missing user so that we can clean up the
> > configs in v5.11.
> >
> > [1] drivers/soc/ti/k3-socinfo.c commit 907a2b7e2fc7 ("soc: ti: add k3
> > platforms chipid module driver")
> > [2]
> > https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/
> >
> > Fixes: afba7e6c5fc1 ("rm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
> > Cc: Swapnil Jakhade
> > Cc: Tomi Valkeinen
> > Cc: Laurent Pinchart
> > Cc: Yuti Amonkar
> > Cc: Jyri Sarha
> > Signed-off-by: Nishanth Menon
>
> Applied to drm-misc-fixes with Tomi's r-b
> Fixed the "Fixes" line while applying - someone ate a 'd'
Ooops.. Sorry about that. Thanks for fixing and picking it up.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/bridge: cdns-dsi: Make sure to to create proper aliases for dt
Add MODULE_DEVICE_TABLE to the device tree table to create required
aliases needed for module to be loaded with device tree based platform.
Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver")
Signed-off-by: Nishanth Menon
---
drivers/gpu/drm/bridge/cdns-dsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c
b/drivers/gpu/drm/bridge/cdns-dsi.c
index d8a15c459b42..829e1a144656 100644
--- a/drivers/gpu/drm/bridge/cdns-dsi.c
+++ b/drivers/gpu/drm/bridge/cdns-dsi.c
@@ -1284,6 +1284,7 @@ static const struct of_device_id cdns_dsi_of_match[] = {
{ .compatible = "cdns,dsi" },
{ },
};
+MODULE_DEVICE_TABLE(of, cdns_dsi_of_match);
static struct platform_driver cdns_dsi_platform_driver = {
.probe = cdns_dsi_drm_probe,
--
2.32.0
Re: [3/3] drm: bridge: it66121: Add audio support
On 14:57-20220316, Nicolas Belin wrote: > Adding the audio support on the HDMI bridge for I2S only. > > Signed-off-by: Nicolas Belin > Signed-off-by: Andy.Hsieh > Reviewed-by: Neil Armstrong > --- > drivers/gpu/drm/bridge/ite-it66121.c | 627 +++ > 1 file changed, 627 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c > b/drivers/gpu/drm/bridge/ite-it66121.c > index 64912b770086..514989676d07 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c Not sure how, but I see this when HDMI is not connected on BeaglePlay https://gist.github.com/nmenon/f3d4a34ec9b9d188fbefb65f94090bcb Cc Jai Luthra -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
[PATCH 1/3] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node
On 09/16/2016 06:50 AM, Jyri Sarha wrote: [..] > + blue-and-red-wiring = "crossed"; Dumb question: Why is this a Linux generic property - does it make sense to have "blue-and-red-wiring" as a Linux generic property? I mean, it reminds me little of those movies "cut the blue or red wire to diffuse the bomb" ;) "The am335x-evm has blue and red wires crossed to get 24-bit RGB (and 16-bit BGR". I mean, there has to be some sort of better description specific to lcdc if some product used yellow and green wires for the same signals crossed? -- Regards, Nishanth Menon
[PATCH 1/3] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node
On 09/19/2016 02:55 AM, Jyri Sarha wrote: [...] > The functional patches, with the binding document can be found here: > http://www.spinics.net/lists/devicetree/msg141246.html > > [1] For more details see section 3.1.1 in AM335x Silicon Errata: > http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360 > Thanks for the detailed explanation. http://www.spinics.net/lists/devicetree/msg141248.html helped explain the same. -- Regards, Nishanth Menon
[PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3
With the integration of chip-id detection scheme in kernel[1], there
is no specific need to maintain multitudes of SoC specific config
options, discussed as per [2], we have deprecated the usage in other
places for v5.10-rc1. Fix the missing user so that we can clean up the
configs in v5.11.
[1] drivers/soc/ti/k3-socinfo.c commit 907a2b7e2fc7 ("soc: ti: add k3 platforms
chipid module driver")
[2]
https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/
Fixes: afba7e6c5fc1 ("rm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
Cc: Swapnil Jakhade
Cc: Tomi Valkeinen
Cc: Laurent Pinchart
Cc: Yuti Amonkar
Cc: Jyri Sarha
Signed-off-by: Nishanth Menon
---
drivers/gpu/drm/bridge/cadence/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cadence/Kconfig
b/drivers/gpu/drm/bridge/cadence/Kconfig
index 511d67b16d14..ef8c230e0f62 100644
--- a/drivers/gpu/drm/bridge/cadence/Kconfig
+++ b/drivers/gpu/drm/bridge/cadence/Kconfig
@@ -13,7 +13,7 @@ config DRM_CDNS_MHDP8546
if DRM_CDNS_MHDP8546
config DRM_CDNS_MHDP8546_J721E
- depends on ARCH_K3_J721E_SOC || COMPILE_TEST
+ depends on ARCH_K3 || COMPILE_TEST
bool "J721E Cadence DPI/DP wrapper support"
default y
help
--
2.28.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v3 1/5] clk: ti: add "ti, gpio-gate-clock" controlled clock
On 09/19/2014 08:07 AM, Tomi Valkeinen wrote: > On 16/09/14 23:40, Jyri Sarha wrote: >> The added ti,gpio-gate-clock is a basic clock that can be enabled and >> disabled trough a gpio output. The DT binding document for the clock >> is also added. For EPROBE_DEFER handling the registering of the clock >> has to be delayed until of_clk_get() call time. >> >> Signed-off-by: Jyri Sarha >> --- >> .../bindings/clock/ti/gpio-gate-clock.txt | 21 ++ >> drivers/clk/ti/Makefile|2 +- >> drivers/clk/ti/gpio.c | 202 >> >> 3 files changed, 224 insertions(+), 1 deletion(-) >> create mode 100644 >> Documentation/devicetree/bindings/clock/ti/gpio-gate-clock.txt >> create mode 100644 drivers/clk/ti/gpio.c > > Why is this a TI clock? Sounds like a generic one to me. Like thread: https://lkml.org/lkml/2014/9/5/284 ? > > In any case, this should go through Mike. > yep - should have been posted independent of this series :). -- Regards, Nishanth Menon
Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference
On 16:35-20230828, Helen Mae Koike Fornazier wrote:
> On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote:
>
> > Fix the NULL pointer dereference when no monitor is connected, and the
> > sound card is opened from userspace.
> >
> > Instead return an error as EDID information cannot be provided to
> > the sound framework if there is no connector attached.
> >
> > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support")
> > Reported-by: Nishanth Menon
> > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/
> > Signed-off-by: Jai Luthra
>
> Reviewed-by: Helen Koike
Occurs on today's master: v6.5-8894-gb97d64c72259
https://gist.github.com/nmenon/6c7166171729342ee0be7de90b65c5c6#file-v6-5-8894-gb97d64c72259-L821
My only complaint with the patch is - yes, it does'nt crash, but I see
this spam on my console:
https://gist.github.com/nmenon/6c7166171729342ee0be7de90b65c5c6#file-with-patch-on-top-L236
>
> > ---
> > drivers/gpu/drm/bridge/ite-it66121.c | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c
> > b/drivers/gpu/drm/bridge/ite-it66121.c
> > index 466641c77fe9..d6fa00dea464 100644
> > --- a/drivers/gpu/drm/bridge/ite-it66121.c
> > +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> > @@ -1446,6 +1446,11 @@ static int it66121_audio_get_eld(struct device *dev,
> > void *data,
> > {
> > struct it66121_ctx *ctx = dev_get_drvdata(dev);
> >
> > + if (!ctx->connector) {
> > + dev_dbg(dev, "No connector present, cannot provide EDID data");
> > + return -EINVAL;
> > + }
> > +
> > mutex_lock(&ctx->lock);
> >
> > memcpy(buf, ctx->connector->eld,
> >
> > ---
> > base-commit: 6269320850097903b30be8f07a5c61d9f7592393
> > change-id: 20230825-it66121_edid-6ee98517808b
> >
> > Best regards,
> > --
> > Jai Luthra
> >
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference
On 17:01-20230901, Aradhya Bhatia wrote:
> On 01-Sep-23 15:01, Jai Luthra wrote:
> > Fix the NULL pointer dereference when no monitor is connected, and the
> > sound card is opened from userspace.
> >
> > Instead return an empty buffer (of zeroes) as the EDID information to
> > the sound framework if there is no connector attached.
> >
> > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support")
> > Reported-by: Nishanth Menon
> > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/
> > Reviewed-by: Helen Koike
> > Signed-off-by: Jai Luthra
>
> Reviewed-by: Aradhya Bhatia
>
Tested-by: Nishanth Menon
Log (beagleplay):
https://gist.github.com/nmenon/17fea9316cbcc5ee47597a39fa5e2d6f
Tested on 99d99825fc07 (origin/master, origin/HEAD) Merge tag 'nfs-for-6.6-1'
of git://git.linux-nfs.org/projects/anna/linux-nfs
Could we get this merged for rc1 cycle?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3
On 19:29-20231128, Geert Uytterhoeven wrote:
> The Imagination Technologies PowerVR Series 6 GPU is currently only
> supported on Texas Instruments K3 AM62x SoCs. Hence add a dependency on
> ARCH_K3, to prevent asking the user about this driver when configuring a
> kernel without Texas Instruments K3 Multicore SoC support.
>
> Fixes: 4babef0708656c54 ("drm/imagination: Add skeleton PowerVR driver")
Minor nitpick here - 12 char sha.. otherwise:
Reviewed-by: Nishanth Menon
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/gpu/drm/imagination/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/imagination/Kconfig
> b/drivers/gpu/drm/imagination/Kconfig
> index 3bfa2ac212dccb73..af492dbd9afd4ed9 100644
> --- a/drivers/gpu/drm/imagination/Kconfig
> +++ b/drivers/gpu/drm/imagination/Kconfig
> @@ -6,6 +6,7 @@ config DRM_POWERVR
> depends on ARM64
> depends on DRM
> depends on PM
> + depends on ARCH_K3 || COMPILE_TEST
> select DRM_EXEC
> select DRM_GEM_SHMEM_HELPER
> select DRM_SCHED
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
Re: [PATCH] drm/debugfs: fix potential NULL pointer dereference
On 15:19-20231205, Dmitry Baryshkov wrote:
> On Tue, 5 Dec 2023 at 15:06, Marek Szyprowski
> wrote:
> >
> > encoder->funcs entry might be NULL, so check it first before calling its
> > methods. This fixes NULL pointer dereference observed on Rasberry Pi
> > 3b/4b boards.
> >
> > Fixes: caf525ed45b4 ("drm/encoder: register per-encoder debugfs dir")
> > Signed-off-by: Marek Szyprowski
>
> Reviewed-by: Dmitry Baryshkov
Tested-by: Nishanth Menon
Fixed multiple platform boot fails on TI K3 SoC family including
BeaglePlay, BeagleBone-AI64.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
[PATCH] drm/edid: kernel-doc minimal cleanup
Some basic cleanups for kernel-doc errors or missing documentation parameters. Warnings generated by ./scripts/kernel-doc drivers/gpu/drm/drm_edid.c >Kerr Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: dri-devel@lists.freedesktop.org Signed-off-by: Nishanth Menon --- It does seem the drm_edid.c could do with some amount of documentation cleanup, but I have stayed with the bare minimum. the above error is based off: master de1a226 Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git defconfig used: omap2plus_defconfig Disclaimer: I am no drm expert, and I tried to use my best judgement about what the meaning of the parameters might be, hope it helps. drivers/gpu/drm/drm_edid.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c194f4e..f604c5f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. - * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * drm_do_probe_ddc_edid() - Get EDID information via I2C. + * @adapter: i2c device adaptor + * @buf: EDID data buffer to be filled + * @block: EDID block to get + * @len: EDID data buffer length * * Try to fetch EDID information by calling i2c driver function. + * Return 0 on success or -1 on failure. */ static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc() - Probe DDC presence + * @adapter: i2c device adaptor * - * \param adapter : i2c device adaptor - * \return 1 on success + * returns 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: connector corresponding to the HDMI/DP sink + * @edid: EDID data * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -2000,6 +2002,7 @@ do_established_modes(struct detailed_timing *timing, void *c) /** * add_established_modes - get est. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2065,7 @@ do_standard_modes(struct detailed_timing *timing, void *c) /** * add_standard_modes - get std. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2192,7 +2196,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) } } -/* +/** * add_detailed_modes - Add modes from detailed timings * @connector: attached connector * @edid: EDID block to scan @@ -2231,7 +2235,8 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #define EDID_CEA_VCDB_QS (1 << 6) /
Re: [PATCH] drm/edid: kernel-doc minimal cleanup
On 14:43-20130301, Ville Syrjälä wrote: > On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote: [..] > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. > > - * > > - * \param adapter : i2c device adaptor > > - * \param buf : EDID data buffer to be filled > > - * \param len : EDID data buffer length > > - * \return 0 on success or -1 on failure. > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > + * @adapter: i2c device adaptor > > nit: adapter vs. adaptor Thanks for catching it. > > > + * @buf: EDID data buffer to be filled > > + * @block: EDID block to get > > + * @len: EDID data buffer length > > * > > * Try to fetch EDID information by calling i2c driver function. > > + * Return 0 on success or -1 on failure. > > */ > > static int > > drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, > > @@ -1128,10 +1128,10 @@ out: > > } > > > > /** > > - * Probe DDC presence. > > + * drm_probe_ddc() - Probe DDC presence > > + * @adapter: i2c device adaptor > > * > > - * \param adapter : i2c device adaptor > > - * \return 1 on success > > + * returns 1 on success > > */ > > bool > > drm_probe_ddc(struct i2c_adapter *adapter) > > @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) > > > > /** > > * drm_mode_std - convert standard mode info (width, height, refresh) into > > mode > > + * @connector: connector corresponding to the HDMI/DP sink > > EDID isn't limited to HDMI/DP. > [..] > > > > /** > > * drm_rgb_quant_range_selectable - is RGB quantization range selectable? > > + * @edid: EDID data > > nit: Different description for the same thing between this and the previous > hunk. agreed. How about just EDID data? -- Regards, Nishanth Menon ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH V2] drm/edid: kernel-doc minimal cleanup
Some basic cleanups for kernel-doc errors or missing documentation parameters. Warnings generated by ./scripts/kernel-doc drivers/gpu/drm/drm_edid.c >Kerr Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: dri-devel@lists.freedesktop.org Signed-off-by: Nishanth Menon --- V2: review comments incorporated V1: http://marc.info/?t=13621411595&r=1&w=2 It does seem the drm_edid.c could do with more documentation cleanup, but I have stayed with the bare minimum. the above error is based off: master de1a226 Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git defconfig used: omap2plus_defconfig Disclaimer: I am no drm expert, and I tried to use my best judgement about what the meaning of the parameters might be, hope it helps. drivers/gpu/drm/drm_edid.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c194f4e..bd864b5 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. - * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * drm_do_probe_ddc_edid() - Get EDID information via I2C. + * @adapter: i2c device adapter + * @buf: EDID data buffer to be filled + * @block: EDID block to get + * @len: EDID data buffer length * * Try to fetch EDID information by calling i2c driver function. + * Return 0 on success or -1 on failure. */ static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc() - Probe DDC presence + * @adapter: i2c device adapter * - * \param adapter : i2c device adaptor - * \return 1 on success + * returns 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: attached connector + * @edid: EDID data * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -2000,6 +2002,7 @@ do_established_modes(struct detailed_timing *timing, void *c) /** * add_established_modes - get est. modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2065,7 @@ do_standard_modes(struct detailed_timing *timing, void *c) /** * add_standard_modes - get std. modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2192,7 +2196,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) } } -/* +/** * add_detailed_modes - Add modes from detailed timings * @connector: attached connector * @edid: EDID block to scan @@ -2231,7 +2235,8 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #def
Re: [PATCH V2] drm/edid: kernel-doc minimal cleanup
On 18:09-20130302, Paul Menzel wrote: > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > Some basic cleanups for kernel-doc errors or missing documentation > > parameters. > > Nishanth, thanks for doing that! glad to be of help. > > > index c194f4e..bd864b5 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. > > - * > > - * \param adapter : i2c device adaptor > > - * \param buf : EDID data buffer to be filled > > - * \param len : EDID data buffer length > > - * \return 0 on success or -1 on failure. > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > Some already existing entries do not use »()« behind the function name > in the comment. Not sure what the correct way is though. I followed the format as in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kernel-doc-nano-HOWTO.txt#n55 That said, I might suggest someone more knowledgable than I look through the drm_edid.c - there seems to be code alignment issues etc which I did not fix up. running Lindent quickly shows: http://pastebin.com/vaYFQDHv -- Regards, Nishanth Menon ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH V2] drm/edid: kernel-doc minimal cleanup
On 10:27-20130304, Nishanth Menon wrote: > On 18:09-20130302, Paul Menzel wrote: > > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > > Some basic cleanups for kernel-doc errors or missing documentation > > > parameters. [..] > > > index c194f4e..bd864b5 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > > > #define DDC_SEGMENT_ADDR 0x30 > > > /** > > > - * Get EDID information via I2C. > > > - * > > > - * \param adapter : i2c device adaptor > > > - * \param buf : EDID data buffer to be filled > > > - * \param len : EDID data buffer length > > > - * \return 0 on success or -1 on failure. > > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > > > Some already existing entries do not use »()« behind the function name > > in the comment. Not sure what the correct way is though. > I followed the format as in: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kernel-doc-nano-HOWTO.txt#n55 just a ping to confirm if there are any further changes required? -- Regards, Nishanth Menon ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
From: Paul Sokolovsky An ifdef in drm.h expects to be compiled with full-fledged Linux toolchain, but it's common to compile kernel with just bare-metal toolchain which doesn't define __linux__. So, also add __KERNEL__ check. [n...@ti.com: port forward to 3.9-rc6 and post to dri devel for feedback as RFC] Signed-off-by: Paul Sokolovsky --- Paul, Dri devel list, I picked up this patch from linaro tree: https://git.linaro.org/gitweb?p=people/asac/android/kernel/lt-ti.git;a=patch;h=719fbc876740cf75e82dd082ae5a00dfcf6fff7a Discussion thread: http://lists.linaro.org/pipermail/linaro-dev/2011-June/thread.html#4874 Seems to me as a valid fix even for upstream perhaps? Regards, Nishanth Menon include/uapi/drm/drm.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -36,7 +36,7 @@ #ifndef _DRM_H_ #define _DRM_H_ -#if defined(__linux__) +#if defined(__KERNEL__) || defined(__linux__) #include #include -- 1.7.9.5 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
On 12:50-20130416, Arnd Bergmann wrote:
> On Tuesday 16 April 2013 12:48:28 Paul Sokolovsky wrote:
> > > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> > > index 8d1e2bb..73a99e4 100644
> > > --- a/include/uapi/drm/drm.h
> > > +++ b/include/uapi/drm/drm.h
> > > @@ -36,7 +36,7 @@
> > > #ifndef _DRM_H_
> > > #define _DRM_H_
> > >
> > > -#if defined(__linux__)
> > > +#if defined(__KERNEL__) || defined(__linux__)
> > >
> > > #include
> > > #include
>
> This is still completely bogus, the __KERNEL__ symbol has no significance
> here.
> Either make the compiler define __linux__, or remove this #ifdef completely.
>
Searching the v.39-rc7 tag, and greping for _linux_ a few interesting
list pops up. (pruned):
arch/arc/Makefile:cflags-y += -mA7 -fno-common -pipe -fno-builtin
-D__linux__
arch/h8300/Makefile:KBUILD_CFLAGS += -D__linux__
arch/hexagon/Makefile:KBUILD_CFLAGS += -ffixed-$(TIR_NAME)
-DTHREADINFO_REG=$(TIR_NAME) -D__linux__
arch/score/Makefile:-D__linux__ -ffunction-sections -ffreestanding
arch/xtensa/Makefile:KBUILD_CFLAGS += -ffreestanding -D__linux__
^^ these architectures seem to bypass the pain entirely by defining
__linux__
arch/mips/include/uapi/asm/sgidefs.h:#ifndef __linux__
drivers/gpu/drm/radeon/radeon_cp.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic7770.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic79xx.h:#ifndef __linux__
{snip}
drivers/scsi/aic7xxx/aic79xx_core.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic79xx_pci.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic7xxx.h:#ifndef __linux__
drivers/scsi/aic7xxx/aic7xxx.h:#ifndef __linux__
drivers/scsi/aic7xxx/aic7xxx_93cx6.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic7xxx_core.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic7xxx_pci.c:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm.h:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_gram.y:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_macro_scan.l:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_scan.l:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h:#ifdef __linux__
drivers/scsi/dpt/osd_defs.h:#if (defined(__linux__))
drivers/staging/ced1401/machine.h:#if (defined(__linux__) || defined(_linux) ||
defined(__linux)) && !defined(LINUX)
include/acpi/platform/acenv.h:#if defined(_LINUX) || defined(__linux__)
include/linux/coda.h:#if defined(__linux__)
include/uapi/drm/drm.h:#if defined(__linux__)
include/uapi/linux/coda.h:#if defined(__linux__)
include/uapi/linux/fuse.h:#ifdef __linux__
And then we have the following as well..
fs/ext4/ext4.h:#if defined(__KERNEL__) || defined(__linux__)
Trying out a few different prebuilt compilers I had around, I see:
http://pastebin.com/bTVDLTb1
So, is our approach just to use __linux__ for builds? I am trying to
understand rationale behind why #include #include
would want __linux__ and why __KERNEL__ check is un-wanted.
Ofcourse, I cant comment about the "One of the BSDs" in else options..
and why we'd like to keep it around in kernel :)
--
Regards,
Nishanth Menon
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
From: Paul Sokolovsky An ifdef in drm.h expects to be compiled with full-fledged Linux toolchain, but it's common to compile kernel with just bare-metal toolchain which doesn't define __linux__. So, also add __KERNEL__ check. [nm at ti.com: port forward to 3.9-rc6 and post to dri devel for feedback as RFC] Signed-off-by: Paul Sokolovsky --- Paul, Dri devel list, I picked up this patch from linaro tree: https://git.linaro.org/gitweb?p=people/asac/android/kernel/lt-ti.git;a=patch;h=719fbc876740cf75e82dd082ae5a00dfcf6fff7a Discussion thread: http://lists.linaro.org/pipermail/linaro-dev/2011-June/thread.html#4874 Seems to me as a valid fix even for upstream perhaps? Regards, Nishanth Menon include/uapi/drm/drm.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -36,7 +36,7 @@ #ifndef _DRM_H_ #define _DRM_H_ -#if defined(__linux__) +#if defined(__KERNEL__) || defined(__linux__) #include #include -- 1.7.9.5
[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
On 12:50-20130416, Arnd Bergmann wrote:
> On Tuesday 16 April 2013 12:48:28 Paul Sokolovsky wrote:
> > > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> > > index 8d1e2bb..73a99e4 100644
> > > --- a/include/uapi/drm/drm.h
> > > +++ b/include/uapi/drm/drm.h
> > > @@ -36,7 +36,7 @@
> > > #ifndef _DRM_H_
> > > #define _DRM_H_
> > >
> > > -#if defined(__linux__)
> > > +#if defined(__KERNEL__) || defined(__linux__)
> > >
> > > #include
> > > #include
>
> This is still completely bogus, the __KERNEL__ symbol has no significance
> here.
> Either make the compiler define __linux__, or remove this #ifdef completely.
>
Searching the v.39-rc7 tag, and greping for _linux_ a few interesting
list pops up. (pruned):
arch/arc/Makefile:cflags-y += -mA7 -fno-common -pipe -fno-builtin
-D__linux__
arch/h8300/Makefile:KBUILD_CFLAGS += -D__linux__
arch/hexagon/Makefile:KBUILD_CFLAGS += -ffixed-$(TIR_NAME)
-DTHREADINFO_REG=$(TIR_NAME) -D__linux__
arch/score/Makefile:-D__linux__ -ffunction-sections -ffreestanding
arch/xtensa/Makefile:KBUILD_CFLAGS += -ffreestanding -D__linux__
^^ these architectures seem to bypass the pain entirely by defining
__linux__
arch/mips/include/uapi/asm/sgidefs.h:#ifndef __linux__
drivers/gpu/drm/radeon/radeon_cp.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic7770.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic79xx.h:#ifndef __linux__
{snip}
drivers/scsi/aic7xxx/aic79xx_core.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic79xx_pci.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic7xxx.h:#ifndef __linux__
drivers/scsi/aic7xxx/aic7xxx.h:#ifndef __linux__
drivers/scsi/aic7xxx/aic7xxx_93cx6.c:#ifdef __linux__
drivers/scsi/aic7xxx/aic7xxx_core.c:#ifdef __linux__
{snip}
drivers/scsi/aic7xxx/aic7xxx_pci.c:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm.h:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_gram.y:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_macro_scan.l:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_scan.l:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c:#ifdef __linux__
drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h:#ifdef __linux__
drivers/scsi/dpt/osd_defs.h:#if (defined(__linux__))
drivers/staging/ced1401/machine.h:#if (defined(__linux__) || defined(_linux) ||
defined(__linux)) && !defined(LINUX)
include/acpi/platform/acenv.h:#if defined(_LINUX) || defined(__linux__)
include/linux/coda.h:#if defined(__linux__)
include/uapi/drm/drm.h:#if defined(__linux__)
include/uapi/linux/coda.h:#if defined(__linux__)
include/uapi/linux/fuse.h:#ifdef __linux__
And then we have the following as well..
fs/ext4/ext4.h:#if defined(__KERNEL__) || defined(__linux__)
Trying out a few different prebuilt compilers I had around, I see:
http://pastebin.com/bTVDLTb1
So, is our approach just to use __linux__ for builds? I am trying to
understand rationale behind why #include #include
would want __linux__ and why __KERNEL__ check is un-wanted.
Ofcourse, I cant comment about the "One of the BSDs" in else options..
and why we'd like to keep it around in kernel :)
--
Regards,
Nishanth Menon
[PATCH] drm/edid: kernel-doc minimal cleanup
Some basic cleanups for kernel-doc errors or missing documentation parameters. Warnings generated by ./scripts/kernel-doc drivers/gpu/drm/drm_edid.c >Kerr Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: dri-devel at lists.freedesktop.org Signed-off-by: Nishanth Menon --- It does seem the drm_edid.c could do with some amount of documentation cleanup, but I have stayed with the bare minimum. the above error is based off: master de1a226 Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git defconfig used: omap2plus_defconfig Disclaimer: I am no drm expert, and I tried to use my best judgement about what the meaning of the parameters might be, hope it helps. drivers/gpu/drm/drm_edid.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c194f4e..f604c5f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. - * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * drm_do_probe_ddc_edid() - Get EDID information via I2C. + * @adapter: i2c device adaptor + * @buf: EDID data buffer to be filled + * @block: EDID block to get + * @len: EDID data buffer length * * Try to fetch EDID information by calling i2c driver function. + * Return 0 on success or -1 on failure. */ static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc() - Probe DDC presence + * @adapter: i2c device adaptor * - * \param adapter : i2c device adaptor - * \return 1 on success + * returns 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: connector corresponding to the HDMI/DP sink + * @edid: EDID data * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -2000,6 +2002,7 @@ do_established_modes(struct detailed_timing *timing, void *c) /** * add_established_modes - get est. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2065,7 @@ do_standard_modes(struct detailed_timing *timing, void *c) /** * add_standard_modes - get std. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2192,7 +2196,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) } } -/* +/** * add_detailed_modes - Add modes from detailed timings * @connector: attached connector * @edid: EDID block to scan @@ -2231,7 +2235,8 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #define EDID_CEA_VCDB_QS (1 << 6) /
[PATCH] drm/edid: kernel-doc minimal cleanup
On 14:43-20130301, Ville Syrj?l? wrote: > On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote: [..] > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. > > - * > > - * \param adapter : i2c device adaptor > > - * \param buf : EDID data buffer to be filled > > - * \param len : EDID data buffer length > > - * \return 0 on success or -1 on failure. > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > + * @adapter: i2c device adaptor > > nit: adapter vs. adaptor Thanks for catching it. > > > + * @buf: EDID data buffer to be filled > > + * @block: EDID block to get > > + * @len: EDID data buffer length > > * > > * Try to fetch EDID information by calling i2c driver function. > > + * Return 0 on success or -1 on failure. > > */ > > static int > > drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, > > @@ -1128,10 +1128,10 @@ out: > > } > > > > /** > > - * Probe DDC presence. > > + * drm_probe_ddc() - Probe DDC presence > > + * @adapter: i2c device adaptor > > * > > - * \param adapter : i2c device adaptor > > - * \return 1 on success > > + * returns 1 on success > > */ > > bool > > drm_probe_ddc(struct i2c_adapter *adapter) > > @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) > > > > /** > > * drm_mode_std - convert standard mode info (width, height, refresh) into > > mode > > + * @connector: connector corresponding to the HDMI/DP sink > > EDID isn't limited to HDMI/DP. > [..] > > > > /** > > * drm_rgb_quant_range_selectable - is RGB quantization range selectable? > > + * @edid: EDID data > > nit: Different description for the same thing between this and the previous > hunk. agreed. How about just EDID data? -- Regards, Nishanth Menon
[PATCH V2] drm/edid: kernel-doc minimal cleanup
Some basic cleanups for kernel-doc errors or missing documentation parameters. Warnings generated by ./scripts/kernel-doc drivers/gpu/drm/drm_edid.c >Kerr Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: Ville Syrj?l? Cc: dri-devel at lists.freedesktop.org Signed-off-by: Nishanth Menon --- V2: review comments incorporated V1: http://marc.info/?t=13621411595&r=1&w=2 It does seem the drm_edid.c could do with more documentation cleanup, but I have stayed with the bare minimum. the above error is based off: master de1a226 Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git defconfig used: omap2plus_defconfig Disclaimer: I am no drm expert, and I tried to use my best judgement about what the meaning of the parameters might be, hope it helps. drivers/gpu/drm/drm_edid.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c194f4e..bd864b5 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. - * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * drm_do_probe_ddc_edid() - Get EDID information via I2C. + * @adapter: i2c device adapter + * @buf: EDID data buffer to be filled + * @block: EDID block to get + * @len: EDID data buffer length * * Try to fetch EDID information by calling i2c driver function. + * Return 0 on success or -1 on failure. */ static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc() - Probe DDC presence + * @adapter: i2c device adapter * - * \param adapter : i2c device adaptor - * \return 1 on success + * returns 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: attached connector + * @edid: EDID data * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -2000,6 +2002,7 @@ do_established_modes(struct detailed_timing *timing, void *c) /** * add_established_modes - get est. modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2065,7 @@ do_standard_modes(struct detailed_timing *timing, void *c) /** * add_standard_modes - get std. modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2192,7 +2196,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) } } -/* +/** * add_detailed_modes - Add modes from detailed timings * @connector: attached connector * @edid: EDID block to scan @@ -2231,7 +2235,8 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #define EDID_CEA_VCDB_QS
[PATCH V2] drm/edid: kernel-doc minimal cleanup
On 18:09-20130302, Paul Menzel wrote: > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > Some basic cleanups for kernel-doc errors or missing documentation > > parameters. > > Nishanth, thanks for doing that! glad to be of help. > > > index c194f4e..bd864b5 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. > > - * > > - * \param adapter : i2c device adaptor > > - * \param buf : EDID data buffer to be filled > > - * \param len : EDID data buffer length > > - * \return 0 on success or -1 on failure. > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > Some already existing entries do not use ?()? behind the function name > in the comment. Not sure what the correct way is though. I followed the format as in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kernel-doc-nano-HOWTO.txt#n55 That said, I might suggest someone more knowledgable than I look through the drm_edid.c - there seems to be code alignment issues etc which I did not fix up. running Lindent quickly shows: http://pastebin.com/vaYFQDHv -- Regards, Nishanth Menon
[PATCH V2] drm/edid: kernel-doc minimal cleanup
On 10:27-20130304, Nishanth Menon wrote: > On 18:09-20130302, Paul Menzel wrote: > > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > > Some basic cleanups for kernel-doc errors or missing documentation > > > parameters. [..] > > > index c194f4e..bd864b5 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > > > #define DDC_SEGMENT_ADDR 0x30 > > > /** > > > - * Get EDID information via I2C. > > > - * > > > - * \param adapter : i2c device adaptor > > > - * \param buf : EDID data buffer to be filled > > > - * \param len : EDID data buffer length > > > - * \return 0 on success or -1 on failure. > > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > > > > Some already existing entries do not use ?()? behind the function name > > in the comment. Not sure what the correct way is though. > I followed the format as in: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kernel-doc-nano-HOWTO.txt#n55 just a ping to confirm if there are any further changes required? -- Regards, Nishanth Menon
Re: [PATCH DO NOT MERGE v6 17/18] arm64: dts: ti: k3-am62: New GPU binding details
On 12:41-20250415, Matt Coster wrote: > On 10/04/2025 10:55, Matt Coster wrote: > > Use the new compatible string introduced earlier (in "dt-bindings: gpu: > > img: More explicit compatible strings") and add a name to the single power > > domain for this GPU (introduced in "dt-bindings: gpu: img: Power domain > > details"). > > Hi Nishanth, Vignesh & Tero, > > Now that P1-16 have landed in a DRM tree, what would be required to get > this and the subsequent patch landed? Can they be reviewed and applied > as-is, or would you like me to send them as a separate series? Matt, Please post the patches in a separate series along with any defconfig changes required for the platforms. Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
