Re: [PATCH 0/9] Typo fixes of faild to failed
On Fri, Oct 22, 2010 at 01:17, Joe Perches wrote: > drivers/ata/pata_bf54x.c | 2 +- > drivers/video/bf54x-lq043fb.c | 6 +++--- > drivers/video/bfin-t350mcqb-fb.c | 2 +- Acked-by: Mike Frysinger -mike ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Intel-gfx] [PATCH] Backlight: Add backlight type
On Mon, Nov 15, 2010 at 11:44, Jesse Barnes wrote: > On Mon, 15 Nov 2010 15:48:20 + Matthew Garrett wrote: >> Richard, any feedback on this? >> > > At KS akpm said he'd likely be taking over backlight from Richard, > since Richard is very distracted with other things atm (please correct > me if I'm wrong). > > So either someone needs to volunteer to maintain this subsystem (I know > how much you love backlights, maybe you'd like to do it?) or you need to > get this patch over to akpm. this go anywhere ? -mike ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Intel-gfx] [PATCH] Backlight: Add backlight type
On Thu, Mar 24, 2011 at 02:53, Mike Frysinger wrote:
> On Mon, Nov 15, 2010 at 11:44, Jesse Barnes wrote:
>> On Mon, 15 Nov 2010 15:48:20 + Matthew Garrett wrote:
>>> Richard, any feedback on this?
>>
>> At KS akpm said he'd likely be taking over backlight from Richard,
>> since Richard is very distracted with other things atm (please correct
>> me if I'm wrong).
>>
>> So either someone needs to volunteer to maintain this subsystem (I know
>> how much you love backlights, maybe you'd like to do it?) or you need to
>> get this patch over to akpm.
>
> this go anywhere ?
nm, i see it was just merged. one of the things i pointed out though
is still there:
-static const char const *backlight_types[] = {
+static const char const * const backlight_types[] = {
-mike
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] Backlight: Add backlight type
On Wed, Sep 8, 2010 at 12:32, Matthew Garrett wrote:
> There may be multiple ways of controlling the backlight on a given machine.
> Allow drivers to expose the type of interface they are providing, making
> it possible for userspace to make appropriate policy decisions.
maybe i missed something, but i dont see the core validating the .type
value at registration time. since the value is then used later as an
index into an array, shouldnt it verify that it is valid ?
do you want to force everyone to declare they're "raw" ? or just go
with the memset default to have people start with "raw" ? otherwise
it might make sense to have the first enum be BACKLIGHT_UNKNOWN and
have the core warn when it hits that.
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
>
> +static const char *backlight_types[] = {
> + [BACKLIGHT_RAW] = "raw",
> + [BACKLIGHT_PLATFORM] = "platform",
> + [BACKLIGHT_FIRMWARE] = "firmware",
> +};
const char * const backlight_types[] ?
-mke
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] Backlight: Add backlight type
On Wed, Sep 8, 2010 at 12:32, Matthew Garrett wrote:
> There may be multiple ways of controlling the backlight on a given machine.
> Allow drivers to expose the type of interface they are providing, making
> it possible for userspace to make appropriate policy decisions.
maybe i missed something, but i dont see the core validating the .type
value at registration time. since the value is then used later as an
index into an array, shouldnt it verify that it is valid ?
do you want to force everyone to declare they're "raw" ? or just go
with the memset default to have people start with "raw" ? otherwise
it might make sense to have the first enum be BACKLIGHT_UNKNOWN and
have the core warn when it hits that.
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
>
> +static const char *backlight_types[] = {
> + ? ? ? [BACKLIGHT_RAW] = "raw",
> + ? ? ? [BACKLIGHT_PLATFORM] = "platform",
> + ? ? ? [BACKLIGHT_FIRMWARE] = "firmware",
> +};
const char * const backlight_types[] ?
-mke
[Intel-gfx] [PATCH] Backlight: Add backlight type
On Mon, Nov 15, 2010 at 11:44, Jesse Barnes wrote: > On Mon, 15 Nov 2010 15:48:20 + Matthew Garrett wrote: >> Richard, any feedback on this? >> > > At KS akpm said he'd likely be taking over backlight from Richard, > since Richard is very distracted with other things atm (please correct > me if I'm wrong). > > So either someone needs to volunteer to maintain this subsystem (I know > how much you love backlights, maybe you'd like to do it?) or you need to > get this patch over to akpm. this go anywhere ? -mike
[Intel-gfx] [PATCH] Backlight: Add backlight type
On Thu, Mar 24, 2011 at 02:53, Mike Frysinger wrote:
> On Mon, Nov 15, 2010 at 11:44, Jesse Barnes wrote:
>> On Mon, 15 Nov 2010 15:48:20 + Matthew Garrett wrote:
>>> Richard, any feedback on this?
>>
>> At KS akpm said he'd likely be taking over backlight from Richard,
>> since Richard is very distracted with other things atm (please correct
>> me if I'm wrong).
>>
>> So either someone needs to volunteer to maintain this subsystem (I know
>> how much you love backlights, maybe you'd like to do it?) or you need to
>> get this patch over to akpm.
>
> this go anywhere ?
nm, i see it was just merged. one of the things i pointed out though
is still there:
-static const char const *backlight_types[] = {
+static const char const * const backlight_types[] = {
-mike
[PATCH 0/9] Typo fixes of faild to failed
On Fri, Oct 22, 2010 at 01:17, Joe Perches wrote: > ?drivers/ata/pata_bf54x.c ? ? ? ? ? | ? ?2 +- > ?drivers/video/bf54x-lq043fb.c ? ? ?| ? ?6 +++--- > ?drivers/video/bfin-t350mcqb-fb.c ? | ? ?2 +- Acked-by: Mike Frysinger -mike
